| *** sridhar_ram has joined #tacker | 00:49 | |
| *** sridhar_ram has quit IRC | 00:54 | |
| *** sridhar_ram has joined #tacker | 00:54 | |
| *** bobh has joined #tacker | 00:57 | |
| *** bobh has quit IRC | 00:59 | |
| *** arturt has quit IRC | 01:07 | |
| *** arturt has joined #tacker | 01:07 | |
| *** arturt has quit IRC | 01:12 | |
| *** santoshkumark has quit IRC | 01:12 | |
| openstackgerrit | Bob Haddleton proposed stackforge/tacker: Resume VNF Monitoring after server restart https://review.openstack.org/231280 | 01:21 |
|---|---|---|
| *** arturt has joined #tacker | 01:26 | |
| *** s3wong has quit IRC | 01:35 | |
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker-horizon: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229709 | 01:37 |
| *** sridhar_ram1 has joined #tacker | 01:38 | |
| *** sridhar_ram1 has quit IRC | 01:39 | |
| *** sridhar_ram has quit IRC | 01:41 | |
| *** arturt has quit IRC | 01:41 | |
| *** arturt has joined #tacker | 01:42 | |
| *** arturt has quit IRC | 02:08 | |
| *** arturt has joined #tacker | 02:10 | |
| *** tbh has joined #tacker | 02:13 | |
| *** lhcheng has quit IRC | 02:14 | |
| *** sridhar_ram has joined #tacker | 02:31 | |
| *** arturt has quit IRC | 02:33 | |
| *** arturt has joined #tacker | 02:33 | |
| *** arturt has quit IRC | 02:38 | |
| *** tbh has quit IRC | 02:49 | |
| *** bobh has joined #tacker | 02:51 | |
| *** sridhar_ram has quit IRC | 02:54 | |
| *** lhcheng has joined #tacker | 02:56 | |
| *** lhcheng_ has joined #tacker | 02:58 | |
| *** bobh has quit IRC | 02:59 | |
| *** lhcheng has quit IRC | 03:01 | |
| *** arturt has joined #tacker | 03:34 | |
| *** arturt has quit IRC | 03:38 | |
| *** lhcheng has joined #tacker | 03:48 | |
| *** lhcheng_ has quit IRC | 03:48 | |
| *** arturt has joined #tacker | 04:35 | |
| *** arturt has quit IRC | 04:40 | |
| *** lsp42 has quit IRC | 05:03 | |
| *** trozet has quit IRC | 05:04 | |
| *** lsp42 has joined #tacker | 05:05 | |
| *** trozet has joined #tacker | 05:08 | |
| *** lhcheng_ has joined #tacker | 05:18 | |
| *** lhcheng has quit IRC | 05:21 | |
| *** tbh has joined #tacker | 05:22 | |
| *** lhcheng has joined #tacker | 05:24 | |
| *** lhcheng_ has quit IRC | 05:27 | |
| *** arturt has joined #tacker | 05:36 | |
| *** arturt has quit IRC | 05:41 | |
| *** arturt has joined #tacker | 06:47 | |
| *** arturt has quit IRC | 06:52 | |
| *** lhcheng has quit IRC | 06:52 | |
| *** lhcheng has joined #tacker | 06:53 | |
| *** lhcheng has quit IRC | 06:57 | |
| *** lhcheng has joined #tacker | 07:09 | |
| *** KLuka_ has quit IRC | 07:15 | |
| *** lhcheng has quit IRC | 07:32 | |
| *** arturt has joined #tacker | 07:48 | |
| *** arturt has quit IRC | 07:53 | |
| *** arturt has joined #tacker | 08:49 | |
| *** arturt has quit IRC | 08:53 | |
| *** arturt has joined #tacker | 09:00 | |
| *** arturt has quit IRC | 09:04 | |
| *** mbound has joined #tacker | 09:07 | |
| *** tbh has quit IRC | 09:31 | |
| *** tbh has joined #tacker | 09:47 | |
| *** arturt has joined #tacker | 10:01 | |
| *** arturt has quit IRC | 10:06 | |
| *** tbh has quit IRC | 10:51 | |
| *** arturt has joined #tacker | 11:02 | |
| *** arturt has quit IRC | 11:06 | |
| *** tbh has joined #tacker | 11:09 | |
| openstackgerrit | bharaththiruveedula proposed stackforge/tacker: HTTP ping monitor driver for Monitoring Framework https://review.openstack.org/229858 | 11:18 |
| openstackgerrit | bharaththiruveedula proposed stackforge/python-tackerclient: Limit description value in vnfd-list https://review.openstack.org/231431 | 11:34 |
| *** arturt has joined #tacker | 12:02 | |
| *** arturt has quit IRC | 12:07 | |
| *** bobh has joined #tacker | 12:08 | |
| *** tbh has quit IRC | 12:20 | |
| *** changzhi has joined #tacker | 12:39 | |
| *** bobh has quit IRC | 12:44 | |
| *** changzhi has quit IRC | 12:54 | |
| *** arturt has joined #tacker | 13:03 | |
| *** arturt has quit IRC | 13:08 | |
| *** bobh has joined #tacker | 13:22 | |
| *** trozet has quit IRC | 13:54 | |
| *** arturt has joined #tacker | 14:04 | |
| *** arturt has quit IRC | 14:08 | |
| *** trozet has joined #tacker | 14:46 | |
| *** arturt_ has joined #tacker | 15:05 | |
| *** tbh has joined #tacker | 15:05 | |
| *** arturt_ has quit IRC | 15:10 | |
| tbh | bobh: Hi | 15:14 |
| tbh | bobh: as the http ping patchset is depenedent on your patch, it says it is outdated, can you help to rebase it? | 15:15 |
| tbh | I tried to fetch your latest updates and rebase to master and fetch my updated and rebased | 15:16 |
| tbh | but it didn't work | 15:16 |
| *** sridhar_ram has joined #tacker | 15:32 | |
| bobh | tbh: Do I need to rebase my patchset? Jenkins didn't report a merge conflict | 15:42 |
| tbh | bobh: no, from my side, I have to rebase I guess | 16:00 |
| openstackgerrit | bharaththiruveedula proposed stackforge/python-tackerclient: Limit description value in vnfd-list https://review.openstack.org/231431 | 16:14 |
| *** mbound has quit IRC | 16:16 | |
| *** tbh has quit IRC | 16:20 | |
| *** tbh has joined #tacker | 16:22 | |
| *** lhcheng_ has joined #tacker | 16:47 | |
| openstackgerrit | bharaththiruveedula proposed stackforge/tacker: HTTP ping monitor driver for Monitoring Framework https://review.openstack.org/229858 | 16:51 |
| openstackgerrit | Merged stackforge/tacker-horizon: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229709 | 16:54 |
| openstackgerrit | bharaththiruveedula proposed stackforge/tacker: Modify the datatype of 'value' column https://review.openstack.org/231088 | 17:09 |
| *** s3wong has joined #tacker | 17:10 | |
| *** bobh has quit IRC | 17:22 | |
| *** bobh has joined #tacker | 17:22 | |
| *** sridhar_ram has quit IRC | 17:23 | |
| *** bobh has quit IRC | 17:29 | |
| *** tbh has quit IRC | 17:33 | |
| *** tbh has joined #tacker | 17:45 | |
| *** bobh has joined #tacker | 17:48 | |
| *** santoshkumark has joined #tacker | 17:50 | |
| *** bobh_ has joined #tacker | 17:50 | |
| *** bobh has quit IRC | 17:53 | |
| *** vishwanathj has quit IRC | 17:56 | |
| tbh | bobh_: regarding the patchset of https://review.openstack.org/#/c/229858/ | 18:10 |
| tbh | bobh_: I have changed the name based on your suggestion, but I think we must keep the acronym as it is | 18:10 |
| tbh | bobh_: as many of the other openstack projects do | 18:11 |
| tbh | bobh_: for example https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L95 | 18:11 |
| tbh | https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L75 | 18:11 |
| tbh | so I think we follow camelcase unless there is no acronym | 18:11 |
| tbh | what do you say? | 18:12 |
| *** tbh has quit IRC | 18:24 | |
| *** tbh has joined #tacker | 18:26 | |
| *** sridhar_ram has joined #tacker | 18:31 | |
| *** bobh_ has quit IRC | 18:53 | |
| *** bobh has joined #tacker | 19:21 | |
| bobh | tbh: When I looked up the guidelines for acronyms I found guidelines that indicated two-letter acronyms should remain capitalized (like IO) but longer acronyms should be put into CamelCase (like Http) | 19:23 |
| bobh | tbh: Personally I agree that VNF is better than VNF, but I will bow to the will of the community :-) | 19:23 |
| bobh | tbh: Maybe sridhar_ram can make the official pronouncement for Tacker (and make one of us submit another patchset) | 19:23 |
| bobh | #link http://stackoverflow.com/questions/15526107/acronyms-in-camelcase | 19:25 |
| bobh | s/VNF is better than VNF/VNF is better than Vnf/ | 19:27 |
| *** santoshk has joined #tacker | 19:56 | |
| bobh | except that the CamelCase rules say it isn't.... | 19:57 |
| *** santoshkumark has quit IRC | 20:00 | |
| *** lhcheng_ has quit IRC | 20:43 | |
| *** sarob has quit IRC | 20:43 | |
| *** lhcheng_ has joined #tacker | 20:46 | |
| *** sarob has joined #tacker | 20:46 | |
| *** elo1 has quit IRC | 21:11 | |
| *** bobh has quit IRC | 21:13 | |
| *** elo has joined #tacker | 21:13 | |
| *** sridhar_ram has quit IRC | 21:39 | |
| *** elo1 has joined #tacker | 21:49 | |
| *** elo has quit IRC | 21:50 | |
| *** sridhar_ram has joined #tacker | 21:55 | |
| *** trozet has quit IRC | 22:00 | |
| *** santoshk has quit IRC | 22:32 | |
| *** santoshk has joined #tacker | 22:38 | |
| *** tbh has quit IRC | 22:39 | |
| *** tbh has joined #tacker | 22:39 | |
| tbh | sridhar_ram: Hi | 22:43 |
| sridhar_ram | tbh: hi | 22:46 |
| tbh | sridhar_ram: in http_ping driver ,bobh and me were discussing about guidelines for class name for the driver | 22:48 |
| tbh | is there ny guideline to use small case even for acronyms in class name | 22:49 |
| tbh | but other openstack projects were using all caps for acronyms | 22:50 |
| tbh | for example https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L95 | 22:50 |
| tbh | https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L75 | 22:50 |
| sridhar_ram | tbh: interesting you ask this... I recently read up quite a bit on CamelCase before a recent 1 line review :) | 22:54 |
| sridhar_ram | side story, the CamelCase goes all the way to back to Microsoft glory days! | 22:54 |
| sridhar_ram | I also looked up openstack hacking guide to see if it takes a stand... | 22:55 |
| sridhar_ram | http://docs.openstack.org/developer/hacking/ | 22:55 |
| sridhar_ram | which in turn points to pep8 https://www.python.org/dev/peps/pep-0008/ | 22:56 |
| sridhar_ram | which in turn points back to the wikipedia link I read in first place at http://www.wikipedia.com/wiki/CamelCase | 22:57 |
| sridhar_ram | the conclusion is the acronyms are not to be capitalized in the official CamelCase convention | 22:57 |
| sridhar_ram | it was a revelation to me so some exent | 22:57 |
| sridhar_ram | long story short .. we use proper camelcase in *new* code .. | 22:58 |
| sridhar_ram | we don't need to bikeshed changing any old code.. | 22:58 |
| sridhar_ram | so VNF should be Vnf | 22:58 |
| sridhar_ram | sorry for the long answer :) | 22:58 |
| sridhar_ram | hang on.. pep008 actually calls out CapWords | 23:01 |
| tbh | sridhar_ram: ha, then I will change the class name | 23:07 |
| sridhar_ram | Duh.. looks pep8 is calling to capitalize acronymns ! | 23:08 |
| sridhar_ram | there is "Note:" added to clarify "HTTPServerError is better than HttpServerError" | 23:09 |
| sridhar_ram | https://www.python.org/dev/peps/pep-0008/#naming-conventions | 23:09 |
| tbh | sridhar_ram: I like that statement | 23:11 |
| tbh | :) | 23:11 |
| tbh | sridhar_ram: so we will go with the current patchset name | 23:13 |
| sridhar_ram | tbh: sounds good | 23:30 |
| tbh | sridhar_ram: I pushed couple of patchsets, when you find time can you review those patches? | 23:38 |
| sridhar_ram | tbh: sure, will do | 23:50 |
| *** mestery has quit IRC | 23:56 | |
| *** mestery has joined #tacker | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!