| *** bobh has quit IRC | 00:25 | |
| *** prashantD has quit IRC | 00:31 | |
| *** tbh has joined #tacker | 00:48 | |
| *** santoshkumark has quit IRC | 00:56 | |
| *** tbh has quit IRC | 00:58 | |
| *** tbh has joined #tacker | 01:00 | |
| *** sripriya has quit IRC | 01:19 | |
| *** s3wong has quit IRC | 01:43 | |
| *** lhcheng has quit IRC | 01:59 | |
| openstackgerrit | bharaththiruveedula proposed openstack/python-tackerclient: Fix for vnfd-delete with vnfd-name as arg https://review.openstack.org/237846 | 02:08 |
|---|---|---|
| *** tbh has quit IRC | 02:17 | |
| *** bobh has joined #tacker | 02:52 | |
| *** bobh has quit IRC | 03:16 | |
| *** lhcheng has joined #tacker | 03:19 | |
| *** bobh has joined #tacker | 03:26 | |
| *** bobh has quit IRC | 03:28 | |
| *** tbh has joined #tacker | 04:24 | |
| *** lhcheng has quit IRC | 04:39 | |
| *** sripriya has joined #tacker | 04:56 | |
| *** sridhar_ram has joined #tacker | 05:02 | |
| *** lhcheng has joined #tacker | 05:04 | |
| openstackgerrit | Imran Hayder Malik proposed openstack/tacker: Add option to generate sample conf file. https://review.openstack.org/237877 | 05:06 |
| *** sripriya_ has joined #tacker | 05:08 | |
| *** sripriya has quit IRC | 05:11 | |
| *** openstackgerrit has quit IRC | 05:16 | |
| *** openstackgerrit has joined #tacker | 05:17 | |
| *** manikanta has joined #tacker | 05:23 | |
| *** manikanta_ has joined #tacker | 05:23 | |
| *** sridhar_ram has quit IRC | 05:30 | |
| *** sridhar_ram has joined #tacker | 05:35 | |
| tbh | I feel https://bugs.launchpad.net/tacker/+bug/1508174 and https://bugs.launchpad.net/tacker/+bug/1505442 are needed for stable release from my side | 05:39 |
| openstack | Launchpad bug 1508174 in tacker "vnfd-delete without args returns 'description'" [Undecided,In progress] - Assigned to bharaththiruveedula (bharath-ves) | 05:39 |
| openstack | Launchpad bug 1505442 in tacker "monitor driver runs ping monitor only for one vdu even though monitoring policy is specified for all vdu's in template" [Undecided,Fix committed] - Assigned to vishwanath jayaraman (vishwanathj) | 05:39 |
| tbh | sorry https://bugs.launchpad.net/tacker/+bug/1506111 | 05:40 |
| openstack | Launchpad bug 1506111 in tacker "Unable to configure VDU using openwrt mgmt driver" [High,In progress] - Assigned to bharaththiruveedula (bharath-ves) | 05:40 |
| *** sridhar_ram1 has joined #tacker | 05:42 | |
| *** sridhar_ram has quit IRC | 05:43 | |
| *** lhcheng has quit IRC | 05:44 | |
| sridhar_ram1 | tbh: on #150611 does openwrt mgmt driver works okay for vnf-update or is it broken for both vnf-create & vnf-update ? | 05:56 |
| tbh | sridhar_ram1: using --config-file option , it is working in both cases | 06:04 |
| tbh | sridhar_ram1: but after service_type changes, all config options were broken | 06:04 |
| sridhar_ram1 | tbh: you mean after this fix https://review.openstack.org/#/c/234714/? | 06:07 |
| sridhar_ram1 | tbh: also, what you mean by all config options ? I'm assuming only "Direct Input" cases are broken here | 06:07 |
| tbh | sridhar_ram1: yeah that patch is actually part of the fix for configuration | 06:11 |
| tbh | all config options I mean both --config-file and --config | 06:11 |
| sridhar_ram1 | tbh: okay, that's bad... we need this in liberty | 06:12 |
| tbh | sridhar_ram1: but let me confirm once again with --config-file, but according to the code it should not work | 06:12 |
| tbh | just give me 5 mins | 06:13 |
| sridhar_ram1 | tbh: sure.. | 06:13 |
| tbh | sridhar_ram1: yeah, not working with --config-file option too | 06:20 |
| sridhar_ram1 | tbh: okay... it silently returns off https://review.openstack.org/#/c/236014/1/tacker/vm/mgmt_drivers/openwrt/openwrt.py L72 ? | 06:21 |
| tbh | sridhar_ram1: I am not sure why we moved service_types from vnf level to vdu level | 06:22 |
| sridhar_ram1 | service_properties: | 06:22 |
| sridhar_ram1 | -type | 06:22 |
| sridhar_ram1 | is at the VNFD level | 06:22 |
| sridhar_ram1 | service_type: is always in VDU level | 06:22 |
| tbh | sridhar_ram1: you mean in old patch i.e "if not service_type" | 06:23 |
| sridhar_ram1 | tbh: yes | 06:24 |
| tbh | sridhar_ram1: okay I confused with service_property -> type parameter | 06:24 |
| *** sridhar_ram1 is now known as sridhar_ram | 06:24 | |
| tbh | sridhar_ram: yeah , so we never get service_type and never get configured | 06:24 |
| sridhar_ram | tbh: in fact, I'm thinking we shd just remove the lines https://github.com/openstack/tacker/blob/master/tacker/vm/mgmt_drivers/openwrt/openwrt.py#L71-L73 | 06:25 |
| sridhar_ram | tbh: it serves no purpose | 06:25 |
| sridhar_ram | we don't actively enforce VNFD level service_properties to VDU level service_type | 06:26 |
| sridhar_ram | the design has evolved a bit.. this whole 'service_type' and 'service_context' needs some revisit / cleanup | 06:26 |
| tbh | sridhar_ram: is it not mandatory to check service_type field in vnfd? | 06:28 |
| sridhar_ram | tbh: no | 06:29 |
| tbh | sridhar_ram: I feel , if it has no signifance as of now, better not to check. In future when we have clear requirement of service type, we can add this check | 06:30 |
| tbh | sridhar_ram: am I correct? | 06:30 |
| sridhar_ram | tbh: exactly... | 06:30 |
| tbh | sridhar_ram: okay can I update the patch by removing the check for service_type? | 06:31 |
| sridhar_ram | yeah.. btw, can you verify if things are fine w/ just that before pushing a patchset ? | 06:32 |
| tbh | sridhar_ram: yeah I do that every time but with specific cases :) | 06:32 |
| sridhar_ram | tbh: :) | 06:33 |
| sridhar_ram | tbh: getting late, so signing off for the eveing... | 06:49 |
| sridhar_ram | tbh: just reviewed https://review.openstack.org/#/c/237846/ .. looks good | 06:49 |
| sridhar_ram | tbh: talk to you tomorrow | 06:49 |
| tbh | sridhar_ram: sure, thanks | 06:49 |
| tbh | sridhar_ram: see you | 06:49 |
| openstackgerrit | Imran Hayder Malik proposed openstack/tacker: Add option to generate sample conf file https://review.openstack.org/237877 | 06:59 |
| *** sridhar_ram has quit IRC | 07:16 | |
| *** karimb has joined #tacker | 07:19 | |
| *** dkusidlo has joined #tacker | 07:24 | |
| *** dkusidlo has quit IRC | 07:29 | |
| *** jongchoi has joined #tacker | 07:31 | |
| *** lhcheng has joined #tacker | 07:55 | |
| *** karimb has quit IRC | 07:59 | |
| *** lhcheng has quit IRC | 07:59 | |
| *** dkusidlo has joined #tacker | 08:24 | |
| *** jongchoi has quit IRC | 08:48 | |
| *** mbound has joined #tacker | 08:52 | |
| *** openstackgerrit has quit IRC | 09:01 | |
| *** openstackgerrit has joined #tacker | 09:02 | |
| *** karimb has joined #tacker | 09:12 | |
| *** karimb has quit IRC | 09:26 | |
| *** dkusidlo has quit IRC | 09:28 | |
| *** openstackgerrit has quit IRC | 09:31 | |
| *** openstackgerrit has joined #tacker | 09:32 | |
| openstackgerrit | bharaththiruveedula proposed openstack/tacker: Remove check for service_type in openwrt mgmt driver https://review.openstack.org/236014 | 09:58 |
| openstackgerrit | bharaththiruveedula proposed openstack/tacker: Remove check for service_type in openwrt mgmt driver https://review.openstack.org/236014 | 10:00 |
| *** lhcheng has joined #tacker | 10:07 | |
| *** lhcheng has quit IRC | 10:12 | |
| *** Avinash has joined #tacker | 11:46 | |
| *** karimb has joined #tacker | 12:04 | |
| *** openstackgerrit has quit IRC | 12:16 | |
| *** openstackgerrit has joined #tacker | 12:17 | |
| *** Avinash has quit IRC | 12:28 | |
| *** Avinash has joined #tacker | 12:43 | |
| *** Avinash has quit IRC | 12:55 | |
| *** trozet has quit IRC | 13:02 | |
| *** tbh has quit IRC | 13:10 | |
| *** bobh has joined #tacker | 13:17 | |
| *** Avinash has joined #tacker | 13:26 | |
| *** trozet has joined #tacker | 13:50 | |
| *** Avinash has quit IRC | 13:55 | |
| *** manikanta has quit IRC | 14:07 | |
| *** manikanta_ has quit IRC | 14:07 | |
| *** jongchoi has joined #tacker | 14:09 | |
| *** zeih has joined #tacker | 14:18 | |
| *** zeih has quit IRC | 14:23 | |
| *** jongchoi has quit IRC | 14:28 | |
| *** zeih has joined #tacker | 14:46 | |
| *** zeih has quit IRC | 14:50 | |
| *** lhcheng has joined #tacker | 15:33 | |
| *** tbh has joined #tacker | 15:35 | |
| *** sridhar_ram has joined #tacker | 15:44 | |
| *** Avinash has joined #tacker | 15:54 | |
| *** sridhar_ram1 has joined #tacker | 15:54 | |
| *** sridhar_ram has quit IRC | 15:54 | |
| *** sridhar_ram1 is now known as sridhar_ram | 15:56 | |
| *** arturt has joined #tacker | 15:57 | |
| *** Avinash2 has joined #tacker | 15:58 | |
| *** Avinash has quit IRC | 16:01 | |
| *** Avinash2 has quit IRC | 16:06 | |
| *** tbh has quit IRC | 16:12 | |
| *** tbh has joined #tacker | 16:14 | |
| *** bobh has quit IRC | 16:25 | |
| *** elo has quit IRC | 16:37 | |
| *** arturt has quit IRC | 16:50 | |
| *** elo has joined #tacker | 16:50 | |
| *** s3wong has joined #tacker | 17:31 | |
| *** santoshkumark has joined #tacker | 17:47 | |
| *** karimb has quit IRC | 17:51 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds devref for vnfd parameterization support https://review.openstack.org/232912 | 17:55 |
| sridhar_ram | sripriya_: few (hopefully quick) review requests - https://review.openstack.org/#/c/237846/ (vnfd delete CLI) and https://review.openstack.org/#/c/232912/ (param devref) | 18:06 |
| sridhar_ram | tbh: ping | 18:12 |
| tbh | sridhar_ram: Hi | 18:12 |
| sridhar_ram | tbh: https://review.openstack.org/#/c/236014 .. looks good. need one related help ... | 18:13 |
| sridhar_ram | tbh: looks you are fixing things related to config_yaml in the update case | 18:13 |
| sridhar_ram | tbh: there is a dead code in the create case that needs to be removed | 18:13 |
| sridhar_ram | tbh: it will be great to fold that into this patchset .. | 18:14 |
| tbh | sridhar_ram: sure, let me check | 18:14 |
| sridhar_ram | tbh: great, thanks... I'm leaving a comment as we speak | 18:15 |
| tbh | sridhar_ram: sure | 18:16 |
| sridhar_ram | This whole block is not needed... https://github.com/openstack/tacker/blob/master/tacker/vm/drivers/heat/heat.py#L304-L319 | 18:16 |
| tbh | I think you are talking about this | 18:18 |
| tbh | https://github.com/openstack/tacker/blob/master/tacker/vm/drivers/heat/heat.py#L304-L318 | 18:18 |
| tbh | sorry, Yeah same thing | 18:18 |
| tbh | I will remove it | 18:18 |
| sripriya_ | sridhar_ram: ack, will take it up today | 18:18 |
| sridhar_ram | sripriya_: thanks! | 18:27 |
| sridhar_ram | tbh: we are in sync, I've left comments in gerrit .. | 18:27 |
| sridhar_ram | tbh: in short - yank off all config_yaml handling in heat.py | 18:28 |
| sridhar_ram | tbh: that is not the place to handle | 18:28 |
| *** lhcheng has quit IRC | 18:28 | |
| *** lhcheng has joined #tacker | 18:29 | |
| *** lhcheng has quit IRC | 18:30 | |
| tbh | sridhar_ram: but we are finding diff of new yaml and old yaml to update in heat.py | 18:33 |
| sridhar_ram | tbh: line # ? | 18:35 |
| tbh | sridhar_ram: https://github.com/openstack/tacker/blob/master/tacker/vm/drivers/heat/heat.py#L408-L412 | 18:36 |
| * sridhar_ram trying to make sense of this code | 18:38 | |
| *** sripriya_ has quit IRC | 18:40 | |
| sridhar_ram | tbh: this logic need to move up to plugin.py in device_update().. . looks the code itself is not harm but lets take it later.. Please leave a TODO comment in there | 18:43 |
| tbh | sridhar_ram: then I think we cannot remove the logic "if config_yaml is None:" in update method which is in the patchset | 18:45 |
| sridhar_ram | tbh: hmm.. then I'd vote to remove the whole block...https://github.com/openstack/tacker/blob/master/tacker/vm/drivers/heat/heat.py#L386-L412 | 18:47 |
| sridhar_ram | tbh: leave a TODO in the plugin update command to introduce a diff logic at a later time | 18:48 |
| sridhar_ram | tbh: what do you think ? | 18:48 |
| *** s3wong has quit IRC | 18:53 | |
| *** s3wong has joined #tacker | 18:53 | |
| tbh | sridhar_ram: yeah makes sense, but was thinking the reason for the code in heat.py | 18:54 |
| *** sripriya has joined #tacker | 19:07 | |
| *** lhcheng has joined #tacker | 19:07 | |
| *** lhcheng_ has joined #tacker | 19:08 | |
| *** lhcheng has quit IRC | 19:12 | |
| sripriya | tbh: are you planning to take care of the retry logic for openwrt? | 19:13 |
| tbh | sripriya: in the same patchset? | 19:13 |
| tbh | sripriya: I think it will fit here https://review.openstack.org/#/c/234741/ | 19:14 |
| sripriya | tbh: that should be fine | 19:15 |
| tbh | sripriya: I will update the patchset | 19:15 |
| sripriya | tbh: thank you! really appreciate it | 19:16 |
| tbh | sripriya: :) | 19:16 |
| *** bobh has joined #tacker | 19:22 | |
| *** tbh has quit IRC | 19:34 | |
| *** tbh has joined #tacker | 19:39 | |
| *** tbh has quit IRC | 19:48 | |
| sridhar_ram | tbh: sripriya: please plan the retry logic in a separate patchset .. | 20:12 |
| sridhar_ram | tbh: sripriya: boot_wait seems a self contained and it seem ready to merge .. adding more logic will delay this patchset | 20:12 |
| sripriya | sridhar_ram: ok | 20:23 |
| *** bobh has quit IRC | 20:47 | |
| *** arturt has joined #tacker | 20:51 | |
| *** jongchoi_ has joined #tacker | 21:11 | |
| *** s3wong has quit IRC | 21:28 | |
| *** s3wong has joined #tacker | 21:32 | |
| *** trozet has quit IRC | 21:36 | |
| *** sripriya_ has joined #tacker | 21:41 | |
| *** sripriya has quit IRC | 21:44 | |
| *** s3wong_ has joined #tacker | 21:55 | |
| *** s3wong has quit IRC | 21:55 | |
| *** s3wong_ is now known as s3wong | 21:56 | |
| *** arturt has quit IRC | 21:57 | |
| *** jongchoi_ has quit IRC | 22:02 | |
| *** santoshk has joined #tacker | 22:03 | |
| *** sripriya has joined #tacker | 22:03 | |
| *** jongchoi_ has joined #tacker | 22:06 | |
| *** santoshkumark has quit IRC | 22:06 | |
| *** sripriya_ has quit IRC | 22:06 | |
| *** jongchoi_ has quit IRC | 22:10 | |
| *** lhcheng_ has quit IRC | 22:17 | |
| *** sridhar_ram has quit IRC | 22:31 | |
| *** sripriya_ has joined #tacker | 22:32 | |
| *** lhcheng has joined #tacker | 22:33 | |
| *** sridhar_ram has joined #tacker | 22:33 | |
| *** sripriya has quit IRC | 22:35 | |
| *** sridhar_ram has quit IRC | 22:42 | |
| *** sridhar_ram has joined #tacker | 22:44 | |
| *** sridhar_ram has quit IRC | 23:03 | |
| *** sripriya has joined #tacker | 23:05 | |
| *** sridhar_ram has joined #tacker | 23:06 | |
| *** sripriya_ has quit IRC | 23:07 | |
| *** dmellado has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!