| *** leecalcote has joined #tacker | 00:10 | |
| *** karimb has quit IRC | 00:21 | |
| *** uck has quit IRC | 00:31 | |
| *** uck has joined #tacker | 00:35 | |
| *** leecalcote has quit IRC | 00:43 | |
| *** uck has quit IRC | 00:46 | |
| *** tbh has joined #tacker | 00:50 | |
| *** lhcheng_ has quit IRC | 00:52 | |
| *** arturt has quit IRC | 01:01 | |
| *** mbound_ has quit IRC | 01:31 | |
| gongysh | vishwanathj, sure | 01:34 |
|---|---|---|
| sripriya | tbh: ping | 01:35 |
| tbh | sripriya, Hi | 01:36 |
| *** arturt has joined #tacker | 01:36 | |
| sripriya | tbh: regarding https://review.openstack.org/#/c/257360/ , we will need to fix the workflow a bit for vnf-upate scenario than setting it to error state | 01:37 |
| sripriya | tbh: until and unless the actually deep update config failed on the vnf instance, we should not be setting the VNF to ERROR state | 01:38 |
| sripriya | actual* | 01:38 |
| sripriya | tbh: in this particular case, the update failed because of the parsing logic in heat which may be because the user input for config was wrong, The VNF otherwise is still ACTIVE | 01:39 |
| tbh | sripriya, yes but according to the logs, vnf is still in pending update state | 01:41 |
| sripriya | tbh: we should not transition the VNF status to PENDING_UPDATE until the user input is validated | 01:41 |
| tbh | because of the issue in _update_device_post | 01:41 |
| tbh | sripriya, so I thought of first remove that issue in _update_device_post | 01:42 |
| tbh | sripriya, yes | 01:42 |
| sripriya | tbh: we should not set the VNF to PENDING_UPDATE in db before parsing user's input | 01:43 |
| sripriya | and is validated | 01:43 |
| sripriya | tbh: rathe the parsing exception should prompt the user with the actual cause of the error than updating the db with ERROR state | 01:44 |
| sripriya | rather* | 01:44 |
| sripriya | tbh: it basically means move the _update_device_pre after the heat parse logic in update_device in plugin file | 01:46 |
| sripriya | tbh: and remove the _update_device_post call in Exception | 01:47 |
| sripriya | tbh: provide a userful message to the user in the Exception | 01:48 |
| *** tbh has quit IRC | 01:49 | |
| *** tbh has joined #tacker | 01:50 | |
| tbh | sripriya, I was thinking of test case to make it fail in update() in heat.py | 01:51 |
| tbh | sripriya, so we better raise an exception instead of setting the state to ERROR? | 01:52 |
| vishwanathj | gongysh, hi | 01:52 |
| tbh | here https://github.com/openstack/tacker/blob/master/tacker/vm/plugin.py#L310 | 01:52 |
| vishwanathj | gongysh, FYI:I will update the VNF placement with my updates in a couple hours | 01:53 |
| sripriya | tbh: try with a badly parsed config file in vnf-update operation | 01:53 |
| sripriya | tbh: yes! | 01:53 |
| sripriya | tbh: or try with the config file reported in the bug | 01:53 |
| sripriya | tbh: i will leave these comments in gerrit, let me know if you have any questions | 01:54 |
| tbh | sripriya, I have tried with reorted files | 01:55 |
| tbh | sripriya, those files are working for me | 01:55 |
| sripriya | tbh: i see | 01:55 |
| tbh | sripriya, I will manually raise exception in heat.py to test this case? | 01:55 |
| sripriya | tbh: sure you can , also try with an ill formed yaml that may break the logic | 01:56 |
| tbh | sripriya, okay | 01:58 |
| *** changzhi has joined #tacker | 01:59 | |
| sripriya | tbh: we will need to thoroughly test these changes, as we do not have func. test cases for vnf-update or for mgmt driver config update yet in our jenkins | 01:59 |
| sripriya | tbh: along with normal vnf-create with config and vnf with monitoring | 02:00 |
| *** amotoki has joined #tacker | 02:03 | |
| *** amotoki_ has joined #tacker | 02:05 | |
| *** amotoki has quit IRC | 02:09 | |
| tbh | sripriya, I want to push these changes along with a unit test | 02:17 |
| *** sridhar_ram has quit IRC | 02:19 | |
| *** sripriya has quit IRC | 02:19 | |
| gongysh | vishwanathj, thanks | 02:33 |
| *** s3wong has quit IRC | 02:40 | |
| *** tbh has quit IRC | 02:40 | |
| *** gongysh_ has joined #tacker | 02:44 | |
| *** gongysh_ has quit IRC | 02:53 | |
| *** arturt has quit IRC | 02:55 | |
| *** arturt has joined #tacker | 02:57 | |
| *** amotoki_ has quit IRC | 02:57 | |
| *** prashantD has quit IRC | 03:05 | |
| *** arturt has quit IRC | 03:13 | |
| *** arturt has joined #tacker | 03:23 | |
| *** amotoki has joined #tacker | 03:47 | |
| *** amotoki has quit IRC | 03:50 | |
| *** amotoki has joined #tacker | 03:56 | |
| *** amotoki_ has joined #tacker | 04:02 | |
| *** amotoki has quit IRC | 04:05 | |
| *** arturt has quit IRC | 04:07 | |
| openstackgerrit | gongysh proposed openstack/python-tackerclient: Allow passing in infra and mgmt drivers https://review.openstack.org/255146 | 04:13 |
| *** lhcheng has joined #tacker | 04:22 | |
| *** tbh has joined #tacker | 04:24 | |
| *** lhcheng_ has joined #tacker | 04:26 | |
| *** lhcheng has quit IRC | 04:28 | |
| *** lhcheng_ has quit IRC | 04:35 | |
| *** gongysh_ has joined #tacker | 04:48 | |
| *** gongysh_ has quit IRC | 04:52 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker-specs: Enhanced VNF placements blue print https://review.openstack.org/257847 | 04:58 |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker-specs: Enhanced VNF placements blue print https://review.openstack.org/257847 | 05:00 |
| *** gongysh_ has joined #tacker | 05:01 | |
| openstackgerrit | Merged openstack/python-tackerclient: Deprecated tox -downloadcache option removed https://review.openstack.org/256716 | 05:39 |
| *** gongysh_ has quit IRC | 05:43 | |
| *** arturt has joined #tacker | 06:08 | |
| *** sarob has quit IRC | 06:10 | |
| *** sarob has joined #tacker | 06:11 | |
| *** sripriya has joined #tacker | 06:26 | |
| *** arturt has quit IRC | 06:45 | |
| *** sripriya has quit IRC | 07:50 | |
| *** denismakogon_ has joined #tacker | 07:59 | |
| *** denismakogon__ has joined #tacker | 08:02 | |
| *** denismakogon_ has quit IRC | 08:04 | |
| *** denismakogon_ has joined #tacker | 08:05 | |
| *** zeih has joined #tacker | 08:06 | |
| *** denismakogon__ has quit IRC | 08:08 | |
| *** denismakogon__ has joined #tacker | 08:08 | |
| *** zeih has quit IRC | 08:10 | |
| *** denismakogon_ has quit IRC | 08:11 | |
| *** denismakogon has joined #tacker | 08:11 | |
| *** denismakogon__ has quit IRC | 08:12 | |
| *** denismakogon__ has joined #tacker | 08:16 | |
| *** denismakogon has quit IRC | 08:17 | |
| *** zeih has joined #tacker | 08:18 | |
| *** denismakogon__ has quit IRC | 08:19 | |
| *** zeih has quit IRC | 08:23 | |
| *** egonzalez has joined #tacker | 08:23 | |
| *** gperal has joined #tacker | 08:28 | |
| *** zeih has joined #tacker | 08:48 | |
| *** zeih has quit IRC | 08:52 | |
| *** amotoki_ has quit IRC | 09:06 | |
| *** karimb has joined #tacker | 09:17 | |
| *** zeih has joined #tacker | 09:26 | |
| *** amotoki has joined #tacker | 09:33 | |
| *** amotoki has quit IRC | 09:44 | |
| *** mbound_ has joined #tacker | 09:45 | |
| *** openstackgerrit has quit IRC | 09:47 | |
| *** openstackgerrit has joined #tacker | 09:48 | |
| *** tbh has quit IRC | 09:51 | |
| *** tbh has joined #tacker | 09:53 | |
| *** lhcheng has joined #tacker | 09:53 | |
| *** lhcheng_ has joined #tacker | 09:57 | |
| *** lhcheng has quit IRC | 09:59 | |
| *** mbound_ has quit IRC | 10:06 | |
| *** masterbound has joined #tacker | 10:06 | |
| *** mbound_ has joined #tacker | 10:09 | |
| *** masterbound has quit IRC | 10:09 | |
| openstackgerrit | Martin Oemke proposed openstack/tacker: Fix H404 errors in tacker code https://review.openstack.org/258937 | 10:43 |
| *** mbound_ has quit IRC | 10:50 | |
| *** mbound_ has joined #tacker | 10:55 | |
| openstackgerrit | Martin Oemke proposed openstack/tacker: [WIP] Fix H404 errors in tacker code https://review.openstack.org/258937 | 10:56 |
| *** mbound_ has quit IRC | 10:59 | |
| *** lhcheng has joined #tacker | 11:06 | |
| *** lhcheng__ has joined #tacker | 11:09 | |
| *** lhcheng_ has quit IRC | 11:09 | |
| zeih | hey tackers, do anyone know documentation of the mgmt_drivers/abstract_driver.py? | 11:11 |
| *** lhcheng has quit IRC | 11:11 | |
| *** mbound_ has joined #tacker | 11:12 | |
| *** changzhi has quit IRC | 11:13 | |
| *** mbound_ has quit IRC | 11:25 | |
| *** zeih has quit IRC | 11:37 | |
| *** zeih has joined #tacker | 12:03 | |
| *** zeih has quit IRC | 12:08 | |
| *** mbound_ has joined #tacker | 12:29 | |
| *** amotoki has joined #tacker | 12:43 | |
| *** amotoki has quit IRC | 12:46 | |
| *** KLuka_ has joined #tacker | 12:53 | |
| *** gongysh has quit IRC | 13:02 | |
| *** gongysh has joined #tacker | 13:02 | |
| *** zeih has joined #tacker | 13:11 | |
| *** tbh has quit IRC | 13:11 | |
| *** mbound_ has quit IRC | 13:35 | |
| *** lhcheng has joined #tacker | 13:36 | |
| *** lhcheng__ has quit IRC | 13:40 | |
| openstackgerrit | Martin Oemke proposed openstack/tacker: [WIP] Fix H404 errors in tacker code https://review.openstack.org/258937 | 13:52 |
| *** lhcheng_ has joined #tacker | 14:01 | |
| *** lhcheng has quit IRC | 14:04 | |
| openstackgerrit | Martin Oemke proposed openstack/tacker: [WIP] Fix H404 and H402 errors in tacker code https://review.openstack.org/258937 | 14:06 |
| *** lhcheng_ has quit IRC | 14:13 | |
| *** mbound_ has joined #tacker | 14:28 | |
| *** lhcheng has joined #tacker | 14:40 | |
| *** lhcheng_ has joined #tacker | 14:49 | |
| *** lhcheng has quit IRC | 14:52 | |
| *** bobh has joined #tacker | 15:06 | |
| openstackgerrit | Martin Oemke proposed openstack/tacker: Fix H404, H402, H405 errors in tacker code https://review.openstack.org/258937 | 15:09 |
| *** bobh has quit IRC | 15:12 | |
| *** gperal has quit IRC | 15:19 | |
| *** sridhar_ram has joined #tacker | 15:37 | |
| *** zeih has quit IRC | 15:39 | |
| *** bobh has joined #tacker | 15:52 | |
| *** zeih has joined #tacker | 15:55 | |
| *** zeih has quit IRC | 16:00 | |
| *** mbound_ has quit IRC | 16:01 | |
| *** mbound_ has joined #tacker | 16:03 | |
| *** bobh_ has joined #tacker | 16:05 | |
| *** egonzalez has quit IRC | 16:06 | |
| *** vishwana_ has joined #tacker | 16:07 | |
| *** bobh has quit IRC | 16:08 | |
| *** sridhar_ram has quit IRC | 16:09 | |
| *** vishwanathj has quit IRC | 16:09 | |
| *** bobh_ has quit IRC | 16:22 | |
| *** mbound_ has quit IRC | 16:25 | |
| *** mbound_ has joined #tacker | 16:25 | |
| *** bobh_ has joined #tacker | 16:28 | |
| *** bobh_ has quit IRC | 16:43 | |
| *** bobh has joined #tacker | 16:44 | |
| *** s3wong has joined #tacker | 17:01 | |
| *** mbound_ has quit IRC | 17:32 | |
| *** bobh_ has joined #tacker | 17:34 | |
| *** bobh has quit IRC | 17:38 | |
| *** sripriya has joined #tacker | 17:39 | |
| *** s3wong has quit IRC | 17:45 | |
| *** prashantD has joined #tacker | 17:46 | |
| *** bobh_ has quit IRC | 17:51 | |
| *** lhcheng has joined #tacker | 18:01 | |
| *** bobh_ has joined #tacker | 18:05 | |
| *** lhcheng_ has quit IRC | 18:05 | |
| *** karimb has quit IRC | 18:10 | |
| *** zeih has joined #tacker | 18:11 | |
| sripriya | zeih: ping | 18:12 |
| *** zeih has quit IRC | 18:16 | |
| *** bobh_ has quit IRC | 18:22 | |
| *** zeih has joined #tacker | 18:38 | |
| *** s3wong has joined #tacker | 18:39 | |
| *** zeih has quit IRC | 18:43 | |
| *** prashantD has quit IRC | 19:38 | |
| *** prashantD has joined #tacker | 19:40 | |
| *** bobh_ has joined #tacker | 19:40 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker-specs: Enhanced VNF placements blue print https://review.openstack.org/257847 | 19:42 |
| *** bobh__ has joined #tacker | 19:43 | |
| *** sridhar_ram has joined #tacker | 19:44 | |
| *** bobh_ has quit IRC | 19:46 | |
| *** bobh__ has quit IRC | 20:00 | |
| *** sridhar_ram has quit IRC | 20:01 | |
| *** bobh_ has joined #tacker | 20:04 | |
| *** sridhar_ram has joined #tacker | 20:04 | |
| *** bobh_ has quit IRC | 20:21 | |
| *** zeih has joined #tacker | 20:26 | |
| *** zeih has quit IRC | 20:31 | |
| *** bobh_ has joined #tacker | 20:42 | |
| *** sridhar_ram has quit IRC | 20:43 | |
| *** sripriya_ has joined #tacker | 20:43 | |
| *** sridhar_ram has joined #tacker | 20:44 | |
| *** sripriya has quit IRC | 20:47 | |
| *** bobh has joined #tacker | 20:50 | |
| *** bobh_ has quit IRC | 20:53 | |
| *** mbound_ has joined #tacker | 21:07 | |
| *** mbound_ has quit IRC | 21:08 | |
| *** mbound_ has joined #tacker | 21:16 | |
| *** karimb has joined #tacker | 21:26 | |
| *** bobh has quit IRC | 21:39 | |
| *** bobh has joined #tacker | 21:39 | |
| *** bobh has quit IRC | 21:39 | |
| *** bobh has joined #tacker | 21:40 | |
| *** bobh has quit IRC | 21:45 | |
| vishwana_ | lhcheng, hi | 21:57 |
| lhcheng | vishwana_: hello! | 21:59 |
| vishwana_ | lhcheng, currently, tacker-horizon has no unit tests, was wondering if you could help us with setting up the basic test framework for tacker-horizon... | 22:02 |
| vishwana_ | what are your throughts? we could work jointly or better yet, if you know horizon developers looking to work in NFV area and could point them towards tacker, it would help as well. | 22:05 |
| lhcheng | vishwana_: it would probably just involve copying some file over and config | 22:05 |
| lhcheng | I can take a stab at writing one unit test, if that work should be easy to write the test | 22:06 |
| lhcheng | hmm most horizon developers are looking for work in angular area :/ | 22:07 |
| vishwana_ | lhcheng, that would be awesome, thanks a lot | 22:07 |
| vishwana_ | lhcheng, pardon my ignorance, since when has angular been part of horizon framework? my question could be wrong too | 22:09 |
| lhcheng | might not have time to do it soon though, maybe next yr | 22:09 |
| lhcheng | if you could open a bug in tacker, and assign to me, that would be helpful | 22:09 |
| lhcheng | so I can track and remember what I need to do | 22:09 |
| lhcheng | hmm the effort has started 1.5 yrs ago | 22:10 |
| lhcheng | but the angular development has been extremely slow | 22:10 |
| vishwana_ | lhcheng, I dont mind waiting till next year :) that is 2.5 weeks away | 22:10 |
| lhcheng | so far only the launch instance is on angular | 22:10 |
| lhcheng | there are a lot of patch in flight at the moment to update other panels in angular | 22:10 |
| lhcheng | tbh, I prefer writing the plugin in django | 22:11 |
| vishwana_ | lhcheng, I see... I will make sure to open a bug..... | 22:11 |
| lhcheng | you have to wrote 10x the amount of code for angular vs django :/ | 22:11 |
| vishwana_ | lhcheng, Ok, I was going to ask why....so more code in angular as compared to django....I see... | 22:12 |
| lhcheng | don't think django code will go away, since other projects have already written their stuff in django | 22:12 |
| vishwana_ | what's the benefit of angular? | 22:12 |
| lhcheng | richer client app | 22:12 |
| lhcheng | most of the code will be in javascript | 22:13 |
| lhcheng | the hope was to have a single page app | 22:13 |
| lhcheng | and enable a richer ui | 22:13 |
| vishwana_ | I see | 22:13 |
| lhcheng | I am not the right person to ask about the benefits of angular, coz I prefer to keep the django code | 22:13 |
| lhcheng | :P | 22:14 |
| *** zeih has joined #tacker | 22:15 | |
| *** zeih has quit IRC | 22:20 | |
| vishwana_ | lhcheng, I opened the bug https://bugs.launchpad.net/tacker/+bug/1527406 ... not able to assign the bug to you using your launch pad id ==> lin-hua-cheng | 22:34 |
| openstack | Launchpad bug 1527406 in tacker "Unit test framework missing in tacker-horizon module" [Undecided,New] | 22:34 |
| *** karimb has quit IRC | 22:37 | |
| *** zeih has joined #tacker | 22:42 | |
| lhcheng | vishwana_: got it | 22:46 |
| *** zeih has quit IRC | 22:47 | |
| vishwana_ | lhcheng, thanks | 22:48 |
| *** karimb has joined #tacker | 22:50 | |
| *** bobh has joined #tacker | 22:50 | |
| *** bobh has quit IRC | 22:57 | |
| *** zeih has joined #tacker | 23:09 | |
| *** prashantD_ has joined #tacker | 23:10 | |
| *** prashantD has quit IRC | 23:10 | |
| *** zeih has quit IRC | 23:14 | |
| *** zeih has joined #tacker | 23:37 | |
| *** zeih has quit IRC | 23:41 | |
| *** tbh has joined #tacker | 23:46 | |
| *** mbound_ has quit IRC | 23:51 | |
| *** lhcheng has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!