Wednesday, 2016-03-16

« Tuesday, 2016-03-15 Index Thursday, 2016-03-17 »
*** openstack has joined #tacker00:26
*** bobh has joined #tacker00:43
*** sripriya_ has quit IRC00:44
*** bobh has quit IRC00:58
*** bobh has joined #tacker01:11
*** vishwanathj has joined #tacker01:37
*** sripriya has joined #tacker01:39
*** s3wong has quit IRC01:44
*** mannidi_ has joined #tacker01:59
*** bobh has quit IRC02:08
*** lhcheng has quit IRC02:19
*** sripriya has quit IRC02:27
*** sripriya has joined #tacker02:28
*** sridhar_ram has joined #tacker02:31
*** sridhar_ram has quit IRC02:41
*** uck has joined #tacker02:52
*** lhcheng has joined #tacker02:54
*** uck has quit IRC03:25
*** vishnoianil has quit IRC03:31
*** gongysh has joined #tacker03:34
gongyshvishwanathj, got it03:34
vishwanathjgongysh ack03:46
gongyshvishwanathj, so it seems we have to wait the tosca integration, right?03:47
vishwanathjgongysh bobh does already have code for tosca integration, we have a dependency on tbh patchset that depends on toscal integration, so our code is mostly upto date with what tbh and bobh have except for missing unit tests03:48
vishwanathjbobh will have an updated patchset tomorrow per the IRC meeting today03:49
gongyshvishwanathj, ok03:49
vishwanathjhowever, our changes may not be too much dependent at this time on bobh and tbh is my analysis and opinion03:50
vishwanathjI mean that if they make changes to their patchset, we may not have to make too many changes03:50
gongyshvishwanathj, I saw that, our patch is small.03:51
vishwanathjit maybe small but provides lots of functionality/features03:52
gongyshvishwanathj, agree03:52
vishwanathjgongysh I am beginning to think/brainstorm what test cases may need to be added for our feature, would appreciate if you could also focus in that area. Thanks03:59
gongyshunittests?04:00
vishwanathjgongysh yes04:00
* gongysh away for meeting04:03
*** gongysh has quit IRC04:04
*** vishwanathj has quit IRC04:05
*** vishnoianil has joined #tacker04:30
*** mannidi_ has quit IRC04:38
*** lhcheng has quit IRC04:38
*** lhcheng has joined #tacker05:10
*** vishwanathj has joined #tacker05:31
*** vishwanathj has quit IRC05:31
*** sridhar_ram has joined #tacker05:31
*** sridhar_ram has quit IRC05:42
*** dkushwaha_ has quit IRC05:44
*** deepakcs has joined #tacker05:48
*** vishwanathj has joined #tacker05:48
*** vishwanathj has quit IRC05:51
*** dkushwaha has joined #tacker05:58
*** lhcheng has quit IRC06:10
*** gongysh has joined #tacker06:19
*** vishwanathj has joined #tacker06:34
*** vishwanathj is now known as vishwanathj_zzz06:35
sripriyagongysh: hello06:44
gongyshsripriya, hi06:44
sripriyagongysh: i was trying to understadn your comment in nfvo_plugin for L69 AND l7506:44
sripriya*understand06:45
gongyshURL, please06:45
sripriyagongysh: https://review.openstack.org/#/c/285096/5/tacker/services/nfvo/nfvo_plugin.py06:45
gongyshsripriya, this is about atomic operation.06:46
gongyshsripriya, obviously, we are doing one thing in two steps.06:46
sripriyagongysh: can you pl help me explain?06:48
gongyshsripriya,  @log.log06:50
gongysh    def delete_vim(self, context, vim_id):06:50
gongysh        vim_obj = self.get_vim(context, vim_id)06:50
gongysh        self._vim_driver.invoke(vim_obj['type'], 'delete_auth', vim_id=vim_id)06:50
gongysh        super(NfvoPlugin, self).delete_vim(context, vim_id)06:50
gongyshif self._vim_driver.invoke(vim_obj['type'], 'delete_auth', vim_id=vim_id) suceed, but super(NfvoPlugin, self).delete_vim(context, vim_id) failed, we will have a inconsistent state.06:51
sripriyagongysh: understood, will fix the 2 calls. thanks06:55
*** lhcheng has joined #tacker07:06
*** lhcheng has quit IRC07:55
openstackgerritdharmendra kushwaha proposed openstack/python-tackerclient: Help message correction  https://review.openstack.org/29329708:01
*** zeih has joined #tacker08:54
*** Ravikiran_K has joined #tacker08:58
*** mbound has joined #tacker09:10
*** mannidi has joined #tacker09:46
*** openstackgerrit has quit IRC09:53
*** openstackgerrit_ is now known as openstackgerrit09:53
*** openstackgerrit has quit IRC09:53
*** openstackgerrit_ has joined #tacker09:54
*** openstackgerrit_ is now known as openstackgerrit09:54
*** openstackgerrit_ has joined #tacker09:55
*** openstackgerrit has quit IRC09:55
*** openstackgerrit has joined #tacker09:56
*** tbh has joined #tacker10:03
*** mannidi_ has joined #tacker10:44
*** mannidi has quit IRC10:48
*** gongysh has quit IRC11:01
*** openstackgerrit has quit IRC11:18
*** openstackgerrit has joined #tacker11:19
*** tbh has quit IRC11:22
*** tbh has joined #tacker11:36
*** zeih has quit IRC11:49
*** zeih has joined #tacker11:49
*** zeih has quit IRC11:54
*** zeih has joined #tacker11:54
*** zeih has quit IRC12:09
*** zeih has joined #tacker12:11
*** gubouvier has joined #tacker12:39
*** gubouvier has quit IRC12:48
*** gubouvier has joined #tacker12:50
*** gubouvier has quit IRC12:50
*** gubouvier has joined #tacker12:51
*** bobh has joined #tacker13:10
*** zeih has quit IRC13:12
*** mannidi_ has quit IRC13:18
*** zeih has joined #tacker13:20
*** deepakcs has quit IRC13:35
*** zeih has quit IRC13:47
*** zeih has joined #tacker13:54
*** vishnoianil has quit IRC13:55
*** zeih has quit IRC13:58
tbhbobh, Hi14:02
bobhtbh: hello14:07
tbhbobh, as part of func tests for flavor creation, I feel it is similar to https://github.com/openstack/tacker/blob/master/tacker/tests/functional/vnfm/test_vnf.py14:07
tbhbobh, but I need to give tosca nfv template and introduce openstackclient to check for new flavor?14:08
tbhbobh, am I right?14:08
bobhtbh: that sounds right - it depends on how far you want to take the test - you could verify that it has been properly added to the heat template without actually deploying the heat template, or you can take it all the way to deployment and verify that the correct flavor gets created and that the VM is using it14:09
bobhtbh: that would be ideal but it may be a lot of work to get there14:09
tbhbobh, ah I have two cases now 1)check correct flavor created 2)Check the flavor  got attached to the VM14:11
tbhbobh, I will try this for single VDU for now14:11
bobhtbh: I think it is sufficient to verify that the VM was created successfully - assuming that you have verified the template assigned the new flavor to the VM14:12
bobhtbh: that's fine - if it works for one VDU then multiple should not be a problem14:12
tbhsure, I will do that. Thanks for the help bobh14:14
bobhtbh: np14:14
*** tbh has quit IRC14:16
*** zeih has joined #tacker14:21
*** zeih has quit IRC14:27
*** zeih has joined #tacker14:45
*** zeih has quit IRC14:58
*** mbound has quit IRC15:22
*** zeih has joined #tacker15:32
*** vishwanathj_zzz is now known as vishwanathj15:38
*** uck has joined #tacker15:53
vishwanathjbobh hi...had a tosca parser related question15:58
bobhvishwanathj: Hi - sure15:59
vishwanathjbobh does the tosca parser do schema validation and throw an error if any of the key words are not recognized in the VNFD template15:59
bobhvishwanathj: yes - it will fail if the template does not match the schema definition16:00
vishwanathjcool...that's why it is important to update the tacker_defs.yaml and tacker_nfv_defs.yaml with any tacker specific parameters/attributes, right?16:01
bobhvishwanathj: yep - users can't just make stuff up :-)16:02
vishwanathjawesome16:02
*** sridhar_ram has joined #tacker16:03
*** dkushwaha_ has joined #tacker16:07
*** prashantD has joined #tacker16:21
*** vishnoianil has joined #tacker16:22
*** lhcheng has joined #tacker16:31
*** tbh has joined #tacker16:46
openstackgerritbharaththiruveedula proposed openstack/tacker: [WIP]Implements unit test cases for auto resource feature  https://review.openstack.org/29303216:46
vishwanathjtbh Hi16:50
tbhvishwanathj, Hi16:50
vishwanathjtbh the usual practice is to include unit tests as part of the code patchset ...16:50
vishwanathjwas curious as to the the reasoning for delivering unit tests as a separate patchset from the code patchset16:52
*** uck has quit IRC16:52
tbhvishwanathj, no particular reason, just tried to divide individual tasks16:53
vishwanathjtbh I see...my recommendation would be to have the code and the associated tests as part of same code patch set, I would like to hear from the cores bobh sridhar_ram and sripriya their opinion as well17:00
*** sripriya has quit IRC17:00
vishwanathjtbh some reviewers also run unit tests associated with the code in their environment as well....so heads up I will be giving a -1 to have unit tests associated with code patch set17:17
tbhvishwanathj, okay I will abandon the unit tests patch17:21
*** sridhar_ram1 has joined #tacker17:21
*** sridhar_ram has quit IRC17:22
vishwanathjtbh thanks that will make review easy17:22
openstackgerritbharaththiruveedula proposed openstack/tacker: [WIP] Implements auto image creation  https://review.openstack.org/29203417:25
*** sripriya has joined #tacker17:27
*** tbh has quit IRC17:27
*** zeih has quit IRC17:30
sripriyasridhar_ram1: just responded to your question the server patch. i'm fixing the attributes in vim resource. i had one clarification regarding tenant_name/tenant_id.17:36
*** tbh has joined #tacker17:36
sridhar_ram1sripriya: thanks.. will look it up17:36
sripriyasridhar_ram1: thank you17:37
vishwanathjbobh hi17:41
*** tbh has quit IRC17:44
*** vishwanathj is now known as vishwanathj_chow17:45
*** tbh has joined #tacker17:45
*** tbh has quit IRC17:46
*** tbh has joined #tacker17:47
*** s3wong has joined #tacker17:48
*** tbh has quit IRC17:51
*** tbh has joined #tacker17:52
*** tbh has quit IRC17:56
bobhvishwanathj_chow: hello17:57
*** zeih has joined #tacker17:58
openstackgerritbharaththiruveedula proposed openstack/tacker: [WIP] Implements auto flavor creation  https://review.openstack.org/29075117:59
openstackgerritbharaththiruveedula proposed openstack/tacker: [WIP] Implements auto image creation  https://review.openstack.org/29203418:10
*** prashantD has quit IRC18:13
*** tbh has joined #tacker18:18
*** dkushwaha_ has quit IRC18:29
*** tbh has quit IRC18:32
*** tbh has joined #tacker18:34
*** tbh has quit IRC18:34
*** tbh has joined #tacker18:36
*** tbh has quit IRC18:37
*** tbh has joined #tacker18:38
*** tbh has quit IRC18:38
*** tbh has joined #tacker18:39
*** tbh has quit IRC18:40
*** tbh has joined #tacker18:43
*** tbh has quit IRC18:46
*** vishnoianil has quit IRC18:46
*** vishwanathj_chow is now known as vishwanathj19:01
*** dkushwaha_ has joined #tacker19:13
vishwanathjbobh sorry was out at lunch when you responded...19:14
dkushwaha_vishwanathj, hi19:15
vishwanathjbobh I needed some guidance/help creating tosca.dataypes for cpu_allocation properties and numa nodes19:15
bobhvishwanathj: ok19:16
vishwanathjbobh give me some time, I will put up my template on paste.openstack.org and ask you questions/guidance on where I need help19:16
vishwanathjdkushwaha_ hi19:16
dkushwaha_vishwanathj, Could you please respond to https://bugs.launchpad.net/tacker/+bug/150336719:16
openstackLaunchpad bug 1503367 in tacker "Validation check missing for parameters value file" [Wishlist,New] - Assigned to dharmendra (dharmendra-kushwaha)19:16
bobhvishwanathj: ok19:16
vishwanathjdkushwaha_ the bug referenced above was opened back in October of last year when we did not have TOSCA parser integration with Tacker...19:18
*** vishnoianil has joined #tacker19:19
vishwanathjdkushwaha_ let me see if with using tosca parser, if the bug is still applicable, give me time till Friday...is that OK?19:19
dkushwaha_vishwanathj, yes. its fine.19:20
dkushwaha_vishwanathj, thanks19:20
*** sridhar_ram1 has quit IRC19:24
dkushwaha_bobh, sripriya Could you please review the patch-set https://review.openstack.org/#/c/269424/19:34
sripriyadkushwaha_: sure19:35
vishwanathjbobh Please take a look at http://paste.openstack.org/show/490782/19:44
vishwanathjbobh I will have questions/clarifications based on above link19:44
bobhvishwanathj: ok - heading to a meeting in 15 but I'll be online later tonight19:44
vishwanathjbobh ok ping me when you are available for a chat...thanks19:45
bobhvishwanathj: one thing I noticed right away - I would add constraints for valid string values (like "avoid") and ranges of integer values for counts, if appropriate19:45
bobhvishwanathj: basically don't let me use any value that you know won't work19:46
vishwanathjbobh yes, that's what I would need help with, i.e how to specify constraints (is there a reference guide)...19:46
bobhvishwanathj: #link http://docs.oasis-open.org/tosca/TOSCA-Simple-Profile-YAML/v1.0/TOSCA-Simple-Profile-YAML-v1.0.html19:47
vishwanathjbobh also, on lines 35 and 39, the names have to be just a string and does not have to be exactly node0 or node1....how would I model that19:47
bobhvishwanathj: all of the datatype definition keywords are described in there19:48
vishwanathjbobh I see19:48
bobhvishwanathj: I would model the id/vcpus/memory as a datatype and then have numa_nodes defined as a map of that datatype19:49
vishwanathjbobh yes, modelling the id/vcpus/memory as a datatype makes sense....defining that as a map would allow to accept arbitrary values such as "node0" , "node1"?19:50
bobhvishwanathj: I believe so - I can look at it more closely when I get back19:51
vishwanathjbobh thanks19:52
*** zeih has quit IRC20:09
openstackgerritdharmendra kushwaha proposed openstack/tacker: Fixing assignment-from-no-return issue.  https://review.openstack.org/29369520:19
*** dkushwaha_ has quit IRC20:30
*** sridhar_ram has joined #tacker20:44
vishwanathjbobh when you are free, take a look at http://paste.openstack.org/show/490799/ to see if it looks better than the last iteration...Thanks20:53
bobhvishwanathj: LGTM - the big question is does it parse?21:10
*** lhcheng has quit IRC21:12
*** uck has joined #tacker21:15
vishwanathjbobh let me try it out....need to setup devstack with your and tbh changes21:17
vishwanathjbobh is there a way to specify that if parameter X is specified then parameter Y be present as well?21:20
*** lhcheng has joined #tacker21:33
sridhar_rambobh: I've started reviewing your patchsets...21:34
sridhar_rambobh: .. beyond unit tests are any other (major) changes expected in your next patchset ?21:35
bobhvishwanathj: I don't think there is a way to do cross-parameter validation in the definitions21:35
vishwanathjbobh thanks21:35
bobhsridhar_ram: no - a few minor changes but mostly tests at this point21:35
sridhar_rambobh: sounds good21:36
*** sridhar_ram1 has joined #tacker22:00
*** sridhar_ram has quit IRC22:01
openstackgerritvishwanath jayaraman proposed openstack/tacker: Implements the Enhanced VNF placement blueprint  https://review.openstack.org/26929522:39
*** sridhar_ram1 has quit IRC22:41
*** bobh has quit IRC22:59
*** vishwanathj has quit IRC23:06
*** sridhar_ram has joined #tacker23:09
openstackgerritvishwanath jayaraman proposed openstack/tacker: Implements the Enhanced VNF placement blueprint  https://review.openstack.org/26929523:21
« Tuesday, 2016-03-15 Index Thursday, 2016-03-17 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!