Wednesday, 2016-03-23

« Tuesday, 2016-03-22 Index Thursday, 2016-03-24 »
*** sridhar_ram has joined #tacker00:28
sridhar_rams3wong: we have an urgent patchset to review / merge .. https://review.openstack.org/#/c/29611100:31
sridhar_rams3wong: going to push a client release.. better to get this in00:32
sridhar_rams3wong: can you please take a look ?00:32
vishwanathjsripriya hi00:34
s3wongsridhar_ram: sure00:36
vishwanathjsripriya I was wondering if the tacker/tests/unit/base.py that is part of your Multi-Site code is independent enough that it can be committed and merged separately, I was hoping to reuse the code functionality in that file00:37
*** sripriya has quit IRC00:40
openstackgerritMerged openstack/python-tackerclient: Fix attr for vim update  https://review.openstack.org/29611100:41
*** sridhar_ram has quit IRC01:03
*** lhcheng has quit IRC01:04
*** bobh has joined #tacker01:31
*** bobh has quit IRC01:32
*** bobh has joined #tacker01:37
*** prashantD__ has quit IRC01:43
*** bobh has quit IRC01:52
*** s3wong has quit IRC01:59
*** bobh has joined #tacker02:04
*** lhcheng has joined #tacker02:29
openstackgerritBob Haddleton proposed openstack/tacker: Implement tosca-parser/heat-translator integration  https://review.openstack.org/27812103:08
*** bobh has quit IRC03:09
*** lhcheng has quit IRC03:42
*** prashantD has joined #tacker04:02
*** sripriya has joined #tacker04:05
*** sripriya_ has joined #tacker04:07
*** sripriya has quit IRC04:09
openstackgerritvishwanath jayaraman proposed openstack/tacker: Implements the Enhanced VNF placement blueprint  https://review.openstack.org/26929504:10
*** lhcheng_ has joined #tacker04:21
*** tbh has joined #tacker04:27
vishwanathjtbh Hi...when you get a chance review my comments to bobh patchset https://review.openstack.org/#/c/278121/16/tacker/tests/unit/vm/infra_drivers/heat/test_heat.py04:32
tbhvishwanathj, done04:38
*** lhcheng has joined #tacker04:39
*** lhcheng_ has quit IRC04:39
vishwanathjtbh what do you mean by getting rid of multiple variable declarations?04:40
tbhvishwanathj, https://review.openstack.org/#/c/290751/17/tacker/tests/unit/vm/infra_drivers/heat/test_heat.py L60 - L7304:41
tbhvishwanathj,  https://review.openstack.org/#/c/269295/21/tacker/tests/unit/vm/infra_drivers/heat/test_heat.py       L74 -L9704:42
tbhvishwanathj, I was worrying about this04:42
vishwanathjtbh yes, that would be beneficial if we dont want to do that...good suggestion...if you can also give a pointer to bobh on what needs to be one, it would be good and he can have a turnaround patch in short time04:42
tbhvishwanathj, sure04:43
vishwanathjtbh does he need to modify the _get_expected_fields_tosca() method to take template as a parameter?04:44
tbhvishwanathj, in the current bobh patchset, that method is not accepting any extra param04:47
vishwanathjcorrect04:48
vishwanathjI see the hard coding in L210 https://review.openstack.org/#/c/278121/16/tacker/tests/unit/vm/infra_drivers/heat/test_heat.py04:49
vishwanathjI mean its not hard coding from his perspective, since we are leveraging his function, we want the template passed as a parameter04:50
tbhvishwanathj, yes, that's true04:52
vishwanathjtbh please review my latest patchset as well, thanks04:57
tbhvishwanathj, sure, I am doing that05:03
*** sridhar_ram has joined #tacker05:16
sridhar_ramgongysh: ping05:22
sridhar_ramtbh: vishwanathj: ping05:32
tbhsridhar_ram, pong05:32
* vishwanathj hopefully tbh is around to take sridhar_ram query05:33
sridhar_ramfolks - I'm looking at https://review.openstack.org/#/c/278121...05:33
sridhar_ramand see your -1s05:33
sridhar_ramare these issues flagged are blockers ?05:34
sridhar_ramIf there are areas of code that we could make it perfect, let's use follow-on patchsets to do that. We really need to wrap this one fast / ASAP05:34
tbhsridhar_ram, not exactly. but it will be nice if we have generic methods in unit tests05:34
sridhar_ramWe really need few days *after this patch merge* to handle any major integration issues. Otherwise we risk releasing a buggy Mitaka release.05:35
*** prashantD has quit IRC05:35
sridhar_ramtbh: I see. Is this something we can handle in a follow on patchset ?05:35
vishwanathjsridhar_ram, its a minor code change that impacts bobh, tbh and my tests...05:35
tbhsridhar_ram, it will be couple of line change05:35
vishwanathjif its handled at bobh patchset, we do not risk braking bobh patchset or future enhancements/additions05:36
sridhar_ramvishwanathj: I understand. I'm trying to differentiate between MUST HAVE and NICE TO HAVE... if it is later lets use follow-on patchsets please05:37
*** lhcheng has quit IRC05:39
sridhar_ramso it is just a matter of dropping "tosca_" and use it in the actual file name ?05:39
vishwanathjsridhar_ram, understand your concern given the situation....I would border it around MUST HAVE, if bobh does not make the change, one of tbh or I have to make the change05:39
tbhsridhar_ram, that's true, we can do that in a follow on patchset05:40
sridhar_ramvishwanathj: I would still vote to have you / tbh take care if possible...05:40
tbhvishwanathj, yes that will be fine. instead I will make those changes in my patchset. what do you say sridhar_ram ?05:40
sridhar_ramtbh: that will be great.. do flag it in bobh's patchset .. I kinda feel bad to push it like this...05:41
tbhsridhar_ram, sure, I will add those changes05:41
vishwanathjtbh let me have a word with bobh tomorrow, because I took the liberty of asking him to make the change, dont want to cause confusion05:41
sridhar_ramvishwanathj: fair enough.. either case, I'll wait for tbh and your's +1 to start working towards landing it05:42
vishwanathjok05:43
sridhar_rammy guidance is - punt non-critical things off to later bug fix..05:43
sridhar_ramwe have a generous post-mitaka cycle to do bug fixing ..05:43
sridhar_ramtbh: vishwanathj: thanks for your understanding... ! I'm quite glad you both took care of doing this detailed review of this whole tosca-parser track..05:44
sridhar_ramappreciate it guys :)05:44
sridhar_ramgongysh: are you there ?05:47
tbhsridhar_ram, :)05:55
tbhsridhar_ram, I will just  just add few comments on what we thought, and will remove -105:55
sridhar_ramtbh: thanks!05:56
*** lhcheng has joined #tacker06:29
openstackgerritSantosh Kodicherla proposed openstack/tacker: Adding vnf create/delete testcase with VIM id Closes-Bug: #1560812  https://review.openstack.org/29620706:46
openstackbug 1560812 in tacker "Automate vnf creation with VIM ID" [Undecided,New] https://launchpad.net/bugs/156081206:46
*** sridhar_ram has quit IRC06:46
openstackgerritbharaththiruveedula proposed openstack/tacker: Implements auto flavor creation  https://review.openstack.org/29075106:46
openstackgerritSantosh Kodicherla proposed openstack/tacker: Adding vnf create/delete testcase with VIM id Closes-Bug: #1560812  https://review.openstack.org/29620706:49
openstackbug 1560812 in tacker "Automate vnf creation with VIM ID" [Undecided,In progress] https://launchpad.net/bugs/1560812 - Assigned to Santosh (ksantosh-cs)06:49
*** vishnoianil has quit IRC07:05
*** vishwanathj is now known as vishwanathj_away07:12
*** sridhar_ram has joined #tacker07:19
*** sridhar_ram has quit IRC07:19
*** vishnoianil has joined #tacker07:32
*** lhcheng has quit IRC07:39
*** lhcheng has joined #tacker07:51
*** zeih has joined #tacker07:55
*** tbh has quit IRC08:31
*** mbound has joined #tacker08:34
*** DaveJ__ has joined #tacker08:38
DaveJ__Hi Guys, is there any example VNFD for tacker that describe a complex VNF i.e. one with multiple VMs08:38
*** lhcheng has quit IRC08:39
*** tbh has joined #tacker08:43
*** openstackgerrit has quit IRC09:03
*** openstackgerrit has joined #tacker09:04
*** zeih_ has joined #tacker09:13
*** zeih has quit IRC09:13
*** lhcheng has joined #tacker10:28
*** lhcheng has quit IRC10:33
*** zeih_ has quit IRC10:58
*** zeih has joined #tacker11:57
*** janki91 has joined #tacker12:19
*** tbh has quit IRC12:48
*** mbound has quit IRC12:49
*** zeih has quit IRC12:58
*** zeih has joined #tacker13:19
*** mbound has joined #tacker13:20
*** trozet_ has joined #tacker13:26
*** bobh has joined #tacker13:55
*** bobh has quit IRC13:55
*** bobh has joined #tacker13:55
vishwanathj_awayDaveJ__ find a sample at link https://github.com/openstack/tacker/blob/master/devstack/samples/sample-vnfd-multi-vdu.yaml that tacker team had uploaded as part of Liberty release13:57
vishwanathj_awaybobh good morning13:57
DaveJ__Excellent, thanks13:57
*** openstack has joined #tacker14:24
*** zeih has quit IRC14:50
*** janki91 has quit IRC14:51
*** janki91 has joined #tacker14:51
bobhvishwanathj_away: hello14:54
vishwanathj_awaybobh please ignore tbh and my comments to https://review.openstack.org/#/c/278121/16/tacker/tests/unit/vm/infra_drivers/heat/test_heat.py14:58
vishwanathj_awaybobh are there going to be anymore patchset uploads from you?14:59
bobhvishwanathj_away: I think it's pretty much done - there are always more things to do but this is probably a good place to stop for now15:05
*** sripriya_ has quit IRC15:06
*** vishwanathj_ has joined #tacker15:26
*** vishwanathj_ has left #tacker15:27
*** vishwanathj_ has joined #tacker15:29
vishwanathj_bobh did the complex data types work for you?15:30
bobhIt appears to be using the monitoring type successfully15:32
vishwanathj_bobh did you have to make any definition changes to make it work?15:36
bobhvishwanathj_: not that I can remember15:36
vishwanathj_Ok15:36
*** zeih has joined #tacker15:47
*** sridhar_ram has joined #tacker15:50
*** prashantD has joined #tacker15:56
*** sridhar_ram1 has joined #tacker15:57
*** zeih has quit IRC16:10
*** zeih has joined #tacker16:13
sridhar_ram1bobh: hi there.. I'm catching up the irclogs...16:18
sridhar_ram1bobh: looks like you wrapped up  https://review.openstack.org/#/c/278121/ for this round ?16:18
sridhar_ram1I was "encouraging" tbh and vishwanathj_away to consider taking up further tune up in follow on fixes...16:19
*** bobh has quit IRC16:20
janki91please review my patch16:23
janki91https://review.openstack.org/#/c/294573/16:23
*** prashantD_ has joined #tacker16:32
*** prashantD has quit IRC16:35
*** lhcheng has joined #tacker16:35
*** zeih has quit IRC16:37
*** vishwanathj_away is now known as vishwanathj16:39
*** sripriya has joined #tacker17:02
*** zeih has joined #tacker17:06
*** vishnoianil has quit IRC17:08
*** zeih has quit IRC17:10
*** zeih has joined #tacker17:10
*** prashantD_ has quit IRC17:24
*** prashantD has joined #tacker17:32
*** mbound has quit IRC17:36
*** mbound has joined #tacker17:38
*** vishnoianil has joined #tacker17:40
*** s3wong has joined #tacker17:45
*** mbound has quit IRC17:51
*** vishwanathj_ has quit IRC17:54
*** zeih has quit IRC18:00
*** zeih has joined #tacker18:01
*** sridhar_ram has quit IRC18:04
*** prashantD has quit IRC18:06
*** janki91 has quit IRC18:12
*** prashantD has joined #tacker18:18
*** tbh1 has joined #tacker18:20
*** zeih has quit IRC18:24
*** sridhar_ram1 is now known as sridhar_ram18:37
*** openstack has joined #tacker19:24
*** tbh1 has quit IRC19:44
sripriyas3wong: ping19:46
s3wongsripriya: pong19:46
sripriyas3wong: can you please help review multisite server patch at https://review.openstack.org/#/c/285096/19:47
sripriyas3wong: hoping to wrap it up soon if things look good19:47
s3wongsripriya: OK... also need to review trozet_'s patch19:48
sripriyas3wong: sure thanks19:48
s3wongsripriya: yours look like a big patch19:48
s3wong:-)19:48
s3wong+1607...19:48
*** zeih_ has joined #tacker19:49
sripriyas3wong: :) we can also look at it as just 1607 lines! ;)19:49
s3wongsripriya: :-)19:49
*** zeih_ has quit IRC19:54
sridhar_rams3wong: didn't mean to say sfc is not important but multisite is for mitaka which is wrapping in few days. you may want to help that one first!19:59
s3wongsridhar_ram: sure19:59
*** zeih_ has joined #tacker20:07
*** openstack has joined #tacker20:34
*** trozet_ is now known as trozet20:39
openstackgerritSantosh Kodicherla proposed openstack/tacker: Adding vnf create/delete testcase with VIM id  https://review.openstack.org/29620720:52
openstackgerritSantosh Kodicherla proposed openstack/tacker: Adding vnf create/delete testcase with VIM id  https://review.openstack.org/29620720:54
openstackgerritSantosh Kodicherla proposed openstack/tacker: Adding vnf create/delete testcase with VIM id  https://review.openstack.org/29620720:55
openstackgerritSantosh Kodicherla proposed openstack/tacker: Adding testcase for create and delete of VIM.  https://review.openstack.org/29669621:02
*** sridhar_ram_ has joined #tacker21:09
*** zeih has quit IRC21:09
*** zeih_ has quit IRC21:52
*** vishnoianil has quit IRC21:56
*** zeih has joined #tacker21:59
*** mannidi_ has joined #tacker22:04
*** bobh has joined #tacker22:06
*** mannidi__ has quit IRC22:07
*** mannidi_ has quit IRC22:11
*** lhcheng_ has joined #tacker22:16
*** zeih has quit IRC22:18
*** lhcheng_ has quit IRC22:19
*** lhcheng__ has joined #tacker22:19
*** lhcheng has quit IRC22:20
vishwanathjbobh hi22:26
vishwanathjbobh with your current patchset uploaded, the only nit I see is an extra tab that is highlighted at L64 in file  https://review.openstack.org/#/c/278121/16/tacker/vm/tosca/lib/tacker_defs.yaml ... from my side, I am ready to give a +122:28
sripriyalhcheng__: ping22:34
lhcheng__hi sripriya22:34
sripriyalhcheng__: can you please help review horizon patch at: https://review.openstack.org/#/c/289614/22:35
lhcheng__sure22:35
sripriyalhcheng__: thank you22:35
lhcheng__sripriya: would be nice to have real tests on that patch22:41
lhcheng__sripriya: I haven't got the change to write test for one panel.. I don't have much time on openstack right now, I got re-assigned to do non-openstack work :(22:42
sripriyalhcheng__: sure i understand, i need to take a look at horizon unit tests to be familiar with the fixtures and unit test framework to write unit tests for tacker horizon code22:50
lhcheng__sripriya: I will try to write one test when I get the chance, what the simplest panel?22:51
sripriyalhcheng__: vnfcatalog22:51
sripriyalhcheng__: i can surely follow up with a RFE for the vim panel unit tests22:52
*** DaveJ__ has quit IRC23:09
*** zeih has joined #tacker23:12
*** sridhar_ram_ has quit IRC23:14
*** zeih has quit IRC23:18
*** sripriya has quit IRC23:19
*** openstack has joined #tacker23:25
*** sridhar_ram has quit IRC23:27
*** santoshk has quit IRC23:31
*** sridhar_ram has joined #tacker23:53
*** sridhar_ram has quit IRC23:59
« Tuesday, 2016-03-22 Index Thursday, 2016-03-24 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!