| *** uck has quit IRC | 00:01 | |
| *** prashantD_ has quit IRC | 00:11 | |
| openstackgerrit | Sridhar Ramaswamy proposed openstack/tacker: Add blueprint only tacker development process https://review.openstack.org/352663 | 00:19 |
|---|---|---|
| *** prashantD_ has joined #tacker | 00:19 | |
| *** vishnoianil has quit IRC | 00:32 | |
| *** trozet has quit IRC | 00:54 | |
| sridhar_ram | sripriya: ping | 01:01 |
| sripriya | sridhar_ram: pong | 01:06 |
| sridhar_ram | sripriya: need ur opinion on https://review.openstack.org/#/c/331130 .. making name mandatory | 01:06 |
| *** trozet has joined #tacker | 01:06 | |
| sridhar_ram | sripriya: fix works fine, now shd we deprecate "--name" instead of removing it.. ? | 01:07 |
| sridhar_ram | sripriya: thoughts ? | 01:07 |
| sridhar_ram | worried many CLI users will trip with newton release | 01:07 |
| *** bobh has joined #tacker | 01:07 | |
| sridhar_ram | bobh: ^^^ | 01:07 |
| sripriya | sridhar_ram: on the api level, we did not deprecate it, we just made it mandatory in master | 01:07 |
| sridhar_ram | bobh: i remember u insisted on making name mandatory.. | 01:08 |
| bobh | sridhar_ram: I missed the line above the ^^^ | 01:08 |
| sridhar_ram | sripriya: okay, so API and Horizon are indeed mandatory.. looks CLI is the only hold out.. | 01:08 |
| sripriya | sridhar_ram: yes… | 01:08 |
| sridhar_ram | bobh: will replay.. | 01:08 |
| sridhar_ram | bobh: need ur opinion on https://review.openstack.org/#/c/331130 .. making name mandatory | 01:09 |
| sridhar_ram | bobh: fix works fine, now shd we deprecate "--name" instead of removing it.. ? | 01:09 |
| sridhar_ram | bobh: thoughts? | 01:09 |
| sridhar_ram | bobh: worried many CLI users will trip with newton release | 01:09 |
| bobh | sridhar_ram: reminds me a lot of https://review.openstack.org/#/c/211232/ :-) | 01:09 |
| sridhar_ram | sripriya: i'm hearing to not both deprecation.. instead go ahead w/ making it mandatory ? | 01:09 |
| sridhar_ram | bobh: indeed.. remember, i came a full circle on this.. | 01:10 |
| bobh | sridhar_ram: good ideas never die... | 01:11 |
| sridhar_ram | bobh: LOL | 01:11 |
| sripriya | sridhar_ram: yes, in this case it would just prompt the user to enter the name if not provided. the general too few arguments error | 01:11 |
| sripriya | sridhar_ram: not very hard to figure out the typical optional vs positional arguments | 01:12 |
| sridhar_ram | sripriya: okay.. let's proceed then | 01:12 |
| sridhar_ram | bobh: sripriya: thanks! | 01:12 |
| sridhar_ram | i can imagine bobh brimming being vindicated | 01:13 |
| * bobh grin | 01:13 | |
| *** s3wong has quit IRC | 01:35 | |
| *** dkushwaha has quit IRC | 01:50 | |
| openstackgerrit | Sripriya Seetharam proposed openstack/tacker: Introduce uniqueness constraint on resource names https://review.openstack.org/329759 | 02:04 |
| openstackgerrit | Sripriya Seetharam proposed openstack/tacker: Introduce uniqueness constraint on resource names https://review.openstack.org/329759 | 02:08 |
| *** sripriya has quit IRC | 02:12 | |
| *** gongysh has joined #tacker | 02:15 | |
| *** prashantD_ has quit IRC | 02:17 | |
| vishwanathj | gongysh good morning | 02:21 |
| gongysh | vishwanathj, hi | 02:22 |
| vishwanathj | gongysh need your help .... | 02:22 |
| gongysh | vishwanathj, my honour, what is that? | 02:22 |
| vishwanathj | gongysh I see that as part of patchset https://review.openstack.org/#/c/325089/4/tacker/db/api.py by you.... | 02:23 |
| openstackgerrit | Merged openstack/python-tackerclient: Make VNFD/VNF/VIM Name Mandatory in Tacker CLI https://review.openstack.org/331130 | 02:23 |
| vishwanathj | gongysh refer https://github.com/openstack/tacker/blob/master/tacker/db/api.py#L29.... | 02:24 |
| openstackgerrit | Merged openstack/tacker: Password Mask for debug logs. https://review.openstack.org/348480 | 02:24 |
| vishwanathj | gongysh can you explain how cfg.CONF.database is used? | 02:25 |
| openstackgerrit | Lu lei proposed openstack/tacker: Fix formats for doc's information https://review.openstack.org/341281 | 02:25 |
| gongysh | vishwanathj, context_manager needs these information to connect db. | 02:27 |
| gongysh | vishwanathj, are you meaning why it is cfg.CONF.database instead of cfg.CONF.others? | 02:28 |
| vishwanathj | Do i need to update the tacker.conf file or someother file to provide that information? and what would that information look like? | 02:28 |
| gongysh | vishwanathj, no, it is already there by oslo db. | 02:28 |
| vishwanathj | gongysh I dont know anything about that...however, I am making get_engine() call in my patchset at L129 https://review.openstack.org/#/c/329652/14/tacker/db/api.py .... | 02:29 |
| vishwanathj | I am getting the error -> 'oslo_config.cfg.NoSuchOptError: no such option database in group [DEFAULT]'...not sure what I need to do to fix it | 02:29 |
| gongysh | vishwanathj, [database] | 02:29 |
| gongysh | connection = mysql+pymysql://root:root@127.0.0.1/tacker?charset=utf8 | 02:29 |
| gongysh | which patchset? | 02:30 |
| vishwanathj | https://review.openstack.org/#/c/329652/14/tacker/db/api.py L129 | 02:30 |
| vishwanathj | in which file is the entry above expected? | 02:31 |
| vishwanathj | gongysh the /etc/tacker/tacker.conf already has the entry that you are referring above - connection = mysql+pymysql://root:devstack@127.0.0.1/tacker?charset=utf8 in the database section | 02:32 |
| gongysh | vishwanathj, by the way, can you organize your patchset in their order? for example part1: xxxx, part2: yyy, if yyy depends on xxxx and both are used to finish one feature. so that reviewer can follow the order. | 02:32 |
| gongysh | vishwanathj, let's have a look. | 02:33 |
| vishwanathj | gongysh there is an inbuilt ordering in patchsets as well...if you click on the parent gitweb you will know the parent of the patchset | 02:33 |
| vishwanathj | also clicking on the topic will show all the related patchsets | 02:34 |
| gongysh | as a reviewers, I like to click on the related patchsets which will not leave the gerrit site. | 02:36 |
| gongysh | but the related patchsets show no dependencies. | 02:36 |
| vishwanathj | ok | 02:37 |
| vishwanathj | per the http://docs.openstack.org/infra/manual/developers.html depends-on is used for cross-repo dependencies.....however, I dont mind using that to see if it would make it better for reviewers | 02:39 |
| gongysh | vishwanathj, I am not asking for depends-on. and my idea is just a suggestion. | 02:41 |
| vishwanathj | gongysh good suggestion, definitely your suggestion would make it easy for reviewers no doubt...if I was a reviewer, I would be confused too | 02:42 |
| vishwanathj | gongysh the error message seems to indicate that it is looking for the entry in [DEFAULT] section | 02:43 |
| gongysh | vishwanathj, give me a while | 02:44 |
| vishwanathj | gongysh sure...thanks a lot | 02:45 |
| vishwanathj | gongysh the full stack trace is here http://paste.openstack.org/show/553740/ | 02:47 |
| *** vishwanathj_ has joined #tacker | 02:54 | |
| *** sripriya has joined #tacker | 02:55 | |
| gongysh | vishwanathj, in general, you are using different cfg.CONF in cli and api. | 02:56 |
| vishwanathj | Hhmmmm....this is the first time I am working with the CLI...how were you able to figure that out? | 02:57 |
| vishwanathj | gongysh the command I am trying to test out is 'tacker-db-manage purge_deleted vnf' | 03:00 |
| gongysh | vishwanathj, what do you mean by 'tacker-db-manage purge_deleted vnf'? | 03:01 |
| vishwanathj | gongysh let me step back and provide background on what I am trying to do......the patchset https://review.openstack.org/#/c/329652/ is to support purging of deleted entries in VNF, VNFD and VIM databases that are aged over a certain period of time | 03:03 |
| vishwanathj | the changes in the api.py and cli.py are to support that effort | 03:03 |
| gongysh | vishwanathj, I got it. you are trying to purge the old records in vnf and its related tables. | 03:04 |
| vishwanathj | yes | 03:04 |
| vishwanathj | gongysh the cli.py and api.py are both importing "from oslo_config import cfg" | 03:07 |
| gongysh | vishwanathj, you can pass in the CONF from cli to api | 03:09 |
| gongysh | vishwanathj, and let https://github.com/openstack/tacker/blob/master/tacker/db/api.py#L29 to use your passed CONF instead of system global cfg.CONF. | 03:11 |
| openstackgerrit | Lu lei proposed openstack/python-tackerclient: Base OpenStackClient(OSC) plugin support https://review.openstack.org/348124 | 03:11 |
| vishwanathj | looks like the cli.py is using cfg.ConfigOpts() and the api.py is using cfg.CONF..... | 03:12 |
| vishwanathj | gongysh, let me try your suggestion....thanks for your guidance | 03:12 |
| gongysh | vishwanathj, you are welcome | 03:12 |
| vishwanathj | Will be out for a while, be back in 2 hours and try it out | 03:12 |
| *** sripriya has quit IRC | 03:13 | |
| openstackgerrit | Tim Rozet proposed openstack/tacker: [WIP] Implements VNFFG into NFVO https://review.openstack.org/344522 | 03:15 |
| trozet | sridhar_ram: I just pushed a new revision of hte patch | 03:16 |
| trozet | sridhar_ram: I removed the cylical constraint, fixed some bugs, added some unit tests. Next will add more unit tests and then fix the things we talked about today | 03:18 |
| *** dkushwaha has joined #tacker | 03:31 | |
| *** trozet has quit IRC | 03:32 | |
| *** links has joined #tacker | 03:37 | |
| *** amotoki has quit IRC | 03:39 | |
| *** KanagarajM has joined #tacker | 03:40 | |
| *** sridhar_ram has quit IRC | 03:47 | |
| *** KanagarajM has quit IRC | 03:49 | |
| *** sridhar_ram has joined #tacker | 03:50 | |
| *** bobh has quit IRC | 03:51 | |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Name of the exception is corrected https://review.openstack.org/353828 | 04:04 |
| *** vishwanathj has quit IRC | 04:20 | |
| *** vishwanathj has joined #tacker | 04:21 | |
| *** sripriya has joined #tacker | 04:22 | |
| *** KanagarajM has joined #tacker | 04:23 | |
| gongysh | sripriya, hi | 04:24 |
| gongysh | can you help to review the three parts of device renaming? | 04:24 |
| sripriya | gongysh: sure | 04:24 |
| gongysh | sripriya, it is a big change, if we hold it a long time, it will conflict with many other patchsets newly merged. | 04:25 |
| *** janki has joined #tacker | 04:27 | |
| sridhar_ram | trozet: ack, good progress...! | 04:33 |
| sripriya | gongysh: yes, features are getting reviewed as a priority but will keep this in review queue. | 04:34 |
| sridhar_ram | gongysh: what is your take on this? There are 3 patchsets associated with this bug. Is this something you can help to wrap ? | 04:46 |
| openstackgerrit | Lu lei proposed openstack/python-tackerclient: Base OpenStackClient(OSC) plugin support https://review.openstack.org/348124 | 04:50 |
| *** vishnoianil has joined #tacker | 04:50 | |
| *** sripriya has quit IRC | 04:52 | |
| *** dkushwaha has quit IRC | 05:00 | |
| *** vishnoianil has quit IRC | 05:05 | |
| *** vishnoianil has joined #tacker | 05:17 | |
| openstackgerrit | Lu lei proposed openstack/python-tackerclient: Base OpenStackClient(OSC) plugin support https://review.openstack.org/348124 | 05:28 |
| *** vishwanathj_ has quit IRC | 05:36 | |
| *** afranc has quit IRC | 05:48 | |
| *** afranc has joined #tacker | 05:49 | |
| gongysh | sridhar_ram, hi | 05:49 |
| sridhar_ram | gongysh: hi | 05:51 |
| gongysh | sridhar_ram, I just want to make it simple and integration unit on one patch. | 05:52 |
| gongysh | sridhar_ram, those three parts, first is on db name from device into vnf, device_template into vnfd. | 05:52 |
| gongysh | sridhar_ram, second part is to remove unused one file which is heavily using device and device_template in codes. | 05:53 |
| gongysh | sridhar_ram, third part is rename all of device, device_template into vnf, vnfd in codes and test codes. | 05:53 |
| gongysh | sridhar_ram, with all these three parts, we will have no device and device template in our codes. | 05:54 |
| gongysh | sridhar_ram, then we come to vnf, vnfd world. | 05:54 |
| sridhar_ram | gongysh: those 3 patchsets looks reasonable | 05:54 |
| sridhar_ram | gongysh: Sorry, I meant to ask you about unit test refactor bug - https://bugs.launchpad.net/tacker/+bug/1579167 | 05:55 |
| openstack | Launchpad bug 1579167 in tacker "Refactor Tacker unit tests to remove neutron specific logic and device/servicevm extensions" [Low,In progress] - Assigned to Tin Lam (tl3438) | 05:55 |
| * sridhar_ram face palm | 05:55 | |
| sridhar_ram | gongysh: now, re-read my question :) | 05:56 |
| sridhar_ram | gongysh: I thought after your 3 patchset db rename u can help with this unit test cleanup / refactor | 05:57 |
| gongysh | sridhar_ram, sure | 05:58 |
| sridhar_ram | gongysh: gr8, thanks | 05:58 |
| sridhar_ram | gongysh: keep in mind, there is already some code from Tin & Trevor...u don't need to start from scratch | 05:59 |
| gongysh | sridhar_ram, sure, I will help to review | 06:00 |
| gongysh | sridhar_ram, In fact, I prefer to help, than to do myself. | 06:00 |
| sridhar_ram | gongysh: well I don't think original authors are actively working, but we can check.. | 06:01 |
| *** manikanta_ has joined #tacker | 06:01 | |
| *** manikanta_tadi has joined #tacker | 06:01 | |
| sridhar_ram | gongysh: again, if there are low hanging area, we can knock them off first | 06:01 |
| sridhar_ram | gongysh: like this https://review.openstack.org/#/c/320546/ | 06:02 |
| sridhar_ram | gongysh: thanks for ur help | 06:02 |
| *** saju_m has joined #tacker | 06:03 | |
| gongysh | sridhar_ram, after cleanup, we will enable the whole code testing | 06:05 |
| sridhar_ram | gongysh: yep | 06:06 |
| *** tbh has joined #tacker | 06:07 | |
| *** saju_m has quit IRC | 06:12 | |
| *** vishwanathj has quit IRC | 06:15 | |
| *** vishwanathj has joined #tacker | 06:15 | |
| *** dkushwaha has joined #tacker | 06:47 | |
| janki | lulei, ping | 07:14 |
| *** mbound has joined #tacker | 07:31 | |
| vishwanathj | gongysh hi | 07:38 |
| gongysh | vishwanathj, en | 07:44 |
| vishwanathj | gongysh your recommendation of passing from cli to api the CONF may break tests and other calls to get_engine().....is there not a way to import opts? | 07:46 |
| gongysh | vishwanathj, you can use default args, for example get_engine(conf=none) | 07:48 |
| vishwanathj | but isnt importing the opts a better way though? ofcourse I do not know the mechanism of how to import them | 07:50 |
| gongysh | vishwanathj, ok, you can use: cfg.CONF.register_cli_opts(__db_opts, 'database') | 07:52 |
| gongysh | after the line 40 in cli | 07:52 |
| gongysh | and then call it cfg.CONF() after line 151 | 07:53 |
| vishwanathj | _create_facade_lazily and get_session will also have to change in api.py, right? | 07:55 |
| gongysh | vishwanathj, with changes in cli, no change needed in api.py | 08:00 |
| vishwanathj | gongysh I see...so only change after line 151 change is needed? | 08:01 |
| vishwanathj | gongysh let me give it a try | 08:01 |
| gongysh | vishwanathj, change under 40 is also needed | 08:01 |
| vishwanathj | What about the existing CONF.register_cli_opts(_db_opts, 'database') already in L41....should we continue to keep that and move it to L42 | 08:03 |
| openstackgerrit | Manikantha Srinivas Tadi proposed openstack/python-tackerclient: Add "Description" parameter while creating VNF with CLI. https://review.openstack.org/330318 | 08:04 |
| openstackgerrit | Manikantha Srinivas Tadi proposed openstack/python-tackerclient: Created nfvo directory for nfvo specific unit tests. https://review.openstack.org/345939 | 08:07 |
| vishwanathj | gongysh, do you mind putting this comment in the patchset so that I can copy and paste correctly without error...thanks | 08:07 |
| *** tbh has quit IRC | 08:08 | |
| openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: Store the right description of VNF given from Horizon/CLI. https://review.openstack.org/331039 | 08:10 |
| vishwanathj | gongysh please see snippet of changes that I made per my understanding of your suggestion and the error that I get at http://paste.openstack.org/show/554027/ ... looks like I maybe doing something wrong ... let me know what I am doing wrong...thanks | 08:16 |
| openstackgerrit | Manikantha Srinivas Tadi proposed openstack/python-tackerclient: Add "Description" parameter while creating VNF with CLI. https://review.openstack.org/330318 | 08:18 |
| gongysh | vishwanathj, can you push a patchset? | 08:25 |
| gongysh | or put your whole cli.py on paste | 08:25 |
| *** vishwanathj_ has joined #tacker | 08:26 | |
| vishwanathj | gongysh here is the link http://paste.openstack.org/show/554071/ | 08:31 |
| vishwanathj | see changes at L41 and L153 that you recommended (per my understanding) | 08:31 |
| vishwanathj | also see the output at L180 to 184 when command 'tacker-db-manage purge_delete vnf' is executed | 08:33 |
| gongysh | vishwanathj, 153 is not there, after CONF() | 08:34 |
| gongysh | so it is at line 174 in your paste text. | 08:35 |
| vishwanathj | gongysh sorry...I did not get you ... is L153 wrong? | 08:36 |
| gongysh | vishwanathj, yes | 08:37 |
| vishwanathj | gongysh are you using this https://review.openstack.org/#/c/329652/14/tacker/db/migration/cli.py for reference | 08:37 |
| vishwanathj | In the paste link, I see *cfg.CONF at L153...what should it be? | 08:39 |
| vishwanathj | correction -> *cfg.CONF() | 08:39 |
| gongysh | cfg.CONF() no '*' | 08:40 |
| vishwanathj | if I remove the * I get the error in L1 to 10 at http://paste.openstack.org/show/554073/ | 08:42 |
| *** mbound has quit IRC | 08:43 | |
| *** saju_m has joined #tacker | 08:45 | |
| gongysh | vishwanathj, I am downloading your patchset, and have a try | 08:45 |
| vishwanathj_ | Thanks | 08:46 |
| *** saju_m has quit IRC | 08:52 | |
| *** dkushwaha has quit IRC | 08:58 | |
| *** saju_m has joined #tacker | 09:09 | |
| openstackgerrit | sajuptpm proposed openstack/tacker: doc change default vim registration via CLI https://review.openstack.org/343097 | 09:12 |
| openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix ImportError when Jenkins check gate-python-tackerclient-python34 https://review.openstack.org/353924 | 09:17 |
| openstackgerrit | gongysh proposed openstack/tacker: Support purge of soft-deleted resources from DB tables https://review.openstack.org/329652 | 09:19 |
| gongysh | vishwanathj, have a look at the new patchset. | 09:20 |
| *** vishnoianil has quit IRC | 09:20 | |
| *** vishnoianil has joined #tacker | 09:23 | |
| openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: 'Getting Started' doc change for name mandatory fix. https://review.openstack.org/353935 | 09:40 |
| openstackgerrit | Manikantha Srinivas Tadi proposed openstack/tacker: doc changes for name mandatory fix. https://review.openstack.org/353935 | 09:49 |
| *** tbh has joined #tacker | 09:49 | |
| openstackgerrit | Lu lei proposed openstack/python-tackerclient: Fix ImportError when Jenkins check gate-python-tackerclient-python34 https://review.openstack.org/353924 | 10:25 |
| *** mbound has joined #tacker | 10:33 | |
| *** amotoki has joined #tacker | 10:35 | |
| *** mbound has quit IRC | 10:38 | |
| *** amotoki has quit IRC | 10:40 | |
| *** gongysh has quit IRC | 11:01 | |
| *** saju_m has quit IRC | 11:02 | |
| *** vishwanathj_ has quit IRC | 11:06 | |
| *** KanagarajM has quit IRC | 12:09 | |
| *** gongysh has joined #tacker | 12:09 | |
| *** vishnoianil has quit IRC | 12:10 | |
| openstackgerrit | Lu lei proposed openstack/python-tackerclient: Base OpenStackClient(OSC) plugin support https://review.openstack.org/348124 | 12:14 |
| openstackgerrit | Lu lei proposed openstack/tacker: Fix formats for doc's information https://review.openstack.org/341281 | 12:24 |
| *** LamT_ has joined #tacker | 12:28 | |
| *** gongysh has quit IRC | 12:28 | |
| *** gongysh has joined #tacker | 12:35 | |
| *** gongysh has quit IRC | 12:41 | |
| *** bobh has joined #tacker | 12:57 | |
| *** KanagarajM has joined #tacker | 13:06 | |
| openstackgerrit | Janki Chhatbar proposed openstack/python-tackerclient: Creates details API to fetch VNF detials https://review.openstack.org/354057 | 13:10 |
| *** bobh has quit IRC | 13:15 | |
| *** KanagarajM has quit IRC | 13:16 | |
| openstackgerrit | Janki Chhatbar proposed openstack/tacker: Add VNF resource details to get vnf API https://review.openstack.org/340838 | 13:19 |
| openstackgerrit | Janki Chhatbar proposed openstack/python-tackerclient: Creates details API to fetch VNF detials https://review.openstack.org/354057 | 13:21 |
| *** haiwei has quit IRC | 13:26 | |
| janki | HI, I am facing error in returning a value to client. Details at https://review.openstack.org/#/c/340838/. Any guidance would be appreciated | 13:28 |
| *** KanagarajM has joined #tacker | 13:54 | |
| *** bobh has joined #tacker | 13:54 | |
| *** KanagarajM has quit IRC | 14:02 | |
| *** manikanta_tadi has quit IRC | 14:02 | |
| *** manikanta_ has quit IRC | 14:02 | |
| *** trozet has joined #tacker | 14:13 | |
| *** vishwanathj_ has joined #tacker | 14:26 | |
| *** uck has joined #tacker | 14:27 | |
| *** amotoki has joined #tacker | 14:31 | |
| *** LamT_ has quit IRC | 14:31 | |
| *** Vijayendra has quit IRC | 14:35 | |
| *** Vijayendra has joined #tacker | 14:35 | |
| openstackgerrit | Janki Chhatbar proposed openstack/tacker: Add VNF resource details to get vnf API https://review.openstack.org/340838 | 14:49 |
| *** janki has quit IRC | 15:06 | |
| *** vishnoianil has joined #tacker | 15:09 | |
| *** uck has quit IRC | 15:21 | |
| *** prashantD_ has joined #tacker | 15:41 | |
| *** links has quit IRC | 15:43 | |
| *** lulei has quit IRC | 16:03 | |
| *** lulei has joined #tacker | 16:03 | |
| trozet | sridhar_ram: ping? | 16:30 |
| *** vishwanathj_ has quit IRC | 16:36 | |
| *** bobh has quit IRC | 16:58 | |
| *** s3wong has joined #tacker | 17:06 | |
| sridhar_ram | trozet: pong | 17:23 |
| *** sripriya has joined #tacker | 17:27 | |
| trozet | sridhar_ram: did you see my updates from last night? | 17:27 |
| sridhar_ram | trozet: yeah, i saw that.. | 17:28 |
| sridhar_ram | trozet: looks like a good progress | 17:28 |
| trozet | sridhar_ram: yeah so i am also able to move the clear_tables back in the db clean, and now it works | 17:29 |
| trozet | sridhar_ram: since i removed the cyclic constraint | 17:29 |
| sridhar_ram | trozet: cool... | 17:29 |
| trozet | sridhar_ram: the create_vnffg with abstract types unit test passes which is cool | 17:29 |
| trozet | sridhar_ram: I just need to add more unit tests, fix up the vim auth stuff, add the tosca parsing and I think it is ready | 17:30 |
| sridhar_ram | trozet: can u recap the cyclic constraints? between which to table/attrs ? just for my understanding | 17:30 |
| trozet | sridhar_ram: it was like this: | 17:30 |
| sridhar_ram | s/to/two/ | 17:30 |
| trozet | nfp table --orm relationship---> sfc table | 17:30 |
| trozet | nfp had column, sfc.id | 17:31 |
| trozet | and sfc table had column nfp.id | 17:31 |
| trozet | so a double constraint | 17:31 |
| sridhar_ram | ah.. got it | 17:31 |
| trozet | typically in the tacker code, the parent table (nfp) wouldn't have sfc_id, and would just use orm to query into it and find the id | 17:31 |
| trozet | and that is done in the make_dict functions | 17:32 |
| trozet | sridhar_ram: so i just switched to that method...it is just much more simple | 17:32 |
| sridhar_ram | trozet: got it.. | 17:32 |
| trozet | sridhar_ram: when do you think you will have some time to go through the whole patch? | 17:33 |
| sridhar_ram | trozet: i'm prioritizing call client patches... | 17:33 |
| sridhar_ram | trozet: i believe .. xu-haiwei doing the client for vnffg .. | 17:34 |
| sridhar_ram | trozet: so my initial plan to look at ur RESTapi and haiwei's client code and sign that off first.. | 17:34 |
| sridhar_ram | trozet: i'll send some comments back by EOD tomorrow | 17:35 |
| trozet | sridhar_ram: i see, i wrote the client also before I knew he had already done part of it | 17:35 |
| trozet | sridhar_ram: so i can review his patch | 17:35 |
| sridhar_ram | trozet: ah, yeah.. make sure it is something to ur liking :) | 17:35 |
| *** tbh has quit IRC | 17:49 | |
| *** bobh has joined #tacker | 17:59 | |
| *** bobh has quit IRC | 18:03 | |
| *** amotoki has quit IRC | 18:15 | |
| openstackgerrit | Sripriya Seetharam proposed openstack/tacker: Introduce uniqueness constraint on resource names https://review.openstack.org/329759 | 18:21 |
| *** amotoki has joined #tacker | 18:22 | |
| *** vishnoianil has quit IRC | 18:30 | |
| *** bobh has joined #tacker | 18:35 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds event plugin for audit support https://review.openstack.org/326102 | 18:45 |
| *** sripriya has quit IRC | 18:48 | |
| *** sripriya has joined #tacker | 18:58 | |
| *** vishnoianil has joined #tacker | 19:33 | |
| *** sripriya has quit IRC | 19:55 | |
| *** amotoki has quit IRC | 20:20 | |
| openstackgerrit | Tim Rozet proposed openstack/tacker: [WIP] Implements VNFFG into NFVO https://review.openstack.org/344522 | 20:43 |
| *** sripriya has joined #tacker | 20:45 | |
| *** bobh has quit IRC | 21:20 | |
| *** prashantD has joined #tacker | 21:24 | |
| *** prashantD_ has quit IRC | 21:26 | |
| *** bobh has joined #tacker | 21:33 | |
| *** bobh has quit IRC | 21:37 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Logs events for VIM, VNFD and VNF operations https://review.openstack.org/349153 | 21:38 |
| *** sripriya has quit IRC | 21:43 | |
| *** prashantD_ has joined #tacker | 21:45 | |
| *** sripriya has joined #tacker | 21:48 | |
| *** prashantD has quit IRC | 21:48 | |
| *** danielraj has joined #tacker | 23:05 | |
| *** danielraj has quit IRC | 23:05 | |
| *** dkushwaha has joined #tacker | 23:08 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!