openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds audit support for VIM, VNFD and VNF https://review.openstack.org/325169 | 00:33 |
---|---|---|
*** vishwanathj has joined #tacker | 00:34 | |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds audit support for VIM, VNFD and VNF https://review.openstack.org/325169 | 00:35 |
*** vishnoianil has quit IRC | 00:46 | |
*** vishnoianil has joined #tacker | 00:47 | |
*** sripriya has quit IRC | 00:52 | |
*** sripriya has joined #tacker | 00:54 | |
*** mike_m has joined #tacker | 00:55 | |
*** mike_m has quit IRC | 01:00 | |
openstackgerrit | Sripriya Seetharam proposed openstack/tacker: Introduce uniqueness constraint on resource names https://review.openstack.org/329759 | 01:24 |
*** sripriya has quit IRC | 01:36 | |
*** s3wong has quit IRC | 01:57 | |
*** vishnoianil has quit IRC | 02:15 | |
openstackgerrit | dharmendra kushwaha proposed openstack/tacker: tacker resource and test_api_v2 refactoring https://review.openstack.org/317749 | 02:17 |
*** manikanta_tadi has joined #tacker | 02:25 | |
*** manikanta_tadi has quit IRC | 02:25 | |
openstackgerrit | dharmendra kushwaha proposed openstack/tacker: tacker resource and test_api_v2 refactoring https://review.openstack.org/317749 | 02:36 |
openstackgerrit | Tim Rozet proposed openstack/tacker: Add VNF resource details to get vnf API https://review.openstack.org/340838 | 03:24 |
openstackgerrit | Tim Rozet proposed openstack/tacker: [WIP] Implements VNFFG into NFVO https://review.openstack.org/344522 | 03:24 |
openstackgerrit | Tim Rozet proposed openstack/tacker: VNFFG chain driver abstract driver https://review.openstack.org/347563 | 03:24 |
*** achatterjee has joined #tacker | 03:26 | |
trozet | sridhar_ram:^ | 03:28 |
*** yifei has left #tacker | 03:48 | |
*** yifei has joined #tacker | 03:54 | |
*** KanagarajM has joined #tacker | 03:59 | |
*** KanagarajM has quit IRC | 04:12 | |
*** links has joined #tacker | 04:15 | |
*** tbh has joined #tacker | 04:17 | |
*** tbh has quit IRC | 04:30 | |
*** arturt has joined #tacker | 04:43 | |
*** arturt has quit IRC | 04:45 | |
*** tbh has joined #tacker | 04:56 | |
*** neel has joined #tacker | 05:03 | |
*** Vijayendra has quit IRC | 05:07 | |
*** Vijayendra has joined #tacker | 05:08 | |
*** vishnoianil has joined #tacker | 05:33 | |
*** Ravikiran_K has joined #tacker | 05:53 | |
openstackgerrit | dharmendra kushwaha proposed openstack/tacker: tacker test_wsgi.py refactoring https://review.openstack.org/319028 | 06:03 |
openstackgerrit | dharmendra kushwaha proposed openstack/tacker: tacker test_wsgi.py refactoring https://review.openstack.org/319028 | 06:07 |
*** tbh has quit IRC | 06:10 | |
*** nagarjung has joined #tacker | 06:16 | |
*** changzhi has joined #tacker | 06:41 | |
changzhi | hi, I plan to upload a OpenWRT image for tacker. Which OpenWRT version should I use? Does tacker need a specific OpenWRT version? | 06:43 |
*** santoshk has quit IRC | 07:02 | |
sridhar_ram | changzhi: yes, use this version.. https://drive.google.com/open?id=0B-ruQ8Tx46wSMktKV3JLRWhnLTA | 07:11 |
sridhar_ram | changzhi: this has dhcp client pre-enabled for the first nic | 07:11 |
changzhi | sridhar_ram: ok, thanks ;-) | 07:12 |
changzhi | sridhar_ram: I already uploaded the openwrt image into glance and named it "OpenWRT". And I created VNFD template by the sample file named "tosca-vnfd-openwrt.yaml". But some errors happen when I create a VNF. The error msg is " ERROR: Property error: : resources.VDU1.properties.image: : Error validating value 'OpenWRT': No images matching {'name': u'OpenWRT'}. (HTTP 404) ". | 07:18 |
changzhi | sridhar_ram: Do I need do something more in Tacker when I upload the OpenWRT image into glance ? | 07:19 |
*** hparekh has quit IRC | 07:26 | |
changzhi | sridhar_ram: Oh, I see. I should change the "OpenWRT" into the uuid of "OpenWRT" image. | 07:35 |
*** vishwanathj has quit IRC | 07:51 | |
*** amotoki has joined #tacker | 07:53 | |
*** amotoki_ has joined #tacker | 07:57 | |
*** amotoki has quit IRC | 07:59 | |
*** openstackgerrit has quit IRC | 08:03 | |
*** openstackgerrit has joined #tacker | 08:04 | |
*** changzhi has quit IRC | 08:10 | |
*** vishwanathj has joined #tacker | 08:14 | |
*** neel has quit IRC | 08:21 | |
*** Ravikiran_K has quit IRC | 08:43 | |
*** hparekh has joined #tacker | 08:44 | |
*** hparekh_ has joined #tacker | 08:44 | |
*** Ravikiran_K has joined #tacker | 08:45 | |
*** hparekh has quit IRC | 08:45 | |
*** hparekh_ has quit IRC | 08:45 | |
*** apsarshaik has quit IRC | 09:01 | |
*** neel has joined #tacker | 09:12 | |
*** vishwanathj is now known as vishwanathj_zzz | 09:15 | |
*** nagarjung has quit IRC | 09:25 | |
*** changzhi has joined #tacker | 09:41 | |
*** nagarjung has joined #tacker | 09:42 | |
*** nagarjung has quit IRC | 09:50 | |
openstackgerrit | Zhi Chang proposed openstack/tacker: Tacker deploy OpenWRT as VNF guide https://review.openstack.org/357728 | 09:54 |
*** manikanta_tadi has joined #tacker | 09:54 | |
*** changzhi has quit IRC | 10:03 | |
*** nagarjung has joined #tacker | 10:06 | |
*** nagarjung has joined #tacker | 10:07 | |
*** neel has quit IRC | 10:07 | |
*** manikanta_tadi has quit IRC | 10:07 | |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Enables soft deletion for VIM, VNFD and VNF https://review.openstack.org/325718 | 10:29 |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds common services plugin for audit support https://review.openstack.org/326102 | 10:35 |
openstackgerrit | Lu lei proposed openstack/tacker: Remove six.iteritems and dict.iteritems/itervalues https://review.openstack.org/357749 | 10:35 |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Logs events for VIM, VNFD and VNF operations https://review.openstack.org/349153 | 10:45 |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Support purge of soft-deleted resources from DB tables https://review.openstack.org/329652 | 10:50 |
-openstackstatus- NOTICE: Precise tests on OSIC provider are currently failing, please stop your checks until the issue is resolved. | 11:18 | |
-openstackstatus- NOTICE: DSVM jobs on OSIC currently failing because of IP collisions, fix is in the gate - https://review.openstack.org/#/c/357764/ - please hold rechecks until merged | 11:23 | |
-openstackstatus- NOTICE: OSIC has burned through the problematic IP range with failures, things should be back to normal now. | 11:51 | |
*** yifei has quit IRC | 12:31 | |
*** lulei has quit IRC | 12:49 | |
*** bobh has joined #tacker | 12:54 | |
*** yifei has joined #tacker | 12:55 | |
*** yifei has quit IRC | 13:00 | |
*** yifei has joined #tacker | 13:00 | |
*** bobh has quit IRC | 13:03 | |
*** mike_m has joined #tacker | 13:11 | |
*** Poorna has quit IRC | 13:20 | |
*** Poorna has joined #tacker | 13:22 | |
*** bobh has joined #tacker | 13:33 | |
*** Ravikiran_K has quit IRC | 13:47 | |
*** nagarjung has joined #tacker | 13:49 | |
*** nagarjung has quit IRC | 14:14 | |
*** uck has joined #tacker | 15:45 | |
*** links has quit IRC | 15:49 | |
*** Ravikiran_K has joined #tacker | 15:55 | |
*** bobh has quit IRC | 15:58 | |
*** Ravikiran_K_ has joined #tacker | 16:00 | |
*** Ravikiran_K has quit IRC | 16:00 | |
*** bobh has joined #tacker | 16:07 | |
*** Poorna has quit IRC | 16:10 | |
*** amotoki_ has quit IRC | 16:22 | |
*** mike_m has quit IRC | 16:39 | |
*** mike_m has joined #tacker | 16:39 | |
*** Ravikiran_K_ has quit IRC | 16:48 | |
*** amotoki has joined #tacker | 16:55 | |
*** yifei has quit IRC | 16:56 | |
*** s3wong has joined #tacker | 17:42 | |
*** sripriya has joined #tacker | 17:47 | |
*** sripriya has quit IRC | 17:58 | |
*** amotoki has quit IRC | 18:16 | |
*** vishwanathj_zzz is now known as vishwanathj | 18:23 | |
*** amotoki has joined #tacker | 18:47 | |
*** amotoki has quit IRC | 18:50 | |
*** amotoki has joined #tacker | 18:56 | |
*** prashantD has joined #tacker | 19:00 | |
*** amotoki has quit IRC | 19:04 | |
*** vishnoianil has quit IRC | 19:25 | |
*** sripriya has joined #tacker | 19:35 | |
*** vishnoianil has joined #tacker | 19:38 | |
*** trozet has quit IRC | 19:39 | |
*** trozet has joined #tacker | 19:44 | |
*** mike_m has quit IRC | 19:49 | |
*** janki has joined #tacker | 19:54 | |
*** jchhatbar has joined #tacker | 20:10 | |
*** janki has quit IRC | 20:10 | |
jchhatbar | trozet, ping | 20:17 |
trozet | jchhatbar: hello | 20:24 |
*** jchhatbar is now known as janki | 20:25 | |
janki | trozet, I noticed you have made few changes to get_vnf_details pacthset | 20:25 |
trozet | janki: ? | 20:25 |
janki | trozet, Have you checked whether or not its working using the CLI? | 20:25 |
janki | trozet, talking about this https://review.openstack.org/#/c/340838/ | 20:26 |
trozet | janki: that must have been an accident, my patch dpeends on yours and i tmust have overwritten your previous change | 20:27 |
janki | trozet, ohh. How do I revert to the previous change? | 20:28 |
janki | trozet, because the changes that have gone in are breaking the code | 20:28 |
trozet | janki: you can just checkout patch set 20, fix sripriyas comments then upload the new patch set | 20:29 |
janki | trozet, ohk..thanks :) | 20:29 |
trozet | janki: sorry about that. When i upload my patch it automatically updates yours | 20:30 |
janki | trozet, No issues. Was travelling whole day, saw your patch and just thought to verify with you first rather than checking it myself as it is quite late night here | 20:31 |
janki | sripriya, ping | 20:32 |
sripriya | janki: pong | 20:33 |
janki | sripriya, I didnot quite understand your comment on https://review.openstack.org/#/c/340838/20/tacker/extensions/vnfm.py | 20:33 |
sripriya | janki: the collection name is ‘details’ and member is ‘vnf_details’ | 20:35 |
sripriya | janki: collection and member refer to the same resource | 20:36 |
sripriya | janki: it cannot be vnf_details | 20:36 |
*** saju_m has joined #tacker | 20:36 | |
janki | sripriya, I am not much aware of collection and member terminologies :( | 20:36 |
janki | do they always need to be same? | 20:36 |
janki | sripriya, won't resource here be vnf? | 20:37 |
sripriya | janki: yes, the collection is —> member +’s’ signifying the plural —>collection of resources | 20:37 |
sripriya | janki: that ’s rest nomenclature | 20:37 |
sripriya | trozet: ping | 20:37 |
trozet | hi sripriya | 20:38 |
janki | sripriya, ohk. since here no plural is involved, collection and member would be same | 20:38 |
sripriya | janki: well, here it is involved, details -> collection, detail->member | 20:39 |
*** mike_m has joined #tacker | 20:39 | |
janki | sripriya, I am not making any plural related declarations on client side. | 20:40 |
sripriya | trozet: did you notice the jenkins error on neutron-client in your patch? | 20:40 |
trozet | sripriya: yeah looks like i just need to change the required version | 20:41 |
trozet | sripriya: was going to work on hte patch tonight, so will include that as well | 20:41 |
sripriya | trozet: but global is pointing to 5.1.0 https://github.com/openstack/requirements/blob/master/global-requirements.txt#L204 | 20:41 |
sripriya | janki: this is on the server side | 20:42 |
sripriya | janki: to give example with existing resources, something like get_vnf and get_vnfs, here vnf —>member, vnfs-> collections | 20:43 |
trozet | sripriya: so you are saying mine was correct, and its a bug in the jenkins check? | 20:43 |
sripriya | trozet: that is what i’m trying to understand why the jenkins choked on the version? | 20:43 |
sripriya | trozet; another observation is https://github.com/openstack/neutron/blob/master/requirements.txt#L21 | 20:44 |
janki | sripriya, thanks for clearing this.. | 20:45 |
trozet | Requirement for package python-neutronclient : Requirement(package=u'python-neutronclient', location='', specifiers='>=5.1.0', markers=u'', comment=u'# Apache-2.0', extras=frozenset([])) does not match openstack/requirements value : set([Requirement(package='python-neutronclient', location='', specifiers='>=4.2.0', markers='', comment='# Apache-2.0', extras=frozenset([]))]) | 20:45 |
sripriya | trozet: yup | 20:45 |
sripriya | janki: np | 20:45 |
trozet | sripriya: looks like the test is set to look for 4.2.0 | 20:45 |
janki | sripriya, please do have a look at https://review.openstack.org/#/c/354057/ at your convinience | 20:45 |
sripriya | janki: please plan to respin the client patch whenever possible | 20:45 |
sripriya | janki: i think the patch needs to address the comments? | 20:46 |
sripriya | trozet: from where is this picking? | 20:46 |
janki | sripriya, yes. I missed those comments. My bad | 20:46 |
sripriya | janki: no worries | 20:47 |
trozet | INFO:zuul.Cloner:Creating repo openstack/requirements from cache file:///opt/git/openstack/requirements | 20:47 |
sripriya | trozet: cache? | 20:48 |
trozet | looks like it pulls from cache first | 20:48 |
trozet | then updates | 20:48 |
trozet | INFO:zuul.Cloner:Prepared openstack/requirements repo with branch master at commit 69cf663e1d24c1e1a0fd437dee64a0a3aee38e7a | 20:48 |
trozet | INFO:zuul.Cloner:Updating origin remote in repo openstack/requirements to git://git.openstack.org/openstack/requirements | 20:48 |
*** prashantD_ has joined #tacker | 20:50 | |
janki | sripriya, I will add functional and unit test cases as a separate patch. I hope this is ok | 20:51 |
openstackgerrit | Janki Chhatbar proposed openstack/tacker: Add VNF resource details to get vnf API https://review.openstack.org/340838 | 20:52 |
*** prashantD has quit IRC | 20:52 | |
*** uck_ has joined #tacker | 20:54 | |
*** uck has quit IRC | 20:54 | |
sripriya | janki: i would request unit tests to be part of the patch, would that be difficult? | 20:54 |
trozet | sripriya: i see the problem | 20:55 |
sripriya | trozet: i think the commit id answers the problem | 20:55 |
sripriya | trozet: :-) | 20:55 |
trozet | sripriya: yeah https://paste.fedoraproject.org/410983/ | 20:56 |
janki | sripriya, quite frankly, have never written a unit test before. Need to go through others first. It is 2:30 at friday night here and am not available over the weekend. Involving unit tests would mean having the patch ready for review by monday. | 20:56 |
janki | sripriya, if this is not urgent, I dont mind having it done by monday EOD | 20:56 |
trozet | sripriya: it looks like global requirements for neutorn were just updated today | 20:57 |
sripriya | janki: monday EOD should be fine, please don’t burn :-) | 20:57 |
sripriya | trozet: yup | 20:57 |
trozet | Date: Fri Aug 19 06:17:47 2016 +0000 | 20:57 |
trozet | Merge "Bump neutronclient to 5.1.0" | 20:57 |
trozet | sripriya: great I don' thave to fix anything ;) | 20:57 |
sripriya | trozet: yes | 20:57 |
trozet | sripriya: will work on the patch some more tonight though. Gotta go for now. Later | 20:57 |
sripriya | trozet: ttyl | 20:58 |
janki | sripriya, will have unit and functional tests by monday. thanks :) | 20:58 |
sripriya | janki: thank you! func tests can come as follow ons, that is fine | 20:59 |
janki | sripriya, ack'ed | 20:59 |
*** trozet has quit IRC | 21:03 | |
*** uck has joined #tacker | 21:11 | |
*** uck_ has quit IRC | 21:11 | |
janki | sripriya, about the client patch, for vnf_details, the response from server would be {u'details': [{u'resource_details': {u'VDU1': {u'type': u'OS::Nova::Server', u'id': u'acc9d87a-7243-4162-a492-6079afca6139'}, u'CP1': {u'type': u'OS::Neutron::Port', u'id': u'1171fb75-5c8a-4388-b641-520dc503f5ec'}, u'CP2': {u'type': u'OS::Neutron::Port', u'id': u'19dad3b5-35c0-4c6e-adc2-1424fcadba23'}, u'CP3': {u'type': u'OS::Neutron::Port', u'id': u'55700416-e84d-410d-8 | 21:15 |
janki | 169-ff5a37c60903'}}}]} | 21:15 |
janki | sripriya, this means need to change the formatting code as well | 21:16 |
sripriya | janki: looking into it | 21:18 |
janki | sripriya, see patchset 3 L55-58 | 21:20 |
sripriya | janki: i think we will need to tweak the ShowCommand a bit more on the response as well along with request to handle the data as a list | 21:26 |
janki | handling it as a list would mean having list_columns, calling list specific methods from ListCommand | 21:29 |
janki | sripriya, ^^, instead i am thinking something like this if 'verbose' in params: | 21:30 |
janki | self.resource = 'resource_details' | 21:30 |
janki | data = obj_shower(_id, **params) | 21:30 |
janki | data = data['details'][0] | 21:30 |
janki | self.format_output_data(data) | 21:30 |
janki | resource = data[self.resource] | 21:30 |
janki | sripriya, the whole code of ShowVNF in __init__ and the response at http://pastebin.com/EvVpVJZD | 21:32 |
janki | since the list has a dict, I am indexing the list and passing the dict for formatting | 21:32 |
sripriya | janki: please push the patch and i will take a closer look, the one thing concerning is picking up the 1st element in the list only and displaying. | 21:37 |
sripriya | janki: i will try to spend some time on this | 21:38 |
janki | sripriya, there won't be more than 1 element in the dict. so its safe to index it to 0 | 21:39 |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Adds audit support for VIM, VNFD and VNF https://review.openstack.org/325169 | 21:39 |
sripriya | janki: it is good to not assume this | 21:39 |
sripriya | janki: though that is the current case | 21:39 |
sripriya | janki: also, you don’t need the verbose thing, and directly use the show-details variable | 21:40 |
janki | sripriya, IMO, this would be the case always. we are returning "resource_details" from server as a list to a sub-reousrce "details". Thus the whole response from server has to be {details: [{}]}. | 21:41 |
janki | sripriya, keeping verbose to apply if later on for formatting output | 21:41 |
sripriya | janki: good point on the server | 21:46 |
sripriya | janki: do we use verbose on the formatting? i | 21:47 |
janki | sripriya, using verbose to have "if" condition for formatting like this | 21:47 |
janki | if 'verbose' in params: | 21:47 |
janki | self.resource = 'resource_details' | 21:47 |
janki | data = data['details'][0] | 21:47 |
janki | otherwise, data = data = obj_shower(_id, **params) (this is implicit) | 21:48 |
sripriya | janki: yeah we don’t need this since parsed.args.show_details is just doing the same | 21:48 |
sripriya | janki: verbose is a param sent for the server | 21:49 |
janki | sripriya, ok. will use parsed.args... here as well | 21:49 |
sripriya | janki: cool | 21:49 |
janki | sripriya, yes, it goes to server. I guess it comes out as a 'filter' on server. Not sure on this | 21:50 |
sripriya | janki: no that is a separate field which server handles, currently tacker doesnt implement | 21:51 |
janki | sripriya, ohh, ohk. Am submitting a patch with discussed changes. It is good to go IMO | 21:52 |
sripriya | janki; okcool | 21:52 |
openstackgerrit | Janki Chhatbar proposed openstack/python-tackerclient: Creates details API to fetch VNF detials https://review.openstack.org/354057 | 21:53 |
janki | sripriya, ^^, submitted. Please review at your convinience. Thanks | 21:54 |
sripriya | janki: will review today. | 21:54 |
openstackgerrit | vishwanath jayaraman proposed openstack/tacker: Enables soft deletion for VIM, VNFD and VNF https://review.openstack.org/325718 | 21:58 |
openstackgerrit | Janki Chhatbar proposed openstack/python-tackerclient: Creates details API to fetch VNF detials https://review.openstack.org/354057 | 21:58 |
*** janki has quit IRC | 22:00 | |
*** bobh has quit IRC | 22:11 | |
*** mike_m has quit IRC | 22:39 | |
*** saju_m has quit IRC | 22:58 | |
*** amotoki has joined #tacker | 23:09 | |
*** uck has quit IRC | 23:18 | |
*** amotoki has quit IRC | 23:23 | |
*** sripriya has quit IRC | 23:37 | |
*** uck has joined #tacker | 23:55 | |
*** yifei has joined #tacker | 23:56 | |
*** uck has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!