| *** gongysh has joined #tacker | 00:13 | |
| *** sripriya has quit IRC | 00:51 | |
| *** prashantD has quit IRC | 01:00 | |
| *** manikanta_tadi has joined #tacker | 01:07 | |
| openstackgerrit | Tim Rozet proposed openstack/python-tackerclient: Add client support for VNFFG in NFVO https://review.openstack.org/341389 | 01:09 |
|---|---|---|
| *** xiayu1 has joined #tacker | 01:13 | |
| *** xiayu has quit IRC | 01:15 | |
| *** KanagarajM has joined #tacker | 01:59 | |
| *** s3wong has quit IRC | 02:00 | |
| *** manikanta_tadi has quit IRC | 02:42 | |
| *** xiayu1 has quit IRC | 02:51 | |
| *** xiayu has joined #tacker | 02:56 | |
| *** gongysh has quit IRC | 03:10 | |
| *** vishnoianil has quit IRC | 03:16 | |
| *** gongysh has joined #tacker | 03:57 | |
| gongysh | sridhar_ram, hi | 03:57 |
| sridhar_ram | gongysh: hi there | 03:58 |
| *** gongysh_ has joined #tacker | 03:59 | |
| gongysh_ | sridhar_ram, 2016-08-26 11:51:22.976 10301 ERROR tacker.api.v1.resource HeatClientException: ERROR: Property error: : resources.VDU1.properties.key_name: : Error validating value 'userKey': The Key (userKey) could not be found. | 04:01 |
| gongysh_ | sridhar_ram, what is the cause which causes it? I am wondering ... | 04:02 |
| gongysh_ | sridhar_ram, topology_template: | 04:02 |
| gongysh_ | node_templates: | 04:02 |
| gongysh_ | VDU1: | 04:02 |
| gongysh_ | type: tosca.nodes.nfv.VDU.Tacker | 04:02 |
| gongysh_ | properties: | 04:02 |
| gongysh_ | image: cirros-0.3.4-x86_64-uec | 04:02 |
| gongysh_ | flavor: m1.tiny | 04:02 |
| gongysh_ | key_name: userKey | 04:02 |
| gongysh_ | availability_zone: nova | 04:02 |
| gongysh_ | mgmt_driver: noop | 04:02 |
| gongysh_ | config: | | 04:02 |
| gongysh_ | param0: key1 | 04:02 |
| gongysh_ | param1: key2 | 04:03 |
| sridhar_ram | gongysh: this functionality test in tacker needs Nova keypair with the name 'userKey' need to be created | 04:03 |
| * sridhar_ram looking up | 04:03 | |
| sridhar_ram | gongysh: see add_nova_key() in https://github.com/openstack/tacker/blob/master/tacker/tests/contrib/post_test_hook.sh | 04:05 |
| sridhar_ram | *add_key | 04:06 |
| *** links has joined #tacker | 04:07 | |
| *** sripriya has joined #tacker | 04:09 | |
| *** haiwei has quit IRC | 04:12 | |
| gongysh | sridhar_ram, the nova userKey should be added to vim0 tenant or the tacker cli tenant? | 04:14 |
| sridhar_ram | gongysh: vim0 tenant | 04:14 |
| gongysh | sridhar_ram, echo "Adding nova key" | 04:15 |
| gongysh | source $DEVSTACK_DIR/openrc admin admin | 04:15 |
| gongysh | userId=$(openstack user list | awk '/\ nfv_user\ / {print $2}') | 04:15 |
| gongysh | nova keypair-add userKey --user $userId > keypair.priv | 04:15 |
| gongysh | sridhar_ram, got it. | 04:15 |
| sridhar_ram | gongysh: cool ! | 04:16 |
| *** janki has joined #tacker | 04:20 | |
| *** achatterjee has joined #tacker | 04:23 | |
| *** sripriya has quit IRC | 04:27 | |
| dkushwaha | sridhar_ram, hi | 05:27 |
| dkushwaha | sridhar_ram, Kindly have a look into https://bugs.launchpad.net/python-tackerclient/+bug/1617157 and confirm the same | 05:32 |
| openstack | Launchpad bug 1617157 in python-tackerclient "Unit test under tackerclient/tests/unit are geting executed" [Undecided,New] - Assigned to dharmendra (dharmendra-kushwaha) | 05:32 |
| sridhar_ram | dkushwaha: i think it was intentionally left that way early in the project (to avoid failures due to old legacy neutron tests). I think it is worth moving the path to what tests/unit and see where we stand now and fix any remaining issues. | 05:44 |
| sridhar_ram | dkushwaha: good find, thanks for bringing this up | 05:45 |
| *** neel has joined #tacker | 05:52 | |
| *** sripriya has joined #tacker | 05:52 | |
| *** haiwei has joined #tacker | 06:12 | |
| *** sripriya has quit IRC | 06:12 | |
| *** sripriya has joined #tacker | 06:12 | |
| openstackgerrit | gongysh proposed openstack/tacker: Device refactor Part3: Rename device in codes https://review.openstack.org/352205 | 06:20 |
| *** sripriya has quit IRC | 06:28 | |
| *** vishwanathj has joined #tacker | 06:43 | |
| *** amotoki has joined #tacker | 06:56 | |
| *** saju_m has joined #tacker | 06:59 | |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Fix the Attribute Error in nova.py https://review.openstack.org/360928 | 07:14 |
| *** neel has quit IRC | 07:17 | |
| *** neel has joined #tacker | 07:22 | |
| openstackgerrit | Sripriya Seetharam proposed openstack/python-tackerclient: cli: modify vnfd, param & config attr. to dict obj https://review.openstack.org/360806 | 07:57 |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** openstackgerrit has joined #tacker | 08:19 | |
| *** neel has quit IRC | 08:20 | |
| openstackgerrit | gongysh proposed openstack/tacker: Device refactor Part3: Rename device in codes https://review.openstack.org/352205 | 08:27 |
| *** vishwanathj has quit IRC | 08:36 | |
| *** vishwanathj has joined #tacker | 08:37 | |
| *** gongysh has quit IRC | 08:44 | |
| *** manikanta_tadi has joined #tacker | 08:51 | |
| *** amotoki has quit IRC | 08:54 | |
| *** vishwanathj has quit IRC | 08:56 | |
| *** vishwanathj has joined #tacker | 08:57 | |
| * janki is away: will be back | 09:07 | |
| * janki is back (gone 00:00:13) | 09:08 | |
| *** lulei has quit IRC | 09:13 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/python-tackerclient: Removing test cases for already removed methods https://review.openstack.org/361027 | 09:21 |
| *** neel has joined #tacker | 09:35 | |
| *** mpsairam has quit IRC | 09:55 | |
| openstackgerrit | sajuptpm proposed openstack/python-tackerclient: [wip] Validate file size before uploading https://review.openstack.org/340950 | 10:06 |
| *** vishwanathj has quit IRC | 10:06 | |
| *** vishwanathj has joined #tacker | 10:07 | |
| *** tbh has joined #tacker | 10:16 | |
| *** bharatht_ has joined #tacker | 10:16 | |
| openstackgerrit | sajuptpm proposed openstack/python-tackerclient: [wip] Validate file size before uploading https://review.openstack.org/340950 | 10:26 |
| *** gongysh has joined #tacker | 10:27 | |
| *** KanagarajM has quit IRC | 10:30 | |
| *** janki has quit IRC | 10:43 | |
| *** janki has joined #tacker | 10:44 | |
| *** saju_m has quit IRC | 10:51 | |
| *** vishwanathj has quit IRC | 10:53 | |
| *** vishwanathj has joined #tacker | 10:54 | |
| *** neel has quit IRC | 11:04 | |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Clean up the imports according to hacking standards https://review.openstack.org/359608 | 11:19 |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Delete unused pom.xml file from doc directory https://review.openstack.org/361103 | 11:29 |
| *** vikasc has joined #tacker | 11:31 | |
| *** vikasc has left #tacker | 11:31 | |
| janki | tbh: sridhar_ram ping | 11:35 |
| *** amotoki has joined #tacker | 11:44 | |
| *** vishwanathj has quit IRC | 11:48 | |
| *** vishwanathj has joined #tacker | 11:49 | |
| *** manikanta_tadi has quit IRC | 12:18 | |
| *** trozet has quit IRC | 12:32 | |
| *** trozet has joined #tacker | 12:44 | |
| *** amotoki has quit IRC | 12:50 | |
| *** janki has quit IRC | 12:50 | |
| openstackgerrit | gongysh proposed openstack/tacker: Add a shell script for developers to prepare functional test env https://review.openstack.org/361153 | 12:51 |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Clean up the imports according to hacking standards https://review.openstack.org/359608 | 12:54 |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Clean up the imports according to hacking standards https://review.openstack.org/359608 | 12:56 |
| *** amotoki has joined #tacker | 12:56 | |
| *** amotoki has quit IRC | 13:02 | |
| *** vikasc has joined #tacker | 13:03 | |
| *** vikasc has left #tacker | 13:03 | |
| *** gongysh has quit IRC | 13:04 | |
| openstackgerrit | Tim Rozet proposed openstack/python-tackerclient: Add client support for VNFFG in NFVO https://review.openstack.org/341389 | 13:23 |
| *** amotoki has joined #tacker | 13:31 | |
| *** amotoki has quit IRC | 13:38 | |
| *** links has quit IRC | 13:45 | |
| *** amotoki has joined #tacker | 13:53 | |
| openstackgerrit | venkatamahesh proposed openstack/tacker: Clean up the imports according to hacking standards https://review.openstack.org/359608 | 14:01 |
| *** brucet has joined #tacker | 14:02 | |
| *** brucet has quit IRC | 14:02 | |
| *** janki has joined #tacker | 14:09 | |
| *** dkushwaha__ has joined #tacker | 14:51 | |
| sridhar_ram | janki: ping | 15:11 |
| janki | sridhar_ram, wanted to discuss the comments on vnf_details patch https://review.openstack.org/#/c/340838/ | 15:13 |
| sridhar_ram | janki: sure | 15:13 |
| janki | sridhar_ram, have commented on Gerrit. Should I continue here still? | 15:14 |
| *** tbh is now known as tbh_afk | 15:14 | |
| sridhar_ram | janki: no, i'm looking at the comments in gerrit, will respond there | 15:14 |
| janki | sridhar_ram, cool, thanks :) | 15:15 |
| sridhar_ram | janki: beyond this, i know you wanted to discuss vnf-inline-template as well ? | 15:15 |
| janki | sridhar_ram, yes. regarding the specs. | 15:15 |
| janki | Do we still have time for the client patch? | 15:15 |
| sridhar_ram | janki: yeah, looks that work needs a tacker-specs.. | 15:15 |
| janki | or should I wait for spec approval? | 15:16 |
| janki | sridhar_ram, ^^ | 15:16 |
| sridhar_ram | janki: the effort and implication seems to be non-trivial.. i think we shd get started writing the tacker-specs | 15:16 |
| sridhar_ram | janki: this will be your first i believe, correct ? :) | 15:17 |
| janki | sridhar_ram, yes. first | 15:17 |
| sridhar_ram | janki: cool, don't worry about this not landing in newton ... | 15:17 |
| sridhar_ram | janki: one general approach i'd suggest for this work.. | 15:18 |
| janki | sridhar_ram, please.. | 15:18 |
| sridhar_ram | janki: ... to continue to make use of the VNFD / VNFDAttributes db tables.. but someone "mark" those VNFDs as "private" or internal so that it doesn't show up in the VNFD Catalog... | 15:19 |
| sridhar_ram | janki: any other approach will be too much surgery of the code base, with very less benefit | 15:20 |
| sridhar_ram | janki: having this in-line template in VNFD table will also help trozet's vnffgd lookups as well | 15:20 |
| janki | sridhar_ram, I think the code changes need to be done only till _create_device_pre(). I have a code with if-else to accomodate non db-existing templates. We can have a look at both approaches. | 15:21 |
| janki | sridhar_ram, also the template needs to be mentioned somewhere for any future reference | 15:22 |
| janki | sridhar_ram, I was thinking to have it stored in "attributes" but your suggestion seems more reasonable | 15:23 |
| *** dkushwaha has quit IRC | 15:23 | |
| *** dkushwaha__ is now known as dkushwaha | 15:24 | |
| sridhar_ram | janki: sure, we can discuss multiple options... are you comfortable writing a tacker-specs for this ? | 15:24 |
| janki | sridhar_ram, yes I am comfortable. I may need guidance/help here and there | 15:24 |
| sridhar_ram | janki: sure, anytime.. this will be a good exposure for you | 15:25 |
| janki | sridhar_ram, not just in tacker, it is my first time writing any spec :) | 15:25 |
| sridhar_ram | janki: super :) | 15:25 |
| janki | sridhar_ram, agreed. | 15:25 |
| janki | sridhar_ram, thanks for giving me such opportunity :) | 15:27 |
| sridhar_ram | janki: sure, there are tons to do .. so this is just a warm up ;-) | 15:28 |
| janki | sridhar_ram, 1 more thing. This bug https://bugs.launchpad.net/tacker/+bug/1591914 | 15:32 |
| openstack | Launchpad bug 1591914 in tacker "validate vnfd before persisting it in db" [Undecided,Confirmed] - Assigned to Janki Chhatbar (jankihchhatbar) | 15:32 |
| janki | sridhar_ram, IMO the logic would be to check for "tosca template" otherwsie raise an exception. So this could be moved to next cycle where are removing the support of legacy templates as well using the same logic. | 15:33 |
| sridhar_ram | janki: this bug seems to be a duplicate of https://bugs.launchpad.net/tacker/+bug/1483953 | 15:42 |
| openstack | Launchpad bug 1483953 in tacker "RFE: Introduce tacker-validate template validation for VNFD" [Low,In progress] - Assigned to Neeldhwaj Pathak (neel) | 15:42 |
| sridhar_ram | janki: neel already has a patchset for that | 15:42 |
| janki | sridhar_ram, ohh, ohk | 15:44 |
| sridhar_ram | janki: they are related .. one is asking to fail for "invalid" templates and another asking for "is-valid" like API / CLI | 15:45 |
| janki | sridhar_ram, this one adds a command to pre-validate a template before using, correct? | 15:47 |
| *** tbh_afk is now known as tbh | 15:48 | |
| janki | sridhar_ram, this https://review.openstack.org/#/c/333852/7/tacker/vm/plugin.py L620 should also be called in create_vnfd() to test for the templates that are not pre-validated. | 15:49 |
| janki | sridhar_ram, also currently tacker allows vnfd creation with HOT template as well. this issue too needs to be addressesd | 15:50 |
| *** dkushwaha has quit IRC | 15:56 | |
| *** dkushwaha has joined #tacker | 16:08 | |
| openstackgerrit | dharmendra kushwaha proposed openstack/python-tackerclient: Removing test cases for already removed methods https://review.openstack.org/361027 | 16:08 |
| *** links has joined #tacker | 16:44 | |
| *** sripriya has joined #tacker | 16:50 | |
| *** Murali_ has joined #tacker | 17:10 | |
| sridhar_ram | janki: tacker allowing HOT templates in VNFD is actually a good bug to have ;-) | 17:11 |
| janki | sridhar_ram, ohh, I believe the bug that i mentioned is becasue HOT is allowed :P | 17:12 |
| sridhar_ram | janki: we will make use of this bug to make an official feature out of it :) | 17:13 |
| janki | sridhar_ram, cool...this should be documented too somewhere | 17:13 |
| *** manikanta_tadi has joined #tacker | 17:14 | |
| sridhar_ram | janki: yes, once we some func & unit tests we can make it an official capability | 17:14 |
| janki | sridhar_ram, I would take to own this up | 17:15 |
| sridhar_ram | janki: sure, can you write a blueprint in https://blueprints.launchpad.net/tacker/ to keep this in our queue ? | 17:16 |
| janki | sridhar_ram, sure. will submit 1 in 2 3 days | 17:17 |
| sridhar_ram | janki: this is not a priority, we have many other loose ends to tie for newton release on the server side.. | 17:19 |
| sridhar_ram | janki: your help will be much appreciated there | 17:20 |
| *** santoshk has joined #tacker | 17:20 | |
| janki | sridhar_ram, sure..will look into those as well... | 17:21 |
| sridhar_ram | sripriya: https://review.openstack.org/341389 ready for merge ? | 17:21 |
| sripriya | sridhar_ram: merged it now | 17:22 |
| sridhar_ram | sripriya: jenkins failure in ur patchset.. on pagination ? that beats me .. http://logs.openstack.org/06/360806/2/check/gate-python-tackerclient-python27-ubuntu-xenial/67e3a27/testr_results.html.gz | 17:26 |
| sridhar_ram | sripriya: any clues ? | 17:26 |
| sripriya | sridhar_ram: yup same here, the issue is not seen when i test locally | 17:27 |
| sripriya | sridhar_ram: zooming on it | 17:27 |
| sridhar_ram | sripriya: okay.. | 17:27 |
| sridhar_ram | tbh: ping | 17:28 |
| tbh | sridhar_ram, pong | 17:28 |
| sridhar_ram | tbh: we are close to client release deadline ... any chance your are available over the weekend to merge any last minute patchsets ? | 17:30 |
| tbh | sridhar_ram, yup sure | 17:30 |
| sridhar_ram | tbh: thanks a lot .. ! | 17:31 |
| sridhar_ram | tbh: we will switch focus to server side patchsets after this release.. including your VNFC | 17:32 |
| sridhar_ram | I mean "after this tackerclient release" | 17:32 |
| tbh | sridhar_ram, sure, that would be helpful | 17:32 |
| *** janki has quit IRC | 17:34 | |
| *** vishwanathj has quit IRC | 17:38 | |
| *** vishwanathj has joined #tacker | 17:39 | |
| openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Functional test for static ip support and anti_spoof_protection fields in tosca template https://review.openstack.org/324101 | 18:02 |
| sridhar_ram | tbh: sripriya: please review new ocata specs dir .. https://review.openstack.org/#/c/358156/ ? | 18:05 |
| tbh | sridhar_ram, sure | 18:17 |
| *** manikanta_tadi has quit IRC | 18:17 | |
| dkushwaha | sripriya, hi | 18:30 |
| *** s3wong has joined #tacker | 18:34 | |
| sripriya | sridhar_ram: ack | 18:36 |
| sripriya | dkushwaha: hello | 18:36 |
| dkushwaha | sripriya, while executing the test tackerclient.tests.unit.test_cli10_event.CLITestV10EventJSON , i am getting error : http://paste.openstack.org/show/564047/ | 18:36 |
| dkushwaha | sripriya, any clue on this | 18:36 |
| dkushwaha | sripriya, actually while i am fixing to https://bugs.launchpad.net/python-tackerclient/+bug/1617157 , there are several issues occurring | 18:38 |
| openstack | Launchpad bug 1617157 in python-tackerclient "Unit test under tackerclient/tests/unit are not getting executed" [Medium,In progress] - Assigned to dharmendra (dharmendra-kushwaha) | 18:38 |
| *** amotoki has quit IRC | 18:40 | |
| sripriya | dkushwaha: the event test cases are not executed at all on gate | 18:40 |
| dkushwaha | sripriya, so should we this as it is? | 18:41 |
| dkushwaha | should we keep | 18:41 |
| sripriya | dkushwaha: i think we should add this under vm dir. for now, since we need the unit tests | 18:44 |
| sripriya | dkushwaha: and for the errors, they are genuine, i would request the author to fix these test errors | 18:45 |
| sripriya | vishwanathj: ^^ | 18:45 |
| sripriya | sridhar_ram: ping | 18:45 |
| dkushwaha | sripriya, ok, but regarding fixing to https://bugs.launchpad.net/python-tackerclient/+bug/1617157 , I am changing OS_TEST_PATH: ./tackerclient/tests/unit/vm to /tackerclient/tests/unit/ | 18:48 |
| openstack | Launchpad bug 1617157 in python-tackerclient "Unit test under tackerclient/tests/unit are not getting executed" [Medium,In progress] - Assigned to dharmendra (dharmendra-kushwaha) | 18:48 |
| sripriya | sridhar_ram: regarding the py27 error on the client patch, quick analysis explains the error possibility, which is the pagination support by default is false for vnf_resource and the whole response is sent off in the 1st query, the 2nd query for pagination request in never executed at all , hence test case fails with a None response for the 2nd part of query | 18:48 |
| dkushwaha | sripriya, so in that case all test will be executed and gate will fail. | 18:48 |
| sripriya | dksuhwaha: i think this requires fixing all tests cases in other modules and files relating to neutron | 18:48 |
| dkushwaha | sripriya, right | 18:49 |
| sripriya | dksuwaha: i know you are already taking up the test refactoring | 18:50 |
| sripriya | dkushwaha: you can fix path as part of the refactoring | 18:50 |
| sripriya | sridhar_ram: one thing i’m not sure why it only failed once (and on the patch unrelated to my changes), why wasn’t it seen earlier is something i dont know yet | 18:51 |
| dkushwaha | sripriya, ok fine. Thanks | 18:51 |
| sripriya | dkushwaha: thank you | 18:52 |
| sripriya | trozet: ping | 18:52 |
| trozet | sripriya: hi | 18:52 |
| openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Functional test for static ip support and anti_spoof_protection fields in tosca template https://review.openstack.org/324101 | 18:52 |
| sripriya | trozet: http://logs.openstack.org/06/360806/2/check/gate-python-tackerclient-python27-ubuntu-xenial/67e3a27/console.html#_2016-08-26_08_00_54_237907 | 18:52 |
| sripriya | trozet: to confirm, you dont intent to provide list_vnf_resources pagination right, wondering why the pagination test case was added since pagination_support is false | 18:53 |
| trozet | sripriya: i just added it because the other list commands included pagination (although some of the other unit tests for vnf were not right, their method declared "tests_pagination" but really htey just called the regular list test method | 18:55 |
| sripriya | trozet: yesi saw that, but as it appears the test case failed because the response was null for the fake_query | 18:55 |
| trozet | sripriya: one sec | 18:56 |
| sripriya | trozet: but i’m not sure why it only failed on gate, but is not reproducible locally or any of yours or others client patches | 18:56 |
| *** vishwanathj has quit IRC | 18:56 | |
| trozet | sripriya: it specifically passed in my setup, because i ran just that test case to make sure it worked | 18:57 |
| *** vishwanathj has joined #tacker | 18:57 | |
| trozet | sripriya: let me pull it up one sec | 18:57 |
| sridhar_ram | dkushwaha: sripriya: here is the suggestion to bring in the tests in tests/unit level .. (a) remove neutron specific tests and (b) mark possible tacker tests but broken at this time and mark them disabled no_test_xyz() and (c) fix the actual test contents in phases and enable by removing the "no_" prefix | 18:58 |
| *** vishnoianil has joined #tacker | 18:59 | |
| sripriya | trozet: i ran that test on my local setup too and dont see the error reproduced, but one observation is, the response {api_resource: [{'id': 'myid3', }, | 18:59 |
| sripriya | {'id': 'myid4', }]} was returned with the 1st part of response itself with reses1 = {api_resource: [{'id': 'myid1', }, | 18:59 |
| sripriya | {'id': 'myid2', }], | 18:59 |
| sripriya | sridhar_ram: what about the events tests cases? | 19:00 |
| trozet | sripriya: i only see the regular _test_list_resources_with_pagination, used in a single test casxe | 19:00 |
| trozet | case | 19:00 |
| trozet | sripriya: looks liike in the test_cli10_event.py file | 19:01 |
| trozet | sripriya: does that one pass? | 19:01 |
| sridhar_ram | trozet: sripriya: when u are done w/ this pagination topic, can you please look at the comment in the server patch on "error_reason" for resource-list .. https://review.openstack.org/#/c/340838/25/tacker/vm/plugin.py@638 ? | 19:02 |
| *** tbh has quit IRC | 19:04 | |
| sripriya | trozet: that one is not tested at all and has errors | 19:04 |
| trozet | sripriya: ok i took the same exact method to make my pagination sub_resources one | 19:04 |
| trozet | sripriya: so im guessing there is a flaw in the logic of the method | 19:05 |
| trozet | sripriya: so what do we do? fix the flaw and modify the vnf pagination cases to use the real pagination test? | 19:05 |
| sripriya | trozet: hmm, or it could be that pagination support is expected to be enabled in both vnf_resources and events which is not the case | 19:05 |
| sripriya | sridhar_ram: vishwanathj: if we plan to include events test cases we need to ASAP to move it to vm dir and fix all the events_path not found errors | 19:06 |
| sripriya | sridhar_ram: reg: error_reason will do | 19:06 |
| sridhar_ram | sripriya: sorry, r u referring to events unit tests in tackerclient ? | 19:07 |
| sripriya | sridhar_ram: yes | 19:07 |
| sripriya | sridhar_ram: none of the test cases pass | 19:08 |
| sridhar_ram | sripriya: vishwanathj: ouch, https://github.com/openstack/python-tackerclient/blob/master/tackerclient/tests/unit/test_cli10_event.py ... | 19:10 |
| sridhar_ram | vishwanathj: can u quickly scrub ? | 19:10 |
| sridhar_ram | vishwanathj: can u manually run this and make any fixes to required to pass ? | 19:11 |
| sripriya | trozet: for now, i will remove the pagination test case for list_vnf_resources since we do not have that enabled for list_vnf_resources | 19:11 |
| sridhar_ram | vishwanathj: sripriya: we will figure out a way to alter testr.conf separately | 19:12 |
| sripriya | sridhar_ram: ack | 19:12 |
| sridhar_ram | sripriya: trozet: +1 to removing pagination test for now | 19:13 |
| sridhar_ram | sripriya: is this an intermittent issue ? Wonderful how it passed the initial patchset gate test | 19:14 |
| trozet | sridhar_ram: ok maybe just leave the test_sub_resources method, and just remove the test from vnf test file | 19:14 |
| sripriya | sridhar_ram: that is a mystery which i’m still uncovering, of how it passed through | 19:14 |
| sridhar_ram | trozet: sounds good...who is doing the change ? | 19:14 |
| sripriya | trozet: yes, doing the same, | 19:14 |
| sridhar_ram | sripriya: sounds good | 19:15 |
| sripriya | sridhar_ram: should this be a separate patch or can it go with the patch for yaml dict? | 19:15 |
| sridhar_ram | sripriya: separate pls | 19:15 |
| trozet | sripriya: do you want me to print the output | 19:15 |
| trozet | sripriya: locally | 19:15 |
| sripriya | trozet: did you want to take it up? | 19:15 |
| trozet | sripriya: to compare | 19:15 |
| sripriya | trozet: sure please | 19:15 |
| sripriya | dkushwaha: thanks for bringing up the events issue | 19:16 |
| sridhar_ram | Folks - i'm considering to disable "VnfTestPingMonitor.test_create_delete_vnf_monitoring_tosca_template" testcase temporarily until we cross the newton release deadlines and re-enable after. This testcase is causing too many false negatives. Just wastes too much developer and CI resource times (with rechecks). Thoughts? | 19:20 |
| trozet | sripriya: i get <tackerclient.tests.unit.test_cli10.MyResp object at 0x7f319b6aa910>, '{"resources": [{"id": "myid3"}, {"id": "myid4"}]}' | 19:21 |
| sridhar_ram | s3wong: ping, need your help. are you around this afternoon as we need to land few last minute client fixes toward newton tackerclient release | 19:21 |
| vishwanathj | sripriya, sridhar_ram hi....back from lunch now....allow me to catch up | 19:22 |
| sridhar_ram | vishwanathj: sure, thanks | 19:22 |
| *** sridhar_ram is now known as sridhar_ram_afk | 19:22 | |
| trozet | sripriya: i'm wondering if it is a pip library that is not the same | 19:25 |
| sripriya | trozet: which library? | 19:25 |
| trozet | sripriya: not sure, i just check requests, but that is fine | 19:26 |
| *** saju_m has joined #tacker | 19:26 | |
| trozet | sripriya: you notice in the log the fake_query is backwards? | 19:26 |
| trozet | - request.__call__('localurl/v1.0/vnfs/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/resources.json?limit=2&marker=myid2' | 19:26 |
| trozet | + request.__call__('localurl/v1.0/vnfs/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/resources.json?marker=myid2&limit=2' | 19:26 |
| trozet | fake_query = "marker=myid2&limit=2" | 19:27 |
| trozet | sripriya: happening during serialize? | 19:28 |
| sripriya | trozet: may be, not sure | 19:28 |
| trozet | sripriya: oslo.serialization==2.13.0 # git sha 1f86a66 | 19:29 |
| trozet | sripriya: looks same as what i have | 19:30 |
| sripriya | trozet: is that causing problem? | 19:30 |
| vishwanathj | dkushwaha hi | 19:31 |
| trozet | sripriya, sridhar_ram_afk: i see hte problem | 19:32 |
| trozet | sripriya: its the cliff version | 19:32 |
| trozet | Exception: (<tackerclient.tests.unit.test_cli10.MyResp object at 0x7f7fad950810>, '{"resources_links": [{"href": "localurl/v1.0/vnfs/aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa/resources.json?marker=myid2&limit=2", "rel": "next"}], "resources": [{"id": "myid1"}, {"id": "myid2"}]}') | 19:32 |
| vishwanathj | dkushwaha do you mind sharing the tacker --version output on your styems | 19:32 |
| dkushwaha | vishwanathj, hello | 19:32 |
| trozet | sripriya: with cliff-2.0.0 it passes | 19:32 |
| vishwanathj | dkushwaha this is with regards to errors in http://paste.openstack.org/show/564047/ | 19:33 |
| dkushwaha | vishwanathj, it is 0.5.1 | 19:33 |
| sripriya | trozet: gate is running cliff 2.2.0, how did it pass then in earlier patches | 19:33 |
| *** links has quit IRC | 19:33 | |
| *** vishwanathj has quit IRC | 19:34 | |
| trozet | sripriya: oh wait nvm | 19:34 |
| *** vishwanathj has joined #tacker | 19:35 | |
| vishwanathj | dkushwaha you need 0.6 .... i am assuming you are testing on a devstack system right,? would be good if you run devstack that will pull in the latest tacker-client patch | 19:36 |
| vishwanathj | dkushwaha I suspect that your devstack install is older | 19:36 |
| trozet | sripriya: hold on ive reproduced hte problem...narrowing it down | 19:36 |
| *** vishwanathj has quit IRC | 19:37 | |
| *** vishwanathj has joined #tacker | 19:38 | |
| dkushwaha | vishwanathj, instead of running devstack, will it be ok, if i manually clone the client and install it? | 19:38 |
| vishwanathj | to rule out other issues, I would recommend to install the latest devstack | 19:39 |
| vishwanathj | lot of patchsets have merged | 19:39 |
| dkushwaha | vishwanathj, ok, i will do it | 19:40 |
| *** vishnoianil has quit IRC | 19:41 | |
| vishwanathj | dkushwaha thanks...that way we do not have to waste time on other issues that may crop up | 19:41 |
| trozet | sripriya: yeah its cliff | 19:41 |
| *** xiayu1 has joined #tacker | 19:43 | |
| trozet | sripriya: actually its random | 19:44 |
| trozet | LOL | 19:44 |
| trozet | sripriya:https://paste.fedoraproject.org/414672/ | 19:45 |
| trozet | sripriya: ah i think its the serialize randomly swithcing the URL | 19:46 |
| sripriya | trozet: that is what i think as well, give me a moment | 19:46 |
| *** xiayu has quit IRC | 19:47 | |
| trozet | sripriya: got to run, later | 19:48 |
| *** xiayu has joined #tacker | 19:48 | |
| sripriya | trozet: will you be pushing a patch for this? | 19:48 |
| trozet | sripriya: can you? I will be offline for a while | 19:48 |
| sripriya | trozet: done | 19:48 |
| trozet | sripriya: cool. thanks. | 19:48 |
| *** sridhar_ram_afk is now known as sridhar_ram | 19:49 | |
| sridhar_ram | vishwanathj: it is better if you can try this ur testbed... to get to the bottom of this quickly | 19:49 |
| sridhar_ram | vishwanathj: in fact, i see a issue with wrong resource used in the list .. https://github.com/openstack/python-tackerclient/blob/master/tackerclient/tests/unit/test_cli10_event.py#L67 | 19:50 |
| *** xiayu1 has quit IRC | 19:50 | |
| sridhar_ram | vishwanathj: looks this slipped through the review :( | 19:50 |
| vishwanathj | sridhar_ram sure....but its very clear in dkushwaha setup, he does not have the client library that has the event related code | 19:51 |
| vishwanathj | sigh | 19:51 |
| vishwanathj | cut and paste error | 19:51 |
| sridhar_ram | vishwanathj: this is a unit test, which we can directly run on the git repo ? | 19:51 |
| openstackgerrit | Sripriya Seetharam proposed openstack/python-tackerclient: Remove list_vnf_resource_pagination unit test https://review.openstack.org/361444 | 19:58 |
| vishwanathj | sridhar_ram the command executed by dkushwaha (refer L1 at http://paste.openstack.org/show/564047/) passes on my latest devstacj | 19:59 |
| vishwanathj | s/devstacj/devstack | 20:00 |
| vishwanathj | sridhar_ram I will open a bug for your finding at https://github.com/openstack/python-tackerclient/blob/master/tackerclient/tests/unit/test_cli10_event.py#L67 and push a patchset soon....let me know if I should do that now | 20:01 |
| dkushwaha | vishwanathj, can you please modify the path in testr.conf with /tackerclient/tests/unit and re execute the test again? | 20:03 |
| sripriya | vishwanathj: the test cases are failing on my system as well | 20:05 |
| *** sridhar_ram has quit IRC | 20:05 | |
| sripriya | vishwanathj: AttributeError: 'Client' object has no attribute 'vnfd_events_path' | 20:05 |
| vishwanathj | sripriya what's the output of the command tacker --version on your devstack system? | 20:05 |
| sripriya | vishwanathj: i’m running tackerclient master | 20:06 |
| openstackgerrit | Sridhar Ramaswamy proposed openstack/python-tackerclient: Deprecate infra_driver and mgmt_driver https://review.openstack.org/360345 | 20:06 |
| sripriya | vishwanathj: not pip pkg | 20:06 |
| sripriya | vishwanathj: the above error is trying to search for vnfd_events patch variable which is not defined in client file | 20:07 |
| vishwanathj | sripriya do you mind still sharing the output of the tacker --version command? Thanks | 20:07 |
| dkushwaha | sripriya, vishwanathj I also did the same, not pip pkg | 20:07 |
| sripriya | vishwanathj: refer https://github.com/openstack/python-tackerclient/blob/master/tackerclient/v1_0/client.py#L347-L348 | 20:09 |
| dkushwaha | vishwanathj, once after setting up my system, i used to manually install master branch . | 20:09 |
| sripriya | vishwanathj: http://paste.openstack.org/show/564058/ | 20:09 |
| sripriya | vishwanathj: these test cases are not executed on gate since they are not under vm dir. | 20:11 |
| vishwanathj | dkushwaha where is the location of testr.conf? | 20:12 |
| vishwanathj | sripriya dkushwaha I have the latest devstack that installs 0.6.0 tackerclient and I execute dkushwaha command and it passes .. refer http://paste.openstack.org/show/564059/ | 20:14 |
| sripriya | vishwanathj: this is did not run any tests at all as per the output in your paste link | 20:15 |
| vishwanathj | HHmm | 20:16 |
| vishwanathj | wow | 20:16 |
| sripriya | vishwanathj: usually you see something like this in outputL Ran 40 (+14) tests in 1.210s (+0.476s | 20:16 |
| vishwanathj | You are right, I used to see that for the server tests | 20:17 |
| sripriya | vishwanathj: you can try to run locally in IDE, the tests have logical errrors which is why its failing | 20:17 |
| sripriya | sridhar_ram: s3wong: please review https://review.openstack.org/#/c/361444/ | 20:19 |
| dkushwaha | vishwanathj, ".tester.conf" in parent dir of client | 20:20 |
| vishwanathj | dkushwaha got it | 20:22 |
| openstackgerrit | Sridhar Ramaswamy proposed openstack/python-tackerclient: Deprecate infra_driver and mgmt_driver https://review.openstack.org/360345 | 20:26 |
| *** ksantoshk has joined #tacker | 20:36 | |
| *** ksk has joined #tacker | 20:37 | |
| *** santoshk has quit IRC | 20:38 | |
| *** ksantoshk has quit IRC | 20:41 | |
| *** sridhar_ram has joined #tacker | 20:48 | |
| *** saju_m has quit IRC | 21:05 | |
| *** sridhar_ram is now known as sridhar_ram_afk | 21:06 | |
| *** vishnoianil has joined #tacker | 21:13 | |
| *** vishwanathj has quit IRC | 21:22 | |
| *** vishwanathj has joined #tacker | 21:23 | |
| *** xiayu1 has joined #tacker | 21:28 | |
| openstackgerrit | Merged openstack/python-tackerclient: Remove list_vnf_resource_pagination unit test https://review.openstack.org/361444 | 21:30 |
| *** xiayu2 has joined #tacker | 21:31 | |
| *** xiayu has quit IRC | 21:32 | |
| *** xiayu1 has quit IRC | 21:33 | |
| *** vishwanathj has quit IRC | 21:48 | |
| *** vishwanathj has joined #tacker | 21:49 | |
| openstackgerrit | Santosh Kodicherla proposed openstack/tacker: Functional test for static ip support and anti_spoof_protection fields in tosca template https://review.openstack.org/324101 | 21:57 |
| *** vishwanathj has quit IRC | 22:14 | |
| *** vishwanathj has joined #tacker | 22:15 | |
| *** vishwanathj has quit IRC | 22:22 | |
| *** vishwanathj has joined #tacker | 22:23 | |
| openstackgerrit | Merged openstack/python-tackerclient: Deprecate infra_driver and mgmt_driver https://review.openstack.org/360345 | 22:34 |
| *** vishwanathj has quit IRC | 22:35 | |
| *** vishwanathj has joined #tacker | 22:36 | |
| *** ksk has quit IRC | 22:37 | |
| *** sripriya has quit IRC | 22:52 | |
| *** sripriya has joined #tacker | 23:02 | |
| *** sridhar_ram_afk has quit IRC | 23:03 | |
| openstackgerrit | Sripriya Seetharam proposed openstack/python-tackerclient: Modify MyURLComparator to handle deep match on URL https://review.openstack.org/361521 | 23:19 |
| *** sridhar_ram_afk has joined #tacker | 23:22 | |
| openstackgerrit | Murali Birru proposed openstack/tacker: Added nova instance id to heat template outputs sections https://review.openstack.org/361523 | 23:28 |
| openstackgerrit | Merged openstack/python-tackerclient: cli: modify vnfd, param & config attr. to dict obj https://review.openstack.org/360806 | 23:33 |
| *** amit213 has quit IRC | 23:37 | |
| *** amit213 has joined #tacker | 23:40 | |
| *** vishwanathj has quit IRC | 23:40 | |
| *** vishwanathj has joined #tacker | 23:41 | |
| *** sridhar_ram_afk has quit IRC | 23:46 | |
| *** sripriya has quit IRC | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!