| *** uck has quit IRC | 00:19 | |
| *** amotoki has joined #tacker | 00:37 | |
| *** amotoki has quit IRC | 00:41 | |
| openstackgerrit | Merged openstack/tacker master: Updated from global requirements https://review.openstack.org/445760 | 00:59 |
|---|---|---|
| *** amotoki has joined #tacker | 01:45 | |
| *** amotoki has quit IRC | 01:50 | |
| *** s3wong has quit IRC | 01:51 | |
| *** vishnoianil has quit IRC | 02:00 | |
| *** bobh has joined #tacker | 03:09 | |
| *** bobh has quit IRC | 03:32 | |
| *** amotoki has joined #tacker | 03:46 | |
| *** amotoki has quit IRC | 03:51 | |
| *** bobh has joined #tacker | 03:56 | |
| *** bobh has quit IRC | 04:01 | |
| *** gongysh has joined #tacker | 04:27 | |
| openstackgerrit | Merged openstack/tacker master: fix function tacker_check_and_download_cirros() error https://review.openstack.org/441080 | 04:32 |
| openstackgerrit | Merged openstack/tacker master: Replace yaml.load with yaml.safe_load; Replace yaml.dump with yaml.safe_dump; https://review.openstack.org/445784 | 04:35 |
| openstackgerrit | qtlu proposed openstack/tacker master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/446843 | 04:45 |
| *** KanagarajM has joined #tacker | 04:47 | |
| *** xianghui has joined #tacker | 04:58 | |
| *** janki has joined #tacker | 05:14 | |
| *** tung_doan_fk has joined #tacker | 05:19 | |
| *** tbh has joined #tacker | 05:46 | |
| *** trinaths has joined #tacker | 05:51 | |
| *** tbh has quit IRC | 05:58 | |
| tung_doan_fk | gongysh: pls help review this serious bug: https://review.openstack.org/#/c/443672/9 | 06:02 |
| tung_doan_fk | thanks | 06:02 |
| gongysh | tung_doan_fk, sure, wait for you recheck result. | 06:03 |
| openstackgerrit | gongysh proposed openstack/tacker-specs master: introduce a scalable task scheduling framework https://review.openstack.org/439300 | 06:10 |
| gongysh | tung_doan_fk, hi | 06:11 |
| *** vishnoianil has joined #tacker | 06:12 | |
| tung_doan_fk | gongysh: hi there | 06:14 |
| gongysh | do you want to do vim worker under task scheduling framework? | 06:14 |
| gongysh | if so, I will add your name in task scheduling BP | 06:15 |
| *** tbh has joined #tacker | 06:15 | |
| tung_doan_fk | gongysh: initially i have a patch for monitoring worker: https://blueprints.launchpad.net/tacker/+spec/vnf-policy-monitoring-worker | 06:16 |
| tung_doan_fk | gongysh: could i have chance to do it? | 06:16 |
| tung_doan_fk | gongysh: if so, pls add me to your bp | 06:16 |
| tung_doan_fk | gongysh: this patch https://review.openstack.org/#/c/443929/ may support for the future work | 06:17 |
| *** Vijayendra has joined #tacker | 06:30 | |
| openstackgerrit | gongysh proposed openstack/tacker master: Provide a tool to generate a VNFC image https://review.openstack.org/445848 | 06:32 |
| gongysh | tung_doan_fk, yes. I will assign vnf-policy-monitoring-worker to you. | 06:33 |
| tung_doan_fk | gongysh: thanks. :) | 06:34 |
| gongysh | tung_doan_fk, for https://review.openstack.org/#/c/443929/4/tacker/vnfm/monitoring_policy.py, I thought you agreed to separate the policy class into their own python file. | 06:35 |
| tung_doan_fk | gongysh: yes.. i will use an abstract class and have separated classes for monitoring policies. Is it ok for you? | 06:37 |
| gongysh | fine | 06:44 |
| tung_doan_fk | gongysh: thanks.. will upload new changes tomorrow | 06:45 |
| openstackgerrit | gongysh proposed openstack/tacker master: Fix monitoring issue for multiple VDUs https://review.openstack.org/443672 | 06:55 |
| openstackgerrit | gongysh proposed openstack/tacker-specs master: introduce a scalable task scheduling framework https://review.openstack.org/439300 | 06:58 |
| *** tung_doan_fk has quit IRC | 07:06 | |
| *** gongysh has quit IRC | 07:07 | |
| *** gongysh has joined #tacker | 07:10 | |
| *** giuseppe1992 has joined #tacker | 07:17 | |
| trinaths | gongysh: Hi | 07:20 |
| trinaths | gongysh: I'm try the mox patch, but was not good in modifying it, here a try http://paste.openstack.org/show/603078/ I was unable find the error. any clues ? | 07:21 |
| gongysh | trinaths, resp = self.client.request(ENDPOINT_URL + '/resource', 'GET', | 07:33 |
| gongysh | headers={} | 07:33 |
| trinaths | gongysh: yes. | 07:34 |
| trinaths | gongysh: any error there ? | 07:34 |
| trinaths | gongysh: as you see, the expected call and actual call are the same. | 07:34 |
| gongysh | trinaths, you cannot do this way. | 07:41 |
| gongysh | this test nothings | 07:41 |
| gongysh | test -> tests. | 07:41 |
| gongysh | trinaths, test client.do_request just like before in this function. | 07:43 |
| *** amotoki has joined #tacker | 07:48 | |
| *** amotoki has quit IRC | 07:52 | |
| trinaths | gongysh: oh! ok | 07:55 |
| trinaths | gongysh: then for client.request, its the mock test way | 07:57 |
| trinaths | gongysh: rather than using stuboutwithmock, i have used @mock.patch.object | 07:58 |
| trinaths | gongysh: and moved mox, to mock based. | 07:58 |
| gongysh | that is fine | 07:58 |
| trinaths | gongysh: as you can see in the test-run, below the code, expected and actual call are the same. but it returns an error. | 07:59 |
| trinaths | gongysh: was unable to plot the cause for the same. | 07:59 |
| gongysh | trinaths, test codes should work like this: tested_code() that will be call b.c() | 08:01 |
| trinaths | gongysh: so where I'm wrong | 08:01 |
| trinaths | gongysh: at http://paste.openstack.org/show/603078/ | 08:01 |
| gongysh | in test case: mock b.c which will be called by tested_code, and then call tested_code in your test case, and then assert b.c() is called liked exepcted way. | 08:02 |
| trinaths | gongysh: agreed. | 08:03 |
| gongysh | trinaths, then you can look at your code. | 08:03 |
| gongysh | you are call b.c that is mocked. | 08:03 |
| gongysh | call -> calling | 08:03 |
| gongysh | so it tests nothing at all. | 08:04 |
| trinaths | gongysh: like this, http://paste.openstack.org/show/603083/ | 08:05 |
| gongysh | the client.do_request should be the tested code like before, the client.request is the mocked | 08:05 |
| gongysh | you should compare your case with previous one. | 08:06 |
| trinaths | gongysh: then mock is not required here. | 08:07 |
| gongysh | @mock.patch('tackerclient.client.HTTPClient.request') | 08:08 |
| gongysh | def test_get_noauth(self, mock_request): | 08:08 |
| gongysh | client.do_request(xxxx ) | 08:08 |
| gongysh | mock_request.assert_called_once_with( | 08:08 |
| gongysh | ENDPOINT_URL + '/resource', 'GET', | 08:08 |
| gongysh | headers=test.MatchType(dict)) | 08:08 |
| trinaths | gongysh: ah! do_request must be tested before, | 08:08 |
| gongysh | the client's do_request is the target tested code, the request() is the mocked one. and then assert the request() is called like expected way. | 08:09 |
| trinaths | gongysh: understood my error. thank you sir. | 08:10 |
| openstackgerrit | gongysh proposed openstack/tacker master: Arrange unit test codes according to tested code directory https://review.openstack.org/446890 | 08:37 |
| *** diga has joined #tacker | 09:12 | |
| *** yifei has quit IRC | 09:21 | |
| *** trinaths has left #tacker | 09:27 | |
| *** giuseppe1992 has quit IRC | 09:33 | |
| *** amotoki has joined #tacker | 09:48 | |
| openstackgerrit | gongysh proposed openstack/tacker master: Fix file exists bug when creating network in devstack. https://review.openstack.org/445311 | 09:52 |
| *** amotoki has quit IRC | 09:53 | |
| *** saju_m has joined #tacker | 09:53 | |
| *** trinaths has joined #tacker | 10:02 | |
| *** trinaths has left #tacker | 10:30 | |
| *** KanagarajM has quit IRC | 10:35 | |
| *** janki has quit IRC | 10:44 | |
| openstackgerrit | gongysh proposed openstack/tacker master: Arrange unit test codes according to tested code directory https://review.openstack.org/446890 | 10:55 |
| *** gongysh has quit IRC | 10:56 | |
| *** xianghui has quit IRC | 11:06 | |
| *** giuseppe1992 has joined #tacker | 11:08 | |
| giuseppe1992 | Hi | 11:09 |
| tung_doan | giuseppe1992: Hi there | 11:30 |
| *** amotoki has joined #tacker | 11:49 | |
| *** amotoki has quit IRC | 11:53 | |
| *** tbh has quit IRC | 12:14 | |
| *** mohankumar has quit IRC | 12:15 | |
| *** trinaths has joined #tacker | 13:03 | |
| *** amotoki has joined #tacker | 13:29 | |
| *** amotoki has quit IRC | 13:33 | |
| *** KanagarajM has joined #tacker | 13:38 | |
| *** diga has quit IRC | 13:38 | |
| *** KanagarajM has quit IRC | 13:38 | |
| *** KanagarajM has joined #tacker | 13:45 | |
| *** gongysh has joined #tacker | 14:06 | |
| *** bobh has joined #tacker | 14:07 | |
| *** bobh has quit IRC | 14:07 | |
| *** bobh has joined #tacker | 14:07 | |
| *** KanagarajM has quit IRC | 14:08 | |
| *** KanagarajM has joined #tacker | 14:08 | |
| gongysh | sridhar_ram, KanagarajM , dkushwaha , what are your comments about https://review.openstack.org/439300 | 14:11 |
| gongysh | I think tung_doan diga have agreed. | 14:12 |
| *** saju_m has quit IRC | 14:22 | |
| *** KanagarajM has quit IRC | 14:25 | |
| *** KanagarajM has joined #tacker | 14:26 | |
| *** KanagarajM has quit IRC | 14:27 | |
| *** KanagarajM has joined #tacker | 14:27 | |
| *** gongysh has quit IRC | 14:39 | |
| *** Vijayendra has quit IRC | 14:42 | |
| *** KanagarajM has quit IRC | 15:07 | |
| *** KanagarajM has joined #tacker | 15:13 | |
| *** KanagarajM has quit IRC | 15:24 | |
| *** uck has joined #tacker | 15:46 | |
| giuseppe1992 | Hi, I'm trying to install tacker. I'm following this https://docs.openstack.org/developer/tacker/install/manual_installation.html. When I try to register the default VIM with :"tacker vim-register --is-default --config-file config.yaml --description 'Openstack Liberty' Site1". the output is: "No handlers could be found for logger "tackerclient.shell".How can I fix it? | 16:03 |
| *** vishwanathj has joined #tacker | 16:03 | |
| *** giuseppe1992 has quit IRC | 16:12 | |
| *** vishwanathj has quit IRC | 16:17 | |
| *** Vijayendra has joined #tacker | 16:21 | |
| *** uck has quit IRC | 17:00 | |
| *** bobh has quit IRC | 17:23 | |
| *** saju_m has joined #tacker | 17:32 | |
| *** uck has joined #tacker | 17:33 | |
| *** tbh has joined #tacker | 17:47 | |
| *** mohankumar has joined #tacker | 17:47 | |
| *** Vijayendra has quit IRC | 17:53 | |
| *** arturt__ has joined #tacker | 17:59 | |
| *** s3wong has joined #tacker | 18:02 | |
| *** arturt__ has quit IRC | 18:03 | |
| *** mohankumar has quit IRC | 18:14 | |
| *** uck_ has joined #tacker | 18:16 | |
| *** uck has quit IRC | 18:16 | |
| openstackgerrit | bharaththiruveedula proposed openstack/tacker master: Access the controller's mistral endpoint instead of VIM https://review.openstack.org/438211 | 18:17 |
| *** bobh has joined #tacker | 18:23 | |
| *** bobh has quit IRC | 18:28 | |
| *** bobh has joined #tacker | 18:38 | |
| *** vishnoianil has quit IRC | 18:50 | |
| *** arturt__ has joined #tacker | 18:55 | |
| *** uck_ has quit IRC | 19:07 | |
| *** uck has joined #tacker | 19:07 | |
| *** arturt__ has quit IRC | 19:24 | |
| *** uck has quit IRC | 19:31 | |
| *** uck has joined #tacker | 19:34 | |
| *** tbh has quit IRC | 19:35 | |
| *** arturt__ has joined #tacker | 19:37 | |
| *** arturt__ has quit IRC | 19:44 | |
| openstackgerrit | Trinath Somanchi proposed openstack/python-tackerclient master: Refactor mox references to use the mock library in pythontackerclient https://review.openstack.org/429813 | 19:45 |
| *** trinaths has left #tacker | 19:48 | |
| *** arturt__ has joined #tacker | 19:49 | |
| *** vishnoianil has joined #tacker | 19:50 | |
| *** arturt__ has quit IRC | 20:09 | |
| *** arturt__ has joined #tacker | 21:05 | |
| *** s3wong has quit IRC | 21:07 | |
| *** uck has quit IRC | 21:32 | |
| *** uck has joined #tacker | 21:33 | |
| *** arturt__ has quit IRC | 21:37 | |
| *** arturt__ has joined #tacker | 21:37 | |
| *** arturt__ has quit IRC | 21:38 | |
| *** bobh has quit IRC | 22:09 | |
| *** gongysh has joined #tacker | 22:40 | |
| gongysh | dkushwaha, hi | 22:41 |
| *** bobh has joined #tacker | 23:18 | |
| *** bobh has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!