*** bobh has joined #tacker | 00:06 | |
*** bobh has quit IRC | 00:36 | |
*** bhagyashris has joined #tacker | 00:51 | |
*** bobh has joined #tacker | 01:09 | |
*** bobh has quit IRC | 01:31 | |
*** bobh has joined #tacker | 01:32 | |
*** bobh has quit IRC | 01:37 | |
*** Dinesh_Bhor has joined #tacker | 02:26 | |
*** Dinesh_Bhor has quit IRC | 02:31 | |
*** Dinesh_Bhor has joined #tacker | 02:33 | |
*** bobh has joined #tacker | 02:33 | |
*** bobh has quit IRC | 02:38 | |
*** Dinesh_Bhor has quit IRC | 03:04 | |
*** Dinesh_Bhor has joined #tacker | 03:11 | |
*** Dinesh_Bhor has quit IRC | 03:36 | |
*** bobh has joined #tacker | 03:38 | |
*** Dinesh_Bhor has joined #tacker | 03:39 | |
*** bobh has quit IRC | 03:43 | |
*** dkushwaha has joined #tacker | 05:07 | |
*** openstackgerrit has joined #tacker | 06:14 | |
openstackgerrit | Merged openstack/tacker-specs master: Change openstack-dev to openstack-discuss https://review.openstack.org/621916 | 06:14 |
---|---|---|
bhagyashris | dkushwaha, phuoc: Hi, I Would like your some insights on https://review.openstack.org/#/c/614964/ and https://review.openstack.org/#/c/625461/ (stable/rocky) address all the review coments. | 06:21 |
phuoc | bhagyashris, I will look at them :) | 06:31 |
bhagyashris | phuoc: Thank you :) | 06:33 |
phuoc | dkushwaha, I think we can merge this patch https://review.openstack.org/#/c/628940 | 06:35 |
*** Dinesh_Bhor has quit IRC | 06:57 | |
*** dkushwaha has quit IRC | 06:58 | |
*** Dinesh_Bhor has joined #tacker | 07:00 | |
*** dkushwaha has joined #tacker | 07:28 | |
dkushwaha | bhagyashris, ACK | 07:28 |
bhagyashris | dkushwaha: thank you :) | 07:29 |
dkushwaha | phuoc, Ok I will merge it. | 07:29 |
*** Dinesh_Bhor has quit IRC | 07:32 | |
dkushwaha | phuoc, As we facing low reviewer issue, So my suggestion is, if a patch(simple/trivial) already have one +2 and one or two +1, and pending from more than week, we should merge it. wdyt? | 07:34 |
phuoc | dkushwaha, I agree with you | 07:35 |
phuoc | for simple patches :) | 07:35 |
dkushwaha | yup | 07:35 |
dkushwaha | Thanks | 07:35 |
dkushwaha | for complex patches, it will be good if it go through more reviewer | 07:36 |
openstackgerrit | Merged openstack/tacker master: Modify image name to cirros-0.4.0-x86_64-disk https://review.openstack.org/628940 | 07:41 |
*** trinaths has joined #tacker | 07:53 | |
*** trinaths has quit IRC | 07:57 | |
*** trinaths has joined #tacker | 08:00 | |
egonzalez | dkushwaha problem with that statement is to define what is simple/trivial patch and what not | 08:03 |
*** trinaths has quit IRC | 08:03 | |
egonzalez | each core could have different vision about that | 08:03 |
egonzalez | although i think is good idea | 08:04 |
*** trinaths has joined #tacker | 08:04 | |
*** Dinesh_Bhor has joined #tacker | 08:04 | |
*** Dinesh_Bhor has quit IRC | 08:10 | |
*** trinaths has quit IRC | 08:10 | |
*** trinaths has joined #tacker | 08:11 | |
*** Dinesh_Bhor has joined #tacker | 08:15 | |
*** Dinesh_Bhor has quit IRC | 08:22 | |
openstackgerrit | Cong Phuoc Hoang proposed openstack/tacker master: Add a new VDU property `reservation` https://review.openstack.org/609610 | 08:26 |
*** Dinesh_Bhor has joined #tacker | 08:31 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/tacker master: Add new policy action: vdu_autoheal https://review.openstack.org/612595 | 08:44 |
*** trinaths has quit IRC | 08:44 | |
*** trinaths has joined #tacker | 09:24 | |
openstackgerrit | Ghanshyam Mann proposed openstack/tacker stable/queens: DNM: for testing the branch for devstack plugins https://review.openstack.org/630098 | 09:44 |
*** Dinesh_Bhor has quit IRC | 09:55 | |
*** bhagyashris has quit IRC | 10:02 | |
*** trinaths has quit IRC | 10:15 | |
openstackgerrit | Niraj Singh proposed openstack/tacker master: Add a new VDU property `reservation` https://review.openstack.org/609610 | 10:23 |
openstackgerrit | Niraj Singh proposed openstack/tacker master: Add reservation support https://review.openstack.org/622888 | 10:23 |
*** ShilpaSD has joined #tacker | 10:29 | |
*** Shubam_potale has joined #tacker | 10:31 | |
dkushwaha | thanks egonzalez for your input. We can discuss it in weekly meeting, and will try to define a clear boundary on that. | 10:33 |
Shubam_potale | Hi All, I am writing unit test case for tacker/vnfm/plugin.py module here in def create_vnf method it is returning vnf_dict w/o waiting for excecution of def create_vnf_wait . as it is asynchronous call, so in currently written test case it is not covering the code inside the def create_vnf_wait. My query is how can I write unit test case to cover this code, https://github.com/openstack/tacker/blob/master/tacker/vnfm/plug | 10:42 |
*** Dinesh_Bhor has joined #tacker | 11:09 | |
*** Shubam_potale has quit IRC | 11:46 | |
*** ShilpaSD has quit IRC | 11:47 | |
*** nnsingh has quit IRC | 11:47 | |
*** Dinesh_Bhor has quit IRC | 11:47 | |
*** nnsingh has joined #tacker | 11:57 | |
*** ShilpaSD has joined #tacker | 11:57 | |
*** ShilpaSD has quit IRC | 12:21 | |
*** nnsingh has quit IRC | 12:21 | |
*** nnsingh has joined #tacker | 12:35 | |
*** ShilpaSD has joined #tacker | 12:36 | |
*** shubham_potale has joined #tacker | 13:08 | |
shubham_potale | dkushwaha:Hi | 13:09 |
openstackgerrit | Niraj Singh proposed openstack/tacker master: Add reservation support https://review.openstack.org/622888 | 13:37 |
*** janki has joined #tacker | 13:39 | |
*** trinaths has joined #tacker | 14:46 | |
*** ShilpaSD has quit IRC | 14:50 | |
*** bobh has joined #tacker | 14:58 | |
*** bobh has quit IRC | 15:27 | |
*** bobh has joined #tacker | 16:44 | |
*** bobh has quit IRC | 17:05 | |
*** trinaths has quit IRC | 17:47 | |
*** openstackstatus has quit IRC | 19:43 | |
*** openstackstatus has joined #tacker | 19:44 | |
*** ChanServ sets mode: +v openstackstatus | 19:44 | |
*** openstack has joined #tacker | 20:18 | |
*** ChanServ sets mode: +o openstack | 20:18 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!