Friday, 2019-01-11

*** bobh has joined #tacker00:06
*** bobh has quit IRC00:36
*** bhagyashris has joined #tacker00:51
*** bobh has joined #tacker01:09
*** bobh has quit IRC01:31
*** bobh has joined #tacker01:32
*** bobh has quit IRC01:37
*** Dinesh_Bhor has joined #tacker02:26
*** Dinesh_Bhor has quit IRC02:31
*** Dinesh_Bhor has joined #tacker02:33
*** bobh has joined #tacker02:33
*** bobh has quit IRC02:38
*** Dinesh_Bhor has quit IRC03:04
*** Dinesh_Bhor has joined #tacker03:11
*** Dinesh_Bhor has quit IRC03:36
*** bobh has joined #tacker03:38
*** Dinesh_Bhor has joined #tacker03:39
*** bobh has quit IRC03:43
*** dkushwaha has joined #tacker05:07
*** openstackgerrit has joined #tacker06:14
openstackgerritMerged openstack/tacker-specs master: Change openstack-dev to openstack-discuss  https://review.openstack.org/62191606:14
bhagyashrisdkushwaha, phuoc: Hi, I Would like your some insights on https://review.openstack.org/#/c/614964/ and https://review.openstack.org/#/c/625461/ (stable/rocky) address all the review coments.06:21
phuocbhagyashris, I will look at them :)06:31
bhagyashrisphuoc: Thank you :)06:33
phuocdkushwaha, I think we can merge this patch https://review.openstack.org/#/c/62894006:35
*** Dinesh_Bhor has quit IRC06:57
*** dkushwaha has quit IRC06:58
*** Dinesh_Bhor has joined #tacker07:00
*** dkushwaha has joined #tacker07:28
dkushwahabhagyashris, ACK07:28
bhagyashrisdkushwaha: thank you :)07:29
dkushwahaphuoc, Ok I will merge it.07:29
*** Dinesh_Bhor has quit IRC07:32
dkushwahaphuoc, As we facing low reviewer issue, So my suggestion is, if a patch(simple/trivial) already have one +2 and one or two +1, and pending from more than week, we should merge it. wdyt?07:34
phuocdkushwaha, I agree with you07:35
phuocfor simple patches :)07:35
dkushwahayup07:35
dkushwahaThanks07:35
dkushwahafor complex patches, it will be good if it go through more reviewer07:36
openstackgerritMerged openstack/tacker master: Modify image name to cirros-0.4.0-x86_64-disk  https://review.openstack.org/62894007:41
*** trinaths has joined #tacker07:53
*** trinaths has quit IRC07:57
*** trinaths has joined #tacker08:00
egonzalezdkushwaha problem with that statement is to define what is simple/trivial patch and what not08:03
*** trinaths has quit IRC08:03
egonzalezeach core could have different vision about that08:03
egonzalezalthough i think is good idea08:04
*** trinaths has joined #tacker08:04
*** Dinesh_Bhor has joined #tacker08:04
*** Dinesh_Bhor has quit IRC08:10
*** trinaths has quit IRC08:10
*** trinaths has joined #tacker08:11
*** Dinesh_Bhor has joined #tacker08:15
*** Dinesh_Bhor has quit IRC08:22
openstackgerritCong Phuoc Hoang proposed openstack/tacker master: Add a new VDU property `reservation`  https://review.openstack.org/60961008:26
*** Dinesh_Bhor has joined #tacker08:31
openstackgerritBhagyashri Shewale proposed openstack/tacker master: Add new policy action: vdu_autoheal  https://review.openstack.org/61259508:44
*** trinaths has quit IRC08:44
*** trinaths has joined #tacker09:24
openstackgerritGhanshyam Mann proposed openstack/tacker stable/queens: DNM: for testing the branch for devstack plugins  https://review.openstack.org/63009809:44
*** Dinesh_Bhor has quit IRC09:55
*** bhagyashris has quit IRC10:02
*** trinaths has quit IRC10:15
openstackgerritNiraj Singh proposed openstack/tacker master: Add a new VDU property `reservation`  https://review.openstack.org/60961010:23
openstackgerritNiraj Singh proposed openstack/tacker master: Add reservation support  https://review.openstack.org/62288810:23
*** ShilpaSD has joined #tacker10:29
*** Shubam_potale has joined #tacker10:31
dkushwahathanks egonzalez for your input. We can discuss it in weekly meeting, and will try to define a clear boundary on that.10:33
Shubam_potaleHi All, I am writing unit test case for tacker/vnfm/plugin.py module  here in  def create_vnf   method it is returning vnf_dict w/o waiting for excecution of def create_vnf_wait . as it is asynchronous call, so in currently written test case  it is not covering the code inside the def create_vnf_wait.  My query is how can I write unit test case to cover this code,   https://github.com/openstack/tacker/blob/master/tacker/vnfm/plug10:42
*** Dinesh_Bhor has joined #tacker11:09
*** Shubam_potale has quit IRC11:46
*** ShilpaSD has quit IRC11:47
*** nnsingh has quit IRC11:47
*** Dinesh_Bhor has quit IRC11:47
*** nnsingh has joined #tacker11:57
*** ShilpaSD has joined #tacker11:57
*** ShilpaSD has quit IRC12:21
*** nnsingh has quit IRC12:21
*** nnsingh has joined #tacker12:35
*** ShilpaSD has joined #tacker12:36
*** shubham_potale has joined #tacker13:08
shubham_potaledkushwaha:Hi13:09
openstackgerritNiraj Singh proposed openstack/tacker master: Add reservation support  https://review.openstack.org/62288813:37
*** janki has joined #tacker13:39
*** trinaths has joined #tacker14:46
*** ShilpaSD has quit IRC14:50
*** bobh has joined #tacker14:58
*** bobh has quit IRC15:27
*** bobh has joined #tacker16:44
*** bobh has quit IRC17:05
*** trinaths has quit IRC17:47
*** openstackstatus has quit IRC19:43
*** openstackstatus has joined #tacker19:44
*** ChanServ sets mode: +v openstackstatus19:44
*** openstack has joined #tacker20:18
*** ChanServ sets mode: +o openstack20:18

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!