Friday, 2015-03-13

*** Marga_ has quit IRC00:15
*** alop has quit IRC00:16
*** pradeep has joined #tripleo00:23
*** jp_at_hp has joined #tripleo00:26
*** Marga_ has joined #tripleo00:27
*** killer_prince has quit IRC00:28
*** pradeep1 has joined #tripleo00:32
*** pradeep has quit IRC00:33
*** killer_prince has joined #tripleo00:35
*** killer_prince is now known as lazy_prince00:35
greghaynesslagle: haha, looks like we picked the exact same time to review SpamapS's spec00:48
greghaynesSpamapS: So, I left some comments. I think I have an idea of how we can do it in a bit less backwards-compat breaking way00:48
slagleheh00:49
slaglegreghaynes: since you're here.... review plz :) https://review.openstack.org/#/c/163235/00:50
* greghaynes hides00:50
greghaynesoh, that one00:50
greghaynes+A'd00:51
*** radez is now known as radez_g0n300:51
slaglethx00:51
*** cody-somerville has quit IRC00:56
*** rameshg87 has joined #tripleo01:03
rameshg87tripleo cores, can some please have a look at https://review.openstack.org/16068701:04
rameshg87this is required for a feature coming under feature freeze in Ironic (next week)01:04
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: puppet: tidy up the Nova ceilo auth configs  https://review.openstack.org/16398801:07
greghaynesrameshg87: LGTM01:08
rameshg87greghaynes: thanks a lot :)01:12
*** rwsu is now known as rwsu-afk01:13
*** pradeep has joined #tripleo01:19
*** pradeep1 has quit IRC01:21
*** rameshg87 has left #tripleo01:24
*** pradeep has quit IRC01:29
*** jp_at_hp has quit IRC01:29
*** stendulker has joined #tripleo01:33
*** yamahata has quit IRC01:33
*** pradeep has joined #tripleo01:35
*** pradeep has quit IRC01:36
*** ChuckC has joined #tripleo01:42
*** ChuckC has quit IRC01:46
*** ChuckC has joined #tripleo01:47
*** sdake has joined #tripleo01:50
openstackgerritimain proposed stackforge/kolla: Mariadb yml file for docker compose.  https://review.openstack.org/16395301:52
*** sdake__ has joined #tripleo01:52
*** lazy_prince has quit IRC01:53
*** Marga_ has quit IRC01:53
openstackgerritMerged openstack/diskimage-builder: Fix check for installtype  https://review.openstack.org/16323501:56
*** sdake has quit IRC01:56
openstackgerritMerged openstack/diskimage-builder: Ironic: uefi localboot support  https://review.openstack.org/16068702:00
*** Marga_ has joined #tripleo02:03
*** tzumainn has quit IRC02:04
*** stendulker has quit IRC02:06
*** stendulker has joined #tripleo02:12
*** killer_prince has joined #tripleo02:14
*** killer_prince is now known as lazy_prince02:14
openstackgerritimain proposed stackforge/kolla: Change keystone yml file to always restart.  https://review.openstack.org/16395702:33
openstackgerritimain proposed stackforge/kolla: rabbitmq yml file.  https://review.openstack.org/16395602:33
openstackgerritimain proposed stackforge/kolla: Complete docker compose setup.  https://review.openstack.org/16394202:33
openstackgerritimain proposed stackforge/kolla: New nova compute and nova network yml file for docker compose.  https://review.openstack.org/16395502:33
openstackgerritimain proposed stackforge/kolla: docker compose file for nova api, conductor and scheduler.  https://review.openstack.org/16395402:33
*** stendulker has quit IRC02:43
sdake__slower please fix the one busted fig.yml02:44
sdake__and then we are gtg imo :)02:44
*** sdake__ has quit IRC02:49
*** sdake has joined #tripleo03:08
*** pradeep has joined #tripleo03:12
*** pradeep1 has joined #tripleo03:15
*** pradeep has quit IRC03:17
*** sdake__ has joined #tripleo03:19
*** sdake has quit IRC03:22
*** pradeep1 has quit IRC03:24
*** spzala has quit IRC03:25
*** lazy_prince is now known as killer_prince03:31
*** cody-somerville has joined #tripleo03:36
*** cody-somerville has joined #tripleo03:36
Slowersdake__: ok03:37
sdake__slower nice work btw03:37
Slowersdake__: so.. hmm03:38
Slowersdake__: in my testing the /etc/libvirt/nwfilters was from the nwfilter conf package03:38
sdake__yup03:38
sdake__one container creates files in it03:38
Slowersdake__: mmm, and mounting it to the host, which will probably not have that package, makes it break03:38
sdake__another container reads files from it03:38
sdake__agree mkdir -p to make the dirs int he container03:39
Slowerso this is because you have libvirt in it's own container?03:39
sdake__I agree, this is a problem which I haven't figured otu how to solve03:39
SlowerI actually am running it in the same container as nova03:39
sdake__but none the less if you actually use novaboot to launch a container, you will need those directories shared03:39
Slowerhuh03:40
SlowerI'm pretty sure I did not have that..03:40
Slowerbut03:40
SlowerI'll run with it :)03:41
SlowerI could be wrong03:41
Sloweractually let me look03:42
Slowersdake__: https://github.com/rthallisey/atomic-osp-installer/blob/master/compose/nova-compute-network.yml03:42
SlowerI *know* that works03:43
sdake__uninstall the nwfilters package03:43
sdake__see if it works03:43
Sloweron the host?03:43
Sloweryou have to have it in the container..03:43
Slowershouldn't matter if the host has it03:44
SlowerI'll add it back for now03:45
Slowerand do some testing03:46
openstackgerritimain proposed stackforge/kolla: New nova compute and nova network yml file for docker compose.  https://review.openstack.org/16395503:51
Slowersdake__: there you go03:52
SlowerI'll have to test with centos too03:53
Slowerhaven't tried it03:53
*** untriaged-bot has joined #tripleo04:00
untriaged-botUntriaged bugs so far:04:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143044504:00
openstackLaunchpad bug 1430445 in tripleo "Horizon translations aren't compiled" [Undecided,In progress] - Assigned to Steve McLellan (sjmc7)04:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143059904:00
openstackLaunchpad bug 1430599 in diskimage-builder "ramdisk-image-create with ironic-discoverd-ramdisk element fails" [Undecided,In progress] - Assigned to Yuiko Takada (takada-yuiko)04:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143046704:00
openstackLaunchpad bug 1430467 in tripleo "Fedora 21 seed image build fails at 05-heat" [Undecided,Triaged]04:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/142990204:00
openstackLaunchpad bug 1429902 in tripleo "os-refresh-config fails during post-configure phase" [Undecided,New]04:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143113604:00
openstackLaunchpad bug 1431136 in diskimage-builder "Add element to create agent deploy ramdisk with proliant utilities for Ironic" [Undecided,New] - Assigned to Ramakrishnan G (rameshg87)04:00
*** untriaged-bot has quit IRC04:00
*** nijaba has quit IRC04:01
*** nijaba has joined #tripleo04:07
*** nijaba has quit IRC04:07
*** nijaba has joined #tripleo04:07
*** sdake__ has quit IRC04:09
*** yog_ has joined #tripleo04:12
*** cody-somerville has quit IRC04:15
*** Marga_ has quit IRC04:16
openstackgerritSpencer Krum proposed openstack/diskimage-builder: Flagging ubuntu-minimal as untested  https://review.openstack.org/16407004:22
*** pradeep has joined #tripleo04:30
*** Marga_ has joined #tripleo04:37
*** killer_prince is now known as lazy_prince04:37
*** akuznetsov has joined #tripleo05:10
*** akuznetsov has quit IRC05:11
*** akuznetsov has joined #tripleo05:12
*** akuznetsov has quit IRC05:19
*** akuznetsov has joined #tripleo05:20
*** akuznetsov has quit IRC05:22
*** masco has joined #tripleo05:44
*** sdake_ has quit IRC06:17
*** sdake_ has joined #tripleo06:21
*** eghobo has joined #tripleo06:38
*** michchap has quit IRC06:38
*** lazy_prince has quit IRC06:40
*** jcoufal has joined #tripleo06:51
*** MasterPiece has joined #tripleo06:57
*** michchap has joined #tripleo06:58
*** mrunge has quit IRC07:00
*** mrunge has joined #tripleo07:01
*** eghobo has quit IRC07:07
*** eghobo has joined #tripleo07:08
*** maufart has joined #tripleo07:30
*** ifarkas has joined #tripleo07:33
*** MasterPiece has quit IRC07:41
*** athomas has joined #tripleo07:42
*** panda has quit IRC07:47
*** panda has joined #tripleo07:47
*** jprovazn has joined #tripleo07:50
*** jtomasek has joined #tripleo08:05
*** ishant has joined #tripleo08:08
*** chlong has quit IRC08:09
*** jistr has joined #tripleo08:12
*** eghobo has quit IRC08:14
*** rlandy has joined #tripleo08:21
*** openstackgerrit has quit IRC08:21
*** openstackgerrit has joined #tripleo08:21
*** gfidente has joined #tripleo08:23
*** gfidente has joined #tripleo08:23
*** dasm has quit IRC08:23
*** rdopiera has joined #tripleo08:24
*** mandre has quit IRC08:28
*** killer_prince has joined #tripleo08:35
*** killer_prince is now known as lazy_prince08:35
*** jistr has quit IRC08:46
*** bvandenh_call_tr has joined #tripleo09:00
*** jistr has joined #tripleo09:04
*** dasm has joined #tripleo09:07
*** rdopiera has quit IRC09:12
*** pdb has quit IRC09:21
*** pdb has joined #tripleo09:21
*** bnemec has quit IRC09:24
*** bnemec has joined #tripleo09:25
*** rdopiera has joined #tripleo09:28
*** eghobo has joined #tripleo09:28
*** mcornea has joined #tripleo09:31
*** mcornea has quit IRC09:39
*** mcornea has joined #tripleo09:42
*** derekh has joined #tripleo09:57
*** untriaged-bot has joined #tripleo10:00
untriaged-botUntriaged bugs so far:10:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143044510:00
openstackLaunchpad bug 1430445 in tripleo "Horizon translations aren't compiled" [Undecided,In progress] - Assigned to Steve McLellan (sjmc7)10:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143059910:00
openstackLaunchpad bug 1430599 in diskimage-builder "ramdisk-image-create with ironic-discoverd-ramdisk element fails" [Undecided,In progress] - Assigned to Yuiko Takada (takada-yuiko)10:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143046710:00
openstackLaunchpad bug 1430467 in tripleo "Fedora 21 seed image build fails at 05-heat" [Undecided,Triaged]10:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/142990210:00
openstackLaunchpad bug 1429902 in tripleo "os-refresh-config fails during post-configure phase" [Undecided,New]10:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143113610:00
openstackLaunchpad bug 1431136 in diskimage-builder "Add element to create agent deploy ramdisk with proliant utilities for Ironic" [Undecided,New] - Assigned to Ramakrishnan G (rameshg87)10:00
*** untriaged-bot has quit IRC10:00
*** eghobo_ has joined #tripleo10:01
*** eghobo has quit IRC10:04
*** jp_at_hp has joined #tripleo10:15
*** yog_ has quit IRC10:18
*** lucasagomes has joined #tripleo10:21
*** eghobo_ has quit IRC10:22
*** pradeep has quit IRC10:33
*** athomas has quit IRC10:34
openstackgerritSteven Hardy proposed openstack/tripleo-heat-templates: Make heat auth_encryption_key random  https://review.openstack.org/15787210:37
*** pradeep has joined #tripleo10:38
*** mcornea_ has joined #tripleo10:39
*** mcornea has quit IRC10:42
*** lazy_prince has quit IRC10:42
*** pelix has joined #tripleo10:45
*** athomas has joined #tripleo10:50
*** MasterPiece has joined #tripleo10:57
*** killer_prince has joined #tripleo10:58
*** killer_prince is now known as lazy_prince10:58
*** sseago has joined #tripleo11:08
*** MasterPiece has quit IRC11:15
*** athomas_ has joined #tripleo11:21
*** thrash|g0ne is now known as thrash11:21
*** athomas has quit IRC11:21
*** rhallisey has joined #tripleo11:27
*** lazy_prince is now known as killer_prince11:30
*** akrivoka has joined #tripleo11:33
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates: Add support for Neutron l3_ha option in puppet templates  https://review.openstack.org/16414411:34
*** athomas_ is now known as athomas11:38
*** athomas has quit IRC11:40
*** pradeep has quit IRC11:43
*** pradeep1 has joined #tripleo11:43
*** athomas has joined #tripleo11:43
*** jcoufal_ has joined #tripleo11:45
*** jcoufal has quit IRC11:49
*** masco has quit IRC11:51
*** lucasagomes is now known as lucas-hungry12:09
*** morazi has joined #tripleo12:11
*** jdob has quit IRC12:14
*** jdob has joined #tripleo12:15
*** pradeep1 has quit IRC12:19
*** radez_g0n3 is now known as radez12:22
*** purmark has quit IRC12:22
*** chlong has joined #tripleo12:24
*** Marga_ has quit IRC12:24
EmilienMspredzy: gfidente: are you guys working on tripleo/puppet/horizon ? of not I take it.12:30
gfidenteEmilienM, not horizon no12:31
gfidenteI submitted something for the l3 ha12:31
gfidentebut after I want to look at the galera thing12:31
EmilienMgfidente: oh, ok12:31
spredzyEmilienM, neither am I12:32
EmilienMack, I take it.12:32
*** mcornea_ has quit IRC12:36
*** mcornea has joined #tripleo12:36
*** mcornea has quit IRC12:37
*** mcornea has joined #tripleo12:37
*** dprince has joined #tripleo12:42
*** rhallisey has quit IRC12:45
*** rhallisey has joined #tripleo12:46
*** weshay has joined #tripleo12:52
*** ishant has quit IRC12:53
openstackgerritMerged openstack/python-tuskarclient: Updated URLs to remove version string  https://review.openstack.org/16389912:55
*** tzumainn has joined #tripleo12:56
*** lucas-hungry is now known as lucasagomes13:03
*** lblanchard has joined #tripleo13:08
*** radez is now known as radez_g0n313:10
*** spredzy is now known as spredzy|afk13:12
*** Marga_ has joined #tripleo13:23
*** jprovazn has quit IRC13:28
gfidenteEmilienM, dprince, the tripleo::database::mysql which I see in puppet-tripleo, do you think I can try to use it?13:38
EmilienMgfidente: yes13:39
EmilienMgfidente: I did it, from taking the bits in Spinal Stack13:39
gfidentethat is great actually13:39
EmilienMgfidente: it's how we setup galera in prod13:39
EmilienMthough spredzy|afk will have a future improvement13:39
gfidenteyes indeed I noticed and wanted to borrow it immediately instead of reinventing the wheel :P13:39
EmilienMhe's doing patch upstream in puppet so there are some part would will be able to drop :)13:39
gfidenteso I'll try to use it from overcloud_controller.pp13:40
EmilienMcool13:40
EmilienMgfidente: I'm on Horizon, I don't see existing parameters now. Should I add them?13:40
EmilienMmaybe I can start by dealing without13:40
dprincegfidente: so long as it fits with what we arleady do in tripleo-heat-templates.13:40
gfidenteEmilienM, yeah I am not looking into that at all so there could be stuff missing entirely13:41
gfidentedprince, you mean I should not mess around with params much?13:41
*** spzala has joined #tripleo13:42
dprincegfidente: CI will tell us if it works.13:44
*** sirushti has quit IRC13:45
dprincegfidente: I see Emilien already has the _dsn split() functions like I did for tripleo-heat-templates so it should be easy13:48
gfidentedprince, I am still unsure why cinder was trying the rtstool in that job13:48
gfidentedprince, if it wasn't easy, I wasn't trying :P13:48
dprincegfidente: looks like a hybrid of puppet-openstack-cloud and the tripleo-heat-template stuff so I think it should be good13:48
dprincegfidente: gfidente: rtstool is used for cinder-lio13:49
dprincegfidente: For product we actually want lio instead of tgt13:49
dprincegfidente: Honestly I used to run with LIO locally but devtest_overcloud.sh makes it hard to do that for CI so I haven't done it yet there.13:50
*** sseago has left #tripleo13:51
dprincegfidente, Emilien: Oh. One more thing to mention before we get too crazy with puppet-tripleo is I don't think we are running the tripleo-puppet job there yet.13:51
EmilienMmhh13:52
gfidentedprince, I mean, I know rtstool is for the lioadm but I am not sure why it tried that when we default to tgtadm everywhere13:52
dprincegfidente, Emilien: what I mean is the our tripleo CI job won't run on changes to that repo yet. Just need to push an infra change to make that happen13:52
*** sirushti has joined #tripleo13:52
dprincegfidente, Emilien: very important though because it means we are at risk of breaking ourselves...13:52
dprincegfidente, Emilien: I can take on adding this soon13:53
EmilienMdprince: I thought you add a patch to gate it13:53
dprincegfidente, Emilien: but FWIW the lack of this job is why I haven't gone crazy with puppet-tripleo yet13:53
gfidentedprince, one day I will ask you guide me a bit over CI jobs as well so we can have that puppet/ha job and maybe free the resources by making some jobs running with 1 compute instead of 213:54
dprinceEmilienM: The work I did gave us tripleo-puppet-element coverage. And also prepped the way to add in puppet-tripleo as well.13:54
gfidentedprince, I am not sure how to do it or I would try adding the job for it first13:54
dprinceEmilienM: just need to actually add *the* job now13:54
EmilienMdprince: ok. I can do it now13:55
dprincegfidente: I'll cc you on this patch13:55
gfidentedprince, tks :)13:55
dprinceEmilienM: Trying to finish your patch here first... https://review.openstack.org/#/c/159757/13:56
dprincegfidente: ^^^ that is also related to what you are doing13:56
EmilienMdprince: oh indeed. You on it ?13:56
dprinceEmilienM: yes. Some params are missing (see my comment)13:58
*** julim has quit IRC14:01
*** radez_g0n3 is now known as radez14:02
*** jprovazn has joined #tripleo14:03
dprincegfidente: Also, the idea with puppet-tripleo is we want to avoid using it as much as possible. At least that is what we are going for.14:04
dprincegfidente: what I mean is we want only a "lightweight composition layer". We are preferring to use the stackforge modules directly in tripleo-heat-templates/puppet/*14:04
gfidentedprince, so my intentions there were to use the part which configures the galera cluster without adding it into controller.pp14:04
dprincegfidente: sure. If it makes sense to keep that close the the other (verbose) database initialization stuff then I could see that. My preference would be that we had only Hiera and stackforge modules.14:06
dprincegfidente: unfortunately due to conversions (missing Heat functions perhaps) we are doing a bit more work in the manifests. That is okay for now but over time I could see us refining this to be more just hiera and stackforge modules directly14:07
openstackgerritDan Prince proposed stackforge/puppet-tripleo: loadbalancer: document required parameters  https://review.openstack.org/16418114:08
openstackgerritLucas Alvares Gomes proposed openstack/diskimage-builder: Ironic: Deploy ramdisk to find the right root device  https://review.openstack.org/14217814:09
*** jp_at_hp has quit IRC14:13
*** dasm is now known as dasm|afk14:15
*** spredzy|afk is now known as spredzy14:15
*** ChuckC_ has joined #tripleo14:16
*** ChuckC has quit IRC14:17
openstackgerritMerged openstack/python-tuskarclient: Rename Attributes to Parameters to match Tuskar API  https://review.openstack.org/16359214:22
*** ChuckC_ has quit IRC14:23
*** rlandy has quit IRC14:25
*** pblaho_ is now known as pblaho14:27
*** eghobo has joined #tripleo14:29
*** Nakato has quit IRC14:33
*** Nakato has joined #tripleo14:34
*** pradeep has joined #tripleo14:35
*** spzala has quit IRC14:41
openstackgerritMerged openstack/tuskar-ui: Set Overcloud Horizon Keystone endpoint to add Horizon webroot  https://review.openstack.org/16333914:48
*** pradeep has quit IRC14:49
*** pradeep has joined #tripleo14:50
*** subscope has quit IRC14:53
*** sdake has joined #tripleo15:00
*** radez is now known as radez_g0n315:02
*** radez_g0n3 is now known as radez15:05
*** rhallisey has quit IRC15:06
*** ChuckC_ has joined #tripleo15:07
*** Marga_ has quit IRC15:10
*** jprovazn has quit IRC15:13
*** pradeep1 has joined #tripleo15:16
*** pradeep has quit IRC15:16
*** MasterPiece has joined #tripleo15:19
*** rhallisey has joined #tripleo15:19
*** pradeep has joined #tripleo15:29
*** pradeep1 has quit IRC15:29
*** eghobo_ has joined #tripleo15:32
*** david-lyle_afk is now known as david-lyle15:33
*** eghobo has quit IRC15:36
*** cody-somerville has joined #tripleo15:37
*** jcoufal_ has quit IRC15:42
*** spzala has joined #tripleo15:43
*** daneyon_ has joined #tripleo15:45
*** eghobo_ has quit IRC15:46
*** bvandenh_call_tr has quit IRC15:46
*** daneyon__ has joined #tripleo15:47
*** daneyon_ has quit IRC15:47
*** daneyon has quit IRC15:48
*** ChuckC_ has quit IRC15:49
*** pradeep1 has joined #tripleo15:53
*** ChuckC has joined #tripleo15:53
gfidentebnemec, https://review.openstack.org/#/c/163113/ ?15:53
*** pradeep has quit IRC15:55
*** alop has joined #tripleo15:56
*** masco has joined #tripleo15:57
*** untriaged-bot has joined #tripleo16:00
untriaged-botUntriaged bugs so far:16:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143044516:00
openstackLaunchpad bug 1430445 in tripleo "Horizon translations aren't compiled" [Undecided,In progress] - Assigned to Steve McLellan (sjmc7)16:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143059916:00
openstackLaunchpad bug 1430599 in diskimage-builder "ramdisk-image-create with ironic-discoverd-ramdisk element fails" [Undecided,In progress] - Assigned to Yuiko Takada (takada-yuiko)16:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143046716:00
openstackLaunchpad bug 1430467 in tripleo "Fedora 21 seed image build fails at 05-heat" [Undecided,Triaged]16:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/142990216:00
openstackLaunchpad bug 1429902 in tripleo "os-refresh-config fails during post-configure phase" [Undecided,New]16:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143113616:00
openstackLaunchpad bug 1431136 in diskimage-builder "Add element to create agent deploy ramdisk with proliant utilities for Ironic" [Undecided,New] - Assigned to Ramakrishnan G (rameshg87)16:00
*** untriaged-bot has quit IRC16:00
*** sdake has quit IRC16:04
*** maufart has quit IRC16:08
*** rwsu-afk is now known as rwsu16:15
*** rdopiera has quit IRC16:22
*** sdake has joined #tripleo16:23
*** pradeep has joined #tripleo16:23
*** pradeep1 has quit IRC16:25
*** pradeep1 has joined #tripleo16:28
*** pradeep has quit IRC16:29
dprinceslagle: we hit an issue in using Instack on baremetal with the defaults. So this: https://review.gerrithub.io/#/c/218639/16:36
openstackgerritMerged stackforge/puppet-tripleo: loadbalancer: document required parameters  https://review.openstack.org/16418116:38
*** MasterPiece has quit IRC16:38
gchamouldprince, slagle: any chance to get your thoughts on this review https://review.openstack.org/162285?16:45
*** Marga_ has joined #tripleo16:46
*** dsneddon is now known as dsneddon_afk16:49
dprincegchamoul: does this mean I'd have to stop using an arbitrary number of spacings for my bash functions!?16:51
dprincegchamoul: I think it looks fine probably16:52
dprincegchamoul: I should carefully look over it though first16:52
greghayneswhoa16:52
greghaynesthats a lot of files16:52
dprincegchamoul: would have made an easier review if this sort of thing was split up16:52
gchamouldprince, greghaynes: Yes it needs real tests!16:53
dprincegchamoul: however, you've got CI passing...16:53
greghaynesgchamoul: One thing that concerns me is you had to edit https://review.openstack.org/#/c/162285/11/scripts/configure-vm which is python16:53
greghaynesdoes that mean were bash8ing our python scripts?16:54
dprincegreghaynes: a very good point16:54
gchamoulgreghaynes: yes I planned to fix this too in one other patch16:54
dprincegchamoul: shouldn't you just be able to modify what is in run-bashate.sh?16:54
gchamoulgreghaynes: renaming test:pep8 but test:bashate and make a real test:pep8 for the python scripts16:55
gchamoulthere is just one in tripleo-inc for the moment16:55
gchamouldprince: yes that's my plan ... to add a parameter to run-bashate.sh ...16:56
gchamoulbut I will need to rename it first16:56
*** pradeep has joined #tripleo16:56
greghaynesyep, so I think were supposed to be ignoring scripts like that, https://review.openstack.org/#/c/162285/11/run-bashate.sh looks like it filters out based on #!16:56
dprincegchamoul: rename what?16:56
greghaynesim wondering if thats either buggy or it actually just works?16:57
gchamoulgreghaynes: nope if you look into the run-bashate.sh, I've excluded the python script16:57
gchamouldprince: run-bashate.sh, I mean16:57
*** pradeep1 has quit IRC16:57
SpamapSgreghaynes: btw, we can't split liberty specs into their own patch, there has to be at least one or specs/liberty/* will fail docs build16:57
greghaynesSpamapS: ah16:57
SpamapSgreghaynes: which sucks. :)16:57
greghaynesyep16:58
greghaynestemplate.rst?16:58
greghaynes;)16:58
*** pradeep1 has joined #tripleo17:00
*** pradeep has quit IRC17:00
gchamoulgreghaynes: well I exclude the awk and python scripts in bashate17:01
gchamoultest17:01
gchamouldprince: I could split up that patch with one fixing bashate rule 'E020: Function declaration not in format ``^function name {$``' and one other for bashte rule 'E003: ensure all indents are a multiple of 4 spaces'17:07
*** pradeep1 has quit IRC17:07
gchamouldprince: cause it's essentially those kind of Errors!17:07
dprincegchamoul: that sounds like more work, I was more thinking just arbitrary splits17:07
dprincegchamoul: don't split it yet I think17:07
dprincegchamoul: I do think not changing the python file is worth doing now though17:08
gchamouldprince: ack! I am waiting for your feedbacks so!17:08
gchamouldprince: that's only indentation errors in the python script17:08
gchamoulif I remember well!17:08
dprincegchamoul: yeah, it is fine to actually fix those mind you17:09
*** ifarkas has quit IRC17:10
dprincegchamoul: the fact that you might have needed to fix them due to a (possibly) incorrect run-bashate.sh file is what we are figuring out here17:10
gchamoulthe run-bashate actually drives only the bash scripts!17:11
*** cody-somerville has quit IRC17:11
*** cody-somerville has joined #tripleo17:11
*** cody-somerville has joined #tripleo17:11
gchamouland I am not wrong ... the flake8 test is not working on tripleo-incubator17:11
gchamouls/and I/and if I/17:12
SpamapSgreghaynes: I don't really understand what you're saying about not breaking things. I don't see where the way I've specified it breaks things until we decide to really break things.17:13
openstackgerritDaneyon Hansen proposed stackforge/kolla: Implements: blueprint container-set-api-control  https://review.openstack.org/15970117:15
greghaynesSpamapS: The issue is when an element provides an arguments.yaml if we mask env vars based on the values in that file then on the commit an element provides it all of a sudden you cant use env vars to configure that element17:15
greghaynesso if I have my tripleorc built up with a bunch of env vars then I dont have any deprecation period for that17:17
*** pelix has quit IRC17:18
openstackgerritDan Prince proposed openstack/tripleo-puppet-elements: Use stackforge/puppet-tripleo  https://review.openstack.org/16426917:20
*** dsneddon_afk is now known as dsneddon17:22
openstackgerritDaneyon Hansen proposed stackforge/kolla: Implements: blueprint Implement a container set for database control  https://review.openstack.org/15900417:22
*** sdake__ has joined #tripleo17:24
greghaynesSpamapS: does that make sense?17:24
*** regebro has quit IRC17:26
SpamapSgreghaynes: no17:27
SpamapSgreghaynes: you're saying mask, but I don't really expect people to do that.17:27
SpamapSgreghaynes: elements will 99% of the time specify null as the value, which means pass-thru17:27
SpamapSgreghaynes: if they put a value in there, they're doing it _to mask things_17:27
SpamapSand that is the element's problem17:27
*** sdake has quit IRC17:28
SpamapSgreghaynes: could we screw that up and mask out something useful? Yes. Do I expect us to do that? No. :)17:28
greghaynesah! so that is the key I was missing, I interpreted what I was reading as if an element/arguments.yaml specified null it wouldnt pass through that var from the env, only for globals17:29
greghaynesso I was just arguing for your design ;)17:29
SpamapSSo we need to clarify that.17:29
SpamapSExamples should help really.17:29
SpamapSWe should include a couple in the spec.17:30
greghaynesyes17:30
SpamapSgreghaynes: thanks for thinking critically about it.17:30
SpamapSMy aim is to not over-think this.17:30
SpamapSI'm a little concerned I already have.17:30
greghaynesyea, I just want to make sure its something that if we end up having to go back to the drawing board on it we can back it out without having forced our users into something17:30
greghaynesanother thing I just noticed17:31
*** jistr has quit IRC17:31
greghaynesin the pypi element we suppert arbitrary env vars17:31
greghaynesDIB\_PYPI\_MIRROR\_URL\_*17:32
greghaynesthat might just be something we want to taboo and find another way to implement that feature17:32
*** pblaho has quit IRC17:33
SpamapSgreghaynes: agree17:33
SpamapSgreghaynes: the documentation says 9 additional mirrors, numbered 1-917:34
SpamapSgreghaynes: I think we should just allow those.17:34
SpamapSgreghaynes: and stop being unfaithful to the docs17:34
greghayneshah, yes, those docs arent true but thats convenient we wrote that17:35
SpamapSactually it's true to the implementation17:35
SpamapSI was eagerly reading17:35
SpamapSIt just says you'll have to be careful with more than 9 additional mirrors.17:35
greghaynesoh, because we alphasort17:36
SpamapSand that they'll be sorted17:36
SpamapSyeah we just have to fix that17:36
greghaynes"be careful with more than 9 mirrors because they wont work"17:36
SpamapSgreghaynes: we can leave that one un-argumented, deprecate using arbitraries, and warn if we see them.17:36
greghaynesor, we can just accept a list in a single var17:36
SpamapSyeah why didn't we just have comma separated list17:36
SpamapSthis is what happens when we reimplement the world. ;)17:37
*** Marga_ has quit IRC17:40
*** Marga_ has joined #tripleo17:41
*** derekh has quit IRC17:45
*** ChuckC has quit IRC17:45
*** Marga_ has quit IRC17:46
*** prad has joined #tripleo17:47
*** stendulker has joined #tripleo17:52
*** lucasagomes is now known as lucas-dinner17:54
*** dprince has quit IRC17:56
*** omnibus7 is now known as davidlenwell17:57
*** mcornea has quit IRC17:57
*** masco has quit IRC17:59
openstackgerritDaneyon Hansen proposed stackforge/kolla: Implements: blueprint Implement a container set for database control  https://review.openstack.org/15900418:00
openstackgerritDaneyon Hansen proposed stackforge/kolla: Implements: blueprint Implement a database container set  https://review.openstack.org/15900418:09
*** alop has quit IRC18:11
openstackgerritGael Chamoulaud proposed openstack/tripleo-incubator: Fix bashate errors  https://review.openstack.org/16228518:11
*** shardy has quit IRC18:24
*** daneyon has joined #tripleo18:25
*** daneyon__ has quit IRC18:28
*** Marga_ has joined #tripleo18:29
*** stendulker has quit IRC18:30
*** daneyon has quit IRC18:34
*** daneyon has joined #tripleo18:35
*** athomas has quit IRC18:45
*** funzo has joined #tripleo18:46
openstackgerritJay Dobies proposed openstack/python-tuskarclient: Add support for subdirs in templates listing  https://review.openstack.org/16429818:47
*** dprince has joined #tripleo19:01
*** cody-somerville has quit IRC19:03
*** cody-somerville has joined #tripleo19:04
*** cody-somerville has joined #tripleo19:04
*** gfidente has quit IRC19:07
*** akrivoka has quit IRC19:33
*** radez is now known as radez_g0n319:40
*** alop has joined #tripleo19:49
*** lucas-dinner has quit IRC19:54
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: puppet/loadbalancer: use puppet-tripleo  https://review.openstack.org/15975719:59
dprinceEmilienM: ^^^ sorry to take so long. I believe that should pass20:01
EmilienMdprince: ack, looking now20:01
openstackgerritMerged openstack/tripleo-image-elements: Work around 20-neutron-selinux issues on F21  https://review.openstack.org/16184020:05
openstackgerritMerged openstack-infra/tripleo-ci: Add support for Fedora 21 image downloads  https://review.openstack.org/16239920:07
*** spzala has quit IRC20:08
*** yamahata has joined #tripleo20:09
openstackgerritMerged openstack/tripleo-incubator: Increase the seed wait_for network timeout  https://review.openstack.org/15920020:09
openstackgerritDan Prince proposed stackforge/puppet-tripleo: loadbalancer: add validations on required params  https://review.openstack.org/16433220:15
dprinceEmilienM: ^^^ also some we need validations in the loadbalancer class20:16
EmilienMdprince: ack20:16
dprinceEmilienM: The last CI failure would have been easier to troubleshoot if we had those in place :/20:16
dprinceEmilienM: my fault... just saying20:16
EmilienMno problem at all20:16
dprinceEmilienM: also at some point spec tests would be good in that repo too20:17
EmilienMdprince: I'll take care of it20:17
openstackgerritMerged openstack/diskimage-builder: ironic-agent: exclude content of /tmp from initramfs  https://review.openstack.org/16311320:17
*** eghobo has joined #tripleo20:18
openstackgerritDan Prince proposed openstack-infra/tripleo-ci: No need to clone tripleo-puppet-elements  https://review.openstack.org/16240020:24
openstackgerritDan Prince proposed openstack-infra/tripleo-ci: Switch Delorean jobs to F21  https://review.openstack.org/16127720:24
openstackgerritMerged openstack/tripleo-puppet-elements: Use stackforge/puppet-tripleo  https://review.openstack.org/16426920:28
*** sdake__ has quit IRC20:40
*** bvandenh_call_tr has joined #tripleo20:42
*** jdob has quit IRC20:43
*** daneyon_ has joined #tripleo20:45
*** daneyon has quit IRC20:48
*** bvandenh_call_tr has quit IRC21:01
*** tzumainn has quit IRC21:03
*** rhallisey has quit IRC21:04
openstackgerritDan Prince proposed openstack/tripleo-incubator: Set NeutronPublicInterface defaults to nic1  https://review.openstack.org/16435021:22
*** mrunge has quit IRC21:29
*** dprince has quit IRC21:46
*** prad has quit IRC21:46
*** sdake has joined #tripleo21:48
*** lblanchard has quit IRC21:58
*** untriaged-bot has joined #tripleo22:00
untriaged-botUntriaged bugs so far:22:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143044522:00
openstackLaunchpad bug 1430445 in tripleo "Horizon translations aren't compiled" [Undecided,In progress] - Assigned to Steve McLellan (sjmc7)22:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143059922:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/143046722:00
openstackLaunchpad bug 1430599 in diskimage-builder "ramdisk-image-create with ironic-discoverd-ramdisk element fails" [Undecided,In progress] - Assigned to Yuiko Takada (takada-yuiko)22:00
openstackLaunchpad bug 1430467 in tripleo "Fedora 21 seed image build fails at 05-heat" [Undecided,Triaged]22:00
untriaged-bothttps://bugs.launchpad.net/tripleo/+bug/142990222:00
openstackLaunchpad bug 1429902 in tripleo "os-refresh-config fails during post-configure phase" [Undecided,New]22:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/143113622:00
openstackLaunchpad bug 1431136 in diskimage-builder "Add element to create agent deploy ramdisk with proliant utilities for Ironic" [Undecided,New] - Assigned to Ramakrishnan G (rameshg87)22:00
*** untriaged-bot has quit IRC22:00
*** rwsu has quit IRC22:00
*** killer_prince has quit IRC22:11
*** killer_prince has joined #tripleo22:14
*** killer_prince is now known as lazy_prince22:15
*** lblanchard has joined #tripleo22:28
*** lblanchard has quit IRC22:28
*** lblanchard has joined #tripleo22:29
*** lblanchard has quit IRC22:30
*** rwsu has joined #tripleo22:33
*** thrash is now known as thrash|wknd22:37
*** sdake__ has joined #tripleo22:38
*** sdake has quit IRC22:41
*** spzala has joined #tripleo22:47
*** eghobo_ has joined #tripleo22:50
*** eghobo has quit IRC22:53
*** spzala_ has joined #tripleo23:02
*** lblanchard has joined #tripleo23:03
*** lblanchard has quit IRC23:03
*** noslzzp has quit IRC23:04
*** lblanchard has joined #tripleo23:04
*** spzala has quit IRC23:04
*** spzala_ is now known as spzala23:04
*** lblanchard has quit IRC23:04
*** lblanchard has joined #tripleo23:05
*** lblanchard has quit IRC23:06
*** spzala has quit IRC23:13
*** sdake__ has quit IRC23:15
*** eghobo_ has quit IRC23:25
*** eghobo has joined #tripleo23:27
*** david-lyle is now known as david-lyle_afk23:29
*** eghobo has quit IRC23:29
*** lblanchard has joined #tripleo23:29
*** lblanchard has quit IRC23:30
*** rwsu has quit IRC23:35
*** daneyon_ has quit IRC23:35
*** daneyon has joined #tripleo23:36
*** rwsu has joined #tripleo23:37
*** lblanchard has joined #tripleo23:37
*** lblanchard has quit IRC23:39
*** ChuckC has joined #tripleo23:41
*** alop has quit IRC23:50

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!