SpamapS | Lotus907efi: those scripts don't get run, they're there to be copied into the target instance. | 00:00 |
---|---|---|
Lotus907efi | oh | 00:00 |
Lotus907efi | ok | 00:00 |
SpamapS | makes it easy to do 'install $(dirname $0)/foo /usr/local/bin' | 00:00 |
Lotus907efi | so by putting a dot in the name | 00:00 |
Lotus907efi | they are not run as an element script | 00:01 |
SpamapS | but I'd rather see install $(dirname $0)/../foo .... | 00:01 |
SpamapS | Lotus907efi: yeah, it's entirely possible it is a happy accident. | 00:01 |
Lotus907efi | or a separate directory for stuff to be placed in the image | 00:01 |
Lotus907efi | that are not expected to run as scripts | 00:01 |
Lotus907efi | something like a copy.d directory | 00:01 |
Lotus907efi | where element scripts are NOT run from | 00:01 |
*** Marga_ has joined #tripleo | 00:02 | |
SpamapS | Lotus907efi: yeah, so, I think this is one of those things where we should open a bug, and start thinking about how to enact a breaking change, but it might take a year+ to get that fixed. | 00:02 |
Lotus907efi | a year? | 00:02 |
Lotus907efi | hehehehe | 00:02 |
Lotus907efi | well I don't think I will wait and hold my breath for a fix | 00:03 |
greghaynes | as long as you dont mind your script being owned by root theres no reason to put it in the .d dirs now | 00:04 |
greghaynes | we have an element that will automagically do the file copying for you | 00:05 |
greghaynes | but yea, backwards compat :/ | 00:05 |
SpamapS | Lotus907efi: no, I wouldn't either, but just making sure you know that I do think it should be better. | 00:05 |
Lotus907efi | ah, ok | 00:05 |
SpamapS | greghaynes: we do? | 00:05 |
Lotus907efi | it would be cool if there was some sort of warning text | 00:05 |
Lotus907efi | hat said the script was not being executed because of the dot in the name | 00:06 |
SpamapS | Lotus907efi: yeah, thats where we need to define the "right way" and start warning first. | 00:06 |
Lotus907efi | at least then it would not have taken so long to figure out | 00:06 |
SpamapS | greghaynes: what element is that? | 00:06 |
Lotus907efi | and that would not break backwards compatibility | 00:06 |
Lotus907efi | yeah, what element? | 00:06 |
greghaynes | SpamapS: http://docs.openstack.org/developer/diskimage-builder/elements/install-static/README.html | 00:07 |
greghaynes | (took me a few to remember the name) | 00:07 |
Lotus907efi | hmmm, ok | 00:07 |
Lotus907efi | I will look at that later. Taking my dad out to spaghetti dinner now | 00:07 |
Lotus907efi | thanks for the confirmation | 00:07 |
SpamapS | Lotus907efi: np, thanks for reporting! | 00:08 |
* SpamapS files the bug report | 00:08 | |
SpamapS | Lotus907efi: https://bugs.launchpad.net/diskimage-builder/+bug/1452509 <-- feel free to subscribe/edit/comment | 00:12 |
openstack | Launchpad bug 1452509 in diskimage-builder "Not executing executable files in .d directories silently is very confusing" [Medium,Triaged] | 00:12 |
*** cwolferh has quit IRC | 00:15 | |
*** Marga_ has quit IRC | 00:17 | |
*** Marga_ has joined #tripleo | 00:17 | |
SpamapS | hm | 00:26 |
openstackgerrit | Merged openstack/tripleo-incubator: build-images: drive DIB via YAML config file https://review.openstack.org/173644 | 00:26 |
*** eghobo_ has quit IRC | 00:30 | |
*** eghobo has joined #tripleo | 00:33 | |
*** saurabhs has left #tripleo | 00:41 | |
SpamapS | Lotus907efi: https://review.openstack.org/180807 | 00:42 |
SpamapS | greghaynes: ^^ | 00:42 |
SpamapS | los like dib-utils doesn't have gerritbot configs | 00:42 |
*** lazy_prince has joined #tripleo | 00:49 | |
*** shakamunyi has quit IRC | 01:02 | |
*** Marga_ has quit IRC | 01:42 | |
*** Marga_ has joined #tripleo | 01:43 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Update neutron local_ip to use the tenant network https://review.openstack.org/178716 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add a network ports IP mapping resource https://review.openstack.org/178714 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add a service ports to network mapping resource https://review.openstack.org/178715 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to controller roles https://review.openstack.org/177846 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add a ports (ip address) abstraction layer https://review.openstack.org/177845 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Wire in optional network creation for overcloud https://review.openstack.org/177844 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Create split out neutron networks via Heat. https://review.openstack.org/177843 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add isolated net parameters to net-config stacks https://review.openstack.org/180820 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to compute roles https://review.openstack.org/180821 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to ceph roles https://review.openstack.org/180822 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to swift roles https://review.openstack.org/180823 | 01:49 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to block storage roles https://review.openstack.org/180824 | 01:49 |
*** eghobo has quit IRC | 01:55 | |
*** sseago has joined #tripleo | 02:02 | |
*** lazy_prince has quit IRC | 02:07 | |
*** shakamunyi has joined #tripleo | 02:09 | |
*** yamahata has joined #tripleo | 02:17 | |
*** yamahata has quit IRC | 02:20 | |
*** yamahata has joined #tripleo | 02:20 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Puppet: Split out controller pacemaker manifest https://review.openstack.org/180833 | 02:24 |
openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Puppet: Split out controller pacemaker manifest https://review.openstack.org/180833 | 02:37 |
*** Marga_ has quit IRC | 02:45 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: load-images: load images via YAML config file https://review.openstack.org/175028 | 02:51 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Wire in load-images https://review.openstack.org/175522 | 02:51 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Add diskimage-builder/bin to PATH. https://review.openstack.org/177198 | 02:51 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: devtest_overcloud.sh: split out image building https://review.openstack.org/173645 | 02:51 |
*** rbrady has quit IRC | 02:53 | |
*** untriaged-bot has joined #tripleo | 03:00 | |
untriaged-bot | Untriaged bugs so far: | 03:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1452400 | 03:00 |
openstack | Launchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New] | 03:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449852 | 03:00 |
openstack | Launchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 03:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449854 | 03:00 |
openstack | Launchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 03:00 |
*** untriaged-bot has quit IRC | 03:00 | |
*** nijaba has quit IRC | 03:02 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Allow libvirt to assign PCI slots for us https://review.openstack.org/180841 | 03:04 |
*** nijaba has joined #tripleo | 03:08 | |
*** nijaba has quit IRC | 03:08 | |
*** nijaba has joined #tripleo | 03:08 | |
*** sdake_ has joined #tripleo | 03:09 | |
*** sdake has quit IRC | 03:13 | |
*** sdake has joined #tripleo | 03:36 | |
*** spzala has quit IRC | 03:36 | |
*** sdake_ has quit IRC | 03:39 | |
*** jrist has quit IRC | 03:43 | |
*** pcrews has quit IRC | 03:43 | |
*** links has joined #tripleo | 03:45 | |
*** jrist has joined #tripleo | 03:55 | |
*** jrist has joined #tripleo | 03:55 | |
*** masco has joined #tripleo | 04:01 | |
*** tzumainn_ has quit IRC | 04:16 | |
*** lazy_prince has joined #tripleo | 04:21 | |
*** pcrews has joined #tripleo | 04:41 | |
greghaynes | SpamapS: oh, ha, looks like I didnt add dib tests to dib-utils | 04:42 |
*** masco has quit IRC | 04:55 | |
greghaynes | SpamapS: https://review.openstack.org/#/c/180861/ | 04:58 |
*** sdake has quit IRC | 05:20 | |
*** jprovazn has joined #tripleo | 05:23 | |
*** jprovazn has quit IRC | 05:23 | |
*** sdake has joined #tripleo | 05:24 | |
*** sdake_ has joined #tripleo | 05:26 | |
*** sdake has quit IRC | 05:29 | |
*** killer_prince has joined #tripleo | 05:33 | |
*** lazy_prince has quit IRC | 05:36 | |
*** eghobo has joined #tripleo | 05:40 | |
*** killer_prince has quit IRC | 05:43 | |
*** lazy_prince has joined #tripleo | 05:43 | |
*** jtomasek has joined #tripleo | 05:43 | |
*** ukalifon1 has joined #tripleo | 06:02 | |
*** dasm|afk is now known as dasm | 06:05 | |
*** lazy_prince has quit IRC | 06:06 | |
*** masco has joined #tripleo | 06:09 | |
*** sdake_ is now known as sdake | 06:10 | |
*** ukalifon1 has quit IRC | 06:11 | |
openstackgerrit | Merged openstack/python-tuskarclient: Add initial python-openstackclient plugin https://review.openstack.org/179213 | 06:13 |
openstackgerrit | Merged openstack/python-tuskarclient: Add stub commands and tests for all OpenStack client commands https://review.openstack.org/179214 | 06:17 |
*** jcoufal has joined #tripleo | 06:28 | |
*** lazy_prince has joined #tripleo | 06:32 | |
*** killer_prince has joined #tripleo | 06:34 | |
*** lazy_prince has quit IRC | 06:37 | |
*** aufi has joined #tripleo | 06:41 | |
openstackgerrit | Merged openstack/diskimage-builder: epel: support centos element https://review.openstack.org/180547 | 06:48 |
*** jprovazn has joined #tripleo | 06:49 | |
*** bkero has quit IRC | 06:50 | |
*** bkero has joined #tripleo | 06:50 | |
*** mmagr has joined #tripleo | 07:11 | |
marios | d0ugal: gonna call it there, will do another run tomorrow :) | 07:16 |
d0ugal | marios: Awesome, thanks very much. | 07:17 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement Plan add Role for the OpenStack client https://review.openstack.org/179221 | 07:18 |
*** rbrady has joined #tripleo | 07:18 | |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement Plan remove Role for the OpenStack client https://review.openstack.org/179222 | 07:18 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement download Plan for the OpenStack client https://review.openstack.org/179223 | 07:18 |
*** rbrady has quit IRC | 07:18 | |
*** rbrady has joined #tripleo | 07:18 | |
*** mmagr has quit IRC | 07:19 | |
*** Goneri has joined #tripleo | 07:30 | |
*** mmagr has joined #tripleo | 07:32 | |
*** ifarkas has joined #tripleo | 07:34 | |
*** Goneri has quit IRC | 07:37 | |
*** gfidente has joined #tripleo | 07:38 | |
gfidente | morning :) | 07:38 |
marios | o/ | 07:39 |
marios | gfidente: thanks very much for checking the puppet-neutron | 07:40 |
marios | gfidente: so if we just add the enabled stuff as you commented should be good? | 07:40 |
gfidente | yep | 07:40 |
marios | excellente | 07:41 |
gfidente | sync_db honoured here https://github.com/stackforge/puppet-neutron/blob/0ab2afac6d912e378c417f0731a3041f6b0e0348/manifests/server.pp#L283 | 07:41 |
gfidente | enabled needs to be set because of https://github.com/stackforge/puppet-neutron/blob/0ab2afac6d912e378c417f0731a3041f6b0e0348/manifests/server.pp#L505 | 07:41 |
marios | cool, so in the glance case this wasn't decoupled like this (considered by itself) | 07:41 |
gfidente | yeah | 07:41 |
gfidente | glance _> https://review.openstack.org/#/c/180229/ | 07:42 |
gfidente | others are affected, keystone and cinder | 07:42 |
gfidente | jistr joining the effort to fix where needed | 07:42 |
gfidente | nova instead is fine, like neutron | 07:43 |
gfidente | others we will see... | 07:43 |
*** Goneri has joined #tripleo | 07:49 | |
marios | got a couple of super easy reviews if anyone is in review mode: https://review.openstack.org/#/c/179368/ and https://review.openstack.org/#/c/180530/ | 07:54 |
*** jistr has joined #tripleo | 07:54 | |
marios | the first adds the neutron-metering-agent and the second the neutron-lbaas packages to the overcloud controller element packages | 07:55 |
*** yog__ has joined #tripleo | 07:55 | |
jistr | marios: +2'd the second one too | 07:57 |
*** athomas has joined #tripleo | 07:57 | |
jistr | good morning :) | 07:57 |
gfidente | jistr, I mentioned you even before you joined | 07:58 |
*** eghobo has quit IRC | 08:00 | |
hewbrocca | Hey, you HA folks have any thoughts about dprince's comment on the pacemaker manifest? | 08:01 |
* jistr reads that | 08:03 | |
*** jcoufal_ has joined #tripleo | 08:03 | |
gfidente | hewbrocca, yeah was looking at that as well | 08:04 |
hewbrocca | social has been yelling at me about all the if/elses in our puppet | 08:05 |
hewbrocca | :) | 08:05 |
hewbrocca | so I am sensitive to that | 08:06 |
*** jcoufal has quit IRC | 08:07 | |
gfidente | let me try | 08:08 |
gfidente | as per initial paragraph, we could run with pacemaker on single node (we already do), but I support the idea of leaving space for the non-pacemaker scenario as well so that doesn't look like a great option to me | 08:10 |
gfidente | two sets of manifests for the non-pacemaker vs pacemaker scenario could work, but I am a little worried about duplication of all the config bits which are not specific to $enable_pacemaker (and they are the vast majority) | 08:11 |
jistr | gfidente: that's exactly my thinking | 08:12 |
jistr | i do think that we should split things out though | 08:12 |
jistr | i've been suggesting that we should have more of a composition layer for some time now | 08:13 |
gfidente | so on how and when, looks something more appropriate for puppeteers | 08:13 |
* gfidente isn't terrified about current status though | 08:14 | |
hewbrocca | Somehow I thought the heat templates *were* the composition layer | 08:14 |
hewbrocca | One day I will have someone explain to me just what a composition layer is and why we have so many of them | 08:15 |
gfidente | jistr, let me see if I got what you mean, that is moving the shared part in some files which can include from two different top-level manifests for pacemaker vs non-pacemaker | 08:16 |
gfidente | *can be included | 08:16 |
gfidente | jistr, I'm going to switch the rabbit clients to list of hosts today | 08:17 |
jistr | hewbrocca: so in the puppet sense of the word, it's a way to structure calling out to lower-level puppet modules, so that we don't have a huge .pp file like we have now. Heat can only accept one .pp file as manifest, not a whole puppet module. So if we wanted to have a composition layer, it would have to be a separate repo. Puppet-tripleo already plays that role, but we've been shy of extracting things to it. I guess it's because when you | 08:18 |
jistr | change something there, you need to rebuild the image, so the feedback loop is slow. | 08:18 |
jistr | hewbrocca: however i have a patch which should allow us to change puppet manifests without rebuilding images https://review.openstack.org/#/c/179177/ | 08:18 |
hewbrocca | interesting | 08:19 |
gfidente | one limitation we seem to be hitting with heat is (I'd say, but heat people can help) that it can't change what data is exposed based on the params it gets | 08:21 |
jistr | gfidente: actually i meant more like having one top-level manifest, and including bits from puppet-tripleo there rather than having everything inlined | 08:21 |
*** panda has quit IRC | 08:21 | |
gfidente | jistr, moving the shared part in to the puppet-tripleo module? | 08:21 |
*** panda has joined #tripleo | 08:21 | |
jistr | gfidente: could be both the shared parts and non-shared parts | 08:21 |
gfidente | but with one top-level the ifs would stay in that top-level | 08:22 |
jistr | gfidente: yea that's right, but the top level manifest would be a dispatcher type thing rather than a big blob | 08:23 |
gfidente | okay, see that now | 08:23 |
*** chlong has quit IRC | 08:23 | |
jistr | i see what dprince is suggesting as somewhat more heat-ish way of solving this | 08:24 |
*** aufi has quit IRC | 08:24 | |
jistr | the issues i see currently: | 08:24 |
jistr | 1. duplication of the shared parts (as you noted) | 08:24 |
*** aufi has joined #tripleo | 08:24 | |
jistr | 2. what if we want to "fork" again based on some other option in the future... we'd have to have a matrix of .pp files instead of just two, which would get out of hand fast... | 08:26 |
gfidente | looking at dprince's proposal, I think he is using the heat registry just to have two different top-level .pp , not to change the data provisioned | 08:26 |
jistr | yeah that makes sense i think | 08:27 |
*** ifarkas has quit IRC | 08:27 | |
jistr | still not sure about having two .pp files though... | 08:27 |
gfidente | well I think that is to get rid of the ids | 08:27 |
gfidente | *ifs | 08:27 |
gfidente | but it only works coupled with the effort to move shared part into puppe-tripleo | 08:27 |
*** lucasagomes has joined #tripleo | 08:28 | |
gfidente | so I personally feel like | 08:28 |
gfidente | it is more urgent to get the seed configured via puppet | 08:29 |
gfidente | and deprecate the old elements-based templates | 08:29 |
gfidente | that is a requirement to make puppet the default into devtest | 08:30 |
gfidente | and this seems more relevant to me, to get people use and consume tripleo | 08:30 |
gfidente | than the ifs in the .pp | 08:30 |
gfidente | but maybe we can do both at the same time | 08:31 |
gfidente | and I had to join some effort, I'd helping on making puppet the default :) | 08:32 |
jistr | yeah i kinda agree with that priority list. In the long term we will have to address this problem anyway though. I'll reply to dprince on the list. | 08:34 |
hewbrocca | well done gents | 08:35 |
*** regebro has joined #tripleo | 08:35 | |
*** ifarkas has joined #tripleo | 08:36 | |
gfidente | yeah I can see the ifs don't go well with the attempt to not put logic into .pp | 08:38 |
gfidente | and as hewbrocca said, we might have done that via heat | 08:38 |
gfidente | but we'd resort to passing a different .pp, like dprince is doing | 08:39 |
*** mcornea has joined #tripleo | 08:41 | |
*** ifarkas has quit IRC | 08:42 | |
*** ifarkas_ has joined #tripleo | 08:42 | |
marios | jistr: thanks! | 08:48 |
*** shardy has joined #tripleo | 08:48 | |
*** jcoufal_ has quit IRC | 08:55 | |
*** jcoufal has joined #tripleo | 08:56 | |
*** untriaged-bot has joined #tripleo | 09:00 | |
untriaged-bot | Untriaged bugs so far: | 09:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1452400 | 09:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449852 | 09:00 |
openstack | Launchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New] | 09:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449854 | 09:00 |
openstack | Launchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 09:00 |
*** untriaged-bot has quit IRC | 09:00 | |
openstack | Launchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 09:00 |
*** yamahata has quit IRC | 09:01 | |
*** athomas has quit IRC | 09:11 | |
openstackgerrit | Merged openstack/python-tuskarclient: Drop use of 'oslo' namespace package https://review.openstack.org/180710 | 09:12 |
*** akrivoka has joined #tripleo | 09:14 | |
openstackgerrit | Merged openstack/tuskar: Drop use of 'oslo' namespace package https://review.openstack.org/180721 | 09:14 |
*** derekh has joined #tripleo | 09:16 | |
*** athomas has joined #tripleo | 09:17 | |
*** pelix has joined #tripleo | 09:26 | |
*** akrivoka has quit IRC | 09:27 | |
openstackgerrit | Merged openstack/diskimage-builder: Support arch-specific package-installs https://review.openstack.org/176560 | 09:29 |
*** nijaba has quit IRC | 09:36 | |
openstackgerrit | Merged openstack-infra/tripleo-ci: Add heat-config-script to our Puppet CI jobs. https://review.openstack.org/174151 | 09:38 |
*** rlandy has joined #tripleo | 09:47 | |
*** akrivoka has joined #tripleo | 09:56 | |
*** lucasagomes_ has joined #tripleo | 10:00 | |
*** lucasagomes has quit IRC | 10:02 | |
*** nijaba has joined #tripleo | 10:04 | |
*** nijaba has quit IRC | 10:04 | |
*** nijaba has joined #tripleo | 10:04 | |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement list plans for the OpenStack client https://review.openstack.org/179216 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement create Plan for the OpenStack client https://review.openstack.org/179217 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement delete Plan for the OpenStack client https://review.openstack.org/179218 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement Update Plan for the OpenStack client https://review.openstack.org/179219 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement show Plan for the OpenStack client https://review.openstack.org/179220 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement Plan add Role for the OpenStack client https://review.openstack.org/179221 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement Plan remove Role for the OpenStack client https://review.openstack.org/179222 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement download Plan for the OpenStack client https://review.openstack.org/179223 | 10:07 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement list Roles for the OpenStack client https://review.openstack.org/179215 | 10:07 |
*** lucasagomes_ is now known as lucasagomes | 10:08 | |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add metering agent as neutron-server plugin https://review.openstack.org/179370 | 10:22 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent https://review.openstack.org/180535 | 10:22 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources https://review.openstack.org/178743 | 10:22 |
openstackgerrit | Dougal Matthews proposed openstack/python-tuskarclient: Implement download Plan for the OpenStack client https://review.openstack.org/179223 | 10:25 |
gfidente | marios, there is a comment on 178743 | 10:25 |
marios | looking | 10:26 |
marios | gfidente: thansk, yeah looks like rebase nit, sec | 10:26 |
*** thrash|g0ne is now known as thrash | 10:29 | |
*** ifarkas_ has quit IRC | 10:29 | |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add metering agent as neutron-server plugin https://review.openstack.org/179370 | 10:32 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent https://review.openstack.org/180535 | 10:32 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources https://review.openstack.org/178743 | 10:32 |
*** mmagr is now known as mmagr|afk | 10:39 | |
*** ifarkas has joined #tripleo | 10:52 | |
*** adrianopetrich has quit IRC | 10:53 | |
*** weshay has joined #tripleo | 10:57 | |
*** akrivoka has quit IRC | 11:00 | |
*** akrivoka has joined #tripleo | 11:03 | |
*** rhallisey has joined #tripleo | 11:17 | |
*** links has quit IRC | 11:31 | |
*** mmagr|afk is now known as mmagr | 11:32 | |
*** links has joined #tripleo | 11:32 | |
*** jistr has left #tripleo | 11:51 | |
*** jistr has joined #tripleo | 11:52 | |
*** openstackgerrit has quit IRC | 11:52 | |
*** openstackgerrit has joined #tripleo | 11:52 | |
*** trown|outttypeww is now known as trown | 12:05 | |
*** dmellado has quit IRC | 12:09 | |
*** dmellado has joined #tripleo | 12:11 | |
*** tzumainn_ has joined #tripleo | 12:12 | |
*** morazi has joined #tripleo | 12:16 | |
*** dprince has joined #tripleo | 12:16 | |
openstackgerrit | Martin Mágr proposed openstack/tripleo-heat-templates: [resubmitted] Keystone domain for Heat https://review.openstack.org/180566 | 12:22 |
*** jayg|g0n3 is now known as jayg | 12:24 | |
openstackgerrit | Merged openstack/python-tuskarclient: Implement list Roles for the OpenStack client https://review.openstack.org/179215 | 12:27 |
openstackgerrit | Merged openstack/python-tuskarclient: Implement list plans for the OpenStack client https://review.openstack.org/179216 | 12:29 |
openstackgerrit | Merged openstack/python-tuskarclient: Implement create Plan for the OpenStack client https://review.openstack.org/179217 | 12:29 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent https://review.openstack.org/180535 | 12:35 |
marios | gfidente: this fixes the config issue i was telling you about ^^ | 12:42 |
openstackgerrit | Merged openstack/tripleo-incubator: Drop usage of keystoneclient https://review.openstack.org/176715 | 12:47 |
openstackgerrit | Merged openstack/tripleo-incubator: Don't install the keystone client cli https://review.openstack.org/176716 | 12:48 |
*** pdb_ has quit IRC | 12:49 | |
*** pdb_ has joined #tripleo | 12:49 | |
*** masco has quit IRC | 12:52 | |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add metering agent as neutron-server plugin https://review.openstack.org/179370 | 12:53 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent https://review.openstack.org/180535 | 12:53 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources https://review.openstack.org/178743 | 12:53 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Update puppet docs to set ROOT_DISK https://review.openstack.org/176337 | 12:54 |
*** gfidente has quit IRC | 12:55 | |
*** gfidente has joined #tripleo | 12:55 | |
openstackgerrit | Dan Prince proposed openstack-infra/tripleo-ci: Add a ceph job https://review.openstack.org/176292 | 13:00 |
*** adrianopetrich has joined #tripleo | 13:01 | |
gfidente | dprince, left a comment on https://review.openstack.org/#/c/176292 | 13:02 |
openstackgerrit | Merged openstack/tripleo-puppet-elements: Add neutron-metering-agent to overcloud controller node element https://review.openstack.org/179368 | 13:03 |
dprince | gfidente: see my comment to derek which is in the same place you are commenting. | 13:04 |
dprince | gfidente: I can remove the ComputeCount too but one thing I would really like to see us move away from is ENV variables in Devtest to set Heat parameters. | 13:05 |
dprince | gfidente: like the L3 thing you just did for example! | 13:05 |
gfidente | dprince, I agree with the idea | 13:06 |
dprince | gfidente: At some point the ENV variables all became unwieldy and I'm trying to decouple devtest from them as much as possible. | 13:06 |
gfidente | how a cleanup change? | 13:06 |
dprince | gfidente: probably okay to leave the SCALE variables in there... | 13:06 |
gfidente | so my attempt is at making things consistent | 13:07 |
gfidente | I am okay using the env file | 13:07 |
gfidente | just make it work one or the other way, without mixing things up | 13:07 |
dprince | gfidente: right, well I would prefer not to continue adding variables for the sake of consistency. That is my point. I think we might have (or think of) better ways to do these things | 13:08 |
gfidente | dprince, so current status of things is | 13:09 |
gfidente | we have one ENV for controllers | 13:09 |
*** yog__ has quit IRC | 13:10 | |
gfidente | and we only enforce compute for the ceph job, in the custom yaml | 13:10 |
openstackgerrit | Merged openstack-infra/tripleo-ci: Enforce COMPUTESCALE to 1 for CI, except HA jobs https://review.openstack.org/173372 | 13:10 |
gfidente | nah who merged that? :( | 13:10 |
gfidente | dprince, I am lost I thought you would do the other way around | 13:11 |
dprince | gfidente: like I said. I think variables for the SCALE counts are fine | 13:11 |
dprince | gfidente: also anything devtest already supports is fair game | 13:11 |
dprince | gfidente: but please, lets try to avoid adding more ENV variables to devtest that enable specific Heat parameter/functionality | 13:12 |
gfidente | the problem I had with L3 is they are conflicting | 13:12 |
dprince | gfidente: it would been quite easy to add an ENABLE_PUPPET flag for example | 13:12 |
dprince | gfidente: but I avoided it... and I'm actually quite happy with how things can be made more generic | 13:13 |
*** rhallisey has quit IRC | 13:13 | |
openstackgerrit | Dan Prince proposed openstack-infra/tripleo-ci: Add a ceph job https://review.openstack.org/176292 | 13:15 |
*** dasm is now known as dasm|afk | 13:17 | |
*** david-lyle has quit IRC | 13:19 | |
*** jprovazn has quit IRC | 13:20 | |
*** yog__ has joined #tripleo | 13:22 | |
*** yog__ has quit IRC | 13:23 | |
*** openstackstatus has quit IRC | 13:25 | |
openstackgerrit | Marios Andreou proposed openstack/tripleo-puppet-elements: Adds neutron-lbaas-package to overcloud-controller element packages https://review.openstack.org/180530 | 13:26 |
*** openstackstatus has joined #tripleo | 13:27 | |
*** ChanServ sets mode: +v openstackstatus | 13:27 | |
*** lblanchard has joined #tripleo | 13:27 | |
marios | jistr: sorry to pester, can you reinstate your vote please (rebase) @ https://review.openstack.org/#/c/180530/2 (still waiting on jenkins), thanks very very much | 13:29 |
jistr | marios: haha sure thing :) | 13:30 |
marios | thanks :) | 13:30 |
openstackgerrit | Merged openstack/tripleo-puppet-elements: Adds neutron-lbaas-package to overcloud-controller element packages https://review.openstack.org/180530 | 13:35 |
*** yamahata has joined #tripleo | 13:37 | |
*** chlong has joined #tripleo | 13:39 | |
shardy | dprince: Hey, sorry I just -1'd a bunch of your network t-h-t patches | 13:53 |
shardy | dprince: I like the overall approach, but I'm looking for ways to simplify it | 13:53 |
*** links has quit IRC | 13:54 | |
dprince | shardy: okay, so the main reason for splitting them out was really to accomodate custom settings via parameter_defaults: | 13:56 |
shardy | dprince: Ok, cool, let me do some experiments, Heat already has some support for overiding just specific resources via the resource_registry | 13:58 |
shardy | potentially that may be a cleaner way to do it, if I can make it work with ResourceGroups | 13:58 |
*** SpamapS has quit IRC | 13:58 | |
*** rhallisey has joined #tripleo | 13:58 | |
shardy | I'll try some stuff and try to catch you later | 13:58 |
dprince | shardy: cool. FWIW I was eyeing resource groups for provider networks (which won't be nearly as invasive as these) | 13:59 |
dprince | shardy: talk to you in a bit | 14:00 |
*** jprovazn has joined #tripleo | 14:01 | |
*** mcornea_ has joined #tripleo | 14:01 | |
*** mcornea has quit IRC | 14:03 | |
*** sseago has left #tripleo | 14:04 | |
openstackgerrit | Merged openstack/tripleo-image-elements: Fix path to neutron dsn. https://review.openstack.org/179077 | 14:08 |
openstackgerrit | Merged openstack/tripleo-image-elements: Revert "An element to force install Qemu 2.1.3-3 on F21" https://review.openstack.org/176310 | 14:09 |
*** mcornea_ has quit IRC | 14:12 | |
*** jcoufal has quit IRC | 14:14 | |
*** jrist has quit IRC | 14:14 | |
*** regebro has quit IRC | 14:15 | |
EmilienM | dprince: looking at pacemaker refacto ( https://review.openstack.org/#/c/180833/2/puppet/manifests/overcloud_controller_pacemaker.pp,cm ) | 14:20 |
EmilienM | dprince: why do you include haproxy/keepalived on pacemaker node? | 14:20 |
EmilienM | is it related to a specific architecture? | 14:20 |
dprince | EmilienM: It is a WIP, (an idea) | 14:20 |
EmilienM | dprince: oh yeah I get it | 14:21 |
EmilienM | I just wonder why haproxy on pacemaker node | 14:21 |
dprince | EmilienM: if people agree then I can update the patch to remove the conditionals, and we can also remove haproxy (or whatever) for pacemaker too | 14:21 |
openstackgerrit | Marios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources https://review.openstack.org/181015 | 14:21 |
EmilienM | dprince: so tell me if I'm wrong, but overcloud_controller_pacemaker is a fork of overcloud_controller, but with pacemaker support | 14:24 |
dprince | EmilienM: basically, yes | 14:25 |
dprince | EmilienM: because what was happening to overcloud_controller.pp was everything was getting wrapped in $enable_pacemaker conditionals | 14:25 |
EmilienM | dprince: I used another approach in Spinal Stack, let me show you | 14:26 |
*** jrist has joined #tripleo | 14:26 | |
*** jrist has joined #tripleo | 14:26 | |
dprince | EmilienM: pretty much the same thing either way... just having separate files I think will be more maintainable (especially for the pacemaker version) | 14:26 |
EmilienM | because I don't like both approaches actually (as far I understand it now) | 14:26 |
dprince | EmilienM: I'm open to suggestions. But as is pacemaker is pretty much trashing our manifest :( | 14:27 |
marios | dprince: hey man, just sent a review for that ^^^ | 14:27 |
*** jcoufal has joined #tripleo | 14:27 | |
*** masco has joined #tripleo | 14:29 | |
dprince | marios: okay, thanks for pointing it out | 14:29 |
dprince | marios: I think this discussion is still ongoing. EmilienM has some thoughts to add | 14:30 |
EmilienM | a sec | 14:30 |
marios | dprince: yeah sure, just showing what it looks like, (e.g. duplication) | 14:32 |
marios | dprince: and yes easy enough to do, if that is consensus | 14:32 |
dprince | marios: I don't think it looks too bad. | 14:33 |
EmilienM | dprince: http://paste.openstack.org/show/Q9e54xUyzqBVYOpTy9QY/ | 14:34 |
dprince | marios: for your patch do the resource chains belong in puppet-neutron though? | 14:34 |
marios | dprince: sure. it is kinda clean without the conditional. if we can live with it some duplication is the price | 14:34 |
zigo | https://bugs.launchpad.net/tuskar/+bug/1452752 | 14:34 |
openstack | Launchpad bug 1452752 in tuskar "keystone_authtoken section is wrong in default shipped tuskar.conf.sample" [Undecided,Confirmed] | 14:34 |
zigo | Quite bad ! | 14:34 |
zigo | Could someone have a look into it? | 14:34 |
zigo | This has been fixed in both Cinder and Nova before the release, AFAIK. | 14:34 |
dprince | EmilienM: right, I think I saw the wrapper in puppet-openstack-cloud right? | 14:35 |
marios | dprince: how do you mean? the pcs resource service definitions? | 14:35 |
EmilienM | dprince: yup Sir | 14:35 |
dprince | marios: all these lines: Service[$::neutron::params::server_service] -> Service[$::neutron::params::dhcp_agent_service] | 14:35 |
EmilienM | dprince: that why I fought to use puppetlabs-corosync | 14:35 |
dprince | EmilienM: if we do the wrapper approach then everythign is using puppet-tripleo then right? | 14:35 |
marios | dprince: oh yeah, i just made these system independent, they were already in the overcloud_controller.yaml | 14:35 |
*** aufi is now known as aufi|afk | 14:36 | |
marios | dprince: so you think we don't need to worry about the dependences? | 14:36 |
marios | dprince: i.e. let systemd do its thing? (so remove them?) haven't tried that | 14:36 |
dprince | marios: no, not right now. Just a minor thing I noticed. That maybe these belong in puppet-neutron somewhere | 14:37 |
marios | dprince: oh i see, yeah that makes sense | 14:37 |
dprince | EmilienM: Yeah, I think we are in a position of choosing the lesser of two "evils". The duplication of class include statements doesn't bother me that much however | 14:38 |
dprince | EmilienM: some of the other conversion code and stuff does bother me but I think it could get refactored over time | 14:38 |
*** masco has quit IRC | 14:40 | |
* dprince back in a bit | 14:41 | |
EmilienM | dprince: I replied to your thread to let our community be involved | 14:42 |
*** radez_g0n3 is now known as radez | 14:45 | |
*** mcornea has joined #tripleo | 14:50 | |
openstackgerrit | Merged openstack/diskimage-builder: Fix $DIB_DEFAULT_INSTALLTYPE export statement https://review.openstack.org/179502 | 14:53 |
*** yamahata has quit IRC | 14:59 | |
*** yamahata has joined #tripleo | 14:59 | |
*** untriaged-bot has joined #tripleo | 15:00 | |
untriaged-bot | Untriaged bugs so far: | 15:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1452400 | 15:00 |
openstack | Launchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New] | 15:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449852 | 15:00 |
openstack | Launchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 15:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449854 | 15:00 |
untriaged-bot | https://bugs.launchpad.net/tuskar/+bug/1452752 | 15:00 |
*** untriaged-bot has quit IRC | 15:00 | |
openstack | Launchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 15:00 |
openstack | Launchpad bug 1452752 in tuskar "keystone_authtoken section is wrong in default shipped tuskar.conf.sample" [Undecided,Confirmed] | 15:00 |
*** jcoufal has quit IRC | 15:02 | |
*** mcornea has quit IRC | 15:06 | |
*** CheKoLyN has joined #tripleo | 15:15 | |
*** mcornea has joined #tripleo | 15:19 | |
*** radez is now known as radez_g0n3 | 15:26 | |
*** mcornea has quit IRC | 15:29 | |
*** mcornea has joined #tripleo | 15:29 | |
*** pblaho has quit IRC | 15:30 | |
*** athomas has quit IRC | 15:32 | |
*** killer_prince has quit IRC | 15:32 | |
*** alop has joined #tripleo | 15:32 | |
*** cody-somerville has joined #tripleo | 15:34 | |
*** Marga_ has joined #tripleo | 15:35 | |
*** sdake_ has joined #tripleo | 15:36 | |
*** sdake_ has quit IRC | 15:36 | |
*** sdake_ has joined #tripleo | 15:36 | |
*** Marga_ has quit IRC | 15:36 | |
*** Marga_ has joined #tripleo | 15:36 | |
*** mmagr has quit IRC | 15:39 | |
*** sdake_ has quit IRC | 15:42 | |
*** sdake has quit IRC | 15:44 | |
*** sdake has joined #tripleo | 15:44 | |
*** morazi has quit IRC | 15:49 | |
*** jehb has joined #tripleo | 15:49 | |
*** morazi has joined #tripleo | 15:50 | |
*** morazi has quit IRC | 15:57 | |
*** morazi has joined #tripleo | 15:57 | |
*** rhallisey has quit IRC | 16:00 | |
*** rhallisey has joined #tripleo | 16:03 | |
*** trown is now known as trown|lunch | 16:05 | |
*** adrianopetrich has quit IRC | 16:06 | |
*** MasterPiece has joined #tripleo | 16:12 | |
*** mcornea has quit IRC | 16:15 | |
*** SpamapS has joined #tripleo | 16:18 | |
*** SpamapS has quit IRC | 16:18 | |
*** SpamapS has joined #tripleo | 16:18 | |
*** derekh has quit IRC | 16:19 | |
Ng | greghaynes: bleh, gertty chewed up the comments I put in a review on 155484, they should relate to lines 51 and 50, respectively | 16:21 |
greghaynes | Ng: heh, this smelled like a gertty gone wrong | 16:22 |
*** Marga_ has quit IRC | 16:24 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Support building ACIs https://review.openstack.org/155484 | 16:24 |
*** shakamunyi has quit IRC | 16:29 | |
*** Marga_ has joined #tripleo | 16:31 | |
*** lucasagomes has quit IRC | 16:33 | |
openstackgerrit | Jiri Stransky proposed openstack/tripleo-heat-templates: Add Cinder as a Pacemaker resource https://review.openstack.org/181067 | 16:34 |
greghaynes | w00t https://review.openstack.org/#/c/174681/ passes | 16:36 |
greghaynes | SpamapS: ^ needs re-review | 16:36 |
*** gfidente has quit IRC | 16:36 | |
*** gfidente has joined #tripleo | 16:36 | |
SpamapS | greghaynes: done | 16:40 |
*** hewbrocca has quit IRC | 16:45 | |
greghaynes | \O/ | 16:45 |
*** aufi|afk is now known as aufi | 16:50 | |
*** aufi has quit IRC | 16:50 | |
*** eghobo has joined #tripleo | 16:51 | |
openstackgerrit | James Slagle proposed openstack/tripleo-puppet-elements: Add puppet-stack-config element https://review.openstack.org/153375 | 16:52 |
*** sdake_ has joined #tripleo | 16:52 | |
*** adrianopetrich has joined #tripleo | 16:54 | |
*** sdake has quit IRC | 16:56 | |
*** Marga_ has quit IRC | 17:00 | |
openstackgerrit | Giulio Fidente proposed openstack/tripleo-heat-templates: Provide RabbitMQ clients with a list of servers instead of VIP https://review.openstack.org/181081 | 17:07 |
*** Goneri has quit IRC | 17:09 | |
*** sdake has joined #tripleo | 17:13 | |
*** yamahata has quit IRC | 17:14 | |
*** eghobo_ has joined #tripleo | 17:15 | |
*** eghobo has quit IRC | 17:16 | |
*** jistr has quit IRC | 17:17 | |
*** sdake_ has quit IRC | 17:17 | |
*** radez_g0n3 is now known as radez | 17:24 | |
*** Marga_ has joined #tripleo | 17:25 | |
openstackgerrit | Merged openstack/diskimage-builder: package-installs: fix error case for Python 2.6 https://review.openstack.org/180561 | 17:25 |
*** Marga_ has quit IRC | 17:30 | |
*** Marga_ has joined #tripleo | 17:30 | |
*** Marga_ has quit IRC | 17:31 | |
*** pelix has quit IRC | 17:31 | |
openstackgerrit | Merged openstack/python-tuskarclient: Correct plan-remove-role to handle return of delete correctly https://review.openstack.org/173026 | 17:35 |
*** Marga_ has joined #tripleo | 17:35 | |
*** yamahata has joined #tripleo | 17:40 | |
*** anteaya has quit IRC | 17:45 | |
*** trown|lunch is now known as trown | 17:48 | |
*** jistr has joined #tripleo | 17:49 | |
*** derekh has joined #tripleo | 17:59 | |
*** masco has joined #tripleo | 18:03 | |
*** sdake has quit IRC | 18:08 | |
*** sdake has joined #tripleo | 18:09 | |
*** derekh has quit IRC | 18:18 | |
*** penick has joined #tripleo | 18:25 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: load-images: load images via YAML config file https://review.openstack.org/175028 | 18:29 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Wire in load-images https://review.openstack.org/175522 | 18:29 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Add diskimage-builder/bin to PATH. https://review.openstack.org/177198 | 18:29 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: devtest_overcloud.sh: split out image building https://review.openstack.org/173645 | 18:29 |
*** Marga_ has quit IRC | 18:32 | |
*** Marga_ has joined #tripleo | 18:36 | |
*** masco has quit IRC | 18:40 | |
*** penick has quit IRC | 18:41 | |
*** penick has joined #tripleo | 18:41 | |
*** sdake_ has joined #tripleo | 18:43 | |
*** sdake has quit IRC | 18:47 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Add a puppet disk images YAML file https://review.openstack.org/181114 | 18:48 |
*** jistr has quit IRC | 18:51 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Add a puppet disk images YAML file https://review.openstack.org/181114 | 18:52 |
openstackgerrit | Dan Prince proposed openstack-infra/tripleo-ci: puppet: use a single image for CI https://review.openstack.org/177060 | 18:54 |
dprince | slagle: Could you be more specific about what you would like me to change here https://review.openstack.org/#/c/173645/11 | 18:58 |
dprince | slagle: I'm having a tough time getting everyone's comments accomodated apparently | 18:58 |
slagle | dprince: it's what i said in my earlier comment | 18:59 |
slagle | dprince: adding -c to the new images build script | 18:59 |
slagle | previously there was a -c for the image building, now there wouldn't be | 18:59 |
dprince | slagle: That is a new script and there should be no expecation that a user has a -c option there. | 18:59 |
dprince | slagle: I'll add it mind you if you require it... but in a new patchset | 19:00 |
slagle | i disagree | 19:00 |
dprince | slagle: shouldn't hold this (already quite large) patch up for such a trivial thing | 19:00 |
dprince | slagle: you have a preference for larger patches? | 19:00 |
slagle | again, i disagree on the principal that it is in fact an expectation | 19:00 |
dprince | slagle: fine, but you can't disagree that this is a new script | 19:00 |
dprince | slagle: not having the option (yet) breaks no-one | 19:01 |
dprince | slagle: the previous -c works as is.... | 19:01 |
dprince | slagle: quite nicely I might add | 19:01 |
slagle | on something that you label deprecated | 19:01 |
slagle | and say "go use this new thing" | 19:01 |
slagle | oh, and btw, which doesn't have -c | 19:01 |
slagle | i'm probably overly sensitive to the user experience | 19:02 |
dprince | slagle: okay, I can add it. FWIW I was just really confused because of the inline comments on this review too. This is totally unrelated to what I was explaining to Guilio about not adding more ENV variables to devtest_overcloud.sh | 19:02 |
slagle | in this specific patch, i know those 2 comments are unrelated. i don't think that i did related them in any way | 19:04 |
dprince | slagle: this patch series speeds up our CI BTW. I would have liked to have my tripleo-ci patch to do similar things in a month ago, sigh | 19:04 |
slagle | i was commenting on your comment to giulio | 19:04 |
slagle | dprince: i know that | 19:05 |
dprince | slagle: well, I left a follow up... to the extent we agreed a while back not to add more of these types of variables | 19:05 |
dprince | slagle: I've got a few abandone branches that were trying to do similar things... | 19:06 |
dprince | slagle: just FYI | 19:06 |
slagle | dprince: i'm well aware, and i believe, at the time, it was to use optional arguments | 19:06 |
slagle | which is why i said i thought maybe it was premature to say it was now to drive everything via the heat environment | 19:07 |
dprince | slagle: right, I'm not sure Guilio was aware though | 19:08 |
* bnemec needs to sit down and write the rationalize-ui spec so we're all on the same page about this stuff | 19:09 | |
dprince | slagle: looking at the devtest landscape it is quite a mess, easy for someone to come in and say, it was done this way before so I can do it in a similar fashion. Just trying to help us raise the bare, that is all | 19:09 |
* bnemec has been saying that for about a year and a half | 19:09 | |
slagle | dprince: yes, of course. you realize you're also making my argument about adding the -c, right? | 19:10 |
dprince | slagle: and I don't we need to drive *everything* this way. But most of the enable this or that parameters, yeah. I think I'd like all of those gone. | 19:10 |
dprince | SCALE... variables are probably fine | 19:10 |
slagle | so, in a way, these 2 comments really are related | 19:10 |
slagle | the devtest landscape is a mess | 19:10 |
slagle | we need to raise the bar | 19:10 |
slagle | not have a lower bar for new scripts | 19:10 |
dprince | slagle: just feel like I'm being nit picked a bit here. Like I said I've been trying to land this idea (in one shape or another) for over a month now. | 19:11 |
dprince | slagle: not against -c. Just doesn't seem all that important | 19:12 |
dprince | slagle: but if it is a show stopper I'll add it :) | 19:12 |
slagle | dprince: i'm willing to admit it's borderline nit pick | 19:12 |
slagle | upon reflection though, i do feel strongly enough though that it's user experience related, and that's what pushed me to the -1 | 19:13 |
dprince | slagle: I'm fixing it. | 19:13 |
slagle | i'm certainly not blocking landing it w/o it. | 19:14 |
slagle | i know things aren't likely to land with a -1 on there...but it's not blocked | 19:14 |
dprince | slagle: The puppet user experience IMO is quite a bit nicer w/ this: https://review.openstack.org/#/c/181114/2/doc/source/puppet.rst,cm | 19:14 |
* dprince is quite happy w/ how it is turning out | 19:15 | |
slagle | i like it as well | 19:16 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: load-images: load images via YAML config file https://review.openstack.org/175028 | 19:23 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Add a puppet disk images YAML file https://review.openstack.org/181114 | 19:23 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Wire in load-images https://review.openstack.org/175522 | 19:23 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Add diskimage-builder/bin to PATH. https://review.openstack.org/177198 | 19:23 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: devtest_overcloud.sh: split out image building https://review.openstack.org/173645 | 19:23 |
*** Marga_ has quit IRC | 19:28 | |
*** akrivoka has quit IRC | 19:43 | |
gfidente | dprince, slagle oh so just that I can explain myself | 19:48 |
gfidente | I figured we had a few params which shouldn't go together | 19:48 |
gfidente | and sure we could explain that in some .rst | 19:49 |
gfidente | but I thought a case switch could work there | 19:50 |
*** yamahata has quit IRC | 19:50 | |
gfidente | I think documenting the different env vars needed for some feature can turn useful to tuskar and the converged cli | 19:51 |
gfidente | but for the l3 specifically the problem is we really want to make sure one of the option which is enabled by default gets disabled when ha or dvr is used | 19:51 |
gfidente | so it is not just about documenting the needed params, we should probably set relocation to false by default as well | 19:52 |
gfidente | so one can document which params need to be enabled for any of the three scenarios, relocation, ha, dvr | 19:52 |
gfidente | without risking any other of the options, enabled by default, is going to conflict with the selection | 19:53 |
gfidente | maybe the template param itself should be turned into a case, like the glance backend | 19:54 |
gfidente | but this goes back to deprecating the old elements-based implementation ... | 19:55 |
gfidente | *documenting the different template params is useful, not documenting the different env vars | 19:56 |
*** lblanchard has quit IRC | 19:56 | |
gfidente | so I did not see many other options | 19:57 |
slagle | gfidente: yea, there isn't a great way to do it. i think the alternative would have been to use arguments to the script | 20:05 |
slagle | but you're absolutely right about driving things via the heat environment file... | 20:06 |
slagle | how do you know what to put in there? and do we need something to create that file? | 20:06 |
gfidente | so while for new things, like ceph, we can just document what are the needed params | 20:07 |
gfidente | for the l3 thing we needed to make sure another param, which is enabled by default, gets set to false | 20:07 |
gfidente | maybe we could have switched off the default in the template | 20:08 |
*** Slower has quit IRC | 20:09 | |
*** Slower has joined #tripleo | 20:10 | |
openstackgerrit | Jan Provaznik proposed openstack/tripleo-common: Add package update support https://review.openstack.org/179862 | 20:17 |
openstackgerrit | Jan Provaznik proposed openstack/tripleo-common: Scale out heat stack https://review.openstack.org/173283 | 20:17 |
openstackgerrit | Jan Provaznik proposed openstack/tripleo-common: Add a step-through heat stack update module https://review.openstack.org/178150 | 20:17 |
dprince | gfidente: So (once this settle down) I'd like to propose that we create an "environments" directory in the incubator to hold files like this: https://review.openstack.org/#/c/176292/4/toci_gate_test.sh,cm | 20:18 |
dprince | gfidente: I could easily move the ceph file into the inbubator now if there is interest. | 20:19 |
dprince | gfidente: The files are YAML... and can easily be documented. | 20:19 |
dprince | gfidente: and adding one for all the L3 stuff wouldn't be to hard I think | 20:20 |
dprince | gfidente: this was the idea behind OVERCLOUD_CUSTOM_HEAT_ENV at least | 20:22 |
dprince | gfidente: and shardy suggested we even make that support multiple files too | 20:22 |
dprince | which is a great idea I think | 20:22 |
*** Marga_ has joined #tripleo | 20:23 | |
*** Marga_ has quit IRC | 20:23 | |
*** Marga_ has joined #tripleo | 20:24 | |
*** jayg is now known as jayg|g0n3 | 20:26 | |
*** sdake_ has quit IRC | 20:29 | |
gfidente | dprince, yes that is nice | 20:31 |
gfidente | I was worried about failover option which has to be disabled when using either l3ha or l3dvr | 20:32 |
gfidente | we can add that into the environment file | 20:33 |
dprince | gfidente: right, all easily commentable because they are YAML. Make it as verbose as you'd like | 20:33 |
gfidente | maybe we should just add some documentation into the devtest_overcloud script on how to use the environment files | 20:35 |
*** bnemec has quit IRC | 20:36 | |
dprince | gfidente: sure. I'm talking about adding a new directory to hold these things. Perhaps starting with this ceph CI job stuff. | 20:36 |
gfidente | as for the params, they still seem to have some advantage | 20:38 |
gfidente | you can use l3ha and ceph | 20:38 |
gfidente | *as per the ENV vats | 20:39 |
gfidente | I can see that can be sorted with multiple HEAT_ENV | 20:39 |
dprince | gfidente: right, that is why I mentioned the option to source multiple files | 20:39 |
gfidente | so maybe we get there by steps | 20:39 |
gfidente | I think the conversation was useful | 20:39 |
gfidente | well, it was to me at least | 20:40 |
*** Marga_ has quit IRC | 20:41 | |
*** Marga_ has joined #tripleo | 20:42 | |
dprince | gfidente: cool :) | 20:42 |
gfidente | dprince, slagle so one more thing I am facing here: https://review.openstack.org/#/c/181081/ | 20:42 |
gfidente | I tried to get the rabbit_node_ips formatted as an array | 20:43 |
gfidente | it DOES work ( that is hiera rabbit_node_ips returns an array ) | 20:43 |
gfidente | but usage of %{hiera(rabbit_node_ips)} for nova::rabbit_hosts DOES NOT work | 20:43 |
gfidente | because it does *string* interpolation | 20:43 |
dprince | gfidente: I think we should make this pacemaker specific | 20:43 |
gfidente | so the value of nova::rabbit_host is going to be a string, even though it looks like an array | 20:44 |
gfidente | while the value of rabbit_node_ips is an actual array | 20:44 |
gfidente | dprince, this one is not related to pacemaker | 20:44 |
dprince | gfidente: or, at least put some thought into what you are suggesting effects isolated networks. | 20:44 |
dprince | gfidente: is it not pacemaker that perfers hostnames? | 20:44 |
gfidente | nah the change is not about hostnames actually | 20:44 |
gfidente | it is for the rabbit clients to get the list of rabbit nodes instead of going via haproxy | 20:45 |
gfidente | but the problem I was pointing at is not about the change itself | 20:45 |
gfidente | but about how string interpolation works in hiera | 20:45 |
dprince | gfidente: oh, where did I get hostname from!!! I will look at it | 20:45 |
dprince | gfidente: could you leave a clear comment on the review with regards to your issue? | 20:46 |
gfidente | dprince, yeah I was trying to use the YAML & and * notation | 20:46 |
gfidente | which DOES work preserving the value type (array) | 20:46 |
gfidente | but only if both keys are in same .yaml | 20:46 |
gfidente | I will yes | 20:46 |
dprince | ah, I see | 20:47 |
gfidente | so it sums up into: rabbit_node_ips is an array, but nova::rabbit_hosts is a string (because of interpolation) | 20:47 |
gfidente | which makes puppet-nova to complain as rabbit_hosts is not an array | 20:47 |
dprince | gfidente: we need better support in the Hiera element for arrays I think | 20:49 |
dprince | gfidente: which may require re-writing it in python rather than bash | 20:49 |
dprince | gfidente: in the meantime I think there is a way to carefully construct the string in heat to satisfy it... just need to mess w/ it a bit | 20:49 |
gfidente | dprince, note that rabbit_node_ips is an array there, the heat manipulation does the job | 20:50 |
gfidente | rabbit_node_ips can be consumed as an array from within the .pp | 20:50 |
gfidente | it is nova::rabbit_hosts which can't, due to return value of %P{ | 20:51 |
gfidente | sorry, of %{} | 20:51 |
*** bnemec has joined #tripleo | 20:51 | |
* gfidente saw CI failing on the non-puppet job from a few hours now | 20:53 | |
* gfidente leaving though because it is pretty late here | 20:54 | |
openstackgerrit | James Slagle proposed openstack/tripleo-heat-templates: post-deploy hook for rhel registration https://review.openstack.org/172065 | 20:55 |
*** ifarkas has quit IRC | 20:57 | |
*** Marga_ has quit IRC | 20:58 | |
*** Marga_ has joined #tripleo | 20:58 | |
*** untriaged-bot has joined #tripleo | 21:00 | |
untriaged-bot | Untriaged bugs so far: | 21:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1452400 | 21:00 |
openstack | Launchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New] | 21:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449852 | 21:00 |
openstack | Launchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 21:00 |
untriaged-bot | https://bugs.launchpad.net/diskimage-builder/+bug/1449854 | 21:00 |
openstack | Launchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87) | 21:00 |
untriaged-bot | https://bugs.launchpad.net/tuskar/+bug/1452752 | 21:00 |
openstack | Launchpad bug 1452752 in tuskar "keystone_authtoken section is wrong in default shipped tuskar.conf.sample" [Undecided,Confirmed] | 21:00 |
*** untriaged-bot has quit IRC | 21:00 | |
gfidente | I think the CI breakage is this http://logs.openstack.org/45/173645/13/check-tripleo/check-tripleo-ironic-overcloud-f20-nonha/6f8e051/logs/seed_logs/ironic-api.txt.gz | 21:07 |
*** sdake has joined #tripleo | 21:08 | |
*** sdake_ has joined #tripleo | 21:11 | |
*** sdake has quit IRC | 21:15 | |
*** EmilienM is now known as EmilienM|afk | 21:16 | |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: devtest_testenv.sh: support for multiple bridges https://review.openstack.org/177880 | 21:18 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Allow libvirt to assign PCI slots for us https://review.openstack.org/180841 | 21:18 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: Allow configurable bridge names and clean all. https://review.openstack.org/177877 | 21:18 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: configure-vm: allow multiple baremetal-interface's https://review.openstack.org/177876 | 21:18 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: create-nodes: allow multiple bridge names https://review.openstack.org/177879 | 21:18 |
openstackgerrit | Dan Prince proposed openstack/tripleo-incubator: setup-network: allow creation of multiple bridges https://review.openstack.org/177878 | 21:18 |
*** dprince has quit IRC | 21:20 | |
*** weshay has quit IRC | 21:23 | |
*** bnemec has quit IRC | 21:25 | |
*** rhallisey has quit IRC | 21:27 | |
*** jprovazn has quit IRC | 21:29 | |
*** sdake_ is now known as sdake | 21:30 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add debian build test case https://review.openstack.org/181161 | 21:44 |
greghaynes | adam_g: ^ you should like that one | 21:44 |
*** gfidente has quit IRC | 21:47 | |
*** trown is now known as trown|outttypeww | 21:48 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add tests for building *-minimal images https://review.openstack.org/181162 | 21:49 |
*** Marga_ has quit IRC | 21:50 | |
*** jpeeler has quit IRC | 21:50 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add debian build test case https://review.openstack.org/181161 | 21:51 |
*** rlandy has quit IRC | 21:54 | |
*** sdake_ has joined #tripleo | 21:54 | |
*** david-lyle has joined #tripleo | 21:56 | |
*** sdake has quit IRC | 21:58 | |
*** chlong has quit IRC | 21:59 | |
*** shardy has quit IRC | 22:00 | |
*** Marga_ has joined #tripleo | 22:08 | |
*** sdake has joined #tripleo | 22:22 | |
*** Marga_ has quit IRC | 22:25 | |
*** sdake_ has quit IRC | 22:25 | |
*** Marga_ has joined #tripleo | 22:26 | |
*** eghobo_ has quit IRC | 22:27 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add smoketest for fedora https://review.openstack.org/178040 | 22:28 |
*** Marga_ has quit IRC | 22:29 | |
*** Marga_ has joined #tripleo | 22:29 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Initial element tests https://review.openstack.org/174681 | 22:36 |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add smoketest for fedora https://review.openstack.org/178040 | 22:37 |
*** david-lyle has quit IRC | 22:38 | |
openstackgerrit | Merged openstack/diskimage-builder: Package ldlinux.c32 along with isolinux.bin if it exists https://review.openstack.org/178534 | 22:42 |
*** sdake has quit IRC | 22:51 | |
*** sdake has joined #tripleo | 22:53 | |
*** BadCub is now known as BadCub_Hiding | 22:55 | |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add debian build test case https://review.openstack.org/181161 | 22:56 |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add debian build test case https://review.openstack.org/181161 | 22:59 |
openstackgerrit | greghaynes proposed openstack/diskimage-builder: Add tests for building *-minimal images https://review.openstack.org/181162 | 23:04 |
*** CheKoLyN has quit IRC | 23:11 | |
*** chlong has joined #tripleo | 23:24 | |
*** Marga_ has quit IRC | 23:28 | |
*** rhallisey has joined #tripleo | 23:34 | |
*** Marga_ has joined #tripleo | 23:42 | |
*** eghobo has joined #tripleo | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!