Thursday, 2015-05-07

SpamapSLotus907efi: those scripts don't get run, they're there to be copied into the target instance.00:00
Lotus907efioh00:00
Lotus907efiok00:00
SpamapSmakes it easy to do 'install $(dirname $0)/foo /usr/local/bin'00:00
Lotus907efiso by putting a dot in the name00:00
Lotus907efithey are not run as an element script00:01
SpamapSbut I'd rather see install $(dirname $0)/../foo ....00:01
SpamapSLotus907efi: yeah, it's entirely possible it is a happy accident.00:01
Lotus907efior a separate directory for stuff to be placed in the image00:01
Lotus907efithat are not expected to run as scripts00:01
Lotus907efisomething like a copy.d directory00:01
Lotus907efiwhere element scripts are NOT run from00:01
*** Marga_ has joined #tripleo00:02
SpamapSLotus907efi: yeah, so, I think this is one of those things where we should open a bug, and start thinking about how to enact a breaking change, but it might take a year+ to get that fixed.00:02
Lotus907efia year?00:02
Lotus907efihehehehe00:02
Lotus907efiwell I don't think I will wait and hold my breath for a fix00:03
greghaynesas long as you dont mind your script being owned by root theres no reason to put it in the .d dirs now00:04
greghayneswe have an element that will automagically do the file copying for you00:05
greghaynesbut yea, backwards compat :/00:05
SpamapSLotus907efi: no, I wouldn't either, but just making sure you know that I do think it should be better.00:05
Lotus907efiah, ok00:05
SpamapSgreghaynes: we do?00:05
Lotus907efiit would be cool if there was some sort of warning text00:05
Lotus907efihat said the script was not being executed because of the dot in the name00:06
SpamapSLotus907efi: yeah, thats where we need to define the "right way" and start warning first.00:06
Lotus907efiat least then it would not have taken so long to figure out00:06
SpamapSgreghaynes: what element is that?00:06
Lotus907efiand that would not break backwards compatibility00:06
Lotus907efiyeah, what element?00:06
greghaynesSpamapS: http://docs.openstack.org/developer/diskimage-builder/elements/install-static/README.html00:07
greghaynes(took me a few to remember the name)00:07
Lotus907efihmmm, ok00:07
Lotus907efiI will look at that later. Taking my dad out to spaghetti dinner now00:07
Lotus907efithanks for the confirmation00:07
SpamapSLotus907efi: np, thanks for reporting!00:08
* SpamapS files the bug report00:08
SpamapSLotus907efi: https://bugs.launchpad.net/diskimage-builder/+bug/1452509 <-- feel free to subscribe/edit/comment00:12
openstackLaunchpad bug 1452509 in diskimage-builder "Not executing executable files in .d directories silently is very confusing" [Medium,Triaged]00:12
*** cwolferh has quit IRC00:15
*** Marga_ has quit IRC00:17
*** Marga_ has joined #tripleo00:17
SpamapShm00:26
openstackgerritMerged openstack/tripleo-incubator: build-images: drive DIB via YAML config file  https://review.openstack.org/17364400:26
*** eghobo_ has quit IRC00:30
*** eghobo has joined #tripleo00:33
*** saurabhs has left #tripleo00:41
SpamapSLotus907efi: https://review.openstack.org/18080700:42
SpamapSgreghaynes: ^^00:42
SpamapSlos like dib-utils doesn't have gerritbot configs00:42
*** lazy_prince has joined #tripleo00:49
*** shakamunyi has quit IRC01:02
*** Marga_ has quit IRC01:42
*** Marga_ has joined #tripleo01:43
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Update neutron local_ip to use the tenant network  https://review.openstack.org/17871601:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add a network ports IP mapping resource  https://review.openstack.org/17871401:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add a service ports to network mapping resource  https://review.openstack.org/17871501:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to controller roles  https://review.openstack.org/17784601:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add a ports (ip address) abstraction layer  https://review.openstack.org/17784501:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Wire in optional network creation for overcloud  https://review.openstack.org/17784401:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Create split out neutron networks via Heat.  https://review.openstack.org/17784301:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add isolated net parameters to net-config stacks  https://review.openstack.org/18082001:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to compute roles  https://review.openstack.org/18082101:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to ceph roles  https://review.openstack.org/18082201:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to swift roles  https://review.openstack.org/18082301:49
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Add isolated network ports to block storage roles  https://review.openstack.org/18082401:49
*** eghobo has quit IRC01:55
*** sseago has joined #tripleo02:02
*** lazy_prince has quit IRC02:07
*** shakamunyi has joined #tripleo02:09
*** yamahata has joined #tripleo02:17
*** yamahata has quit IRC02:20
*** yamahata has joined #tripleo02:20
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Puppet: Split out controller pacemaker manifest  https://review.openstack.org/18083302:24
openstackgerritDan Prince proposed openstack/tripleo-heat-templates: Puppet: Split out controller pacemaker manifest  https://review.openstack.org/18083302:37
*** Marga_ has quit IRC02:45
openstackgerritDan Prince proposed openstack/tripleo-incubator: load-images: load images via YAML config file  https://review.openstack.org/17502802:51
openstackgerritDan Prince proposed openstack/tripleo-incubator: Wire in load-images  https://review.openstack.org/17552202:51
openstackgerritDan Prince proposed openstack/tripleo-incubator: Add diskimage-builder/bin to PATH.  https://review.openstack.org/17719802:51
openstackgerritDan Prince proposed openstack/tripleo-incubator: devtest_overcloud.sh: split out image building  https://review.openstack.org/17364502:51
*** rbrady has quit IRC02:53
*** untriaged-bot has joined #tripleo03:00
untriaged-botUntriaged bugs so far:03:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/145240003:00
openstackLaunchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New]03:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985203:00
openstackLaunchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)03:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985403:00
openstackLaunchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)03:00
*** untriaged-bot has quit IRC03:00
*** nijaba has quit IRC03:02
openstackgerritDan Prince proposed openstack/tripleo-incubator: Allow libvirt to assign PCI slots for us  https://review.openstack.org/18084103:04
*** nijaba has joined #tripleo03:08
*** nijaba has quit IRC03:08
*** nijaba has joined #tripleo03:08
*** sdake_ has joined #tripleo03:09
*** sdake has quit IRC03:13
*** sdake has joined #tripleo03:36
*** spzala has quit IRC03:36
*** sdake_ has quit IRC03:39
*** jrist has quit IRC03:43
*** pcrews has quit IRC03:43
*** links has joined #tripleo03:45
*** jrist has joined #tripleo03:55
*** jrist has joined #tripleo03:55
*** masco has joined #tripleo04:01
*** tzumainn_ has quit IRC04:16
*** lazy_prince has joined #tripleo04:21
*** pcrews has joined #tripleo04:41
greghaynesSpamapS: oh, ha, looks like I didnt add dib tests to dib-utils04:42
*** masco has quit IRC04:55
greghaynesSpamapS: https://review.openstack.org/#/c/180861/04:58
*** sdake has quit IRC05:20
*** jprovazn has joined #tripleo05:23
*** jprovazn has quit IRC05:23
*** sdake has joined #tripleo05:24
*** sdake_ has joined #tripleo05:26
*** sdake has quit IRC05:29
*** killer_prince has joined #tripleo05:33
*** lazy_prince has quit IRC05:36
*** eghobo has joined #tripleo05:40
*** killer_prince has quit IRC05:43
*** lazy_prince has joined #tripleo05:43
*** jtomasek has joined #tripleo05:43
*** ukalifon1 has joined #tripleo06:02
*** dasm|afk is now known as dasm06:05
*** lazy_prince has quit IRC06:06
*** masco has joined #tripleo06:09
*** sdake_ is now known as sdake06:10
*** ukalifon1 has quit IRC06:11
openstackgerritMerged openstack/python-tuskarclient: Add initial python-openstackclient plugin  https://review.openstack.org/17921306:13
openstackgerritMerged openstack/python-tuskarclient: Add stub commands and tests for all OpenStack client commands  https://review.openstack.org/17921406:17
*** jcoufal has joined #tripleo06:28
*** lazy_prince has joined #tripleo06:32
*** killer_prince has joined #tripleo06:34
*** lazy_prince has quit IRC06:37
*** aufi has joined #tripleo06:41
openstackgerritMerged openstack/diskimage-builder: epel: support centos element  https://review.openstack.org/18054706:48
*** jprovazn has joined #tripleo06:49
*** bkero has quit IRC06:50
*** bkero has joined #tripleo06:50
*** mmagr has joined #tripleo07:11
mariosd0ugal: gonna call it there, will do another run tomorrow :)07:16
d0ugalmarios: Awesome, thanks very much.07:17
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement Plan add Role for the OpenStack client  https://review.openstack.org/17922107:18
*** rbrady has joined #tripleo07:18
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement Plan remove Role for the OpenStack client  https://review.openstack.org/17922207:18
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement download Plan for the OpenStack client  https://review.openstack.org/17922307:18
*** rbrady has quit IRC07:18
*** rbrady has joined #tripleo07:18
*** mmagr has quit IRC07:19
*** Goneri has joined #tripleo07:30
*** mmagr has joined #tripleo07:32
*** ifarkas has joined #tripleo07:34
*** Goneri has quit IRC07:37
*** gfidente has joined #tripleo07:38
gfidentemorning :)07:38
marioso/07:39
mariosgfidente: thanks very much for checking the puppet-neutron07:40
mariosgfidente: so if we just add the enabled stuff as you commented should be good?07:40
gfidenteyep07:40
mariosexcellente07:41
gfidentesync_db honoured here https://github.com/stackforge/puppet-neutron/blob/0ab2afac6d912e378c417f0731a3041f6b0e0348/manifests/server.pp#L28307:41
gfidenteenabled needs to be set because of https://github.com/stackforge/puppet-neutron/blob/0ab2afac6d912e378c417f0731a3041f6b0e0348/manifests/server.pp#L50507:41
marioscool, so in the glance case this wasn't decoupled like this (considered by itself)07:41
gfidenteyeah07:41
gfidenteglance _> https://review.openstack.org/#/c/180229/07:42
gfidenteothers are affected, keystone and cinder07:42
gfidentejistr joining the effort to fix where needed07:42
gfidentenova instead is fine, like neutron07:43
gfidenteothers we will see...07:43
*** Goneri has joined #tripleo07:49
mariosgot a couple of super easy reviews if anyone is in review mode: https://review.openstack.org/#/c/179368/ and  https://review.openstack.org/#/c/180530/07:54
*** jistr has joined #tripleo07:54
mariosthe first adds the neutron-metering-agent and the second the neutron-lbaas packages to the overcloud controller element packages07:55
*** yog__ has joined #tripleo07:55
jistrmarios: +2'd the second one too07:57
*** athomas has joined #tripleo07:57
jistrgood morning :)07:57
gfidentejistr, I mentioned you even before you joined07:58
*** eghobo has quit IRC08:00
hewbroccaHey, you HA folks have any thoughts about dprince's comment on the pacemaker manifest?08:01
* jistr reads that08:03
*** jcoufal_ has joined #tripleo08:03
gfidentehewbrocca, yeah was looking at that as well08:04
hewbroccasocial has been yelling at me about all the if/elses in our puppet08:05
hewbrocca:)08:05
hewbroccaso I am sensitive to that08:06
*** jcoufal has quit IRC08:07
gfidentelet me try08:08
gfidenteas per initial paragraph, we could run with pacemaker on single node (we already do), but I support the idea of leaving space for the non-pacemaker scenario as well so that doesn't look like a great option to me08:10
gfidentetwo sets of manifests for the non-pacemaker vs pacemaker scenario could work, but I am a little worried about duplication of all the config bits which are not specific to $enable_pacemaker (and they are the vast majority)08:11
jistrgfidente: that's exactly my thinking08:12
jistri do think that we should split things out though08:12
jistri've been suggesting that we should have more of a composition layer for some time now08:13
gfidenteso on how and when, looks something more appropriate for puppeteers08:13
* gfidente isn't terrified about current status though08:14
hewbroccaSomehow I thought the heat templates *were* the composition layer08:14
hewbroccaOne day I will have someone explain to me just what a composition layer is and why we have so many of them08:15
gfidentejistr, let me see if I got what you mean, that is moving the shared part in some files which can include from two different top-level manifests for pacemaker vs non-pacemaker08:16
gfidente*can be included08:16
gfidentejistr, I'm going to switch the rabbit clients to list of hosts today08:17
jistrhewbrocca: so in the puppet sense of the word, it's a way to structure calling out to lower-level puppet modules, so that we don't have a huge .pp file like we have now. Heat can only accept one .pp file as manifest, not a whole puppet module. So if we wanted to have a composition layer, it would have to be a separate repo. Puppet-tripleo already plays that role, but we've been shy of extracting things to it. I guess it's because when you08:18
jistrchange something there, you need to rebuild the image, so the feedback loop is slow.08:18
jistrhewbrocca: however i have a patch which should allow us to change puppet manifests without rebuilding images https://review.openstack.org/#/c/179177/08:18
hewbroccainteresting08:19
gfidenteone limitation we seem to be hitting with heat is (I'd say, but heat people can help) that it can't change what data is exposed based on the params it gets08:21
jistrgfidente: actually i meant more like having one top-level manifest, and including bits from puppet-tripleo there rather than having everything inlined08:21
*** panda has quit IRC08:21
gfidentejistr, moving the shared part in to the puppet-tripleo module?08:21
*** panda has joined #tripleo08:21
jistrgfidente: could be both the shared parts and non-shared parts08:21
gfidentebut with one top-level the ifs would stay in that top-level08:22
jistrgfidente: yea that's right, but the top level manifest would be a dispatcher type thing rather than a big blob08:23
gfidenteokay, see that now08:23
*** chlong has quit IRC08:23
jistri see what dprince is suggesting as somewhat more heat-ish way of solving this08:24
*** aufi has quit IRC08:24
jistrthe issues i see currently:08:24
jistr1. duplication of the shared parts (as you noted)08:24
*** aufi has joined #tripleo08:24
jistr2. what if we want to "fork" again based on some other option in the future... we'd have to have a matrix of .pp files instead of just two, which would get out of hand fast...08:26
gfidentelooking at dprince's proposal, I think he is using the heat registry just to have two different top-level .pp , not to change the data provisioned08:26
jistryeah that makes sense i think08:27
*** ifarkas has quit IRC08:27
jistrstill not sure about having two .pp files though...08:27
gfidentewell I think that is to get rid of the ids08:27
gfidente*ifs08:27
gfidentebut it only works coupled with the effort to move shared part into puppe-tripleo08:27
*** lucasagomes has joined #tripleo08:28
gfidenteso I personally feel like08:28
gfidenteit is more urgent to get the seed configured via puppet08:29
gfidenteand deprecate the old elements-based templates08:29
gfidentethat is a requirement to make puppet the default into devtest08:30
gfidenteand this seems more relevant to me, to get people use and consume tripleo08:30
gfidentethan the ifs in the .pp08:30
gfidentebut maybe we can do both at the same time08:31
gfidenteand I had to join some effort, I'd helping on making puppet the default :)08:32
jistryeah i kinda agree with that priority list. In the long term we will have to address this problem anyway though. I'll reply to dprince on the list.08:34
hewbroccawell done gents08:35
*** regebro has joined #tripleo08:35
*** ifarkas has joined #tripleo08:36
gfidenteyeah I can see the ifs don't go well with the attempt to not put logic into .pp08:38
gfidenteand as hewbrocca said, we might have done that via heat08:38
gfidentebut we'd resort to passing a different .pp, like dprince is doing08:39
*** mcornea has joined #tripleo08:41
*** ifarkas has quit IRC08:42
*** ifarkas_ has joined #tripleo08:42
mariosjistr: thanks!08:48
*** shardy has joined #tripleo08:48
*** jcoufal_ has quit IRC08:55
*** jcoufal has joined #tripleo08:56
*** untriaged-bot has joined #tripleo09:00
untriaged-botUntriaged bugs so far:09:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/145240009:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985209:00
openstackLaunchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New]09:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985409:00
openstackLaunchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)09:00
*** untriaged-bot has quit IRC09:00
openstackLaunchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)09:00
*** yamahata has quit IRC09:01
*** athomas has quit IRC09:11
openstackgerritMerged openstack/python-tuskarclient: Drop use of 'oslo' namespace package  https://review.openstack.org/18071009:12
*** akrivoka has joined #tripleo09:14
openstackgerritMerged openstack/tuskar: Drop use of 'oslo' namespace package  https://review.openstack.org/18072109:14
*** derekh has joined #tripleo09:16
*** athomas has joined #tripleo09:17
*** pelix has joined #tripleo09:26
*** akrivoka has quit IRC09:27
openstackgerritMerged openstack/diskimage-builder: Support arch-specific package-installs  https://review.openstack.org/17656009:29
*** nijaba has quit IRC09:36
openstackgerritMerged openstack-infra/tripleo-ci: Add heat-config-script to our Puppet CI jobs.  https://review.openstack.org/17415109:38
*** rlandy has joined #tripleo09:47
*** akrivoka has joined #tripleo09:56
*** lucasagomes_ has joined #tripleo10:00
*** lucasagomes has quit IRC10:02
*** nijaba has joined #tripleo10:04
*** nijaba has quit IRC10:04
*** nijaba has joined #tripleo10:04
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement list plans for the OpenStack client  https://review.openstack.org/17921610:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement create Plan for the OpenStack client  https://review.openstack.org/17921710:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement delete Plan for the OpenStack client  https://review.openstack.org/17921810:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement Update Plan for the OpenStack client  https://review.openstack.org/17921910:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement show Plan for the OpenStack client  https://review.openstack.org/17922010:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement Plan add Role for the OpenStack client  https://review.openstack.org/17922110:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement Plan remove Role for the OpenStack client  https://review.openstack.org/17922210:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement download Plan for the OpenStack client  https://review.openstack.org/17922310:07
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement list Roles for the OpenStack client  https://review.openstack.org/17921510:07
*** lucasagomes_ is now known as lucasagomes10:08
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add metering agent as neutron-server plugin  https://review.openstack.org/17937010:22
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent  https://review.openstack.org/18053510:22
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources  https://review.openstack.org/17874310:22
openstackgerritDougal Matthews proposed openstack/python-tuskarclient: Implement download Plan for the OpenStack client  https://review.openstack.org/17922310:25
gfidentemarios, there is a comment on 17874310:25
marioslooking10:26
mariosgfidente: thansk, yeah looks like rebase nit, sec10:26
*** thrash|g0ne is now known as thrash10:29
*** ifarkas_ has quit IRC10:29
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add metering agent as neutron-server plugin  https://review.openstack.org/17937010:32
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent  https://review.openstack.org/18053510:32
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources  https://review.openstack.org/17874310:32
*** mmagr is now known as mmagr|afk10:39
*** ifarkas has joined #tripleo10:52
*** adrianopetrich has quit IRC10:53
*** weshay has joined #tripleo10:57
*** akrivoka has quit IRC11:00
*** akrivoka has joined #tripleo11:03
*** rhallisey has joined #tripleo11:17
*** links has quit IRC11:31
*** mmagr|afk is now known as mmagr11:32
*** links has joined #tripleo11:32
*** jistr has left #tripleo11:51
*** jistr has joined #tripleo11:52
*** openstackgerrit has quit IRC11:52
*** openstackgerrit has joined #tripleo11:52
*** trown|outttypeww is now known as trown12:05
*** dmellado has quit IRC12:09
*** dmellado has joined #tripleo12:11
*** tzumainn_ has joined #tripleo12:12
*** morazi has joined #tripleo12:16
*** dprince has joined #tripleo12:16
openstackgerritMartin Mágr proposed openstack/tripleo-heat-templates: [resubmitted] Keystone domain for Heat  https://review.openstack.org/18056612:22
*** jayg|g0n3 is now known as jayg12:24
openstackgerritMerged openstack/python-tuskarclient: Implement list Roles for the OpenStack client  https://review.openstack.org/17921512:27
openstackgerritMerged openstack/python-tuskarclient: Implement list plans for the OpenStack client  https://review.openstack.org/17921612:29
openstackgerritMerged openstack/python-tuskarclient: Implement create Plan for the OpenStack client  https://review.openstack.org/17921712:29
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent  https://review.openstack.org/18053512:35
mariosgfidente: this fixes the config issue i was telling you about ^^12:42
openstackgerritMerged openstack/tripleo-incubator: Drop usage of keystoneclient  https://review.openstack.org/17671512:47
openstackgerritMerged openstack/tripleo-incubator: Don't install the keystone client cli  https://review.openstack.org/17671612:48
*** pdb_ has quit IRC12:49
*** pdb_ has joined #tripleo12:49
*** masco has quit IRC12:52
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add metering agent as neutron-server plugin  https://review.openstack.org/17937012:53
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Add neutron-lbaas as neutron-server plugin & neutron-lbaas-agent  https://review.openstack.org/18053512:53
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources  https://review.openstack.org/17874312:53
openstackgerritDan Prince proposed openstack/tripleo-incubator: Update puppet docs to set ROOT_DISK  https://review.openstack.org/17633712:54
*** gfidente has quit IRC12:55
*** gfidente has joined #tripleo12:55
openstackgerritDan Prince proposed openstack-infra/tripleo-ci: Add a ceph job  https://review.openstack.org/17629213:00
*** adrianopetrich has joined #tripleo13:01
gfidentedprince, left a comment on https://review.openstack.org/#/c/17629213:02
openstackgerritMerged openstack/tripleo-puppet-elements: Add neutron-metering-agent to overcloud controller node element  https://review.openstack.org/17936813:03
dprincegfidente: see my comment to derek which is in the same place you are commenting.13:04
dprincegfidente: I can remove the ComputeCount too but one thing I would really like to see us move away from is ENV variables in Devtest to set Heat parameters.13:05
dprincegfidente: like the L3 thing you just did for example!13:05
gfidentedprince, I agree with the idea13:06
dprincegfidente: At some point the ENV variables all became unwieldy and I'm trying to decouple devtest from them as much as possible.13:06
gfidentehow a cleanup change?13:06
dprincegfidente: probably okay to leave the SCALE variables in there...13:06
gfidenteso my attempt is at making things consistent13:07
gfidenteI am okay using the env file13:07
gfidentejust make it work one or the other way, without mixing things up13:07
dprincegfidente: right, well I would prefer not to continue adding variables for the sake of consistency. That is my point. I think we might have (or think of) better ways to do these things13:08
gfidentedprince, so current status of things is13:09
gfidentewe have one ENV for controllers13:09
*** yog__ has quit IRC13:10
gfidenteand we only enforce compute for the ceph job, in the custom yaml13:10
openstackgerritMerged openstack-infra/tripleo-ci: Enforce COMPUTESCALE to 1 for CI, except HA jobs  https://review.openstack.org/17337213:10
gfidentenah who merged that? :(13:10
gfidentedprince, I am lost I thought you would do the other way around13:11
dprincegfidente: like I said. I think variables for the SCALE counts are fine13:11
dprincegfidente: also anything devtest already supports is fair game13:11
dprincegfidente: but please, lets try to avoid adding more ENV variables to devtest that enable specific Heat parameter/functionality13:12
gfidentethe problem I had with L3 is they are conflicting13:12
dprincegfidente: it would been quite easy to add an ENABLE_PUPPET flag for example13:12
dprincegfidente: but I avoided it... and I'm actually quite happy with how things can be made more generic13:13
*** rhallisey has quit IRC13:13
openstackgerritDan Prince proposed openstack-infra/tripleo-ci: Add a ceph job  https://review.openstack.org/17629213:15
*** dasm is now known as dasm|afk13:17
*** david-lyle has quit IRC13:19
*** jprovazn has quit IRC13:20
*** yog__ has joined #tripleo13:22
*** yog__ has quit IRC13:23
*** openstackstatus has quit IRC13:25
openstackgerritMarios Andreou proposed openstack/tripleo-puppet-elements: Adds neutron-lbaas-package to overcloud-controller element packages  https://review.openstack.org/18053013:26
*** openstackstatus has joined #tripleo13:27
*** ChanServ sets mode: +v openstackstatus13:27
*** lblanchard has joined #tripleo13:27
mariosjistr: sorry to pester, can you reinstate your vote please (rebase) @ https://review.openstack.org/#/c/180530/2 (still waiting on jenkins), thanks very very much13:29
jistrmarios: haha sure thing :)13:30
mariosthanks :)13:30
openstackgerritMerged openstack/tripleo-puppet-elements: Adds neutron-lbaas-package to overcloud-controller element packages  https://review.openstack.org/18053013:35
*** yamahata has joined #tripleo13:37
*** chlong has joined #tripleo13:39
shardydprince: Hey, sorry I just -1'd a bunch of your network t-h-t patches13:53
shardydprince: I like the overall approach, but I'm looking for ways to simplify it13:53
*** links has quit IRC13:54
dprinceshardy: okay, so the main reason for splitting them out was really to accomodate custom settings via parameter_defaults:13:56
shardydprince: Ok, cool, let me do some experiments, Heat already has some support for overiding just specific resources via the resource_registry13:58
shardypotentially that may be a cleaner way to do it, if I can make it work with ResourceGroups13:58
*** SpamapS has quit IRC13:58
*** rhallisey has joined #tripleo13:58
shardyI'll try some stuff and try to catch you later13:58
dprinceshardy: cool. FWIW I was eyeing resource groups for provider networks (which won't be nearly as invasive as these)13:59
dprinceshardy: talk to you in a bit14:00
*** jprovazn has joined #tripleo14:01
*** mcornea_ has joined #tripleo14:01
*** mcornea has quit IRC14:03
*** sseago has left #tripleo14:04
openstackgerritMerged openstack/tripleo-image-elements: Fix path to neutron dsn.  https://review.openstack.org/17907714:08
openstackgerritMerged openstack/tripleo-image-elements: Revert "An element to force install Qemu 2.1.3-3 on F21"  https://review.openstack.org/17631014:09
*** mcornea_ has quit IRC14:12
*** jcoufal has quit IRC14:14
*** jrist has quit IRC14:14
*** regebro has quit IRC14:15
EmilienMdprince: looking at pacemaker refacto ( https://review.openstack.org/#/c/180833/2/puppet/manifests/overcloud_controller_pacemaker.pp,cm )14:20
EmilienMdprince: why do you include haproxy/keepalived on pacemaker node?14:20
EmilienMis it related to a specific architecture?14:20
dprinceEmilienM: It is a WIP, (an idea)14:20
EmilienMdprince: oh yeah I get it14:21
EmilienMI just wonder why haproxy on pacemaker node14:21
dprinceEmilienM: if people agree then I can update the patch to remove the conditionals, and we can also remove haproxy (or whatever) for pacemaker too14:21
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates: Adds neutron-server and agents as pacemaker resources  https://review.openstack.org/18101514:21
EmilienMdprince: so tell me if I'm wrong, but overcloud_controller_pacemaker is a fork of overcloud_controller, but with pacemaker support14:24
dprinceEmilienM: basically, yes14:25
dprinceEmilienM: because what was happening to overcloud_controller.pp was everything was getting wrapped in $enable_pacemaker conditionals14:25
EmilienMdprince: I used another approach in Spinal Stack, let me show you14:26
*** jrist has joined #tripleo14:26
*** jrist has joined #tripleo14:26
dprinceEmilienM: pretty much the same thing either way... just having separate files I think will be more maintainable (especially for the pacemaker version)14:26
EmilienMbecause I don't like both approaches actually (as far I understand it now)14:26
dprinceEmilienM: I'm open to suggestions. But as is pacemaker is pretty much trashing our manifest :(14:27
mariosdprince: hey man, just sent a review for that ^^^14:27
*** jcoufal has joined #tripleo14:27
*** masco has joined #tripleo14:29
dprincemarios: okay, thanks for pointing it out14:29
dprincemarios: I think this discussion is still ongoing. EmilienM has some thoughts to add14:30
EmilienMa sec14:30
mariosdprince: yeah sure, just showing what it looks like, (e.g. duplication)14:32
mariosdprince: and yes easy enough to do, if that is consensus14:32
dprincemarios: I don't think it looks too bad.14:33
EmilienMdprince: http://paste.openstack.org/show/Q9e54xUyzqBVYOpTy9QY/14:34
dprincemarios: for your patch do the resource chains belong in puppet-neutron though?14:34
mariosdprince: sure. it is kinda clean without the conditional. if we can live with it some duplication is the price14:34
zigohttps://bugs.launchpad.net/tuskar/+bug/145275214:34
openstackLaunchpad bug 1452752 in tuskar "keystone_authtoken section is wrong in default shipped tuskar.conf.sample" [Undecided,Confirmed]14:34
zigoQuite bad !14:34
zigoCould someone have a look into it?14:34
zigoThis has been fixed in both Cinder and Nova before the release, AFAIK.14:34
dprinceEmilienM: right, I think I saw the wrapper in puppet-openstack-cloud right?14:35
mariosdprince: how do you mean? the pcs resource service definitions?14:35
EmilienMdprince: yup Sir14:35
dprincemarios: all these lines: Service[$::neutron::params::server_service] -> Service[$::neutron::params::dhcp_agent_service]14:35
EmilienMdprince: that why I fought to use puppetlabs-corosync14:35
dprinceEmilienM: if we do the wrapper approach then everythign is using puppet-tripleo then right?14:35
mariosdprince: oh yeah, i just made these system independent, they were already in the overcloud_controller.yaml14:35
*** aufi is now known as aufi|afk14:36
mariosdprince: so you think we don't need to worry about the dependences?14:36
mariosdprince: i.e. let systemd do its thing? (so remove them?) haven't tried that14:36
dprincemarios: no, not right now. Just a minor thing I noticed. That maybe these belong in puppet-neutron somewhere14:37
mariosdprince: oh i see, yeah that makes sense14:37
dprinceEmilienM: Yeah, I think we are in a position of choosing the lesser of two "evils". The duplication of class include statements doesn't bother me that much however14:38
dprinceEmilienM: some of the other conversion code and stuff does bother me but I think it could get refactored over time14:38
*** masco has quit IRC14:40
* dprince back in a bit14:41
EmilienMdprince: I replied to your thread to let our community be involved14:42
*** radez_g0n3 is now known as radez14:45
*** mcornea has joined #tripleo14:50
openstackgerritMerged openstack/diskimage-builder: Fix $DIB_DEFAULT_INSTALLTYPE export statement  https://review.openstack.org/17950214:53
*** yamahata has quit IRC14:59
*** yamahata has joined #tripleo14:59
*** untriaged-bot has joined #tripleo15:00
untriaged-botUntriaged bugs so far:15:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/145240015:00
openstackLaunchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New]15:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985215:00
openstackLaunchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)15:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985415:00
untriaged-bothttps://bugs.launchpad.net/tuskar/+bug/145275215:00
*** untriaged-bot has quit IRC15:00
openstackLaunchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)15:00
openstackLaunchpad bug 1452752 in tuskar "keystone_authtoken section is wrong in default shipped tuskar.conf.sample" [Undecided,Confirmed]15:00
*** jcoufal has quit IRC15:02
*** mcornea has quit IRC15:06
*** CheKoLyN has joined #tripleo15:15
*** mcornea has joined #tripleo15:19
*** radez is now known as radez_g0n315:26
*** mcornea has quit IRC15:29
*** mcornea has joined #tripleo15:29
*** pblaho has quit IRC15:30
*** athomas has quit IRC15:32
*** killer_prince has quit IRC15:32
*** alop has joined #tripleo15:32
*** cody-somerville has joined #tripleo15:34
*** Marga_ has joined #tripleo15:35
*** sdake_ has joined #tripleo15:36
*** sdake_ has quit IRC15:36
*** sdake_ has joined #tripleo15:36
*** Marga_ has quit IRC15:36
*** Marga_ has joined #tripleo15:36
*** mmagr has quit IRC15:39
*** sdake_ has quit IRC15:42
*** sdake has quit IRC15:44
*** sdake has joined #tripleo15:44
*** morazi has quit IRC15:49
*** jehb has joined #tripleo15:49
*** morazi has joined #tripleo15:50
*** morazi has quit IRC15:57
*** morazi has joined #tripleo15:57
*** rhallisey has quit IRC16:00
*** rhallisey has joined #tripleo16:03
*** trown is now known as trown|lunch16:05
*** adrianopetrich has quit IRC16:06
*** MasterPiece has joined #tripleo16:12
*** mcornea has quit IRC16:15
*** SpamapS has joined #tripleo16:18
*** SpamapS has quit IRC16:18
*** SpamapS has joined #tripleo16:18
*** derekh has quit IRC16:19
Nggreghaynes: bleh, gertty chewed up the comments I put in a review on 155484, they should relate to lines 51 and 50, respectively16:21
greghaynesNg: heh, this smelled like a gertty gone wrong16:22
*** Marga_ has quit IRC16:24
openstackgerritgreghaynes proposed openstack/diskimage-builder: Support building ACIs  https://review.openstack.org/15548416:24
*** shakamunyi has quit IRC16:29
*** Marga_ has joined #tripleo16:31
*** lucasagomes has quit IRC16:33
openstackgerritJiri Stransky proposed openstack/tripleo-heat-templates: Add Cinder as a Pacemaker resource  https://review.openstack.org/18106716:34
greghaynesw00t https://review.openstack.org/#/c/174681/ passes16:36
greghaynesSpamapS: ^ needs re-review16:36
*** gfidente has quit IRC16:36
*** gfidente has joined #tripleo16:36
SpamapSgreghaynes: done16:40
*** hewbrocca has quit IRC16:45
greghaynes\O/16:45
*** aufi|afk is now known as aufi16:50
*** aufi has quit IRC16:50
*** eghobo has joined #tripleo16:51
openstackgerritJames Slagle proposed openstack/tripleo-puppet-elements: Add puppet-stack-config element  https://review.openstack.org/15337516:52
*** sdake_ has joined #tripleo16:52
*** adrianopetrich has joined #tripleo16:54
*** sdake has quit IRC16:56
*** Marga_ has quit IRC17:00
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates: Provide RabbitMQ clients with a list of servers instead of VIP  https://review.openstack.org/18108117:07
*** Goneri has quit IRC17:09
*** sdake has joined #tripleo17:13
*** yamahata has quit IRC17:14
*** eghobo_ has joined #tripleo17:15
*** eghobo has quit IRC17:16
*** jistr has quit IRC17:17
*** sdake_ has quit IRC17:17
*** radez_g0n3 is now known as radez17:24
*** Marga_ has joined #tripleo17:25
openstackgerritMerged openstack/diskimage-builder: package-installs: fix error case for Python 2.6  https://review.openstack.org/18056117:25
*** Marga_ has quit IRC17:30
*** Marga_ has joined #tripleo17:30
*** Marga_ has quit IRC17:31
*** pelix has quit IRC17:31
openstackgerritMerged openstack/python-tuskarclient: Correct plan-remove-role to handle return of delete correctly  https://review.openstack.org/17302617:35
*** Marga_ has joined #tripleo17:35
*** yamahata has joined #tripleo17:40
*** anteaya has quit IRC17:45
*** trown|lunch is now known as trown17:48
*** jistr has joined #tripleo17:49
*** derekh has joined #tripleo17:59
*** masco has joined #tripleo18:03
*** sdake has quit IRC18:08
*** sdake has joined #tripleo18:09
*** derekh has quit IRC18:18
*** penick has joined #tripleo18:25
openstackgerritDan Prince proposed openstack/tripleo-incubator: load-images: load images via YAML config file  https://review.openstack.org/17502818:29
openstackgerritDan Prince proposed openstack/tripleo-incubator: Wire in load-images  https://review.openstack.org/17552218:29
openstackgerritDan Prince proposed openstack/tripleo-incubator: Add diskimage-builder/bin to PATH.  https://review.openstack.org/17719818:29
openstackgerritDan Prince proposed openstack/tripleo-incubator: devtest_overcloud.sh: split out image building  https://review.openstack.org/17364518:29
*** Marga_ has quit IRC18:32
*** Marga_ has joined #tripleo18:36
*** masco has quit IRC18:40
*** penick has quit IRC18:41
*** penick has joined #tripleo18:41
*** sdake_ has joined #tripleo18:43
*** sdake has quit IRC18:47
openstackgerritDan Prince proposed openstack/tripleo-incubator: Add a puppet disk images YAML file  https://review.openstack.org/18111418:48
*** jistr has quit IRC18:51
openstackgerritDan Prince proposed openstack/tripleo-incubator: Add a puppet disk images YAML file  https://review.openstack.org/18111418:52
openstackgerritDan Prince proposed openstack-infra/tripleo-ci: puppet: use a single image for CI  https://review.openstack.org/17706018:54
dprinceslagle: Could you be more specific about what you would like me to change here https://review.openstack.org/#/c/173645/1118:58
dprinceslagle: I'm having a tough time getting everyone's comments accomodated apparently18:58
slagledprince: it's what i said in my earlier comment18:59
slagledprince: adding -c to the new images build script18:59
slaglepreviously there was a -c for the image building, now there wouldn't be18:59
dprinceslagle: That is a new script and there should be no expecation that a user has a -c option there.18:59
dprinceslagle: I'll add it mind you if you require it... but in a new patchset19:00
slaglei disagree19:00
dprinceslagle: shouldn't hold this (already quite large) patch up for such a trivial thing19:00
dprinceslagle: you have a preference for larger patches?19:00
slagleagain, i disagree on the principal that it is in fact an expectation19:00
dprinceslagle: fine, but you can't disagree that this is a new script19:00
dprinceslagle: not having the option (yet) breaks no-one19:01
dprinceslagle: the previous -c works as is....19:01
dprinceslagle: quite nicely I might add19:01
slagleon something that you label deprecated19:01
slagleand say "go use this new thing"19:01
slagleoh, and btw, which doesn't have -c19:01
slaglei'm probably overly sensitive to the user experience19:02
dprinceslagle: okay, I can add it. FWIW I was just really confused because of the inline comments on this review too. This is totally unrelated to what I was explaining to Guilio about not adding more ENV variables to devtest_overcloud.sh19:02
slaglein this specific patch, i know those 2 comments are unrelated. i don't think that i did related them in any way19:04
dprinceslagle: this patch series speeds up our CI BTW. I would have liked to have my tripleo-ci patch to do similar things in a month ago, sigh19:04
slaglei was commenting on your comment to giulio19:04
slagledprince: i know that19:05
dprinceslagle: well, I left a follow up... to the extent we agreed a while back not to add more of these types of variables19:05
dprinceslagle: I've got a few abandone branches that were trying to do similar things...19:06
dprinceslagle: just FYI19:06
slagledprince: i'm well aware, and i believe, at the time, it was to use optional arguments19:06
slaglewhich is why i said i thought maybe it was premature to say it was now to drive everything via the heat environment19:07
dprinceslagle: right, I'm not sure Guilio was aware though19:08
* bnemec needs to sit down and write the rationalize-ui spec so we're all on the same page about this stuff19:09
dprinceslagle: looking at the devtest landscape it is quite a mess, easy for someone to come in and say, it was done this way before so I can do it in a similar fashion. Just trying to help us raise the bare, that is all19:09
* bnemec has been saying that for about a year and a half19:09
slagledprince: yes, of course. you realize you're also making my argument about adding the -c, right?19:10
dprinceslagle: and I don't we need to drive *everything* this way. But most of the enable this or that parameters, yeah. I think I'd like all of those gone.19:10
dprinceSCALE... variables are probably fine19:10
slagleso, in a way, these 2 comments really are related19:10
slaglethe devtest landscape is a mess19:10
slaglewe need to raise the bar19:10
slaglenot have a lower bar for new scripts19:10
dprinceslagle: just feel like I'm being nit picked a bit here. Like I said I've been trying to land this idea (in one shape or another) for over a month now.19:11
dprinceslagle: not against -c. Just doesn't seem all that important19:12
dprinceslagle: but if it is a show stopper I'll add it :)19:12
slagledprince: i'm willing to admit it's borderline nit pick19:12
slagleupon reflection though, i do feel strongly enough though that it's user experience related, and that's what pushed me to the -119:13
dprinceslagle: I'm fixing it.19:13
slaglei'm certainly not blocking landing it w/o it.19:14
slaglei know things aren't likely to land with a -1 on there...but it's not blocked19:14
dprinceslagle: The puppet user experience IMO is quite a bit nicer w/ this: https://review.openstack.org/#/c/181114/2/doc/source/puppet.rst,cm19:14
* dprince is quite happy w/ how it is turning out19:15
slaglei like it as well19:16
openstackgerritDan Prince proposed openstack/tripleo-incubator: load-images: load images via YAML config file  https://review.openstack.org/17502819:23
openstackgerritDan Prince proposed openstack/tripleo-incubator: Add a puppet disk images YAML file  https://review.openstack.org/18111419:23
openstackgerritDan Prince proposed openstack/tripleo-incubator: Wire in load-images  https://review.openstack.org/17552219:23
openstackgerritDan Prince proposed openstack/tripleo-incubator: Add diskimage-builder/bin to PATH.  https://review.openstack.org/17719819:23
openstackgerritDan Prince proposed openstack/tripleo-incubator: devtest_overcloud.sh: split out image building  https://review.openstack.org/17364519:23
*** Marga_ has quit IRC19:28
*** akrivoka has quit IRC19:43
gfidentedprince, slagle oh so just that I can explain myself19:48
gfidenteI figured we had a few params which shouldn't go together19:48
gfidenteand sure we could explain that in some .rst19:49
gfidentebut I thought a case switch could work there19:50
*** yamahata has quit IRC19:50
gfidenteI think documenting the different env vars needed for some feature can turn useful to tuskar and the converged cli19:51
gfidentebut for the l3 specifically the problem is we really want to make sure one of the option which is enabled by default gets disabled when ha or dvr is used19:51
gfidenteso it is not just about documenting the needed params, we should probably set relocation to false by default as well19:52
gfidenteso one can document which params need to be enabled for any of the three scenarios, relocation, ha, dvr19:52
gfidentewithout risking any other of the options, enabled by default, is going to conflict with the selection19:53
gfidentemaybe the template param itself should be turned into a case, like the glance backend19:54
gfidentebut this goes back to deprecating the old elements-based implementation ...19:55
gfidente*documenting the different template params is useful, not documenting the different env vars19:56
*** lblanchard has quit IRC19:56
gfidenteso I did not see many other options19:57
slaglegfidente: yea, there isn't a great way to do it. i think the alternative would have been to use arguments to the script20:05
slaglebut you're absolutely right about driving things via the heat environment file...20:06
slaglehow do you know what to put in there? and do we need something to create that file?20:06
gfidenteso while for new things, like ceph, we can just document what are the needed params20:07
gfidentefor the l3 thing we needed to make sure another param, which is enabled by default, gets set to false20:07
gfidentemaybe we could have switched off the default in the template20:08
*** Slower has quit IRC20:09
*** Slower has joined #tripleo20:10
openstackgerritJan Provaznik proposed openstack/tripleo-common: Add package update support  https://review.openstack.org/17986220:17
openstackgerritJan Provaznik proposed openstack/tripleo-common: Scale out heat stack  https://review.openstack.org/17328320:17
openstackgerritJan Provaznik proposed openstack/tripleo-common: Add a step-through heat stack update module  https://review.openstack.org/17815020:17
dprincegfidente: So (once this settle down) I'd like to propose that we create an "environments" directory in the incubator to hold files like this: https://review.openstack.org/#/c/176292/4/toci_gate_test.sh,cm20:18
dprincegfidente: I could easily move the ceph file into the inbubator now if there is interest.20:19
dprincegfidente: The files are YAML... and can easily be documented.20:19
dprincegfidente: and adding one for all the L3 stuff wouldn't be to hard I think20:20
dprincegfidente: this was the idea behind OVERCLOUD_CUSTOM_HEAT_ENV at least20:22
dprincegfidente: and shardy suggested we even make that support multiple files too20:22
dprincewhich is a great idea I think20:22
*** Marga_ has joined #tripleo20:23
*** Marga_ has quit IRC20:23
*** Marga_ has joined #tripleo20:24
*** jayg is now known as jayg|g0n320:26
*** sdake_ has quit IRC20:29
gfidentedprince, yes that is nice20:31
gfidenteI was worried about failover option which has to be disabled when using either l3ha or l3dvr20:32
gfidentewe can add that into the environment file20:33
dprincegfidente: right, all easily commentable because they are YAML. Make it as verbose as you'd like20:33
gfidentemaybe we should just add some documentation into the devtest_overcloud script on how to use the environment files20:35
*** bnemec has quit IRC20:36
dprincegfidente: sure. I'm talking about adding a new directory to hold these things. Perhaps starting with this ceph CI job stuff.20:36
gfidenteas for the params, they still seem to have some advantage20:38
gfidenteyou can use l3ha and ceph20:38
gfidente*as per the ENV vats20:39
gfidenteI can see that can be sorted with multiple HEAT_ENV20:39
dprincegfidente: right, that is why I mentioned the option to source multiple files20:39
gfidenteso maybe we get there by steps20:39
gfidenteI think the conversation was useful20:39
gfidentewell, it was to me at least20:40
*** Marga_ has quit IRC20:41
*** Marga_ has joined #tripleo20:42
dprincegfidente: cool :)20:42
gfidentedprince, slagle so one more thing I am facing here: https://review.openstack.org/#/c/181081/20:42
gfidenteI tried to get the rabbit_node_ips formatted as an array20:43
gfidenteit DOES work ( that is hiera rabbit_node_ips returns an array )20:43
gfidentebut usage of %{hiera(rabbit_node_ips)} for nova::rabbit_hosts DOES NOT work20:43
gfidentebecause it does *string* interpolation20:43
dprincegfidente: I think we should make this pacemaker specific20:43
gfidenteso the value of nova::rabbit_host is going to be a string, even though it looks like an array20:44
gfidentewhile the value of rabbit_node_ips is an actual array20:44
gfidentedprince, this one is not related to pacemaker20:44
dprincegfidente: or, at least put some thought into what you are suggesting effects isolated networks.20:44
dprincegfidente: is it not pacemaker that perfers hostnames?20:44
gfidentenah the change is not about hostnames actually20:44
gfidenteit is for the rabbit clients to get the list of rabbit nodes instead of going via haproxy20:45
gfidentebut the problem I was pointing at is not about the change itself20:45
gfidentebut about how string interpolation works in hiera20:45
dprincegfidente: oh, where did I get hostname from!!! I will look at it20:45
dprincegfidente: could you leave a clear comment on the review with regards to your issue?20:46
gfidentedprince, yeah I was trying to use the YAML & and * notation20:46
gfidentewhich DOES work preserving the value type (array)20:46
gfidentebut only if both keys are in same .yaml20:46
gfidenteI will yes20:46
dprinceah, I see20:47
gfidenteso it sums up into: rabbit_node_ips is an array, but nova::rabbit_hosts is a string (because of interpolation)20:47
gfidentewhich makes puppet-nova to complain as rabbit_hosts is not an array20:47
dprincegfidente: we need better support in the Hiera element for arrays I think20:49
dprincegfidente: which may require re-writing it in python rather than bash20:49
dprincegfidente: in the meantime I think there is a way to carefully construct the string in heat to satisfy it... just need to mess w/ it a bit20:49
gfidentedprince, note that rabbit_node_ips is an array there, the heat manipulation does the job20:50
gfidenterabbit_node_ips can be consumed as an array from within the .pp20:50
gfidenteit is nova::rabbit_hosts which can't, due to return value of %P{20:51
gfidentesorry, of %{}20:51
*** bnemec has joined #tripleo20:51
* gfidente saw CI failing on the non-puppet job from a few hours now20:53
* gfidente leaving though because it is pretty late here20:54
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates: post-deploy hook for rhel registration  https://review.openstack.org/17206520:55
*** ifarkas has quit IRC20:57
*** Marga_ has quit IRC20:58
*** Marga_ has joined #tripleo20:58
*** untriaged-bot has joined #tripleo21:00
untriaged-botUntriaged bugs so far:21:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/145240021:00
openstackLaunchpad bug 1452400 in diskimage-builder "debian-minimal builds still busted, now on locale issues" [Undecided,New]21:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985221:00
openstackLaunchpad bug 1449852 in diskimage-builder "Buidling ramdisk with ironic-agent behind proxy fails" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)21:00
untriaged-bothttps://bugs.launchpad.net/diskimage-builder/+bug/144985421:00
openstackLaunchpad bug 1449854 in diskimage-builder "Ironic agent ramdisk built using disk-image-create fails with iscsi_ilo driver" [Undecided,In progress] - Assigned to Ramakrishnan G (rameshg87) (rameshg87)21:00
untriaged-bothttps://bugs.launchpad.net/tuskar/+bug/145275221:00
openstackLaunchpad bug 1452752 in tuskar "keystone_authtoken section is wrong in default shipped tuskar.conf.sample" [Undecided,Confirmed]21:00
*** untriaged-bot has quit IRC21:00
gfidenteI think the CI breakage is this http://logs.openstack.org/45/173645/13/check-tripleo/check-tripleo-ironic-overcloud-f20-nonha/6f8e051/logs/seed_logs/ironic-api.txt.gz21:07
*** sdake has joined #tripleo21:08
*** sdake_ has joined #tripleo21:11
*** sdake has quit IRC21:15
*** EmilienM is now known as EmilienM|afk21:16
openstackgerritDan Prince proposed openstack/tripleo-incubator: devtest_testenv.sh: support for multiple bridges  https://review.openstack.org/17788021:18
openstackgerritDan Prince proposed openstack/tripleo-incubator: Allow libvirt to assign PCI slots for us  https://review.openstack.org/18084121:18
openstackgerritDan Prince proposed openstack/tripleo-incubator: Allow configurable bridge names and clean all.  https://review.openstack.org/17787721:18
openstackgerritDan Prince proposed openstack/tripleo-incubator: configure-vm: allow multiple baremetal-interface's  https://review.openstack.org/17787621:18
openstackgerritDan Prince proposed openstack/tripleo-incubator: create-nodes: allow multiple bridge names  https://review.openstack.org/17787921:18
openstackgerritDan Prince proposed openstack/tripleo-incubator: setup-network: allow creation of multiple bridges  https://review.openstack.org/17787821:18
*** dprince has quit IRC21:20
*** weshay has quit IRC21:23
*** bnemec has quit IRC21:25
*** rhallisey has quit IRC21:27
*** jprovazn has quit IRC21:29
*** sdake_ is now known as sdake21:30
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add debian build test case  https://review.openstack.org/18116121:44
greghaynesadam_g: ^ you should like that one21:44
*** gfidente has quit IRC21:47
*** trown is now known as trown|outttypeww21:48
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add tests for building *-minimal images  https://review.openstack.org/18116221:49
*** Marga_ has quit IRC21:50
*** jpeeler has quit IRC21:50
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add debian build test case  https://review.openstack.org/18116121:51
*** rlandy has quit IRC21:54
*** sdake_ has joined #tripleo21:54
*** david-lyle has joined #tripleo21:56
*** sdake has quit IRC21:58
*** chlong has quit IRC21:59
*** shardy has quit IRC22:00
*** Marga_ has joined #tripleo22:08
*** sdake has joined #tripleo22:22
*** Marga_ has quit IRC22:25
*** sdake_ has quit IRC22:25
*** Marga_ has joined #tripleo22:26
*** eghobo_ has quit IRC22:27
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add smoketest for fedora  https://review.openstack.org/17804022:28
*** Marga_ has quit IRC22:29
*** Marga_ has joined #tripleo22:29
openstackgerritgreghaynes proposed openstack/diskimage-builder: Initial element tests  https://review.openstack.org/17468122:36
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add smoketest for fedora  https://review.openstack.org/17804022:37
*** david-lyle has quit IRC22:38
openstackgerritMerged openstack/diskimage-builder: Package ldlinux.c32 along with isolinux.bin if it exists  https://review.openstack.org/17853422:42
*** sdake has quit IRC22:51
*** sdake has joined #tripleo22:53
*** BadCub is now known as BadCub_Hiding22:55
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add debian build test case  https://review.openstack.org/18116122:56
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add debian build test case  https://review.openstack.org/18116122:59
openstackgerritgreghaynes proposed openstack/diskimage-builder: Add tests for building *-minimal images  https://review.openstack.org/18116223:04
*** CheKoLyN has quit IRC23:11
*** chlong has joined #tripleo23:24
*** Marga_ has quit IRC23:28
*** rhallisey has joined #tripleo23:34
*** Marga_ has joined #tripleo23:42
*** eghobo has joined #tripleo23:50

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!