| *** shivrao has quit IRC | 00:00 | |
| *** shadower has quit IRC | 00:23 | |
| *** shadower has joined #tripleo | 00:23 | |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Perform a booting test for our images https://review.openstack.org/204639 | 00:26 |
|---|---|---|
| *** alop has quit IRC | 00:27 | |
| *** rlandy has joined #tripleo | 00:32 | |
| *** gothicmindfood has quit IRC | 00:34 | |
| *** gothicmindfood has joined #tripleo | 00:35 | |
| *** Goneri has joined #tripleo | 00:37 | |
| openstackgerrit | Merged openstack/os-cloud-config: register-nodes: add support for node capabilites https://review.openstack.org/194136 | 00:48 |
| *** chlong has quit IRC | 00:52 | |
| *** dprince has joined #tripleo | 01:00 | |
| *** rlandy has quit IRC | 01:05 | |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: network validation to ping test each interface https://review.openstack.org/204781 | 01:08 |
| *** dprince has quit IRC | 01:21 | |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Rename -puppet.yaml templates. https://review.openstack.org/203452 | 01:31 |
| *** sthillma has quit IRC | 01:49 | |
| *** EmilienM|off is now known as EmilienM | 01:52 | |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add validation to ping the default gateway https://review.openstack.org/204806 | 01:53 |
| openstackgerrit | Emilien Macchi proposed openstack/tripleo-heat-templates: Puppet / Compute: allow to run Ephemeral only storage with RBD https://review.openstack.org/202206 | 02:09 |
| *** chlong has joined #tripleo | 02:11 | |
| *** shivrao has joined #tripleo | 02:11 | |
| *** yamahata has quit IRC | 02:27 | |
| *** rbrady has quit IRC | 02:42 | |
| *** sthillma has joined #tripleo | 02:48 | |
| *** yuanying has joined #tripleo | 02:49 | |
| *** sthillma_ has joined #tripleo | 02:51 | |
| *** sthillma has quit IRC | 02:53 | |
| *** sthillma_ is now known as sthillma | 02:53 | |
| *** rlandy has joined #tripleo | 03:10 | |
| *** Marga_ has quit IRC | 03:13 | |
| *** julim has quit IRC | 03:19 | |
| *** Goneri has quit IRC | 03:22 | |
| *** yuanying has quit IRC | 03:26 | |
| *** yuanying has joined #tripleo | 03:28 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/diskimage-builder: Updated from global requirements https://review.openstack.org/201852 | 03:28 |
| *** shivrao has quit IRC | 03:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-cloud-config: Updated from global requirements https://review.openstack.org/193997 | 03:32 |
| *** shivrao has joined #tripleo | 03:37 | |
| *** rlandy has quit IRC | 03:40 | |
| *** yuanying has quit IRC | 03:49 | |
| *** yuanying has joined #tripleo | 03:59 | |
| *** yuanying has quit IRC | 04:02 | |
| *** shivrao has quit IRC | 04:04 | |
| *** Nisha has joined #tripleo | 04:05 | |
| *** HenryG has quit IRC | 04:09 | |
| *** shivrao has joined #tripleo | 04:10 | |
| *** mordred has quit IRC | 04:11 | |
| *** HenryG has joined #tripleo | 04:12 | |
| *** shivrao has quit IRC | 04:21 | |
| *** mordred has joined #tripleo | 04:24 | |
| *** sthillma has quit IRC | 04:24 | |
| *** yamahata has joined #tripleo | 04:48 | |
| *** gfidente has joined #tripleo | 04:57 | |
| *** AzherKhan has joined #tripleo | 05:00 | |
| *** yuanying has joined #tripleo | 05:01 | |
| *** AK has joined #tripleo | 05:05 | |
| *** masco has joined #tripleo | 05:05 | |
| *** AzherKhan has quit IRC | 05:06 | |
| *** AK has quit IRC | 05:06 | |
| *** AzherKhan has joined #tripleo | 05:06 | |
| *** AzherKhan has quit IRC | 05:09 | |
| *** AzherKhan has joined #tripleo | 05:09 | |
| *** sthillma has joined #tripleo | 05:37 | |
| *** bvandenh has joined #tripleo | 05:39 | |
| *** yamahata has quit IRC | 06:03 | |
| *** yamahata has joined #tripleo | 06:16 | |
| *** ishant has joined #tripleo | 06:24 | |
| *** jprovazn has joined #tripleo | 06:31 | |
| *** ukalifon1 has joined #tripleo | 06:35 | |
| *** chlong has quit IRC | 06:49 | |
| *** pblaho has joined #tripleo | 07:00 | |
| *** bvandenh has quit IRC | 07:00 | |
| *** ifarkas has quit IRC | 07:04 | |
| *** jcoufal has joined #tripleo | 07:18 | |
| *** regebro has joined #tripleo | 07:23 | |
| *** ifarkas has joined #tripleo | 07:23 | |
| *** Marga_ has joined #tripleo | 07:27 | |
| *** dtantsur|afk is now known as dtantsur | 07:28 | |
| *** aufi has joined #tripleo | 07:37 | |
| *** subscope has quit IRC | 07:41 | |
| *** regebro has quit IRC | 07:50 | |
| *** regebro has joined #tripleo | 07:51 | |
| *** subscope has joined #tripleo | 07:55 | |
| *** Nisha has quit IRC | 07:55 | |
| *** yog__ has joined #tripleo | 07:56 | |
| *** jistr has joined #tripleo | 08:02 | |
| *** paramite|afk has joined #tripleo | 08:02 | |
| *** paramite|afk is now known as paramite | 08:04 | |
| *** mcornea has joined #tripleo | 08:05 | |
| *** Nisha has joined #tripleo | 08:05 | |
| *** sthillma has quit IRC | 08:07 | |
| *** subscope has quit IRC | 08:09 | |
| *** lucasagomes has joined #tripleo | 08:11 | |
| *** pino|work has joined #tripleo | 08:15 | |
| *** sthillma has joined #tripleo | 08:19 | |
| *** derekh has joined #tripleo | 08:25 | |
| *** subscope has joined #tripleo | 08:25 | |
| *** mcornea has quit IRC | 08:26 | |
| *** shardy_ has joined #tripleo | 08:31 | |
| *** shardy has quit IRC | 08:32 | |
| *** shardy_ has quit IRC | 08:36 | |
| *** shardy has joined #tripleo | 08:37 | |
| *** pelix has joined #tripleo | 08:42 | |
| *** bvandenh has joined #tripleo | 08:45 | |
| *** mcornea has joined #tripleo | 08:51 | |
| *** jprovazn has quit IRC | 09:01 | |
| *** regebro has quit IRC | 09:03 | |
| *** stendulker has joined #tripleo | 09:03 | |
| *** sthillma has quit IRC | 09:03 | |
| *** regebro has joined #tripleo | 09:04 | |
| *** aukhan has joined #tripleo | 09:18 | |
| *** AzherKhan has quit IRC | 09:21 | |
| paramite | shardy, Thanks Steven, I did not realize that tox is enforcing different rules than plain flake8 | 09:24 |
| paramite | shardy, anyway, what about MAX_RESPONSE_SIZE? Do you think it should be higher? | 09:25 |
| shardy | paramite: hi, yeah I normally find tox gives results that align well with the gate (unless the local venv is stale..) | 09:27 |
| *** bvandenh has quit IRC | 09:28 | |
| shardy | I'm not sure re MAX_RESPONSE_SIZE, the number chosen seems Ok, but I wondered about the rationale behind it | 09:28 |
| shardy | ultimately we have no way to know what outputs a template specifies, so it's hard to choose a hard-coded value | 09:29 |
| shardy | One way would be to look at all output keys and trim them all evenly, but we can do that later :) | 09:30 |
| paramite | ok | 09:31 |
| shardy | paramite: I think the patch looks OK now tho, I may write a test for the trim_response logic just to prove it's cutting as expected :) | 09:32 |
| *** sbelous has quit IRC | 09:36 | |
| *** paramite has quit IRC | 09:42 | |
| *** bvandenh has joined #tripleo | 09:42 | |
| *** sbelous has joined #tripleo | 09:43 | |
| *** paramite has joined #tripleo | 09:44 | |
| *** paramite has quit IRC | 09:49 | |
| openstackgerrit | Merged openstack/tripleo-heat-templates: Provide list of memcached servers to Nova https://review.openstack.org/202744 | 09:53 |
| *** gfidente has quit IRC | 09:59 | |
| *** gfidente has joined #tripleo | 10:01 | |
| *** athomas has quit IRC | 10:02 | |
| *** paramite has joined #tripleo | 10:03 | |
| *** aukhan has quit IRC | 10:05 | |
| *** regebro has quit IRC | 10:08 | |
| *** athomas has joined #tripleo | 10:10 | |
| *** jprovazn has joined #tripleo | 10:11 | |
| *** panda has quit IRC | 10:12 | |
| *** panda has joined #tripleo | 10:13 | |
| *** paramite has quit IRC | 10:14 | |
| *** paramite has joined #tripleo | 10:27 | |
| openstackgerrit | Giulio Fidente proposed openstack/tripleo-heat-templates: Use 'public' instead of 'nova' as default floating pool name https://review.openstack.org/204016 | 10:36 |
| gfidente | ^^ needed a rebase FWIW | 10:36 |
| *** Nisha has quit IRC | 10:40 | |
| *** rbrady has joined #tripleo | 10:48 | |
| *** AzherKhan has joined #tripleo | 10:56 | |
| *** AzherKhan has quit IRC | 11:00 | |
| *** chlong has joined #tripleo | 11:08 | |
| *** rhallisey has joined #tripleo | 11:16 | |
| *** paramite is now known as paramite|afk | 11:16 | |
| *** paramite|afk is now known as paramite | 11:18 | |
| *** pino|work has quit IRC | 11:22 | |
| *** lazy_prince has joined #tripleo | 11:30 | |
| *** daemontool_ has joined #tripleo | 11:36 | |
| *** daemontool_ has quit IRC | 11:36 | |
| *** daemontool_ has joined #tripleo | 11:37 | |
| *** pino|work has joined #tripleo | 11:41 | |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Perform a booting test for our images https://review.openstack.org/204639 | 11:43 |
| slagle | greghaynes: up early? | 11:47 |
| greghaynes | hah, dont be silly ;) | 11:48 |
| greghaynes | me and early dont mix | 11:48 |
| greghaynes | In spain at Europython | 11:48 |
| slagle | ah, very nice | 11:48 |
| *** trown|outttypeww is now known as trown | 11:55 | |
| openstackgerrit | Atsushi SAKAI proposed openstack/diskimage-builder: typos on the document https://review.openstack.org/204491 | 11:56 |
| *** akrivoka has joined #tripleo | 12:00 | |
| *** mcornea has quit IRC | 12:04 | |
| *** mcornea has joined #tripleo | 12:06 | |
| *** stendulker has quit IRC | 12:13 | |
| *** akrivoka has quit IRC | 12:23 | |
| *** dprince has joined #tripleo | 12:23 | |
| openstackgerrit | Saverio Proto proposed openstack/diskimage-builder: debian: properly configure interfaces https://review.openstack.org/205036 | 12:32 |
| *** thrash|g0ne is now known as thrash | 12:33 | |
| openstackgerrit | Saverio Proto proposed openstack/diskimage-builder: debian: properly configure interfaces https://review.openstack.org/205036 | 12:34 |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Perform a booting test for our images https://review.openstack.org/204639 | 12:38 |
| *** prad has joined #tripleo | 12:41 | |
| *** ishant has quit IRC | 12:44 | |
| dprince | jistr, gfidente: can we land this? https://review.openstack.org/#/c/195328/ | 12:45 |
| openstackgerrit | greghaynes proposed openstack/diskimage-builder: Perform a booting test for our images https://review.openstack.org/204639 | 12:47 |
| StevenK | greghaynes: Blah, I have a bunch of comments on ps 13 | 12:48 |
| greghaynes | StevenK: hah | 12:48 |
| greghaynes | StevenK: Its hitting a lot of distros so I kind of am having to test against jenkins | 12:48 |
| StevenK | greghaynes: Shall I post them anyway? | 12:48 |
| greghaynes | yea | 12:48 |
| greghaynes | im mostly just tweaking things to make it mostly work ATM, will refactor based on comments later | 12:49 |
| StevenK | Right, not voting because you're iterating quickly | 12:49 |
| jistr | dprince: ah yeah i've already reviewed that before, will re-review | 12:49 |
| openstackgerrit | Merged openstack/tripleo-heat-templates: Convert PublicVirtualIP to new port creation method https://review.openstack.org/195328 | 12:52 |
| greghaynes | slagle: Hey, since youre around - can I get a re +2 on https://review.openstack.org/#/c/198814/ and +A on https://review.openstack.org/#/c/198841/ so I can cut a 1.0 :) | 12:54 |
| *** jcoufal has quit IRC | 12:54 | |
| *** pblaho has quit IRC | 12:54 | |
| openstackgerrit | Saverio Proto proposed openstack/diskimage-builder: Debian: dont set always the hostname to debian https://review.openstack.org/205047 | 12:56 |
| *** bvandenh has quit IRC | 12:57 | |
| *** bvandenh has joined #tripleo | 12:59 | |
| *** rlandy has joined #tripleo | 12:59 | |
| *** paramite has quit IRC | 12:59 | |
| slagle | greghaynes: looking | 13:02 |
| *** Goneri has joined #tripleo | 13:06 | |
| openstackgerrit | Dan Prince proposed openstack/os-cloud-config: register-nodes: add iboot support for node updates https://review.openstack.org/194158 | 13:06 |
| *** weshay has quit IRC | 13:08 | |
| *** pino|work has quit IRC | 13:08 | |
| *** pino|work has joined #tripleo | 13:08 | |
| openstackgerrit | Merged openstack/os-cloud-config: register-nodes: add iboot support for node updates https://review.openstack.org/194158 | 13:15 |
| greghaynes | w00t, just need to fish for a +A on https://review.openstack.org/#/c/198814/ now... | 13:17 |
| greghaynes | SpamapS: ^ | 13:17 |
| StevenK | greghaynes: You're welcome. | 13:19 |
| *** rhefner has quit IRC | 13:20 | |
| *** rhefner has joined #tripleo | 13:20 | |
| *** julim has joined #tripleo | 13:21 | |
| *** weshay has joined #tripleo | 13:21 | |
| greghaynes | \O/ | 13:21 |
| *** julim has quit IRC | 13:22 | |
| *** julim has joined #tripleo | 13:23 | |
| *** jcoufal has joined #tripleo | 13:29 | |
| *** morazi has joined #tripleo | 13:33 | |
| *** lblanchard has joined #tripleo | 13:38 | |
| *** bvandenh has quit IRC | 13:42 | |
| *** shardy_ has joined #tripleo | 13:42 | |
| *** pbourke has quit IRC | 13:43 | |
| *** pbourke has joined #tripleo | 13:44 | |
| *** shardy has quit IRC | 13:44 | |
| *** masco has quit IRC | 13:47 | |
| *** shardy_ has quit IRC | 13:48 | |
| *** shardy has joined #tripleo | 13:48 | |
| shardy | jprovazn: Hey, FYI https://review.openstack.org/#/c/202694/ finally passed CI and is ready for +A I think | 13:50 |
| shardy | thanks for the reviews :) | 13:50 |
| jprovazn | shardy: ah, cool, done | 13:51 |
| openstackgerrit | Merged openstack/tripleo-heat-templates: Wire in hieradata overrides via ExtraConfig for ObjectStorage https://review.openstack.org/202694 | 13:51 |
| openstackgerrit | Merged openstack/tripleo-heat-templates: Wire in hieradata overrides via ExtraConfig for CephStorage https://review.openstack.org/202695 | 13:51 |
| jprovazn | shardy: congrats to CI lottery win ;) | 13:52 |
| shardy | jprovazn: thanks! | 13:52 |
| * shardy is feeling lucky today! :D | 13:52 | |
| jprovazn | hehe | 13:56 |
| *** bnemec has joined #tripleo | 13:59 | |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add validation to ping the default gateway https://review.openstack.org/204806 | 14:11 |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: network validation to ping test each interface https://review.openstack.org/204781 | 14:11 |
| *** rlandy has quit IRC | 14:12 | |
| *** rlandy has joined #tripleo | 14:13 | |
| *** panda has quit IRC | 14:13 | |
| *** panda has joined #tripleo | 14:13 | |
| openstackgerrit | Merged openstack/diskimage-builder: Document what our stable interfaces are https://review.openstack.org/198814 | 14:18 |
| *** penick has joined #tripleo | 14:29 | |
| *** penick has quit IRC | 14:30 | |
| dprince | shardy: can you give quick feedback on this approach: https://review.openstack.org/#/c/204781/ | 14:41 |
| shardy | dprince: sure | 14:42 |
| shardy | dprince: does it need to be done as a cluster (StructuredDeployments) config, vs a step performed inside the ResourceGroup (e.g after os-net-config has run)? | 14:45 |
| shardy | I'm thinking it might be cleaner to just pass PingTestIps in to each ResourceGroup? | 14:45 |
| shardy | The overall approach seems fine, although originally I thought we were going to build it into os-net-config so the config could be rolled back if it failed validation | 14:46 |
| dprince | shardy: so we could make the validation per resource, sure | 14:47 |
| dprince | shardy: given all-nodes data is top level I suppose an all-nodes validation made sense to be top level | 14:48 |
| hewbrocca | shadower: ^^^ | 14:48 |
| *** spredzy is now known as spredzy|afk | 14:48 | |
| dprince | shardy: with regards to using os-net-config for this, I think only the default gateway ping would be in scope for os-net-config to validate (and potentially rollback if it couldn't access it) | 14:49 |
| dprince | shardy: I guess a generic ping mechanism could be implemented in os-net-config but you'd have to pass those in | 14:49 |
| shardy | dprince: so to clarify, is the test to ping all other nodes in the cluster/group, or only the gateway? | 14:54 |
| shardy | I guess the allnodes top-level thing makes sense if the former | 14:54 |
| shardy | I'm just on the lookout for ways to avoid additional complexity in the top-level template, if it can reasonably be encapsulated elsewhere | 14:55 |
| dprince | shardy: this is to ensure that each network, on each node is working and has connectivity (ping test) back to the provided controller 0 network IP | 14:56 |
| dprince | shardy: we want to run this on each node | 14:56 |
| shardy | dprince: Ok, so it's probably can be handled, e.g in controller-puppet.yaml after os-net-config gets applied? | 14:57 |
| shardy | Then if the ResourceGroup completes, you know you have all nodes up with validated networking | 14:57 |
| dprince | shardy: controller 0's IP are what is pinged | 14:57 |
| dprince | shardy: but we actually want to run the ping from each node in the cluster | 14:57 |
| dprince | shardy: not just on controller 0 itself | 14:57 |
| shardy | dprince: aha, sorry I was missing that | 14:58 |
| * shardy needs another coffee | 14:58 | |
| shardy | Ok then, lgtm! :) | 14:58 |
| dprince | shardy: np, cool | 14:58 |
| dprince | shardy: the reason to use the controller as a starting point was because it is the only role that has an IP on every network | 14:59 |
| dprince | shardy: controller 0 is just as good as any controller, but we use 0 because we always require at least 1 | 14:59 |
| shadower | dprince, shardy: is there a way to capture stdout/stderr on those deployments and report it back to heat? | 15:00 |
| shadower | so we can see them in the deployments' attributes | 15:01 |
| shardy | dprince: it would be cool if we could rationalize the various "allnodes" configs in due course tho, e.g having one nested stack ControllerNodesDeployment config or something | 15:01 |
| *** morazi has quit IRC | 15:01 | |
| shardy | it's quite confusing having all the Bootstrap/Cluster/Allnodes individual deployments at the top level | 15:01 |
| dprince | shadower: I think so, we could add a top level Heat output to make it even easier | 15:02 |
| shardy | shadower: yes, it's returned by default by the heat-config hook | 15:02 |
| shardy | shadower: heat deployment-show <deployment id> | 15:02 |
| shadower | shardy: yeah I did that but the values are empty | 15:02 |
| shardy | shadower: it's also accessible in the template: | 15:02 |
| shardy | shadower: is the deployment CREATE_COMPLETE? | 15:02 |
| shadower | shardy: CREATE_FAILED | 15:02 |
| shadower | so we want to see the output to see why :-) | 15:03 |
| dprince | shardy: the output of this will clearly identify which network IP wasn't pingable | 15:04 |
| shardy | shadower: Ok, are you sure you have the heat-config-script hook installed in your image? | 15:04 |
| dprince | shardy: you can see it in os-collect-config log for example... | 15:04 |
| *** jprovazn has quit IRC | 15:04 | |
| shardy | shadower: if the hook ran the script and it failed, you should see the stderr in the deployment-show output, along with the status code | 15:04 |
| shadower | oh actually, I haven't tried deployment-show | 15:04 |
| shardy | so probably something isn't set up right | 15:04 |
| shadower | I did resource-show. ANd it's attributes were all null | 15:05 |
| shardy | shadower: resource-show doesn't have the values, there's a bz about it I raised | 15:05 |
| shadower | ok | 15:05 |
| shardy | actually, I thing ggilles raised it | 15:05 |
| shadower | shardy: I'm getting "Deployment not found: <uuid>". How do I get the id? | 15:06 |
| *** morazi has joined #tripleo | 15:06 | |
| shadower | I tried physical_resource_id from resource-ilst | 15:06 |
| shardy | shadower: do heat resource-list -n5 overcloud | grep Deployment | grep FAILED | 15:06 |
| shardy | then you need the SoftwareDeployment (singular) not the cluster SoftwareDeployments resource | 15:07 |
| shardy | it'll be called e.g "0" | 15:07 |
| shadower | ah | 15:07 |
| shadower | I was looking at the top-level cluster one | 15:07 |
| shardy | we renamed SoftwareDeployments to SoftwareDeploymentGroup for liberty because that name is confusing.. | 15:07 |
| shadower | okay, I see stdout now | 15:08 |
| shadower | thanks! | 15:08 |
| hewbrocca | sweet! | 15:08 |
| shardy | https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/controller-puppet.yaml#L1160 | 15:09 |
| shardy | shadower: you can also access it in the template if you need to ^^ | 15:09 |
| *** daemontool_ is now known as marzif_ | 15:10 | |
| shadower | cool | 15:10 |
| *** aufi has quit IRC | 15:14 | |
| *** david-lyle has joined #tripleo | 15:17 | |
| *** pradk has joined #tripleo | 15:23 | |
| openstackgerrit | Dan Prince proposed openstack/os-cloud-config: register-nodes: drop support for Nova baremetal https://review.openstack.org/194167 | 15:27 |
| *** marzif_ has quit IRC | 15:28 | |
| dprince | shardy: another quick one https://review.openstack.org/#/c/203814/ | 15:28 |
| dprince | shardy: collectively CI passes fine on that (looking at the last two runs...) | 15:29 |
| *** penick has joined #tripleo | 15:30 | |
| openstackgerrit | Merged openstack/os-cloud-config: register-nodes: drop support for Nova baremetal https://review.openstack.org/194167 | 15:31 |
| *** ifarkas has quit IRC | 15:32 | |
| shardy | dprince: I added some some comments to the validation patch, mostly minor suggestions | 15:36 |
| dprince | shardy: thanks. looking.... | 15:36 |
| dprince | shardy: so I specifically choose not to use inputs because they have to be configured on the SoftwareDeployments (and there are 6 of them) | 15:40 |
| shardy | dprince: yeah, I made a suggestion about moving all the Deployments into the nested stack which would avoid that | 15:41 |
| shardy | well, you still have to define them but you don't have the list_join on each | 15:41 |
| shardy | The -1 was really only for the stderr thing, the rest of the cosmetic stuff can be considered personal preference :) | 15:42 |
| dprince | shardy: Right, but that nested stack would still have to wire them up via all the deployments right? These ones: http://paste.openstack.org/show/404255/ | 15:42 |
| dprince | shardy: alternately it would be really nice to be able to use an array of collections for the deployments 'servers:' properties | 15:43 |
| *** mestery has joined #tripleo | 15:43 | |
| dprince | shardy: because then it could be this way: http://paste.openstack.org/show/404256/ | 15:44 |
| * dprince doesn't think that works already | 15:44 | |
| shardy | dprince: yeah I was thinking the same thing, well actually could we join the lists, but functionally the same | 15:44 |
| shardy | dprince: really servers should just consume a list, not a map | 15:45 |
| shardy | as it makes it impossible to use with anything other than a ResourceGroup of nested stacks | 15:45 |
| shardy | I'll look in to how we can make that more flexible | 15:46 |
| dprince | shardy: agree, I was griping about this very thing yesterday evening w/ Ryan and Ian | 15:46 |
| shardy | It's probably an easy fix, I noticed it a while ago trying to configure a ResourceGroup of OS::Nova::Server resources | 15:46 |
| shardy | which should be the most basic use-case but actually doesn't work | 15:47 |
| shardy | we'll probably have to add a server_list property due to the way the resource properties schema works | 15:48 |
| dprince | shardy: sure, this would make using inputs a lot more appealing | 15:48 |
| dprince | shardy: still, I do wonder if a parameter/inputs grouping mechanism has a place too | 15:49 |
| dprince | shardy: because creating the "group" of parameters and adding them to set of deployments that way is also useful | 15:49 |
| dprince | shardy: we've already got 'parameter_groups' but they don't do this... just ordering right? | 15:50 |
| shardy | dprince: you can probably remove the str_replace even if you don't want to use input_values: | 15:50 |
| shardy | https://github.com/openstack/heat-templates/blob/master/hot/software-config/elements/heat-config-script/install.d/hook-script.py#L52 | 15:50 |
| shardy | the environment is derived from inputs, not deployment input_values | 15:50 |
| shardy | so you can stick with the current pattern "hard coding" the config into the inputs properties if you like | 15:51 |
| *** dtantsur is now known as dtantsur|afk | 15:51 | |
| dprince | shardy: okay, you lost me there. patch diff? | 15:51 |
| shardy | https://review.openstack.org/#/c/204781/3/all-nodes-validation.yaml | 15:52 |
| shardy | dprince: I'm saying using inputs doesn't require they are specified on each deployment, AFAICS | 15:52 |
| shardy | that is the preferred pattern, but it's not required for the hook to provide the input as a variable to the script | 15:52 |
| dprince | shardy: hmmm. so where would I specify inputs then? | 15:53 |
| shardy | we can pass it as a default into the input | 15:53 |
| shardy | sec | 15:53 |
| dprince | shardy: I think it only works if they live on the deployments | 15:53 |
| shardy | http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Heat::SoftwareConfig-props | 15:53 |
| shardy | inputs is a list of maps, and he map can contain "default" with a value, as well as "name" | 15:54 |
| shardy | dprince: not a big deal, just pointing it out as a possible option - I've not tested that approach myself tbh | 15:55 |
| dprince | shardy: sure, much appreciated | 15:56 |
| shardy | dprince, derekh: so you're happy for https://review.openstack.org/#/c/203814/ to go in, given that the failing job seems unrelated and passed on the previous run? | 15:58 |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Rename context_selection to prevent coliding with Horizon https://review.openstack.org/205127 | 15:58 |
| dprince | shardy: I'm happy removing it. Just trying to clean house on old pins in the CI tests | 15:59 |
| shardy | dprince: k, done! | 15:59 |
| openstackgerrit | Merged openstack-infra/tripleo-ci: Drop pin to install old Fedora keepalived package https://review.openstack.org/203814 | 16:00 |
| dprince | shardy: I think we agreed that it is okay to send patches (safer ones at least) that collectively pass CI across a couple runs | 16:00 |
| derekh | shardy: yup | 16:00 |
| * derekh late to the party | 16:00 | |
| shardy | dprince: Ok cool, I normally recheck all-the-things until they pass, but that makes sense | 16:00 |
| dprince | shardy, derekh: thanks. Now I can abandone this too https://review.openstack.org/#/c/191536/ | 16:00 |
| *** jistr has quit IRC | 16:01 | |
| derekh | dprince: you probably could have abandoned that from the start | 16:01 |
| *** jcoufal has quit IRC | 16:01 | |
| dprince | derekh: sure, just my policy not to abandone things unless they are gone from CI ;) | 16:01 |
| dprince | derekh: my little reminder | 16:01 |
| derekh | dprince: fair enough | 16:02 |
| *** Slower has quit IRC | 16:18 | |
| *** shivrao has joined #tripleo | 16:20 | |
| *** yog__ has quit IRC | 16:22 | |
| *** jprovazn has joined #tripleo | 16:28 | |
| *** jprovazn has quit IRC | 16:31 | |
| *** jprovazn has joined #tripleo | 16:32 | |
| *** bvandenh has joined #tripleo | 16:33 | |
| *** Slower has joined #tripleo | 16:36 | |
| openstackgerrit | Lennart Regebro proposed openstack/python-tuskarclient: Replace assert_called_once() calls https://review.openstack.org/205152 | 16:41 |
| *** shivrao has quit IRC | 16:43 | |
| *** derekh has quit IRC | 16:46 | |
| *** dsneddon_biab is now known as dsneddon | 16:53 | |
| *** pino|work has quit IRC | 16:55 | |
| *** ukalifon1 has quit IRC | 17:02 | |
| *** trown is now known as trown|lunch | 17:03 | |
| *** lucasagomes has quit IRC | 17:07 | |
| *** pelix has quit IRC | 17:07 | |
| *** pelix has joined #tripleo | 17:08 | |
| *** alop has joined #tripleo | 17:09 | |
| *** rwsu has quit IRC | 17:11 | |
| *** rwsu has joined #tripleo | 17:12 | |
| *** regebro has joined #tripleo | 17:16 | |
| *** yamahata has quit IRC | 17:25 | |
| *** Slower has quit IRC | 17:34 | |
| dprince | shardy: just to make sure. You like this better then http://paste.openstack.org/show/404438/ | 17:40 |
| dprince | shardy: using input defaults, getting rid of str_replace | 17:41 |
| dprince | shardy: a bit more verbose but the interface is more clear cut | 17:41 |
| *** regebro has quit IRC | 17:42 | |
| *** regebro has joined #tripleo | 17:43 | |
| *** panda has quit IRC | 17:44 | |
| shardy | dprince: am I reading the diff wrong, doesn't the default need to go in the inputs block in all-nodes-validation.yaml? | 17:44 |
| *** panda has joined #tripleo | 17:44 | |
| dprince | shardy: I think it would work in either place. | 17:44 |
| dprince | shardy: reglardless, if I move it there... you like this better then? | 17:44 |
| shardy | Then the default references parameters passed in to the template | 17:45 |
| dprince | shardy: happy to make the changes... just wanted to confirm first | 17:45 |
| shardy | Sure, I think it's a bit cleaner, what do you think? | 17:45 |
| *** sthillma has joined #tripleo | 17:46 | |
| dprince | shardy: I'm good w/ it | 17:46 |
| shardy | You can still pass PingTestIps in if you like, then pass that via a default to an ip_list input with a default in all-nodes-validation.yaml | 17:47 |
| shardy | as written I'm not sure it'll work, because there's no "inputs" parameter in the nested stack, and it's not wired in to the SoftwareConfig | 17:48 |
| shardy | but +1 on the general idea :) | 17:48 |
| dprince | shardy: yep, got it. I believe we did this a while back in the controller template actuall | 17:48 |
| dprince | shardy: just had to job my memory on the idea of the default inputs thing | 17:49 |
| dprince | shardy: got it, I'll wire it up properly... | 17:49 |
| shardy | dprince: heh, me too, had to look at the docs! | 17:49 |
| *** yamahata has joined #tripleo | 17:49 | |
| *** trown|lunch is now known as trown | 17:51 | |
| *** bvandenh has quit IRC | 17:53 | |
| *** yamahata has quit IRC | 17:55 | |
| *** yamahata has joined #tripleo | 17:55 | |
| *** spzala has joined #tripleo | 17:56 | |
| *** shivrao has joined #tripleo | 18:01 | |
| *** regebro has quit IRC | 18:05 | |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Add validation to ping the default gateway https://review.openstack.org/204806 | 18:09 |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: network validation to ping test each interface https://review.openstack.org/204781 | 18:09 |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Set default external port to noop for puppet https://review.openstack.org/205206 | 18:09 |
| dprince | rhallisey, athomas, shadower: ^^^ | 18:10 |
| dprince | rhallisey, athomas, shadower: the 'Set default external port to noop for puppet' regression was from earlier today upstream and was why your local dev environments might have been failing with the latest validation patch. In other words the validation helped catch this upstream regression | 18:11 |
| rhallisey | oh interesting | 18:11 |
| dprince | dsneddon: https://review.openstack.org/205206 | 18:11 |
| dprince | dsneddon: a regression from a patch we merged this morning. Can you review? | 18:11 |
| dprince | rhallisey: note that I didn't hit it locally because w/ network isolation the external port wasn't being masked as a VIP | 18:12 |
| rhallisey | neat | 18:12 |
| *** Slower has joined #tripleo | 18:22 | |
| *** Slower has quit IRC | 18:22 | |
| *** Slower has joined #tripleo | 18:22 | |
| gfidente | dprince, dsneddon I think the intent there was to have two IPs on the ctlplane when not using network-isolation | 18:25 |
| gfidente | one as internal vip and the other as public vip | 18:25 |
| dprince | gfidente: we already have that | 18:25 |
| dprince | gfidente: it has always been that way in fact, one VIP and one ctlplane IP | 18:25 |
| dprince | gfidente: and even if we need more VIPs or whatever this isn't the way to get it | 18:27 |
| gfidente | so the change from dsneddon was setting public vip to ExternalPort | 18:31 |
| gfidente | I know when running with network-isolation they are on different ports | 18:31 |
| gfidente | but when not running with network-isolation | 18:31 |
| gfidente | if ExternalPort points to noop | 18:31 |
| gfidente | it doesn't allocate it | 18:31 |
| dsneddon | gfidente, The ctlplane_vip.yaml will put an additional VIP on the ctlplane. The redis VIP uses that. | 18:32 |
| gfidente | dsneddon, yes that is what I am saying about https://review.openstack.org/#/c/205206/1 | 18:33 |
| *** lazy_prince has quit IRC | 18:36 | |
| openstackgerrit | Merged openstack/puppet-tripleo: Implement firewalling in tripleo::firewall https://review.openstack.org/202027 | 18:37 |
| *** jprovazn has quit IRC | 18:38 | |
| *** bvandenh has joined #tripleo | 18:43 | |
| *** leanderthal has quit IRC | 18:48 | |
| *** bitblt has joined #tripleo | 18:55 | |
| *** bitblt has quit IRC | 18:58 | |
| *** bvandenh has quit IRC | 19:02 | |
| *** gfidente has quit IRC | 19:29 | |
| openstackgerrit | Abel Lopez proposed openstack/diskimage-builder: Set and export DIB_RELEASE https://review.openstack.org/205252 | 19:29 |
| *** bvandenh has joined #tripleo | 19:30 | |
| *** hewbrocca has quit IRC | 19:32 | |
| *** bvandenh has quit IRC | 19:37 | |
| *** athomas has quit IRC | 19:43 | |
| *** lblanchard has quit IRC | 20:04 | |
| *** Goneri has quit IRC | 20:08 | |
| *** Goneri has joined #tripleo | 20:09 | |
| openstackgerrit | Ben Nemec proposed openstack-infra/tripleo-ci: Test fix for ironic ephemeral drive problem https://review.openstack.org/205273 | 20:15 |
| *** bvandenh has joined #tripleo | 20:19 | |
| *** pelix has quit IRC | 20:19 | |
| *** Goneri has quit IRC | 20:21 | |
| openstackgerrit | Dan Prince proposed openstack/tripleo-heat-templates: Allow 'ctlplane' to be used within Net IP Maps https://review.openstack.org/205278 | 20:22 |
| *** Goneri has joined #tripleo | 20:22 | |
| *** rhallisey has quit IRC | 20:28 | |
| *** Goneri has quit IRC | 20:29 | |
| *** mcornea has quit IRC | 20:29 | |
| *** Goneri has joined #tripleo | 20:30 | |
| *** dprince has quit IRC | 20:32 | |
| *** prad has quit IRC | 20:37 | |
| *** pradk has quit IRC | 20:41 | |
| *** shardy has quit IRC | 20:54 | |
| *** trown is now known as trown|outttypeww | 21:08 | |
| *** penick has quit IRC | 21:15 | |
| *** mcornea has joined #tripleo | 21:24 | |
| *** julim has quit IRC | 21:25 | |
| *** pleia2 has quit IRC | 21:42 | |
| *** spzala has quit IRC | 21:43 | |
| *** panda has quit IRC | 21:44 | |
| *** panda has joined #tripleo | 21:44 | |
| *** mcornea has quit IRC | 22:07 | |
| *** pleia2 has joined #tripleo | 22:16 | |
| *** bnemec has quit IRC | 22:18 | |
| openstackgerrit | Emilien Macchi proposed openstack/tripleo-heat-templates: Implement Advanced Firewalling support https://review.openstack.org/191195 | 22:34 |
| *** bvandenh has quit IRC | 22:37 | |
| *** CheKoLyN has joined #tripleo | 22:40 | |
| *** CheKoLyN has quit IRC | 22:40 | |
| *** morazi has quit IRC | 22:43 | |
| *** mcornea has joined #tripleo | 22:49 | |
| *** Goneri has quit IRC | 22:50 | |
| *** chlong has quit IRC | 22:52 | |
| *** david-lyle has quit IRC | 23:02 | |
| *** mcornea has quit IRC | 23:04 | |
| *** rlandy has quit IRC | 23:11 | |
| *** rlandy has joined #tripleo | 23:11 | |
| *** david-lyle has joined #tripleo | 23:36 | |
| *** rhefner has quit IRC | 23:40 | |
| *** dsneddon is now known as dsneddon_biab | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!