Friday, 2019-07-12

*** cdearborn has quit IRC00:10
cloudnullEmilienM so i'm really not sure why the build process is not failing, maybe there's some try/except block in an underlying caller?00:18
cloudnullwhen testing with oslo the lib is behaving correctly00:19
cloudnullhttps://pasted.tech/pastes/f4847e3b421455fbc6acc3804e6bfcb2691a5a1e00:19
cloudnulleven when testing with a valid Dockerfile, which has a `RUN false` in it, it builds then fails correctly - https://pasted.tech/pastes/c858e1f48f0e9ec56d814847da859f752394cc2000:19
cloudnullin both cases the exception ProcessExecutionError is raised via oslo00:20
cloudnullwhen using the client a proper exception should be raised here https://github.com/openstack/python-tripleoclient/blob/c6d441b24c2f367a6d95772a7d83e4f6fcd8caa0/tripleoclient/v1/container_image.py#L200-L23200:24
cloudnullthe only thing i can think is that - https://github.com/openstack/tripleo-common/blob/master/tripleo_common/image/builder/buildah.py#L164-L169 which is threading the build command is masking the return codes00:25
*** betherly has joined #tripleo00:26
*** betherly has quit IRC00:30
*** dmsimard4 is now known as dmsimard00:32
*** rcernin has quit IRC00:34
*** rcernin has joined #tripleo00:35
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-common master: Ensure we're raising proper exceptions  https://review.opendev.org/67040800:38
cloudnullmwhahaha weshay|rover EmilienM - https://review.opendev.org/#/c/670408 ok that should do it00:39
cloudnullthat will ensure our build process raises an exception when there's an erro r00:39
cloudnulland with that, im going to go uncloud for a while. talk to you all soon00:40
*** betherly has joined #tripleo00:46
*** panda has quit IRC00:48
*** panda has joined #tripleo00:50
*** betherly has quit IRC00:51
openstackgerritMerged openstack/puppet-tripleo stable/rocky: Support TLS deployments with KernelDisableIPv6 enabled  https://review.opendev.org/66990100:55
*** irclogbot_2 has joined #tripleo00:56
*** irclogbot_2 has quit IRC01:00
*** betherly has joined #tripleo01:06
*** betherly has quit IRC01:11
openstackgerritTakashi Kajinami proposed openstack/puppet-tripleo master: Enable service token in nova and cinder  https://review.opendev.org/67042401:17
openstackgerritTakashi Kajinami proposed openstack/tripleo-heat-templates master: Enable service token in nova and cinder  https://review.opendev.org/66674401:18
*** irclogbot_3 has joined #tripleo01:26
*** betherly has joined #tripleo01:27
*** betherly has quit IRC01:32
*** irclogbot_3 has quit IRC01:34
openstackgerritTakashi Kajinami proposed openstack/tripleo-heat-templates master: Enable service token in nova and cinder  https://review.opendev.org/66674401:38
*** dsneddon has quit IRC01:41
*** dsneddon has joined #tripleo01:41
*** dsneddon has quit IRC01:46
*** betherly has joined #tripleo01:48
*** mschuppert has quit IRC01:50
*** betherly has quit IRC01:53
*** apetrich has quit IRC01:58
*** dsneddon has joined #tripleo02:07
*** brault has joined #tripleo02:18
openstackgerritSteve Baker proposed openstack/tripleo-common master: Make instances name/hostname optional  https://review.opendev.org/66901902:19
openstackgerritSteve Baker proposed openstack/tripleo-common master: Changes to baremetal provision format  https://review.opendev.org/66977402:19
openstackgerritSteve Baker proposed openstack/tripleo-common master: Break out hostname format logic into functions  https://review.opendev.org/67043202:19
*** brault has quit IRC02:22
*** irclogbot_2 has joined #tripleo02:26
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-common master: Ensure we're raising proper exceptions  https://review.opendev.org/67040802:28
*** irclogbot_2 has quit IRC02:30
*** betherly has joined #tripleo02:39
openstackgerritMerged openstack/tripleo-common master: Remove the tripleo.plan_management.v1.download_logs workflow  https://review.opendev.org/66916102:41
openstackgerritMerged openstack/tripleo-common master: Remove the tripleo.plan_management.v1.publish_ui_logs_to_swiftworkflow  https://review.opendev.org/66916202:41
*** betherly has quit IRC02:44
*** vinaykns has quit IRC02:46
*** altlogbot_3 has joined #tripleo02:48
*** altlogbot_3 has quit IRC02:52
*** betherly has joined #tripleo03:00
*** betherly has quit IRC03:05
*** rlandy has quit IRC03:16
*** betherly has joined #tripleo03:20
*** irclogbot_3 has joined #tripleo03:22
*** dsneddon has quit IRC03:24
*** betherly has quit IRC03:25
*** irclogbot_3 has quit IRC03:26
*** betherly has joined #tripleo03:42
*** psachin has joined #tripleo03:45
*** betherly has quit IRC03:46
*** dsneddon has joined #tripleo03:47
*** irclogbot_0 has joined #tripleo03:52
EmilienMcloudnull: nicely done03:53
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: Remove service_names hieradata file  https://review.opendev.org/66942403:55
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: deploy-steps: remove unused hieradata_templates_list  https://review.opendev.org/66991703:55
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: Remove config_step hieradata  https://review.opendev.org/66992403:55
*** irclogbot_0 has quit IRC03:56
*** betherly has joined #tripleo04:02
*** ykarel|away has joined #tripleo04:02
*** dsneddon has quit IRC04:03
*** udesale has joined #tripleo04:05
*** betherly has quit IRC04:07
openstackgerrityatin proposed openstack/tripleo-common master: DNM: test tripleo-ansible  https://review.opendev.org/67027604:07
openstackgerritSteve Baker proposed openstack/tripleo-common master: Make instances name/hostname optional  https://review.opendev.org/66901904:10
openstackgerritSteve Baker proposed openstack/tripleo-common master: Changes to baremetal provision format  https://review.opendev.org/66977404:10
openstackgerritSteve Baker proposed openstack/tripleo-common master: Break out hostname format logic into functions  https://review.opendev.org/67043204:10
openstackgerritSteve Baker proposed openstack/tripleo-common master: Allow mixing of count and instances  https://review.opendev.org/67043704:10
*** betherly has joined #tripleo04:33
*** dsneddon has joined #tripleo04:34
*** betherly has quit IRC04:38
*** dsneddon has quit IRC04:39
*** ratailor has joined #tripleo04:52
*** poopcat has quit IRC04:52
*** zbitter has quit IRC04:53
*** zbitter has joined #tripleo04:53
*** rcernin has quit IRC04:54
*** ykarel|away has quit IRC04:59
*** irclogbot_1 has joined #tripleo05:00
*** dsneddon has joined #tripleo05:03
*** pdeore has joined #tripleo05:04
*** dsneddon has quit IRC05:07
*** pcaruana has joined #tripleo05:13
*** betherly has joined #tripleo05:14
*** jistr has quit IRC05:15
*** irclogbot_1 has quit IRC05:16
*** jistr has joined #tripleo05:18
*** betherly has quit IRC05:19
*** ykarel|away has joined #tripleo05:24
*** ykarel|away is now known as ykarel05:25
*** holser_ has joined #tripleo05:32
*** ratailor_ has joined #tripleo05:33
*** ratailor has quit IRC05:35
Tenguhello there05:36
*** holser_ has quit IRC05:36
*** pdeore has quit IRC05:39
*** dsneddon has joined #tripleo05:40
ykarelo/05:40
* Tengu reading the latest CIX for rocky promotion05:41
*** yprokule has joined #tripleo05:43
*** dsneddon has quit IRC05:45
*** mburned is now known as mburned_out05:45
*** aedc has quit IRC05:47
*** mburned_out is now known as mburned05:48
*** ratailor_ has quit IRC05:48
Tenguhmmm.... that's not very nice: http://logs.openstack.org/54/670254/2/check/tripleo-ci-centos-7-scenario010-standalone/2c44a77/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2019-07-11_19_33_1905:49
Tengutranscient, or.. ?05:49
openstackgerritChandan Kumar (raukadah) proposed openstack/tripleo-ci master: Move tripleo-ci-centos-7-containers-multinode to os_tempest  https://review.opendev.org/66739005:49
*** zaneb has joined #tripleo05:51
*** ratailor has joined #tripleo05:51
ykarelwith that error it doesn't look transcient05:52
*** zbitter has quit IRC05:53
Tenguykarel: :/05:53
Tenguguess we're good for some new CIX, for Network/Octavia then05:53
Tengulemme create an LP.05:53
*** jbadiapa has quit IRC05:55
Tenguykarel: would that be a promotion blocker?05:56
ykarelTengu, i can see good amount of SUCCESS http://zuul.openstack.org/builds?job_name=tripleo-ci-centos-7-scenario010-standalone recently05:56
ykarelseems it's fixed05:57
ykareli see two failures though05:57
Tengulet's do a recheck05:57
Tenguykarel: 9h ago for the failing job. maybe it was fixed in the meanwhile.05:57
ykarelTengu, yes05:57
TenguI keep the LP open, ready to submit.05:57
Tengu#coffee05:58
*** marios has joined #tripleo05:59
ykarelTengu, so https://review.opendev.org/#/c/667247/ and https://review.opendev.org/#/c/665256/06:00
ykarel^^ both changes needed together to work, so possibly failing job had only one of them06:00
*** skramaja has joined #tripleo06:00
openstackgerritRajesh Tailor proposed openstack/tripleo-puppet-elements stable/queens: Stop and disable libvirtd service on controller  https://review.opendev.org/67044806:05
Tenguykarel: ok! let's see with the recheck06:05
ykarelyes recheck will work06:06
*** betherly has joined #tripleo06:06
openstackgerritMerged openstack/tripleo-heat-templates stable/rocky: Rocky: enable container auth support  https://review.opendev.org/67034906:09
*** altlogbot_2 has joined #tripleo06:10
*** betherly has quit IRC06:11
*** dsneddon has joined #tripleo06:12
*** altlogbot_2 has quit IRC06:14
*** dsneddon has quit IRC06:17
*** amoralej|off is now known as amoralej06:18
*** dsneddon has joined #tripleo06:22
*** jtomasek has joined #tripleo06:25
*** Goneri has joined #tripleo06:25
*** dsneddon has quit IRC06:27
*** mschuppert has joined #tripleo06:27
*** irclogbot_1 has joined #tripleo06:36
*** betherly has joined #tripleo06:37
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-heat-templates stable/rocky: Allow logrotate to access container_file_t files  https://review.opendev.org/67045106:37
Tengudamn... forget the -x -.-06:38
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-heat-templates stable/rocky: Allow logrotate to access container_file_t files  https://review.opendev.org/67045106:38
*** irclogbot_1 has quit IRC06:40
*** betherly has quit IRC06:42
*** saneax has joined #tripleo06:53
*** aedc has joined #tripleo06:58
*** yprokule has quit IRC07:02
*** yprokule has joined #tripleo07:02
*** holser_ has joined #tripleo07:02
*** dsneddon has joined #tripleo07:02
*** dsneddon has quit IRC07:07
*** holser_ has quit IRC07:12
*** holser_ has joined #tripleo07:13
*** jpich has joined #tripleo07:17
*** Goneri has quit IRC07:17
*** Goneri has joined #tripleo07:18
*** rpittau|afk is now known as rpittau07:18
openstackgerritmathieu bultel proposed openstack/python-tripleoclient master: Make mistral optional for Ansible Update and Upgrade  https://review.opendev.org/67029507:18
*** tosky has joined #tripleo07:19
openstackgerritmathieu bultel proposed openstack/python-tripleoclient master: DNM CI test  https://review.opendev.org/67031407:21
*** jbadiapa has joined #tripleo07:22
*** bogdando has joined #tripleo07:24
*** jbadiapa has quit IRC07:27
*** iurygregory has joined #tripleo07:30
*** dsneddon has joined #tripleo07:35
*** xek has joined #tripleo07:36
*** florianf has joined #tripleo07:37
*** dsneddon has quit IRC07:40
*** slaweq has joined #tripleo07:41
*** lucasagomes has joined #tripleo07:43
*** mcornea has joined #tripleo07:47
*** aedc has quit IRC07:48
*** shyamb has joined #tripleo07:49
*** dsneddon has joined #tripleo07:50
openstackgerritTakashi Kajinami proposed openstack/puppet-tripleo master: Enable service token in nova and cinder  https://review.opendev.org/67042407:51
*** aedc has joined #tripleo07:54
*** dsneddon has quit IRC07:54
*** bhagyashris has joined #tripleo07:57
*** ccamacho has joined #tripleo07:59
*** ykarel is now known as ykarel|lunch07:59
*** shyamb has quit IRC07:59
*** altlogbot_2 has joined #tripleo08:03
*** altlogbot_2 has quit IRC08:04
*** yolanda has quit IRC08:08
*** yolanda has joined #tripleo08:09
openstackgerritBogdan Dobrelya (bogdando) proposed openstack/tripleo-heat-templates master: Fix generating Apache configs by container-puppet  https://review.opendev.org/66917808:10
Tenguarxcruz|ruck: heya! can you tell me if https://bugs.launchpad.net/tripleo/+bug/1835718 is sorted out so that we can move the CIX card to "done" ?08:12
openstackLaunchpad bug 1835718 in tripleo "Rocky promotion jobs fail on undercloud install" [Critical,Triaged] - Assigned to Alex Schultz (alex-schultz)08:12
Tenguthe patch merged, so it should be fine08:12
*** altlogbot_0 has joined #tripleo08:12
*** gkadam has joined #tripleo08:15
*** altlogbot_0 has quit IRC08:16
*** gkadam has quit IRC08:17
*** altlogbot_0 has joined #tripleo08:18
*** tkajinam has quit IRC08:19
*** altlogbot_0 has quit IRC08:22
*** dsneddon has joined #tripleo08:24
*** altlogbot_0 has joined #tripleo08:24
*** pkopec has joined #tripleo08:27
*** dsneddon has quit IRC08:28
*** altlogbot_0 has quit IRC08:29
*** derekh has joined #tripleo08:32
*** rascasoft has quit IRC08:33
*** rascasoft has joined #tripleo08:34
*** bogdando has quit IRC08:40
openstackgerritMarios Andreou proposed openstack/tripleo-ci master: Rename tripleo-ci build-images to oooci-build-images for clash  https://review.opendev.org/66988808:43
*** bogdando has joined #tripleo08:43
*** shyamb has joined #tripleo08:46
*** aedc has quit IRC08:48
*** ykarel|lunch is now known as ykarel08:48
openstackgerritMarios Andreou proposed openstack/tripleo-ci master: Tidy up tripleo-standalone-scenarios-full template with anchors  https://review.opendev.org/66301808:51
*** rascasoft has quit IRC08:55
*** rascasoft has joined #tripleo08:58
openstackgerritMarios Andreou proposed openstack/tripleo-ci master: Add new scenario007-standalone job definition & add to check  https://review.opendev.org/63149708:58
*** betherly has joined #tripleo09:00
*** irclogbot_1 has joined #tripleo09:00
*** dsneddon has joined #tripleo09:03
*** irclogbot_1 has quit IRC09:04
*** betherly has quit IRC09:05
*** dsneddon has quit IRC09:08
*** Goneri has quit IRC09:14
arxcruz|ruckTengu, i don't have the results yet, i'll update as soon as I get okay? :)09:15
openstackgerritCarlos Camacho proposed openstack/tripleo-heat-templates stable/stein: Clean docker and podman after executing an update or upgrade  https://review.opendev.org/67047809:16
Tenguarxcruz|ruck: ;_; ok... hoped to get rid of the spam-bot :/09:16
mariosreviews please https://review.opendev.org/#/c/669329/ & https://review.opendev.org/#/c/670290/ needed by https://review.rdoproject.org/r/#/c/21357/ rdo rhel 8 image build https://tree.taiga.io/project/tripleo-ci-board/task/1151 thank you!09:19
*** Goneri has joined #tripleo09:27
*** Goneri has quit IRC09:39
*** ratailor_ has joined #tripleo09:40
*** dsneddon has joined #tripleo09:42
*** ratailor has quit IRC09:43
*** dsneddon has quit IRC09:47
*** dmacpher has quit IRC09:48
*** dmacpher has joined #tripleo09:48
*** dmacpher has quit IRC09:49
*** dmacpher has joined #tripleo09:49
openstackgerritFrancesco Pantano proposed openstack/tripleo-heat-templates master: Add dashboard component as new ceph composable service.  https://review.opendev.org/66657809:58
ykarelmarios, adding ironic in standalone 007 was intentional?09:59
ykarelhttps://review.opendev.org/#/c/631496/17/ci/environments/scenario007-standalone.yaml10:00
mariosykarel: its been a while but i took what we had in scen7 multinode and copied over ... let me check10:00
ykarelack, but multinode one don't have ironic10:01
ykareland i don't think it was there ever, but good to check10:01
mariosykarel: ack checking10:01
ykarelack10:02
mariosykarel: thanks adding comment. this review was started a long time ago and there was/still is some issue with neutron sidecar containers that beagles was looking at at some point10:03
mariosykarel: so i haven't been focusing on it for a while/other things have priority. i missed that ironic not sure where it came from10:04
ykarelmarios, ack, good to revise it as per multinode- 007 file, that will help it move forward10:04
mariosykarel: earlier versions didn't have that so not sure (eg https://review.opendev.org/#/c/631496/4/ci/environments/scenario007-standalone.yaml10:04
mariosykarel: not sure where/why i added that10:05
ykarel^^ was for ovn10:05
ykarelmay be u took scenario012 as reference10:05
*** shyamb has quit IRC10:05
openstackgerritSergii Golovatiuk proposed openstack/tripleo-heat-templates master: Refactor docker stop on upgrade tasks  https://review.opendev.org/67048410:06
mariosykarel: ah so thats why10:06
mariosykarel: see comments on v8/9 apr 3 from folco and me10:06
* ykarel looks10:06
ykarelmarios, okk, u compared undercloud containers with standalone :(10:09
ykarelshould have compared overcloud ones10:09
openstackgerritMartin Schuppert proposed openstack/tripleo-common master: Create <service> _cell_node_names if nova_additional_cell  https://review.opendev.org/67048610:09
mariosykarel: :D /me facepalm10:10
mariosykarel: in my defence folco started it :D10:10
ykarel:)10:10
mariosrfolco: ^^10:10
openstackgerritMartin Schuppert proposed openstack/tripleo-heat-templates master: Set nova_additional_cell as global_vars  https://review.opendev.org/67048710:10
mariosykarel: ok will try and look at that again today and fixup those containers10:11
mariosykarel: thank you!10:11
ykarelmarios, ack10:11
mariosykarel: pasted irc into the review fyi10:12
ykarelack10:12
*** dsneddon has joined #tripleo10:17
*** dsneddon has quit IRC10:21
*** ratailor_ has quit IRC10:23
*** ratailor has joined #tripleo10:24
*** bogdando has quit IRC10:27
*** holser_ is now known as holser|lunch10:28
*** avivgta has joined #tripleo10:30
*** yolanda has quit IRC10:31
*** yolanda has joined #tripleo10:32
*** irclogbot_3 has joined #tripleo10:32
openstackgerritMarios Andreou proposed openstack/tripleo-heat-templates master: Add scenario007-standalone environment file  https://review.opendev.org/63149610:36
mariosykarel: thanks when you next have time ^ i rechecked on the ci patch lets see10:37
ykarelmarios, ack /me looks10:38
*** irclogbot_3 has quit IRC10:38
ykarelmarios, looks better10:38
mariosykarel: yeah we have to wait for the job i restricted it so it will only run that one10:39
*** shyamb has joined #tripleo10:40
openstackgerritChandan Kumar (raukadah) proposed openstack/tripleo-common master: Remove pika from container builds  https://review.opendev.org/67039810:40
mariossimple rename if someone has time please thanks https://review.opendev.org/#/c/669888/10:43
openstackgerritMerged openstack/tripleo-common master: Added support of overcloud os_cloud  https://review.opendev.org/66456810:43
*** bhagyashris has quit IRC10:43
*** irclogbot_1 has joined #tripleo10:43
*** irclogbot_1 has quit IRC10:44
*** Goneri has joined #tripleo10:53
*** dsneddon has joined #tripleo10:53
*** dsneddon has quit IRC10:58
*** altlogbot_3 has joined #tripleo11:04
*** shyam89 has joined #tripleo11:08
*** altlogbot_3 has quit IRC11:08
*** shyamb has quit IRC11:08
*** tesseract has joined #tripleo11:08
*** marios has quit IRC11:09
*** altlogbot_2 has joined #tripleo11:14
*** dsneddon has joined #tripleo11:15
*** altlogbot_2 has quit IRC11:16
*** bogdando has joined #tripleo11:17
openstackgerritSlawek Kaplonski proposed openstack/tripleo-quickstart-extras master: WIP Add playbook and role to run tobiko  https://review.opendev.org/65542311:19
openstackgerritCarlos Camacho proposed openstack/tripleo-heat-templates master: Stop services for unupgraded controllers  https://review.opendev.org/66909511:26
*** avivgta has quit IRC11:26
openstackgerritBrent Eagles proposed openstack/tripleo-quickstart master: Add support for running tempest against Octavia featuresets  https://review.opendev.org/66966611:29
openstackgerritBrent Eagles proposed openstack/tripleo-quickstart master: Add support for running tempest against Octavia featuresets  https://review.opendev.org/66966611:31
openstackgerritCarlos Camacho proposed openstack/tripleo-heat-templates stable/stein: Stop services for unupgraded controllers  https://review.opendev.org/66962811:32
openstackgerritCarlos Camacho proposed openstack/tripleo-heat-templates master: Stop services for unupgraded controllers  https://review.opendev.org/66909511:36
openstackgerritMartin Schuppert proposed openstack/tripleo-heat-templates master: Set nova_additional_cell as global_vars  https://review.opendev.org/67048711:36
*** dtrainor has quit IRC11:37
*** dtrainor has joined #tripleo11:37
*** apetrich has joined #tripleo11:38
openstackgerritMartin Schuppert proposed openstack/tripleo-heat-templates master: Set nova_additional_cell as global_vars  https://review.opendev.org/67048711:39
*** shyam89 has quit IRC11:39
openstackgerritMartin Schuppert proposed openstack/tripleo-common master: Create <service> _cell_node_names if nova_additional_cell  https://review.opendev.org/67048611:39
openstackgerritMartin Mágr proposed openstack/tripleo-heat-templates master: Rsyslog composable service  https://review.opendev.org/62433011:42
*** paramite has joined #tripleo11:44
paramitepanda, we still seem to have rsyslog image issues: http://logs.openstack.org/30/624330/11/check/tripleo-ci-centos-7-scenario002-standalone/59ac239/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz#_2019-07-08_22_01_5511:45
paramitepanda, any idea why https://review.opendev.org/#/c/624325 was not merged?11:45
paramiteEmilienM, maybe you will know ^11:46
EmilienMparamite: probably was in a gate reset or something11:47
EmilienMI did recheck and it'll land today11:47
paramiteEmilienM, thanks a lot!11:48
*** shyam89 has joined #tripleo11:48
pandayeah a recheck should fix it. Also I mistakenly added a +1W11:48
pandaI was sure I put just a +1CR there ... probably a mistyping in gertty11:48
paramitepanda, I thought that it was on purpose :)11:49
pandaparamite: well, I told you I was giving a +1, but I meat a +1 in core review, not in workflow, which actually gives the green flag to merge ..11:49
pandathat was a mistake :(11:50
*** holser|lunch is now known as holser_11:50
*** saneax has quit IRC11:52
*** aedc has joined #tripleo11:54
*** udesale has quit IRC11:59
*** udesale has joined #tripleo12:00
*** marios has joined #tripleo12:10
*** morazi has joined #tripleo12:16
*** Goneri has quit IRC12:21
*** derekh has quit IRC12:26
*** aedc has quit IRC12:27
*** dsneddon has quit IRC12:28
*** Goneri has joined #tripleo12:29
*** mcornea has quit IRC12:29
*** ekultails has joined #tripleo12:30
openstackgerritGael Chamoulaud proposed openstack/python-tripleoclient master: Add --parameters and --create-vars-file arguments to the list subcommand  https://review.opendev.org/67035212:31
EmilienMykarel: please check with cloudnull when he's online, maybe file a bug if you can12:31
*** afazekas_ has joined #tripleo12:31
ykarelEmilienM, ack, was there already bug against it? i see there was revert12:32
ykarelhmm found https://bugs.launchpad.net/tripleo/+bug/183565712:32
openstackLaunchpad bug 1835657 in tripleo "tripleo-ci-centos-7-standalone-upgrade-stein is broken by container registry login task" [Critical,Fix released] - Assigned to Kevin Carter (kevin-carter)12:32
mariossimple rename if someone has time please thanks https://review.opendev.org/#/c/669888/12:32
ykarelEmilienM, i think same bug can be reused12:33
EmilienMok12:34
ykarelas issue is same12:34
ykarelack12:34
*** afazekas_ is now known as afazekas12:34
*** amoralej is now known as amoralej|lunch12:35
openstackgerritSlawek Kaplonski proposed openstack/tripleo-quickstart-extras master: WIP Add playbook and role to run tobiko  https://review.opendev.org/65542312:37
*** rlandy has joined #tripleo12:37
*** skramaja has quit IRC12:39
openstackgerritSagi Shnaidman proposed openstack/tripleo-heat-templates master: DNM: login-defs in 004 standalone  https://review.opendev.org/67003412:40
*** paramite has quit IRC12:41
*** paramite has joined #tripleo12:42
mwhahahahow are we not reproducing this in ci?12:44
openstackgerritLuke Short proposed openstack/tripleo-ansible master: Import the tripleo-persist role from tripleo-common.  https://review.opendev.org/67036212:49
marioseasy one tidy up files: for scen-standalone 1-4 https://review.opendev.org/#/c/663018/ if you have time please thanks12:53
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: WIP generate addition drop-in dependencies for podman containers  https://review.opendev.org/66991012:56
*** dsneddon has joined #tripleo12:58
*** aedc has joined #tripleo13:00
*** dsneddon has quit IRC13:03
*** paramite has quit IRC13:03
*** raildo has joined #tripleo13:03
ykarelmarios, so scenario007 moved forward, and failed at os_tempest https://opendev.org/openstack/tripleo-quickstart-extras/src/branch/master/playbooks/tempest.yml#L3213:04
ykareli would say good to go without os_tempest at first stage13:05
*** derekh has joined #tripleo13:06
mariosykarel: ack thanks I will try and look again on monday see if we can get this merged... sounds like the neutron issue was fixed13:06
mariosykarel: thank you for making me look at that today!13:06
openstackgerritGael Chamoulaud proposed openstack/python-tripleoclient master: Add --parameters and --create-vars-file arguments to the list subcommand  https://review.opendev.org/67035213:06
ykarelmarios, yes, it's better now, i also commented on template file, there is one extra entry in that13:07
ykarelrelated to ironic13:07
ykarelso once u get change update that also13:07
mariosykarel: ack will check thanks (might do it after a call in a bit otherwise monday)13:07
ykarelack, np13:07
*** aedc has quit IRC13:12
openstackgerritGael Chamoulaud proposed openstack/python-tripleoclient master: Add --parameters and --create-vars-file arguments to the list subcommand  https://review.opendev.org/67035213:13
*** amoralej|lunch is now known as amoralej13:19
openstackgerritDavid Peacock proposed openstack/python-tripleoclient master: WIP - Implement tripleo container image show command  https://review.opendev.org/66798813:26
openstackgerritRonelle Landy proposed openstack/tripleo-ci master: Add roles/playbooks copy in setup.cfg  https://review.opendev.org/67055113:28
openstackgerritBrent Eagles proposed openstack/tripleo-quickstart master: Add support for running tempest against Octavia featuresets  https://review.opendev.org/66966613:30
*** sshnaidm|off has quit IRC13:30
*** florianf_ has joined #tripleo13:31
*** shyam89 has quit IRC13:33
openstackgerritGael Chamoulaud proposed openstack/python-tripleoclient master: Add --parameters and --create-vars-file arguments to the list subcommand  https://review.opendev.org/67035213:33
*** florianf has quit IRC13:34
*** sshnaidm has joined #tripleo13:35
*** sshnaidm is now known as sshnaidm|off13:36
*** dsneddon has joined #tripleo13:36
*** florianf_ has quit IRC13:37
*** irclogbot_0 has joined #tripleo13:38
*** irclogbot_0 has quit IRC13:38
openstackgerritSergii Golovatiuk proposed openstack/tripleo-heat-templates stable/stein: Upgrade fixes for RabbitMQ and Pacemaker  https://review.opendev.org/67055513:40
*** dsneddon has quit IRC13:41
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-common master: Correct how we fetch External and InternalApi networks name  https://review.opendev.org/67055713:41
*** florianf has joined #tripleo13:42
openstackgerritSergii Golovatiuk proposed openstack/tripleo-heat-templates stable/stein: Upgrade fixes for RabbitMQ and Pacemaker  https://review.opendev.org/67055513:44
openstackgerritRonelle Landy proposed openstack/tripleo-ci master: Add roles/playbooks copy in setup.cfg  https://review.opendev.org/67055113:45
*** paramite has joined #tripleo13:49
*** sabedevops has joined #tripleo13:51
openstackgerritRonelle Landy proposed openstack/tripleo-quickstart master: Add tripleo-ci to the extra-requirements  https://review.opendev.org/67056313:52
mariosreviews please https://review.opendev.org/#/c/669329/ & https://review.opendev.org/#/c/670290/ needed by https://review.rdoproject.org/r/#/c/21357/ rdo rhel 8 image build https://tree.taiga.io/project/tripleo-ci-board/task/1151 thank you!13:54
*** ykarel is now known as ykarel|afk13:54
*** aakarsh has quit IRC13:56
*** Vorrtex has joined #tripleo13:56
*** ykarel|afk has quit IRC13:59
cloudnullmornings14:03
slagleekultails: hey, what's the difference between molecule/default and molecule/legacy_vars? i guess both need to be updated the same way?14:04
slaglelooks like CI is using legacy_vars. but when I run molecule locally, default is used14:04
*** vinaykns has joined #tripleo14:05
ekultailsslagle: The first level of directories below molecule are the different scenarios.14:07
ekultailsBased on what needs to be tested, there may be one or more scenarios.14:07
ekultailsBy default, the "default" scenario will run.14:07
ekultailsYou can run `molecule test --all` to run the mall or `molecule test --scenario legacy_vars` to cover only the other scenario.14:08
*** dsneddon has joined #tripleo14:08
slagleekultails: ok, that makes sense. but why do we need both if the contents are identical?14:08
ekultailsrun them all* not run the mall. Sorry, I've been watching Strangers Things 3. ;-)14:09
ekultailsHmm, if they really are exactly the same then it sounds like we can get ride of the legacy_vars.14:09
ekultailsAnd just keep the default scenario.14:10
slaglethey're the same, at least for the role i'm currently working on (tripleo-ssh-known-hosts)14:10
slaglei'll try just rm'ing legacy_vars, see if CI is happy with that :)14:10
*** irclogbot_2 has joined #tripleo14:10
ekultailscloudnull: Do you know why there is a legacy_vars scenario? Looks to be used in a handful of roles.14:12
cloudnullyes its testing using non-namespaced variables14:13
cloudnullslagle the ci tests all of the scenarios. if you wanted to run them all you can do so with `molecule test --all`14:13
cloudnullyou could also run just that one scenario with `molecule test -s $NAME`14:14
*** chandankumar is now known as raukadah14:14
cloudnullwe also  have some tools to mimic what zuul is doing - https://docs.openstack.org/tripleo-ansible/latest/contributing.html#local-testing-of-new-roles14:14
cloudnullif you are running things in a clean vm14:14
*** altlogbot_0 has joined #tripleo14:15
*** dsneddon has quit IRC14:15
ekultailsNamespaced variables meaning, for example, being prefixed with tripleo_ssh_known_hosts?14:15
cloudnullyes, instead of ssh_known_hosts14:15
cloudnullas an example14:16
* cloudnull has no idea if that was a var 14:16
ekultailsCool, thanks for the clarification.14:16
cloudnullhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-container-tag/defaults/main.yml#L22-L3114:16
cloudnullis a good example14:16
openstackgerritFrancesco Pantano proposed openstack/tripleo-heat-templates master: Add dashboard component as new ceph composable service.  https://review.opendev.org/66657814:17
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: tripleo-hieradata: merge j2 hiera templates  https://review.opendev.org/66991614:17
ekultailsYeah, back in Consulting I ran into a lot of customer use cases that had very generic and conflicting names lol. Namespaces/prefixes are definitely the way to go.14:18
ekultails++14:18
cloudnull++14:18
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: tripleo-hieradata: include config_step into all_nodes_merged  https://review.opendev.org/66992114:18
*** ykarel|afk has joined #tripleo14:24
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: Remove the tripleo.plan_management.v1.list_sample_plans workflow  https://review.opendev.org/66916314:24
*** aakarsh has joined #tripleo14:25
EmilienMabishop: thank you for the reply on cinder/netapp14:27
slaglecloudnull: ok. so since i plan to remove the usage of the non-namespaced var, i can also remove all of legacy_vars14:27
*** jcoufal has joined #tripleo14:27
cloudnull+114:27
cloudnullI just added tests so we'd catch that usage due to us having both non-namespaced and namespaced vars when we did the role import14:28
cloudnullbut if we dont need that anymore, remove it :)14:28
* cloudnull is always happy to delete things :D14:28
openstackgerritJames Slagle proposed openstack/tripleo-ansible master: Remove non-template mode from tripleo-ssh-known-hosts role  https://review.opendev.org/66996614:28
abishopEmilienM: sure, thank you for your first one!14:29
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates stable/rocky: Revert "Revert "Set proper setype for service directories""  https://review.opendev.org/64425814:31
*** bnemec is now known as beekneemech14:34
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates stable/rocky: Revert "Revert "docker: wire SELinuxMode with Ansible vars""  https://review.opendev.org/64425714:35
slaglecloudnull: ekultails : out of curiosity, is there any effort for podman support in molecule?14:38
cloudnullI think zbr just got that added ?14:39
openstackgerritFrancesco Pantano proposed openstack/tripleo-heat-templates master: Add dashboard component as new ceph composable service.  https://review.opendev.org/66657814:39
slagleyea? cool14:39
* cloudnull would like to switch to that instead of docker if at all possible. 14:39
cloudnullthough I've not actually given it a spin yet14:39
cloudnullhttps://github.com/ansible/molecule/pull/209814:40
*** hoonetorg has quit IRC14:40
cloudnullsorry sshnaidm|off made the initial commit14:40
cloudnullbut, yes, it lookslike its in ?14:40
cloudnullmaybe just not in a released branch14:40
zbrcloudnull: yep sshnaidm|off added it but its is experimental, is is on master.14:40
cloudnullslagle ^14:41
zbrbut we do not run CI on it and i doubt is usable in jobs.14:41
slagleok, i may give it a try locally14:41
cloudnull++ I'd be keen on switching our jobs around to run podman instead of docker14:42
zbri would also be very unhappy to see it activated in jobs because it will prevent me from running molecule locally. my desktop is a mac, and I do run molecule very well now with docker.14:42
zbrno remoting support in podman at all (docker has good DOCKER_HOST=ssh://), also other problems. More likely to start using libvirt or openstack driver than podman driver.14:44
*** dsneddon has joined #tripleo14:47
openstackgerritAlex Schultz proposed openstack/tripleo-common master: Set container=oci for our containers  https://review.opendev.org/67057414:49
*** Goneri has quit IRC14:52
*** rpittau is now known as elfosardo14:52
openstackgerritHarald Jensås proposed openstack/python-tripleoclient master: Ensure files are closed, ensure no ResourceWarning on console  https://review.opendev.org/67057614:54
*** hoonetorg has joined #tripleo14:56
*** dsneddon has quit IRC14:57
*** Goneri has joined #tripleo14:57
*** ratailor has quit IRC14:58
*** ayoung has quit IRC15:12
*** ayoung has joined #tripleo15:12
*** Goneri has quit IRC15:15
*** ykarel|afk is now known as ykarel|away15:16
openstackgerritMerged openstack/tripleo-ci master: Rename tripleo-ci build-images to oooci-build-images for clash  https://review.opendev.org/66988815:18
*** sabedevops has quit IRC15:19
*** amoralej is now known as amoralej|off15:19
*** ansmith has quit IRC15:23
*** dsneddon has joined #tripleo15:27
*** iurygregory is now known as skolt15:27
openstackgerritSlawek Kaplonski proposed openstack/tripleo-quickstart-extras master: WIP Add playbook and role to run tobiko  https://review.opendev.org/65542315:27
*** holser_ has quit IRC15:30
*** jcoufal has quit IRC15:34
*** yprokule has quit IRC15:35
*** morazi_ has joined #tripleo15:35
*** morazi has quit IRC15:36
*** marios is now known as marios|out15:39
openstackgerritGael Chamoulaud proposed openstack/python-tripleoclient master: Add --parameters and --create-vars-file arguments to the list subcommand  https://review.opendev.org/67035215:40
*** ayoung has quit IRC15:44
*** jcoufal has joined #tripleo15:45
openstackgerritHarald Jensås proposed openstack/python-tripleoclient master: Ensure files are closed, ensure no ResourceWarning on console  https://review.opendev.org/67057615:45
*** marios|out has quit IRC15:46
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: Correct how we fetch External and InternalApi networks name  https://review.opendev.org/67055715:47
*** lucasagomes has quit IRC15:47
*** nkinder has joined #tripleo15:47
EmilienMdamn15:47
*** ayoung has joined #tripleo15:48
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: Correct how we fetch External and InternalApi networks name  https://review.opendev.org/67055715:48
cloudnullEmilienM mwhahaha weshay|rover when you get a chance - https://review.opendev.org/#/c/670408/ - could use some review .15:48
cloudnullregarding our image build tools not raising an exception15:49
EmilienMcloudnull: please update unit testds15:49
cloudnullwill do15:49
*** bcafarel has quit IRC15:50
cloudnulldoesn't look like build_all has a unit test15:51
* cloudnull will go make one15:51
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: tripleo-hieradata: merge j2 hiera templates  https://review.opendev.org/66991615:51
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: tripleo-hieradata: merge j2 hiera templates  https://review.opendev.org/66991615:52
EmilienMslagle: this log confused me for the bootstrap_nodeid thing: http://logs.openstack.org/17/669917/10/check/tripleo-ci-centos-7-undercloud-containers/d47c1e4/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2019-07-12_04_36_3815:52
openstackgerritEmilien Macchi proposed openstack/tripleo-common master: tripleo-hieradata: include config_step into all_nodes_merged  https://review.opendev.org/66992115:53
slagleEmilienM: i can tell you why15:54
slagleEmilienM: bootstrap_nodeid comes from this file: http://logs.openstack.org/17/669917/10/check/tripleo-ci-centos-7-undercloud-containers/d47c1e4/logs/undercloud/home/zuul/undercloud-ansible-yf2YcF/Undercloud/hieradata_vars.yaml.txt.gz15:55
slagleEmilienM: you can see where i pass that in with vars_files on the "Hieradata from vars" task15:55
slagleEmilienM: however, since you moved bootstrap_nodeid to the "render all_nodes" tasks, the var is undefined there15:55
weshay|roverEmilienM I'll ask rfolco to include that patch in our manual test15:56
weshay|roverrfolco https://review.opendev.org/#/c/670408/4/tripleo_common/image/builder/buildah.py15:56
weshay|roverwe may need to rebase that patch on top of some other tripleo-common patches to test it15:56
weshay|rovercloudnull EmilienM is that ok?15:57
slagleEmilienM: i would actually like to get rid of the "render all_nodes data as group_vars..." tasks. we'd just need to find all the other tasks that are using those vars. i think there's just a few15:57
* weshay|rover looks at which ones15:57
EmilienMslagle: ok, let me look that15:57
*** ykarel|away has quit IRC15:57
*** ansmith has joined #tripleo15:57
weshay|roverhttps://review.opendev.org/#/c/670398/ that one15:57
cloudnullweshay|rover feel free to rebase / change / modify anything I ever work on.15:57
weshay|roverthanks15:58
weshay|roverrfolco you seeing this?15:58
slagleEmilienM: the other thing we could do is move what's in hieradata_vars.yaml to be group vars, then we wouldn't need to use the vars_files15:58
weshay|roverrfolco multiple patches in tripleo-common :)15:58
slagleEmilienM: i had originally thought it might be a lot of data, and I didn't want to set all that as host/group vars. but it turned out to be pretty small15:59
EmilienMslagle: yes, let's do that and if it becomes too big we can still roll-back...15:59
slagleb/c anything you set as a host var persists in memory for that host for the whole playbook run15:59
EmilienMright15:59
slagleok, i can look at that15:59
openstackgerritMerged openstack/tripleo-puppet-elements stable/queens: Stop and disable libvirtd service on controller  https://review.opendev.org/67044815:59
openstackgerritMerged openstack/tripleo-heat-templates stable/rocky: Allow logrotate to access container_file_t files  https://review.opendev.org/67045116:00
EmilienMcool thanks16:00
EmilienMweshay|rover: yes, if you want to test out the errors it's the patch to use16:00
* EmilienM lunch16:00
rfolcoweshay|rover, ok will apply both patches in tripleo-common16:00
*** adrianreza_ has joined #tripleo16:01
*** jpich has quit IRC16:01
*** ykarel|away has joined #tripleo16:09
*** pkopec has quit IRC16:10
*** sabedevops has joined #tripleo16:13
*** Vorrtex has quit IRC16:13
openstackgerritMerged openstack/tripleo-common master: Remove pika from container builds  https://review.opendev.org/67039816:17
weshay|roverrfolco fyi.. https://review.opendev.org/#/c/670398/ just merged16:23
*** hjensas is now known as hjensas|afk16:24
*** elfosardo is now known as rpittau|afk16:27
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates master: Set HieradataVars as group vars instead  https://review.opendev.org/67059616:30
slagleEmilienM: ^16:30
slagleonly light testing done so far :) my deploy is still in progress16:31
openstackgerritBrent Eagles proposed openstack/tripleo-heat-templates master: Configure amphora for upload and run tempest  https://review.opendev.org/66966916:35
*** bogdando has quit IRC16:42
ykarel|awaycloudnull, can u please check https://bugs.launchpad.net/tripleo/+bug/183565716:46
openstackLaunchpad bug 1835657 in tripleo "tripleo-ci-centos-7-standalone-upgrade-stein is broken by container registry login task" [Critical,Fix released] - Assigned to Kevin Carter (kevin-carter)16:46
ykarel|awaymay be u already on it16:46
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-common master: Ensure we're raising proper exceptions  https://review.opendev.org/67040816:47
cloudnullEmilienM ^16:47
*** derekh has quit IRC16:48
cloudnullykarel|away I've been looking at that, and sadly I've not been able to recreate the error. though I've found a couple suspect things I've love to chat more about. I'll post them in the LP issue so folks can think about it asynchronously16:49
ykarel|awaycloudnull, ack, atleast it's failing consistantly in CI16:51
cloudnullykarel|away when I look at http://logs.openstack.org/25/654925/9/check/tripleo-ci-centos-7-standalone-upgrade-stein/44390d5/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2019-07-11_10_11_16 I see it skipping the fact set, which would mean the logins option is initially undefined?16:55
cloudnulland when I look at the internal CI which I assume is a multi-node test I see the facts being set on controller-0 but not compute-1 which I think is why it's raising the error there16:56
cloudnull2019-07-12 09:03:13,120 p=301 u=mistral |  ok: [controller-0] => {"ansible_facts": {"container_registry_insecure_registries": ["192.168.24.1:8787"], "container_registry_login": false, "container_registry_logins": {}, "container_registry_logins_json": {}}, "changed": false}16:56
cloudnull2019-07-12 09:03:15,738 p=301 u=mistral |  fatal: [compute-0]: FAILED! => {"msg": "An unhandled exception occurred while running the lookup plugin 'dict'. Error was a <class 'ansible.errors.AnsibleError'>, original message: with_dict expects a dict"}16:56
cloudnull^ Log entries I was looking at earlier16:56
*** udesale has quit IRC16:59
*** morazi_ has quit IRC17:00
*** betherly has joined #tripleo17:00
cloudnullykarel|away I'm going to go grab a bite to eat but I'll continue looking at it17:01
*** psachin has quit IRC17:03
ykarel|awaycloudnull, let me try to reproduce, if i can17:04
*** jtomasek has quit IRC17:04
*** betherly has quit IRC17:05
EmilienMslagle: thanks17:09
*** jcoufal has quit IRC17:09
EmilienMcloudnull: ack17:09
*** morazi_ has joined #tripleo17:13
ykarel|awaycloudnull, i am able to reproduce it locally17:13
ykarel|awaycloudnull, try running playbook locally: http://paste.openstack.org/show/754351/17:15
openstackgerritNatal Ngétal proposed openstack/paunch master: [Configuration] Switch to stestr.  https://review.opendev.org/62942117:17
openstackgerritClark Boylan proposed openstack/diskimage-builder master: Only enable dbus-daemon on fedora-29  https://review.opendev.org/67060617:23
*** florianf has quit IRC17:33
openstackgerritMerged openstack/puppet-tripleo master: Replace hiera('service_names') by hiera('enabled_services')  https://review.opendev.org/66941417:36
openstackgerritMerged openstack/tripleo-heat-templates master: Remove service_names hieradata file  https://review.opendev.org/66942417:36
*** xek has quit IRC17:53
*** xek has joined #tripleo17:53
*** poopcat has joined #tripleo17:54
*** betherly has joined #tripleo18:01
*** betherly has quit IRC18:06
EmilienMslagle: I commented on https://review.opendev.org/#/c/670596/1/puppet/role.role.j2.yaml18:16
*** betherly has joined #tripleo18:21
*** betherly has quit IRC18:26
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates master: Set HieradataVars as group vars instead  https://review.opendev.org/67059618:27
slagleEmilienM: fixed18:27
EmilienMslagle: +218:28
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: deploy-steps: remove unused hieradata_templates_list  https://review.opendev.org/66991718:29
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: Remove config_step hieradata  https://review.opendev.org/66992418:29
slagledang, that going to merge conflict my own patch18:35
*** sabedevops has quit IRC18:37
*** betherly has joined #tripleo18:42
EmilienMslagle: you can rebase on tops of the ssh things18:43
EmilienMor vice versa if yours can wait18:44
*** rascasoft has quit IRC18:44
*** mburned is now known as mburned_out18:46
*** betherly has quit IRC18:46
*** rascasoft has joined #tripleo18:47
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates master: Set HieradataVars as group vars instead  https://review.opendev.org/67059618:47
*** morazi_ has quit IRC18:47
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates master: Set HieradataVars as group vars instead  https://review.opendev.org/67059618:48
*** ccamacho has quit IRC18:48
slagleEmilienM: ok, i did18:48
*** irclogbot_2 has quit IRC18:49
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: deploy-steps: remove unused hieradata_templates_list  https://review.opendev.org/66991718:50
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: Remove config_step hieradata  https://review.opendev.org/66992418:50
EmilienMno more conflict :)18:50
*** irclogbot_1 has joined #tripleo18:53
*** slaweq has quit IRC19:17
*** mburned_out is now known as mburned19:21
cloudnullykarel|away that playbook works for me19:25
cloudnullhttps://pasted.tech/pastes/20cae44b777be2458e32301f0d0c02b54f44386c.raw19:25
ykarel|awaycloudnull, strange, can u try with ansible 2.8.019:26
cloudnullsure19:26
cloudnullinstalling now19:26
ykarel|awaycloudnull, looks like u have not used complete playbook19:27
ykarel|awaylet me recheck what i shared19:28
cloudnullsame result19:28
cloudnullhttps://pasted.tech/pastes/cce87c6d75054d2b513889ac6cd8084414925302.raw19:28
ykarel|awaycloudnull, try to use same playbook i shared19:28
ykarel|awayu missed last conditionals19:28
ykarel|awaywhen: step|int ==119:29
ykarel|awayto the block19:29
cloudnulloic19:29
cloudnullthat failed19:29
cloudnullhttps://pasted.tech/pastes/07714b556f63c5855ee7dd294838084fae8cec3c.raw19:30
cloudnulland that's because the look is evaluated but those facts are not set19:30
cloudnullso those facts need to be set outside of the block19:30
ykarel|awaycloudnull, yup19:31
cloudnullykarel|away mind trying https://pasted.tech/pastes/5a2850e51b83035d5ed9e95055920a15f69048b719:33
cloudnulljust to make sure we're on the same page19:33
*** tesseract has quit IRC19:33
cloudnullif that works for you I'll smash together another review19:33
ykarel|awaycloudnull, ^^ looks same i shared, u changed something19:34
ykarel|away?19:34
*** slaweq has joined #tripleo19:34
cloudnullyes its slightly different19:34
ykarel|awayokk got it u moved block:19:35
cloudnull++19:35
ykarel|awayyes ^^ should work19:35
cloudnullk19:36
mwhahahalogin shouldn't be stepwise19:37
mwhahahai thought it was host prep19:37
ykarel|awayhmm right19:38
*** skolt has quit IRC19:39
ykarel|awayEmilienM, see ^^, looks like u are chasing same thing over email, re. original message: with_dict expects a dict"19:39
mwhahahaadditionally it hit on the overcloud but not undercloud19:40
mwhahahawhich uses the same code19:40
mwhahahai wodner if overcloud injects bad credentials somewhere19:40
* mwhahaha is slowly building an environment19:40
EmilienMyeah me too19:40
ykarel|awayack19:41
*** mburned is now known as mburned_out19:41
mwhahahawhich is exactly what i want to be doing on a friday afternoon19:42
* mwhahaha cries19:42
EmilienMlol19:43
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-heat-templates master: Move container logins facts outside of the login block  https://review.opendev.org/67062719:44
cloudnullykarel|away ^19:45
ykarel|awayohhk so install_and_configure_podman anchor was adding that if condition19:47
cloudnullThough, after seeing what mwhahaha just said, and rereading the tasks, there's no conditional on that block19:48
cloudnullykarel|away is that a heat'ism ?19:48
ykarel|awayso with this host_prep_tasks has condition when: step|int == 119:48
ykarel|awaycloudnull, see Line 13619:48
cloudnullOHIC19:49
ykarel|awayand here is that in the log http://logs.openstack.org/25/654925/9/check/tripleo-ci-centos-7-standalone-upgrade-stein/44390d5/logs/undercloud/home/zuul/undercloud-ansible-1WMDAE/Standalone/upgrade_tasks.yaml.txt.gz19:49
cloudnullin the upgrade tasks...19:49
cloudnullso I guess those facts need to be set there too19:50
mwhahahaugh19:50
* mwhahaha throws things at ansible for evaluating things that should be skipped19:50
cloudnull^19:50
*** slaweq has quit IRC19:51
mwhahahaif we do something stupid like wrap it in a block, does the loop stop being evaluated?19:51
mwhahahaor is it always evaulated no matter what (wtf)19:51
cloudnullthe lookup is being evaluated no matter what19:52
mwhahahameh19:52
*** morazi has joined #tripleo19:53
mwhahahaso sounds like we need to move it to an ansible role?19:53
mwhahahaand then it'll stop being evaluated?19:53
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-heat-templates master: Move container logins facts outside of the login block  https://review.opendev.org/67062719:53
cloudnull^ that will make the login facts available to both the hostprep and upgrade tasks k19:54
mwhahahacloudnull: i don't think that's fixes it because we take that whole section and alap a step on it19:54
mwhahahaso it won't end up different19:54
cloudnullI added the facts block as a pre-step19:54
cloudnullwhich should be run before the failing block with the step conditional19:55
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates master: Set HieradataVars as group vars instead  https://review.opendev.org/67059619:55
cloudnullhowever, yes, if we stuck these things in a role ansible would not evaluate any of it until its executed.19:55
mwhahahai don't think moving it solves it19:55
mwhahahawe'll have to check the generated upgrade tasks19:56
mwhahahabut we'll see19:56
mwhahahabecause when step|int == 2, it's undefined19:56
* mwhahaha blames EmilienM for not creating a podman role. also cause it's friday19:56
cloudnullhttps://review.opendev.org/#/c/670627/2/deployment/podman/podman-baremetal-ansible.yaml@133 should run regardless of step?19:57
mwhahahaoh maybe19:58
mwhahahayaml id's are hard to follow sometimes19:58
* ykarel|away too late, need to go19:58
EmilienMwhat19:58
EmilienMwhy you always end up blaming me19:58
mwhahahaEmilienM: because you end up writing 1/3 of everything19:58
cloudnullEmilienM tl;dr its friday and your fault19:58
mwhahahaplus podman is your fault19:59
mwhahahalike ntp/chrony is my fault19:59
EmilienMclimate change as well?19:59
mwhahahaor config download is slagle's fault19:59
mwhahahasure we can blame you for climate change19:59
* ykarel|away :D20:00
cloudnullykarel|away are you able to pull that patch and give it a spin ?20:00
*** betherly has joined #tripleo20:02
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: deploy-steps: remove unused hieradata_templates_list  https://review.opendev.org/66991720:03
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: Remove config_step hieradata  https://review.opendev.org/66992420:03
*** ykarel|away has quit IRC20:04
cloudnullmwhahaha EmilienM is there a DNM review up we can update to see if the latest change resolves the container login issues?20:05
EmilienMafik my DNM in oooq was useless20:06
mwhahahanot really i don't think we've been able to reproduce it in stream?20:06
mwhahahai've got an env i'll test shortly20:06
EmilienMsame20:06
EmilienMmy standalone deployed just fine btw20:06
* mwhahaha does the introspection dance20:06
openstackgerritMerged openstack/tripleo-ci master: Run periodic standalone jobs  https://review.opendev.org/66997720:07
*** betherly has quit IRC20:07
cloudnullEmilienM ++ standalone deployment seem to work just fine, I think the missing link was these facts were not getting set in that upgrade_tasks section.20:09
mwhahahayea but we're seeing it elsewhere on normal overcloud deployments20:09
EmilienMyeah20:09
mwhahahaso unless we're running upgrade tasks on deploys (which would be bad), something else is weird20:09
cloudnullI think that issue was due to the lookup being evaluated even when the task shouldn't run20:10
* cloudnull guessing 20:10
*** holser_ has joined #tripleo20:11
mwhahahawe're all just guessing at this point :D20:13
openstackgerritMerged openstack/diskimage-builder master: Only enable dbus-daemon on fedora-29  https://review.opendev.org/67060620:13
*** mburned_out is now known as mburned20:14
*** slaweq has joined #tripleo20:15
openstackgerritGoutham Pacha Ravi proposed openstack/tripleo-heat-templates master: [dnm] Test manila without pacemaker  https://review.opendev.org/64292620:19
openstackgerritCorey Bryant proposed openstack/os-net-config master: Add Python 3 Train unit tests  https://review.opendev.org/67064320:19
vkmcgouthamr, (o/ \o) \o/20:19
openstackgerritCorey Bryant proposed openstack/paunch master: Add Python 3 Train unit tests  https://review.opendev.org/67064420:20
gouthamrvkmc: ^ rebased that old patch :) if it fails, let's debug with the fresh logs :P20:20
openstackgerritJohn Dennis proposed openstack/tripleo-quickstart master: Create supplemental node volume in correct volume pool  https://review.opendev.org/67064620:20
*** slaweq has quit IRC20:20
vkmcgouthamr, yes, cool20:21
vkmcthanks20:21
openstackgerritCorey Bryant proposed openstack/tripleo-image-elements master: Add Python 3 Train unit tests  https://review.opendev.org/67064720:21
openstackgerritJames Slagle proposed openstack/tripleo-heat-templates master: Set HieradataVars as group vars instead  https://review.opendev.org/67059620:22
openstackgerritCorey Bryant proposed openstack/os-refresh-config master: Add Python 3 Train unit tests  https://review.opendev.org/67064920:22
openstackgerritJeremy Freudberg proposed openstack/tripleo-validations master: Support multi-arch in deploy image validations  https://review.opendev.org/66673020:22
openstackgerritJeremy Freudberg proposed openstack/tripleo-validations master: [wip] Loosen ironic-boot-configuration  https://review.opendev.org/67065020:22
openstackgerritCorey Bryant proposed openstack/openstack-virtual-baremetal master: Add Python 3 Train unit tests  https://review.opendev.org/67065120:23
*** betherly has joined #tripleo20:23
*** slagle is now known as slagle-afk20:23
openstackgerritCorey Bryant proposed openstack/os-collect-config master: Add Python 3 Train unit tests  https://review.opendev.org/67065220:24
openstackgerritCorey Bryant proposed openstack/tripleo-repos master: Add Python 3 Train unit tests  https://review.opendev.org/67065320:24
*** betherly has quit IRC20:27
openstackgerritCorey Bryant proposed openstack/tripleo-validations master: Add Python 3 Train unit tests  https://review.opendev.org/67065520:28
openstackgerritCorey Bryant proposed openstack/tripleo-common-tempest-plugin master: Add Python 3 Train unit tests  https://review.opendev.org/67065620:29
openstackgerritCorey Bryant proposed openstack/python-tripleoclient master: Add Python 3 Train unit tests  https://review.opendev.org/67065720:29
*** slaweq has joined #tripleo20:31
*** slaweq has quit IRC20:35
openstackgerritCorey Bryant proposed openstack/tripleo-common master: Add Python 3 Train unit tests  https://review.opendev.org/67065820:36
openstackgerritCorey Bryant proposed openstack/tripleo-puppet-elements master: Add Python 3 Train unit tests  https://review.opendev.org/67065920:38
openstackgerritCorey Bryant proposed openstack/tripleo-heat-templates master: Add Python 3 Train unit tests  https://review.opendev.org/67066020:39
openstackgerritMerged openstack/openstack-virtual-baremetal master: Add Python 3 Train unit tests  https://review.opendev.org/67065120:39
mwhahahacloudnull: so interesting thing is that the login task is coming from the controller tasks rather than the compute (but is failing on compute)20:40
openstackgerritCorey Bryant proposed openstack/os-apply-config master: Add Python 3 Train unit tests  https://review.opendev.org/67066120:40
mwhahahacloudnull, EmilienM: it's failing because we're running the controller host prep tasks so the compute node is skipped when we run the set facts, but we still evaluate the query20:43
mwhahahahttp://paste.openstack.org/show/754360/20:44
mwhahahai think we need to stop using query() or lookup()20:45
mwhahahaon facts20:46
mwhahahabecause they get skipped20:46
* mwhahaha goes back to the drawing board20:46
cloudnull:'(20:50
cloudnullmwhahaha what if we slam that together in a new role and just include it ?20:51
mwhahahaso we could fix it for train but we need to backport it20:52
cloudnullthen it'd work similar to what we're doing with the older docker login20:52
cloudnullhum20:52
mwhahahaso it'd have to go tripleo-ansible to tripleo-common20:52
mwhahahai'd like to figure out how to solve this in THT if possible, but yes a role in the long term would be more ideal20:52
cloudnull++20:53
mwhahahai think i figured it out20:53
* mwhahaha sighs20:54
* cloudnull holds mwhahaha's beer 20:54
mwhahahait's simplier than we were making it20:54
mwhahahai also don't think we need the json conversion stuff either20:55
mwhahahabut i'll follow up with that later20:55
*** chem has quit IRC20:56
openstackgerritAlex Schultz proposed openstack/tripleo-heat-templates master: Specify a default for container_registry_logins  https://review.opendev.org/67066320:56
mwhahahacloudnull: -^20:56
mwhahahathat's it20:56
* cloudnull trying 20:57
*** pcaruana has quit IRC20:59
mwhahahaoops needs an extra )21:00
cloudnull++ works21:00
openstackgerritAlex Schultz proposed openstack/tripleo-heat-templates master: Specify a default for container_registry_logins  https://review.opendev.org/67066321:00
mwhahahabut yea that's it21:00
mwhahahaso we don't need to move anything around either21:00
*** raildo has quit IRC21:01
openstackgerritwes hayutin proposed openstack/tripleo-ci master: DNM: RHEL8 support for containers build  https://review.opendev.org/66948721:01
cloudnullhttps://pasted.tech/pastes/09908ff3e620d8cf3cf225b9da26ef654c42909f <- that was the reproducer playbook I was tinkering with and with the default it works, which sucks because it means the lookup is being run no matter.21:01
mwhahaharight21:02
cloudnullbut +1 from me, that would be easy to backport21:02
openstackgerritAlex Schultz proposed openstack/ansible-role-container-registry master: Specify a default for container_registry_logins  https://review.opendev.org/67066521:02
cloudnullI abandoned https://review.opendev.org/#/c/670627/21:03
mwhahahai think the more concerting part is that I don't think it ever runs correctly on the nova compute21:03
* mwhahaha chooses to ignore this and moves on with life21:03
*** betherly has joined #tripleo21:04
openstackgerritMerged openstack/tripleo-ansible master: Add template mode to tripleo-ssh-known-hosts  https://review.opendev.org/66996021:05
cloudnullhahaha21:05
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-common master: Ensure we're raising proper exceptions  https://review.opendev.org/67040821:08
*** betherly has quit IRC21:09
mwhahahaI think this didn't show up in CI because it only affects podman21:12
mwhahahaovb runs docker21:12
cloudnullinteresting. why is that?21:12
* mwhahaha shakes his fist at the lack of centos8 striking yet again21:12
mwhahahadocker is an include of role tasks21:13
cloudnullha21:13
mwhahahathe upgrade is the upgrade from docker to podman21:13
cloudnulli see21:13
mwhahahai reproduced it on a podman overcloud21:13
mwhahahastandalone won't hit it because it's 1 node21:14
mwhahahaall the upstream jobs are 1 node21:14
mwhahahait triggers on >121:14
* mwhahaha sighs21:14
cloudnullok, le sigh21:14
mwhahahaalso why the undercloud install was fine but the overcloud hit it21:15
openstackgerritRonelle Landy proposed openstack/openstack-virtual-baremetal master: Add requirements for python 3 installs  https://review.opendev.org/67066721:21
openstackgerritMerged openstack/tripleo-heat-templates master: Lookup pre/post deployment vars with hostvars  https://review.opendev.org/66996421:29
openstackgerritRyan Brady proposed openstack/tripleo-upgrade master: Change Upgrade Run Script Generation to Per Host  https://review.opendev.org/66761021:29
*** ekultails has quit IRC21:32
*** cfontain has joined #tripleo21:34
* mwhahaha give sup for teh week21:35
cloudnulldid it not work ?21:36
*** cfontain has quit IRC21:37
*** holser_ has quit IRC21:46
openstackgerritMerged openstack/python-tripleoclient master: Ensure files are closed, ensure no ResourceWarning on console  https://review.opendev.org/67057621:47
*** rlandy has quit IRC21:54
*** cfontain has joined #tripleo21:55
openstackgerritRonelle Landy proposed openstack/tripleo-ci master: Add roles/playbooks copy in setup.cfg  https://review.opendev.org/67055121:55
*** xek has quit IRC22:05
*** betherly has joined #tripleo22:17
*** cfontain_ has joined #tripleo22:19
*** betherly has quit IRC22:21
*** vinaykns has quit IRC22:25
*** cfontain_ has quit IRC22:25
*** aakarsh has quit IRC22:32
*** cfontain_ has joined #tripleo22:41
*** holser_ has joined #tripleo22:41
*** cfontain_ has quit IRC22:45
*** aakarsh has joined #tripleo22:51
*** cfontain has joined #tripleo23:14
*** betherly has joined #tripleo23:19
*** tosky has quit IRC23:20
*** betherly has quit IRC23:24
*** betherly has joined #tripleo23:39
*** betherly has quit IRC23:44
*** artom has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!