Wednesday, 2019-12-18

*** tosky has quit IRC00:00
*** tkajinam has quit IRC00:07
*** tkajinam has joined #tripleo00:07
*** bnemec has quit IRC00:14
*** saneax has quit IRC00:20
*** rlandy has quit IRC00:29
*** rodrigods has quit IRC00:39
openstackgerritMerged openstack/tripleo-ansible master: zuul: all functional jobs now depend on linter job first  https://review.opendev.org/69335500:47
*** artom has quit IRC01:08
openstackgerritSteve Baker proposed openstack/tripleo-heat-templates master: Deploy neutron metadata agent with nova metadata api  https://review.opendev.org/69952801:24
tkajinamhmmm... seems we need to disable relative_classname_inclusion for instack_undercloud to avoid the same error we observed for puppet modules... https://review.opendev.org/#/c/699401/01:56
openstackgerritTakashi Kajinami proposed openstack/puppet-tripleo master: Add support to configure virtlogd  https://review.opendev.org/68534901:59
openstackgerritTakashi Kajinami proposed openstack/puppet-tripleo master: Add support to configure virtlogd  https://review.opendev.org/68534902:00
*** apetrich has quit IRC03:09
*** gouthamr has quit IRC03:14
*** gouthamr has joined #tripleo03:24
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944803:30
*** psachin has joined #tripleo03:40
*** StevenK_ is now known as StevenK03:44
*** ykarel|away has joined #tripleo03:46
*** bhagyashris has joined #tripleo04:05
*** ykarel|away has quit IRC04:18
*** skramaja has joined #tripleo04:26
*** ykarel|away has joined #tripleo04:35
*** bhagyashris has quit IRC04:47
*** bhagyashris has joined #tripleo04:47
*** epoojad1 has joined #tripleo04:49
*** holser has joined #tripleo04:54
*** ykarel|away is now known as ykarel05:00
*** whoami-rajat__ has joined #tripleo05:03
openstackgerrityatin proposed openstack/tripleo-ci master: [DNM] Add option to build containers from package  https://review.opendev.org/69954905:18
openstackgerritJaganathan Palanisamy proposed openstack/tripleo-common stable/stein: Incorrectly derives NeutronPhysnetNUMANodesMapping  https://review.opendev.org/69955105:21
openstackgerritJaganathan Palanisamy proposed openstack/tripleo-common stable/rocky: OvS DPDK parameters failing in NIC Partitioning  https://review.opendev.org/69955205:22
*** ramishra has joined #tripleo05:23
*** pcaruana has joined #tripleo05:24
openstackgerrityatin proposed openstack/tripleo-ci master: [DNM] Test container build with python3 on CentOS7  https://review.opendev.org/69955505:28
openstackgerrityogananth subramanian proposed openstack/tripleo-heat-templates master: Provide option to set reserved_huge_pages  https://review.opendev.org/69399405:31
*** holser has quit IRC05:34
*** zaneb has quit IRC05:53
*** raukadah is now known as chkumar|rover05:58
*** surpatil has joined #tripleo05:59
*** bandini has joined #tripleo06:00
openstackgerritSuraj Patil proposed openstack/tripleo-quickstart-extras master: [queens] Removed passing Tests from skiplist  https://review.opendev.org/69955806:05
*** whoami-rajat__ has quit IRC06:07
*** SurajPatil has joined #tripleo06:09
*** surpatil has quit IRC06:12
*** yprokule has joined #tripleo06:14
*** waleedm has joined #tripleo06:16
*** ksambor has quit IRC06:17
*** ksambor has joined #tripleo06:17
bandiniugh gate is all clogged06:22
*** saneax has joined #tripleo06:24
chkumar|roverlooks like last night so many patches got approved06:25
*** SurajPatil has quit IRC06:25
*** surpatil has joined #tripleo06:26
*** lmiccini has joined #tripleo06:34
*** marios|ruck has joined #tripleo06:36
*** whoami-rajat__ has joined #tripleo06:37
*** shyamb has joined #tripleo06:40
shyambHi owalsh: Created same bug in redhat bugzila: https://bugzilla.redhat.com/show_bug.cgi?id=178470606:41
openstackbugzilla.redhat.com bug 1784706 in tripleo-ansible "Duplicate horizon, keystone containers getting launched during overcloud deploy process" [Urgent,New] - Assigned to rhos-maint06:41
*** ansmith_ has joined #tripleo06:42
*** ansmith has quit IRC06:43
*** janki has joined #tripleo06:48
*** jfrancoa has joined #tripleo06:52
*** rcernin has quit IRC06:56
openstackgerritMerged openstack/tripleo-heat-templates stable/stein: Revert "Add ntpdate to ensure hwclock sync"  https://review.opendev.org/69903307:01
Tenguchkumar|rover: apparently we did some unlocking in CI ? :)07:12
Tenguchkumar|rover: btw, any power on https://review.opendev.org/699438 ?07:12
Tenguwould be good to get it merged so that we can close the LP07:13
chkumar|roverTengu: thanks, will get it merged07:13
Tengu:)07:15
Tenguchkumar|rover: would you have a moment for some help on a CI issue? it keeps failing for a "tox -elinters" here: https://14d65eceddbce78ddf51-8bfb5d70b83a273fa97d15d51d14f1ae.ssl.cf1.rackcdn.com/698006/5/check/openstack-tox-linters/8233f64/job-output.txt07:17
*** pkopec has joined #tripleo07:18
Tenguchkumar|rover: I've tried to understand what's going on, I can reproduce it locally using a virtualenv with python3.6, but I'm unabe to find WHAT file is actually failint… apparently it's not always the same place.07:18
chkumar|roverTengu: checking07:18
Tengualso, I don't really like the message about python version mismatch, especially when a TODO in the code shows a "raise for tox 4"07:19
chkumar|roverTengu: at this file it failed https://review.opendev.org/#/c/698006/5/roles/validate-selinux/molecule/default/prepare.yml07:20
Tenguchkumar|rover: how did you find it?!07:21
chkumar|roverI am checking for last file order07:21
chkumar|roverreproducing it locally07:21
Tenguo_07:21
Tenguhere it changes every time07:21
chkumar|rovermay be issue in ansible lint07:22
Tengu«again»...07:22
Tengu?07:22
Tenguhere, each run fails on a different file.07:22
Tengunow, it MIGHT indeed be related to that one since it's a new addition. Wondering how I can pin the exact issue though07:23
*** TrevorV has joined #tripleo07:23
*** TrevorV has quit IRC07:23
chkumar|roverTengu: I also reproduced07:28
Tenguchkumar|rover: hmm. apparently, it's either ./molecule/default/playbook.yml or ./molecule/default/prepare.yml in the validate-selinux. Just called ansible-lint by hand, and one of those is failing. Thank for the investigations!07:28
Tenguyay! ./molecule/default/playbook.yml07:28
Tengubut absolutely NO clue as to why....07:31
*** holser has joined #tripleo07:31
*** mschuppert has joined #tripleo07:32
chkumar|rovertrying out pdb07:33
openstackgerritMerged openstack/tripleo-heat-templates stable/train: Add netcontrold service for DPDK roles  https://review.opendev.org/69886907:35
openstackgerritMerged openstack/tripleo-heat-templates stable/stein: Properly set loopback_users via rabbitmq::loopback_users  https://review.opendev.org/69864107:35
openstackgerritMerged openstack/tripleo-heat-templates stable/rocky: Fix OctaviaFlavorId type  https://review.opendev.org/69684707:35
openstackgerritMichele Baldessari proposed openstack/tripleo-heat-templates stable/stein: Increase rabbitmq tcp backlog  https://review.opendev.org/69957307:36
Tenguchkumar|rover: apparently it has some issues finding the role path. At least, that's what I understand.07:37
chkumar|roverTengu: yes07:37
Tengunon-sense :/07:38
*** ccamacho has joined #tripleo07:38
*** shyamb has quit IRC07:41
Tenguchkumar|rover: found it.07:42
chkumar|roveris it include role?07:42
Tenguinclude_role dropped "role" param in favor of "name", but it's not even failing within ansible - ansible-lint on the other part seems to enforce it at some point.07:42
chkumar|roverrunnign it rigjt now with that fix07:43
chkumar|roverTengu: http://paste.openstack.org/show/787701/07:43
chkumar|roverdoe not work07:44
Tenguhave to update allthe calls07:44
chkumar|roverok07:45
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-validations master: New validation: validate-selinux  https://review.opendev.org/69800607:45
Tengunow if gerrit can...07:45
Tenguthank you gerrit.07:45
Tengugrumpf.07:45
Tenguthat patch should be OK07:45
openstackgerritMartin Schuppert proposed openstack/puppet-tripleo master: Make sure neutron [placement] config section is set  https://review.opendev.org/69884307:46
*** ykarel is now known as ykarel|lunch07:47
*** whoami-rajat__ is now known as whoami-rajat|lun07:48
*** kozhukalov has joined #tripleo07:52
*** kopecmartin|off is now known as kopecmartin07:53
*** slaweq has joined #tripleo08:03
*** Chaserjim has quit IRC08:04
*** Chaserjim has joined #tripleo08:04
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Clean up ansible variables.  https://review.opendev.org/56295708:13
*** amoralej|off is now known as amoralej08:14
openstackgerritDaniel Bengtsson proposed openstack/tripleo-quickstart master: Use python -m pip instead pip command.  https://review.opendev.org/69314208:15
openstackgerritCarlos Camacho proposed openstack/tripleo-upgrade master: Fix bindeps  https://review.opendev.org/69957408:15
*** tosky has joined #tripleo08:18
*** jpena|off is now known as jpena08:22
*** tmazur has joined #tripleo08:23
*** florianf has joined #tripleo08:23
chkumar|roverTengu: does linters passed?08:25
*** hberaud|gone is now known as hberaud08:25
*** SurajPatil has joined #tripleo08:29
*** surpatil has quit IRC08:30
*** surpatil has joined #tripleo08:31
*** tosky has quit IRC08:32
*** tkajinam has quit IRC08:34
*** SurajPatil has quit IRC08:34
*** shyamb has joined #tripleo08:35
*** slaweq has quit IRC08:36
*** pbandark has joined #tripleo08:43
Tenguchkumar|rover: failed, but on another issue - and one I didn't got locally....08:46
Tenguansible-lint is a nightmare.08:46
*** slaweq has joined #tripleo08:50
openstackgerritMarios Andreou proposed openstack/tripleo-quickstart-extras master: Add tempest.api.compute.images test_delete_saving_image to skip  https://review.opendev.org/69962408:52
marios|ruckchkumar|rover: ^ https://bugs.launchpad.net/tripleo/+bug/1856723/comments/308:53
openstackLaunchpad bug 1856723 in tripleo "periodic-tripleo-ci-centos-7-standalone-full-tempest-master fails during tempest run ImagesTestJSON:test_delete_saving_image" [Critical,Triaged]08:53
*** kozhukalov has quit IRC08:58
*** rpittau|afk is now known as rpittau08:59
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-validations master: New validation: validate-selinux  https://review.opendev.org/69800609:00
*** jpich has joined #tripleo09:01
*** lucasagomes has joined #tripleo09:05
openstackgerritSagi Shnaidman proposed openstack/python-tripleoclient master: Support standalone ansible.cfg addition and extra args  https://review.opendev.org/69913709:13
openstackgerritSagi Shnaidman proposed openstack/tripleo-quickstart-extras master: WIP: run ansible plugins on undercloud  https://review.opendev.org/69931409:13
Tenguchkumar|rover: w00t! linters just passed with latest patch! pfiouuu09:13
*** pbandark has quit IRC09:14
*** tosky has joined #tripleo09:16
*** gfidente has joined #tripleo09:16
*** paramite|clone has joined #tripleo09:19
*** shyamb has quit IRC09:23
*** apetrich has joined #tripleo09:27
Tengugchamoul: I finally found the issue with my validate-selinux thing... ansible-lint being stricter than ansible itself regarding parameters for include_role...09:29
Tenguansible does an undocumented alias name <-> role, while ansible-lint doesn't. yay09:31
gchamoulTengu: ...09:35
Tenguyeah... well ;)09:36
Tenguso it should now pass CI, and be able to merge shortly.09:36
Tenguthen, I'll have to corner weshay in order to activate it in some way :).09:36
Tenguand this MIGHT be the first call to the validation framework. yay!09:37
*** derekh has joined #tripleo09:37
openstackgerritGael Chamoulaud proposed openstack/tripleo-ansible stable/train: Create Validations logging directory  https://review.opendev.org/69964109:37
*** bhagyashris has quit IRC09:41
*** ykarel|lunch is now known as ykarel09:44
*** whoami-rajat|lun is now known as whoami-rajat09:44
*** shyamb has joined #tripleo09:51
*** dpawlik has joined #tripleo09:51
*** leanderthal has joined #tripleo09:53
*** fmount has quit IRC09:53
openstackgerritGael Chamoulaud proposed openstack/tripleo-validations master: Fix upper and lower constraints  https://review.opendev.org/69949909:55
*** apetrich has quit IRC09:58
*** suuuper has joined #tripleo10:00
*** fmount has joined #tripleo10:02
*** tosky has quit IRC10:02
*** Chaserjim has quit IRC10:03
*** tosky has joined #tripleo10:03
*** Chaserjim has joined #tripleo10:03
openstackgerritGael Chamoulaud proposed openstack/tripleo-validations master: Fix upper and lower constraints  https://review.opendev.org/69949910:13
*** bhagyashris has joined #tripleo10:24
shyambHi10:28
shyambin tripleo-quickstart github repo, I don't find this ansible playbook- quickstart-extras-overcloud.yml10:28
shyambthis is getting referred in documentation10:28
shyambAre we keep some playbooks in some other repository?10:29
toskyshyamb: it's in tripleo-quickstart-extras - and please clone the repositories from opendev.org, github is just a mirror10:29
shyambI am looking at this install doc: https://docs.openstack.org/tripleo-quickstart/latest/getting-started.html#install-the-undercloud10:29
shyambtosky10:29
shyambgot it10:29
shyambso if I want to deploy openstack using tripleo-quickstart, I need to clone both repos?10:29
shyambor just tripleo-quickstart?10:30
shyamband internally it will clone the extras repo?10:30
shyambtosky: install doc https://docs.openstack.org/tripleo-quickstart/latest/getting-started.html#install-the-undercloud10:30
toskyno10:31
toskyquickstart.sh clones the other repository10:31
shyambokay10:31
shyambgot it10:31
shyambtosky: thank you10:31
toskyI'd suggest trying to follow the instructions (until you get stuck - but hopefully you won't :)10:31
shyambtosky: yes10:32
leanderthalshyamb, and then come ask questions here or #rdo10:32
shyambleanderthal: I was going through the script and design of the project10:33
leanderthalcool cool10:33
shyambwanted to understand the details10:33
leanderthalfair10:33
shyambthank you10:34
leanderthalhere and #rdo are great resources, but if no one's answering, also feel free to post to the mailing lists10:34
shyambI want to deploy my product on openstack through tripleo-quickstart10:35
leanderthalhttps://lists.rdoproject.org/mailman/listinfo10:35
leanderthalcool!10:35
*** janki has quit IRC10:35
shyambI need to write my ansible role?10:35
openstackgerritKamil Sambor proposed openstack/tripleo-heat-templates master: WIP: Change default dns domain in neutron  https://review.opendev.org/69940710:40
chem_matbu: hey, around ?10:40
*** shyamb has quit IRC10:42
*** holser has quit IRC10:50
*** holser__ has joined #tripleo10:50
matbuchem_: yep10:51
*** hberaud is now known as hberaud|school-r10:52
*** bhagyashris has quit IRC10:54
Tengufolks, can anyone approve this patch? https://review.opendev.org/#/c/699438/  it would close a CIX :)10:56
*** bhagyashris has joined #tripleo10:58
*** shyamb has joined #tripleo10:59
Tenguor I can +A it.... ? since it's actually blocking promotion and things10:59
*** tbarron_ has joined #tripleo11:00
*** Chaserjim has quit IRC11:00
*** Chaserjim has joined #tripleo11:00
*** pbandark has joined #tripleo11:01
sshnaidmTengu, done11:12
openstackgerritJose Luis Franco proposed openstack/tripleo-upgrade master: Run upgrade for previous hosts only in Controller role.  https://review.opendev.org/69966511:15
*** ykarel is now known as ykarel|afk11:20
*** holser__ has quit IRC11:21
*** holser has joined #tripleo11:22
*** hberaud|school-r is now known as hberaud11:24
cgoncalveschkumar|rover, marios|ruck: hi. stable/train tripleo-ci-centos-7-containerized-undercloud-upgrades has been failing consistently for the last 4 rechecks in https://review.opendev.org/#/c/698246/. I believe the patch does not touch code relevant to the job. are you aware of any issues with this job on stable/train?11:25
marios|ruckcgoncalves: checking ... we have a lp for that already i believe gimme min will find11:27
marios|ruck2019-12-18 10:44:39.322627 | primary |         "tripleo_ironic_neutron_agent_healthcheck.service loaded failed failed ironic_neutron_agent healthcheck"11:27
*** shyamb has quit IRC11:27
marios|ruckcgoncalves: yeah we hav https://bugs.launchpad.net/tripleo/+bug/185628811:28
openstackLaunchpad bug 1856191 in tripleo "duplicate for #1856288 Ironic PXE healthcheck is broken in master" [Undecided,Fix released] - Assigned to Emilien Macchi (emilienm)11:28
marios|ruckcgoncalves: meant to be fixed by https://review.opendev.org/#/c/698580/11:28
marios|ruckcgoncalves: but looks like its still an issue11:28
marios|ruckmatbu: jfrancoa: fyi containerized undercloud-upgrades bug still ongoing (neutron healthcheck one0  ^^11:29
cgoncalvesmarios|ruck, thanks. I see the same error in the failed job of my patch.11:30
marios|ruckcgoncalves: right i added comment in the bug just now11:30
openstackgerritDaniel Bengtsson proposed openstack/tripleo-validations master: Remove the useless environment variable.  https://review.opendev.org/69966711:30
*** ykarel|afk has quit IRC11:30
*** jfrancoa has quit IRC11:32
*** apetrich has joined #tripleo11:42
openstackgerritSagi Shnaidman proposed openstack/python-tripleoclient master: Support standalone ansible.cfg addition and extra args  https://review.opendev.org/69913711:44
matbumarios|ruck: i don't follow the review from Damien, fix it or not ?11:45
*** jfrancoa has joined #tripleo11:47
surpatills11:48
*** bhagyashris has quit IRC11:52
marios|ruckmatbu: well there were two issues. dciabrin_ patch was for another healthcheck. for neutron agent healthcheck mwhahaha patch https://review.opendev.org/#/c/698580/ was meant to fix it11:52
marios|ruckmatbu: but that is the failing healthcheck in https://bugs.launchpad.net/tripleo/+bug/1856288/comments/7 and from cgoncalves11:53
openstackLaunchpad bug 1856191 in tripleo "duplicate for #1856288 Ironic PXE healthcheck is broken in master" [Undecided,Fix released] - Assigned to Emilien Macchi (emilienm)11:53
*** lucasagomes has quit IRC11:57
marios|ruckmatbu: hmmm chkumar|rover wondering if this is just related to delayed consistent build11:57
*** lucasagomes has joined #tripleo11:58
marios|ruckchkumar|rover: so we don't have latest which includes fix from mwhahaha11:58
marios|ruckmatbu: we should wait for next periodic run maybe will clear it11:58
*** bhagyashris has joined #tripleo11:58
*** epoojad1 is now known as epoojad1|afk11:59
matbumatbu: hmm oki12:00
chkumar|rovermatbu: marios|ruck we need to wait for the promotion12:02
matbuthen i can go to lunch :D12:03
matbuchkumar|rover: ack thx12:03
marios|ruckmatbu: (this is the issue i mean https://bugs.launchpad.net/tripleo/+bug/1856830/comments/512:03
openstackLaunchpad bug 1856830 in tripleo "master + train promote-consistent-to-tripleo-ci-testing times out blocks master+train pipeline" [Critical,Triaged]12:03
*** sshnaidm has quit IRC12:04
*** epoojad1|afk has quit IRC12:04
*** raildo has joined #tripleo12:05
*** yog_ has joined #tripleo12:05
yog_mwhahaha, EmilienM .. it would be wonderful if you could give your review for the patch related to setting reserved_huge_pages ... https://review.opendev.org/#/c/693994/12:09
*** bhagyashris_ has joined #tripleo12:09
*** bhagyashris has quit IRC12:12
*** hjensas has quit IRC12:12
*** bhagyashris_ has quit IRC12:13
*** gfidente has quit IRC12:14
*** florianf has quit IRC12:18
*** ykarel|afk has joined #tripleo12:21
*** florianf has joined #tripleo12:25
*** gfidente has joined #tripleo12:29
*** jpena is now known as jpena|lunch12:41
*** ansmith_ has quit IRC12:53
*** morazi has joined #tripleo12:53
*** rlandy has joined #tripleo12:57
*** sshnaidm has joined #tripleo12:58
*** shyamb has joined #tripleo12:58
*** Goneri has quit IRC12:58
openstackgerritMerged openstack/tripleo-heat-templates stable/queens: Properly set loopback_users via rabbitmq::loopback_users  https://review.opendev.org/69865512:58
*** ekultails has joined #tripleo13:00
*** marios|ruck is now known as marios|ruck|call13:00
*** sshnaidm has quit IRC13:02
*** sshnaidm has joined #tripleo13:03
Tengufolks, care to make that one merge? https://review.opendev.org/698006   would be great to get that new validation in the repo :)13:03
chkumar|roverTengu: gates are in bad state, can we wait?13:04
*** rh-jelabarre has joined #tripleo13:06
chkumar|roverwe have long queue time there13:06
*** jainprasuk1996 has joined #tripleo13:07
slaglefultonj: can you review https://review.opendev.org/#/c/697188/ plz? it's needed for minor update for multi-stack13:07
fultonjslagle: sure13:08
slaglethanks13:08
Tenguchkumar|rover: noooo we can't wait, never, EVER !13:08
Tengu:]13:08
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-heat-templates master: Create a dedicated log file for healthchecks for collectd  https://review.opendev.org/69922613:08
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944813:08
Tenguchkumar|rover: (joke aside, of course we can wait, that one isn't high prio)13:09
*** amoralej is now known as amoralej|lunch13:09
fultonjslagle: +2 +w13:10
*** udesale has joined #tripleo13:11
*** holser has quit IRC13:17
*** jbadiapa has joined #tripleo13:17
*** holser has joined #tripleo13:18
*** nkinder has joined #tripleo13:19
slaglefultonj: cheers!13:19
*** ssbarnea has quit IRC13:22
fultonjslagle: would you mind reviewing https://review.opendev.org/#/c/696401 ?13:22
*** jainprasuk1996 has quit IRC13:22
*** csmart has quit IRC13:23
slaglefultonj: will take a look13:24
fultonjthks?13:24
*** jainprasuk1996 has joined #tripleo13:28
cloudnullmornings13:32
openstackgerritRonelle Landy proposed openstack/ansible-role-collect-logs master: WIP: Add functionality to sanitize collected logs  https://review.opendev.org/69199413:33
*** ykarel|afk is now known as ykarel13:36
openstackgerritBrent Eagles proposed openstack/tripleo-quickstart master: WIP: parameterize amphora download path  https://review.opendev.org/69285713:38
openstackgerritBrent Eagles proposed openstack/tripleo-heat-templates stable/queens: WIP/DNM Configure amphora for upload and run tempest  https://review.opendev.org/69257913:38
EmilienMchkumar|rover, marios|ruck|call : do we know why the gate is stacked up?13:42
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates stable/queens: CiscoNexus: Update and Remove deprecated vars  https://review.opendev.org/69942013:44
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates stable/queens: Remove incorrect mapped_data key from cisco ml2 hieradata  https://review.opendev.org/69942113:44
*** jpena|lunch is now known as jpena13:45
*** Goneri has joined #tripleo13:46
openstackgerritEmilien Macchi proposed openstack/tripleo-ansible master: tripleo-keystone-resources: handle multiple roles per user  https://review.opendev.org/69928613:47
chkumar|roverEmilienM: we are seeing random times on multinode jobs, It is 9th hours from early morning, the patches in queue are high also13:48
EmilienMchkumar|rover: so it's timeout ?13:48
chkumar|roveryes13:48
EmilienMmhhh13:51
*** amoralej|lunch is now known as amoralej13:51
EmilienMchkumar|rover: are you able to tell since when we have these timeouts?13:51
EmilienMdo you have graps?13:51
EmilienMgraphs13:51
chkumar|roverEmilienM: http://zuul.openstack.org/builds?job_name=tripleo-ci-centos-7-containers-undercloud-minion13:51
EmilienMwe have merged a bunch of changes lately13:51
EmilienMchkumar|rover: is that only the minion?13:52
chkumar|rovergrabing from the graphs13:52
*** hjensas has joined #tripleo13:52
*** ansmith has joined #tripleo13:53
EmilienMmwhahaha: ^ when you're up13:53
*** fmount has quit IRC13:53
*** fmount has joined #tripleo13:54
EmilienMit's indeed timeouting during the minion deployment13:54
EmilienMhttps://99b357a009d0a4edac99-8a8b5915810a5f7208ad3fdf123edf93.ssl.cf2.rackcdn.com/698936/7/check/tripleo-ci-centos-7-containers-undercloud-minion/f96a71f/logs/subnode-1/home/zuul/minion_install.log.txt.gz13:54
EmilienMit's like the timeouts are since yesterday or something13:55
fultonjTengu: regarding https://review.opendev.org/#/c/694673/ what kind of unit test are you looking for? e.g. Molecule? are there existing tests in the repos I could use as an example?13:55
marios|ruck|callEmilienM: not aware of something it must be new as it wasn't an issue until earlier at least chkumar|rover ?13:56
marios|ruck|callEmilienM: in a call right now will try check in bit13:56
EmilienMi'm looking now13:58
chkumar|roverEmilienM:http://dashboard-ci.tripleo.org/d/si1tipHZk/jobs-exploration?orgId=1&var-influxdb_filter=result%7C%3D%7CTIMED_OUT&from=1576072854338&to=1576677654339&panelId=9&fullscreen14:01
chkumar|roversorry wrong mapping14:01
*** jainprasuk1996 has quit IRC14:02
*** sshnaidm has quit IRC14:02
*** udesale has quit IRC14:02
*** lbragstad_ is now known as lbragstad14:03
*** rh-jelabarre has quit IRC14:04
openstackgerritRiccardo Pittau proposed openstack/diskimage-builder master: Add python-yaml in bindep for ubuntu  https://review.opendev.org/69968114:05
Tengufultonj: Molecule would be good, yes, but maybe "plain" unit test for the python lib itself would already be something good14:05
chkumar|rovermarios|ruck|call: sawe few timeout on my patches14:06
Tengufultonj: lemme dig some links14:06
Tengufultonj: so python unit test would take place here: https://opendev.org/openstack/tripleo-validations/src/branch/master/tripleo_validations/tests/library14:07
*** marios|ruck|call is now known as marios14:07
*** marios is now known as marios|call14:07
Tengufultonj: and you might have a look at https://review.opendev.org/#/c/698006/ for molecule tests (and we can work together if you want)14:07
*** chkumar|rover is now known as chandankumar14:07
mwhahahaEmilienM: Im PTO today. I bet it was the firewall change or something14:08
fultonjTengu: should we have both?14:09
EmilienMmwhahaha: ah right, ttyl14:10
Tengufultonj: python unit tests are testing the lib itself, method by method, while molecule is more like an "acceptance test"14:10
*** bnemec has joined #tripleo14:10
*** ramishra has quit IRC14:13
mwhahahaEmilienM: minion will hang if it can't MySQL to the undercloud because heat db sync hangs14:13
Tengufultonj: and if we have to chose one, seeing the complexity, I'll ask for python unit tests in order to ensure we don't have regression at that level :).14:13
EmilienMcloudnull: i'm currently investigating the timeouts in tripleo gate and looking if it can be related to https://review.opendev.org/#/c/698620/14:13
openstackgerritLuke Short proposed openstack/tripleo-heat-templates stable/train: Use include_tasks instead of import_tasks  https://review.opendev.org/69968614:13
EmilienMmwhahaha: gotcha14:14
cloudnullEmilienM - are we seeing timouts across the board?14:14
EmilienMyes14:14
EmilienMgate is stacked up14:15
Tenguplugin is supposed to be faster :(14:15
EmilienMminion job is timing out (more than others apparently)14:15
*** shyamb has quit IRC14:15
EmilienMsee what alex said ^14:15
cloudnullyea, that plugin is quite a bit faster executing.14:16
EmilienMhttps://zuul.openstack.org/builds?job_name=tripleo-ci-centos-7-containers-undercloud-minion14:16
cloudnulllooking at the gate status page, and searching for tripleo, (http://zuul.openstack.org/status) it doesn't look like there are too many failures?14:17
EmilienMcloudnull: watch the queue14:18
cloudnulloh, so its just the minion job?14:18
EmilienMapparently not only, but with the most hits14:18
cloudnullin the current running jobs the only job with the status "timed_out" is a minion job14:20
*** mcornea has joined #tripleo14:20
EmilienMcloudnull: did we change logging for firewall tasks?14:20
EmilienMsince yesterday I see:14:20
EmilienM tripleo-firewall : Manage firewall rules ------------------------------- 16.51s14:21
EmilienMcheck https://6965fd4aef581b711f1e-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf5.rackcdn.com/699505/1/check/tripleo-ci-centos-7-containers-undercloud-minion/eb9c291/logs/undercloud/home/zuul/undercloud_install.log.txt.gz14:21
EmilienMwe didn't have it before: https://ac838a0a27e37f4efe0f-f8f923e4c1a8e99f5a61e3c81e6721bf.ssl.cf5.rackcdn.com/698211/6/check/tripleo-ci-centos-7-containers-undercloud-minion/0d87b18/logs/undercloud/home/zuul/undercloud_install.log.txt.gz14:21
EmilienMah yeah we did https://review.opendev.org/#/c/698620/7/tripleo_ansible/roles/tripleo-firewall/tasks/main.yml14:21
*** pbandark has quit IRC14:21
cloudnullyea, its just the one task now14:21
Tengu16 seconds, not a source of timeout, is it?14:22
EmilienMyeah and it takes 16.51s, not too bad14:22
cloudnullin verbose mode you see more output.14:22
EmilienMbut I wonder if a rule would be missing or something14:22
cloudnullbut without verbose its just a task return14:22
EmilienMi compared, I saw no issue14:22
*** rh-jelabarre has joined #tripleo14:22
TenguEmilienM: we can check here maybe: https://6965fd4aef581b711f1e-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf5.rackcdn.com/699505/1/check/tripleo-ci-centos-7-containers-undercloud-minion/eb9c291/logs/undercloud/var/log/extra/network.txt.gz14:23
EmilienMyeah I did14:23
EmilienMI compared with a job from 3 days ago14:23
EmilienMand no change14:23
Tengumeh..14:23
Tenguoh.... interesting..... my undercloud deploy seems to be stalled at step 314:23
Tenguah. nope. it just unlocked -.-14:23
mwhahahahttps://6965fd4aef581b711f1e-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf5.rackcdn.com/699505/1/check/tripleo-ci-centos-7-containers-undercloud-minion/eb9c291/logs/subnode-1/var/log/containers/stdouts/heat_engine_db_sync.log.txt.gz14:25
mwhahahaminion can't connect to the undercloud14:25
Tengu"No route to host"14:25
mwhahahaso it's hung on the db sync (like i said i twas)14:25
EmilienMinteresting, I see one missing rule14:25
Tengueither missing firewall rule, or network issue14:25
TenguEmilienM: so we probably have the cause then. what's that rule?14:26
cloudnullin the timout job it looks like the undercloud completed in ~1 hour14:26
cloudnullStart 2019-12-18 10:29:31, Stop 2019-12-18 11:30:1514:26
EmilienMTengu: https://www.diffchecker.com/GmEVf7pi14:27
TenguDec 18 13:05:56 undercloud.localdomain kernel: iptables dropped: IN=br-ex OUT= MAC=fe:ef:39:14:18:4e:fa:93:9d:fa:72:4d:08:00 SRC=192.168.24.4 DST=192.168.24.1 LEN=60 TOS=0x00 PREC=0x00 TTL=64 ID=39564 DF PROTO=TCP SPT=56135 DPT=3306 WINDOW=29200 RES=0x00 SYN URGP=014:27
EmilienMnice catch14:28
mwhahahalike i said, probably the firewall change :D14:28
Tenguwe're "just" missing rules allowing the minion to connect, indeed. and, hey, we have firewall logging :D14:28
EmilienMpush ups !14:28
EmilienMyeah is that new?14:28
openstackgerritRyan McCabe proposed openstack/tripleo-heat-templates master: Add SAF environment  https://review.opendev.org/69462314:28
mwhahahathe rewrite into python is14:28
*** surpatil has quit IRC14:29
mwhahahahttps://review.opendev.org/#/c/698620/14:29
Tenguerr..... wait. "-A INPUT -m comment --comment "999 drop all ipv4" -m conntrack --ctstate NEW -j ACCEPT"   accept, when it's saying "drop"?14:29
EmilienMyeah I know, I was wondering if the logging was new14:29
Tengualso, there are 2 rules after that one14:29
EmilienMmwhahaha: go back to PTO :P14:29
* mwhahaha doesn't want to have to catch up on email tomorrow14:29
EmilienMdelete them all14:30
TenguEmilienM: so logging was broken some months ago, I worked on that in order to make it back again - sooo yeah.14:30
cloudnullTengu ++ that rule doesn't seem right. the comment says drop but the jump is accept14:30
Tengucloudnull: yeah, and it should be at the far, far end I think.14:30
cloudnull++14:30
TenguEmilienM: in fact, the two "missing" rules are present, but for other IPs I think.14:30
EmilienMwait, the thing on the left is what we had before14:30
cloudnullI would expect that to be "-A INPUT -m comment --comment "999 drop all ipv4" -m conntrack --ctstate NEW -j DROP"14:31
EmilienMthe rules on the right is from a timeouted job14:31
Tengucloudnull: yup. Still, that's a cosmetic detail.14:31
mwhahahawe shouldn't drop btw14:31
mwhahahawe used to reject14:31
TenguEmilienM: care to check the IPs of the job matching the right one?=14:31
mwhahahawith icmp authorization prohibited or something14:31
EmilienMTengu: https://6965fd4aef581b711f1e-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf5.rackcdn.com/699505/1/check/tripleo-ci-centos-7-containers-undercloud-minion/eb9c291/logs/subnode-1/var/log/extra/ is the job that timeouts14:31
TenguEmilienM: since we apparently have 4 un-commented rules about 10.201.1 and 23.253 networks14:31
EmilienMfor the working one: https://b0f2eef64be29a19651b-3de1975357a6c165386fdc5736e590dc.ssl.cf1.rackcdn.com/699425/1/check/tripleo-ci-centos-7-containers-undercloud-minion/226b09e/logs/subnode-1/var/log/extra/network.txt.gz14:32
Tengu    inet 23.253.173.132/24 brd 23.253.173.255 scope global noprefixroute eth0     inet 10.210.1.132/19 brd 10.210.31.255 scope global noprefixroute eth114:32
EmilienMmwhahaha: we do reject14:32
EmilienMI see -A openstack-INPUT -j REJECT --reject-with icmp-host-prohibited14:32
TenguEmilienM: they are allowed....14:32
TenguEmilienM: both minion IPs are allowed in the firewall :/14:34
Tengusooo..... that's maybe not the issue?14:34
mwhahahahttps://b0f2eef64be29a19651b-3de1975357a6c165386fdc5736e590dc.ssl.cf1.rackcdn.com/699425/1/check/tripleo-ci-centos-7-containers-undercloud-minion/226b09e/logs/undercloud/var/log/extra/network.txt.gz14:34
mwhahahawe're missing 330614:34
mwhahahathat's teh bug14:34
* mwhahaha would like to stop having to repeat himself14:34
Tengunah14:34
Tengu-A INPUT -s 23.253.173.92/32 -j ACCEPT  <- accepts all from that IP14:35
Tengusame -A INPUT -s 10.210.1.132/32 -j ACCEPT14:35
mwhahahayou'd think14:35
Tenguthose two are attached to the minion node (subnode-1)14:35
Tengusupposed to accept both TCP and UDP on all ports, yes.14:35
mwhahahabut the ip is 192.168.24.x14:35
Tenguhmm so the wrong IP is used|pushed.14:36
mwhahahawhich we only allow snmp, ssh, memcache from14:36
mwhahahaplz compare https://1c854b43b98bfdb525a8-06ff0b77c4b7bc18f9f8408eaae15058.ssl.cf5.rackcdn.com/699019/2/check/tripleo-ci-centos-7-undercloud-containers/ab1a14b/logs/undercloud/var/log/extra/network.txt.gz14:36
mwhahaha3306 is there14:36
mwhahahait's missing from the rules14:37
* mwhahaha broken record14:37
Tenguyep, I see that - now the question is: why do we allow everything from the 2 other associated IPs?14:37
mwhahahabecause tunnel14:37
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-ansible master: Change drop action  https://review.opendev.org/69969214:37
mwhahahawe setup a vxlan tunnel for 192.168.24 traffic on multinode14:37
mwhahahait's a ci thing14:37
Tengucan't we allow all from that 192.168.24.x/24 ?14:37
mwhahahanot related tot his isue14:37
cloudnullmwhahaha Tengu that change will make it so we're adding the drop rules14:38
mwhahahai'm sure we could, the point being that teh rules are way off14:38
Tenguright. Didn't realized it was using a 3rd subnet at some point -.-.14:38
Tengupff.14:38
Tengucloudnull: drop|reject I think... ?14:39
cloudnullit looks like before the action plugin it was using drop, but we can change that to reject ?14:40
Tengucosmetics at that point.14:40
EmilienMmwhahaha: that was is from stable/stein14:40
Tengufact is, we should understand why it's missing a rule.14:40
EmilienMmwhahaha: your "plz compare" URL14:40
Tenguand if we miss some others.14:40
mwhahahaEmilienM: yes we've dropped rules over the cycles (for reasons unknown)14:40
cloudnullhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-firewall/defaults/main.yml#L61-L6314:40
EmilienMI looked at a job on master (before action plugin) and and there is no mysql14:40
TenguEmilienM: I think it was working because 192.168.24.X/32 had full access, no limitation as today.14:41
mwhahahaanyway we need to audit the rules for the undercloud, in theory there should be a 3306 rule14:42
TenguEmilienM: i.e. something is now injecting eth0 + eth1 IPs, but not the br-ex14:42
Tenguand, if we take back your diff, left one has only the br-ext IP, not eth0 nor eth1....14:42
Tenguquestion would be "how are those IPs provided", and check if something in the comprehension of those IPs changed lately...14:43
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-ansible master: Change drop action  https://review.opendev.org/69969214:43
cloudnullchecking a newly deployed undercloud from master I don't see a rule with port 330614:45
*** marios|call is now known as marios14:45
EmilienMcloudnull: right we had the rule in stein14:46
EmilienMlet's see when it started to disappear14:46
cloudnullI think this rule "-A INPUT -m comment --comment "999 drop all ipv4" -m conntrack --ctstate NEW -j ACCEPT" was allowing it work. we were accepting ALL traffic, not dropping it.14:46
mwhahahaso you "fixed" it uncovering an older bug around missing rules :D14:47
cloudnullwhich was a bug in the way the ansible task driven firewall rules were being created14:47
cloudnullso does that mean I get negative pushups ?14:48
cloudnull:P14:48
Tengucloudnull: makes sense as well14:48
Tengucloudnull: call it squats ;)14:48
cloudnullhahaha14:48
EmilienM-1 on negative pushups14:48
cloudnullLOL14:48
cloudnullto get the gate working we could push a patch up to recreate that bug ?14:48
cloudnullIE add a rule that accepts all traffic14:49
EmilienMno, we need to figureo ut why mysql isn't added14:49
cloudnullthat'd give us some time to go find / fix the real bug14:49
cloudnullok14:49
EmilienMI'm playing mwhahaha's broken record14:49
cloudnullhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/database/mysql-base.yaml#L71-L7914:51
cloudnullI see tht has the rule14:51
Tengucloudnull: apparently it doesn't apply for the minion IP/case - else we'd see a lot more rules right?14:52
EmilienMI looked at a job from Nov 21, and we were missing mysql rule as well14:52
*** sshnaidm has joined #tripleo14:53
* mwhahaha wanders off to PTO14:54
mwhahahagood luck :D14:54
EmilienMslacker14:54
EmilienMIt was there end of august14:54
EmilienMit disappeared somewhere in Sept/Oct14:54
*** TrevorV has joined #tripleo14:55
Tenguisn't it when things were moved to ansible for the firewall?14:55
EmilienMdciabrin_, bandini ^ by any chance, do you know why mysql iptables rule wouldn't be there on the undercloud anymore?14:55
EmilienMcloudnull, Tengu: when was the move again14:56
dciabrin_EmilienM, meh no idea14:56
bandiniEmilienM: erm not really no14:56
bandinidid we migrate to the ansible for firewall and maybe something is lurking in there?14:56
EmilienMhttps://review.opendev.org/#/c/677237/14:56
TenguEmilienM: not really sure, I know there were "some" delay, but I think it was around october... cloudnull ?14:56
EmilienMwas 2 weeks again14:57
EmilienM2w ago*14:57
Tenguoh. craps.14:57
Tenguso not the same period right14:57
Tengucloudnull: isn't there some kind of typo in the mysql-base maybe? for instance I don't see mention of port 4444 in the rules.15:00
Tengucloudnull: or maybe some missing include, or whatever...?15:01
yog_slagle,  could kindly give your review again :) for the patch related to setting reserved_huge_pages ... https://review.opendev.org/#/c/693994/ .. had made minor code change regarding spacing/format in code based on saravanan's review15:01
EmilienMI wonder if it's because the rule doesn't have the service name in it15:02
EmilienMso it get ignored15:02
Tengumaybe?15:02
Tenguat least, none of the rules that are defined ONLY in this file are applied.15:02
Tenguthere some others, but it's probably due to the fact they are defined in other templates.15:02
Tengulike port 87315:03
slagleyog_: done. looks like it hit the CI timeout currently under investigation, so will need to hold off on +A15:04
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: WIP - use service_name for mysql firewall rules  https://review.opendev.org/69969915:04
cloudnullTengu sorry was getting a coffee refill15:05
* Tengu glues cloudnull to his chair until issue is sorted out15:05
Tengu:)15:05
EmilienMmy patch should happen IMHO15:05
EmilienMI didn't know the rule name was restrictive but I suspect it is right now15:06
cloudnullTengu - https://github.com/openstack/tripleo-heat-templates/commit/50367fbe3563d34976deb377ed32b6f26aeca44f - looks like the initial move to the firewall role was nov 1815:06
TenguI think it might match the service_enabled list or something like that15:06
Tengucloudnull: yep. in the meanwhile EmilienM might have found the issue. And it looks like something with some sens in it15:06
EmilienMyeah I think that's the bug15:06
EmilienMbecause I see some other rules missing15:07
EmilienMlike ironic conductor TFTP15:07
yog_slagle, thank you for the review ;)15:07
Tenguuhu15:07
EmilienMthat's our bug15:07
EmilienMfirewall rules that are applied are only the ones with a proper service_name matching hieradata15:07
EmilienMif the string isn't a service_name of hieradata on the node, the rule is skipped15:08
Tenguyup. sounds like something15:08
*** jfrancoa has quit IRC15:08
Tenguprobably matchin [0-9]+\s<service_name>15:08
cloudnullwhere does that string matching happen ?15:08
EmilienMno idea yet but we'll find out15:08
Tenguheat template generation I suspect15:08
* EmilienM digging THT15:08
EmilienMbtw15:11
EmilienMhttps://6965fd4aef581b711f1e-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf5.rackcdn.com/699505/1/check/tripleo-ci-centos-7-containers-undercloud-minion/eb9c291/logs/undercloud/home/zuul/undercloud-ansible-T0VOEe/Undercloud/host_prep_tasks.yaml.txt.gz15:11
EmilienMyou can see that a lot of rules are missing in the tripleo_firewall_rules var15:11
*** ykarel is now known as ykarel|away15:11
cloudnullcould it be something with the yaql https://github.com/openstack/tripleo-heat-templates/blob/master/common/services/role.role.j2.yaml#L344-L352  ?15:11
EmilienMit's likely around these lines: https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/common/services/role.role.j2.yaml#L344-L35215:11
TenguEmilienM: seems to match the "service_name isn't matching" thoughts.15:11
Tenguouch... yaql shaving15:12
*** ramishra has joined #tripleo15:12
*** waleedm has quit IRC15:13
TenguEmilienM: no rule with a non-service_name are applied indeed. comments in the applied rules are indeed showing only "<order> <service_name> <ip-version>"15:15
Tengunot that the ip-version is probably useless since we have two separated commands, iptables for inet and ip6tables for inet6...15:15
EmilienMi wonder if it's because the mysql rules are in a base template15:15
TenguEmilienM: hmm... -A INPUT -p udp -m udp --dport 69 -m comment --comment "134 ironic conductor TFTP ipv4" -m conntrack --ctstate NEW -j ACCEPT15:16
Tenguit is actually present15:16
Tenguand this crashes the theory I think :/15:17
cloudnullthe FirewallRules yaql was modeled after AnsibleGroupVars so maybe both have similar issues ?15:17
EmilienMTengu: I think my theory is now, for the rules in a base template15:17
TenguEmilienM: ah. some kind of override?15:17
*** udesale has joined #tripleo15:17
*** whoami-rajat has quit IRC15:19
cloudnullEmilienM I see the rules in both the base and pacemaker templates - https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/database/mysql-pacemaker-puppet.yaml15:19
cloudnullhttps://github.com/openstack/tripleo-heat-templates/blob/master/deployment/database/mysql-pacemaker-puppet.yaml#L111-L12015:19
cloudnullcould that be causing the issue ?15:19
cloudnullthey're not in https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/database/mysql-container-puppet.yaml and https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/database/mysql-client.yaml15:20
EmilienMno15:20
EmilienMthat file isn't used on the undercloud15:20
EmilienMthe problem is that the yaql looks for firewall_rules in the imported templates15:20
EmilienMhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/common/services/role.role.j2.yaml#L344-L35215:21
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command.  https://review.opendev.org/69939115:21
cloudnullthat one is the same to what is being done in AnsibleGroupVars15:21
EmilienM(which doesn't mean AnsibleGroupVars is working :D)15:22
EmilienMI _think_ the problem is that we use the role_data15:22
EmilienMlet me try to reproduce locally15:23
cloudnulland GlobalConfigSettings MonitoringSubscriptionsConfig too15:23
cloudnullall are using the same style yql query15:23
*** jfrancoa has joined #tripleo15:24
*** csmart has joined #tripleo15:24
*** ssbarnea has joined #tripleo15:24
*** udesale has quit IRC15:25
*** udesale has joined #tripleo15:25
EmilienMchandankumar: we need to clear the gate IMHO15:25
EmilienMnow that we have identified the problem (at least we know where to look), we should not approve patches15:25
chandankumarEmilienM: yes, can we start abandoning then?15:26
*** mwhahaha sets mode: +o EmilienM15:26
EmilienMchandankumar: yes. Have oyu done it before?15:26
EmilienMmwhahaha: thx15:26
chandankumarEmilienM: nope, I donot have access to abandon button15:27
*** EmilienM changes topic to "CI Status: RED | Issue has been identified with broken firewall rules - DO NOT RECHECK - DO NOT +W | community irc meeting Tues@1400 UTC - tripleo-ci-community meeting Tues@1330 UTC | https://docs.openstack.org/tripleo-docs"15:27
EmilienMchandankumar: ok I'll do it asap15:27
EmilienMi'm also sending a note to the ML15:27
chandankumarhttps://review.opendev.org/#/c/699438/ https://review.opendev.org/#/c/697526/ https://review.opendev.org/#/c/697188/ https://review.opendev.org/#/c/699007/ https://review.opendev.org/#/c/696401/ https://review.opendev.org/#/c/698417/ https://review.opendev.org/#/c/698417/15:28
TenguEmilienM: I've cancelled my 2 patches in gate.15:28
chandankumarjobs are not started yet here15:28
Tenguhttps://review.opendev.org/#/c/699426/ https://review.opendev.org/#/c/699438/  are stopped just to be sure15:28
EmilienMchandankumar: I'll find them in zuul15:28
EmilienMno need to paste here15:28
cloudnullEmilienM its just the one job that's failing, the minion job. wouldn't it be better to make that one non-voting ?15:28
EmilienMmeh15:29
cloudnullseems the regular multi-node jobs are passing ?15:29
EmilienMyeah because we are lucky15:29
*** marios is now known as marios|call15:29
EmilienMnow let me file a bug, send an email and test a fix15:29
cloudnullfor sure, something is broken that needs fixing15:29
cloudnulljust didn't want to cause too much havoc :)15:30
cloudnullbut you're right, meh. all the current jobs are likely going to fail15:31
EmilienMand if we make minion non voting alex will not be super happy :D15:31
*** panda has quit IRC15:31
*** panda has joined #tripleo15:33
EmilienMhttps://bugs.launchpad.net/tripleo/+bug/185686415:33
openstackLaunchpad bug 1856864 in tripleo "Not all firewall rules are applied, leading to timeouts" [Critical,Triaged] - Assigned to Emilien Macchi (emilienm)15:33
ramishraEmilienM: Where do you see the minion logs? It was failing intermittently yesterday too, I could not find the logs then15:37
EmilienMramishra: https://6965fd4aef581b711f1e-c46dc4d37fef1869c0d0d51dc6a4d27f.ssl.cf5.rackcdn.com/699505/1/check/tripleo-ci-centos-7-containers-undercloud-minion/eb9c291/logs/subnode-1/var/log/containers/stdouts/heat_engine_db_sync.log.txt.gz15:37
*** holser has quit IRC15:40
*** holser has joined #tripleo15:40
ramishraEmilienM: ok, I was looking in the wrong place, wrongly assumed that it's installed from the undercloud node;)15:40
*** csmart has quit IRC15:46
*** ssbarnea has quit IRC15:46
openstackgerritAthlan-Guyot sofer proposed openstack/tripleo-upgrade master: Fix python3 compatibility during role adjustment.  https://review.opendev.org/69970915:48
openstackgerritCédric Jeanneret (Tengu) proposed openstack/tripleo-heat-templates master: Create a dedicated log file for healthchecks for collectd  https://review.opendev.org/69922615:49
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates master: mysql: move firewall_rules to mysql-container-puppet  https://review.opendev.org/69971215:50
EmilienMramishra: could you please look at ^15:50
EmilienMramishra: I'm wondering if we can do better, wrt the YAQL https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/common/services/role.role.j2.yaml#L344-L35215:50
*** yog_ has quit IRC15:52
*** marios|call is now known as marios15:54
cloudnullEmilienM ramishra - If we can come up with a better query we should also update FirewallRules, AnsibleGroupVars, GlobalConfigSettings, MonitoringSubscriptionsConfig - they're all the same basic YAQL.15:55
*** udesale has quit IRC15:56
EmilienMI tested my patch locally, it works15:56
cloudnullis there a good YAQL debugger ?15:56
EmilienMslagle: do you mind looking at https://review.opendev.org/699712 please15:57
slaglecloudnull: there's a shell, where you can load json data from a file, and then run queries against it15:57
slaglecloudnull: best i've found. it's all mostly guess and check anyway15:58
cloudnullslagle ++15:58
slagleEmilienM: looking15:58
EmilienMlol15:58
slagleEmilienM: it looks fine to me. they definitely need to be in the role_data for the service template. there's no "magic" inheritance16:00
EmilienMok16:00
EmilienMthen let's go with it16:00
EmilienMi'm purging the gate now16:00
EmilienMslagle++ thx for the double checking16:01
slagleyou could however pull them off the base template, similr to what is done with service_name16:01
slaglein case they need to be shared, so you only have to write it once16:01
ramishraslagle: I commented the same:)16:01
EmilienMin the case of mysql, it doesn't make sense16:01
EmilienMbecause they are overriden in mysql-galera I think16:02
EmilienMwith 104 mysql galera-bundle16:02
*** jainprasuk1996 has joined #tripleo16:04
EmilienMchandankumar: purging the gate now16:04
chandankumarEmilienM: thanks for taking care,16:05
chandankumarTengu: cloudnull EmilienM: I will be going offline from 20th Dec to 05th Jan16:05
cloudnullchandankumar enjoy your time off :D16:07
cloudnullEmilienM slagle are there other base templates that have firewall rules within them ?16:07
*** ksambor has quit IRC16:07
openstackgerritRonelle Landy proposed openstack/ansible-role-collect-logs master: Add functionality to sanitize collected logs  https://review.opendev.org/69199416:07
*** ksambor has joined #tripleo16:07
EmilienMcloudnull: not afik16:07
EmilienMI looked and couldn't find any beside mysql16:07
cloudnullrunning `find deployment -type f -name '*base*' -exec grep -l firewall_rules {} \; ` I dont see any that match the "base" naming convention16:07
cloudnullbut idk if that naming convention holds true across the stack16:08
EmilienMgate is cleared16:08
*** leanderthal has quit IRC16:09
*** chandankumar is now known as raukadah16:10
*** leanderthal has joined #tripleo16:10
EmilienMbandini: if you're still around, can you quickly look https://review.opendev.org/#/c/699712/16:11
EmilienMI'll approve if it pass CI16:11
*** lmiccini has quit IRC16:11
EmilienMand restore the gate16:11
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command.  https://review.opendev.org/69939116:12
bandiniEmilienM: on it16:12
cloudnullso i guess I'll go do some pushups: https://github.com/openstack/tripleo-heat-templates/blame/master/deployment/database/mysql-base.yaml#L71-L79 that came over with the firewall conversion. it used to be in "config_settings" which I guess does not have the same YAQL issues.16:12
EmilienMcloudnull: i told you16:12
EmilienM:D16:12
EmilienMraukadah: are you still around?16:13
EmilienMraukadah: unping16:13
raukadahEmilienM: yes, just lurking16:13
* raukadah hides then16:13
*** marios is now known as marios|out16:15
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939116:16
*** leanderthal has quit IRC16:16
ramishracloudnull: Did not see your msg about the debugger, you can use http://yaqluator.com/ too, I too will spend sometime tomorrow to see if it can be better16:16
cloudnullramishra is there a way to capture the entire blob from a deployment to run queries against in that online validator ?16:18
*** iurygregory has joined #tripleo16:20
ramishracloudnull: I mean you can load from a file or paste the json, but you need to paste what's passed in data to heat yaql function16:20
ramishracloudnull: If I understand your question.. late for me too;)16:21
cloudnullis there a way to retrieve a json blob with all of that heat data ?16:22
*** marios|out has quit IRC16:26
slaglecloudnull:  look at the stack outputs of the nested stacks that correspond to the service templates16:26
slagleidentify where what you're looking for gets passed around in the templates, identify the nested stack that corresponds to those templates, openstack stack show on those nested stacks16:27
openstackgerritMohammed Naser proposed openstack/diskimage-builder master: modprobe.d: use $TMP_MOUNT_PATH  https://review.opendev.org/69972216:27
*** waleedm has joined #tripleo16:33
openstackgerritMohammed Naser proposed openstack/diskimage-builder master: modprobe.d: use $TMP_MOUNT_PATH  https://review.opendev.org/69972216:42
openstackgerritRonelle Landy proposed openstack/tripleo-quickstart-extras master: Add tempest.api.compute.images test_delete_saving_image to skip  https://review.opendev.org/69962416:44
*** ed_b has joined #tripleo16:46
*** csmart has joined #tripleo16:47
*** ssbarnea has joined #tripleo16:47
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944816:49
openstackgerritAthlan-Guyot sofer proposed openstack/tripleo-upgrade master: Fix python3 compatibility during role adjustment.  https://review.opendev.org/69970916:49
*** waleedm_ has joined #tripleo16:52
*** lucasagomes has quit IRC16:52
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944816:53
*** waleedm has quit IRC16:54
*** shardy has joined #tripleo16:55
*** kopecmartin is now known as kopecmartin|off16:58
*** dtrainor has quit IRC17:08
*** dtrainor has joined #tripleo17:08
m1pon train/centos7 with custom prepare parameters and `push_destination: true`, deployment fails with docker on overcloud nodes not being able to pull some images. anybody seen this before?17:13
m1phttps://www.irccloud.com/pastebin/DoKAIRw7/17:13
m1pit happend with more images before, i deleted /var/lib/image-serve/v2/tripleotrain and recreated it with sudo openstack tripleo container image prepare, now it only happens for a few images17:15
m1pwhich is weird because I didn't modify anything, except using the undercloud registry17:15
*** artom has joined #tripleo17:17
*** rlandy is now known as rlandy|brb17:17
*** suuuper has quit IRC17:20
*** yprokule has quit IRC17:21
*** bandini has quit IRC17:21
*** rpittau is now known as rpittau|afk17:21
*** Chaserjim has quit IRC17:22
*** Chaserjim has joined #tripleo17:23
openstackgerritSagi Shnaidman proposed openstack/tripleo-quickstart-extras master: WIP: run ansible plugins on undercloud  https://review.opendev.org/69931417:23
*** gfidente is now known as gfidente|afk17:24
*** hberaud is now known as hberaud|gone17:26
*** ykarel|away has quit IRC17:26
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939117:33
*** jpena is now known as jpena|off17:36
*** panda has quit IRC17:36
openstackgerritDamien Ciabrini proposed openstack/tripleo-heat-templates master: Limit concurrency in container-puppet to image pull  https://review.opendev.org/69973717:37
*** panda has joined #tripleo17:39
*** psachin has quit IRC17:39
*** waleedm has joined #tripleo17:43
*** waleedm_ has quit IRC17:45
*** rlandy|brb is now known as rlandy17:46
openstackgerritDamien Ciabrini proposed openstack/tripleo-heat-templates master: Limit concurrency in container-puppet to image pull  https://review.opendev.org/69973717:51
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939117:54
*** chem_ has quit IRC17:55
*** rascasoft has quit IRC17:56
*** mcornea has quit IRC17:57
openstackgerritSagi Shnaidman proposed openstack/tripleo-quickstart-extras master: WIP: run ansible plugins on undercloud  https://review.opendev.org/69931417:58
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939118:02
*** derekh has quit IRC18:04
*** mcornea has joined #tripleo18:05
*** rfolco has quit IRC18:07
openstackgerritDaniel Bengtsson proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939118:07
*** Chaserjim has quit IRC18:12
*** Chaserjim has joined #tripleo18:12
openstackgerritDamien Ciabrini proposed openstack/tripleo-heat-templates master: Limit concurrency in container-puppet to image pull  https://review.opendev.org/69973718:17
*** yolanda__ is now known as yolanda18:18
*** tosky has quit IRC18:23
*** Goneri has quit IRC18:28
openstackgerritDamien Ciabrini proposed openstack/tripleo-heat-templates master: container-puppet: create containers sequentially to avoid race  https://review.opendev.org/69973718:37
*** tmazur has quit IRC18:38
openstackgerritDamien Ciabrini proposed openstack/tripleo-heat-templates master: Limit concurrency in container-puppet to image pull  https://review.opendev.org/69973718:40
openstackgerritDamien Ciabrini proposed openstack/tripleo-heat-templates master: container-puppet: create containers sequentially to avoid race  https://review.opendev.org/69980318:40
*** openstackgerrit has quit IRC18:43
*** amoralej is now known as amoralej|off18:44
*** rfolco has joined #tripleo18:52
*** waleedm has quit IRC18:56
*** waleedm has joined #tripleo18:57
*** sshnaidm is now known as sshnaidm|afk18:58
*** openstackgerrit has joined #tripleo18:58
openstackgerritSergii Golovatiuk proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939118:58
*** jainprasuk1996 has quit IRC19:01
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944819:01
*** mburned has joined #tripleo19:03
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944819:04
*** mcornea has quit IRC19:12
*** chem_ has joined #tripleo19:12
*** chem_ has quit IRC19:18
*** mcornea has joined #tripleo19:20
*** chem_ has joined #tripleo19:21
openstackgerritSergii Golovatiuk proposed openstack/tripleo-upgrade master: Fix python command and fix python3 compatiblity.  https://review.opendev.org/69939119:21
*** holser has quit IRC19:24
*** chem_ has quit IRC19:26
*** chem_ has joined #tripleo19:27
*** jbadiapa has quit IRC19:31
*** Goneri has joined #tripleo19:37
*** waleedm_ has joined #tripleo19:52
*** chem_ has quit IRC19:52
*** waleedm has quit IRC19:52
*** chem_ has joined #tripleo19:57
*** pkopec has quit IRC19:58
*** jpich has quit IRC20:01
*** waleedm_ has quit IRC20:08
TenguEmilienM: is gate happy again?20:14
openstackgerritKevin Carter (cloudnull) proposed openstack/tripleo-ansible master: Programatically generate ssh hosts lines  https://review.opendev.org/69950220:14
EmilienMTengu: not yet20:15
EmilienMbut soon20:15
EmilienMhttps://review.opendev.org/#/c/699712/ is in gate20:15
Tenguwhat was the issue? the yaql?20:15
EmilienMonce it merges, we should be good20:15
*** rf0lc0 has joined #tripleo20:15
Tenguoh. damn.20:15
Tenguthat was a tricky one :(20:16
*** rfolco has quit IRC20:17
Tenguanyway. will check the state of my patches tomorrow. One of them at least has been restored and will help gate/zuul with the /var/log/journal directory.20:18
Tengu'night all ;)20:19
openstackgerritMerged openstack/diskimage-builder master: modprobe.d: use $TMP_MOUNT_PATH  https://review.opendev.org/69972220:29
*** ramishra has quit IRC20:31
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Revert "Added for support for generating overcloud clouds.yaml"  https://review.opendev.org/69932920:31
openstackgerritEmilien Macchi proposed openstack/tripleo-heat-templates stable/train: mysql: move firewall_rules to mysql-container-puppet  https://review.opendev.org/69986620:32
*** slaweq has quit IRC20:36
openstackgerritSteve Baker proposed openstack/tripleo-heat-templates stable/train: Revert "Drop EC2MetadataIp parameter and its uses"  https://review.opendev.org/69913620:40
openstackgerritSteve Baker proposed openstack/tripleo-heat-templates stable/train: Optional enable undercloud nova-metadata-api  https://review.opendev.org/69859320:40
*** rf0lc0 has quit IRC20:41
openstackgerritEmilien Macchi proposed openstack/python-tripleoclient master: Implement utils.copy_clouds_yaml  https://review.opendev.org/69944820:42
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates master: DO-NOT-MERGE Test new ceph-container builds  https://review.opendev.org/56221320:42
openstackgerritSagi Shnaidman proposed openstack/ansible-role-collect-logs master: WIP: render UC ara results  https://review.opendev.org/69986720:42
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/train: DO-NOT-MERGE Test new ceph-container builds (OSP train)  https://review.opendev.org/69003620:42
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/train: DO-NOT-MERGE Test new ceph-container builds (OSP train)  https://review.opendev.org/69003620:42
openstackgerritSagi Shnaidman proposed openstack/tripleo-quickstart-extras master: WIP: run ansible plugins on undercloud  https://review.opendev.org/69931420:43
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/stein: DO-NOT-MERGE Test new ceph-container builds (OSP stein)  https://review.opendev.org/65693420:43
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates master: DO-NOT-MERGE Test new ceph-container builds  https://review.opendev.org/56221320:43
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/train: DO-NOT-MERGE Test new ceph-container builds (OSP train)  https://review.opendev.org/69003620:43
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/stein: DO-NOT-MERGE Test new ceph-container builds (OSP stein)  https://review.opendev.org/65693420:43
*** slaweq has joined #tripleo20:45
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/queens: DO-NOT-MERGE Test new ceph-container builds (OSP queens)  https://review.opendev.org/56221520:45
openstackgerritGiulio Fidente proposed openstack/tripleo-heat-templates stable/queens: DO-NOT-MERGE Test new ceph-container builds (OSP queens)  https://review.opendev.org/56221520:45
openstackgerritSteve Baker proposed openstack/tripleo-heat-templates stable/train: Revert "Drop EC2MetadataIp parameter and its uses"  https://review.opendev.org/69913620:47
openstackgerritSteve Baker proposed openstack/tripleo-heat-templates stable/train: Optional enable undercloud nova-metadata-api  https://review.opendev.org/69859320:47
*** iurygregory has quit IRC20:53
*** holser has joined #tripleo20:54
*** waleedm_ has joined #tripleo20:59
*** waleedm__ has joined #tripleo21:00
*** waleedm_ has quit IRC21:03
*** ayoung has joined #tripleo21:12
*** raildo has quit IRC21:16
openstackgerritToure Dunnon proposed openstack/tripleo-ansible master: [WIP] Add service management support.  https://review.opendev.org/68101721:16
*** rf0lc0 has joined #tripleo21:26
*** rf0lc0 has quit IRC21:26
openstackgerritRonelle Landy proposed openstack/tripleo-heat-templates stable/train: Create /var/log/journal directory during step-0  https://review.opendev.org/69943821:31
*** thrash has quit IRC21:35
*** thrash has joined #tripleo21:37
*** ansmith has quit IRC21:38
*** Chaserjim has quit IRC21:40
*** Chaserjim has joined #tripleo21:41
*** pcaruana has quit IRC21:54
*** saneax has quit IRC21:55
*** mcornea has quit IRC21:59
*** morazi has quit IRC22:02
*** dpawlik has quit IRC22:08
*** TrevorV has quit IRC22:10
*** jfrancoa has quit IRC22:10
*** chem_ has quit IRC22:11
*** nkinder has quit IRC22:12
*** Chaserjim has quit IRC22:17
*** Chaserjim has joined #tripleo22:18
openstackgerritJohn Fulton proposed openstack/tripleo-validations master: Introduce Ceph placement group validation  https://review.opendev.org/69467322:19
*** haleyb has quit IRC22:22
openstackgerritAlan Bishop proposed openstack/tripleo-common master: Add container images for DCN/Edge deployments  https://review.opendev.org/69987922:25
openstackgerritAlan Bishop proposed openstack/tripleo-heat-templates master: Add ability to deploy glance at DCN/Edge sites  https://review.opendev.org/69988022:25
*** haleyb has joined #tripleo22:26
openstackgerritSteve Baker proposed openstack/tripleo-heat-templates master: Revert "Optional enable undercloud nova-metadata-api"  https://review.opendev.org/69988122:36
*** ansmith has joined #tripleo22:44
*** saneax has joined #tripleo22:54
cloudnullanyone around able to give https://review.opendev.org/#/q/topic:fw-update+(status:open+OR+status:merged) a push23:02
*** tkajinam has joined #tripleo23:05
*** holser has quit IRC23:09
*** rcernin has joined #tripleo23:10
*** rlandy is now known as rlandy|bbl23:11
*** ccamacho has quit IRC23:23
*** saneax has quit IRC23:24
fultonjcloudnull: i'm reviewing them23:24
cloudnulltyvm23:25
fultonjcloudnull: i +2'd both23:27
cloudnullthanks!23:27
* fultonj looking at Emilien's email regarding not +w'ing though i think this is related to fixing that right?23:27
cloudnullthis is not23:28
cloudnullfixing a different bug23:28
fultonjhttp://lists.openstack.org/pipermail/openstack-discuss/2019-December/011671.html23:28
fultonjcloudnull: i won't +w those two then as per ^23:29
fultonjcloudnull: at least not tonight23:29
cloudnull++23:30
cloudnullno worries I appreciate the reviews23:30
fultonjnp23:30

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!