Tuesday, 2021-06-15

opendevreviewMerged openstack/tripleo-heat-templates stable/train: set ganesha idmap.conf file path and overrides  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79607600:20
opendevreviewMerged openstack/tripleo-common stable/victoria: Move rabbitmq healthcheck to something more modern  https://review.opendev.org/c/openstack/tripleo-common/+/79608001:54
opendevreviewMerged openstack/puppet-tripleo stable/wallaby: Add pcmk_host_list stonith-fence_compute-fence-nova  https://review.opendev.org/c/openstack/puppet-tripleo/+/79607901:54
opendevreviewMerged openstack/tripleo-validations master: Allow comments in variable files to be rendered in docs  https://review.opendev.org/c/openstack/tripleo-validations/+/79526101:54
opendevreviewMerged openstack/python-tripleoclient master: Adding EndpointNotFound exception during scale_down  https://review.opendev.org/c/openstack/python-tripleoclient/+/79512101:54
opendevreviewMerged openstack/tripleo-heat-templates stable/train: Correct metrics_qdr logging path and regex parsing  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79485001:54
opendevreviewSteve Baker proposed openstack/diskimage-builder master: Add a growvols utility for growing LVM volumes  https://review.opendev.org/c/openstack/diskimage-builder/+/79108302:16
opendevreviewMerged openstack/tripleo-heat-templates stable/train: Bump ovs and ovn versions to 2.15 for FFWD.  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79578602:48
opendevreviewMerged openstack/tripleo-heat-templates stable/train: Make UpgradeLeappDevelSkip per-role  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79560602:48
opendevreviewMerged openstack/tripleo-heat-templates stable/train: [train-only] Set leapp parameters to target RHEL release  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79421202:49
opendevreviewMerged openstack/tripleo-heat-templates stable/train: Unify cinder's volume and backup kolla_config settings  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79541302:50
opendevreviewRabi Mishra proposed openstack/tripleo-heat-templates master: Use merge strategy for EndpointMap  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79613703:48
*** ykarel|away is now known as ykarel04:18
opendevreviewSteve Baker proposed openstack/diskimage-builder master: Add a growvols utility for growing LVM volumes  https://review.opendev.org/c/openstack/diskimage-builder/+/79108304:33
opendevreviewMichele Baldessari proposed openstack/tripleo-common stable/ussuri: Move rabbitmq healthcheck to something more modern  https://review.opendev.org/c/openstack/tripleo-common/+/79622505:10
opendevreviewMichele Baldessari proposed openstack/puppet-tripleo stable/ussuri: Add pcmk_host_list stonith-fence_compute-fence-nova  https://review.opendev.org/c/openstack/puppet-tripleo/+/79622605:10
*** marios is now known as marios|ruck05:16
opendevreviewMichele Baldessari proposed openstack/tripleo-heat-templates master: OVN DBs clustering  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/77544406:06
opendevreviewMichele Baldessari proposed openstack/tripleo-heat-templates master: DNM CI test ovn-dbs-cluster-ansible THT service  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/78617806:06
*** ysandeep|out is now known as ysandeep06:09
opendevreviewJiri Podivin proposed openstack/validations-common master: DNM Potential fix  https://review.opendev.org/c/openstack/validations-common/+/79598706:17
*** iurygregory_ is now known as iurygregory06:19
*** jpena|off is now known as jpena06:34
opendevreviewHarald Jensås proposed openstack/tripleo-heat-templates stable/wallaby: Refactor OVN bridge MAC addresses  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79252206:40
opendevreviewMartin Schuppert proposed openstack/tripleo-heat-templates master: Simplify libvirt/qemu ssl certificates  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/78971806:59
*** rpittau|afk is now known as rpittau07:13
opendevreviewMerged openstack/tripleo-quickstart-extras master: Don't use disable-telemetry.yaml  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/79501807:15
opendevreviewMerged openstack/tripleo-heat-templates master: Set OS_CLOUD instead in stackrc  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79520307:15
opendevreviewMerged openstack/python-tripleoclient master: Fix overcloud node provide  https://review.opendev.org/c/openstack/python-tripleoclient/+/79592507:16
opendevreviewMerged openstack/tripleo-ansible stable/wallaby: Build ganesha idmap.conf file path and apply overrides  https://review.opendev.org/c/openstack/tripleo-ansible/+/79593607:16
opendevreviewMerged openstack/tripleo-heat-templates stable/wallaby: Set ganesha idmap.conf file path and overrides  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79587607:17
opendevreviewRabi Mishra proposed openstack/tripleo-quickstart master: Don't explicitly disable telemetry  https://review.opendev.org/c/openstack/tripleo-quickstart/+/79501907:18
*** ykarel is now known as ykarel|lunch07:38
opendevreviewMartin Schuppert proposed openstack/tripleo-docs master: Update cell v2 multicell doc  https://review.opendev.org/c/openstack/tripleo-docs/+/79638807:47
opendevreviewJose Luis Franco proposed openstack/tripleo-heat-templates stable/train: [Train-Only] Add leapp answer authselect_check.confirm.  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79295507:53
opendevreviewMerged openstack/tripleo-docs master: Document --work-dir  https://review.opendev.org/c/openstack/tripleo-docs/+/78301607:56
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: Neutorn: Explicitly set the default hepervisor name  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79640208:26
opendevreviewGiulio Fidente proposed openstack/tripleo-heat-templates master: Add post_upgrade_task and remove puppet-ceph pkg  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79640308:29
hjensastrivial change needs another review - https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79248109:20
bandinimarios|ruck: o/ a quick one. I am using quay.io/tripleomaster and current-tripleo as a tag. I noticed that the containers are about three months old. is that expected or am I doing something wrong here?09:52
opendevreviewFrancesco Pantano proposed openstack/tripleo-heat-templates master: DNM - Test Pending Ceph Pacific daemons in CI  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/77891509:53
marios|ruckbandini: which branch? sounds wrong though i mean we don't have somethign unpromoted for 3 months09:53
bandinimarios|ruck: I am using master afaict09:54
bandinimarios|ruck: but if I go https://quay.io/repository/tripleomaster/openstack-heat-engine?tab=tags and search for tripleo in the filter I only get current-tripleo and it is 3months old?09:55
marios|ruckbandini: ah ok... so the current value of current-tripleo is like https://trunk.rdoproject.org/centos8-master/current-tripleo/delorean.repo.md5 ee4aecfe06de7e8ca63aed041b3e42a8 for centos8 master09:56
marios|ruckbandini: and you can find that hash in https://quay.io/repository/tripleomaster/openstack-heat-engine?tab=tags if you search for it09:57
opendevreviewJiri Podivin proposed openstack/validations-libs master: Filling license info for Ansible and Pyflakes  https://review.opendev.org/c/openstack/validations-libs/+/79628009:57
*** ykarel|lunch is now known as ykarel09:57
bandinimarios|ruck: oh so I am not supposed to use the tag but I need to fetch it via https://trunk.rdoproject.org/centos8-master/current-tripleo/delorean.repo.md5 ?09:57
bandinithe tag == current-tripleo09:57
marios|ruckbandini: not sure what the actual current-tripleo on quay.io is or why it was tagged 3 months ago 09:57
bandinioh okay09:57
marios|ruckbandini: yeah in our jobs we 'resolve' what current-tripleo hash is and then we use that 09:58
bandiniack let me do that then. thanks!09:58
opendevreviewKamil Sambor proposed openstack/tripleo-heat-templates master: Enable DPDK OVS PMD Auto Load Balance  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/78793509:59
bandinimarios|ruck: but if we do not update the tag on quay then using the command 'openstack tripleo container image prepare default --local-push-destination --output-env-file /home/stack/containers-prepare-parameter.yaml' is broken?10:03
bandiniI mean I can tweak that yaml and put the hash in there I guess10:04
marios|ruckbandini: so there should be current-tripleo tagged things in quay.io but i don't know why it isn't there10:04
marios|ruckbandini: i can see the tag in rdo for example https://trunk.registry.rdoproject.org:8443/oapi/v1/namespaces/tripleomaster/imagestreamtags/10:04
marios|ruckeg         "name": "openstack-zaqar-wsgi:current-tripleo",10:05
marios|ruck        "creationTimestamp": "2021-06-13T21:38:27Z"10:05
marios|ruckbandini: it seems like our promoter is only tagging things in rdo registry but not quay.io 10:05
bandiniso just quay is missing it10:05
bandiniaye10:05
marios|ruckbandini: the promoter has been worked on by many different people in the last while and we are still having some problems with it10:06
marios|ruckbandini: this sounds like one of them 10:06
marios|ruckcc bandini akahat fyi folks do you know why we are not tagging promoted containers with current-tripleo in quay.io? ^^^ 10:06
marios|ruckbandini: so for now try and use the hash directly, or consider using rdo registry if you can instead of quay10:07
bandiniack, thanks marios|ruck 10:07
opendevreviewLukas Bezdicka proposed openstack/tripleo-heat-templates stable/train: [ffwd] Introduce hybrid mode for ovs neutron agent  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79525210:15
fultonjhjensas: After running `openstack overcloud node provision --network-config` is it expected that users should run `openstack overcloud network provision` in order to generate a deployed-networks.yaml to pass to `openstack overcloud deploy`?11:01
opendevreviewyatin proposed openstack/tripleo-quickstart master: [DNM] Test ovs2.15 with upgrades  https://review.opendev.org/c/openstack/tripleo-quickstart/+/79642411:04
hjensasfultonj: you would run `openstack overcloud network provision` first, then `openstack overcloud node provision --network-config`11:05
fultonjhjensas: ah ok, thanks11:05
fultonjhjensas: `openstack overcloud node provision --network-config` works for me! But I noticed that if I don't call my stack "overcloud" then it fails11:06
fultonjwith an error like the one here: http://paste.openstack.org/show/806610/11:06
fultonjdo you want me to open a bug for that?11:06
hjensasyes, thats  a bug. I'm surprised, I use a custom stack name in some of my test envs as well.11:09
hjensasfultonj: please open a bug. :)11:10
fultonjhjensas: ok, but i'll make sure i can reproduce one more time first11:10
fultonj"It also assumes overcloud networks are pre-deployed using the openstack overcloud network provision command and the deployed networks environment file is ~/overcloud-networks-deployed.yaml."11:12
fultonjhttps://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#deploying-the-overcloud11:12
fultonjfor my first question I obviously overlooked this part of the manual11:13
marios|ruckbandini: fyi should be fixed now arxcruz re-added a broken cron job that copied the promoted content to quay.io 11:13
hjensasfultonj: oh, openstack overcloud node provision has a '--stack' argument, it defaults to overcloud. Is that the issue? You need to use the arg, or set OVERCLOUD_STACK_NAME in the environment?11:15
hjensashttps://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v2/overcloud_node.py#L234-L23811:15
fultonjhjensas: i did pass --stack overcloud-011:15
hjensasfultonj: ok, then it's a bug :)11:16
fultonjbut "PLAY [Overcloud Node Network Config]" returned "skipping: no hosts matched"11:16
hjensasfultonj: So what ended up in the inventory?11:20
fultonjonly the undercloud11:20
*** sshnaidm|afk is now known as sshnaidm11:21
hjensasfultonj: if you do "openstack port list --long", is the stack name tag set on the ports?11:21
fultonji'll need to reprouce it and then I can run that command11:22
hjensasfultonj: ok, I will try to reproduce it as well.11:23
fultonji have been deploying without `openstack overcloud network provision` first11:23
fultonjso I'll run it first to see if it makes any diff11:23
*** ysandeep is now known as ysandeep|afk11:24
hjensasysandeep: fs039 passed on https://review.opendev.org/c/openstack/tripleo-quickstart/+/795251, I think thats good to go? And we can move on with the BMC OS::Heat::None in OVB to save us some resource usage.11:24
bandinimarios|ruck: awesome, thanks!11:24
*** jpena is now known as jpena|lunch11:25
arxcruzbandini: all set now 11:28
bandinithanks arxcruz!11:37
opendevreviewJiri Podivin proposed openstack/validations-libs master: Default value for the '--group' param  https://review.opendev.org/c/openstack/validations-libs/+/79642611:41
opendevreviewJiri Podivin proposed openstack/validations-libs master: Default value for the '--group' param  https://review.opendev.org/c/openstack/validations-libs/+/79642611:43
*** amoralej is now known as amoralej|lunch11:50
opendevreviewShnaidman Sagi (Sergey) proposed openstack/tripleo-ansible stable/wallaby: Use direct import from collection  https://review.opendev.org/c/openstack/tripleo-ansible/+/79623211:59
opendevreviewShnaidman Sagi (Sergey) proposed openstack/tripleo-heat-templates stable/wallaby: Use community.general ansible collection instead of modules  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79643312:00
opendevreviewJose Luis Franco proposed openstack/tripleo-upgrade master: Make --config-heat available for FFWD automation.  https://review.opendev.org/c/openstack/tripleo-upgrade/+/79643012:04
opendevreviewJose Luis Franco proposed openstack/tripleo-upgrade stable/victoria: Make --config-heat available for FFWD automation.  https://review.opendev.org/c/openstack/tripleo-upgrade/+/79643412:06
opendevreviewJose Luis Franco proposed openstack/tripleo-upgrade stable/ussuri: Make --config-heat available for FFWD automation.  https://review.opendev.org/c/openstack/tripleo-upgrade/+/79643512:07
opendevreviewJose Luis Franco proposed openstack/tripleo-upgrade stable/train: Make --config-heat available for FFWD automation.  https://review.opendev.org/c/openstack/tripleo-upgrade/+/79643612:07
opendevreviewMerged openstack/tripleo-heat-templates stable/wallaby: Fix typo in ceilometer-write-qdr environment file  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79538612:09
opendevreviewSorin Sbârnea proposed openstack/ansible-role-collect-logs master: Refactor zuul jobs  https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/79627812:13
*** jpena|lunch is now known as jpena12:17
rlandycloudnull: hey - good morning ... can you review https://bugs.launchpad.net/tripleo/+bug/1931995 - I think this is why rhos-17 is still failing on using the wrong registry12:20
fultonjhjensas: i can no longer reproduce 12:21
fultonjhjensas: so i don't need to open a bug (good news)12:22
opendevreviewSorin Sbârnea proposed openstack/ansible-role-collect-logs master: Refactor zuul jobs  https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/79627812:28
*** ysandeep|afk is now known as ysandeep12:33
hjensasfultonj: ok, good. :)12:36
cloudnullMornings. 12:45
cloudnullrlandy looking. 12:46
rlandycloudnull: thanks - even if we are passing the right vars, this explains why we are still seeing a failure so early considering http://git.app.eng.bos.redhat.com/git/openstack-tripleo-common.git/tree/container-images/tripleo_containers.yaml?h=rhos-17.0-trunk-patches12:47
Tenguhard-coded tag or something?12:47
*** amoralej|lunch is now known as amoralej12:51
opendevreviewOwen McGonagle proposed openstack/tripleo-validations master: [WIP] remove using containers-prepare-parameter.yaml  https://review.opendev.org/c/openstack/tripleo-validations/+/79606112:52
hjensassoo, I install Wallaby - but I get: DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi12:58
hjensaswhich means Xena Ironic ...12:58
pleimerHi all, can I please get a +CR and Workflow on this cherry-pick? Thanks! https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79402813:01
opendevreviewMerged openstack/tripleo-heat-templates stable/victoria: Fix typo in ceilometer-write-qdr environment file  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79538713:03
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role  https://review.opendev.org/c/openstack/tripleo-validations/+/78969813:21
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Moving setting validation from nova_event_callback  https://review.opendev.org/c/openstack/tripleo-validations/+/79486613:23
opendevreviewFrancesco Pantano proposed openstack/tripleo-heat-templates master: Set tripleo_cephadm rbd mirror vars  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79628313:25
cloudnullrlandy I'm sitting here scratching my head trying to track down https://bugs.launchpad.net/tripleo/+bug/1931995 - slagle could this be related to some of the ephemeral heat work?13:26
Tengucloudnull: maybe container-images/tripleo_containers.yaml:- imagename: quay.io/tripleomaster/openstack-heat-api:current-tripleo13:28
Tenguit's in tripleo-common13:28
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role  https://review.opendev.org/c/openstack/tripleo-validations/+/78969813:28
rlandyright so it's pulling the default ... marios left some links13:28
Tenguoh. wait. there's an associated .j2 - that one is probably a generated thing13:28
cloudnullyeah that file looks pretty standard 13:29
rlandyfor some reason it's not taking the generated values13:29
rlandyneither in wallaby/master nor 1713:29
cloudnulland I see our templated values looks normal for heat 13:29
cloudnull"{{namespace}}/{{name_prefix}}heat-engine{{name_suffix}}:{{tag}}"13:29
rlandyin periodic jobs,13:29
Tenguyeah, was also looking at that file, cloudnull ... weird.13:30
rlandyit should get containers from the rdo trunk registry13:30
rlandyat least that is what container-prepare-parameters states13:30
Tenguin tripleoclient there's tripleoclient/constants.py:DEFAULT_CONTAINER_TAG = "current-tripleo"13:31
Tenguguess it's overridden13:31
Tengubut yeah, we can see it's running ephemeral heat (Using ephemeral heat for stack operation13:32
Tengumaybe a missing override in the new code?13:32
cloudnullhttps://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/constants.py#L43-L5413:32
Tenguha! so it gets generated before we can override... ?13:33
cloudnullwhile that code path isn't particularly new, i suspect that's the issues 13:33
cloudnullwe're likely using a new code path given the ephemeral change 13:33
cloudnullTengu I think so 13:34
cloudnullhttps://github.com/openstack/python-tripleoclient/commit/0f9fbfa58d10db9f78860fe22a2e2e771630da6f13:34
Tenguhttps://github.com/openstack/python-tripleoclient/commit/0f9fbfa58d10db9f78860fe22a2e2e771630da6f#diff-b11b57bc4b70550876aa592303b19031bdf2efb75f10a9b036d0f0d5e86b1559R118-R124   that one should probably build the container image name instead of relying on the constants13:35
cloudnullso I suspect we need a way to feed the heat container data into the client, or we need the client to read the renderered file and parse it 13:35
cloudnullTengu++ 13:35
matbumarios|ruck: hey man, sorry for bugging you about that, but we need your great power one the releases: https://review.opendev.org/q/topic:%22vf%252F1.2.0%22+(status:open%20OR%20status:merged)13:35
Tenguat the same time... a constant is supposed to be a constant....13:36
Tenguso there's little to no sense to allow constant override :D13:36
Tenguo_O apparently that constants.DEFAULT_CONTAINER_TAG isn't used at all across tripleoclient ?!13:37
Tengunor is it in tripleo-common..... what?13:37
hjensasTengu: DEFAULT_CONTAINER_TAG is used to build DEFAULT_HEAT_CONTAINER, DEFAULT_HEAT_API_CONTAINER and DEFAULT_HEAT_ENGINE_CONTAINER13:39
rlandyso really, this would have gone undetected upstream until it tripped us up in rhos-1713:40
Tenguhjensas: yeah - nothing else apparently, and this creates an issue at some point13:40
hjensasTengu: the ones it builds is then used tripleoclient/v1/tripleo_launch_heat.py:2613:40
Tenguso those default_heat_* might even be dropped at some point imho..13:40
Tenguhjensas: yeah, saw it already. thing is, it's a wrong tag for the CI, leading to master/wallaby issues in the periodic runs (see https://bugs.launchpad.net/tripleo/+bug/1931995)13:41
Tengurlandy: that's a nasty issue :(. going undetected like that :((13:42
hjensasTengu: yeah, I guess CI should set the args? --heat-container-api-image --heat-container-engine-image --heat-container-image ... and yeah I guess downsteam as well. :.O13:43
Tenguor heat image should take the container tag as configured somewhere in the CI - else we'll face some issues with osp13:44
rlandyhjensas: hmmm ... so we can set and override with  --heat-container-api-image --heat-container-engine-image --heat-container-image to the deploy command?13:44
Tengu(since osp will also cry with "current-tripleo" - should take the things from the generate-container thing)13:44
Tengurlandy: there are those options, yeah...... still, not sure this is the right way.13:45
hjensasrlandy: tripleo launch heat command has those args, the constants are used for the defaults of those args.13:45
* hjensas 2nd's Tengu's not sure this is the way ... 13:45
rlandywe can at least try those option13:45
Tengurlandy: as a work-around in order to unlock the periodics, yeah13:46
rlandyTengu: the only blocked release is 1713:46
Tengustill the "right" way would be to use the container image prepare generated content13:46
rlandyalthough that's becoming a bug deal ahead of el913:46
* rlandy will leave upstream for the better solution ... at least until it falls over13:47
* rlandy tries with 1713:47
hjensasrlandy: hm, overcloud deploy command seem to only have --heat-container-api-image and --heat-container-engine-image args. Not the --heat-container-image13:49
rlandyhjensas: testing that anyways just to see if it takes and gets us by the first failure13:51
marios|ruckmatbu: ack but in call will check in bit13:51
opendevreviewJames Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79648113:57
opendevreviewJiri Podivin proposed openstack/validations-libs master: Default value of the constructor parameter  https://review.opendev.org/c/openstack/validations-libs/+/79648213:58
cloudnullyeah I think we're going to need to sync with slagle on that. 14:00
cloudnullI suspect there's some nuance here 14:00
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role  https://review.opendev.org/c/openstack/tripleo-validations/+/78969814:08
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: Neutron: Explicitly set the default hepervisor name  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79640214:09
opendevreviewSandeep Yadav proposed openstack/tripleo-quickstart-extras master: build-test-package: Set distro for downstream case  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/79648614:13
Tengucloudnull: add you as well as slagle to the CIX card (and joined it). hjensas feel free to join it if you want, of course :)14:14
Tengu*added you14:14
Tengu... EoD is close - my brain's dying in the heat here.14:14
matbumarios|ruck: no pb14:16
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role  https://review.opendev.org/c/openstack/tripleo-validations/+/78969814:17
marios|ruckmatbu: just voted on the libs one i voted on the -common this morning14:17
marios|ruckmatbu: fyi you can just do them both in one review next time if you like it is easier for you14:18
matbumarios|ruck: hoo right /me stupid :)14:18
matbudouble CI double work sorry14:18
marios|ruckmatbu: ack np :) not stupid but yeah easier to get reviewer attention from the release team too maybe 14:19
marios|ruckmatbu: there is no 'right' here some people might prefer independent review for each repo14:19
marios|ruckmatbu: we always do the tripleo ones in the same review 14:19
matbumarios|ruck: yep i actually prepare the v-libs review on friday, waiting one patch to land... and monday morning, my mind wasn't very clear i guess :)14:20
opendevreviewPaul Leimer proposed openstack/tripleo-heat-templates stable/victoria: Add option for enabling rsyslog reopenOnTruncate  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79643714:25
*** rpittau is now known as rpittau|afk14:29
opendevreviewFrancesco Pantano proposed openstack/tripleo-heat-templates master: WIP - Moving scenario004 to cephadm  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/77335514:30
opendevreviewJuan Badia Payno proposed openstack/tripleo-ansible stable/victoria: BnR Test NFS server conectivity & ubi-minimal container image  https://review.opendev.org/c/openstack/tripleo-ansible/+/79644114:38
opendevreviewJuan Badia Payno proposed openstack/tripleo-heat-templates stable/victoria: Added the posibility of skipping the NFS ping test on the rear installation  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79644214:40
opendevreviewJuan Badia Payno proposed openstack/tripleo-ansible stable/wallaby: BnR Added a nfs validation when the nfs server is installed  https://review.opendev.org/c/openstack/tripleo-ansible/+/79644314:43
opendevreviewJuan Badia Payno proposed openstack/tripleo-ansible stable/victoria: BnR Added a nfs validation when the nfs server is installed  https://review.opendev.org/c/openstack/tripleo-ansible/+/79644414:44
opendevreviewJuan Badia Payno proposed openstack/tripleo-ansible stable/victoria: BnR Added a nfs validation when the nfs server is installed  https://review.opendev.org/c/openstack/tripleo-ansible/+/79644414:45
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the switch_vlans module  https://review.opendev.org/c/openstack/tripleo-validations/+/79649914:53
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the network_environment module  https://review.opendev.org/c/openstack/tripleo-validations/+/79650014:54
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the verify_profiles module  https://review.opendev.org/c/openstack/tripleo-validations/+/79650214:56
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Moving setting validation from nova_event_callback  https://review.opendev.org/c/openstack/tripleo-validations/+/79486614:56
*** ykarel_ is now known as ykarel14:56
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the ceph_pools_pg_protection module  https://review.opendev.org/c/openstack/tripleo-validations/+/79650314:56
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the ovs_dpdk_pmd_cpus_check module.  https://review.opendev.org/c/openstack/tripleo-validations/+/79650514:57
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the icmp_ping module.  https://review.opendev.org/c/openstack/tripleo-validations/+/79650614:58
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the node_disk module.  https://review.opendev.org/c/openstack/tripleo-validations/+/79650714:59
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the pacemaker module  https://review.opendev.org/c/openstack/tripleo-validations/+/79650815:00
sshnaidmcloudnull, hi, can you please review/merge in your time? https://review.opendev.org/q/topic:%22collections-everywhere%22+(status:open%20OR%20status:merged)15:00
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the check_flavors module  https://review.opendev.org/c/openstack/tripleo-validations/+/79650915:00
opendevreviewJiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the ip_range module.  https://review.opendev.org/c/openstack/tripleo-validations/+/79651015:01
weshay|ruckFYI.. 15:08
weshay|ruck2021-06-15 12:21:26.261455 | ubuntu-bionic | ERROR: Cannot install -r /home/zuul/src/opendev.org/openstack/tripleo-heat-templates/requirements.txt (line 8) because these package versions have conflicting dependencies.15:08
weshay|ruck2021-06-15 12:21:26.261540 | ubuntu-bionic |15:08
weshay|ruck2021-06-15 12:21:26.261629 | ubuntu-bionic | The conflict is caused by:15:08
weshay|ruck2021-06-15 12:21:26.261669 | ubuntu-bionic |     tripleo-common 11.7.0 depends on python-zaqarclient>=1.0.015:08
weshay|ruck2021-06-15 12:21:26.261707 | ubuntu-bionic |     The user requested (constraint) python-zaqarclient===1.12.015:08
weshay|ruck2021-06-15 12:21:26.261725 | ubuntu-bionic |15:08
opendevreviewDaniel Alvarez proposed openstack/tripleo-heat-templates master: [ovn metadata] Add agent report option  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79651215:09
*** jpena is now known as jpena|off15:18
bogdandoTengu: there is heat_container_image config for custom image 15:18
bogdandooh, hjensas already mentioned that15:19
hjensas(╯°□°)╯︵ ┻━┻, I'm hitting https://bugs.launchpad.net/tripleo/+bug/1931995 as well I think.15:29
hjensasWhen I install a Wallby undercloud, I end up with a0f84bc37951  quay.io/tripleomaster/openstack-ironic-conductor:current-tripleo15:29
hjensasI don't run any 'container image prepare' command. Just 'tripleo-repos -b wallaby current ceph' to get the Wallaby repos. 15:32
mwhahahadid we not properly patch wallaby defaults15:33
mwhahahanope15:34
* mwhahaha sighs and fixes15:34
hjensasI get 'tag: current-tripleo' if run openstack tripleo container image prepare default --local-push-destination --output-env-file /home/centos/containers-prepare-parameter.yaml15:35
mwhahahawhen we cut stable branches we have to patch teh branch with the wallaby stuff15:35
mwhahahaweshay|ruck, marios|ruck: what's the correct namespace for wallaby?15:36
hjensasmeh, ok please go ahead I can review.15:36
mwhahahaquay.io/tripleowallaby?15:36
marios|ruckmwhahaha: should be tripleowallaby according to https://opendev.org/openstack/tripleo-quickstart/src/commit/141194c402da021975ffe6e93c4d5acfa966dfe8/config/release/tripleo-ci/CentOS-8/wallaby.yml#L26 15:37
mwhahahathen there needs to be a downstream patch for whatever that namespace is15:39
opendevreviewAlex Schultz proposed openstack/tripleo-common stable/wallaby: [Wallaby-only] Update default container namespace for wallaby  https://review.opendev.org/c/openstack/tripleo-common/+/79651615:39
weshay|ruckmwhahaha, https://hub.docker.com/u/tripleowallaby15:40
* weshay|ruck looks at quay15:40
weshay|ruck40415:40
weshay|ruckdang it15:40
*** ysandeep is now known as ysandeep|out15:41
marios|ruckweshay|ruck: there was an issue with the copy quay script apparently and arxcruz had to fix a cron job 15:42
weshay|ruckmwhahaha, fixing now15:42
marios|ruckweshay|ruck: see google chat 15:42
weshay|ruckk15:42
marios|ruckweshay|ruck: so quay wasnt in sync15:42
marios|ruckweshay|ruck: like current-tripleo was 3 months old15:42
weshay|ruckya.. chatting about it now15:43
bandiniyeah i hit that one15:50
mwhahahaneed to make sure that gets done when we cut stable releases15:51
*** amoralej is now known as amoralej|off15:53
opendevreviewSofer Athlan-Guyot proposed openstack/tripleo-heat-templates stable/train: Update, avoid task skipping by directly importing step file.  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79651815:53
mwhahahameh lint15:53
opendevreviewAlex Schultz proposed openstack/tripleo-common stable/wallaby: [Wallaby-only] Update default container namespace for wallaby  https://review.opendev.org/c/openstack/tripleo-common/+/79651615:54
*** marios|ruck is now known as marios|out15:57
opendevreviewShnaidman Sagi (Sergey) proposed openstack/tripleo-quickstart-extras master: Add option to build collection github PRs  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/79652215:59
weshay|ruckmwhahaha, getting populated now https://quay.io/organization/tripleowallaby16:03
mwhahahak16:03
mwhahahawe don't hit it in ci because we always build16:03
weshay|ruckya16:03
weshay|ruckjust for users and devs.. pffff16:03
hjensasweshay|ruck: how long does it take for it to populate? 16:09
weshay|ruckit's pretty quick.. arxcruz wrote it in go.. pretty zippy16:10
weshay|ruckarxcruz, you get through ironic?16:10
*** ricolin_ is now known as ricolin16:26
opendevreviewMerged openstack/tripleo-heat-templates stable/train: Fix typo in ceilometer-write-qdr environment file  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79538916:46
opendevreviewMerged openstack/puppet-tripleo master: Clear last dependency on puppet-ceph from Manila manifest  https://review.opendev.org/c/openstack/puppet-tripleo/+/79629316:46
opendevreviewMerged openstack/puppet-tripleo stable/wallaby: Introduce nova virtlogd wrapper  https://review.opendev.org/c/openstack/puppet-tripleo/+/79514816:47
mwhahahacloudnull: have you ever messed with the default ansible runner inventory handling?  Do you know if you can do something like inventory/file.yaml or does it need to be extensionless?17:00
cloudnullI think it has to be extensionless if you use the runner path 17:07
mwhahaha:(17:07
fultonjhjensas: after generating deployed-{network,metal}.yaml w/ `opentsack overcloud network provision` and `openstack overcloud node provision --network-config` and passing -e deployed-{network,metal}.yaml to my overcloud deploy, it fails looking for rendered port templates; any ideas? http://paste.openstack.org/show/80664117:07
mwhahahacloudnull: ok i'll poke at it. unfortunatley our code assumes an extension17:08
opendevreviewJames Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79648117:09
hjensasfultonj: you passed the network_data.yaml used with opentsack overcloud network provision as the -n option to the overcloud deploy command?17:09
cloudnullthis is how we handle it in the client https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L360-L37517:09
cloudnullhttps://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L63717:10
cloudnullso I guess it "should"-tm work if you pass it full path to the file 17:10
fultonjhjensas: yes, here's my deploy command http://paste.openstack.org/show/806642/ 17:10
mwhahahacloudnull: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventories.py#L117-L13917:10
mwhahahacloudnull: that's the one i think i need to update because i want to generate it corectly to the config download dir17:11
cloudnull++17:11
bandinifultonj, hjensas: I have the exact same issue (fwiw)17:11
fultonjthanks bandini17:11
opendevreviewJames Slagle proposed openstack/tripleo-docs master: Document DeployedServerPortMap deprecation  https://review.opendev.org/c/openstack/tripleo-docs/+/79652517:12
hjensasbandini: fultonj: oh, I think it's hard-coding to /usr/share/openstack-tripleo-heat-templates in the generated environments.17:13
hjensasbandini: fultonj: I always edit them with sed, see: https://github.com/hjensas/homelab/blob/master/labs/ovb-ipv4-routed/overcloud/deploy_baremetal.sh#L917:13
*** gfidente is now known as gfidente|afk17:14
hjensasbandini: fultonj: It would be good to add a optional --templates argument to these commands so that it would do that automatically. Or maby a bigger hammer that replace anything /usr/share/openstack-tripleo-heat-templates to what's set as --tempaltes on the deploy command.17:15
fultonjhjensas: thanks, i'm sed'ing my genereated files to the correct path and about to re-test17:16
bandinii'll check tomorrow in my env17:16
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role  https://review.opendev.org/c/openstack/tripleo-validations/+/78969817:18
weshay|ruckmwhahaha, hjensas https://quay.io/organization/tripleowallaby should be sane.. sorry about that17:20
weshay|ruck*should*17:20
mwhahahak17:20
fultonjhjensas: thanks that fixed my issue. heat stack is now creating.17:28
*** ricolin_ is now known as ricolin17:32
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-validations master: Moving setting validation from nova_event_callback  https://review.opendev.org/c/openstack/tripleo-validations/+/79486617:34
weshay|ruckanbanerj|rover, http://pastebin.test.redhat.com/97191317:45
opendevreviewDouglas Viroel proposed openstack/tripleo-repos master: Add tripleo-yum-config ansible module  https://review.opendev.org/c/openstack/tripleo-repos/+/79652918:02
opendevreviewDouglas Viroel proposed openstack/tripleo-repos master: Add tripleo-yum-config ansible module  https://review.opendev.org/c/openstack/tripleo-repos/+/79652918:04
sshnaidmmwhahaha, do you know maybe, how do we ensure container-puppet-rabbitmq finishes before container rabbitmq_bootstrap starts? Both of them in step 118:13
mwhahahasshnaidm: they run at different imes18:18
mwhahahacontainer puppet tasks are seperate from container management18:18
mwhahahahttps://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps-tasks.yaml#L83-L11518:19
opendevreviewwes hayutin proposed openstack/openstack-tempest-skiplist master: add wallaby to negvolumetest skip  https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/79653018:20
mwhahahasshnaidm: that's why we force detach to false as well, https://review.opendev.org/c/openstack/tripleo-ansible/+/791317/16/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py so they should all finish before we run any other containers18:22
sshnaidmmwhahaha, you run it in threads, right?18:39
mwhahahasshnaidm: yes but they run at different execution times18:39
mwhahahapuppet-container-* are run all together but are seperate from the bootstrap container execution18:40
sshnaidmmwhahaha, yeah, when I use API it seems like bootstrap container starts before puppet container is finished: https://logserver.rdoproject.org/63/34063/2/check/tripleo-ci-centos-8-standalone-podman-ansible/07854ca/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz18:43
sshnaidmI wonder when it's leaking..18:43
mwhahahasshnaidm: create via the api detaches always i assume18:44
mwhahahaso it doesn't wait like it does when you execute via cli18:44
mwhahahaif detach: false, you'd need to poll the api to wait for the container to finish18:45
sshnaidmprobably, although in cli it was holding.. will check again18:46
mwhahaha2021-06-15 16:08:35.251096 | fa163edc-7451-7d19-62e2-0000000013ad |     TIMING | tripleo_container_manage : Create containers managed by Podman for /var/lib/tripleo-config/container-puppet-config/step_1 | standalone | 0:15:01.887043 | 3.29s18:47
mwhahahai think that's the task and the process takes longer than 3 seconds which would mean the api just returns after being executed18:48
opendevreviewAlan Bishop proposed openstack/tripleo-common master: WIP: tcib: clean up cinder packages  https://review.opendev.org/c/openstack/tripleo-common/+/79653118:49
sshnaidmmwhahaha, yeah, tested now, it just sends a request, work in terminal only18:55
sshnaidmmwhahaha, so for working with API need to add task that checks all of them finished18:57
sshnaidmsomething like that https://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps-tasks.yaml#L3918:57
mwhahahawe used to do that and it was terribly inefficient18:57
mwhahahabut yea18:57
mwhahahawe'd need a module that can be looped until a state is reached18:58
sshnaidmmwhahaha, it's podman_container_info actually19:00
mwhahahadoe sit take a list of containers?19:00
* mwhahaha doens't remember19:00
sshnaidmyep19:00
mwhahahak19:00
sshnaidmeither to add to your module option "wait until all is exited"19:00
mwhahahait'd be more efficient to add it to my module19:01
mwhahahathough it's needed for both19:01
mwhahaha(i think)19:01
mwhahahabecause we assume that things like bootstrap container launching don't move on to the next step 19:01
mwhahahabecause we have a start order in the container configs within a step19:01
mwhahahabasically if detach: false, we need to add a wait condition19:02
mwhahahaadded into https://review.opendev.org/c/openstack/tripleo-ansible/+/791317/16/tripleo_ansible/ansible_plugins/modules/tripleo_container_manage.py somewhere19:03
sshnaidmI think better to come with other option than "detach" if it doesn't work well with API.19:03
sshnaidmjust "wait_for_finish" or kind of19:03
mwhahahai mean that's the flag19:03
mwhahahano it needs to be in that module19:03
mwhahahabecause it needs to be handled for start order19:04
mwhahahahttps://review.opendev.org/c/openstack/tripleo-ansible/+/791317/16/tripleo_ansible/ansible_plugins/modules/tripleo_container_manage.py#34419:04
mwhahahathat needs to wait for all containers in a start order to complete before moving on to the next one19:04
mwhahahaand exit if detach: false19:04
sshnaidmyeah, will figure this out19:07
opendevreviewJames Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79648119:16
opendevreviewJames Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79648119:17
opendevreviewAlex Schultz proposed openstack/python-tripleoclient master: [WIP] Import task core into tripleoclient  https://review.opendev.org/c/openstack/python-tripleoclient/+/79653319:37
opendevreviewAlex Schultz proposed openstack/python-tripleoclient master: Drop mistralclient from requirements  https://review.opendev.org/c/openstack/python-tripleoclient/+/79653419:41
opendevreviewAlex Schultz proposed openstack/python-tripleoclient master: [WIP] Import task core into tripleoclient  https://review.opendev.org/c/openstack/python-tripleoclient/+/79653319:43
opendevreviewMerged openstack/openstack-tempest-skiplist master: add wallaby to negvolumetest skip  https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/79653019:57
opendevreviewAlex Schultz proposed openstack/python-tripleoclient master: [WIP] Import task core into tripleoclient  https://review.opendev.org/c/openstack/python-tripleoclient/+/79653320:02
opendevreviewRonelle Landy proposed openstack/tripleo-quickstart master: Update centos 8 dep pieline to run with compose repos  https://review.opendev.org/c/openstack/tripleo-quickstart/+/79653620:03
rlandyweshay|ruck: ^^20:03
* weshay|ruck looks20:03
mwhahahaweshay|ruck, rlandy: https://review.opendev.org/c/openstack/tripleo-common/+/796516 plz4me20:06
rlandydone20:08
slaweqweshay|ruck hi, can You check https://review.opendev.org/c/openstack/tripleo-heat-templates/+/783932 when You will have few minutes? Thx in advance20:10
weshay|ruckslaweq, what are you doing awake?20:12
slaweqweshay|ruck it's not that late for me, only 10pm :)20:13
slaweqI'm watching match and checking my opened reviews ;)20:13
weshay|ruckladies and gentleman.. I give EmilienM 2.020:14
weshay|ruckI give you20:14
slaweqweshay|ruck You mean me? No, I'm definitely not as good as EmilienM :)20:18
EmilienMwhat did I break again?20:18
weshay|ruckslaweq, you are much better looking at least20:19
slaweq:D20:19
opendevreviewJames Slagle proposed openstack/python-tripleoclient master: Copy the deployment archive to /var/lib/tripleo  https://review.opendev.org/c/openstack/python-tripleoclient/+/79653720:25
opendevreviewOwen McGonagle proposed openstack/tripleo-validations master: [WIP] remove using containers-prepare-parameter.yaml  https://review.opendev.org/c/openstack/tripleo-validations/+/79606120:26
opendevreviewMerged openstack/tripleo-quickstart-extras master: Include component repo in image builds  https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/79583820:31
fultonjredeployed my undercloud ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi.20:31
mwhahahafultonj: you have master containers with wallaby20:32
fultonji'm using master, not wallaby though20:32
mwhahahayou're missing teh THT patch to remove iscsi20:32
mwhahaharelated ML [rdo-users] Error importing node definition on undercloud Wallaby20:33
mwhahahahttps://review.opendev.org/c/openstack/tripleo-heat-templates/+/74947520:33
fultonjso get that patch and re-run undercloud install?20:34
fultonjthanks mwhahaha for identifying the root cuase20:34
mwhahahathat landed back in feb20:34
mwhahahaso not certain how you don't have that20:35
mwhahahathere might be another bug somewhere. stevebaker may know20:36
* fultonj checking /usr/share/openstack-tripleo-heat-templates/ on my new undercloud20:36
fultonji have that patch already20:37
mwhahahasounds like there's a bug somewhere else then20:37
mwhahahabut we shouldn't be referencing iscsi anymore20:37
fultonji built an undercloud on master 8 hours ago without this problem20:38
fultonjthis new one has the issue20:38
* fultonj looks into manually telling ironic to not use iscsi20:39
mwhahahafultonj: do you have https://review.opendev.org/c/openstack/python-tripleoclient/+/79552020:40
opendevreviewAlex Schultz proposed openstack/python-tripleoclient stable/wallaby: Remove iscsi from IronicEnabledDeployInterfaces  https://review.opendev.org/c/openstack/python-tripleoclient/+/79645120:40
fultonjpython3-tripleoclient-16.0.1-0.20210520134358.e86bccd.el8.noarch20:42
mwhahahaso no based on date20:42
mwhahahaare you using current-tripleo instead of current-tripleo-dev?20:43
fultonjcurrent-tripleo20:46
mwhahahayea so you'd need a promotion20:46
mwhahahaif running master it's better to use current-tripleo-dev20:46
fultonjok, thanks. i'll rebuild with current-tripleo-dev20:46
mwhahahabut that does hightlight we haven't had a promotion lately. weshay|ruck are we almost 30 days behind on master?20:51
*** sshnaidm is now known as sshnaidm|afk21:15
opendevreviewHarald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs  https://review.opendev.org/c/openstack/python-tripleoclient/+/79654521:40
opendevreviewHarald Jensås proposed openstack/tripleo-ansible master: %%_USER_THT_ROOT_%% replaces static THT path  https://review.opendev.org/c/openstack/tripleo-ansible/+/79654621:40
hjensasfultonj: you may want to test ^^ to avoid sed'ing the environment files manually. (re the issue we discussed earlier.)21:41
weshay|ruckmwhahaha, upstream integration promoted a couple days ago21:43
weshay|ruckmwhahaha, you are referring to the component in tripleo master for rdo21:43
opendevreviewMerged openstack/tripleo-heat-templates master: Add OVNAvailabilityZone to improve UX  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/78602021:43
weshay|ruckmwhahaha, and you are correct.. but most tripleo packages come through current anyway.. https://trunk.rdoproject.org/centos8/component/tripleo/c1/52/c1527ca9fcd5d2a50af896e2335b0af992d7a94b_2ecfbcb5/21:44
weshay|ruckwe'll get it promoted21:44
opendevreviewHarald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs  https://review.opendev.org/c/openstack/python-tripleoclient/+/79654521:45
weshay|ruckupgrade job is blocking21:48
weshay|ruckcan waive21:48
opendevreviewMerged openstack/tripleo-heat-templates master: Add service defined ansible_group_vars to RoleGroupVars  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79613521:50
opendevreviewMerged openstack/tripleo-heat-templates master: Add map merge strategy for {{role.name}}Parameters  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/79613621:59
hjensasslagle: if you are around, this Wallaby backport https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792522, removes use of OS::Neutron::Net and OS::Neutron::Port with OVN deployments.22:06
opendevreviewHarald Jensås proposed openstack/tripleo-ansible master: %%_USER_THT_ROOT_%% replaces static THT path  https://review.opendev.org/c/openstack/tripleo-ansible/+/79654622:26
opendevreviewHarald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs  https://review.opendev.org/c/openstack/python-tripleoclient/+/79654522:41
opendevreviewHarald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs  https://review.opendev.org/c/openstack/python-tripleoclient/+/79654522:50
stevebakerhjensas: hey are you still about?23:35
hjensasstevebaker: yes, just about to call it a night. Whats up?23:36
stevebakerhjensas: I'd like to use the provision playbook thing to run the growvols script, but it should basically be mandatory to run with fixed defaults in most cases. But sometimes defaults will be different, and it should only run for whole-disk images. I'm just pondering how to make it just work without any extra provision yaml required in the common case23:39
stevebakerhjensas: https://review.opendev.org/c/openstack/diskimage-builder/+/79108323:39
stevebakerhjensas: so no real questions right now, I'm just pondering the options23:43
hjensasstevebaker: I have a patch up to refactor the execution of the playbook applying network configuration. https://review.opendev.org/c/openstack/python-tripleoclient/+/794017/9/tripleoclient/utils.py#287623:44
hjensasstevebaker: you could call a playbook there, before the Network config playbook.23:45
hjensasstevebaker: Alternatively you could make it a composable service in THT that always run? In either case I guess the playbook could check for LVM/whole-disk image by inspecting the deployed instance?23:46
stevebakeryeah, it could run regardless, and be a noop if there is no lvm23:47
stevebakerthat refactor is good23:47
stevebakerok, I'll start by writing the playbook then we can decide how best to wire it in23:48
hjensasnecessary since I'm adding support to overcloud deploy command in that patch series23:48
stevebakerI think running it early as possible is best, but its not a huge deal23:49
hjensasquestion is also how you should wire in setting custom vars for a growvols playbook.23:53
hjensasthe generic ansible_playbook interface has the 'extra_vars' that can be set per-playbook in the deployment yaml23:53
hjensasthere is 'network_config': key in the deployment yaml, setting the nic-config template etc. It may make sense to ass a 'storage_config' key. 23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!