opendevreview | Merged openstack/tripleo-heat-templates stable/train: set ganesha idmap.conf file path and overrides https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796076 | 00:20 |
---|---|---|
opendevreview | Merged openstack/tripleo-common stable/victoria: Move rabbitmq healthcheck to something more modern https://review.opendev.org/c/openstack/tripleo-common/+/796080 | 01:54 |
opendevreview | Merged openstack/puppet-tripleo stable/wallaby: Add pcmk_host_list stonith-fence_compute-fence-nova https://review.opendev.org/c/openstack/puppet-tripleo/+/796079 | 01:54 |
opendevreview | Merged openstack/tripleo-validations master: Allow comments in variable files to be rendered in docs https://review.opendev.org/c/openstack/tripleo-validations/+/795261 | 01:54 |
opendevreview | Merged openstack/python-tripleoclient master: Adding EndpointNotFound exception during scale_down https://review.opendev.org/c/openstack/python-tripleoclient/+/795121 | 01:54 |
opendevreview | Merged openstack/tripleo-heat-templates stable/train: Correct metrics_qdr logging path and regex parsing https://review.opendev.org/c/openstack/tripleo-heat-templates/+/794850 | 01:54 |
opendevreview | Steve Baker proposed openstack/diskimage-builder master: Add a growvols utility for growing LVM volumes https://review.opendev.org/c/openstack/diskimage-builder/+/791083 | 02:16 |
opendevreview | Merged openstack/tripleo-heat-templates stable/train: Bump ovs and ovn versions to 2.15 for FFWD. https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795786 | 02:48 |
opendevreview | Merged openstack/tripleo-heat-templates stable/train: Make UpgradeLeappDevelSkip per-role https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795606 | 02:48 |
opendevreview | Merged openstack/tripleo-heat-templates stable/train: [train-only] Set leapp parameters to target RHEL release https://review.opendev.org/c/openstack/tripleo-heat-templates/+/794212 | 02:49 |
opendevreview | Merged openstack/tripleo-heat-templates stable/train: Unify cinder's volume and backup kolla_config settings https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795413 | 02:50 |
opendevreview | Rabi Mishra proposed openstack/tripleo-heat-templates master: Use merge strategy for EndpointMap https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796137 | 03:48 |
*** ykarel|away is now known as ykarel | 04:18 | |
opendevreview | Steve Baker proposed openstack/diskimage-builder master: Add a growvols utility for growing LVM volumes https://review.opendev.org/c/openstack/diskimage-builder/+/791083 | 04:33 |
opendevreview | Michele Baldessari proposed openstack/tripleo-common stable/ussuri: Move rabbitmq healthcheck to something more modern https://review.opendev.org/c/openstack/tripleo-common/+/796225 | 05:10 |
opendevreview | Michele Baldessari proposed openstack/puppet-tripleo stable/ussuri: Add pcmk_host_list stonith-fence_compute-fence-nova https://review.opendev.org/c/openstack/puppet-tripleo/+/796226 | 05:10 |
*** marios is now known as marios|ruck | 05:16 | |
opendevreview | Michele Baldessari proposed openstack/tripleo-heat-templates master: OVN DBs clustering https://review.opendev.org/c/openstack/tripleo-heat-templates/+/775444 | 06:06 |
opendevreview | Michele Baldessari proposed openstack/tripleo-heat-templates master: DNM CI test ovn-dbs-cluster-ansible THT service https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786178 | 06:06 |
*** ysandeep|out is now known as ysandeep | 06:09 | |
opendevreview | Jiri Podivin proposed openstack/validations-common master: DNM Potential fix https://review.opendev.org/c/openstack/validations-common/+/795987 | 06:17 |
*** iurygregory_ is now known as iurygregory | 06:19 | |
*** jpena|off is now known as jpena | 06:34 | |
opendevreview | Harald Jensås proposed openstack/tripleo-heat-templates stable/wallaby: Refactor OVN bridge MAC addresses https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792522 | 06:40 |
opendevreview | Martin Schuppert proposed openstack/tripleo-heat-templates master: Simplify libvirt/qemu ssl certificates https://review.opendev.org/c/openstack/tripleo-heat-templates/+/789718 | 06:59 |
*** rpittau|afk is now known as rpittau | 07:13 | |
opendevreview | Merged openstack/tripleo-quickstart-extras master: Don't use disable-telemetry.yaml https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/795018 | 07:15 |
opendevreview | Merged openstack/tripleo-heat-templates master: Set OS_CLOUD instead in stackrc https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795203 | 07:15 |
opendevreview | Merged openstack/python-tripleoclient master: Fix overcloud node provide https://review.opendev.org/c/openstack/python-tripleoclient/+/795925 | 07:16 |
opendevreview | Merged openstack/tripleo-ansible stable/wallaby: Build ganesha idmap.conf file path and apply overrides https://review.opendev.org/c/openstack/tripleo-ansible/+/795936 | 07:16 |
opendevreview | Merged openstack/tripleo-heat-templates stable/wallaby: Set ganesha idmap.conf file path and overrides https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795876 | 07:17 |
opendevreview | Rabi Mishra proposed openstack/tripleo-quickstart master: Don't explicitly disable telemetry https://review.opendev.org/c/openstack/tripleo-quickstart/+/795019 | 07:18 |
*** ykarel is now known as ykarel|lunch | 07:38 | |
opendevreview | Martin Schuppert proposed openstack/tripleo-docs master: Update cell v2 multicell doc https://review.opendev.org/c/openstack/tripleo-docs/+/796388 | 07:47 |
opendevreview | Jose Luis Franco proposed openstack/tripleo-heat-templates stable/train: [Train-Only] Add leapp answer authselect_check.confirm. https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792955 | 07:53 |
opendevreview | Merged openstack/tripleo-docs master: Document --work-dir https://review.opendev.org/c/openstack/tripleo-docs/+/783016 | 07:56 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: Neutorn: Explicitly set the default hepervisor name https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796402 | 08:26 |
opendevreview | Giulio Fidente proposed openstack/tripleo-heat-templates master: Add post_upgrade_task and remove puppet-ceph pkg https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796403 | 08:29 |
hjensas | trivial change needs another review - https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792481 | 09:20 |
bandini | marios|ruck: o/ a quick one. I am using quay.io/tripleomaster and current-tripleo as a tag. I noticed that the containers are about three months old. is that expected or am I doing something wrong here? | 09:52 |
opendevreview | Francesco Pantano proposed openstack/tripleo-heat-templates master: DNM - Test Pending Ceph Pacific daemons in CI https://review.opendev.org/c/openstack/tripleo-heat-templates/+/778915 | 09:53 |
marios|ruck | bandini: which branch? sounds wrong though i mean we don't have somethign unpromoted for 3 months | 09:53 |
bandini | marios|ruck: I am using master afaict | 09:54 |
bandini | marios|ruck: but if I go https://quay.io/repository/tripleomaster/openstack-heat-engine?tab=tags and search for tripleo in the filter I only get current-tripleo and it is 3months old? | 09:55 |
marios|ruck | bandini: ah ok... so the current value of current-tripleo is like https://trunk.rdoproject.org/centos8-master/current-tripleo/delorean.repo.md5 ee4aecfe06de7e8ca63aed041b3e42a8 for centos8 master | 09:56 |
marios|ruck | bandini: and you can find that hash in https://quay.io/repository/tripleomaster/openstack-heat-engine?tab=tags if you search for it | 09:57 |
opendevreview | Jiri Podivin proposed openstack/validations-libs master: Filling license info for Ansible and Pyflakes https://review.opendev.org/c/openstack/validations-libs/+/796280 | 09:57 |
*** ykarel|lunch is now known as ykarel | 09:57 | |
bandini | marios|ruck: oh so I am not supposed to use the tag but I need to fetch it via https://trunk.rdoproject.org/centos8-master/current-tripleo/delorean.repo.md5 ? | 09:57 |
bandini | the tag == current-tripleo | 09:57 |
marios|ruck | bandini: not sure what the actual current-tripleo on quay.io is or why it was tagged 3 months ago | 09:57 |
bandini | oh okay | 09:57 |
marios|ruck | bandini: yeah in our jobs we 'resolve' what current-tripleo hash is and then we use that | 09:58 |
bandini | ack let me do that then. thanks! | 09:58 |
opendevreview | Kamil Sambor proposed openstack/tripleo-heat-templates master: Enable DPDK OVS PMD Auto Load Balance https://review.opendev.org/c/openstack/tripleo-heat-templates/+/787935 | 09:59 |
bandini | marios|ruck: but if we do not update the tag on quay then using the command 'openstack tripleo container image prepare default --local-push-destination --output-env-file /home/stack/containers-prepare-parameter.yaml' is broken? | 10:03 |
bandini | I mean I can tweak that yaml and put the hash in there I guess | 10:04 |
marios|ruck | bandini: so there should be current-tripleo tagged things in quay.io but i don't know why it isn't there | 10:04 |
marios|ruck | bandini: i can see the tag in rdo for example https://trunk.registry.rdoproject.org:8443/oapi/v1/namespaces/tripleomaster/imagestreamtags/ | 10:04 |
marios|ruck | eg "name": "openstack-zaqar-wsgi:current-tripleo", | 10:05 |
marios|ruck | "creationTimestamp": "2021-06-13T21:38:27Z" | 10:05 |
marios|ruck | bandini: it seems like our promoter is only tagging things in rdo registry but not quay.io | 10:05 |
bandini | so just quay is missing it | 10:05 |
bandini | aye | 10:05 |
marios|ruck | bandini: the promoter has been worked on by many different people in the last while and we are still having some problems with it | 10:06 |
marios|ruck | bandini: this sounds like one of them | 10:06 |
marios|ruck | cc bandini akahat fyi folks do you know why we are not tagging promoted containers with current-tripleo in quay.io? ^^^ | 10:06 |
marios|ruck | bandini: so for now try and use the hash directly, or consider using rdo registry if you can instead of quay | 10:07 |
bandini | ack, thanks marios|ruck | 10:07 |
opendevreview | Lukas Bezdicka proposed openstack/tripleo-heat-templates stable/train: [ffwd] Introduce hybrid mode for ovs neutron agent https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795252 | 10:15 |
fultonj | hjensas: After running `openstack overcloud node provision --network-config` is it expected that users should run `openstack overcloud network provision` in order to generate a deployed-networks.yaml to pass to `openstack overcloud deploy`? | 11:01 |
opendevreview | yatin proposed openstack/tripleo-quickstart master: [DNM] Test ovs2.15 with upgrades https://review.opendev.org/c/openstack/tripleo-quickstart/+/796424 | 11:04 |
hjensas | fultonj: you would run `openstack overcloud network provision` first, then `openstack overcloud node provision --network-config` | 11:05 |
fultonj | hjensas: ah ok, thanks | 11:05 |
fultonj | hjensas: `openstack overcloud node provision --network-config` works for me! But I noticed that if I don't call my stack "overcloud" then it fails | 11:06 |
fultonj | with an error like the one here: http://paste.openstack.org/show/806610/ | 11:06 |
fultonj | do you want me to open a bug for that? | 11:06 |
hjensas | yes, thats a bug. I'm surprised, I use a custom stack name in some of my test envs as well. | 11:09 |
hjensas | fultonj: please open a bug. :) | 11:10 |
fultonj | hjensas: ok, but i'll make sure i can reproduce one more time first | 11:10 |
fultonj | "It also assumes overcloud networks are pre-deployed using the openstack overcloud network provision command and the deployed networks environment file is ~/overcloud-networks-deployed.yaml." | 11:12 |
fultonj | https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/provisioning/baremetal_provision.html#deploying-the-overcloud | 11:12 |
fultonj | for my first question I obviously overlooked this part of the manual | 11:13 |
marios|ruck | bandini: fyi should be fixed now arxcruz re-added a broken cron job that copied the promoted content to quay.io | 11:13 |
hjensas | fultonj: oh, openstack overcloud node provision has a '--stack' argument, it defaults to overcloud. Is that the issue? You need to use the arg, or set OVERCLOUD_STACK_NAME in the environment? | 11:15 |
hjensas | https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/v2/overcloud_node.py#L234-L238 | 11:15 |
fultonj | hjensas: i did pass --stack overcloud-0 | 11:15 |
hjensas | fultonj: ok, then it's a bug :) | 11:16 |
fultonj | but "PLAY [Overcloud Node Network Config]" returned "skipping: no hosts matched" | 11:16 |
hjensas | fultonj: So what ended up in the inventory? | 11:20 |
fultonj | only the undercloud | 11:20 |
*** sshnaidm|afk is now known as sshnaidm | 11:21 | |
hjensas | fultonj: if you do "openstack port list --long", is the stack name tag set on the ports? | 11:21 |
fultonj | i'll need to reprouce it and then I can run that command | 11:22 |
hjensas | fultonj: ok, I will try to reproduce it as well. | 11:23 |
fultonj | i have been deploying without `openstack overcloud network provision` first | 11:23 |
fultonj | so I'll run it first to see if it makes any diff | 11:23 |
*** ysandeep is now known as ysandeep|afk | 11:24 | |
hjensas | ysandeep: fs039 passed on https://review.opendev.org/c/openstack/tripleo-quickstart/+/795251, I think thats good to go? And we can move on with the BMC OS::Heat::None in OVB to save us some resource usage. | 11:24 |
bandini | marios|ruck: awesome, thanks! | 11:24 |
*** jpena is now known as jpena|lunch | 11:25 | |
arxcruz | bandini: all set now | 11:28 |
bandini | thanks arxcruz! | 11:37 |
opendevreview | Jiri Podivin proposed openstack/validations-libs master: Default value for the '--group' param https://review.opendev.org/c/openstack/validations-libs/+/796426 | 11:41 |
opendevreview | Jiri Podivin proposed openstack/validations-libs master: Default value for the '--group' param https://review.opendev.org/c/openstack/validations-libs/+/796426 | 11:43 |
*** amoralej is now known as amoralej|lunch | 11:50 | |
opendevreview | Shnaidman Sagi (Sergey) proposed openstack/tripleo-ansible stable/wallaby: Use direct import from collection https://review.opendev.org/c/openstack/tripleo-ansible/+/796232 | 11:59 |
opendevreview | Shnaidman Sagi (Sergey) proposed openstack/tripleo-heat-templates stable/wallaby: Use community.general ansible collection instead of modules https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796433 | 12:00 |
opendevreview | Jose Luis Franco proposed openstack/tripleo-upgrade master: Make --config-heat available for FFWD automation. https://review.opendev.org/c/openstack/tripleo-upgrade/+/796430 | 12:04 |
opendevreview | Jose Luis Franco proposed openstack/tripleo-upgrade stable/victoria: Make --config-heat available for FFWD automation. https://review.opendev.org/c/openstack/tripleo-upgrade/+/796434 | 12:06 |
opendevreview | Jose Luis Franco proposed openstack/tripleo-upgrade stable/ussuri: Make --config-heat available for FFWD automation. https://review.opendev.org/c/openstack/tripleo-upgrade/+/796435 | 12:07 |
opendevreview | Jose Luis Franco proposed openstack/tripleo-upgrade stable/train: Make --config-heat available for FFWD automation. https://review.opendev.org/c/openstack/tripleo-upgrade/+/796436 | 12:07 |
opendevreview | Merged openstack/tripleo-heat-templates stable/wallaby: Fix typo in ceilometer-write-qdr environment file https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795386 | 12:09 |
opendevreview | Sorin Sbârnea proposed openstack/ansible-role-collect-logs master: Refactor zuul jobs https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/796278 | 12:13 |
*** jpena|lunch is now known as jpena | 12:17 | |
rlandy | cloudnull: hey - good morning ... can you review https://bugs.launchpad.net/tripleo/+bug/1931995 - I think this is why rhos-17 is still failing on using the wrong registry | 12:20 |
fultonj | hjensas: i can no longer reproduce | 12:21 |
fultonj | hjensas: so i don't need to open a bug (good news) | 12:22 |
opendevreview | Sorin Sbârnea proposed openstack/ansible-role-collect-logs master: Refactor zuul jobs https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/796278 | 12:28 |
*** ysandeep|afk is now known as ysandeep | 12:33 | |
hjensas | fultonj: ok, good. :) | 12:36 |
cloudnull | Mornings. | 12:45 |
cloudnull | rlandy looking. | 12:46 |
rlandy | cloudnull: thanks - even if we are passing the right vars, this explains why we are still seeing a failure so early considering http://git.app.eng.bos.redhat.com/git/openstack-tripleo-common.git/tree/container-images/tripleo_containers.yaml?h=rhos-17.0-trunk-patches | 12:47 |
Tengu | hard-coded tag or something? | 12:47 |
*** amoralej|lunch is now known as amoralej | 12:51 | |
opendevreview | Owen McGonagle proposed openstack/tripleo-validations master: [WIP] remove using containers-prepare-parameter.yaml https://review.opendev.org/c/openstack/tripleo-validations/+/796061 | 12:52 |
hjensas | soo, I install Wallaby - but I get: DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi | 12:58 |
hjensas | which means Xena Ironic ... | 12:58 |
pleimer | Hi all, can I please get a +CR and Workflow on this cherry-pick? Thanks! https://review.opendev.org/c/openstack/tripleo-heat-templates/+/794028 | 13:01 |
opendevreview | Merged openstack/tripleo-heat-templates stable/victoria: Fix typo in ceilometer-write-qdr environment file https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795387 | 13:03 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role https://review.opendev.org/c/openstack/tripleo-validations/+/789698 | 13:21 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Moving setting validation from nova_event_callback https://review.opendev.org/c/openstack/tripleo-validations/+/794866 | 13:23 |
opendevreview | Francesco Pantano proposed openstack/tripleo-heat-templates master: Set tripleo_cephadm rbd mirror vars https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796283 | 13:25 |
cloudnull | rlandy I'm sitting here scratching my head trying to track down https://bugs.launchpad.net/tripleo/+bug/1931995 - slagle could this be related to some of the ephemeral heat work? | 13:26 |
Tengu | cloudnull: maybe container-images/tripleo_containers.yaml:- imagename: quay.io/tripleomaster/openstack-heat-api:current-tripleo | 13:28 |
Tengu | it's in tripleo-common | 13:28 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role https://review.opendev.org/c/openstack/tripleo-validations/+/789698 | 13:28 |
rlandy | right so it's pulling the default ... marios left some links | 13:28 |
Tengu | oh. wait. there's an associated .j2 - that one is probably a generated thing | 13:28 |
cloudnull | yeah that file looks pretty standard | 13:29 |
rlandy | for some reason it's not taking the generated values | 13:29 |
rlandy | neither in wallaby/master nor 17 | 13:29 |
cloudnull | and I see our templated values looks normal for heat | 13:29 |
cloudnull | "{{namespace}}/{{name_prefix}}heat-engine{{name_suffix}}:{{tag}}" | 13:29 |
rlandy | in periodic jobs, | 13:29 |
Tengu | yeah, was also looking at that file, cloudnull ... weird. | 13:30 |
rlandy | it should get containers from the rdo trunk registry | 13:30 |
rlandy | at least that is what container-prepare-parameters states | 13:30 |
Tengu | in tripleoclient there's tripleoclient/constants.py:DEFAULT_CONTAINER_TAG = "current-tripleo" | 13:31 |
Tengu | guess it's overridden | 13:31 |
Tengu | but yeah, we can see it's running ephemeral heat (Using ephemeral heat for stack operation | 13:32 |
Tengu | maybe a missing override in the new code? | 13:32 |
cloudnull | https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/constants.py#L43-L54 | 13:32 |
Tengu | ha! so it gets generated before we can override... ? | 13:33 |
cloudnull | while that code path isn't particularly new, i suspect that's the issues | 13:33 |
cloudnull | we're likely using a new code path given the ephemeral change | 13:33 |
cloudnull | Tengu I think so | 13:34 |
cloudnull | https://github.com/openstack/python-tripleoclient/commit/0f9fbfa58d10db9f78860fe22a2e2e771630da6f | 13:34 |
Tengu | https://github.com/openstack/python-tripleoclient/commit/0f9fbfa58d10db9f78860fe22a2e2e771630da6f#diff-b11b57bc4b70550876aa592303b19031bdf2efb75f10a9b036d0f0d5e86b1559R118-R124 that one should probably build the container image name instead of relying on the constants | 13:35 |
cloudnull | so I suspect we need a way to feed the heat container data into the client, or we need the client to read the renderered file and parse it | 13:35 |
cloudnull | Tengu++ | 13:35 |
matbu | marios|ruck: hey man, sorry for bugging you about that, but we need your great power one the releases: https://review.opendev.org/q/topic:%22vf%252F1.2.0%22+(status:open%20OR%20status:merged) | 13:35 |
Tengu | at the same time... a constant is supposed to be a constant.... | 13:36 |
Tengu | so there's little to no sense to allow constant override :D | 13:36 |
Tengu | o_O apparently that constants.DEFAULT_CONTAINER_TAG isn't used at all across tripleoclient ?! | 13:37 |
Tengu | nor is it in tripleo-common..... what? | 13:37 |
hjensas | Tengu: DEFAULT_CONTAINER_TAG is used to build DEFAULT_HEAT_CONTAINER, DEFAULT_HEAT_API_CONTAINER and DEFAULT_HEAT_ENGINE_CONTAINER | 13:39 |
rlandy | so really, this would have gone undetected upstream until it tripped us up in rhos-17 | 13:40 |
Tengu | hjensas: yeah - nothing else apparently, and this creates an issue at some point | 13:40 |
hjensas | Tengu: the ones it builds is then used tripleoclient/v1/tripleo_launch_heat.py:26 | 13:40 |
Tengu | so those default_heat_* might even be dropped at some point imho.. | 13:40 |
Tengu | hjensas: yeah, saw it already. thing is, it's a wrong tag for the CI, leading to master/wallaby issues in the periodic runs (see https://bugs.launchpad.net/tripleo/+bug/1931995) | 13:41 |
Tengu | rlandy: that's a nasty issue :(. going undetected like that :(( | 13:42 |
hjensas | Tengu: yeah, I guess CI should set the args? --heat-container-api-image --heat-container-engine-image --heat-container-image ... and yeah I guess downsteam as well. :.O | 13:43 |
Tengu | or heat image should take the container tag as configured somewhere in the CI - else we'll face some issues with osp | 13:44 |
rlandy | hjensas: hmmm ... so we can set and override with --heat-container-api-image --heat-container-engine-image --heat-container-image to the deploy command? | 13:44 |
Tengu | (since osp will also cry with "current-tripleo" - should take the things from the generate-container thing) | 13:44 |
Tengu | rlandy: there are those options, yeah...... still, not sure this is the right way. | 13:45 |
hjensas | rlandy: tripleo launch heat command has those args, the constants are used for the defaults of those args. | 13:45 |
* hjensas 2nd's Tengu's not sure this is the way ... | 13:45 | |
rlandy | we can at least try those option | 13:45 |
Tengu | rlandy: as a work-around in order to unlock the periodics, yeah | 13:46 |
rlandy | Tengu: the only blocked release is 17 | 13:46 |
Tengu | still the "right" way would be to use the container image prepare generated content | 13:46 |
rlandy | although that's becoming a bug deal ahead of el9 | 13:46 |
* rlandy will leave upstream for the better solution ... at least until it falls over | 13:47 | |
* rlandy tries with 17 | 13:47 | |
hjensas | rlandy: hm, overcloud deploy command seem to only have --heat-container-api-image and --heat-container-engine-image args. Not the --heat-container-image | 13:49 |
rlandy | hjensas: testing that anyways just to see if it takes and gets us by the first failure | 13:51 |
marios|ruck | matbu: ack but in call will check in bit | 13:51 |
opendevreview | James Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796481 | 13:57 |
opendevreview | Jiri Podivin proposed openstack/validations-libs master: Default value of the constructor parameter https://review.opendev.org/c/openstack/validations-libs/+/796482 | 13:58 |
cloudnull | yeah I think we're going to need to sync with slagle on that. | 14:00 |
cloudnull | I suspect there's some nuance here | 14:00 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role https://review.opendev.org/c/openstack/tripleo-validations/+/789698 | 14:08 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: Neutron: Explicitly set the default hepervisor name https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796402 | 14:09 |
opendevreview | Sandeep Yadav proposed openstack/tripleo-quickstart-extras master: build-test-package: Set distro for downstream case https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/796486 | 14:13 |
Tengu | cloudnull: add you as well as slagle to the CIX card (and joined it). hjensas feel free to join it if you want, of course :) | 14:14 |
Tengu | *added you | 14:14 |
Tengu | ... EoD is close - my brain's dying in the heat here. | 14:14 |
matbu | marios|ruck: no pb | 14:16 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role https://review.opendev.org/c/openstack/tripleo-validations/+/789698 | 14:17 |
marios|ruck | matbu: just voted on the libs one i voted on the -common this morning | 14:17 |
marios|ruck | matbu: fyi you can just do them both in one review next time if you like it is easier for you | 14:18 |
matbu | marios|ruck: hoo right /me stupid :) | 14:18 |
matbu | double CI double work sorry | 14:18 |
marios|ruck | matbu: ack np :) not stupid but yeah easier to get reviewer attention from the release team too maybe | 14:19 |
marios|ruck | matbu: there is no 'right' here some people might prefer independent review for each repo | 14:19 |
marios|ruck | matbu: we always do the tripleo ones in the same review | 14:19 |
matbu | marios|ruck: yep i actually prepare the v-libs review on friday, waiting one patch to land... and monday morning, my mind wasn't very clear i guess :) | 14:20 |
opendevreview | Paul Leimer proposed openstack/tripleo-heat-templates stable/victoria: Add option for enabling rsyslog reopenOnTruncate https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796437 | 14:25 |
*** rpittau is now known as rpittau|afk | 14:29 | |
opendevreview | Francesco Pantano proposed openstack/tripleo-heat-templates master: WIP - Moving scenario004 to cephadm https://review.opendev.org/c/openstack/tripleo-heat-templates/+/773355 | 14:30 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-ansible stable/victoria: BnR Test NFS server conectivity & ubi-minimal container image https://review.opendev.org/c/openstack/tripleo-ansible/+/796441 | 14:38 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-heat-templates stable/victoria: Added the posibility of skipping the NFS ping test on the rear installation https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796442 | 14:40 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-ansible stable/wallaby: BnR Added a nfs validation when the nfs server is installed https://review.opendev.org/c/openstack/tripleo-ansible/+/796443 | 14:43 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-ansible stable/victoria: BnR Added a nfs validation when the nfs server is installed https://review.opendev.org/c/openstack/tripleo-ansible/+/796444 | 14:44 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-ansible stable/victoria: BnR Added a nfs validation when the nfs server is installed https://review.opendev.org/c/openstack/tripleo-ansible/+/796444 | 14:45 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the switch_vlans module https://review.opendev.org/c/openstack/tripleo-validations/+/796499 | 14:53 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the network_environment module https://review.opendev.org/c/openstack/tripleo-validations/+/796500 | 14:54 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the verify_profiles module https://review.opendev.org/c/openstack/tripleo-validations/+/796502 | 14:56 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Moving setting validation from nova_event_callback https://review.opendev.org/c/openstack/tripleo-validations/+/794866 | 14:56 |
*** ykarel_ is now known as ykarel | 14:56 | |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the ceph_pools_pg_protection module https://review.opendev.org/c/openstack/tripleo-validations/+/796503 | 14:56 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the ovs_dpdk_pmd_cpus_check module. https://review.opendev.org/c/openstack/tripleo-validations/+/796505 | 14:57 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the icmp_ping module. https://review.opendev.org/c/openstack/tripleo-validations/+/796506 | 14:58 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the node_disk module. https://review.opendev.org/c/openstack/tripleo-validations/+/796507 | 14:59 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the pacemaker module https://review.opendev.org/c/openstack/tripleo-validations/+/796508 | 15:00 |
sshnaidm | cloudnull, hi, can you please review/merge in your time? https://review.opendev.org/q/topic:%22collections-everywhere%22+(status:open%20OR%20status:merged) | 15:00 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the check_flavors module https://review.opendev.org/c/openstack/tripleo-validations/+/796509 | 15:00 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations stable/wallaby: Use and ownership info for the ip_range module. https://review.opendev.org/c/openstack/tripleo-validations/+/796510 | 15:01 |
weshay|ruck | FYI.. | 15:08 |
weshay|ruck | 2021-06-15 12:21:26.261455 | ubuntu-bionic | ERROR: Cannot install -r /home/zuul/src/opendev.org/openstack/tripleo-heat-templates/requirements.txt (line 8) because these package versions have conflicting dependencies. | 15:08 |
weshay|ruck | 2021-06-15 12:21:26.261540 | ubuntu-bionic | | 15:08 |
weshay|ruck | 2021-06-15 12:21:26.261629 | ubuntu-bionic | The conflict is caused by: | 15:08 |
weshay|ruck | 2021-06-15 12:21:26.261669 | ubuntu-bionic | tripleo-common 11.7.0 depends on python-zaqarclient>=1.0.0 | 15:08 |
weshay|ruck | 2021-06-15 12:21:26.261707 | ubuntu-bionic | The user requested (constraint) python-zaqarclient===1.12.0 | 15:08 |
weshay|ruck | 2021-06-15 12:21:26.261725 | ubuntu-bionic | | 15:08 |
opendevreview | Daniel Alvarez proposed openstack/tripleo-heat-templates master: [ovn metadata] Add agent report option https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796512 | 15:09 |
*** jpena is now known as jpena|off | 15:18 | |
bogdando | Tengu: there is heat_container_image config for custom image | 15:18 |
bogdando | oh, hjensas already mentioned that | 15:19 |
hjensas | (╯°□°)╯︵ ┻━┻, I'm hitting https://bugs.launchpad.net/tripleo/+bug/1931995 as well I think. | 15:29 |
hjensas | When I install a Wallby undercloud, I end up with a0f84bc37951 quay.io/tripleomaster/openstack-ironic-conductor:current-tripleo | 15:29 |
hjensas | I don't run any 'container image prepare' command. Just 'tripleo-repos -b wallaby current ceph' to get the Wallaby repos. | 15:32 |
mwhahaha | did we not properly patch wallaby defaults | 15:33 |
mwhahaha | nope | 15:34 |
* mwhahaha sighs and fixes | 15:34 | |
hjensas | I get 'tag: current-tripleo' if run openstack tripleo container image prepare default --local-push-destination --output-env-file /home/centos/containers-prepare-parameter.yaml | 15:35 |
mwhahaha | when we cut stable branches we have to patch teh branch with the wallaby stuff | 15:35 |
mwhahaha | weshay|ruck, marios|ruck: what's the correct namespace for wallaby? | 15:36 |
hjensas | meh, ok please go ahead I can review. | 15:36 |
mwhahaha | quay.io/tripleowallaby? | 15:36 |
marios|ruck | mwhahaha: should be tripleowallaby according to https://opendev.org/openstack/tripleo-quickstart/src/commit/141194c402da021975ffe6e93c4d5acfa966dfe8/config/release/tripleo-ci/CentOS-8/wallaby.yml#L26 | 15:37 |
mwhahaha | then there needs to be a downstream patch for whatever that namespace is | 15:39 |
opendevreview | Alex Schultz proposed openstack/tripleo-common stable/wallaby: [Wallaby-only] Update default container namespace for wallaby https://review.opendev.org/c/openstack/tripleo-common/+/796516 | 15:39 |
weshay|ruck | mwhahaha, https://hub.docker.com/u/tripleowallaby | 15:40 |
* weshay|ruck looks at quay | 15:40 | |
weshay|ruck | 404 | 15:40 |
weshay|ruck | dang it | 15:40 |
*** ysandeep is now known as ysandeep|out | 15:41 | |
marios|ruck | weshay|ruck: there was an issue with the copy quay script apparently and arxcruz had to fix a cron job | 15:42 |
weshay|ruck | mwhahaha, fixing now | 15:42 |
marios|ruck | weshay|ruck: see google chat | 15:42 |
weshay|ruck | k | 15:42 |
marios|ruck | weshay|ruck: so quay wasnt in sync | 15:42 |
marios|ruck | weshay|ruck: like current-tripleo was 3 months old | 15:42 |
weshay|ruck | ya.. chatting about it now | 15:43 |
bandini | yeah i hit that one | 15:50 |
mwhahaha | need to make sure that gets done when we cut stable releases | 15:51 |
*** amoralej is now known as amoralej|off | 15:53 | |
opendevreview | Sofer Athlan-Guyot proposed openstack/tripleo-heat-templates stable/train: Update, avoid task skipping by directly importing step file. https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796518 | 15:53 |
mwhahaha | meh lint | 15:53 |
opendevreview | Alex Schultz proposed openstack/tripleo-common stable/wallaby: [Wallaby-only] Update default container namespace for wallaby https://review.opendev.org/c/openstack/tripleo-common/+/796516 | 15:54 |
*** marios|ruck is now known as marios|out | 15:57 | |
opendevreview | Shnaidman Sagi (Sergey) proposed openstack/tripleo-quickstart-extras master: Add option to build collection github PRs https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/796522 | 15:59 |
weshay|ruck | mwhahaha, getting populated now https://quay.io/organization/tripleowallaby | 16:03 |
mwhahaha | k | 16:03 |
mwhahaha | we don't hit it in ci because we always build | 16:03 |
weshay|ruck | ya | 16:03 |
weshay|ruck | just for users and devs.. pffff | 16:03 |
hjensas | weshay|ruck: how long does it take for it to populate? | 16:09 |
weshay|ruck | it's pretty quick.. arxcruz wrote it in go.. pretty zippy | 16:10 |
weshay|ruck | arxcruz, you get through ironic? | 16:10 |
*** ricolin_ is now known as ricolin | 16:26 | |
opendevreview | Merged openstack/tripleo-heat-templates stable/train: Fix typo in ceilometer-write-qdr environment file https://review.opendev.org/c/openstack/tripleo-heat-templates/+/795389 | 16:46 |
opendevreview | Merged openstack/puppet-tripleo master: Clear last dependency on puppet-ceph from Manila manifest https://review.opendev.org/c/openstack/puppet-tripleo/+/796293 | 16:46 |
opendevreview | Merged openstack/puppet-tripleo stable/wallaby: Introduce nova virtlogd wrapper https://review.opendev.org/c/openstack/puppet-tripleo/+/795148 | 16:47 |
mwhahaha | cloudnull: have you ever messed with the default ansible runner inventory handling? Do you know if you can do something like inventory/file.yaml or does it need to be extensionless? | 17:00 |
cloudnull | I think it has to be extensionless if you use the runner path | 17:07 |
mwhahaha | :( | 17:07 |
fultonj | hjensas: after generating deployed-{network,metal}.yaml w/ `opentsack overcloud network provision` and `openstack overcloud node provision --network-config` and passing -e deployed-{network,metal}.yaml to my overcloud deploy, it fails looking for rendered port templates; any ideas? http://paste.openstack.org/show/806641 | 17:07 |
mwhahaha | cloudnull: ok i'll poke at it. unfortunatley our code assumes an extension | 17:08 |
opendevreview | James Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796481 | 17:09 |
hjensas | fultonj: you passed the network_data.yaml used with opentsack overcloud network provision as the -n option to the overcloud deploy command? | 17:09 |
cloudnull | this is how we handle it in the client https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L360-L375 | 17:09 |
cloudnull | https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/utils.py#L637 | 17:10 |
cloudnull | so I guess it "should"-tm work if you pass it full path to the file | 17:10 |
fultonj | hjensas: yes, here's my deploy command http://paste.openstack.org/show/806642/ | 17:10 |
mwhahaha | cloudnull: https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventories.py#L117-L139 | 17:10 |
mwhahaha | cloudnull: that's the one i think i need to update because i want to generate it corectly to the config download dir | 17:11 |
cloudnull | ++ | 17:11 |
bandini | fultonj, hjensas: I have the exact same issue (fwiw) | 17:11 |
fultonj | thanks bandini | 17:11 |
opendevreview | James Slagle proposed openstack/tripleo-docs master: Document DeployedServerPortMap deprecation https://review.opendev.org/c/openstack/tripleo-docs/+/796525 | 17:12 |
hjensas | bandini: fultonj: oh, I think it's hard-coding to /usr/share/openstack-tripleo-heat-templates in the generated environments. | 17:13 |
hjensas | bandini: fultonj: I always edit them with sed, see: https://github.com/hjensas/homelab/blob/master/labs/ovb-ipv4-routed/overcloud/deploy_baremetal.sh#L9 | 17:13 |
*** gfidente is now known as gfidente|afk | 17:14 | |
hjensas | bandini: fultonj: It would be good to add a optional --templates argument to these commands so that it would do that automatically. Or maby a bigger hammer that replace anything /usr/share/openstack-tripleo-heat-templates to what's set as --tempaltes on the deploy command. | 17:15 |
fultonj | hjensas: thanks, i'm sed'ing my genereated files to the correct path and about to re-test | 17:16 |
bandini | i'll check tomorrow in my env | 17:16 |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Introducing the oslo_config_validator role https://review.opendev.org/c/openstack/tripleo-validations/+/789698 | 17:18 |
weshay|ruck | mwhahaha, hjensas https://quay.io/organization/tripleowallaby should be sane.. sorry about that | 17:20 |
weshay|ruck | *should* | 17:20 |
mwhahaha | k | 17:20 |
fultonj | hjensas: thanks that fixed my issue. heat stack is now creating. | 17:28 |
*** ricolin_ is now known as ricolin | 17:32 | |
opendevreview | David Vallee Delisle proposed openstack/tripleo-validations master: Moving setting validation from nova_event_callback https://review.opendev.org/c/openstack/tripleo-validations/+/794866 | 17:34 |
weshay|ruck | anbanerj|rover, http://pastebin.test.redhat.com/971913 | 17:45 |
opendevreview | Douglas Viroel proposed openstack/tripleo-repos master: Add tripleo-yum-config ansible module https://review.opendev.org/c/openstack/tripleo-repos/+/796529 | 18:02 |
opendevreview | Douglas Viroel proposed openstack/tripleo-repos master: Add tripleo-yum-config ansible module https://review.opendev.org/c/openstack/tripleo-repos/+/796529 | 18:04 |
sshnaidm | mwhahaha, do you know maybe, how do we ensure container-puppet-rabbitmq finishes before container rabbitmq_bootstrap starts? Both of them in step 1 | 18:13 |
mwhahaha | sshnaidm: they run at different imes | 18:18 |
mwhahaha | container puppet tasks are seperate from container management | 18:18 |
mwhahaha | https://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps-tasks.yaml#L83-L115 | 18:19 |
opendevreview | wes hayutin proposed openstack/openstack-tempest-skiplist master: add wallaby to negvolumetest skip https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/796530 | 18:20 |
mwhahaha | sshnaidm: that's why we force detach to false as well, https://review.opendev.org/c/openstack/tripleo-ansible/+/791317/16/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py so they should all finish before we run any other containers | 18:22 |
sshnaidm | mwhahaha, you run it in threads, right? | 18:39 |
mwhahaha | sshnaidm: yes but they run at different execution times | 18:39 |
mwhahaha | puppet-container-* are run all together but are seperate from the bootstrap container execution | 18:40 |
sshnaidm | mwhahaha, yeah, when I use API it seems like bootstrap container starts before puppet container is finished: https://logserver.rdoproject.org/63/34063/2/check/tripleo-ci-centos-8-standalone-podman-ansible/07854ca/logs/undercloud/home/zuul/standalone_deploy.log.txt.gz | 18:43 |
sshnaidm | I wonder when it's leaking.. | 18:43 |
mwhahaha | sshnaidm: create via the api detaches always i assume | 18:44 |
mwhahaha | so it doesn't wait like it does when you execute via cli | 18:44 |
mwhahaha | if detach: false, you'd need to poll the api to wait for the container to finish | 18:45 |
sshnaidm | probably, although in cli it was holding.. will check again | 18:46 |
mwhahaha | 2021-06-15 16:08:35.251096 | fa163edc-7451-7d19-62e2-0000000013ad | TIMING | tripleo_container_manage : Create containers managed by Podman for /var/lib/tripleo-config/container-puppet-config/step_1 | standalone | 0:15:01.887043 | 3.29s | 18:47 |
mwhahaha | i think that's the task and the process takes longer than 3 seconds which would mean the api just returns after being executed | 18:48 |
opendevreview | Alan Bishop proposed openstack/tripleo-common master: WIP: tcib: clean up cinder packages https://review.opendev.org/c/openstack/tripleo-common/+/796531 | 18:49 |
sshnaidm | mwhahaha, yeah, tested now, it just sends a request, work in terminal only | 18:55 |
sshnaidm | mwhahaha, so for working with API need to add task that checks all of them finished | 18:57 |
sshnaidm | something like that https://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps-tasks.yaml#L39 | 18:57 |
mwhahaha | we used to do that and it was terribly inefficient | 18:57 |
mwhahaha | but yea | 18:57 |
mwhahaha | we'd need a module that can be looped until a state is reached | 18:58 |
sshnaidm | mwhahaha, it's podman_container_info actually | 19:00 |
mwhahaha | doe sit take a list of containers? | 19:00 |
* mwhahaha doens't remember | 19:00 | |
sshnaidm | yep | 19:00 |
mwhahaha | k | 19:00 |
sshnaidm | either to add to your module option "wait until all is exited" | 19:00 |
mwhahaha | it'd be more efficient to add it to my module | 19:01 |
mwhahaha | though it's needed for both | 19:01 |
mwhahaha | (i think) | 19:01 |
mwhahaha | because we assume that things like bootstrap container launching don't move on to the next step | 19:01 |
mwhahaha | because we have a start order in the container configs within a step | 19:01 |
mwhahaha | basically if detach: false, we need to add a wait condition | 19:02 |
mwhahaha | added into https://review.opendev.org/c/openstack/tripleo-ansible/+/791317/16/tripleo_ansible/ansible_plugins/modules/tripleo_container_manage.py somewhere | 19:03 |
sshnaidm | I think better to come with other option than "detach" if it doesn't work well with API. | 19:03 |
sshnaidm | just "wait_for_finish" or kind of | 19:03 |
mwhahaha | i mean that's the flag | 19:03 |
mwhahaha | no it needs to be in that module | 19:03 |
mwhahaha | because it needs to be handled for start order | 19:04 |
mwhahaha | https://review.opendev.org/c/openstack/tripleo-ansible/+/791317/16/tripleo_ansible/ansible_plugins/modules/tripleo_container_manage.py#344 | 19:04 |
mwhahaha | that needs to wait for all containers in a start order to complete before moving on to the next one | 19:04 |
mwhahaha | and exit if detach: false | 19:04 |
sshnaidm | yeah, will figure this out | 19:07 |
opendevreview | James Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796481 | 19:16 |
opendevreview | James Slagle proposed openstack/tripleo-heat-templates master: Deprecate DeployedServerPortMap https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796481 | 19:17 |
opendevreview | Alex Schultz proposed openstack/python-tripleoclient master: [WIP] Import task core into tripleoclient https://review.opendev.org/c/openstack/python-tripleoclient/+/796533 | 19:37 |
opendevreview | Alex Schultz proposed openstack/python-tripleoclient master: Drop mistralclient from requirements https://review.opendev.org/c/openstack/python-tripleoclient/+/796534 | 19:41 |
opendevreview | Alex Schultz proposed openstack/python-tripleoclient master: [WIP] Import task core into tripleoclient https://review.opendev.org/c/openstack/python-tripleoclient/+/796533 | 19:43 |
opendevreview | Merged openstack/openstack-tempest-skiplist master: add wallaby to negvolumetest skip https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/796530 | 19:57 |
opendevreview | Alex Schultz proposed openstack/python-tripleoclient master: [WIP] Import task core into tripleoclient https://review.opendev.org/c/openstack/python-tripleoclient/+/796533 | 20:02 |
opendevreview | Ronelle Landy proposed openstack/tripleo-quickstart master: Update centos 8 dep pieline to run with compose repos https://review.opendev.org/c/openstack/tripleo-quickstart/+/796536 | 20:03 |
rlandy | weshay|ruck: ^^ | 20:03 |
* weshay|ruck looks | 20:03 | |
mwhahaha | weshay|ruck, rlandy: https://review.opendev.org/c/openstack/tripleo-common/+/796516 plz4me | 20:06 |
rlandy | done | 20:08 |
slaweq | weshay|ruck hi, can You check https://review.opendev.org/c/openstack/tripleo-heat-templates/+/783932 when You will have few minutes? Thx in advance | 20:10 |
weshay|ruck | slaweq, what are you doing awake? | 20:12 |
slaweq | weshay|ruck it's not that late for me, only 10pm :) | 20:13 |
slaweq | I'm watching match and checking my opened reviews ;) | 20:13 |
weshay|ruck | ladies and gentleman.. I give EmilienM 2.0 | 20:14 |
weshay|ruck | I give you | 20:14 |
slaweq | weshay|ruck You mean me? No, I'm definitely not as good as EmilienM :) | 20:18 |
EmilienM | what did I break again? | 20:18 |
weshay|ruck | slaweq, you are much better looking at least | 20:19 |
slaweq | :D | 20:19 |
opendevreview | James Slagle proposed openstack/python-tripleoclient master: Copy the deployment archive to /var/lib/tripleo https://review.opendev.org/c/openstack/python-tripleoclient/+/796537 | 20:25 |
opendevreview | Owen McGonagle proposed openstack/tripleo-validations master: [WIP] remove using containers-prepare-parameter.yaml https://review.opendev.org/c/openstack/tripleo-validations/+/796061 | 20:26 |
opendevreview | Merged openstack/tripleo-quickstart-extras master: Include component repo in image builds https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/795838 | 20:31 |
fultonj | redeployed my undercloud ironic.common.exception.DriverNotFoundInEntrypoint: Could not find the following items in the 'ironic.hardware.interfaces.deploy' entrypoint: iscsi. | 20:31 |
mwhahaha | fultonj: you have master containers with wallaby | 20:32 |
fultonj | i'm using master, not wallaby though | 20:32 |
mwhahaha | you're missing teh THT patch to remove iscsi | 20:32 |
mwhahaha | related ML [rdo-users] Error importing node definition on undercloud Wallaby | 20:33 |
mwhahaha | https://review.opendev.org/c/openstack/tripleo-heat-templates/+/749475 | 20:33 |
fultonj | so get that patch and re-run undercloud install? | 20:34 |
fultonj | thanks mwhahaha for identifying the root cuase | 20:34 |
mwhahaha | that landed back in feb | 20:34 |
mwhahaha | so not certain how you don't have that | 20:35 |
mwhahaha | there might be another bug somewhere. stevebaker may know | 20:36 |
* fultonj checking /usr/share/openstack-tripleo-heat-templates/ on my new undercloud | 20:36 | |
fultonj | i have that patch already | 20:37 |
mwhahaha | sounds like there's a bug somewhere else then | 20:37 |
mwhahaha | but we shouldn't be referencing iscsi anymore | 20:37 |
fultonj | i built an undercloud on master 8 hours ago without this problem | 20:38 |
fultonj | this new one has the issue | 20:38 |
* fultonj looks into manually telling ironic to not use iscsi | 20:39 | |
mwhahaha | fultonj: do you have https://review.opendev.org/c/openstack/python-tripleoclient/+/795520 | 20:40 |
opendevreview | Alex Schultz proposed openstack/python-tripleoclient stable/wallaby: Remove iscsi from IronicEnabledDeployInterfaces https://review.opendev.org/c/openstack/python-tripleoclient/+/796451 | 20:40 |
fultonj | python3-tripleoclient-16.0.1-0.20210520134358.e86bccd.el8.noarch | 20:42 |
mwhahaha | so no based on date | 20:42 |
mwhahaha | are you using current-tripleo instead of current-tripleo-dev? | 20:43 |
fultonj | current-tripleo | 20:46 |
mwhahaha | yea so you'd need a promotion | 20:46 |
mwhahaha | if running master it's better to use current-tripleo-dev | 20:46 |
fultonj | ok, thanks. i'll rebuild with current-tripleo-dev | 20:46 |
mwhahaha | but that does hightlight we haven't had a promotion lately. weshay|ruck are we almost 30 days behind on master? | 20:51 |
*** sshnaidm is now known as sshnaidm|afk | 21:15 | |
opendevreview | Harald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs https://review.opendev.org/c/openstack/python-tripleoclient/+/796545 | 21:40 |
opendevreview | Harald Jensås proposed openstack/tripleo-ansible master: %%_USER_THT_ROOT_%% replaces static THT path https://review.opendev.org/c/openstack/tripleo-ansible/+/796546 | 21:40 |
hjensas | fultonj: you may want to test ^^ to avoid sed'ing the environment files manually. (re the issue we discussed earlier.) | 21:41 |
weshay|ruck | mwhahaha, upstream integration promoted a couple days ago | 21:43 |
weshay|ruck | mwhahaha, you are referring to the component in tripleo master for rdo | 21:43 |
opendevreview | Merged openstack/tripleo-heat-templates master: Add OVNAvailabilityZone to improve UX https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786020 | 21:43 |
weshay|ruck | mwhahaha, and you are correct.. but most tripleo packages come through current anyway.. https://trunk.rdoproject.org/centos8/component/tripleo/c1/52/c1527ca9fcd5d2a50af896e2335b0af992d7a94b_2ecfbcb5/ | 21:44 |
weshay|ruck | we'll get it promoted | 21:44 |
opendevreview | Harald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs https://review.opendev.org/c/openstack/python-tripleoclient/+/796545 | 21:45 |
weshay|ruck | upgrade job is blocking | 21:48 |
weshay|ruck | can waive | 21:48 |
opendevreview | Merged openstack/tripleo-heat-templates master: Add service defined ansible_group_vars to RoleGroupVars https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796135 | 21:50 |
opendevreview | Merged openstack/tripleo-heat-templates master: Add map merge strategy for {{role.name}}Parameters https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796136 | 21:59 |
hjensas | slagle: if you are around, this Wallaby backport https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792522, removes use of OS::Neutron::Net and OS::Neutron::Port with OVN deployments. | 22:06 |
opendevreview | Harald Jensås proposed openstack/tripleo-ansible master: %%_USER_THT_ROOT_%% replaces static THT path https://review.opendev.org/c/openstack/tripleo-ansible/+/796546 | 22:26 |
opendevreview | Harald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs https://review.opendev.org/c/openstack/python-tripleoclient/+/796545 | 22:41 |
opendevreview | Harald Jensås proposed openstack/python-tripleoclient master: Rewrite %%_USER_THT_ROOT_%% in user envs https://review.opendev.org/c/openstack/python-tripleoclient/+/796545 | 22:50 |
stevebaker | hjensas: hey are you still about? | 23:35 |
hjensas | stevebaker: yes, just about to call it a night. Whats up? | 23:36 |
stevebaker | hjensas: I'd like to use the provision playbook thing to run the growvols script, but it should basically be mandatory to run with fixed defaults in most cases. But sometimes defaults will be different, and it should only run for whole-disk images. I'm just pondering how to make it just work without any extra provision yaml required in the common case | 23:39 |
stevebaker | hjensas: https://review.opendev.org/c/openstack/diskimage-builder/+/791083 | 23:39 |
stevebaker | hjensas: so no real questions right now, I'm just pondering the options | 23:43 |
hjensas | stevebaker: I have a patch up to refactor the execution of the playbook applying network configuration. https://review.opendev.org/c/openstack/python-tripleoclient/+/794017/9/tripleoclient/utils.py#2876 | 23:44 |
hjensas | stevebaker: you could call a playbook there, before the Network config playbook. | 23:45 |
hjensas | stevebaker: Alternatively you could make it a composable service in THT that always run? In either case I guess the playbook could check for LVM/whole-disk image by inspecting the deployed instance? | 23:46 |
stevebaker | yeah, it could run regardless, and be a noop if there is no lvm | 23:47 |
stevebaker | that refactor is good | 23:47 |
stevebaker | ok, I'll start by writing the playbook then we can decide how best to wire it in | 23:48 |
hjensas | necessary since I'm adding support to overcloud deploy command in that patch series | 23:48 |
stevebaker | I think running it early as possible is best, but its not a huge deal | 23:49 |
hjensas | question is also how you should wire in setting custom vars for a growvols playbook. | 23:53 |
hjensas | the generic ansible_playbook interface has the 'extra_vars' that can be set per-playbook in the deployment yaml | 23:53 |
hjensas | there is 'network_config': key in the deployment yaml, setting the nic-config template etc. It may make sense to ass a 'storage_config' key. | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!