Wednesday, 2022-10-05

opendevreviewBrendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks for octavia_api  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86033202:02
opendevreviewBrendan Shephard proposed openstack/tripleo-heat-templates stable/wallaby: Octavia: Remove unnecessary neutronclient package  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86031402:04
opendevreviewTakashi Kajinami proposed openstack/tripleo-ci master: Collect configuration files for host crond service  https://review.opendev.org/c/openstack/tripleo-ci/+/85977102:10
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: WIP: Offload cron job to host crond  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/85892902:13
opendevreviewBrendan Shephard proposed openstack/tripleo-ansible master: Add Octavia Worker host_prep_tasks  https://review.opendev.org/c/openstack/tripleo-ansible/+/86033302:16
opendevreviewBrendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks from THT to tripleo-ansible  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86033402:20
opendevreviewBrendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks from THT to tripleo-ansible  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86033402:20
opendevreviewBrendan Shephard proposed openstack/tripleo-heat-templates master: Move host_prep_tasks for octavia worker to Ansible role  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86033402:25
opendevreviewTakashi Kajinami proposed openstack/puppet-tripleo master: Remove reference to unused hieradata keys  https://review.opendev.org/c/openstack/puppet-tripleo/+/83177902:55
opendevreviewTakashi Kajinami proposed openstack/puppet-tripleo master: Remove manifest to deploy OVNDB at host  https://review.opendev.org/c/openstack/puppet-tripleo/+/85244902:56
opendevreviewTakashi Kajinami proposed openstack/python-tripleoclient master: overcloud node delete: Fix ignored --overcloud-ssh-port-timeout  https://review.opendev.org/c/openstack/python-tripleoclient/+/86033503:02
opendevreviewTakashi Kajinami proposed openstack/tripleo-ansible master: Make python codes pep8 compliant  https://review.opendev.org/c/openstack/tripleo-ansible/+/84917903:08
opendevreviewMerged openstack/tripleo-heat-templates master: Fix kill-script search string to match any "/libpod-"  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/85945404:48
opendevreviewBrendan Shephard proposed openstack/tripleo-ansible master: Add standalone ovn-controller role  https://review.opendev.org/c/openstack/tripleo-ansible/+/84565304:59
opendevreviewBrendan Shephard proposed openstack/tripleo-ansible master: Add standalone ovn-controller role  https://review.opendev.org/c/openstack/tripleo-ansible/+/84565305:03
*** marios is now known as marios|ruck06:31
opendevreviewBrendan Shephard proposed openstack/tripleo-heat-templates stable/wallaby: Support role specific ContainerImagePrepare  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86031506:43
*** yadnesh is now known as yadnesh|away06:54
*** amoralej|off is now known as amoralej07:27
*** jpena|off is now known as jpena07:37
opendevreviewArx Cruz proposed openstack/openstack-tempest-skiplist master: Add copy release command  https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/86039009:47
opendevreviewArx Cruz proposed openstack/tripleo-ci master: Remove pingtest from tripleo  https://review.opendev.org/c/openstack/tripleo-ci/+/85952609:52
opendevreviewBrendan Shephard proposed openstack/tripleo-ansible master: Add standalone ovn-controller role  https://review.opendev.org/c/openstack/tripleo-ansible/+/84565309:54
opendevreviewArx Cruz proposed openstack/openstack-tempest-skiplist master: Add copy release command  https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/86039010:40
opendevreviewMerged openstack/tripleo-common master: Fix the roles symlink  https://review.opendev.org/c/openstack/tripleo-common/+/86025910:53
*** amoralej is now known as amoralej|lunch11:03
fultonjbogdando: i wonder if we need a follow up to https://github.com/openstack/tripleo-ansible/commit/6d23b30ce8d22a4495a5ec5f248c6810696244ae 11:35
fultonjI'm testing your proposed nova_compute review but it fails as this file doesn't exist: 11:35
fultonjhttps://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#1411:35
fultonj 2022-10-05T11:28:02.641636716+00:00 stderr F ERROR:__main__:MissingRequiredSource: /var/lib/kolla/config_files/src-iscsid/* file is not found11:35
fultonjbogdando: ^ or do you have a better idea? I'm not certain.11:36
opendevreviewArx Cruz proposed openstack/openstack-tempest-skiplist master: Add zed release to list of skipped tests  https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/86040311:38
bogdandofultonj: I'm not sure which role should handle creation of that path11:54
bogdandoslagle: perchance?11:54
bogdandoMy initial assumption was that should be a meta-dependency standalone role to cover that11:54
*** blarnath is now known as d34dh0r5311:56
fultonjhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_container_standalone/tasks/main.yml#L42-L4711:56
fultonjlooks like tripleo_container_standalone mkaes a directory and copies files into it but isn't set up to handle aribtrary subdirectories like the ones in https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#14 11:57
fultonjso I thought of extending the loop on the config_files to make the directories11:59
bogdandomakes sense, also maybe we want that role included as meta: dependencies12:01
bogdandoroles/foo/meta/main.yml:dependencies: []12:01
bogdandobshephar: WDYT?12:02
bogdandofultonj: wanna go for it and submit a patch?12:02
fultonjbogdando: sure, i'll give it a try12:03
bogdandothanks12:03
fultonjok, bogdando thanks for the dicussion12:03
bshepharReading the backlog12:12
*** jpodivin_ is now known as jpodivin12:12
fultonjhi bshephar feel free to let me know if you have a question on how i hit this12:14
opendevreviewHarald JensÃ¥s proposed openstack/openstack-virtual-baremetal master: dhcp-relay - CentOS Stream 9  https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/85753712:19
bshepharfultonj: Yeah, I need to get back into the standalone roles work. I think I get the issue you're describing12:19
fultonjack12:20
*** amoralej|lunch is now known as amoralej12:31
opendevreviewMikolaj Ciecierski proposed openstack/tripleo-upgrade stable/train: Make a workload_launch script more robust  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86041312:44
*** kopecmartin is now known as kopecmartin|sick12:56
*** marios|ruck is now known as marios13:31
*** dasm|off is now known as dasm13:43
opendevreviewMerged openstack/diskimage-builder master: Fix wrong yum.conf name of CentOS 9 Stream  https://review.opendev.org/c/openstack/diskimage-builder/+/85240814:50
opendevreviewNeil Hanlon proposed openstack/diskimage-builder master: Change rockylinux-9 container to use baseurl instead of mirrorlist  https://review.opendev.org/c/openstack/diskimage-builder/+/86042814:52
opendevreviewJiri Podivin proposed openstack/tripleo-validations master: Removing six from modules  https://review.opendev.org/c/openstack/tripleo-validations/+/86042914:54
opendevreviewFrancesco Pantano proposed openstack/tripleo-ansible master: Add observability_data_only condition to node-exporter component  https://review.opendev.org/c/openstack/tripleo-ansible/+/85417615:07
opendevreviewFrancesco Pantano proposed openstack/tripleo-heat-templates master: Add observability_data_only bool  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/85417815:08
opendevreviewJohn Fulton proposed openstack/tripleo-ansible master: Ensure /var/lib/kolla/config_files sub-directories exist  https://review.opendev.org/c/openstack/tripleo-ansible/+/86047215:11
opendevreviewDavid Hill proposed openstack/tripleo-heat-templates master: Set external_ids:ovn-ofctrl-wait-before-clear  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86047315:12
*** marios is now known as marios|out15:17
opendevreviewDavid Hill proposed openstack/puppet-tripleo master: Allow an operator to change the crypto policies  https://review.opendev.org/c/openstack/puppet-tripleo/+/86012415:17
opendevreviewDavid Hill proposed openstack/puppet-tripleo master: Allow an operator to change the crypto policies  https://review.opendev.org/c/openstack/puppet-tripleo/+/86012415:19
opendevreviewDavid Hill proposed openstack/puppet-tripleo master: Allow an operator to change the crypto policies  https://review.opendev.org/c/openstack/puppet-tripleo/+/86012415:19
*** jpena is now known as jpena|off16:38
*** amoralej is now known as amoralej|off16:39
opendevreviewJohn Fulton proposed openstack/tripleo-ansible master: Ensure /var/lib/kolla/config_files sub-directories exist  https://review.opendev.org/c/openstack/tripleo-ansible/+/86047216:54
slaglefultonj: i was just looking at that :)16:55
fultonjslagle: ah ok :)16:55
slaglei don't think the issue is that src-iscsid doesn't exist16:55
slagleit's that /var/lib/config-data/ansible-generated/iscsid is empty on the host16:55
slagleso that glob doesn't find anything, which apprently makes kolla unhappy16:56
fultonji removed the glob but got the same complaint16:56
fultonjhttps://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#1416:56
fultonjbut i had to combine the glob removal and my patch to create the subdirs16:57
fultonji'll confirm one more time16:57
* fultonj undoes his patch and removes the dir to test again16:57
slagleit looks like your patch would create /var/lib/kolla/config_files/src-iscsid/ on the host? 17:00
fultonjyes17:00
slagleyea, that's not needed.17:00
slaglethe "source" there is telling kolla-start where to read from inside the container17:01
fultonjjust like how https://review.opendev.org/c/openstack/tripleo-ansible/+/853700 did17:01
fultonj"where to read from inside the container"17:02
fultonjok, so i've undone my patch17:02
fultonjand removed the glob from https://review.opendev.org/c/openstack/tripleo-ansible/+/843659/45/tripleo_ansible/roles/tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2#14 17:02
fultonjand my compute_contaienr hasn't crashed17:02
fultonjsupporting what you're proposing17:02
fultonjslagle: so i guess i'll abandon my patch17:03
slagle/var/lib/kolla/config_files on the host is for the kolla configuration files17:03
fultonjright17:04
fultonjon my host i see a src directory in /var/lib/kolla/config_files17:04
fultonj12:55 <slagle> it's that /var/lib/config-data/ansible-generated/iscsid is empty on the host17:05
fultonjyes it's empty17:05
fultonjslagle: should the fix then just be to not have the glob in tripleo_nova_compute/templates/kolla_config/nova_compute.yaml.j2 line 14 ?17:05
slaglefultonj: short term fix is probably to comment out that whole key for now17:07
slaglelong term fix is to make iscsid role actually generate a config file. then we could leave the glob, which is what we want17:07
slaglesorry, when i say "key", i mean that list item starting at line 1417:08
fultonjok, so the config_files list would only have two items in the short term17:09
slagleright17:09
fultonjok, thanks. i'll abandon the patch and leave a comment in https://review.opendev.org/c/openstack/tripleo-ansible/+/843659 17:10
opendevreviewMerged openstack/ansible-role-chrony master: Add tasks for run and sync to chrony role  https://review.opendev.org/c/openstack/ansible-role-chrony/+/84222317:17
opendevreviewJohn Fulton proposed openstack/tripleo-ansible master: DNM: Workaround missing items in tripleo_nova_compute  https://review.opendev.org/c/openstack/tripleo-ansible/+/86048317:49
opendevreviewMerged openstack/python-tripleoclient master: Replace some unnecessary os.path.join()  https://review.opendev.org/c/openstack/python-tripleoclient/+/85918818:03
fultonjtkajinam: would you mind re-reviewing this when you get a chance https://review.opendev.org/c/openstack/tripleo-ansible/+/851198 ? thx20:45
rcastillo|ruckissue with a container image hitting gate jobs https://bugs.launchpad.net/tripleo/+bug/199184621:16
*** dviroel is now known as dviroel|afk21:17
*** dasm is now known as dasm|off21:34
*** dkehn_ is now known as dkehn23:32

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!