Monday, 2022-12-05

opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86653902:22
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86653902:23
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86653902:25
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: OVN: Remove unused deployment methods of OVN DB  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/85558102:37
*** yadnesh|away is now known as yadnesh04:30
*** marios is now known as marios|ruck06:09
mrjoshiHi, looking for reviews on the patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86589806:41
*** ysandeep__ is now known as ysandeep|afk07:49
*** yadnesh is now known as yadnesh|afk08:01
opendevreviewJiri Podivin proposed openstack/tripleo-validations master: Removing six from modules  https://review.opendev.org/c/openstack/tripleo-validations/+/86042908:21
opendevreviewJiri Podivin proposed openstack/validations-common stable/1.6: [stable/1.6 only] Setting default interpreter for tox docs env to generic Python3  https://review.opendev.org/c/openstack/validations-common/+/86655108:27
*** khomesh|away is now known as khomesh08:39
*** jpena|off is now known as jpena08:42
lmiccinio/ can anybody give https://review.opendev.org/c/openstack/tripleo-ansible/+/865438 a push please? thanks!08:47
*** ysandeep|afk is now known as ysandeep09:10
opendevreviewDaniel Bengtsson proposed openstack/python-tripleoclient master: Fix upgrade playbook path.  https://review.opendev.org/c/openstack/python-tripleoclient/+/85185609:13
opendevreviewDaniel Bengtsson proposed openstack/python-tripleoclient master: Fix upgrade playbook path.  https://review.opendev.org/c/openstack/python-tripleoclient/+/85185609:15
damanihi09:16
damanican i have code review here please https://review.opendev.org/c/openstack/tripleo-ansible/+/865514 ?09:16
damaniand here https://review.opendev.org/c/openstack/tripleo-heat-templates/+/855651 ?09:17
*** yadnesh|afk is now known as yadnesh09:24
mrjoshiHi, looking for reviews on the patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86589810:38
opendevreviewTakashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86653910:40
*** ysandeep is now known as ysandeep|brb10:49
opendevreviewMerged openstack/puppet-tripleo master: Enable fence_watchdog configuration in stonith topology  https://review.opendev.org/c/openstack/puppet-tripleo/+/86304110:53
*** ysandeep|brb is now known as ysandeep10:59
*** dviroel|afk is now known as dviroel11:05
opendevreviewSofer Athlan-Guyot proposed openstack/tripleo-ansible master: Fix ovs check pkg_has_restart error.  https://review.opendev.org/c/openstack/tripleo-ansible/+/86656311:08
opendevreviewSofer Athlan-Guyot proposed openstack/tripleo-ansible stable/zed: Fix ovs check pkg_has_restart error.  https://review.opendev.org/c/openstack/tripleo-ansible/+/86656411:10
*** rlandy|out is now known as rlandy|rover11:10
opendevreviewSofer Athlan-Guyot proposed openstack/tripleo-ansible stable/wallaby: Fix ovs check pkg_has_restart error.  https://review.opendev.org/c/openstack/tripleo-ansible/+/86656511:10
opendevreviewSofer Athlan-Guyot proposed openstack/tripleo-ansible stable/train: Fix ovs check pkg_has_restart error.  https://review.opendev.org/c/openstack/tripleo-ansible/+/86656611:14
opendevreviewLuca Miccini proposed openstack/puppet-tripleo stable/zed: Enable fence_watchdog configuration in stonith topology  https://review.opendev.org/c/openstack/puppet-tripleo/+/86646211:20
opendevreviewLuca Miccini proposed openstack/puppet-tripleo stable/wallaby: Enable fence_watchdog configuration in stonith topology  https://review.opendev.org/c/openstack/puppet-tripleo/+/86646311:20
opendevreviewLuca Miccini proposed openstack/puppet-tripleo stable/wallaby: Enable fence_watchdog configuration in stonith topology  https://review.opendev.org/c/openstack/puppet-tripleo/+/86646311:22
opendevreviewLuca Miccini proposed openstack/puppet-tripleo stable/wallaby: Enable fence_watchdog configuration in stonith topology  https://review.opendev.org/c/openstack/puppet-tripleo/+/86646311:25
*** pojadhav is now known as pojadhav|brb11:31
opendevreviewFernando Díaz Bravo proposed openstack/python-tripleoclient master: bnr - Deprecation note  https://review.opendev.org/c/openstack/python-tripleoclient/+/86633411:35
*** yadnesh is now known as yadnesh|afk11:45
opendevreviewBogdan Dobrelya proposed openstack/tripleo-ansible master: Syns t-h-t: Fix logs permissions for swtpm  https://review.opendev.org/c/openstack/tripleo-ansible/+/86585212:15
opendevreviewBogdan Dobrelya proposed openstack/tripleo-heat-templates stable/wallaby: Run virtqemud with umask 0027  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86539612:23
*** pojadhav|brb is now known as pojadhav12:23
*** yadnesh|afk is now known as yadnesh12:26
*** frenzy_friday is now known as frenzy_friday|food12:40
fultonjowalsh: marios|ruck in order to resolve the CIX quickly I'd like to merge https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 and backport directly and then do a follow up patch using ansible.inventory.manager 12:46
fultonjif you concur would you please review ^ ?12:46
fultonjfpantano: ^ 12:46
fultonjI've tested that 866503 resolve the bug in my env with the inventory being genreated from the downstream 17.1 job12:47
fpantanofultonj: ack and thanks for the patch, I'll review!12:53
marios|ruckfultonj: ack thanks13:00
fultonjthx13:00
*** arxcruz is now known as arx|202313:08
owalshfultonj: so just want to get it working enough to pass the job? but not get it fully working yet (e.g not changing get_inventory_roles_to_hosts() and get_roles_to_svcs_from_inventory())13:24
fultonjowalsh: want to pass the job and fix the bug in its current scope13:27
fultonjfast track the working fix, but follow up with the new inventory as requested by ci team13:28
fultonj"the new inventory parsing*"13:29
owalshfultonj: ack, IIRC the inventory in that job doesn't include any ceph services so the functions don't return anything13:29
fultonjowalsh: it does include ceph services13:29
fultonjthe problem functions didn't return anything13:30
fultonji fixed them w/ https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 13:30
fultonjhttps://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1/tripleo_ansible/ansible_plugins/modules/ceph_spec_bootstrap.py#17613:30
fultonjthe comment in line 176 is is directly from the inventory in that job13:31
owalshfultonj: in the inventory I can see a CephStorage group but no ceph_mgr/ceph_mon/ceph_osd groups13:34
owalshis it going to work for an inventory with those services?13:36
fultonjowalsh: yes, it will work for those groups13:36
*** dasm|off is now known as dasm13:38
fultonjthese groups are based on tripleo roles (not ansible roles)13:39
opendevreviewMerged openstack/tripleo-heat-templates stable/wallaby: Fix trailing slashes in bind-mounts and linting  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86302413:43
opendevreviewMerged openstack/tripleo-ansible master: Enable start of FRR for non-root user  https://review.opendev.org/c/openstack/tripleo-ansible/+/86543813:43
owalshfultonj: so get_roles_to_svcs_from_inventory doesn't give the correct result, but it doesn't raise an exception like get_inventory_hosts_to_ips did13:48
opendevreviewMerged openstack/validations-common stable/1.6: [stable/1.6 only] Setting default interpreter for tox docs env to generic Python3  https://review.opendev.org/c/openstack/validations-common/+/86655113:48
opendevreviewJesse Pretorius proposed openstack/tripleo-upgrade master: [workload_launch] Update µversions for Wallaby & Zed  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86657813:51
fultonjowalsh: so can i address that in the follow up patch or do we want to block the quick fix?13:54
fultonjthere's an argument for not rushing to fix a job13:55
fultonjthe root cause of the reported bug was that the THT Role CephStorage didn't return any hosts 13:56
fultonjper the commit message13:56
fultonjhttps://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1//COMMIT_MSG#2213:57
owalshfultonj: in the BZ the issue is a KeyError13:58
fultonjyes, indeed13:58
owalshget_roles_to_svcs_from_inventory will return nothing for that inventory since there are no ceph services13:59
fultonjfromline 180 https://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1/tripleo_ansible/ansible_plugins/modules/ceph_spec_bootstrap.py#b18013:59
fultonjkey issue was from get_inventory_hosts_to_ips()13:59
fultonjissue technically wasn't in get_roles_to_svcs_from_inventory14:00
owalshso the patch would fix that job only, will it just fail at the first job that does have ceph services?14:00
fultonji don't see why this would introduce problems14:02
fultonjlet's step up one layer14:02
fultonjare you concerned my patch as it is right now will break other jobs?14:03
fultonjthe job we're talking about did have ceph services14:03
owalshis it standalone ceph though, not HCI14:04
fultonjit's not standalone14:04
fultonjit's multinode downstream14:04
fultonjhttps://bugzilla.redhat.com/show_bug.cgi?id=214996314:04
owalshbut I don't see any of the ceph_* groups in the inventory14:04
fultonjand it will handle hci too14:04
fultonji think you're confusing THT roles with ansible groups14:05
owalsheach tripleo service has an ansible group14:05
owalshe.g nova_libvirt, ceph_mon, ceph_mgr, etc..14:05
fultonjowalsh: wait14:06
fultonjthis is an inventory genereated by baremetal deployment14:06
fultonjso those services don't exist yet14:07
fultonjthey get defined later when the heat stack is deployed14:07
owalshack, so when I modify the inventory file used in the unit tests to use the new format then the test fail for get_roles_to_svcs_from_inventory14:08
fultonjso those details still need to be worked out in my follow up patch based on yours14:09
fultonjand i'll start a layered patch on 866503 with those changes14:09
owalshack. My patch works when I test it manually, but centos9 ansible-core seems to be broken (missing some .py files) so CI is red14:10
fultonjowalsh: upstream ci red14:10
fultonjowalsh: so i'll work on that14:10
owalshModuleNotFoundError: No module named 'ansible.module_utils.common.yaml14:11
fultonjowalsh: yo ok w/ https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 ?14:11
fultonjto address https://bugzilla.redhat.com/show_bug.cgi?id=2149963 quickly?14:11
fultonjall i've done is make get_inventory_hosts_to_ips() handle children correctly14:12
fultonjs/yo/you :)14:13
owalshfultonj: hrmm, well if it doesn't matter that roles_to_svcs will be wrong then ok, I'm not sure how/where it used14:17
fultonjit is used in other cases14:18
fultonjthe module genereates a ceph spec when we have an inventory from heat or if we don't have an inventory from heat14:18
fultonjthe case where the bug happended was an inventory not from heat14:19
owalshok then, can follow up with the CI issue for my patch later14:19
owalshmarios|ruck: might need your help for that ^14:20
owalshfultonj: you want to fix the comment from Francesco first?14:21
fultonjok14:21
*** yadnesh is now known as yadnesh|away14:21
opendevreviewJohn Fulton proposed openstack/tripleo-ansible master: Handle child groups when building ceph spec from inventory  https://review.opendev.org/c/openstack/tripleo-ansible/+/86650314:23
fultonjdone14:23
marios|ruckowalsh: ok can check after calls 14:23
marios|ruckowalsh: link?14:23
fultonjmarios|ruck: quick revote on https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 ?14:24
opendevreviewJiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup  https://review.opendev.org/c/openstack/tripleo-validations/+/86658114:24
fultonjhttps://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1..2/tripleo_ansible/ansible_plugins/modules/ceph_spec_bootstrap.py14:24
fultonjfpantano: ^ quick revrote on ^ ?14:24
fultonjre-vote*14:25
fpantanoack thanks for the update!14:25
opendevreviewJiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup  https://review.opendev.org/c/openstack/tripleo-validations/+/86658114:26
owalshmarios|ruck: https://zuul.opendev.org/t/openstack/build/63c22505b39547afbcf3965014a271be14:30
owalshModuleNotFoundError: No module named 'ansible.module_utils.common.yaml14:30
owalshmissing some files in ansible-core?14:30
opendevreviewJiri Podivin proposed openstack/validations-common stable/1.6: Bugfix: Add missing become: true to 2 tasks  https://review.opendev.org/c/openstack/validations-common/+/86469814:35
*** pojadhav is now known as pojadhav|afk14:38
*** ysandeep is now known as ysandeep|dinner14:52
opendevreviewJiri Podivin proposed openstack/validations-common stable/1.6: DNM Setting default interpreter for tox docs env to generic Python3  https://review.opendev.org/c/openstack/validations-common/+/86658614:53
opendevreviewBogdan Dobrelya proposed openstack/tripleo-heat-templates master: Convert Nova httpd configurations to new role  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86617715:11
opendevreviewJiri Podivin proposed openstack/validations-common stable/1.6: DNM testing new doc job overrides for stable branches  https://review.opendev.org/c/openstack/validations-common/+/86634315:18
opendevreviewDavid Hill proposed openstack/tripleo-ansible master: Fix MTU ping validations  https://review.opendev.org/c/openstack/tripleo-ansible/+/86659015:20
opendevreviewDavid Hill proposed openstack/tripleo-ansible master: Fix MTU ping validations  https://review.opendev.org/c/openstack/tripleo-ansible/+/86659015:25
opendevreviewJiri Podivin proposed openstack/validations-common stable/1.6: DNM testing new doc job overrides for stable branches  https://review.opendev.org/c/openstack/validations-common/+/86634315:29
opendevreviewDavid Hill proposed openstack/tripleo-ansible master: Fix MTU ping validations  https://review.opendev.org/c/openstack/tripleo-ansible/+/86659015:34
opendevreviewBogdan Dobrelya proposed openstack/python-tripleoclient master: Do not filter ovn_dbs_vip for multi-cell export  https://review.opendev.org/c/openstack/python-tripleoclient/+/86659315:39
*** pojadhav|afk is now known as pojadhav15:40
opendevreviewJohn Fulton proposed openstack/tripleo-ansible stable/wallaby: Handle child groups when building ceph spec from inventory  https://review.opendev.org/c/openstack/tripleo-ansible/+/86646515:41
opendevreviewJiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup  https://review.opendev.org/c/openstack/tripleo-validations/+/86658115:55
opendevreviewJiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup  https://review.opendev.org/c/openstack/tripleo-validations/+/86658116:00
Tengufolks, care to have a look at this backport? https://review.opendev.org/c/openstack/tripleo-common/+/865390  thanks!16:00
*** dviroel is now known as dviroel|lunch16:00
*** ysandeep|dinner is now known as ysandeep16:13
*** ysandeep is now known as ysandeep|out16:15
fultonjTengu: I +2 +w'd the clean cherry pick ^ 16:21
Tengufultonj: thanks!16:22
fultonjnp16:24
*** frenzy_friday|food is now known as frenzy_friday16:24
opendevreviewJuan Badia Payno proposed openstack/tripleo-ansible stable/zed: [ffwd3] Use tripleo tags in network extraction  https://review.opendev.org/c/openstack/tripleo-ansible/+/86646616:31
*** marios|ruck is now known as marios|out16:35
owalshmarios|ruck, fultonj: I think the issue with the ansible.module_utils.common.yaml is due to https://docs.ansible.com/ansible/latest/dev_guide/developing_module_utilities.html#using-and-developing-module-utilities16:39
owalsh"The ansible.module_utils namespace is not a plain Python package: it is constructed dynamically for each task invocation, by extracting imports and resolving those matching the namespace against a search path derived from the active configuration"16:39
owalshI think it would be safer to avoid the dependency on the core ansible.inventory classes - doubt it's safe to assume they will exist on the remote host. I'll re-implement using python stdlib instead16:50
*** dviroel|lunch is now known as dviroel16:51
opendevreviewJuan Badia Payno proposed openstack/tripleo-ansible stable/wallaby: [ffwd3] Use tripleo tags in network extraction  https://review.opendev.org/c/openstack/tripleo-ansible/+/86646717:13
opendevreviewBogdan Dobrelya proposed openstack/python-tripleoclient master: Also export OVN_DBs_IPs for multi-stack inputs  https://review.opendev.org/c/openstack/python-tripleoclient/+/86659317:17
opendevreviewMerged openstack/tripleo-validations master: Changing mount parameter of podman task to volume  https://review.opendev.org/c/openstack/tripleo-validations/+/86643817:23
opendevreviewJuan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Make sure patch reports issues and ignores test files  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86646817:35
opendevreviewJuan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Make sure patch reports issues and ignores test files  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86646817:37
opendevreviewJuan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Improve patch download  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86646917:44
opendevreviewJuan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Make sure patch reports issues and ignores test files  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86646817:51
opendevreviewMerged openstack/tripleo-heat-templates master: Configure a step when the old ironic-api configuration is cleaned  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86637317:51
*** dviroel is now known as dviroel|afk17:52
*** jpena is now known as jpena|off17:58
opendevreviewJuan Badia Payno proposed openstack/ansible-role-collect-logs master: Collect ~/.ssh/config file  https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/86661818:24
opendevreviewMerged openstack/tripleo-common stable/zed: By default, unset everything proxy related for healthcheck  https://review.opendev.org/c/openstack/tripleo-common/+/86539019:05
-opendevstatus- NOTICE: The lists.opendev.org and lists.zuul-ci.org sites will be offline briefly for migration to a new server20:03
opendevreviewChris Sibbitt proposed openstack/tripleo-ansible stable/wallaby: Fix molecule failures in tripleo_collectd  https://review.opendev.org/c/openstack/tripleo-ansible/+/86621520:19
csibbittHi y'all; I'd like to request a final review + merge on a patch to fix CI tests. https://review.opendev.org/c/openstack/tripleo-ansible/+/865465 (master) and  https://review.opendev.org/c/openstack/tripleo-ansible/+/865888 (zed)21:37
opendevreviewChris Sibbitt proposed openstack/tripleo-ansible stable/wallaby: Fix molecule failures in tripleo_collectd  https://review.opendev.org/c/openstack/tripleo-ansible/+/86621521:43
*** dviroel|afk is now known as dviroel22:01
opendevreviewDavid Vallee Delisle proposed openstack/tripleo-heat-templates stable/train: [TRAIN-ONLY] Passing NovaComputeOpt{Volumes,EnvVars} to hybrid containers  https://review.opendev.org/c/openstack/tripleo-heat-templates/+/86623822:18
opendevreviewMerged openstack/tripleo-upgrade stable/wallaby: Improve patch download  https://review.opendev.org/c/openstack/tripleo-upgrade/+/86646922:33
opendevreviewMerged openstack/os-net-config master: Avoid reconfiguring SR-IOV devices during stack update  https://review.opendev.org/c/openstack/os-net-config/+/86631222:46
*** dasm is now known as dasm|off22:51
opendevreviewOliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing  https://review.opendev.org/c/openstack/tripleo-ansible/+/86641023:07
opendevreviewOliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing  https://review.opendev.org/c/openstack/tripleo-ansible/+/86641023:12
opendevreviewOliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing  https://review.opendev.org/c/openstack/tripleo-ansible/+/86641023:25
*** rlandy|rover is now known as rlandy|out23:37
opendevreviewOliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing  https://review.opendev.org/c/openstack/tripleo-ansible/+/86641023:47

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!