opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866539 | 02:22 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866539 | 02:23 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866539 | 02:25 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: OVN: Remove unused deployment methods of OVN DB https://review.opendev.org/c/openstack/tripleo-heat-templates/+/855581 | 02:37 |
*** yadnesh|away is now known as yadnesh | 04:30 | |
*** marios is now known as marios|ruck | 06:09 | |
mrjoshi | Hi, looking for reviews on the patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865898 | 06:41 |
*** ysandeep__ is now known as ysandeep|afk | 07:49 | |
*** yadnesh is now known as yadnesh|afk | 08:01 | |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations master: Removing six from modules https://review.opendev.org/c/openstack/tripleo-validations/+/860429 | 08:21 |
opendevreview | Jiri Podivin proposed openstack/validations-common stable/1.6: [stable/1.6 only] Setting default interpreter for tox docs env to generic Python3 https://review.opendev.org/c/openstack/validations-common/+/866551 | 08:27 |
*** khomesh|away is now known as khomesh | 08:39 | |
*** jpena|off is now known as jpena | 08:42 | |
lmiccini | o/ can anybody give https://review.opendev.org/c/openstack/tripleo-ansible/+/865438 a push please? thanks! | 08:47 |
*** ysandeep|afk is now known as ysandeep | 09:10 | |
opendevreview | Daniel Bengtsson proposed openstack/python-tripleoclient master: Fix upgrade playbook path. https://review.opendev.org/c/openstack/python-tripleoclient/+/851856 | 09:13 |
opendevreview | Daniel Bengtsson proposed openstack/python-tripleoclient master: Fix upgrade playbook path. https://review.opendev.org/c/openstack/python-tripleoclient/+/851856 | 09:15 |
damani | hi | 09:16 |
damani | can i have code review here please https://review.opendev.org/c/openstack/tripleo-ansible/+/865514 ? | 09:16 |
damani | and here https://review.opendev.org/c/openstack/tripleo-heat-templates/+/855651 ? | 09:17 |
*** yadnesh|afk is now known as yadnesh | 09:24 | |
mrjoshi | Hi, looking for reviews on the patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865898 | 10:38 |
opendevreview | Takashi Kajinami proposed openstack/tripleo-heat-templates master: Ironic: Fail when creating a tempurl key fails https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866539 | 10:40 |
*** ysandeep is now known as ysandeep|brb | 10:49 | |
opendevreview | Merged openstack/puppet-tripleo master: Enable fence_watchdog configuration in stonith topology https://review.opendev.org/c/openstack/puppet-tripleo/+/863041 | 10:53 |
*** ysandeep|brb is now known as ysandeep | 10:59 | |
*** dviroel|afk is now known as dviroel | 11:05 | |
opendevreview | Sofer Athlan-Guyot proposed openstack/tripleo-ansible master: Fix ovs check pkg_has_restart error. https://review.opendev.org/c/openstack/tripleo-ansible/+/866563 | 11:08 |
opendevreview | Sofer Athlan-Guyot proposed openstack/tripleo-ansible stable/zed: Fix ovs check pkg_has_restart error. https://review.opendev.org/c/openstack/tripleo-ansible/+/866564 | 11:10 |
*** rlandy|out is now known as rlandy|rover | 11:10 | |
opendevreview | Sofer Athlan-Guyot proposed openstack/tripleo-ansible stable/wallaby: Fix ovs check pkg_has_restart error. https://review.opendev.org/c/openstack/tripleo-ansible/+/866565 | 11:10 |
opendevreview | Sofer Athlan-Guyot proposed openstack/tripleo-ansible stable/train: Fix ovs check pkg_has_restart error. https://review.opendev.org/c/openstack/tripleo-ansible/+/866566 | 11:14 |
opendevreview | Luca Miccini proposed openstack/puppet-tripleo stable/zed: Enable fence_watchdog configuration in stonith topology https://review.opendev.org/c/openstack/puppet-tripleo/+/866462 | 11:20 |
opendevreview | Luca Miccini proposed openstack/puppet-tripleo stable/wallaby: Enable fence_watchdog configuration in stonith topology https://review.opendev.org/c/openstack/puppet-tripleo/+/866463 | 11:20 |
opendevreview | Luca Miccini proposed openstack/puppet-tripleo stable/wallaby: Enable fence_watchdog configuration in stonith topology https://review.opendev.org/c/openstack/puppet-tripleo/+/866463 | 11:22 |
opendevreview | Luca Miccini proposed openstack/puppet-tripleo stable/wallaby: Enable fence_watchdog configuration in stonith topology https://review.opendev.org/c/openstack/puppet-tripleo/+/866463 | 11:25 |
*** pojadhav is now known as pojadhav|brb | 11:31 | |
opendevreview | Fernando Díaz Bravo proposed openstack/python-tripleoclient master: bnr - Deprecation note https://review.opendev.org/c/openstack/python-tripleoclient/+/866334 | 11:35 |
*** yadnesh is now known as yadnesh|afk | 11:45 | |
opendevreview | Bogdan Dobrelya proposed openstack/tripleo-ansible master: Syns t-h-t: Fix logs permissions for swtpm https://review.opendev.org/c/openstack/tripleo-ansible/+/865852 | 12:15 |
opendevreview | Bogdan Dobrelya proposed openstack/tripleo-heat-templates stable/wallaby: Run virtqemud with umask 0027 https://review.opendev.org/c/openstack/tripleo-heat-templates/+/865396 | 12:23 |
*** pojadhav|brb is now known as pojadhav | 12:23 | |
*** yadnesh|afk is now known as yadnesh | 12:26 | |
*** frenzy_friday is now known as frenzy_friday|food | 12:40 | |
fultonj | owalsh: marios|ruck in order to resolve the CIX quickly I'd like to merge https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 and backport directly and then do a follow up patch using ansible.inventory.manager | 12:46 |
fultonj | if you concur would you please review ^ ? | 12:46 |
fultonj | fpantano: ^ | 12:46 |
fultonj | I've tested that 866503 resolve the bug in my env with the inventory being genreated from the downstream 17.1 job | 12:47 |
fpantano | fultonj: ack and thanks for the patch, I'll review! | 12:53 |
marios|ruck | fultonj: ack thanks | 13:00 |
fultonj | thx | 13:00 |
*** arxcruz is now known as arx|2023 | 13:08 | |
owalsh | fultonj: so just want to get it working enough to pass the job? but not get it fully working yet (e.g not changing get_inventory_roles_to_hosts() and get_roles_to_svcs_from_inventory()) | 13:24 |
fultonj | owalsh: want to pass the job and fix the bug in its current scope | 13:27 |
fultonj | fast track the working fix, but follow up with the new inventory as requested by ci team | 13:28 |
fultonj | "the new inventory parsing*" | 13:29 |
owalsh | fultonj: ack, IIRC the inventory in that job doesn't include any ceph services so the functions don't return anything | 13:29 |
fultonj | owalsh: it does include ceph services | 13:29 |
fultonj | the problem functions didn't return anything | 13:30 |
fultonj | i fixed them w/ https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 | 13:30 |
fultonj | https://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1/tripleo_ansible/ansible_plugins/modules/ceph_spec_bootstrap.py#176 | 13:30 |
fultonj | the comment in line 176 is is directly from the inventory in that job | 13:31 |
owalsh | fultonj: in the inventory I can see a CephStorage group but no ceph_mgr/ceph_mon/ceph_osd groups | 13:34 |
owalsh | is it going to work for an inventory with those services? | 13:36 |
fultonj | owalsh: yes, it will work for those groups | 13:36 |
*** dasm|off is now known as dasm | 13:38 | |
fultonj | these groups are based on tripleo roles (not ansible roles) | 13:39 |
opendevreview | Merged openstack/tripleo-heat-templates stable/wallaby: Fix trailing slashes in bind-mounts and linting https://review.opendev.org/c/openstack/tripleo-heat-templates/+/863024 | 13:43 |
opendevreview | Merged openstack/tripleo-ansible master: Enable start of FRR for non-root user https://review.opendev.org/c/openstack/tripleo-ansible/+/865438 | 13:43 |
owalsh | fultonj: so get_roles_to_svcs_from_inventory doesn't give the correct result, but it doesn't raise an exception like get_inventory_hosts_to_ips did | 13:48 |
opendevreview | Merged openstack/validations-common stable/1.6: [stable/1.6 only] Setting default interpreter for tox docs env to generic Python3 https://review.opendev.org/c/openstack/validations-common/+/866551 | 13:48 |
opendevreview | Jesse Pretorius proposed openstack/tripleo-upgrade master: [workload_launch] Update µversions for Wallaby & Zed https://review.opendev.org/c/openstack/tripleo-upgrade/+/866578 | 13:51 |
fultonj | owalsh: so can i address that in the follow up patch or do we want to block the quick fix? | 13:54 |
fultonj | there's an argument for not rushing to fix a job | 13:55 |
fultonj | the root cause of the reported bug was that the THT Role CephStorage didn't return any hosts | 13:56 |
fultonj | per the commit message | 13:56 |
fultonj | https://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1//COMMIT_MSG#22 | 13:57 |
owalsh | fultonj: in the BZ the issue is a KeyError | 13:58 |
fultonj | yes, indeed | 13:58 |
owalsh | get_roles_to_svcs_from_inventory will return nothing for that inventory since there are no ceph services | 13:59 |
fultonj | fromline 180 https://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1/tripleo_ansible/ansible_plugins/modules/ceph_spec_bootstrap.py#b180 | 13:59 |
fultonj | key issue was from get_inventory_hosts_to_ips() | 13:59 |
fultonj | issue technically wasn't in get_roles_to_svcs_from_inventory | 14:00 |
owalsh | so the patch would fix that job only, will it just fail at the first job that does have ceph services? | 14:00 |
fultonj | i don't see why this would introduce problems | 14:02 |
fultonj | let's step up one layer | 14:02 |
fultonj | are you concerned my patch as it is right now will break other jobs? | 14:03 |
fultonj | the job we're talking about did have ceph services | 14:03 |
owalsh | is it standalone ceph though, not HCI | 14:04 |
fultonj | it's not standalone | 14:04 |
fultonj | it's multinode downstream | 14:04 |
fultonj | https://bugzilla.redhat.com/show_bug.cgi?id=2149963 | 14:04 |
owalsh | but I don't see any of the ceph_* groups in the inventory | 14:04 |
fultonj | and it will handle hci too | 14:04 |
fultonj | i think you're confusing THT roles with ansible groups | 14:05 |
owalsh | each tripleo service has an ansible group | 14:05 |
owalsh | e.g nova_libvirt, ceph_mon, ceph_mgr, etc.. | 14:05 |
fultonj | owalsh: wait | 14:06 |
fultonj | this is an inventory genereated by baremetal deployment | 14:06 |
fultonj | so those services don't exist yet | 14:07 |
fultonj | they get defined later when the heat stack is deployed | 14:07 |
owalsh | ack, so when I modify the inventory file used in the unit tests to use the new format then the test fail for get_roles_to_svcs_from_inventory | 14:08 |
fultonj | so those details still need to be worked out in my follow up patch based on yours | 14:09 |
fultonj | and i'll start a layered patch on 866503 with those changes | 14:09 |
owalsh | ack. My patch works when I test it manually, but centos9 ansible-core seems to be broken (missing some .py files) so CI is red | 14:10 |
fultonj | owalsh: upstream ci red | 14:10 |
fultonj | owalsh: so i'll work on that | 14:10 |
owalsh | ModuleNotFoundError: No module named 'ansible.module_utils.common.yaml | 14:11 |
fultonj | owalsh: yo ok w/ https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 ? | 14:11 |
fultonj | to address https://bugzilla.redhat.com/show_bug.cgi?id=2149963 quickly? | 14:11 |
fultonj | all i've done is make get_inventory_hosts_to_ips() handle children correctly | 14:12 |
fultonj | s/yo/you :) | 14:13 |
owalsh | fultonj: hrmm, well if it doesn't matter that roles_to_svcs will be wrong then ok, I'm not sure how/where it used | 14:17 |
fultonj | it is used in other cases | 14:18 |
fultonj | the module genereates a ceph spec when we have an inventory from heat or if we don't have an inventory from heat | 14:18 |
fultonj | the case where the bug happended was an inventory not from heat | 14:19 |
owalsh | ok then, can follow up with the CI issue for my patch later | 14:19 |
owalsh | marios|ruck: might need your help for that ^ | 14:20 |
owalsh | fultonj: you want to fix the comment from Francesco first? | 14:21 |
fultonj | ok | 14:21 |
*** yadnesh is now known as yadnesh|away | 14:21 | |
opendevreview | John Fulton proposed openstack/tripleo-ansible master: Handle child groups when building ceph spec from inventory https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 | 14:23 |
fultonj | done | 14:23 |
marios|ruck | owalsh: ok can check after calls | 14:23 |
marios|ruck | owalsh: link? | 14:23 |
fultonj | marios|ruck: quick revote on https://review.opendev.org/c/openstack/tripleo-ansible/+/866503 ? | 14:24 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup https://review.opendev.org/c/openstack/tripleo-validations/+/866581 | 14:24 |
fultonj | https://review.opendev.org/c/openstack/tripleo-ansible/+/866503/1..2/tripleo_ansible/ansible_plugins/modules/ceph_spec_bootstrap.py | 14:24 |
fultonj | fpantano: ^ quick revrote on ^ ? | 14:24 |
fultonj | re-vote* | 14:25 |
fpantano | ack thanks for the update! | 14:25 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup https://review.opendev.org/c/openstack/tripleo-validations/+/866581 | 14:26 |
owalsh | marios|ruck: https://zuul.opendev.org/t/openstack/build/63c22505b39547afbcf3965014a271be | 14:30 |
owalsh | ModuleNotFoundError: No module named 'ansible.module_utils.common.yaml | 14:30 |
owalsh | missing some files in ansible-core? | 14:30 |
opendevreview | Jiri Podivin proposed openstack/validations-common stable/1.6: Bugfix: Add missing become: true to 2 tasks https://review.opendev.org/c/openstack/validations-common/+/864698 | 14:35 |
*** pojadhav is now known as pojadhav|afk | 14:38 | |
*** ysandeep is now known as ysandeep|dinner | 14:52 | |
opendevreview | Jiri Podivin proposed openstack/validations-common stable/1.6: DNM Setting default interpreter for tox docs env to generic Python3 https://review.opendev.org/c/openstack/validations-common/+/866586 | 14:53 |
opendevreview | Bogdan Dobrelya proposed openstack/tripleo-heat-templates master: Convert Nova httpd configurations to new role https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866177 | 15:11 |
opendevreview | Jiri Podivin proposed openstack/validations-common stable/1.6: DNM testing new doc job overrides for stable branches https://review.opendev.org/c/openstack/validations-common/+/866343 | 15:18 |
opendevreview | David Hill proposed openstack/tripleo-ansible master: Fix MTU ping validations https://review.opendev.org/c/openstack/tripleo-ansible/+/866590 | 15:20 |
opendevreview | David Hill proposed openstack/tripleo-ansible master: Fix MTU ping validations https://review.opendev.org/c/openstack/tripleo-ansible/+/866590 | 15:25 |
opendevreview | Jiri Podivin proposed openstack/validations-common stable/1.6: DNM testing new doc job overrides for stable branches https://review.opendev.org/c/openstack/validations-common/+/866343 | 15:29 |
opendevreview | David Hill proposed openstack/tripleo-ansible master: Fix MTU ping validations https://review.opendev.org/c/openstack/tripleo-ansible/+/866590 | 15:34 |
opendevreview | Bogdan Dobrelya proposed openstack/python-tripleoclient master: Do not filter ovn_dbs_vip for multi-cell export https://review.opendev.org/c/openstack/python-tripleoclient/+/866593 | 15:39 |
*** pojadhav|afk is now known as pojadhav | 15:40 | |
opendevreview | John Fulton proposed openstack/tripleo-ansible stable/wallaby: Handle child groups when building ceph spec from inventory https://review.opendev.org/c/openstack/tripleo-ansible/+/866465 | 15:41 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup https://review.opendev.org/c/openstack/tripleo-validations/+/866581 | 15:55 |
opendevreview | Jiri Podivin proposed openstack/tripleo-validations master: Adding graceful failure condition to options dictionary lookup https://review.opendev.org/c/openstack/tripleo-validations/+/866581 | 16:00 |
Tengu | folks, care to have a look at this backport? https://review.opendev.org/c/openstack/tripleo-common/+/865390 thanks! | 16:00 |
*** dviroel is now known as dviroel|lunch | 16:00 | |
*** ysandeep|dinner is now known as ysandeep | 16:13 | |
*** ysandeep is now known as ysandeep|out | 16:15 | |
fultonj | Tengu: I +2 +w'd the clean cherry pick ^ | 16:21 |
Tengu | fultonj: thanks! | 16:22 |
fultonj | np | 16:24 |
*** frenzy_friday|food is now known as frenzy_friday | 16:24 | |
opendevreview | Juan Badia Payno proposed openstack/tripleo-ansible stable/zed: [ffwd3] Use tripleo tags in network extraction https://review.opendev.org/c/openstack/tripleo-ansible/+/866466 | 16:31 |
*** marios|ruck is now known as marios|out | 16:35 | |
owalsh | marios|ruck, fultonj: I think the issue with the ansible.module_utils.common.yaml is due to https://docs.ansible.com/ansible/latest/dev_guide/developing_module_utilities.html#using-and-developing-module-utilities | 16:39 |
owalsh | "The ansible.module_utils namespace is not a plain Python package: it is constructed dynamically for each task invocation, by extracting imports and resolving those matching the namespace against a search path derived from the active configuration" | 16:39 |
owalsh | I think it would be safer to avoid the dependency on the core ansible.inventory classes - doubt it's safe to assume they will exist on the remote host. I'll re-implement using python stdlib instead | 16:50 |
*** dviroel|lunch is now known as dviroel | 16:51 | |
opendevreview | Juan Badia Payno proposed openstack/tripleo-ansible stable/wallaby: [ffwd3] Use tripleo tags in network extraction https://review.opendev.org/c/openstack/tripleo-ansible/+/866467 | 17:13 |
opendevreview | Bogdan Dobrelya proposed openstack/python-tripleoclient master: Also export OVN_DBs_IPs for multi-stack inputs https://review.opendev.org/c/openstack/python-tripleoclient/+/866593 | 17:17 |
opendevreview | Merged openstack/tripleo-validations master: Changing mount parameter of podman task to volume https://review.opendev.org/c/openstack/tripleo-validations/+/866438 | 17:23 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Make sure patch reports issues and ignores test files https://review.opendev.org/c/openstack/tripleo-upgrade/+/866468 | 17:35 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Make sure patch reports issues and ignores test files https://review.opendev.org/c/openstack/tripleo-upgrade/+/866468 | 17:37 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Improve patch download https://review.opendev.org/c/openstack/tripleo-upgrade/+/866469 | 17:44 |
opendevreview | Juan Badia Payno proposed openstack/tripleo-upgrade stable/wallaby: Make sure patch reports issues and ignores test files https://review.opendev.org/c/openstack/tripleo-upgrade/+/866468 | 17:51 |
opendevreview | Merged openstack/tripleo-heat-templates master: Configure a step when the old ironic-api configuration is cleaned https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866373 | 17:51 |
*** dviroel is now known as dviroel|afk | 17:52 | |
*** jpena is now known as jpena|off | 17:58 | |
opendevreview | Juan Badia Payno proposed openstack/ansible-role-collect-logs master: Collect ~/.ssh/config file https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/866618 | 18:24 |
opendevreview | Merged openstack/tripleo-common stable/zed: By default, unset everything proxy related for healthcheck https://review.opendev.org/c/openstack/tripleo-common/+/865390 | 19:05 |
-opendevstatus- NOTICE: The lists.opendev.org and lists.zuul-ci.org sites will be offline briefly for migration to a new server | 20:03 | |
opendevreview | Chris Sibbitt proposed openstack/tripleo-ansible stable/wallaby: Fix molecule failures in tripleo_collectd https://review.opendev.org/c/openstack/tripleo-ansible/+/866215 | 20:19 |
csibbitt | Hi y'all; I'd like to request a final review + merge on a patch to fix CI tests. https://review.opendev.org/c/openstack/tripleo-ansible/+/865465 (master) and https://review.opendev.org/c/openstack/tripleo-ansible/+/865888 (zed) | 21:37 |
opendevreview | Chris Sibbitt proposed openstack/tripleo-ansible stable/wallaby: Fix molecule failures in tripleo_collectd https://review.opendev.org/c/openstack/tripleo-ansible/+/866215 | 21:43 |
*** dviroel|afk is now known as dviroel | 22:01 | |
opendevreview | David Vallee Delisle proposed openstack/tripleo-heat-templates stable/train: [TRAIN-ONLY] Passing NovaComputeOpt{Volumes,EnvVars} to hybrid containers https://review.opendev.org/c/openstack/tripleo-heat-templates/+/866238 | 22:18 |
opendevreview | Merged openstack/tripleo-upgrade stable/wallaby: Improve patch download https://review.opendev.org/c/openstack/tripleo-upgrade/+/866469 | 22:33 |
opendevreview | Merged openstack/os-net-config master: Avoid reconfiguring SR-IOV devices during stack update https://review.opendev.org/c/openstack/os-net-config/+/866312 | 22:46 |
*** dasm is now known as dasm|off | 22:51 | |
opendevreview | Oliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing https://review.opendev.org/c/openstack/tripleo-ansible/+/866410 | 23:07 |
opendevreview | Oliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing https://review.opendev.org/c/openstack/tripleo-ansible/+/866410 | 23:12 |
opendevreview | Oliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing https://review.opendev.org/c/openstack/tripleo-ansible/+/866410 | 23:25 |
*** rlandy|rover is now known as rlandy|out | 23:37 | |
opendevreview | Oliver Walsh proposed openstack/tripleo-ansible master: WIP: fix ceph_spec_bootstrap inventory parsing https://review.opendev.org/c/openstack/tripleo-ansible/+/866410 | 23:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!