openstackgerrit | Merged openstack-infra/zuul: Re-enable requirement reject tests https://review.openstack.org/401063 | 00:22 |
---|---|---|
*** bhavik has joined #zuul | 04:03 | |
*** bhavik has quit IRC | 04:08 | |
*** saneax-_-|AFK is now known as saneax | 04:23 | |
*** bhavik has joined #zuul | 04:41 | |
*** willthames has quit IRC | 06:18 | |
*** openstackgerrit_ has joined #zuul | 06:24 | |
*** openstackgerrit_ has quit IRC | 06:25 | |
*** openstackgerrit_ has joined #zuul | 06:26 | |
*** openstackgerrit_ has quit IRC | 06:27 | |
*** openstackgerrit_ has joined #zuul | 06:35 | |
*** openstackgerrit_ has quit IRC | 06:35 | |
*** yolanda has joined #zuul | 06:58 | |
*** openstackgerrit_ has joined #zuul | 06:59 | |
*** openstackgerrit_ has quit IRC | 07:00 | |
*** abregman has joined #zuul | 07:51 | |
*** hashar has joined #zuul | 08:55 | |
*** Cibo_ has quit IRC | 09:20 | |
*** Cibo_ has joined #zuul | 10:08 | |
*** bhavik has quit IRC | 11:07 | |
*** hashar is now known as hasharLunch | 11:35 | |
*** abregman is now known as abregman|mtg | 12:14 | |
*** abregman_ has joined #zuul | 12:22 | |
*** abregman_ has quit IRC | 12:25 | |
*** abregman|mtg has quit IRC | 12:25 | |
*** abregman has joined #zuul | 12:25 | |
*** saneax is now known as saneax-_-|AFK | 12:33 | |
*** abregman is now known as abregman|mtg | 12:39 | |
*** hasharLunch is now known as hashar | 13:39 | |
*** abregman|mtg has quit IRC | 13:53 | |
*** abregman has joined #zuul | 13:54 | |
*** abregman is now known as abregman|mtg | 14:08 | |
*** yolanda has quit IRC | 14:11 | |
*** yolanda has joined #zuul | 14:13 | |
*** saneax-_-|AFK is now known as saneax | 14:13 | |
*** yolanda has quit IRC | 14:15 | |
*** yolanda has joined #zuul | 14:15 | |
*** jamielennox is now known as jamielennox|away | 14:38 | |
*** Cibo_ has quit IRC | 14:44 | |
*** abregman|mtg is now known as abregman | 14:44 | |
*** jamielennox|away is now known as jamielennox | 14:45 | |
*** saneax is now known as saneax-_-|AFK | 15:08 | |
*** bhavik1 has joined #zuul | 15:19 | |
*** saneax-_-|AFK is now known as saneax | 15:32 | |
*** abregman has quit IRC | 15:45 | |
*** saneax is now known as saneax-_-|AFK | 16:01 | |
*** saneax-_-|AFK is now known as saneax | 16:16 | |
*** Cibo_ has joined #zuul | 16:55 | |
*** saneax is now known as saneax-_-|AFK | 17:06 | |
*** Shuo has joined #zuul | 17:11 | |
jeblair | Shrews, pabelanger, clarkb, mordred: i think the main thing i would like to address before we merge the branch that wasn't on our production blocker list is what to do about identifying the image uploads. during dev, we realized that we can't say "image-delete 1234" anymore, we have to say "image delete <image name> <build id> <provider> <upload id>" which is not super convenient. | 17:15 |
jeblair | Shrews, pabelanger, clarkb, mordred: if we care about that enough to come up with another solution, that would be good to do before merging | 17:16 |
jeblair | solutions which jump out at me are: a) generate uuids for uploads. b) use a global sequence generator to get unique sequential ids for uploads. c) decide that we probably won't delete individual uploads that much anyway, so leave it as is. | 17:17 |
mordred | jeblair: role spec update looks good | 17:18 |
jeblair | mordred: w00t | 17:19 |
mordred | jeblair: I tend towards c in my thinking- as the usual reason for deleting an image is bad content which usually applies across the board and is not specific to a single upload | 17:19 |
jeblair | mordred: yeah | 17:22 |
*** Shuo has quit IRC | 17:25 | |
jeblair | mordred: can you take a lookt at https://review.openstack.org/223333 when you have a chance? | 17:44 |
mordred | jeblair: I have 2 concerns that feel more like unimportant quibbles ... one being addeding sqlalchemy as a dep across the board instead of just adding it to the mysql_reporter extras entry - the second is that String(255) seems big for zuul_def and ref, which really should have a well-known number of characters - but I'm pretty sure those are just nitpicky and not important | 17:53 |
*** openstack has joined #zuul | 18:01 | |
jeblair | mordred: i agree we could probably constrain zuul_ref though | 18:01 |
jeblair | mordred: oh, zuul_ref might also contain a branch | 18:02 |
mordred | jeblair: so maybe just leaving well enough alone for now | 18:03 |
jeblair | mordred: yeah, maybe so. it uses alembic. :) | 18:04 |
mordred | jeblair: bombs away then | 18:04 |
jeblair | mordred: as for deps, yeah... we could probably do some conditional imports to fix that... but maybe we can do that later. | 18:04 |
jeblair | mordred: (and my WIP patch for drivers should make that easier in v3) | 18:05 |
mordred | \o/ | 18:06 |
clarkb | jeblair: all that info is available in the default output for dib-image-list right? | 18:06 |
clarkb | or is it image-list? as long as the info is readily available the extra typing doesn't bother me too much since its rare that we need it | 18:06 |
jeblair | clarkb: yes: image-list | 18:07 |
*** harlowja has joined #zuul | 18:20 | |
*** Shuo has joined #zuul | 18:30 | |
*** bhavik1 has quit IRC | 19:37 | |
*** jamielennox is now known as jamielennox|away | 19:46 | |
*** Shuo has quit IRC | 19:52 | |
*** jamielennox|away is now known as jamielennox | 19:53 | |
adam_g | is it correct that BuildSet.commit is only ever set after a merge? | 20:50 |
adam_g | or rather: it is not expected to be set after a launcher merge, only after an upstream merge | 20:53 |
*** Cibo_ has quit IRC | 21:30 | |
*** Cibo_ has joined #zuul | 21:30 | |
morgan | I will try and be on for the meeting | 21:30 |
morgan | might be a little late dropping someone off at the train. and finishing packing. | 21:30 |
jeblair | adam_g: in v2, it was set by the merger so it would be set before a job ran for any kind of change... we may want to think about removing it entirely if we can get away with it not being used. | 21:52 |
jeblair | it's zuul meeting time in #openstack-meeting-alt | 22:00 |
jhesketh | Morning | 22:01 |
adam_g | jeblair: yeah. not sure what hte uses would be for it being attached to the merge event | 22:01 |
*** dmsimard has quit IRC | 22:26 | |
*** rcarrillocruz has quit IRC | 23:05 | |
*** Shuo has joined #zuul | 23:15 | |
openstackgerrit | Adam Gandelman proposed openstack-infra/zuul: Move and re-enable test_build_configuration_* https://review.openstack.org/409376 | 23:17 |
*** willthames has joined #zuul | 23:19 | |
*** rcarrillocruz has joined #zuul | 23:20 | |
pabelanger | jeblair: mordred: Shrews: clarkb: personally, I think I'll be using dib-image-delete if I wanted to nuke an upload to all providers, since that was easy to use on Thursday of last week | 23:24 |
pabelanger | using the 4 args from image-list is just too hard for me to parse quickly | 23:24 |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool: Make diskimage-builder command configurable for testing https://review.openstack.org/404976 | 23:30 |
openstackgerrit | Paul Belanger proposed openstack-infra/nodepool: Properly cleanup failed diskimage builds https://review.openstack.org/409327 | 23:30 |
*** rcarrillocruz has quit IRC | 23:38 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!