| jeblair | Shrews: yeah, i think you're right -- using DataWatcher we can probably drop the re-connect event queue stuff i just wrote :) | 00:21 |
|---|---|---|
| jeblair | my initial stab at that looks promising; i just need to clean it up a bit before i push it up | 00:22 |
| *** saneax is now known as saneax-_-|AFK | 00:42 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Re-submit node requests on ZooKeeper disconnect https://review.openstack.org/416357 | 01:03 |
| jeblair | Shrews: considerably less code, and, I think, much more simple and self-contained. thanks! :) | 01:04 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Re-submit node requests on ZooKeeper disconnect https://review.openstack.org/416357 | 01:08 |
| *** ianw is now known as ianw_pto | 02:07 | |
| *** jamielennox is now known as jamielennox|away | 03:51 | |
| *** jamielennox|away is now known as jamielennox | 03:59 | |
| openstackgerrit | Jamie Lennox proposed openstack-infra/nodepool: Ensure env-vars are strings in config validate https://review.openstack.org/416427 | 04:02 |
| *** saneax-_-|AFK is now known as saneax | 04:53 | |
| *** bhavik1 has joined #zuul | 06:07 | |
| *** bhavik1 has quit IRC | 06:34 | |
| *** Cibo_ has joined #zuul | 07:42 | |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul: Cloner: use zuul_url always when project set https://review.openstack.org/389851 | 07:58 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul: Cloner: add extra project test https://review.openstack.org/389852 | 07:58 |
| *** saneax is now known as saneax-_-|AFK | 08:44 | |
| *** Cibo_ has quit IRC | 09:03 | |
| *** saneax-_-|AFK is now known as saneax | 09:03 | |
| *** hashar has joined #zuul | 09:19 | |
| *** rcarrillocruz has quit IRC | 10:49 | |
| *** bhavik1 has joined #zuul | 11:07 | |
| *** bhavik1 has quit IRC | 11:12 | |
| *** saneax is now known as saneax-_-|AFK | 11:23 | |
| *** openstackgerrit has quit IRC | 12:33 | |
| *** rcarrillocruz has joined #zuul | 13:03 | |
| *** bhavik1 has joined #zuul | 14:10 | |
| *** bhavik1 has quit IRC | 14:19 | |
| *** openstackgerrit has joined #zuul | 15:28 | |
| openstackgerrit | Kevin Prettre proposed openstack-infra/zuul: Fix infinite loop when Gerrit close connection https://review.openstack.org/416586 | 15:28 |
| pabelanger | Yay, tickets obtained for OpenStack PTG | 15:34 |
| Shrews | about that... jeblair, fungi: are there certain days assigned at PTG where zuulv3 things will be discussed where my attending might be useful? | 15:45 |
| Shrews | i'd be willing to come for a day or two if there are discussions around it, but spending 5 days in Atlanta is not something I want to do | 15:47 |
| fungi | Shrews: i have similar disdain for atlanta | 15:48 |
| fungi | Shrews: infra's assigned days are monday and tuesday | 15:48 |
| fungi | so if you're looking to make it a short trip, those would be the two to target | 15:48 |
| Shrews | fungi: it should have been held at Hilton Head :) | 15:50 |
| pabelanger | Ya, that's my plan too. Aim for monday and tuesday | 15:55 |
| pabelanger | wednesday - friday is day by day right now | 15:55 |
| fungi | Shrews: so true | 15:58 |
| *** pabelanger has quit IRC | 16:19 | |
| *** pabelanger has joined #zuul | 16:19 | |
| *** hashar has quit IRC | 17:05 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Re-submit node requests on ZooKeeper disconnect https://review.openstack.org/416357 | 17:11 |
| SpamapS | I quite enjoyed Hotlanta last time | 17:14 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool: Add getNodeRequest ZK API method https://review.openstack.org/416671 | 17:15 |
| Shrews | SpamapS: you shut your mouth. we do not speak of last time | 17:16 |
| Shrews | never happened | 17:16 |
| Shrews | jeblair: i chose to use the kazoo recipe for 671 ^^^. I quite liked the logic | 17:17 |
| Shrews | and it still works with how you are putting items into the queue | 17:17 |
| SpamapS | using kazoo recipes++ | 17:18 |
| Shrews | SpamapS: well, some of them have a big red warning flag not to use them :) | 17:18 |
| SpamapS | Of course | 17:19 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool: Add getNodeRequest ZK API method https://review.openstack.org/416671 | 17:24 |
| jeblair | Shrews: the recipe removes items from the queue, but we can not do that | 17:26 |
| Shrews | jeblair: ugh | 17:27 |
| Shrews | yeah, you're right | 17:27 |
| Shrews | well, i can copy the code i guess | 17:27 |
| Shrews | minus the delete() part | 17:27 |
| jeblair | Shrews: well, i don't really think it's the same thing at all | 17:27 |
| jeblair | Shrews: we just need to walk the queue in sorted order, then lock the request using the side-band lock | 17:28 |
| Shrews | ah right. we do need that locked | 17:29 |
| Shrews | jeblair: from the spec, "If at any point Nodepool detects that the ephemeral request node has been deleted, it should return any allocated nodes to the pool." | 17:38 |
| Shrews | jeblair: so, nodepool will not know that a request node has been deleted unless we set a watch on it (not specified in the spec, i don't think) | 17:39 |
| Shrews | jeblair: also, the mapping of the node ids used for that request is gone once a request is deleted. how do we know what nodes to delete? | 17:40 |
| *** bhavik1 has joined #zuul | 17:41 | |
| jeblair | Shrews: yeah, setting a watch is an option, or perhaps the thread that's handling the request could check on it at certain points during the process, or in the very edge case of it being deleted after fulfillment but before use, a periodic cleanup thread could handle it. | 17:41 |
| *** bhavik1 has quit IRC | 17:42 | |
| Shrews | that edge case is what i'm wondering about. we'd need to store the request ID with the nodes, i think | 17:43 |
| jeblair | Shrews: re the second thing: the spec says that zuul should lock the nodes before deleting the request, so nodepool always has a way of determining if a request has been "abandoned" -- either the request is deleted (before node use), or the node locks vanish (after node use) | 17:43 |
| jeblair | (i'm writing the 'zuul locks nodes' bit right now) | 17:46 |
| Shrews | k. i think i follow that bit better now after mapping it about my head | 17:47 |
| *** bhavik1 has joined #zuul | 17:57 | |
| *** bhavik1 has quit IRC | 18:00 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Lock nodes when nodepool request is fulfilled https://review.openstack.org/416700 | 18:34 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool: Add ZK API methods for node requests https://review.openstack.org/416671 | 18:37 |
| *** dmsimard has quit IRC | 19:35 | |
| *** dmsimard has joined #zuul | 19:35 | |
| *** pabelanger has quit IRC | 19:36 | |
| *** SotK has quit IRC | 19:36 | |
| *** adam_g has quit IRC | 19:36 | |
| *** bstinson has quit IRC | 19:36 | |
| *** Zara has quit IRC | 19:36 | |
| *** tristanC has quit IRC | 19:36 | |
| *** clarkb has quit IRC | 19:36 | |
| *** tristanC has joined #zuul | 19:36 | |
| *** bstinson has joined #zuul | 19:36 | |
| *** SotK has joined #zuul | 19:36 | |
| *** Zara has joined #zuul | 19:36 | |
| *** adam_g has joined #zuul | 19:36 | |
| *** pabelanger has joined #zuul | 19:36 | |
| *** clarkb has joined #zuul | 19:36 | |
| *** adam_g has quit IRC | 19:36 | |
| *** adam_g has joined #zuul | 19:36 | |
| *** hashar has joined #zuul | 20:29 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Lock nodes when nodepool request is fulfilled https://review.openstack.org/416700 | 20:39 |
| *** hashar has quit IRC | 21:02 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Mark nodes as 'in-use' before launching jobs https://review.openstack.org/416737 | 21:18 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Return nodes after use https://review.openstack.org/416739 | 21:29 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Lock nodes when nodepool request is fulfilled https://review.openstack.org/416700 | 21:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Return nodes after use https://review.openstack.org/416739 | 21:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Mark nodes as 'in-use' before launching jobs https://review.openstack.org/416737 | 21:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Return nodes after use https://review.openstack.org/416739 | 21:49 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Mark nodes as 'in-use' before launching jobs https://review.openstack.org/416737 | 21:49 |
| jhesketh | Morning | 21:50 |
| *** openstack has joined #zuul | 22:56 | |
| *** jamielennox is now known as jamielennox|away | 23:11 | |
| *** jamielennox|away is now known as jamielennox | 23:14 | |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Lock nodes when nodepool request is fulfilled https://review.openstack.org/416700 | 23:29 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Return nodes after use https://review.openstack.org/416739 | 23:29 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Mark nodes as 'in-use' before launching jobs https://review.openstack.org/416737 | 23:29 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Copy nodeset when making node requests https://review.openstack.org/416772 | 23:29 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Lock nodes when nodepool request is fulfilled https://review.openstack.org/416700 | 23:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Return nodes after use https://review.openstack.org/416739 | 23:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Mark nodes as 'in-use' before launching jobs https://review.openstack.org/416737 | 23:45 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul: Copy nodeset when making node requests https://review.openstack.org/416772 | 23:45 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!