Tuesday, 2017-01-31

*** saneax is now known as saneax-_-|AFK00:34
*** jamielennox is now known as jamielennox|away00:58
*** jamielennox|away is now known as jamielennox01:12
*** abregman has joined #zuul05:52
*** saneax-_-|AFK is now known as saneax06:36
*** Cibo_ has quit IRC08:16
*** Cibo_ has joined #zuul08:17
*** hashar has joined #zuul09:29
*** Cibo_ has quit IRC10:34
*** Cibo_ has joined #zuul10:38
mordredSpamapS: there is never enough distracting11:59
*** Cibo_ has quit IRC12:21
openstackgerritMerged openstack-infra/nodepool: Merge branch 'master' into feature/zuulv3  https://review.openstack.org/42497412:21
openstackgerritMerged openstack-infra/nodepool: Create mandatory /etc/nodepool for later use  https://review.openstack.org/42400012:21
openstackgerritMerged openstack-infra/nodepool: Removed redundant 'the'  https://review.openstack.org/42052512:21
openstackgerritMerged openstack-infra/nodepool: Ensure env-vars are strings in config validate  https://review.openstack.org/41642712:24
openstackgerritMerged openstack-infra/zuul: Re-enable test_dependent_behind_dequeue  https://review.openstack.org/41376812:43
openstackgerritMerged openstack-infra/zuul: Correct comments in requirement test cases  https://review.openstack.org/42290012:54
*** saneax is now known as saneax-_-|AFK13:30
openstackgerritMerged openstack-infra/zuul: Add zuul->np test for invalid node type  https://review.openstack.org/42568613:36
Shrewsjeblair: mordred: i wish there were some way to "share" that experimental integration test. it pretty much one-way right now13:43
*** abregman has quit IRC13:47
*** saneax-_-|AFK is now known as saneax14:19
mordredShrews: what do you mean by share it? we should be able to add it to the experimental pipeline of both projects?14:20
Shrewsmordred: right now, i don't know if i break any of the tests with a nodepool change until after it merges. would be nice to know beforehand14:21
mordredShrews: in that case, it might be worthwhile to make the test a nonvoting check job and add it to both zuul and nodepool14:23
*** saneax is now known as saneax-_-|AFK14:52
*** hashar has quit IRC15:11
jeblairShrews, mordred: it is on both zuul and nodepool15:33
jeblair(and it wouldn't be much of an integration test if it didn't test both things)15:34
Shrewsjeblair: oh? so i can 'check experimental' on a nodepool change?15:35
jeblairShrews: yes15:35
Shrewswell then... ignore me15:35
morganjeblair: wooo i feel good i had an understanding of where we are/were ;)16:29
mordredjeblair: https://review.openstack.org/#/c/426578 from pabelanger if you have a sec - it fixes a bug which is currently causing nodepool dsvm jobs to run long and flirt with the job timeout17:25
jeblairmordred, pabelanger: it would be neat if we could make that safe by default.  i forsee this happening a lot otherwise.  :)17:26
mordredjeblair: although I'm a little concerned about the unittest failure17:26
mordredjeblair: ++17:26
jeblairmordred, pabelanger: maybe an env var that lists things that should be unpaused, and if the image is not in that variable, consider it paused.  that would be fun bash to write.17:27
openstackgerritMerged openstack-infra/zuul: Cloner: use zuul_url always when project set  https://review.openstack.org/38985117:56
*** jamielennox is now known as jamielennox|away17:58
*** Cibo_ has joined #zuul18:12
*** timrc has quit IRC18:25
*** jlk has quit IRC18:26
*** Shuo has joined #zuul18:27
openstackgerritMerged openstack-infra/nodepool: Fix fedora 25 pause bug with devstack  https://review.openstack.org/42657818:29
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Add storeNode ZK API method  https://review.openstack.org/42735318:44
Shrewsnew API method i'll need for an upcoming change ^^^^18:46
Shrewscurrent body of work is getting pretty large, so trying to break it up18:46
mordredShrews: I see what I think is an error - although it's not actually an error in that patch18:48
*** jlk has joined #zuul18:48
Shrewsmordred: \o/18:48
Shrewsmordred: responded! thx18:50
Shrewsmordred: and hopefully my rambling made some sort of sense18:52
mordredShrews: AH. makes sense - it read to me like a type/mistake, but your rambling makes sense18:53
Shrewsmordred: the setter is easy to miss18:53
mordredwell - no, I'm just dumb - I saw the setter - but still thought that self.id in the ctr was a typo :)18:54
Shrewsit was fixing a mistake where i never set the uninitialized value to None. should have included that in the commit msg i guess18:55
Shrewsadded another inline comment for others18:56
*** Cibo_ has quit IRC19:05
*** Cibo_ has joined #zuul19:13
*** SpamapS has quit IRC19:39
*** SpamapS has joined #zuul19:41
*** Cibo_ has quit IRC19:48
SpamapShmm20:06
SpamapSwhen I try to run a single unit test today, it just fails on zookeeper20:06
SpamapShttp://paste.openstack.org/show/597083/20:07
SpamapSShrews: ^ jeblair ?20:07
ShrewsSpamapS: did you start a zookeeper?20:07
SpamapSuh, no?20:07
SpamapStox needs a zk running now?20:07
Shrewsyeah20:08
SpamapSoh that's silly. We can just start one in the test suite as a test resource.20:08
jeblaireither locally or set NODEPOOL_ZK_HOST20:08
SpamapSon a random port20:08
ShrewsSpamapS: we used to do that20:08
SpamapSbut?20:09
ShrewsSpamapS: this docker image works lovely for me:  https://hub.docker.com/r/jplock/zookeeper/20:09
Shrewsiirc, turned out to be a pain. and it wasn't how we (mostly I, at the time) was testing it20:10
jeblairyeah, ensuring it was started correctly was finicky, and new zk versions made it worse20:11
SpamapSbummer20:11
SpamapSwe had very few problems back in the juju days doing it that way20:11
SpamapS(the main problem was packaging zookeeper, which we did. ;)20:11
jeblairi just started running one locally on my workstation (which is what the unit test nodes do too).  Shrews is happy with the docker solution.  and it does use chroots, so it doesn't muck with anything else in the zookeeper.20:12
Shrewsdocker start zk ; tox -epy27   FTW20:13
SpamapSI'm having trouble getting it running on my WS20:13
SpamapSdocker is borked because I'm using an rc build of the kernel20:13
SpamapSand apt-get install zookeeper didn't seem to start a zookeeper20:14
Shrewseww20:14
jeblairSpamapS: there's a second package for the init script20:14
jeblairSpamapS: zookeeperd20:14
SpamapSzookeeperd20:14
SpamapShaha this is funny20:14
SpamapSI believe I argued for that split. :)20:14
jeblairSpamapS: yeah, i kinda like it :)20:14
SpamapSI argued for it because juju ran zookeeper on its own, and I didn't want zk always running on my laptop. ;)20:15
Shrewsyep. exactly why i use the docker solution20:15
SpamapSI can always just apt-get remove it :)20:15
Shrewsi have sparse amounts of memory as it is20:15
SpamapSShrews: yeah normally I'd prefer that, but I have blocked myself by trying to track down intel graphics driver bugs for the kernel team. ;)20:15
SpamapSOh I have plenty of memory, but zk will trash your SSD20:16
SpamapSit's always writing checkpoints20:16
SpamapSand keeping your disk from sleeping20:16
SpamapSnot exactly something they designed with laptops in mind :)20:16
jeblairSpamapS: maybe it can be configured to write checkpoints to a tmpfs?20:17
jeblairSpamapS: related: export ZUUL_TEST_ROOT=/tmpfs20:17
jeblairSpamapS: is in my .bashrc20:17
SpamapSthat would be ideal yeah20:17
jeblairSpamapS: (so the git repo thrashing happens there)20:17
SpamapSyeah I took your advice on that one and mounted a tmpfs for just that reason20:17
SpamapSshaved about 10s off the run20:17
jeblairoh good i'm repeating myself :)20:17
jeblairgotta run grab lunch now20:18
* Shrews images jeblair running down a gazelle for lunch like a cheetah20:19
Shrewsimagines*20:19
Shrewsimagins*?  gah20:19
Shrewsme no spelly goodly20:19
openstackgerritMonty Taylor proposed openstack-infra/nodepool: Start nodepool in the test-config phase  https://review.openstack.org/42739020:21
mordredjeblair: ^^20:21
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool: Replace NodeRequestWorker with NodeRequestHandler  https://review.openstack.org/42739320:24
Shrewsah, wunderbar! check experimental does work for ^^^. bonus that i didn't break the one passing test20:31
mordredShrews: \o/20:33
*** Shuo has quit IRC21:02
mordredShrews, jeblair: nodepool test still failing - but I don't see any errors in the logs :( http://logs.openstack.org/90/427390/1/check/gate-dsvm-nodepool/9bdc346/logs/screen-nodepool.txt.gz21:22
Shrewsmordred: uh, hrm21:25
ShrewsTASK [copy console log]   <--- why is that the last line of ansible_log.txt ?21:25
mordredShrews: because it can't log anything else to the file after it has copied the log that it logs to?21:26
Shrewsi don't understand why that errored. weird21:28
mordredme either. the nodepool log shows 2017-01-31 21:19:39,573 DEBUG nodepool.NodePool:   Deficit: ubuntu-trusty: 0 (start: 0 min-ready: 1 ready: 1 capacity: 4)21:34
mordredbut then nodepool list is showing the node in building state21:35
jeblairhttp://logs.openstack.org/90/427390/1/check/gate-dsvm-nodepool/9bdc346/logs/screen-nodepool.txt.gz#_2017-01-31_20_55_46_18621:38
jeblairthat ssh warning seems to be the last interaction with the node21:38
jeblairi'm guessing the ssh connectivity test never finished?21:38
mordredjeblair: well, at least it was able to connect to the node21:40
mordred:)21:40
jeblairmordred, Shrews: i would have expected some sort of timeout message afterwords though; i think we only wait a few mins?21:42
jeblairthough maybe it got caught it some unbreakable paramiko thing21:42
mordredjeblair: I'm quite tempted to make a patch that adds in a ton more logging just to see where it's going south21:43
jeblair++21:45
openstackgerritMonty Taylor proposed openstack-infra/nodepool: DNM - Print debugging ftw  https://review.openstack.org/42747121:47
mordredjeblair: the test-config patch does seem to have fixed the nova exception we were getting earlire21:48
*** jamielennox|away is now known as jamielennox22:15
*** Shuo has joined #zuul22:15
*** jeblair has quit IRC22:16
openstackgerritMonty Taylor proposed openstack-infra/nodepool: Revert "Create mandatory /etc/nodepool for later use"  https://review.openstack.org/42748622:19
*** jeblair has joined #zuul22:22
mordredjeblair: welcome back! I have a patch up to revert a patch that was recently landed in nodepool ... as well as a held node: 2001:4800:1ae1:18:f816:3eff:fef9:9b8f in case you care to look22:23
mordredjeblair: Revert "Create mandatory /etc/nodepool for later use"  https://review.openstack.org/42748622:23
jeblairyeah, there's a reason why we don't do that22:33
jeblairnodepool user doesn't have perms for that22:33
jeblairand who says the nodepool-base element is optional?22:33
jeblairnodepool doesn't care about what's on the image except: (a) it can log into the server.  (b) it can write to /etc/nodepool22:35
jeblairthat's definitely a requirement22:35
jeblairpabelanger, mordred: ^ fyi22:35
mordredjeblair: nod.22:35
jeblairmordred: thanks for finding that and the fix.  can we add a comment there so that people won't be tempted to do that again22:37
mordredjeblair: yah22:38
mordredjeblair: I'm going to do that as follow up since I already have a couple of depends-on things pointed at that patch and there's no real need for more churn22:38
jeblairmordred: ok22:39
jeblairmordred: are you still waiting on test results to confirm that?22:40
mordredjeblair: I'm not. I'm fairly darned confident22:40
jeblairmordred: er, to rephrase, tests that would confirm that haven't returned yet, right? :)22:40
mordredjeblair: I am tailing the nodepool log on the bad node - last print was 2017-01-31 22:13:06,026 INFO nodepool.NodeLauncher: Creating config dir22:41
mordredjeblair: and have not gotten "Created config dir" - and it's been there for about 15 minutes22:41
jeblairmordred: yeah, i agree, i expect the sudo to hand because sudo over ssh is hard :)22:41
jeblairsudo to *hang*22:41
mordredjeblair: but yes - the tests that confirm the revert are still running :)22:41
openstackgerritMonty Taylor proposed openstack-infra/nodepool: Add comment explaining test-not-create behavior  https://review.openstack.org/42749122:43
mordredjeblair: thereyago22:43
jeblairmordred: cool,  should at least make us think twice22:43
mordredjeblair: so that one and the two before it should make everything happy again22:43
jeblairmordred: i also added some thoughts to the original change: https://review.openstack.org/42400022:44
openstackgerritJames E. Blair proposed openstack-infra/zuul: Run pre and post playbooks  https://review.openstack.org/42749422:50
jeblairmordred: ^ let me know what you think of that.  i think that's about ready to work on adding the secure ansible module stuff from v2.5 back in22:51
openstackgerritJames E. Blair proposed openstack-infra/zuul: Run pre and post playbooks  https://review.openstack.org/42749422:55
openstackgerritJames E. Blair proposed openstack-infra/zuul: Run pre and post playbooks  https://review.openstack.org/42749422:59
*** saneax-_-|AFK is now known as saneax23:01
jeblairmordred: the main nodepool dsvm job passed, but not the -src one... is that expected?23:12
jeblairhttp://logs.openstack.org/86/427486/1/check/gate-dsvm-nodepool-src-nv/e0e63b6/logs/devstacklog.txt.gz#_2017-01-31_22_36_48_89323:12
jeblairmordred: oh, i bet the -src job needs the same service enablement change as the main one23:16
openstackgerritMerged openstack-infra/nodepool: Start nodepool in the test-config phase  https://review.openstack.org/42739023:17
jeblairremote:   https://review.openstack.org/427503 Update nodepool-src-dsvm to disable services23:19
jeblairmordred: ^23:19
jeblairmordred: i've approved the other changes based on that explanation :)23:19
openstackgerritMerged openstack-infra/nodepool: Revert "Create mandatory /etc/nodepool for later use"  https://review.openstack.org/42748623:22
openstackgerritMerged openstack-infra/nodepool: Add comment explaining test-not-create behavior  https://review.openstack.org/42749123:22
mordredjeblair: oh bother. thank you23:25

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!