openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul feature/zuulv3: Merge branch 'master' into feature/zuulv3 https://review.openstack.org/441731 | 02:31 |
---|---|---|
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul feature/zuulv3: Merge branch 'master' into feature/zuulv3 https://review.openstack.org/441731 | 02:38 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul feature/zuulv3: Merge branch 'master' into feature/zuulv3 https://review.openstack.org/441731 | 02:42 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: A couple small test improvements https://review.openstack.org/437592 | 02:47 |
*** abregman has joined #zuul | 06:15 | |
*** bhavik1 has joined #zuul | 06:50 | |
*** saneax-_-|AFK is now known as saneax | 06:55 | |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Correct the quota/availability algorithm https://review.openstack.org/440780 | 07:04 |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Only use ready nodes from the same provider. https://review.openstack.org/441270 | 07:06 |
*** Cibo has joined #zuul | 07:40 | |
*** Cibo has quit IRC | 07:44 | |
*** Cibo has joined #zuul | 07:52 | |
*** Cibo has quit IRC | 08:08 | |
*** isaacb has joined #zuul | 09:04 | |
*** abregman is now known as abregman|mtg | 09:42 | |
*** abregman|mtg has quit IRC | 09:42 | |
*** abregman has joined #zuul | 09:44 | |
*** Cibo has joined #zuul | 10:25 | |
*** abregman has quit IRC | 10:29 | |
*** bhavik1 has quit IRC | 10:29 | |
*** openstackgerrit has quit IRC | 10:33 | |
*** abregman has joined #zuul | 10:42 | |
*** Cibo has quit IRC | 11:07 | |
*** isaacb has quit IRC | 11:29 | |
*** Cibo has joined #zuul | 11:55 | |
*** isaacb has joined #zuul | 12:08 | |
*** Cibo has quit IRC | 12:11 | |
*** Cibo has joined #zuul | 12:13 | |
*** GK_1wm__SU has joined #zuul | 12:22 | |
*** GK_1wm__SU has quit IRC | 12:28 | |
Shrews | jhesketh: morning! saw your comment on 441470, but afraid I'm not following (probably due to lack of coffee and being Monday) | 12:43 |
Shrews | i want to tweak that algorithm a bit anyway, so expect another patchset | 12:44 |
Shrews | responded inline | 12:49 |
*** jamielennox is now known as jamielennox|away | 12:50 | |
*** abregman has quit IRC | 12:59 | |
*** abregman has joined #zuul | 13:00 | |
*** abregman is now known as abregman|mtg | 13:03 | |
*** Cibo has quit IRC | 13:06 | |
*** isaacb has quit IRC | 13:08 | |
*** openstackgerrit has joined #zuul | 13:17 | |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Group nodes by availability zone https://review.openstack.org/441470 | 13:17 |
Shrews | jhesketh: jeblair: ^^^ I tweaked the AZ grouping algorithm slightly to guarantee we use nodes from the READY node pool | 13:18 |
Shrews | described in the commit message | 13:19 |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Group nodes by availability zone https://review.openstack.org/441470 | 13:21 |
Shrews | ugh, that's wrong | 13:24 |
mordred | Shrews: your face is wrong | 13:26 |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Group nodes by availability zone https://review.openstack.org/441470 | 13:28 |
Shrews | mordred: i know, i know | 13:28 |
Shrews | but that patch set is right | 13:29 |
* Shrews now coffees | 13:29 | |
*** abregman|mtg has quit IRC | 13:31 | |
openstackgerrit | Alexander Evseev proposed openstack-infra/zuul master: Use ssh-agent instead of ugly ssh-wrapper scripts https://review.openstack.org/331148 | 13:33 |
*** hashar has joined #zuul | 13:39 | |
*** abregman|mtg has joined #zuul | 13:43 | |
*** Cibo has joined #zuul | 13:45 | |
*** abregman|mtg has quit IRC | 14:04 | |
*** isaacb has joined #zuul | 14:17 | |
*** abregman|mtg has joined #zuul | 14:19 | |
*** Cibo has quit IRC | 14:19 | |
*** Cibo has joined #zuul | 14:22 | |
*** saneax is now known as saneax-_-|AFK | 15:09 | |
*** Cibo has quit IRC | 15:16 | |
*** Cibo has joined #zuul | 15:18 | |
*** Cibo has quit IRC | 15:58 | |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Use devstack's zookeeper support https://review.openstack.org/441209 | 16:10 |
pabelanger | morning | 16:12 |
*** bhavik1 has joined #zuul | 16:16 | |
openstackgerrit | Cullen Taylor proposed openstack-infra/zuul feature/zuulv3: Re-enable test_tags https://review.openstack.org/439858 | 16:44 |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Fix comment about AZ selection https://review.openstack.org/442029 | 16:44 |
pabelanger | Shrews: woah, I think we are having a zk issue on zuulv3-dev.o.o. | 16:45 |
pabelanger | Shrews: http://paste.openstack.org/show/601610/ | 16:45 |
pabelanger | jeblair: ^^might be interested | 16:45 |
pabelanger | it is spamming the log now | 16:46 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Merge branch 'master' into feature/zuulv3 https://review.openstack.org/441731 | 16:46 |
jeblair | fascinating! | 16:46 |
Shrews | pabelanger: neat! | 16:46 |
jeblair | maybe this is an idle timeout, and nodepool is chatty enough with zk that this doesn't happen there, but when we leave zuul idle over the weekend, it does time out? | 16:47 |
Shrews | is the zk server available? | 16:47 |
Shrews | jeblair: ah, likely. but, you'd think it would reconnect | 16:48 |
jeblair | oh, nl01 is reporting the same error | 16:48 |
jeblair | nb01: http://paste.openstack.org/show/601615/ | 16:49 |
Shrews | wow | 16:50 |
pabelanger | was AFK, haven't looked at nl01 | 16:50 |
jeblair | same on nb02 | 16:50 |
jeblair | 2017-03-06 16:43:35,103 [myid:] - ERROR [main:ZooKeeperServer@272] - Severe unrecoverable error, exiting | 16:50 |
jeblair | java.io.IOException: No space left on device | 16:50 |
pabelanger | eep | 16:50 |
jeblair | that splains that. :) | 16:50 |
Shrews | i cannot connect from nodepool.o.o | 16:51 |
Shrews | oh, yeah | 16:51 |
Shrews | :) | 16:51 |
jeblair | let's take this over to #openstack-infra | 16:51 |
pabelanger | I just deleted some qcow2 images from my home folder | 16:51 |
pabelanger | ++ | 16:51 |
SpamapS | is anyone else a little bit terrified that this exists? https://github.com/coreos/zetcd#zetcd | 16:55 |
*** abregman|mtg has quit IRC | 16:55 | |
*** hashar is now known as hasharErrand | 16:58 | |
Shrews | SpamapS: yes | 16:59 |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool feature/zuulv3: Suspend NodeCleanupWorker on ZK suspension https://review.openstack.org/442042 | 17:03 |
*** mgagne_ has quit IRC | 17:05 | |
*** mgagne_ has joined #zuul | 17:05 | |
openstackgerrit | Merged openstack-infra/nodepool master: Clarification about the rate parameter https://review.openstack.org/436993 | 17:23 |
openstackgerrit | Merged openstack-infra/nodepool master: Fix potential race in image upload cleanup https://review.openstack.org/434934 | 17:30 |
Shrews | mordred: can i persuade you to take a gander at https://review.openstack.org/441470 today? i'll give you alcohols | 17:34 |
jeblair | Shrews: ethyl or methyl? | 17:34 |
Shrews | jeblair: isopropyl | 17:35 |
jeblair | oof | 17:35 |
Shrews | pabelanger could grab it, too. whomever. :) | 17:37 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Merge branch 'master' into feature/zuulv3 https://review.openstack.org/441731 | 17:40 |
*** isaacb has quit IRC | 17:52 | |
*** hasharErrand has quit IRC | 18:02 | |
dmsimard | -9k lines, wow :P | 18:05 |
jeblair | i don't know how to read those in merge commits; i don't know how well that maps to our ideas of what's going on. :/ | 18:08 |
*** bhavik1 has quit IRC | 18:17 | |
*** hashar has joined #zuul | 18:25 | |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Remove spurious with from comment https://review.openstack.org/442107 | 18:43 |
mordred | jeblair: started reviewing the 440760 stack - there was a comment thing on the first patchset - which I decided to just push a follow up patch for | 18:44 |
jeblair | mordred: thx +3 | 18:46 |
mordred | jeblair: also, jhesketh has comments on https://review.openstack.org/#/c/435948 | 18:49 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Report layout config errors for config repos https://review.openstack.org/440760 | 18:49 |
jeblair | mordred: good suggestion; i'll pull that one out and put it at the end when i redo it. :) | 18:54 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Catch gear.InterruptedError https://review.openstack.org/440789 | 18:55 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Switch to yaml.safe_load https://review.openstack.org/441285 | 18:55 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Report YAML parse errors https://review.openstack.org/441286 | 18:56 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Port SQLAlchemy reporter to v3 driver structure https://review.openstack.org/442114 | 18:57 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove spurious with from comment https://review.openstack.org/442107 | 19:03 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Port SQLAlchemy reporter to v3 driver structure https://review.openstack.org/442114 | 19:09 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Move alembic into sql driver https://review.openstack.org/442124 | 19:18 |
jeblair | it is not fun having to remember to run 'git review -R' on child changes underneath a merge commit | 19:18 |
mordred | jeblair: merge commits are weird | 19:34 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add missing pauses in reconfiguration tests https://review.openstack.org/442136 | 19:37 |
jeblair | that ^ fixes a spurious test failure | 19:37 |
jeblair | mordred: can you fast-approve so it doesn't block any merges? | 19:38 |
pabelanger | Shrews: +2 on 441470 | 19:40 |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Group nodes by availability zone https://review.openstack.org/441470 | 19:44 |
mordred | jeblair: yup | 19:45 |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Fix comment about AZ selection https://review.openstack.org/442029 | 19:45 |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Suspend NodeCleanupWorker on ZK suspension https://review.openstack.org/442042 | 19:45 |
mordred | jeblair: done | 19:45 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Add missing pauses in reconfiguration tests https://review.openstack.org/442136 | 20:01 |
*** Cibo has joined #zuul | 20:46 | |
*** jamielennox|away is now known as jamielennox | 21:00 | |
*** pabelanger has quit IRC | 21:14 | |
*** pabelanger has joined #zuul | 21:14 | |
*** Cibo has quit IRC | 21:18 | |
jeblair | pabelanger: fyi i replaced 'zuul ansible running' with 'zuul sample jobs' in the status updates portion of the zuul meeting. hope that's okay. :) | 21:23 |
pabelanger | jeblair: WFM | 21:25 |
jeblair | pabelanger: iirc, you were going to make two competing tox job definitions for us to discuss... can you point me at those? | 21:28 |
pabelanger | jeblair: right, I haven't created the 2nd one yet. I can quickly do that now and WIP the patch | 21:29 |
jeblair | pabelanger: was the other going to use zuul job 'vars' to set the role for tox? | 21:30 |
pabelanger | jeblair: right | 21:31 |
pabelanger | jeblair: 438281,11 was the example of using vars in .zuul.yaml. Single playbook, and latest 438281 is per job playbooks | 21:32 |
jeblair | pabelanger: right; i'd like both things to be a change so that we can refine both of them in parallel and then merge the best approach. | 21:32 |
jeblair | pabelanger: also, please see my comment in 438281,12 and ,23 on the word 'eventlist' | 21:33 |
pabelanger | jeblair: yes, a typo. I'll adjust in a moment. | 21:36 |
pabelanger | jeblair: as for both approaches, I can update 438281 to do that, if that is what you are suggesting | 21:36 |
jeblair | pabelanger: no, i'm suggesting *two* separate changes in gerrit. | 21:37 |
pabelanger | ack | 21:37 |
jeblair | we're only going to merge one of them. | 21:38 |
jeblair | but they should each get the opportunity to represent the best of both approaches. | 21:38 |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/442180 | 21:43 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Provide file locations of config syntax errors https://review.openstack.org/441606 | 21:46 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Remove unused mergeChangeQueue method https://review.openstack.org/435950 | 21:46 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Use hostname in Nodepool requests https://review.openstack.org/435949 | 21:46 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Clarify Job/Build/BuildSet docstrings https://review.openstack.org/435948 | 21:46 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Add a test for a broken config on startup https://review.openstack.org/441499 | 21:46 |
pabelanger | jeblair: I'll hold off on patching eventlist (spamming) on 438281 until we decide how to move forward | 21:47 |
pabelanger | 442180 is the alternate patch | 21:48 |
jeblair | pabelanger: well, what i'm trying to get going here is that we refine *both* things in parallel so they represent the best of both approaches. that doesn't work if we hold off on making one better. | 21:48 |
jeblair | pabelanger: so if you're worried about the spamming, maybe just don't update the child patches yet? | 21:48 |
pabelanger | jeblair: sure, I can do that too | 21:49 |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/438281 | 21:52 |
SpamapS | reminder, Zuul meeting in 5 | 21:55 |
jhesketh | Morning | 21:57 |
jeblair | jhesketh: morning! thanks for the merge commit! i pushed up a revision to 441731 and two more changes on top of it | 21:59 |
jhesketh | jeblair: no worries. I'm reworking the sql driver too. Should have that today | 22:00 |
jeblair | jhesketh: oh, er, that was one of the things i added :| | 22:00 |
jeblair | jhesketh: sorry... | 22:00 |
jhesketh | Oh that's cool | 22:01 |
jhesketh | I'll take a look after the meeting | 22:01 |
jeblair | cool, thanks. i hope i didn't step on your toes too hard | 22:01 |
jeblair | zuul meeting now in #openstack-meeting-alt | 22:01 |
jhesketh | jeblair: all good :-) | 22:02 |
Shrews | pabelanger: stopping nodepool-launcher on nl01... k? | 22:20 |
pabelanger | Shrews: ++ | 22:21 |
Shrews | pabelanger: does infracloud-chocolate have AZs? | 22:35 |
Shrews | if so, we need to add those to nodepool.yaml | 22:35 |
Shrews | for nl01 | 22:36 |
pabelanger | Shrews: no, we don't have them enabled | 22:36 |
Shrews | pabelanger: ok. was hoping to see the new AZ grouping in action. | 22:37 |
Shrews | but if there are no AZs... | 22:38 |
pabelanger | Shrews: I should say, we have the default settings. | 22:38 |
pabelanger | but, we could update them | 22:38 |
SpamapS | jeblair: yeah searching for openstack-infra/zuul + tag:low-hanging-fruit is effectively the same thing for now | 23:00 |
jeblair | SpamapS: yes. will also need to search for nodepool. right this moment though, the only lhf nodepool task is also on zuul, so we lucked out. :) | 23:01 |
SpamapS | jeblair: I think this is worth driving into storyboard | 23:03 |
SpamapS | should be relatively straight forward to achieve | 23:03 |
jeblair | SpamapS: agreed on the first part. on the second, i don't know if it's a client or server side limitation.... (that has very different implications on simplicity for me) | 23:04 |
SpamapS | true | 23:04 |
SpamapS | It's most likely both | 23:05 |
SpamapS | but if we can fix server side at least we can publish a list of links somewhere until the client side works | 23:05 |
jeblair | jhesketh: unless you object, i'm going to take your affirmative comment on 441731 (the merge commit) as permission to merge | 23:05 |
jhesketh | jeblair: yep, please do | 23:05 |
jhesketh | just looking at your subsequent changes | 23:06 |
jeblair | jhesketh: cool, thx | 23:06 |
Shrews | jhesketh: thx for the nodepool reviews | 23:08 |
jhesketh | no worries :-) | 23:09 |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul feature/zuulv3: Add generic tox job https://review.openstack.org/442180 | 23:11 |
Shrews | jeblair: https://review.openstack.org/435949 makes me sad we have divergent model classes. That new field could be useful in nodepool logs, too | 23:12 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Merge branch 'master' into feature/zuulv3 https://review.openstack.org/441731 | 23:13 |
* Shrews hears the dinner bell | 23:14 | |
*** hashar has quit IRC | 23:15 | |
pabelanger | jeblair: Shrews: at this point, I think I'm ready to be pointed into the next direction, at least until we decided on the zuulv3-ansible topic. | 23:16 |
pabelanger | going to checkout storyboard for items still assigned to me, but willing to take direction too | 23:17 |
jeblair | pabelanger: what do you think about mentioning the tox jobs at the infra meeting and get some more folks to weigh in on it? | 23:18 |
pabelanger | jeblair: great idea | 23:19 |
*** saneax-_-|AFK is now known as saneax | 23:21 | |
jeblair | jhesketh: if you have some more time, there are changes at 435944 that could use some review | 23:45 |
jhesketh | sure | 23:46 |
jhesketh | jeblair: I've got a comment on the first two | 23:50 |
SpamapS | oh wow | 23:53 |
SpamapS | storyboard uses FULLTEXT | 23:54 |
SpamapS | weird | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!