| openstackgerrit | Merged openstack-infra/nodepool master: Add support for specifying key-name per label https://review.openstack.org/455466 | 00:14 |
|---|---|---|
| pabelanger | clarkb: mordred: ^ I'll update dsvm-nodepool tomorrow to use that, so we can test in the gate | 00:16 |
| mordred | pabelanger: woot | 00:16 |
| clarkb | awesome | 00:18 |
| pabelanger | https://review.openstack.org/#/c/455388/ is our cloud-launcher change | 00:18 |
| pabelanger | but we need to automate that still too | 00:19 |
| clarkb | the suns out and its beer thirty. I think I may have to do some yard work | 00:19 |
| mordred | pabelanger: oh - have you tested adding an ssh-keypair that has more than one key? | 00:23 |
| pabelanger | mordred: I have not, clarkb suggest we'd stack them all in a single key | 00:25 |
| pabelanger | I should be able to do that tomorrow | 00:25 |
| mordred | yah - I think single key sounds right | 00:25 |
| mordred | which should be fine as long as nova doens't, you know, try to process them in some sort of weird way | 00:26 |
| pabelanger | ya | 00:26 |
| jamielennox | is there a recent change that would mean i would not be getting ips in the ansible inventories? | 03:28 |
| jamielennox | eg: bonnyci nodepool_region=None nodepool_provider=cicloud-v3 ansible_host=None nodepool_az=compute_standard | 03:29 |
| jamielennox | so ansible_host=None and the ip is missing in known hosts | 03:29 |
| clarkb | the IP comes from nodepool, check if nodepool knows what the IP is? | 04:14 |
| openstackgerrit | Jamie Lennox proposed openstack-infra/zuul feature/zuulv3: Use public_ipv4 variable when passing to executor https://review.openstack.org/455508 | 04:28 |
| jamielennox | clarkb: i'm not sure how this happened exactly, but what executor/client sends: http://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/executor/client.py?h=feature/zuulv3#n305 | 04:30 |
| jamielennox | is not what executor/server reads http://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/executor/server.py?h=feature/zuulv3#n672 | 04:30 |
| *** bhavik1 has joined #zuul | 06:04 | |
| *** bhavik1 has quit IRC | 06:28 | |
| *** bstinson has quit IRC | 06:29 | |
| *** bstinson has joined #zuul | 06:31 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Use PBR's setup.py test command https://review.openstack.org/454923 | 06:42 |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Configure zk fixture cleanup early https://review.openstack.org/454924 | 06:43 |
| *** mgagne has quit IRC | 06:52 | |
| *** bhavik1 has joined #zuul | 08:29 | |
| *** hashar has joined #zuul | 08:30 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Use ssh for git-upload-pack https://review.openstack.org/436802 | 08:55 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Resolve project_name/project confusion for gerrit https://review.openstack.org/455604 | 08:55 |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** openstackgerrit has joined #zuul | 09:18 | |
| openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Put test id in zk chroot path https://review.openstack.org/454925 | 09:18 |
| *** bhavik1 has quit IRC | 09:50 | |
| *** bhavik1 has joined #zuul | 09:50 | |
| *** bhavik1 has quit IRC | 10:03 | |
| mordred | jamielennox: oh glory | 10:29 |
| jamielennox | mordred: heh, yea, that one seems glaring and i don't know what's running it at the moment | 10:30 |
| mordred | jamielennox: sounds like the interface_ip change didn't get plumbed through everywhere somehow | 10:30 |
| jamielennox | mordred: the change that did it was against the launcher/ but it looks like it was matched against executor/client but not against executor/server | 10:31 |
| mordred | jamielennox: the _goal_ with that change is to make sure that interface_ip (which is a shade-added thing) just gets used - but clearly that's not going to work if we're not doing it in all the places | 10:31 |
| jamielennox | mordred: yep, don't mind the change at all - though i'm not sure if public_ makes sense because it's probably a private ip | 10:33 |
| mordred | oh - no, I mean, that's why it should be interface_ip instead of public_v4/private_v4 - turns out "what interface do I use to talk to this" is the question you really care about | 10:36 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Send interface_ip in the node description https://review.openstack.org/455639 | 10:39 |
| mordred | jamielennox: ^^ I think that should finish plumbing it through, yeah? | 10:39 |
| jamielennox | mordred: oh, ok, i don't have a preference on interface vs public/private | 10:40 |
| jamielennox | https://review.openstack.org/455508 solved the problem but i don't care which way we go | 10:40 |
| mordred | yah - it's been a path away from public_ and to interface_ (there's a ton of logic in shade about how to find the ip you actually want and the results of that go into interface_ip - so it migh be public/private - and it might be v6 instead of v4) | 10:44 |
| mordred | I'm a little tempted to remove public_v4/public_v6/private_v4 from those zuul vars as they don't make a ton of sense in a zuul context - but I think I'd like jeblair's take on that | 10:45 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Remove public_ipv[46] and private_ipv4 https://review.openstack.org/455642 | 10:48 |
| *** hashar is now known as hasharLunch | 11:23 | |
| *** hasharLunch is now known as hashar | 12:20 | |
| Shrews | mordred: wonder if it would make sense to remove them from the nodepool model, too (assuming we go this route) | 12:55 |
| mordred | Shrews: yah | 13:05 |
| mordred | Shrews: oh- I guess there's a question though - nodepool currently writes out those nodepool variables files | 13:08 |
| mordred | Shrews: and public/private addresses are important to write out in those | 13:08 |
| mordred | where did we went up with in terms of ownership of writing that info out - it's just the stuff in zuul vars right? | 13:08 |
| mordred | so I think _removing_ public|private/v4|v6 is wrong - we need those variables for things like devstack-gate | 13:09 |
| mordred | but adding interface_ip and making sure that's what zuul uses for inventory is important | 13:09 |
| Shrews | mordred: nodepool variables files? | 13:11 |
| Shrews | mordred: oh, the /etc/nodepool/* files? that's gone in v3 | 13:12 |
| mordred | nod. those are just from the inventory varialbes now | 13:28 |
| mordred | so yah- we should not remove the public/private things | 13:28 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Don't report start on unmanaged projects https://review.openstack.org/455711 | 13:33 |
| tobiash | ^^ this inhibits zuul start reporting for unmanaged projects | 13:34 |
| tobiash | my local zuulv3 test instance reported with "Starting check jobs" for every change in our gerrit | 13:35 |
| Shrews | mordred: i'm not 100% convinced that https://review.openstack.org/455639 solves something | 13:45 |
| mordred | Shrews: it uses interface_ip instead of public_v4 for the ansible inventory | 13:46 |
| mordred | Shrews: that means that for v6 enabled things, ansible will connect to the node wiht v6 instead of v4 | 13:47 |
| mordred | Shrews: and if someone has put "private: True" in their clouds.yaml for that cloud, ansible will use the private_v4 address to connect to the node | 13:47 |
| Shrews | mordred: updateFromDict() will already set the interface_ip attribute (http://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/model.py?h=feature/zuulv3#n426). so is the real fix in client.py? | 13:47 |
| Shrews | (any attrs not found in the class in model.py will automatically be created) | 13:48 |
| mordred | Shrews: yes- client.py is the important bit I believe | 13:49 |
| tobiash | I'm a bit confused why the docs build fails for my patch (http://logs.openstack.org/11/455711/1/check/gate-zuul-docs-ubuntu-xenial/5938265/console.html) | 13:57 |
| tobiash | I'm not aware of changing anything related to this in https://review.openstack.org/455711 | 13:58 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul feature/zuulv3: Turn off sphinx warnings-is-error for now https://review.openstack.org/455720 | 14:03 |
| mordred | tobiash: might be in the air ^^ we had some issues with sphinx this morning in other projects too | 14:04 |
| mordred | tobiash: ah - it's apparently more systemic | 14:23 |
| pabelanger | tobiash: will be fixed shortly, sorry for the noise | 14:36 |
| pabelanger | Shrews: it is possible to delete an image that is currently getting uploaded in nodepool? | 15:38 |
| pabelanger | I don't believe so | 15:38 |
| pabelanger | ya, looks like they flag ready for a minute, then delete right away. | 15:50 |
| pabelanger | wonder if we could clean that up a bit | 15:50 |
| pabelanger | either way, things deleting as expected | 15:51 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool master: [WIP] Add functional test for key-name and glean https://review.openstack.org/455770 | 16:14 |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool master: [WIP] Add functional test for key-name and glean https://review.openstack.org/455770 | 16:47 |
| *** mgagne has joined #zuul | 17:00 | |
| *** hashar has quit IRC | 17:06 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool master: [WIP] Add functional test for key-name and glean https://review.openstack.org/455770 | 17:29 |
| pabelanger | heh, nodepool is deleting our keypair on master | 18:09 |
| clarkb | really? | 18:10 |
| pabelanger | nodepool think it is leaked? | 18:10 |
| clarkb | fun | 18:10 |
| pabelanger | 2017-04-11 18:07:00,821 DEBUG novaclient.v2.client: REQ: curl -g -i -X DELETE http://198.72.124.14:8774/v2.1/os-keypairs/root -H "User-Agent: python-novaclient" -H "Accept: application/json" -H "X-Auth-Token: {SHA1}d4a6525e70ed917d6a6019ba7b77d489be3ee275" | 18:10 |
| clarkb | so we need to also patch in don't delete any keys specified | 18:10 |
| pabelanger | 2017-04-11 18:07:00,820 DEBUG nodepool.TaskManager: Manager devstack running task KeypairDelete (queue: 1) | 18:10 |
| pabelanger | ya | 18:10 |
| pabelanger | think so | 18:10 |
| pabelanger | I don't think this is an issue in feature/zuulv3 | 18:10 |
| clarkb | ya zuulv3 doesn't ssh so doesn't make keys it needs to clean up | 18:11 |
| pabelanger | oh | 18:13 |
| pabelanger | hmm | 18:13 |
| pabelanger | okay | 18:15 |
| pabelanger | see the issue | 18:15 |
| pabelanger | cleanupServer() is doing it | 18:15 |
| pabelanger | we only keep the keypair we generate today | 18:16 |
| clarkb | actually it looks like its a provider keypair? | 18:18 |
| clarkb | so did we already have this feature just applied to provider not image label? | 18:18 |
| clarkb | it looks unplumbed | 18:19 |
| pabelanger | provider keypair was something we generated for snapshot images | 18:20 |
| pabelanger | but since removed | 18:20 |
| clarkb | ya and addkeypair is no longer called | 18:20 |
| pabelanger | yup | 18:20 |
| pabelanger | I mean, we could re used it | 18:20 |
| clarkb | so I think what we can do is just clean out the keypair management code that is now dead, and stop deleting the key that is on the instance | 18:20 |
| pabelanger | ya | 18:20 |
| pabelanger | that works too | 18:20 |
| clarkb | its simpler and I don't think we really want to maange a one shot thing in nodepool | 18:20 |
| pabelanger | k | 18:20 |
| clarkb | pabelanger: you going to work on that? | 18:21 |
| pabelanger | clarkb: you can, if you'd like | 18:21 |
| pabelanger | I need to break before meeting | 18:21 |
| clarkb | ok | 18:21 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool master: Cleanup old keypair config option https://review.openstack.org/455802 | 18:29 |
| clarkb | something like that I think | 18:29 |
| pabelanger | think so | 18:34 |
| *** mgagne_ has joined #zuul | 18:35 | |
| *** mgagne_ is now known as Guest89317 | 18:35 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool master: [WIP] Add functional test for key-name and glean https://review.openstack.org/455770 | 18:37 |
| pabelanger | rebased atop if it for testing | 18:38 |
| pabelanger | clarkb: mordred: and it worked. Once I stopped nodepool from deleting my keypair :) | 18:44 |
| clarkb | yay | 18:45 |
| *** Guest89317 has quit IRC | 18:46 | |
| pabelanger | clarkb: the pep8 gods are unhappy | 18:50 |
| clarkb | gah | 18:50 |
| clarkb | I probably deleted a blank line I shouldnt have | 18:50 |
| clarkb | will have fix up as soon as local pep8 finishes cleanly | 18:53 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool master: Cleanup old keypair config option https://review.openstack.org/455802 | 19:01 |
| clarkb | pabelanger: ^ there and now going bcak to meeting | 19:01 |
| *** mgagne_ has joined #zuul | 19:18 | |
| *** mgagne_ is now known as Guest4366 | 19:19 | |
| *** mgagne has quit IRC | 19:24 | |
| *** Guest4366 is now known as mgagne | 19:25 | |
| *** mgagne has quit IRC | 19:25 | |
| *** mgagne has joined #zuul | 19:25 | |
| *** hashar has joined #zuul | 19:38 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/nodepool master: [WIP] Add functional test for key-name and glean https://review.openstack.org/455770 | 20:15 |
| *** dmellado has quit IRC | 20:48 | |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: support github pull reqeust labels https://review.openstack.org/444511 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow github trigger to match on branches/refs https://review.openstack.org/445625 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL https://review.openstack.org/446782 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status https://review.openstack.org/449390 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for dependent pipelines with github https://review.openstack.org/445292 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates https://review.openstack.org/453844 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews https://review.openstack.org/453845 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add basic Github Zuul Reporter. https://review.openstack.org/443323 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Configurable SSH access to GitHub https://review.openstack.org/444034 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add 'push' and 'tag' github webhook events. https://review.openstack.org/443947 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add 'pr-comment' github webhook event https://review.openstack.org/443959 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for github commit status https://review.openstack.org/444060 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Better merge message for GitHub pull reqeusts https://review.openstack.org/445644 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Query changes only via relevant sources https://review.openstack.org/448257 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Encapsulate determining the event purpose https://review.openstack.org/445242 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow using webapp from connections https://review.openstack.org/439831 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Merge pull requests from github reporter https://review.openstack.org/444463 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise https://review.openstack.org/449258 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support GitHub PR webhooks https://review.openstack.org/439834 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: GitHub file matching support https://review.openstack.org/446113 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review https://review.openstack.org/449365 | 22:14 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Log GitHub API rate limit https://review.openstack.org/446150 | 22:14 |
| *** hashar has quit IRC | 22:17 | |
| jlk | That face when you forget to pep8 your stack, and you made an error in patch 2 of 22..... | 22:43 |
| clarkb | jlk: the way I like to handle that is make new commit then rebase -i HEAD~23 and squash new commit into commit that introduced error | 22:46 |
| clarkb | the edit future then squash history workflow has made my life much easier when dealing with large stacks | 22:46 |
| jlk | oh it's easy to fix, i tjust means re-sending 20 patches back up to gerrit | 22:46 |
| jhesketh | Morning | 22:51 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: support github pull reqeust labels https://review.openstack.org/444511 | 22:52 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow github trigger to match on branches/refs https://review.openstack.org/445625 | 22:52 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Set filter according to PR/Change in URL https://review.openstack.org/446782 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for requiring github pr head status https://review.openstack.org/449390 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for dependent pipelines with github https://review.openstack.org/445292 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Adds github triggering from status updates https://review.openstack.org/453844 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Implement pipeline requirement on github reviews https://review.openstack.org/453845 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add basic Github Zuul Reporter. https://review.openstack.org/443323 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Configurable SSH access to GitHub https://review.openstack.org/444034 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add 'push' and 'tag' github webhook events. https://review.openstack.org/443947 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add 'pr-comment' github webhook event https://review.openstack.org/443959 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support for github commit status https://review.openstack.org/444060 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Better merge message for GitHub pull reqeusts https://review.openstack.org/445644 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Query changes only via relevant sources https://review.openstack.org/448257 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Encapsulate determining the event purpose https://review.openstack.org/445242 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Allow using webapp from connections https://review.openstack.org/439831 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Merge pull requests from github reporter https://review.openstack.org/444463 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add support for github enterprise https://review.openstack.org/449258 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Support GitHub PR webhooks https://review.openstack.org/439834 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: GitHub file matching support https://review.openstack.org/446113 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Add trigger capability on github pr review https://review.openstack.org/449365 | 22:53 |
| openstackgerrit | Jesse Keating proposed openstack-infra/zuul feature/zuulv3: Log GitHub API rate limit https://review.openstack.org/446150 | 22:53 |
| pabelanger | stackalytics, here we come! | 22:57 |
| jlk | sorry about that..... :( | 23:03 |
| pabelanger | jlk: all good :) | 23:03 |
| jlk | Oooh we're up to 90~ megs of console.html now | 23:29 |
| *** jamielennox is now known as jamielennox|away | 23:48 | |
| *** jamielennox|away is now known as jamielennox | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!