*** threestrands has joined #zuul | 00:01 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Add sphinx_python variable to sphinx role and job https://review.openstack.org/525688 | 00:11 |
---|---|---|
*** ricky_vaca has quit IRC | 00:15 | |
*** harlowja has quit IRC | 02:03 | |
*** Wei_Liu has quit IRC | 03:14 | |
*** Wei_Liu has joined #zuul | 03:27 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: handler: fix support for handler without launch_manager https://review.openstack.org/524773 | 04:24 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add a plugin interface for drivers https://review.openstack.org/524620 | 04:24 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: builder: do not cleanup image for driver not managing image https://review.openstack.org/516920 | 04:24 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a static driver for Nodepool https://review.openstack.org/468624 | 04:24 |
*** bhavik1 has joined #zuul | 04:48 | |
*** bhavik1 has quit IRC | 04:56 | |
*** tflink has quit IRC | 05:13 | |
*** tflink has joined #zuul | 05:14 | |
*** threestrands has quit IRC | 05:24 | |
*** harlowja has joined #zuul | 05:37 | |
*** threestrands has joined #zuul | 05:39 | |
*** threestrands has quit IRC | 05:39 | |
*** threestrands has joined #zuul | 05:39 | |
*** harlowja has quit IRC | 06:14 | |
*** xinliang has quit IRC | 06:22 | |
*** threestrands has quit IRC | 06:28 | |
*** Wei_Liu has quit IRC | 06:31 | |
*** Wei_Liu has joined #zuul | 06:31 | |
*** xinliang has joined #zuul | 06:35 | |
*** xinliang has quit IRC | 06:35 | |
*** xinliang has joined #zuul | 06:35 | |
*** vivsoni__ has quit IRC | 06:51 | |
*** persia has quit IRC | 07:07 | |
*** odyssey4me has quit IRC | 07:08 | |
*** persia has joined #zuul | 07:08 | |
*** nguyentrihai has joined #zuul | 07:09 | |
*** nguyentrihai has quit IRC | 07:11 | |
*** odyssey4me has joined #zuul | 07:12 | |
*** patriciadomin has quit IRC | 07:17 | |
*** patriciadomin has joined #zuul | 07:17 | |
tristanC | Shrews: i went a step further and merged the NodeLaunchManager into the RequestHandler, about to submit a new PS... | 07:34 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a generic run_handler https://review.openstack.org/526325 | 07:36 |
tristanC | there, i think the openstack and static handler looks much better in 526325 | 07:37 |
*** hashar has joined #zuul | 07:58 | |
*** baiyi has joined #zuul | 08:32 | |
baiyi | When I run zuul, job will stop for a few minutes | 08:37 |
baiyi | 2017-12-08 08:30:24.852581 | TASK [bindep : create temp dir for bindep] | 08:38 |
baiyi | 2017-12-08 08:32:25.371500 | ubuntu-xenial | changed | 08:38 |
baiyi | Does anyone have the same problem? | 09:06 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a generic run_handler https://review.openstack.org/526325 | 09:11 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an OpenContainer driver https://review.openstack.org/468753 | 09:11 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a Kubernetes driver https://review.openstack.org/521356 | 09:11 |
*** bbc1__ has joined #zuul | 09:11 | |
tobiash | baiyi: the executor logs would be helpful | 09:20 |
*** flepied has joined #zuul | 09:51 | |
*** baiyi1 has joined #zuul | 10:19 | |
*** baiyi has quit IRC | 10:19 | |
*** baiyi has joined #zuul | 10:22 | |
*** baiyi has left #zuul | 10:22 | |
*** baiyi has joined #zuul | 10:22 | |
*** baiyi1 has quit IRC | 10:24 | |
baiyi | Between 10:11 and 10:13 pause for two minutes, I don't know why, not every time http://paste.openstack.org/show/628439/ http://paste.openstack.org/show/628441/ | 10:24 |
baiyi | The pause task is different every time | 10:25 |
*** baiyi has quit IRC | 10:30 | |
*** electrofelix has joined #zuul | 10:30 | |
*** JasonCL has quit IRC | 11:07 | |
openstackgerrit | Jens Harbott (frickler) proposed openstack-infra/zuul-jobs master: Revert "Add sphinx_python variable to sphinx role and job" https://review.openstack.org/526657 | 11:10 |
*** openstackgerrit has quit IRC | 11:17 | |
*** jkilpatr has quit IRC | 11:28 | |
*** JasonCL has joined #zuul | 11:30 | |
*** jkilpatr has joined #zuul | 12:23 | |
*** openstackgerrit has joined #zuul | 12:31 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Revert "Add sphinx_python variable to sphinx role and job" https://review.openstack.org/526657 | 12:31 |
openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job"" https://review.openstack.org/526666 | 12:33 |
openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul feature/zuulv3: Update sphinx jobs to use python3 https://review.openstack.org/525690 | 12:34 |
*** flepied_ has joined #zuul | 12:41 | |
*** flepied has quit IRC | 12:44 | |
*** dkranz has joined #zuul | 12:47 | |
*** bbc1__ has quit IRC | 13:02 | |
*** nguyentrihai has joined #zuul | 13:26 | |
*** Wei_Liu has quit IRC | 13:37 | |
*** jkilpatr has quit IRC | 13:53 | |
*** JasonCL has quit IRC | 15:06 | |
*** JasonCL has joined #zuul | 15:19 | |
*** Wei_Liu has joined #zuul | 15:23 | |
*** JasonCL has quit IRC | 15:24 | |
*** JasonCL has joined #zuul | 15:25 | |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul feature/zuulv3: WIP: Git driver https://review.openstack.org/525614 | 15:47 |
*** JasonCL has quit IRC | 16:05 | |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks https://review.openstack.org/526233 | 16:12 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup https://review.openstack.org/526234 | 16:12 |
clarkb | tobiash: ^ lets see if that helps, also thanks for the reviews. As for testing that I'm not really sure. Maybe we construct something that manually executes the cleanup worker then manually execute the request handler polling? | 16:14 |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver https://review.openstack.org/525614 | 16:14 |
*** weshay|ruck is now known as weshay|ruck|MOD | 16:15 | |
*** flepied__ has joined #zuul | 16:24 | |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks https://review.openstack.org/526233 | 16:25 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup https://review.openstack.org/526234 | 16:25 |
*** flepied_ has quit IRC | 16:27 | |
*** hashar has quit IRC | 16:29 | |
Shrews | clarkb: just added another comment on https://review.openstack.org/526234 (in case you missed it) | 16:32 |
clarkb | Shrews: thanks will work on a new patch | 16:35 |
*** JasonCL has joined #zuul | 16:40 | |
clarkb | Shrews: you are saying treat the missing lock exception in poll() as not an error? | 16:43 |
Shrews | clarkb: as for testing that race, it's difficult, but I think it could be done. take a look at test_node_assignment_at_quota and how it uses client.pause_creates. before you unpause that, you could remove the request and the lock (may need to manually do that), then unpause | 16:43 |
Shrews | clarkb: treating your new exception as not an error, yes | 16:44 |
*** d0ugal has joined #zuul | 16:44 | |
*** JasonCL has quit IRC | 16:48 | |
*** d0ugal has quit IRC | 16:52 | |
*** JasonCL has joined #zuul | 16:58 | |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup https://review.openstack.org/526234 | 17:03 |
clarkb | Shrews: something like ^ ? | 17:03 |
clarkb | I'll work on that test after tea | 17:03 |
Shrews | clarkb: perfect, yes | 17:05 |
clarkb | Shrews: node requests are fulfilled when zuul is given the nodes right? not when zuul hands the nodes back? | 17:28 |
clarkb | (sorting out how this test will look) | 17:28 |
*** JasonCL has quit IRC | 17:29 | |
SpamapS | hrm.. confusing syntax error | 17:31 |
SpamapS | http://paste.openstack.org/show/628472/ | 17:31 |
SpamapS | required-projects can be a list of dicts according to https://docs.openstack.org/infra/zuul/user/config.html | 17:32 |
Shrews | clarkb: correct. the NodeRequest.nodes[] element is filled with node IDs, then the status is set to FULFILLED and the request is unlocked. | 17:32 |
Shrews | clarkb: then zuul handles it from there | 17:32 |
clarkb | SpamapS: override branch looks funny to me too | 17:33 |
clarkb | SpamapS: needs more indentation and possibly more :'s | 17:33 |
clarkb | Shrews: perfect, thanks | 17:33 |
*** jkilpatr has joined #zuul | 17:34 | |
pabelanger | yah, needs to lined with name above? | 17:34 |
clarkb | SpamapS: re required projects I'm guessing the docs are just wrong? | 17:34 |
clarkb | but coulkd be a schema bug | 17:34 |
pabelanger | but maybe just formatting issue in debug log | 17:34 |
*** JasonCL has joined #zuul | 17:35 | |
Shrews | clarkb: you know what... i think you've inadvertantly found another bug | 17:36 |
pabelanger | override-branch: "1.3" ? | 17:36 |
pabelanger | maybe it thinks 1.3 is float? | 17:36 |
Shrews | clarkb: oh, no you didn't. nothing to see here :) | 17:37 |
* Shrews returns to his own test writing | 17:37 | |
SpamapS | clarkb: that format is just how the errors come out. In the source, override-branch is in the dict with name. | 17:39 |
SpamapS | I'll look and see if the feature is tested. | 17:39 |
*** jkilpatr has quit IRC | 17:39 | |
SpamapS | Oh that's true | 17:40 |
SpamapS | yep, float | 17:40 |
SpamapS | doh | 17:40 |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul feature/zuulv3: Git driver https://review.openstack.org/525614 | 17:41 |
SpamapS | pabelanger: well spotted. | 17:41 |
SpamapS | I'd test it but my VPN just went down doh | 17:42 |
*** JasonCL has quit IRC | 17:43 | |
pabelanger | yay | 17:44 |
clarkb | Shrews: figuring out a test for this is slightly mind bending particularly with a cold | 17:50 |
clarkb | Shrews: I think how this happens now is the request basically went stale for 8 hours or more and eventually was fullfilled | 17:51 |
clarkb | because cloud madness or something? | 17:51 |
*** jkilpatr has joined #zuul | 17:53 | |
Shrews | clarkb: i'm unsure what conditions led up to the problem | 17:58 |
*** openstackgerrit has quit IRC | 18:03 | |
*** JasonCL has joined #zuul | 18:03 | |
*** jkilpatr has quit IRC | 18:06 | |
*** JasonCL has quit IRC | 18:07 | |
*** jkilpatr has joined #zuul | 18:22 | |
*** electrofelix has quit IRC | 18:28 | |
*** openstackgerrit has joined #zuul | 18:42 | |
openstackgerrit | David Moreau Simard proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job"" https://review.openstack.org/526666 | 18:42 |
*** JasonCL has joined #zuul | 18:45 | |
*** JasonCL has quit IRC | 18:53 | |
*** JasonCL has joined #zuul | 18:55 | |
clarkb | soI think I have a test that mostly works except it completely breaks the main run loop which breaks shutdown of threds check in the tests :P | 19:10 |
openstackgerrit | David Moreau Simard proposed openstack-infra/zuul-jobs master: WIP: Revert "Revert "Add sphinx_python variable to sphinx role and job"" https://review.openstack.org/526666 | 19:19 |
*** harlowja has joined #zuul | 19:21 | |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks https://review.openstack.org/526233 | 19:38 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup https://review.openstack.org/526234 | 19:38 |
clarkb | Shrews: ^ ok I think I finally got it | 19:38 |
clarkb | turns out the trick is to set min ready to 0 if you don't want to fight the normal scheduler | 19:39 |
openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: Add finger gateway https://review.openstack.org/525276 | 20:05 |
Shrews | omg omg omg... un-WIP'd ^^^ | 20:05 |
* Shrews celebrates with the drinking of scotch | 20:05 | |
Shrews | because it's Friday and why not and stuff | 20:05 |
Shrews | clarkb: awesome. we should try to get those changes in ASAP | 20:08 |
Shrews | and restart launchers with them | 20:08 |
*** ChanServ has quit IRC | 20:17 | |
*** ChanServ has joined #zuul | 20:24 | |
*** barjavel.freenode.net sets mode: +o ChanServ | 20:24 | |
*** JasonCL has quit IRC | 20:39 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Make all zuul-web urls relative https://review.openstack.org/526770 | 20:42 |
*** JasonCL has joined #zuul | 20:43 | |
*** jkilpatr has quit IRC | 20:47 | |
*** JasonCL has quit IRC | 20:48 | |
pabelanger | Shrews: looking at finger gateway, does that mean the finger_port setting in zuul.conf [executor] could be updated to a different port now? maybe something like tcp 2003 (gnu finger) or 107979? | 20:51 |
pabelanger | Shrews: also left a comment about CommandSocket support | 20:52 |
Shrews | pabelanger: it could be, yes. it's a separate change to remove the need to start executor as root | 20:52 |
pabelanger | okay cool, thats what I figured | 20:53 |
Shrews | pabelanger: could you point me to that commandsocket change? | 20:53 |
Shrews | pabelanger: nm, found one | 20:55 |
*** JasonCL has joined #zuul | 20:57 | |
pabelanger | k | 20:58 |
Shrews | pabelanger: oh, i see what that is now. is that something needed for the gateway? | 20:59 |
Shrews | not sure what commands we'd send it | 20:59 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Clarify terminology around node request locks https://review.openstack.org/526233 | 21:00 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup https://review.openstack.org/526234 | 21:00 |
Shrews | pabelanger: oh, i guess 'stop' would be valid. not sure i understand the reasoning behind that, but yeah, I can add it. | 21:05 |
Shrews | pabelanger: how is that used? | 21:05 |
pabelanger | Shrews: for example, zuul-executor stop | 21:06 |
pabelanger | would stop the process | 21:07 |
Shrews | ah | 21:07 |
pabelanger | jeblair added that a while back, I guess it is better? | 21:07 |
pabelanger | I admit, I'm not really sure why that would be | 21:07 |
Shrews | oh, those just landed yesterday. no wonder i didn't see that change | 21:08 |
Shrews | bad timing | 21:08 |
tobiash | reload config via command socket on the scheduler could also be useful in a containerized context (k8s) where it can be hard to get directly into the container to issue sighup | 21:09 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Serve keys from canonical project name https://review.openstack.org/504807 | 21:18 |
*** sc68cal has joined #zuul | 21:22 | |
pabelanger | tobiash: ah, good point | 21:23 |
tobiash | pabelanger: the port thingy? | 21:24 |
tobiash | pabelanger: misunderstanding, had some other thing in my mind ;) | 21:25 |
pabelanger | tobiash: reload config | 21:31 |
openstackgerrit | David Shrewsbury proposed openstack-infra/zuul feature/zuulv3: Add finger gateway https://review.openstack.org/525276 | 21:31 |
Shrews | pabelanger: ^^^ does not yet address your commandsocket thing. only tobiash's random port comment. will get to the commandsocket probably monday based on current time | 21:44 |
tobiash | Shrews: :) | 21:48 |
Shrews | pabelanger: shouldn't send_command() close the socket? | 21:54 |
*** JasonCL_ has joined #zuul | 21:57 | |
*** JasonCL has quit IRC | 22:00 | |
clarkb | Shrews: I'll have new patchset up momentarily addressing your review. Just rerunning tests locally | 22:03 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Handle race between handler and request cleanup https://review.openstack.org/526234 | 22:04 |
clarkb | there we go | 22:04 |
Shrews | clarkb: lgtm | 22:08 |
Shrews | ok, i'm going to have to wait until Monday to look at this new CommandSocket stuff. something isn't computing for me. going to blame it on being late on a Friday. | 22:09 |
Shrews | like, i'm not sure why we can't just catch the commands in cmd/whatever.py and call the appropriate object method there, rather than having a thread in the object receive the command via a file socket. | 22:14 |
Shrews | anyway... maybe monday. night all | 22:14 |
Shrews | Oh, duh. Not the same as the running object. *sigh* | 22:17 |
clarkb | probably the scotch | 22:24 |
clarkb | :) | 22:24 |
*** hashar has joined #zuul | 22:49 | |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Pin to npm4 until npm 5.6.0 comes out https://review.openstack.org/526799 | 23:22 |
*** Wei_Liu has quit IRC | 23:27 | |
*** hashar has quit IRC | 23:47 | |
*** flepied__ has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!