| tristanC | SpamapS: fwiw, the waitForNodeSet logic is moved to the base class in https://review.openstack.org/526325 | 01:25 |
|---|---|---|
| tristanC | SpamapS: what else would you like to see in the base classes? | 01:33 |
| *** Wei_Liu has quit IRC | 01:47 | |
| *** persia has quit IRC | 02:22 | |
| *** persia has joined #zuul | 02:23 | |
| SpamapS | tristanC: that's a lot of it. | 03:07 |
| SpamapS | tristanC: there's some stuff in run_handler too, like declining min ready reqs. Maybe that's there too, I should probably just stack on top of yours. | 03:09 |
| *** xinliang has quit IRC | 03:12 | |
| tristanC | SpamapS: i'd also like to propose a generic nodelauncher class to manage thread creation and the statsd logic | 03:22 |
| tristanC | SpamapS: and not sure if you saw it, but there is wip aws driver here: https://review.openstack.org/528982 | 03:23 |
| *** xinliang has joined #zuul | 03:24 | |
| *** xinliang has quit IRC | 03:24 | |
| *** xinliang has joined #zuul | 03:24 | |
| SpamapS | tristanC: I did, which is why I chose gce. ;) | 03:28 |
| SpamapS | It feels pretty daunting. | 03:29 |
| SpamapS | IIRC somebody had proposed an exec driver or something that would let us use ansible or maybe other tools to do the heavy lifting instead of python libs. Though I don't really love that. | 03:30 |
| tristanC | the tricky part is to keep track of instance in the provider, e.g. openstack is using nova metadata to store nodepool_node_id | 03:31 |
| SpamapS | well technically it uses instance name too | 03:32 |
| SpamapS | They all give you something you can get back from a list for this purpose. | 03:33 |
| SpamapS | anyway I got a little lost in the gce thing but maybe I can stack on your refactoring | 03:37 |
| tristanC | beware the aws driver is missing node creation registering, it should store a zk.BUILDING state as soon as the instance is created | 03:37 |
| tristanC | then if it fails to switch to READY, it should be deleted to avoid leaking resource | 03:38 |
| tristanC | and cleaning alien node remains to be defined | 03:39 |
| *** bhavik has joined #zuul | 04:51 | |
| *** bhavik has quit IRC | 05:19 | |
| SpamapS | tristanC: that's good advice. At this point I've pulled away from it. There's just too much going on and I do have a big OpenStack cloud to play with. :-P | 06:19 |
| SpamapS | tobiash: have you considered open sourcing your dockerfiles for zuul? I am itching to try Zuul-in-k8s. | 06:34 |
| tobiash | SpamapS: older versions of them are open reviews in zuul and nodepool | 07:12 |
| tobiash | But there was the feedback that these should not be part of the zuul repo | 07:13 |
| tobiash | I can push up the latest versions if you want | 07:14 |
| tobiash | But opensourcing them as a separate project/repo is a major process overhead for me compared to contributing to an existing opensource project | 07:16 |
| SpamapS | tobiash: Yeah, new repo, new everything. I agree, starting fresh is harder. | 07:28 |
| SpamapS | tobiash: well if you ever wanted to just toss them in a github repo somewhere, I'd be happy to move it forward from there. | 07:53 |
| SpamapS | Ideally w/ Helm charts too. | 07:53 |
| tobiash | SpamapS: I'll push up what I have later. Atm I'm not at the PC | 08:18 |
| *** bhavik has joined #zuul | 10:02 | |
| *** bhavik has quit IRC | 10:13 | |
| *** rcarrill1 has joined #zuul | 13:36 | |
| *** rcarrillocruz has quit IRC | 13:40 | |
| *** rcarrillocruz has joined #zuul | 13:51 | |
| *** rcarrill1 has quit IRC | 13:53 | |
| *** openstackgerrit has joined #zuul | 14:16 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Add Dockerfile https://review.openstack.org/465912 | 14:16 |
| tobiash | SpamapS: ^^ this is my currently in use dockerfile | 14:17 |
| tobiash | I derive scheduler/executor/web specific images from there to add a logging config | 14:17 |
| tobiash | For the deployment I use openshift and not helm with plain kubernetes so I have no helm chart I could provide | 14:18 |
| SpamapS | tobiash: oh that's fine, I meant I'd ideally produce helm charts. ;) | 15:13 |
| SpamapS | thanks!! | 15:13 |
| SpamapS | tobiash: also are you able to use a normal ingress to make log streaming work? | 15:31 |
| SpamapS | or do you need another container with a special apache/nginx for that? | 15:31 |
| tobiash | SpamapS: I have an apache in front of it | 15:32 |
| tobiash | But mainly for url rewrite to /zuul | 15:32 |
| SpamapS | Looks like the nginx ingress controller claims to support websockets. | 15:33 |
| tobiash | I'm using openshift routes which is haproxy | 15:33 |
| SpamapS | yeah, I hear people are actually moving to haproxy in droves anyway because it has some advantages. | 15:34 |
| SpamapS | and the hosted k8s's all don't use it. | 15:34 |
| SpamapS | The nginx config required these days is really really tiny. | 15:35 |
| SpamapS | In fact once GH hooks are in zuul-web it's just /static and then throw everything at zuul-web. | 15:35 |
| SpamapS | anybody have a quick pointer to the place where query string args for status.html are documented? Trying to set filters.. not sure how. | 15:50 |
| tobiash | I think filters are implemented client side | 15:57 |
| *** rcarrill1 has joined #zuul | 16:14 | |
| *** rcarrillocruz has quit IRC | 16:17 | |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/zuul feature/zuulv3: WIP Add specific setup inventory https://review.openstack.org/530265 | 16:24 |
| SpamapS | tobiash: I am sure they are. I don't know how to read the static html/javascript to figure out how to pass them on the URL | 16:29 |
| SpamapS | I mean I can learn | 16:29 |
| SpamapS | but was hoping for a quick shortcut :) | 16:29 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/zuul feature/zuulv3: WIP Add specific setup inventory https://review.openstack.org/530265 | 16:40 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Fix non-standard docs build https://review.openstack.org/530087 | 16:42 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/zuul feature/zuulv3: WIP Add specific setup inventory https://review.openstack.org/530265 | 17:02 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/zuul feature/zuulv3: Add specific setup inventory https://review.openstack.org/530265 | 17:14 |
| SpamapS | jlk: I have learned something in trying to beat hoist into submission enough to be run directly by Zuul. The way we did group_vars was I think the wrong approach. | 17:14 |
| SpamapS | jlk: I think the way to go is to create roles full of defaults, and depend on them. | 17:15 |
| SpamapS | just thought I'd share | 17:16 |
| SpamapS | Kind of struggling with hoist.. which is why I'm bugging tobiash for his Dockerfiles. ;-) | 17:16 |
| * SpamapS is about 80% of the way through his first post job that deploys stuff to real resources. | 18:49 | |
| SpamapS | one tricky part is.. it deploys zuul. ;) | 18:49 |
| SpamapS | so.. inception is a problem. ;) | 18:50 |
| rcarrill1 | mordred: | 20:44 |
| rcarrill1 | 2017-12-28 20:36:18,031 DEBUG zuul.AnsibleJob: [build: f1e4cfe7dd8446c0aaa3e5026ea20ba6] Ansible command: ANSIBLE_CONFIG=/tmp/f1e4cfe7dd8446c0aaa3e5026ea20ba6/ansible/setup_playbook/ansible.cfg ansible '*' -v -m setup -i /tmp/f1e4cfe7dd8446c0aaa3e5026ea20ba6/ansible/setup-inventory.yaml -a 'gather_subset=!all' | 20:44 |
| rcarrill1 | that from running https://review.openstack.org/#/c/530265/ | 20:44 |
| rcarrill1 | tl;dr : i create setup-inventory.yaml, with just hosts, so runAnsibleSetup specifically uses it , by passing -i setup-inventory.yaml | 20:45 |
| rcarrill1 | the rest just works, as the good ol' inventory.yaml is put on ansible.cfg | 20:45 |
| rcarrill1 | the setup-inventory.yaml is populated from getHostList, but simply skipping the nodes with conneciton types put on blacklist (in this case network_cli, could be expanded should other connection types need this behaviour) | 20:46 |
| *** rcarrill1 is now known as rcarrillocruz | 20:46 | |
| *** Shrews has quit IRC | 21:06 | |
| *** Shrews has joined #zuul | 21:07 | |
| *** harlowja has quit IRC | 23:37 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!