openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Add --strip option to encrypt_secret.py https://review.openstack.org/530547 | 00:32 |
---|---|---|
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Enable direct use of github driver in debug tool https://review.openstack.org/529606 | 00:36 |
SpamapS | damn | 01:05 |
* SpamapS gets through the backlog | 01:05 | |
SpamapS | was hoping the "we're CPU bound" discussion would end in "I guess we have to rewrite that calc code in rust" | 01:05 |
SpamapS | ;-) | 01:05 |
mrhillsman | is the zuul ML setup already? | 01:31 |
mrhillsman | i wanted to start a thread regarding zuul behind vpn or environments that do not allow public access | 01:32 |
clarkb | mrhillsman: it is, lists.zuul-ci.org | 01:52 |
mrhillsman | thx | 01:53 |
clarkb | I don't know how many people are subscribed at this point but you can subscribe and it is functional | 01:53 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Do pep8 housekeeping according to zuul rules https://review.openstack.org/522945 | 02:20 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Use same flake8 config as in zuul https://review.openstack.org/509715 | 02:20 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul feature/zuulv3: pep8: ignore E124 rule https://review.openstack.org/534588 | 02:24 |
*** rlandy has quit IRC | 02:27 | |
*** jaianshu has joined #zuul | 03:57 | |
openstackgerrit | Jens Harbott (frickler) proposed openstack-infra/zuul feature/zuulv3: Fix dependency cycle false positive https://review.openstack.org/534444 | 04:24 |
*** bhavik1 has joined #zuul | 04:32 | |
*** ankkumar has joined #zuul | 05:08 | |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Remove unused method term_handler https://review.openstack.org/530202 | 05:16 |
*** smyers has quit IRC | 05:16 | |
*** robled has quit IRC | 05:19 | |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Fix dependency cycle false positive https://review.openstack.org/534444 | 05:20 |
*** bhavik1 has quit IRC | 05:21 | |
*** smyers has joined #zuul | 05:33 | |
*** robled has joined #zuul | 05:38 | |
*** robled has quit IRC | 05:38 | |
*** robled has joined #zuul | 05:38 | |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Centrally register stack dump handler https://review.openstack.org/530203 | 05:47 |
*** saop has joined #zuul | 05:53 | |
*** flepied has joined #zuul | 06:22 | |
*** flepied has quit IRC | 06:23 | |
*** flepied has joined #zuul | 06:24 | |
*** flepied has quit IRC | 06:35 | |
*** threestrands_ has quit IRC | 07:20 | |
*** jkilpatr has quit IRC | 07:28 | |
*** jkilpatr has joined #zuul | 07:39 | |
*** flepied has joined #zuul | 07:39 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul feature/zuulv3: Add memory awareness to system load governor https://review.openstack.org/508960 | 08:08 |
*** flepied_ has joined #zuul | 08:15 | |
*** flepied has quit IRC | 08:18 | |
*** jpena|off is now known as jpena | 08:57 | |
*** xinliang has quit IRC | 09:48 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Adjust check for .stestr directory https://review.openstack.org/532688 | 09:48 |
*** flepied__ has joined #zuul | 09:52 | |
*** sshnaidm|off is now known as sshnaidm | 09:54 | |
*** flepied_ has quit IRC | 09:55 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Clean up when conditions in fetch-subunit-output https://review.openstack.org/534428 | 09:57 |
*** xinliang has joined #zuul | 10:00 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Only fail requests if no cloud can service them https://review.openstack.org/533372 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: handler: fix support for handler without launch_manager https://review.openstack.org/524773 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add a plugin interface for drivers https://review.openstack.org/524620 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: builder: do not cleanup image for driver not managing image https://review.openstack.org/516920 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a static driver for Nodepool https://review.openstack.org/468624 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Refactor run_handler to be generic https://review.openstack.org/526325 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Refactor NodeLauncher to be generic https://review.openstack.org/532450 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an OpenContainer driver https://review.openstack.org/468753 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement a Kubernetes driver https://review.openstack.org/521356 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Implement an Amazon EC2 driver https://review.openstack.org/528982 | 10:37 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test https://review.openstack.org/533771 | 10:38 |
tristanC | fwiw i've succesfully run some zuul-jobs on aws with 528982, and this last patchset implements proper alien/failed-build node cleaning | 10:39 |
*** flepied__ is now known as flepied | 10:40 | |
saop | tristanC, Ansible failing in posting logs to logserver, "msg": "SSH Error: data could not be sent to remote host 'ubuntu'. But we already set private key and manually we are able to ssh, any thing we missed? | 10:59 |
tristanC | saop: did you used the add-fileserver role? | 11:00 |
saop | tristanC, yes we used it | 11:00 |
tristanC | saop: the executor is running playbook in a restricted environment, so it probably doesn't have the same access that you have when testing manually | 11:01 |
saop | tristanC, - hosts: all | 11:04 |
saop | tasks: | 11:04 |
saop | # add-fileserver role's tasks inlined bellow | 11:04 |
saop | - name: Add fileserver to inventory | 11:04 |
saop | add_host: | 11:04 |
saop | name: 10.13.120.209 | 11:04 |
saop | ansible_ssh_host: ubuntu | 11:04 |
saop | ansible_ssh_private_key_file: "~/.ssh/myserver.rsa" | 11:04 |
saop | zuul_fileserver_project_path: /var/www/logs/{{ zuul.project.short_name }} | 11:04 |
saop | tristanC, that is the add fileserver thing for us | 11:04 |
tristanC | saop: yes, "~/.ssh/" shouldn't be available to the playbook running by the executor | 11:05 |
tristanC | saop: if you don't want to bother with using a zuul secret, then you can put that myserver.rsa file into a separate directory, e.g. /etc/zuul-keys | 11:05 |
saop | tristanC, /etc/zuul-keys that is on the nodepool node, or the ansible host? | 11:06 |
tristanC | saop: and then, you can map that /etc/zuul-keys directory inside the executor bubblewrap using that option: https://docs.openstack.org/infra/zuul/feature/zuulv3/admin/components.html#attr-executor.untrusted_ro_paths | 11:07 |
tristanC | saop: on the executor node running the above playbook | 11:07 |
tristanC | saop: oops, you should use "trusted_ro_paths" for config-projects playbook instead | 11:08 |
saop | tristanC, so this line 'ansible_ssh_private_key_file: "~/.ssh/myserver.rsa"' ansible_ssh_private_key_file: "/etc/zuul-keys/myserver.rsa" after? | 11:09 |
tristanC | saop: yes, and you need to restart the executor after adding that trusted_ro_paths option to zuul.conf | 11:10 |
saop | tristanC, Thanks | 11:10 |
* SpamapS rather likes that feature. :) | 11:59 | |
*** jkilpatr has quit IRC | 12:07 | |
*** jkilpatr has joined #zuul | 12:09 | |
*** sshnaidm is now known as sshnaidm|afk | 12:11 | |
*** sshnaidm|afk has quit IRC | 12:16 | |
*** jpena is now known as jpena|lunch | 12:45 | |
*** sshnaidm|afk has joined #zuul | 12:55 | |
*** sshnaidm|afk is now known as sshnaidm | 12:55 | |
saop | tristanC, In the 'zuul_return' phase of ansible, its failing with error: 'The error was: KeyError: 'ZUUL_JOBDIR'' | 13:24 |
tristanC | saop: zuul_return can only be used on localhost | 13:25 |
saop | tristanC, we are using in localhost only | 13:25 |
saop | tristanC, ubuntu | MODULE FAILURE while debuging we got this | 13:25 |
saop | tristanC, okay i got it | 13:26 |
saop | tristanC, found the missing line delegate_to: localhost | 13:26 |
*** rlandy has joined #zuul | 13:30 | |
*** dkranz has joined #zuul | 13:31 | |
*** jaianshu has quit IRC | 13:35 | |
*** ankkumar has quit IRC | 13:40 | |
*** saop has quit IRC | 13:43 | |
Shrews | tristanC: woah, you've got quite a collection of drivers going there. awesome! | 13:46 |
*** jpena|lunch is now known as jpena | 13:48 | |
Shrews | clarkb: found an issue with 533771. i'm not sure how to do what you want to do there yet. i'm still pre-coffee | 13:53 |
tristanC | Shrews: heh, still trying to figure out a good interface to support different workflow | 13:53 |
*** hashar is now known as hasharAway | 14:06 | |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Rename _useBuilder method to useBuilder https://review.openstack.org/531883 | 14:29 |
*** sshnaidm is now known as sshnaidm|mtg | 14:46 | |
*** flepied has quit IRC | 15:05 | |
*** sc68cal has quit IRC | 15:09 | |
fungi | is tests.unit.test_git_driver.Te | 15:17 |
fungi | ugh, stray newlin... is tests.unit.test_git_driver.TestGitDriver.test_ref_updated_event unreliable? | 15:18 |
fungi | seems i'm running afoul of it on a trivial change to zuul's docs: https://review.openstack.org/531912 | 15:18 |
tobiash | hm, good question | 15:27 |
tobiash | it looks like today the zuul tests are generally unstable somehow | 15:27 |
corvus | yeah, that test just has a simple delay that's too short | 15:39 |
corvus | i think we can fix that systemically by having the git driver used in tests record when it emits an event, that will tell us when we can call waitUntilSettled | 15:40 |
*** sc68cal has joined #zuul | 15:49 | |
*** flepied has joined #zuul | 15:55 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Stabilize git driver tests https://review.openstack.org/534818 | 15:58 |
corvus | fungi, tobiash, fbo: ^ | 15:59 |
*** sshnaidm|mtg is now known as sshnaidm | 16:19 | |
Shrews | so this is happening today at my place: https://photos.app.goo.gl/v4TEHiYlhESLgi9I3 | 16:20 |
Shrews | quite the rare occurrence | 16:21 |
Shrews | tristanC: tobiash: re-approved the pep8/flake8 changes | 16:43 |
pabelanger | Shrews: nice snow! | 16:46 |
pabelanger | love it | 16:46 |
tobiash | corvus: looking | 16:50 |
tobiash | Shrews: cool, so much snow | 16:50 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components https://review.openstack.org/534841 | 16:51 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components https://review.openstack.org/534841 | 16:57 |
clarkb | Shrews: hrm ya I guess that is a race. I too don't have any immediate ideas on how to address it | 16:59 |
Shrews | clarkb: maybe if you create additional unique labels to each provider, request those first, then request the shared label? | 17:06 |
clarkb | oh ya that should work | 17:07 |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Do pep8 housekeeping according to zuul rules https://review.openstack.org/522945 | 17:07 |
*** flepied has quit IRC | 17:08 | |
openstackgerrit | Merged openstack-infra/nodepool feature/zuulv3: Use same flake8 config as in zuul https://review.openstack.org/509715 | 17:09 |
*** flepied has joined #zuul | 17:11 | |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test https://review.openstack.org/533771 | 17:12 |
clarkb | Shrews: ^ maybe it is that simple? | 17:12 |
mordred | corvus: +2 with comments on https://review.openstack.org/#/c/534841/ - feel free to land | 17:17 |
Shrews | clarkb: shouldn't your 2nd request for fake-label go to FAILED with your change? If it ever goes PENDING, that's only a temporary state due to your change, right? | 17:30 |
Shrews | clarkb: and i think the first request for fake-label is racey on PENDING to, since it should also transition back to REQUESTED | 17:31 |
Shrews | clarkb: oh, no, i'm wrong on the first part of that. 2nd request will pause | 17:33 |
clarkb | Shrews: for the first thing, no thats exactly what we are fixing. We should only fail after all available providers have failed or declined the request. So both fake-labels go to paused one on each provider. Then we delete the existing node on the second provider unpausing its fake-label request. Then we also delete that fake-label node. At this point the only outstanding request is the fake-label on the first | 17:33 |
clarkb | provider. We make it fail due to exception then provider2 picks it up and fulfills it | 17:33 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components https://review.openstack.org/534841 | 17:33 |
corvus | mordred: tests are failing anyway, so i went ahead and ammended it with your and tobiash's suggested changes | 17:34 |
clarkb | Shrews: and I don't thnk there is a race on PENDING as that is the state that paused requests seem to go in | 17:34 |
clarkb | Shrews: so once both reuqests are paused they are pending | 17:34 |
mordred | clarkb: cool | 17:35 |
Shrews | clarkb: oh, i got confused a sec... we aren't actually testing your change here, which is what i was expecting | 17:38 |
clarkb | Shrews: we arne't? | 17:38 |
Shrews | your change being the exception from run_handler causing the request to go back to REQUESTED | 17:38 |
clarkb | Shrews: we do | 17:39 |
clarkb | by checking that the second provider ends up fulfilling the request | 17:39 |
clarkb | which it won't do if the request is marked failed instead | 17:39 |
clarkb | we are doing a functional test that a cloud failure in fake-provider doesn't prevent fake-provider2 from fulfilling the request. The painful part of the test is that we have to ensure that fake-provider grabs the request first and also declines it due to failure which is why we end up with all those requests to "prime" the system | 17:41 |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Don't fetch coverage report from failing tests https://review.openstack.org/534853 | 17:45 |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Don't fetch coverage report from failing tests https://review.openstack.org/534853 | 17:47 |
Shrews | sorry... lost power for a minute | 17:47 |
Shrews | clarkb: ok, yeah. i see now. i confused myself for a bit | 17:48 |
clarkb | Shrews: It took me like 5 hours to sort out that test because its a bit confusing :) | 17:48 |
Shrews | btw, if i disappear, it's probably b/c of a power loss and I went to find someplace warm | 17:48 |
clarkb | also that is like the 4th appraoch I took | 17:49 |
clarkb | dealing with different provider threads racing each other is ufn | 17:49 |
Shrews | yeah, not so much | 17:49 |
corvus | it looks like the other zuul tests are failing due to a dependency change, i suspect something aiohttp related. digging into it now. | 17:49 |
corvus | (probably they made a release because of that dep that we had to pin) | 17:50 |
Shrews | corvus: aiohttp... now THAT'S fun | 17:50 |
corvus | heh, yeah, aiohttp made a release which works with yarl 1.0 but not yarl<1.0 | 17:52 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Stabilize git driver tests https://review.openstack.org/534818 | 17:54 |
corvus | ok, that should fix both things | 17:54 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Document connection information for components https://review.openstack.org/534841 | 17:54 |
*** jpena is now known as jpena|off | 18:17 | |
corvus | mordred: 534841 and parent are passing tests and ready now | 18:31 |
corvus | parent will unblock gate | 18:31 |
mordred | corvus: +A to both | 18:33 |
openstackgerrit | Andreas Jaeger proposed openstack-infra/zuul-jobs master: Don't fetch coverage report from failing tests https://review.openstack.org/534853 | 18:54 |
*** flepied_ has joined #zuul | 19:09 | |
*** flepied has quit IRC | 19:10 | |
corvus | zuul/nodepool don't have a backlog -- should we restart them to pick up the CSD changes? | 19:18 |
corvus | oops, wrong channel | 19:18 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test https://review.openstack.org/533771 | 19:36 |
clarkb | now with pep8 fixes | 19:36 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Stabilize git driver tests https://review.openstack.org/534818 | 19:43 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Only fail requests if no cloud can service them https://review.openstack.org/533372 | 19:47 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool feature/zuulv3: Add test_launcher test https://review.openstack.org/533771 | 19:47 |
clarkb | rebased because testing api changed | 19:47 |
SpamapS | Have we ever talked about how we might support tags in playbooks? | 19:48 |
pabelanger | yah, I think there is a story for it in SB | 19:49 |
SpamapS | I have a few playbooks that work well directly run by Ansible, but that I'd like to be able to test with a mix of tags. | 19:49 |
pabelanger | tripleo wanted to use them | 19:49 |
SpamapS | run by Zuul I mean. | 19:49 |
pabelanger | SpamapS: https://storyboard.openstack.org/#!/story/2001353 | 19:50 |
SpamapS | pabelanger: thanks. Couldn't find it. :-P | 19:58 |
*** hasharAway is now known as hashar | 20:04 | |
*** corvus is now known as jeblair | 20:37 | |
*** jeblair is now known as corvus | 20:37 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Don't gather host keys for non ssh connections https://review.openstack.org/503166 | 20:41 |
openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool feature/zuulv3: Add connection-port to provider diskimage https://review.openstack.org/504112 | 20:41 |
Shrews | leifmadsen_: oy, did you pick a bad time to come to Raleigh | 20:52 |
SpamapS | woot, fb-re2/pyre2 maintainer lives. :) | 20:54 |
leifmadsen_ | Shrews: no shit! | 21:01 |
leifmadsen_ | Shrews: every bloody time I come to the south, it snows | 21:01 |
leifmadsen_ | our training got cancelled today... so, I may or may not be sitting in a bar | 21:02 |
Shrews | leifmadsen_: sitting in a bar may, or may not, be an excellent choice | 21:04 |
*** hashar has quit IRC | 21:16 | |
*** hashar has joined #zuul | 21:27 | |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Document connection information for components https://review.openstack.org/534841 | 21:28 |
leifmadsen_ | Shrews: :D | 21:36 |
*** threestrands_ has joined #zuul | 21:44 | |
*** hashar has quit IRC | 21:44 | |
*** threestrands_ has quit IRC | 21:45 | |
*** threestrands_ has joined #zuul | 21:45 | |
*** threestrands_ has quit IRC | 21:45 | |
*** threestrands_ has joined #zuul | 21:45 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle secrets in branches https://review.openstack.org/534956 | 21:50 |
corvus | we also need to do the same thing as that ^ for nodesets i think | 21:51 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Make ZuulDaemonApp an abstract base class https://review.openstack.org/530204 | 22:28 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle secrets in branches https://review.openstack.org/534956 | 22:40 |
*** jkilpatr has quit IRC | 22:54 | |
corvus | fungi, clarkb, mordred, tobiash, SpamapS: i sent an email to -discuss about ^: http://lists.zuul-ci.org/pipermail/zuul-discuss/2018-January/000003.html | 23:03 |
clarkb | Shrews: can you rereview https://review.openstack.org/#/c/533771/9 and its parent now? I think I've addressed the review comments and the rebase got tests working again so should be good to go | 23:05 |
openstackgerrit | Merged openstack-infra/zuul feature/zuulv3: Register term_handler for all zuul apps https://review.openstack.org/530205 | 23:07 |
Shrews | clarkb: done | 23:16 |
*** persia has quit IRC | 23:18 | |
*** persia has joined #zuul | 23:18 | |
*** rlandy has quit IRC | 23:40 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul feature/zuulv3: Handle nodesets in branches https://review.openstack.org/534974 | 23:51 |
*** persia has quit IRC | 23:53 | |
*** dkranz has quit IRC | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!