| *** sshnaidm|rover is now known as sshnaidm|afk | 00:56 | |
| openstackgerrit | Vu Cong Tuan proposed openstack-infra/zuul-jobs master: Switch to stestr https://review.openstack.org/580028 | 02:07 |
|---|---|---|
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: doc: re-order GitHub Application configuration https://review.openstack.org/580247 | 02:20 |
| *** pwhalen has quit IRC | 02:54 | |
| *** pwhalen has joined #zuul | 02:56 | |
| openstackgerrit | David Moreau Simard proposed openstack-infra/zuul master: Enable ARA action plugins for ara_record and ara_read https://review.openstack.org/580256 | 03:02 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: Ensure iptables-services is installed when persisting firewall config https://review.openstack.org/579283 | 03:53 |
| *** swest has joined #zuul | 04:54 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift resource provider https://review.openstack.org/570667 | 05:12 |
| *** yolanda has joined #zuul | 05:30 | |
| *** ianychoi has joined #zuul | 05:34 | |
| *** pawelzny has quit IRC | 05:58 | |
| *** pawelzny has joined #zuul | 05:59 | |
| *** nchakrab has joined #zuul | 06:20 | |
| *** gtema has joined #zuul | 06:23 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Make GitHub rate limit logging configurable https://review.openstack.org/580295 | 06:26 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Make GitHub rate limit logging configurable https://review.openstack.org/580295 | 06:33 |
| *** robled has quit IRC | 06:45 | |
| *** robled has joined #zuul | 06:50 | |
| *** robled has quit IRC | 06:50 | |
| *** robled has joined #zuul | 06:50 | |
| *** jpena|off is now known as jpena | 07:05 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Reduce requests to github when listing project branches https://review.openstack.org/580218 | 07:10 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Make GitHub rate limit logging configurable https://review.openstack.org/580295 | 07:10 |
| *** sshnaidm|afk has quit IRC | 07:14 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Make GitHub rate limit logging configurable https://review.openstack.org/580295 | 07:17 |
| *** sshnaidm|afk has joined #zuul | 07:21 | |
| *** sshnaidm|afk is now known as sshnaidm|rover | 08:16 | |
| *** zaro has quit IRC | 09:11 | |
| *** zaro has joined #zuul | 09:12 | |
| *** hashar has quit IRC | 09:21 | |
| *** hashar has joined #zuul | 09:38 | |
| *** spsurya_ has quit IRC | 09:49 | |
| *** gtema has quit IRC | 10:57 | |
| *** jpena is now known as jpena|lunch | 11:05 | |
| *** gtema has joined #zuul | 11:05 | |
| *** hashar is now known as hasharAway | 11:21 | |
| *** gtema has quit IRC | 11:25 | |
| *** gtema has joined #zuul | 11:26 | |
| *** sshnaidm|rover is now known as sshnaidm|rov|lnc | 11:33 | |
| openstackgerrit | Merged openstack-infra/zuul master: doc: re-order GitHub Application configuration https://review.openstack.org/580247 | 12:11 |
| *** sshnaidm|rov|lnc is now known as sshnaidm|rover | 12:15 | |
| *** gtema_ has joined #zuul | 12:15 | |
| *** gtema has quit IRC | 12:18 | |
| *** rlandy has joined #zuul | 12:23 | |
| *** nchakrab has quit IRC | 12:23 | |
| *** nchakrab has joined #zuul | 12:24 | |
| *** nchakrab_ has joined #zuul | 12:31 | |
| *** nchakrab has quit IRC | 12:35 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Support skip_child_jobs via zuul_return https://review.openstack.org/578230 | 12:45 |
| *** hasharAway is now known as hashar | 12:48 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Fix zuul startup with inexisting project template and gate https://review.openstack.org/579859 | 12:50 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Tolerate missing project https://review.openstack.org/579872 | 12:50 |
| *** swest has quit IRC | 13:27 | |
| *** jpena|lunch is now known as jpena | 13:28 | |
| *** swest has joined #zuul | 13:29 | |
| *** nchakrab_ has quit IRC | 13:30 | |
| *** nchakrab has joined #zuul | 13:31 | |
| *** swest has quit IRC | 13:34 | |
| *** swest has joined #zuul | 13:34 | |
| *** swest has quit IRC | 13:49 | |
| mordred | rcarrillocruz: yes, I looked at it - and mention it in the spec iirc - I think it's a promising possibility - but I wanted to keep things simple and start with docker | 14:03 |
| rcarrillocruz | ack | 14:03 |
| mordred | rcarrillocruz: if you mean instead of pbrx - no, they do different things. if we adopt buildah for building the images, I'd update pbrx to use it | 14:04 |
| rcarrillocruz | so pbrx is a wrapper around an image builder, in what sense | 14:04 |
| mordred | it knows how to build images given a python project using bindep and pbr ... so that you don't have to duplicate the information already present in requirements and bindep | 14:06 |
| mordred | and also setup.cfg already contains a list of the commands that would be installed by the python project as well - so you can make per-command container images | 14:06 |
| rcarrillocruz | ah gotcha... | 14:07 |
| rcarrillocruz | that's for contanerizing zuul i guess ? | 14:07 |
| *** nchakrab has quit IRC | 14:07 | |
| mordred | yah - or literally any other python project that uses bindep and pbr | 14:07 |
| rcarrillocruz | containerizing too | 14:07 |
| mordred | but yes, exploring using it for building/publishing zuul containers | 14:08 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Update bindep file with build profiles https://review.openstack.org/580159 | 14:25 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Add job to build container images using pbrx https://review.openstack.org/580160 | 14:25 |
| mordred | tobiash: thanks for the review - hopefully those will suck less :) | 14:25 |
| corvus | tobiash, jhesketh, tristanC: see my comment on https://review.openstack.org/580247 please | 14:26 |
| tobiash | corvus: oh, overlooked that | 14:44 |
| *** nchakrab has joined #zuul | 14:46 | |
| *** nchakrab_ has joined #zuul | 14:47 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Sync zuul from scratch github app settings https://review.openstack.org/580403 | 14:47 |
| tobiash | corvus: ^ | 14:47 |
| *** nchakrab has quit IRC | 14:51 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Support zuul.child_jobs via zuul_return https://review.openstack.org/578230 | 14:54 |
| *** jiapei has quit IRC | 14:58 | |
| *** acozine1 has joined #zuul | 15:21 | |
| *** nchakrab_ has quit IRC | 15:30 | |
| corvus | tobiash: i'm going to continue trying to find underlying causes of job source contexts being wrong, with the hope that might supply a clue to your incident where a proposed change to a config repo was run. do you have any further information (or incidents)? | 15:49 |
| rcarrillocruz | hmm, folks , what's the default timeout for a job? | 15:50 |
| rcarrillocruz | just got a timeout at 30m, wondering if i hit that value or is due to some underlying issue in RDO | 15:51 |
| corvus | rcarrillocruz: there is no default timeout: https://zuul-ci.org/docs/zuul/user/config.html#attr-job.timeout | 15:51 |
| corvus | rcarrillocruz: but the 'base' job might define a timeout | 15:51 |
| corvus | (which all other jobs would inherit) | 15:51 |
| rcarrillocruz | ah... | 15:51 |
| * rcarrillocruz goes check | 15:52 | |
| rcarrillocruz | hah, indeed | 15:52 |
| rcarrillocruz | 1800 | 15:52 |
| rcarrillocruz | thx corvus :-) | 15:52 |
| corvus | np | 15:52 |
| tobiash | corvus: no, this was a single event so far and I had to work on other scaling and stability fixes | 15:53 |
| *** dtruong has joined #zuul | 15:55 | |
| tobiash | Like nodepool quota handling | 15:56 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Update bindep file with build profiles https://review.openstack.org/580159 | 16:05 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Add job to build container images using pbrx https://review.openstack.org/580160 | 16:05 |
| *** yolanda_ has joined #zuul | 16:13 | |
| *** yolanda has quit IRC | 16:17 | |
| corvus | tobiash, mordred: i see the problem that's causing our source_contexts to be wrong in openstack-infra: http://git.zuul-ci.org/cgit/zuul/tree/zuul/configloader.py#n1530 | 16:37 |
| corvus | if we fetch multiple zuul config files from a single project-branch, that causes them all to share the same source_context object. the .path attribute is overwritten, so the last filename wins. | 16:38 |
| corvus | i think it's relatively harmless, since all of the security checks are only looking at project+branch, not pathname. we're still creating new source_contexts for each project+branch. | 16:39 |
| corvus | so i don't immediately see a way for this to have caused the issue tobiash saw | 16:40 |
| mordred | corvus: nod. so the thing tobiash saw is potentially something else - and the pathname thing is just annoying and not necessarily dangerous | 16:40 |
| corvus | mordred: ya, that's what it's looking like to me. | 16:41 |
| gtema_ | mordred: any comments on shade->sdk change? | 16:41 |
| corvus | i'm going to work on a (one line) patch to fix this, plus a > one line test. | 16:41 |
| mordred | gtema_: oh - thanks for reminding me - lemme go look at that (I'm actually touching some similar things right now) | 16:43 |
| mordred | corvus: ++ | 16:43 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Fix source context in split config https://review.openstack.org/580449 | 16:53 |
| *** yolanda__ has joined #zuul | 16:53 | |
| corvus | tobiash: would you mind writing up everything you know about the error you observed and putting it in an etherpad? i know it's not much, but it may help. | 16:55 |
| tobiash | corvus: yes I can do that tomorrow. I'm afk this evening | 16:56 |
| *** yolanda_ has quit IRC | 16:56 | |
| corvus | tobiash: thanks! enjoy the afking :) | 16:57 |
| tobiash | Thanks :) | 16:57 |
| *** yolanda_ has joined #zuul | 17:12 | |
| *** yolanda__ has quit IRC | 17:15 | |
| *** hashar is now known as hasharAway | 17:20 | |
| *** rlandy is now known as rlandy|brb | 17:21 | |
| *** jpena is now known as jpena|off | 17:24 | |
| *** rlandy|brb is now known as rlandy | 17:40 | |
| *** sshnaidm|rover has quit IRC | 17:43 | |
| *** sshnaidm|rover has joined #zuul | 17:52 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Consume Task and TaskManager from openstacksdk https://review.openstack.org/414759 | 17:55 |
| *** yolanda__ has joined #zuul | 18:13 | |
| *** yolanda_ has quit IRC | 18:15 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Change TaskManager from is-a to has-a thread https://review.openstack.org/580463 | 18:26 |
| mordred | corvus, Shrews: ^^ this causes the test suite to hang - so I'm pretty sure I'm doing something wrong, but I can't see it | 18:27 |
| mordred | corvus, Shrews: oh. hrm. if I set the daemon flag on the thread it stops hanging | 18:31 |
| Shrews | tobiash: left you some comments on 536930. I think I'm missing the root cause of the problem you're trying to solve. | 18:32 |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Change TaskManager from is-a to has-a thread https://review.openstack.org/580463 | 18:33 |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Consume Task and TaskManager from openstacksdk https://review.openstack.org/414759 | 18:33 |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Remove Task class https://review.openstack.org/580466 | 18:33 |
| Shrews | mordred: that sounds fun | 18:34 |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Consume TaskManager from openstacksdk https://review.openstack.org/414759 | 18:34 |
| mordred | Shrews: yah. maybe the stack will work now | 18:34 |
| tobiash | Shrews: the root problem is that the quota calculations are not neccessarily precise due to timing or outside effects so we need to handle node launch failures caused by exceeding quota gravefully | 18:35 |
| gtema_ | mordred: and while you are waiting for tests - do review shade=>sdk ;-) | 18:35 |
| mordred | gtema_: :) | 18:35 |
| *** yolanda_ has joined #zuul | 18:35 | |
| *** yolanda__ has quit IRC | 18:39 | |
| *** yolanda__ has joined #zuul | 18:39 | |
| Shrews | mordred: the comment about logging the 'running task' portion from corvus here (https://review.openstack.org/#/c/414759/2/nodepool/task_manager.py) is still relevant. We don't log shade at debug level. | 18:41 |
| *** yolanda_ has quit IRC | 18:42 | |
| mordred | gtema_: looks great - left a couple of comments | 18:42 |
| Shrews | tobiash: lol, though I'm sure you meant 'gracefully', i find 'gravefully' amusing and more fun to consider when coding :) | 18:43 |
| gtema_ | mordred: ok, thanks | 18:43 |
| tobiash | lol, shitty mobile keyboard | 18:44 |
| openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Consume TaskManager from openstacksdk https://review.openstack.org/414759 | 18:45 |
| mordred | Shrews: done - thanks | 18:46 |
| *** sshnaidm|rover is now known as sshnaidm|off | 18:46 | |
| openstackgerrit | Artem Goncharov proposed openstack-infra/nodepool master: retire shade in favor of openstacksdk https://review.openstack.org/572829 | 18:50 |
| mordred | gtema_: lgtm | 18:55 |
| mordred | Shrews: ^^ how's that look to you? | 18:56 |
| gtema_ | good | 18:56 |
| *** gtema_ has quit IRC | 19:23 | |
| Shrews | mordred: that change to waitForImage in driver/openstack/provider.py is radically different from the replacement | 20:02 |
| Shrews | mordred: but saying that... i can't find that method actually being used anywhere. am i crazy? | 20:02 |
| openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool master: Remove OpenStack driver waitForImage call https://review.openstack.org/580487 | 20:05 |
| Shrews | we'll find out | 20:05 |
| *** acozine1 has quit IRC | 20:12 | |
| mordred | Shrews: I agree | 20:13 |
| mordred | Shrews: and yes - we use wait=True on create_image - so that waitForImage should be unused | 20:13 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Update bindep file with build profiles https://review.openstack.org/580159 | 20:18 |
| *** gouthamr has quit IRC | 20:27 | |
| *** dmellado has quit IRC | 20:28 | |
| Shrews | mordred: that code removal passes tests, so i'm ok with the shade replacement change. do we want to merge that now? we'll probably want a nodepool restart with these changes at some point when they can be watched | 20:36 |
| mordred | Shrews: as soon as the cherry-pick of your dict patch lands I wanna cut a new sdk version ... maybe let's wait until that's happened? | 20:44 |
| Shrews | mordred: k. i'll just add the +2 and a note | 20:44 |
| *** gouthamr has joined #zuul | 21:35 | |
| openstackgerrit | Merged openstack-infra/zuul master: Fix source context in split config https://review.openstack.org/580449 | 21:44 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add container spec https://review.openstack.org/560136 | 22:32 |
| jhesketh | corvus: woops, sorry, didn't realise that. +W'd the fix (re 580247 & now 580403) | 22:34 |
| *** hasharAway has quit IRC | 22:35 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: Switch to repos.fedorapeople.org for rdo-release package https://review.openstack.org/580518 | 22:37 |
| openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add container spec https://review.openstack.org/560136 | 22:39 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Install build bindep profiles alongside doc and test https://review.openstack.org/580521 | 22:44 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul master: Update bindep file with build profiles https://review.openstack.org/580159 | 22:45 |
| openstackgerrit | Merged openstack-infra/zuul master: Sync zuul from scratch github app settings https://review.openstack.org/580403 | 22:50 |
| *** ianychoi_ has joined #zuul | 23:01 | |
| logan- | is it possible to use the github driver just to enable depends-on without actually registering any webhooks or setting up an app? | 23:03 |
| *** ianychoi has quit IRC | 23:04 | |
| logan- | basically, no jobs targeting any github projects, but the ability to have gerrit patches cross test github PRs | 23:05 |
| *** yolanda_ has joined #zuul | 23:07 | |
| corvus | logan-: theoretically, yes, and i think we should support it, but i'm not sure that's tested or anyone has done it. without an app, it should fall back to the unauthenticated client, which means pretty significant query/rate limits. | 23:07 |
| *** yolanda__ has quit IRC | 23:08 | |
| *** yolanda__ has joined #zuul | 23:11 | |
| logan- | thanks | 23:11 |
| *** yolanda_ has quit IRC | 23:13 | |
| corvus | logan-: if you try it, let me know how it goes, or if you have problems | 23:17 |
| *** rlandy has quit IRC | 23:25 | |
| logan- | certainly | 23:25 |
| pabelanger | logan-: corvus: I believe we've tested that the other direction with kubernetes-incubator/kubespray in zuul.o.o: https://review.openstack.org/549768/ depends-on works, and we didn't setup a webapp | 23:30 |
| *** yolanda_ has joined #zuul | 23:40 | |
| *** yolanda__ has quit IRC | 23:42 | |
| logan- | cool pabelanger. one other question.. to cross test a github project, would it need to be added to the config as an untrusted project, or does the driver enable testing of any github PR regardless whether it is present in the tenant layout? | 23:52 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!