*** rlandy is now known as rlandy|bbl | 00:33 | |
*** fungi has quit IRC | 01:18 | |
*** Shrews has quit IRC | 01:19 | |
*** odyssey4me has quit IRC | 01:19 | |
*** sdoran has quit IRC | 01:19 | |
*** fungi has joined #zuul | 01:19 | |
*** odyssey4me has joined #zuul | 01:20 | |
*** ianw has quit IRC | 01:49 | |
*** zigo has quit IRC | 01:49 | |
*** spsurya has quit IRC | 01:49 | |
*** jamielennox has quit IRC | 01:49 | |
*** persia has quit IRC | 01:49 | |
*** ianw has joined #zuul | 01:53 | |
*** jamielennox has joined #zuul | 01:53 | |
*** persia has joined #zuul | 01:55 | |
*** Shrews has joined #zuul | 02:00 | |
*** ianw has quit IRC | 02:03 | |
*** ianw has joined #zuul | 02:04 | |
*** rlandy|bbl is now known as rlandy | 02:13 | |
*** eumel8 has quit IRC | 02:19 | |
*** openstack has joined #zuul | 02:52 | |
*** ChanServ sets mode: +o openstack | 02:52 | |
*** jhesketh has joined #zuul | 02:57 | |
*** openstackstatus has joined #zuul | 03:02 | |
*** ChanServ sets mode: +v openstackstatus | 03:02 | |
*** rlandy has quit IRC | 03:30 | |
*** spsurya has joined #zuul | 03:54 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add job page https://review.openstack.org/597048 | 04:20 |
---|---|---|
tristanC | corvus: 597048 now uses tabs and react-json-view. thanks for the suggestions! | 04:21 |
tristanC | it's now easy to spot differences in job variants and their variables | 04:21 |
*** mattclay has joined #zuul | 04:23 | |
*** myoung is now known as myoung|pto | 04:25 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add job page https://review.openstack.org/597048 | 04:35 |
*** neilsun has joined #zuul | 05:24 | |
*** nchakrab has joined #zuul | 06:10 | |
*** pcaruana has joined #zuul | 06:50 | |
*** electrofelix has joined #zuul | 07:20 | |
*** jesusaur has quit IRC | 07:23 | |
*** jesusaur has joined #zuul | 07:27 | |
*** fdegir has joined #zuul | 07:42 | |
*** threestrands has quit IRC | 07:50 | |
*** jpena|off is now known as jpena | 07:51 | |
*** zigo has joined #zuul | 07:54 | |
*** hashar has joined #zuul | 08:26 | |
openstackgerrit | Markus Hosch proposed openstack-infra/nodepool master: Add metric for image build result https://review.openstack.org/590412 | 08:31 |
openstackgerrit | Markus Hosch proposed openstack-infra/nodepool master: Add list of metrics provided to statsd https://review.openstack.org/590233 | 08:45 |
*** sshnaidm|afk is now known as sshnaidm | 08:59 | |
*** gundalow has joined #zuul | 09:30 | |
openstackgerrit | Markus Hosch proposed openstack-infra/nodepool master: Add metric for image build result https://review.openstack.org/590412 | 09:40 |
*** nchakrab has quit IRC | 09:53 | |
*** snapiri has joined #zuul | 11:01 | |
*** electrofelix has quit IRC | 11:02 | |
*** electrofelix has joined #zuul | 11:14 | |
openstackgerrit | Rafael Folco proposed openstack-infra/zuul-jobs master: [DNM] base-test #597235 https://review.openstack.org/597449 | 11:20 |
openstackgerrit | Rafael Folco proposed openstack-infra/zuul-jobs master: Set zuul job start time fact https://review.openstack.org/597235 | 11:35 |
*** snapiri has quit IRC | 11:35 | |
*** jpena is now known as jpena|lunch | 11:37 | |
*** elyezer has quit IRC | 12:08 | |
*** elyezer has joined #zuul | 12:15 | |
openstackgerrit | Rafael Folco proposed openstack-infra/zuul-jobs master: [DNM] base-test #597235 https://review.openstack.org/597449 | 12:26 |
*** sshnaidm is now known as sshnaidm|afk | 12:28 | |
*** rlandy has joined #zuul | 12:29 | |
*** jpena|lunch is now known as jpena | 12:46 | |
*** sshnaidm|afk is now known as sshnaidm | 13:02 | |
*** pcaruana has quit IRC | 13:04 | |
*** snapiri has joined #zuul | 13:08 | |
openstackgerrit | Rafael Folco proposed openstack-infra/zuul-jobs master: [WIP] Set zuul job start time fact https://review.openstack.org/597513 | 13:17 |
*** elyezer has quit IRC | 13:24 | |
pabelanger | tobiash: do you have a copy of your check pipeline you can share for github? Mostly curious how you are using labels in check | 13:34 |
dmsimard | tristanC: I'm not sure what the nodeset table cell represents ? https://i.imgur.com/fwAlidp.png | 13:37 |
*** elyezer has joined #zuul | 13:38 | |
*** dkehn has joined #zuul | 13:46 | |
*** jimi|ansible has joined #zuul | 13:46 | |
tristanC | dmsimard: number of server, number of group, then the list of node-name - label-name (group-name) | 13:48 |
dmsimard | tristanC: okay, that makes sense -- it would need labels (or at the very least alt text on the icons) | 13:48 |
tristanC | dmsimard: noted, thanks for the feedback :) | 13:48 |
tristanC | dmsimard: btw, the code for that component is https://review.openstack.org/#/c/597048/3/web/src/containers/job/Nodeset.jsx | 13:49 |
dmsimard | jsx makes my eyes bleed | 13:49 |
dmsimard | It's like.. not quite javascript and not quite html at the same time, it makes my brain want to cry | 13:50 |
dmsimard | I can read it but I can't write it :D | 13:50 |
tristanC | dmsimard: using the right editor, like emacs and rjsx-mode makes it very easy | 13:51 |
tristanC | dmsimard: and you can translate to javascript very easily, e.g.: https://reactjs.org/docs/react-without-jsx.html | 13:51 |
dmsimard | yeah I think if I cared more about frontend I could get myself to learn it :) | 13:51 |
tristanC | i find it much easier to use than jinja or any other templating systems, it's more powerfull as react only render when actually needed | 13:52 |
dmsimard | no doubt, I have a huge amount of respect for people who can write good frontends | 13:53 |
fungi | is there an etherpad yet for brainstorming zuul-oriented topic ideas for berlin forum sessions? | 13:59 |
fungi | i've gone ahead and created https://etherpad.openstack.org/p/BER-zuul-brainstorming and linked it from https://wiki.openstack.org/wiki/Forum/Berlin2018 but can switch it out if there's already one i'm not finding | 14:07 |
openstackgerrit | Rafael Folco proposed openstack-infra/zuul-jobs master: Set zuul job start time fact https://review.openstack.org/597235 | 14:29 |
*** pcaruana has joined #zuul | 14:50 | |
corvus | fungi: i think you're the first :) | 15:01 |
fungi | claire kept asking me if we had one, so... i just went ahead and created it | 15:01 |
fungi | also see her message to the zuul-discuss ml, the forum organizers are looking for a zuul subject matter expert interested in helping gauge any proposed zuul content for forum sessions (or more likely just representing the ones we add on our brainstorming etherpad) | 15:02 |
fungi | well, s/content/topics/ as it's the forum | 15:03 |
corvus | tristanC: 597048 is great! it's super easy to compare branch variants, and presents it in an intuitive manner. a couple of minor things: it'd be nice to highlight the current "tab" (and for them to look more like something you can click -- but i think if you bold and/or underline the current one, that might be enough to suggest that you can click them all). and i think it'd be good if we didn't have to | 15:06 |
corvus | scroll the description -- just let it be large. | 15:06 |
tristanC | corvus: noted. about the description, it may shift the other attributes' position and makes comparaison less easy. Especially for the devstack job that has varying description size on some branches. | 15:11 |
tristanC | maybe the description could be collapsable? | 15:13 |
corvus | tristanC: maybe... we also talked about possibly putting the reference definition description (ie, the first variant) above the table, then including the variant description in the table... | 15:14 |
corvus | tristanC: okay, so just brainstorming without any idea whether this is possible -- but what would be ideal is if the description field were as tall as needed for the longest description. | 15:14 |
corvus | i'm pretty sure nothing actually works like that and it would be really difficult/impossible to do. but it sure would be nice :) | 15:15 |
corvus | tristanC: at the very least, let's at least make it a bit larger for now -- as it is, for me, it doesn't actually look like the description for devstack master is any longer than stable/pike | 15:16 |
tristanC | comuting the max size is doable, but it may look weird if one of the description is extra long. | 15:17 |
corvus | tristanC: i think that might be okay -- the big empty space is actually extra information :) (and besides, things usually get bigger over time, so it's probably the reference definition which would have the long one anyway, and that shows up first) | 15:18 |
tristanC | corvus: actually it's quite easy using https://github.com/nkbt/react-height . Next PS should implement the last suggestion | 15:40 |
corvus | wow magic! | 15:42 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add job page https://review.openstack.org/597048 | 15:49 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add config-errors notifications drawer https://review.openstack.org/597147 | 15:49 |
tristanC | corvus: also, have you checked the config-error notifications? | 15:49 |
tristanC | you can find some on the rdoproject.org from this page: http://logs.openstack.org/47/597147/3/check/zuul-build-dashboard-multi-tenant/340268a/npm/html/ | 15:50 |
tristanC | on the top right, there is a bell, and when you click any of them, there is a page with the full details | 15:50 |
corvus | tristanC: that's sweet! | 15:51 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add config-errors notifications drawer https://review.openstack.org/597147 | 15:52 |
tristanC | corvus: and one last link for today, here is a test deployment with the rewrite rule from the installation.rst doc: http://38.145.32.112/react-zuul-openstack/job/devstack | 16:01 |
tristanC | that demonstrates links url as you suggested | 16:03 |
pabelanger | tristanC: that looks way nice | 16:04 |
pabelanger | http://38.145.32.112/react-zuul-openstack/job/devstack-minimal | 16:05 |
pabelanger | seems odd with less text | 16:05 |
pabelanger | but pretty | 16:05 |
corvus | tristanC: links url? which suggestion is that? | 16:10 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add private key storage migration https://review.openstack.org/592213 | 16:12 |
tristanC | corvus: that links should looks like "/job/devstack" instead of "#/job/devstack" or "job.html?name=devstack" | 16:12 |
tristanC | this is using the configuration L170 of https://review.openstack.org/#/c/591604/24/doc/source/admin/installation.rst | 16:13 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add job page https://review.openstack.org/597048 | 16:13 |
corvus | tristanC: ah, gotcha | 16:14 |
tristanC | this is not working in job artifacts as the logserver is missing the rewrite catchall to index.html | 16:14 |
tristanC | but it does work fine when using the rewriterule documented in the installation.rst | 16:16 |
SpamapS | corvus: did I hear correctly that you were working on logs -> swift? | 16:26 |
*** hashar is now known as hasharAway | 16:28 | |
corvus | SpamapS: yes. tobiash has it in production. it's *basically* ready for openstack but not in prod yet. let me dig up urls | 16:29 |
corvus | SpamapS: here's the main role: https://zuul-ci.org/docs/zuul-jobs/roles.html#role-upload-logs-swift | 16:30 |
corvus | SpamapS: here's the playbook standing by for openstack's use: http://git.openstack.org/cgit/openstack-infra/project-config/tree/playbooks/base-test/post-logs-swift.yaml | 16:31 |
*** jpena is now known as jpena|off | 16:31 | |
corvus | SpamapS: note that playbook runs an 'htmlify' role which compensates for not having an os-loganalyze proxy. of course you can still run a proxy if you want; tobiash does. | 16:32 |
corvus | SpamapS: here's a test run in openstack: https://object-storage-ca-ymq-1.vexxhost.net/swift/v1/86bbbcfa8ad043109d2d7af530225c72/logs_82/592582/2/check/tempest-full/a77af5a/ | 16:32 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Change project.private_key to private_secrets_key https://review.openstack.org/597302 | 16:34 |
SpamapS | corvus: sweet! | 16:38 |
corvus | Shrews: https://hub.docker.com/r/zuul/ has nodepool images now | 16:49 |
openstackgerrit | Clark Boylan proposed openstack-infra/zuul master: The argparse type of node-hold-expiration is int https://review.openstack.org/597592 | 16:53 |
clarkb | corvus: Shrews https://review.openstack.org/597592 fix for the node expiry type issue in nodepool | 16:53 |
clarkb | I didn't write a test because our tests seem to happen a level below the argparsing layer | 16:53 |
clarkb | and I don't feel like making an entirely new layer of tests for argparse for this small thing >_> | 16:54 |
corvus | clarkb: wfm | 16:55 |
corvus | clarkb: though we could add the coercion at the lower layer so we're not relying on argparse | 16:55 |
clarkb | corvus: maybe do that in nodepool so that it santizes its own inputs? | 17:02 |
*** neilsun has quit IRC | 17:04 | |
Shrews | corvus: yeah, i saw | 17:05 |
*** snapiri has quit IRC | 17:05 | |
clarkb | I'm working ont he coercion in nodepool patch, this one I am writing tests for | 17:17 |
openstackgerrit | Clark Boylan proposed openstack-infra/nodepool master: Force node hold expiration to integer type https://review.openstack.org/597609 | 17:24 |
clarkb | corvus: ^ nodepool being defensive | 17:24 |
corvus | clarkb: belts _and_ suspenders | 17:30 |
*** bhavikdbavishi has joined #zuul | 17:38 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add private key storage migration https://review.openstack.org/592213 | 17:43 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Change project.private_key to private_secrets_key https://review.openstack.org/597302 | 17:43 |
clarkb | mnaser: corvus it appears to be working now | 17:44 |
openstackgerrit | Merged openstack-infra/zuul master: The argparse type of node-hold-expiration is int https://review.openstack.org/597592 | 17:58 |
*** electrofelix has quit IRC | 18:11 | |
*** elyezer has quit IRC | 18:44 | |
*** bhavikdbavishi has quit IRC | 18:47 | |
openstackgerrit | Merged openstack-infra/nodepool master: Force node hold expiration to integer type https://review.openstack.org/597609 | 18:51 |
*** elyezer has joined #zuul | 18:57 | |
*** pcaruana has quit IRC | 19:09 | |
dmsimard | How would I troubleshoot a lock acquisition timeout from nodepool ? trace: http://paste.openstack.org/raw/729078/ | 19:24 |
dmsimard | Nothing in logs, services (and even the server) was restarted | 19:26 |
dmsimard | That's when trying to delete a node fwiw | 19:28 |
openstackgerrit | David Moreau Simard proposed openstack-infra/nodepool master: WIP: Implement an Amazon EC2 driver https://review.openstack.org/535558 | 19:41 |
SpamapS | dmsimard: how's your zookeper doing? | 19:41 |
SpamapS | dmsimard: I had a lot of weird lock timeouts and stuff in nodepool until I put zk on its own dedicated VM | 19:41 |
*** mgagne has joined #zuul | 20:21 | |
*** hwoarang has quit IRC | 20:39 | |
*** hasharAway has quit IRC | 20:54 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Create per-project ssh keys https://review.openstack.org/597711 | 21:15 |
*** jimi|ansible has quit IRC | 21:15 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Create per-project ssh keys https://review.openstack.org/597711 | 22:14 |
*** threestrands has joined #zuul | 22:19 | |
*** threestrands has quit IRC | 22:19 | |
*** threestrands has joined #zuul | 22:22 | |
*** jimi|ansible has joined #zuul | 22:46 | |
*** rlandy is now known as rlandy|bbl | 22:57 | |
*** elyezer has quit IRC | 22:57 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Provide per-project ssh key to executor https://review.openstack.org/597727 | 23:01 |
*** elyezer has joined #zuul | 23:09 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!