| openstackgerrit | Merged openstack-infra/zuul-jobs master: lay down gentoo use file for openvswitch https://review.openstack.org/604655 | 01:18 |
|---|---|---|
| openstackgerrit | Matthew Thode proposed openstack-infra/zuul-jobs master: create the pacage.use file... https://review.openstack.org/604671 | 02:20 |
| AJaeger | tobiash: want to remove your -2 from https://review.openstack.org/#/c/578238/ ? | 04:09 |
| *** _ari_ has quit IRC | 04:11 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: executor: add support for generic build resource https://review.openstack.org/570668 | 04:29 |
| *** spsurya has joined #zuul | 05:02 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/nodepool master: Implement a Kubernetes driver https://review.openstack.org/535557 | 05:09 |
| tobiash | AJaeger: of course | 05:20 |
| tobiash | +2 now | 05:20 |
| openstackgerrit | Matthew Thode proposed openstack-infra/zuul-jobs master: use find instead of ls to list interfaces https://review.openstack.org/604677 | 05:22 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Support node caching in the nodeIterator https://review.openstack.org/604648 | 05:25 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Use node cache in quota calculations https://review.openstack.org/604649 | 05:25 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Cache iterations over ready nodes https://review.openstack.org/604650 | 05:25 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Use cache when counting poolnodes https://review.openstack.org/604651 | 05:25 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Use cache when deleting oldest unused nodes https://review.openstack.org/604652 | 05:25 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Fix race in test_launchNode_delete_error https://review.openstack.org/604678 | 05:25 |
| *** jimi|ansible has joined #zuul | 05:29 | |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Support node caching in the nodeIterator https://review.openstack.org/604648 | 05:40 |
| *** quique|rover|off is now known as quiquell|rover | 05:45 | |
| *** jiapei has joined #zuul | 05:46 | |
| *** pcaruana has joined #zuul | 06:05 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add labels page https://review.openstack.org/604682 | 06:13 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add nodes page https://review.openstack.org/604683 | 06:13 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Support node caching in the nodeIterator https://review.openstack.org/604648 | 06:31 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Use node cache in quota calculations https://review.openstack.org/604649 | 06:31 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Cache iterations over ready nodes https://review.openstack.org/604650 | 06:31 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Use cache when counting poolnodes https://review.openstack.org/604651 | 06:31 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Use cache when deleting oldest unused nodes https://review.openstack.org/604652 | 06:31 |
| openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: Use zuul-sphinx for configuration layout https://review.openstack.org/604274 | 06:33 |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: log-inventory: remove inventory_file usage https://review.openstack.org/578238 | 06:34 |
| openstackgerrit | Matthew Thode proposed openstack-infra/zuul-jobs master: Add Gentoo iptables handling https://review.openstack.org/604688 | 06:38 |
| *** quiquell|rover is now known as quique|rover|brb | 06:58 | |
| openstackgerrit | Matthew Thode proposed openstack-infra/zuul-jobs master: use find instead of ls to list interfaces https://review.openstack.org/604677 | 06:58 |
| *** dkehn_ has joined #zuul | 07:11 | |
| *** dkehn has quit IRC | 07:12 | |
| *** dkehn_ is now known as dkehn | 07:12 | |
| openstackgerrit | Merged openstack-infra/zuul-jobs master: create the pacage.use file... https://review.openstack.org/604671 | 07:17 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Cache node iterations of DeletedNodeWorker https://review.openstack.org/604691 | 07:23 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: Cache node iterations in cleanup workers https://review.openstack.org/604691 | 07:29 |
| *** quique|rover|brb is now known as quiquell|rover | 07:30 | |
| *** jpena|off is now known as jpena | 07:49 | |
| tobiash | tristanC: is the decision to use the path router in the webui rewrite fixed? | 08:04 |
| tristanC | tobiash: what do you mean? | 08:05 |
| tristanC | tobiash: the react ui is using the browserrouter already, not the hashrouter | 08:05 |
| tobiash | tristanC: ah, I missed the wrong word, browserrouter is path based right? | 08:05 |
| tristanC | tobiash: and to make the html5 links work, you need https://review.openstack.org/604251 | 08:05 |
| tristanC | tobiash: that is correct, links will be "https://zuul.openstack.org/job/devstack" | 08:06 |
| *** hashar has joined #zuul | 08:06 | |
| tobiash | tristanC: that's why I'm asking because if I understood that right, the browserrouter requires rewrite rules to make deep links work | 08:06 |
| tobiash | while the hashrouter wouldn't | 08:07 |
| tobiash | (but has uglier urls) | 08:07 |
| tristanC | tobiash: that is also correct | 08:07 |
| tristanC | deep link work if you start from '/', the ui use 'history.pushState()' which updates the url without doing http request | 08:07 |
| tristanC | but then, if you copy-paste the link, they won't work without the rewrite proposed in 604251 | 08:08 |
| tobiash | tristanC: is the ugly url the only drawback of the hashrouter? | 08:08 |
| tobiash | because that makes me think if the hashrouter would be the more general solution | 08:08 |
| tristanC | tobiash: afaict yes, you should be able to just s/BrowserRouter/HashRouter/ if you prefer that | 08:09 |
| tristanC | tobiash: i would also prefer if hashrouter would be the more general solution, as it simplifies sub-url setup | 08:09 |
| tobiash | well I can deal with that, but I think about zfs and smaller deployments that might not have an apache in front | 08:10 |
| tristanC | tobiash: well i also fixed zuul-web to implement the rewrite rules, see https://review.openstack.org/#/c/591604/25/zuul/web/__init__.py | 08:10 |
| tobiash | ah ok, so deployment without reverse-proxy will work | 08:11 |
| tobiash | deployment with reverse proxy will need to change rewrite rules? | 08:11 |
| tristanC | tobiash: yes, as documented in https://review.openstack.org/#/c/591604/25/doc/source/admin/installation.rst | 08:12 |
| tobiash | tristanC: thanks, I wasn't that far with the review yet ;) | 08:12 |
| tristanC | tobiash: heh, no worries :) | 08:13 |
| tristanC | tobiash: i also wrote a blog post about React that may be useful, it's: https://www.softwarefactory-project.io/react-for-python-developers.html | 08:13 |
| tobiash | cool, thx | 08:14 |
| openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: Doc: executor operations - explain jobs will be restarted at restart https://review.openstack.org/603136 | 08:18 |
| openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: Doc: executor operations - explain jobs will be restarted at restart https://review.openstack.org/603136 | 08:20 |
| *** openstackgerrit has quit IRC | 08:22 | |
| *** ianychoi_ has joined #zuul | 09:30 | |
| *** ianychoi has quit IRC | 09:34 | |
| *** chkumar|ruck has joined #zuul | 10:07 | |
| *** ssbarnea|bkp has joined #zuul | 10:23 | |
| *** jiapei has quit IRC | 10:23 | |
| tobiash | tristanC: when I install zuul it doesn't copy the static css and js files to the destination | 10:52 |
| tobiash | tristanC: I'm installing with 'python3 setup.py install' and it does a yarn build and the generated files are in the source dir under /zuul/web/static/static/ which doesn't seem to be copied during installation | 10:54 |
| tristanC | tobiash: zuul/web/static/static is expected, is the zuul/web/static/index.html generated? | 11:02 |
| tobiash | tristanC: zuul/web/static/index.html is generated and also installed | 11:02 |
| tristanC | but not the static sub directory? | 11:02 |
| tobiash | the second static dir is missing from the installation | 11:02 |
| tobiash | tristanC: what's also really strange is that if I curl /index.html I get an empty response, if I curl /foo then I get the expected generated index.html | 11:05 |
| *** jpena is now known as jpena|lunch | 11:10 | |
| tristanC | tobiash: hum, good catch, not sure how to instruct pbr to copy sub-directories too... | 11:26 |
| tristanC | tobiash: perhaps the static files needs to be moved to package-data, e.g. in /usr/share, and makes zuul-web uses pkg_resources as root location | 11:27 |
| tobiash | tristanC: the easiest way is probably to put an __init__.py file in there | 11:27 |
| tobiash | but that's probably a hack ;) | 11:27 |
| *** dkehn has quit IRC | 11:37 | |
| *** quiquell|rover is now known as quique|rover|brb | 11:40 | |
| *** dkehn has joined #zuul | 11:43 | |
| *** quique|rover|brb is now known as quiquell|rover | 11:45 | |
| *** samccann has joined #zuul | 11:54 | |
| *** _ari_ has joined #zuul | 11:56 | |
| tristanC | tobiash: adding the __init__.py file is not enough, for some reason, the rest of the sub directory content doesn't get installed... | 11:56 |
| tristanC | and using package-data or data-files in setup.cfg doesn't seems to work with directory :( | 11:57 |
| tobiash | tristanC: did you try with globbing? | 12:01 |
| tobiash | https://docs.openstack.org/pbr/latest/user/using.html#files | 12:01 |
| tobiash | the docs say that with globbing you can copy files and directories | 12:01 |
| *** jpena|lunch is now known as jpena | 12:14 | |
| mordred | tobiash, tristanC: morning! it *should* work, so that's sadmaking. you tried putting an __init__.py in there already? | 12:16 |
| mordred | tristanC: try putting 'include zuul/web/static/static/*' in MANIFEST.in | 12:17 |
| tobiash | mordred: is that manufest not recursive? | 12:17 |
| *** rfolco has joined #zuul | 12:18 | |
| mordred | tobiash: I thought it was - but maybe not? | 12:20 |
| mordred | tobiash: the story with additional files and setuptools is always a pile of black magic | 12:20 |
| tobiash | mordred: probably not, because zuul/web/static is in the installation, but zuul/web/static/static not | 12:20 |
| tristanC | mordred: indeed, MANIFEST.in does explain why zuul/web/static was created in the first place | 12:23 |
| *** openstackgerrit has joined #zuul | 12:25 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: rewrite interface in react https://review.openstack.org/591604 | 12:25 |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: rewrite interface in react https://review.openstack.org/591604 | 12:33 |
| tristanC | tobiash: last 2 PS should have fixed static file installation and zuul-web serving of real file paths | 12:33 |
| tobiash | tristanC: doesn't cherrypy.lib.static.staticdir already handle the file and we just need to return true in that case? | 12:34 |
| tristanC | tobiash: it seems like we need to return serve_file(), return true raises a 500 | 12:36 |
| tobiash | tristanC: ah, you're right, just tried that and got 500 | 12:37 |
| mordred | tristanC: sweet, the MANIFEST line worked then? | 12:38 |
| tobiash | checking in a bit | 12:40 |
| tristanC | mordred: seems like it yes | 12:46 |
| mordred | tristanC: nice blog post on react - thanks for writing that | 12:46 |
| tristanC | mordred: thanks! you're welcome :-) | 12:47 |
| mordred | tristanC: re: "It installs command line tools in node_modules/.bin/." - don't know if you found this yet, but if you want to run an executable from that dir easily, you can use npx - so like, 'npx webpack' will run the webpack command from node_modules/.bin | 12:47 |
| *** jiapei has joined #zuul | 12:47 | |
| mordred | (I only recently discovered that - I've been doing ./node_modules/.bin/foo when I wanted to run something instlaled locally :) ) | 12:48 |
| tristanC | "npx - execute npm package binaries" *facepalm*, i didn't knew that... | 12:49 |
| tristanC | i've been doing export PATH=${PATH}:$(pwd)/node_modules/.bin; and rely on the shell to execute binaries... | 12:49 |
| mordred | yup - I've done that one too | 12:51 |
| tobiash | tristanC, mordred: I've rebuilt the zuul-web container and now it includes the static stuff | 12:52 |
| tobiash | trying the serving in a bit | 12:52 |
| mordred | \o/ | 12:52 |
| tobiash | tristanC, mordred: it works :) | 13:03 |
| tobiash | the fonts of the top bar are a bit small | 13:04 |
| *** bbayszczak has joined #zuul | 13:42 | |
| bbayszczak | pabelanger: Hi, the review concerning the zuul_return behavior when using it multiple times has been +2 (https://review.openstack.org/#/c/602054), what's the next step ? Thanks ! | 13:46 |
| pabelanger | bbayszczak: I'll review shortly, just finishing up a meeting now | 13:51 |
| bbayszczak | pabelanger: ok thanks ! | 13:52 |
| *** annabelleB has joined #zuul | 14:01 | |
| *** samccann has quit IRC | 14:05 | |
| *** samccann has joined #zuul | 14:06 | |
| *** chkumar|ruck has quit IRC | 14:08 | |
| *** bbayszczak has quit IRC | 14:13 | |
| *** chandankumar has joined #zuul | 14:14 | |
| *** chandankumar is now known as chkumar|ruck | 14:15 | |
| *** quiquell|rover is now known as quique|rover|off | 14:15 | |
| mordred | pabelanger: that lgtm - something about it triggers my "I'd like to make sure corvus looks at it" sense just to make sure | 14:28 |
| *** annabelleB has quit IRC | 14:28 | |
| pabelanger | mordred: Yah, agree | 14:30 |
| pabelanger | with github driver, if I added a require label to for gate pipeline, then PR is enqueued into gate, but then remove the label, zuul doesn't remove the change from gate and the PR was merged | 14:38 |
| tobiash | pabelanger: that's because it's already triggered and github won't prevent merging because of a missing label | 14:39 |
| pabelanger | tobiash: yah, unexpected difference with gerrit | 14:40 |
| tobiash | pabelanger: does it dequeue with gerrit? | 14:41 |
| tobiash | Or does just gerrit prevent the merge then? | 14:41 |
| mordred | gerrit prevents the merge | 14:41 |
| pabelanger | sorry, not dequeue, what mordred said | 14:42 |
| *** annabelleB has joined #zuul | 14:43 | |
| tobiash | pabelanger: you could write a github app that reacts on '/approved' comments and sets an 'approved' build status | 14:44 |
| tobiash | then you could require that and if you would '/decline' and the app removes that status you could prevent the merge | 14:44 |
| corvus | tobiash: you could call that app "zuul" :) | 14:45 |
| corvus | (a pipeline could do that pretty easily) | 14:45 |
| pabelanger | so, pipeline after gate to recheck labels? then the merge? | 14:46 |
| corvus | so in github, you can't require a label with branch protection? | 14:49 |
| pabelanger | checking docs, as I don't know | 14:51 |
| pabelanger | I only see status checks, not labels | 14:53 |
| corvus | the thing about having zuul dequeue based on that is that, for example, openstack's gate pipeline removes a required label, so if we implemented that, the gate pipeline would immediately dequeue anything that went into it. so we'd have to make it optional. | 14:57 |
| *** chkumar|ruck is now known as chkumar|off | 15:02 | |
| corvus | i'm going to be catching up on email and paperwork for a bit... i'll try to catch up with what's been going on soon. :) | 15:03 |
| *** bbayszczak has joined #zuul | 15:17 | |
| *** jesusaur has quit IRC | 15:26 | |
| *** jimi|ansible has quit IRC | 15:26 | |
| *** jesusaur has joined #zuul | 15:32 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Use = not : for ini settings in pypirc https://review.openstack.org/604820 | 15:39 |
| tobiash | corvus: welcome back :) | 15:55 |
| tobiash | corvus: that would work although a bit expensive | 15:56 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool master: Do Not Merge Testing glean + nodepool integration https://review.openstack.org/604826 | 15:56 |
| *** bbayszczak has quit IRC | 16:06 | |
| *** jiapei has quit IRC | 16:43 | |
| *** dkehn has quit IRC | 16:49 | |
| *** hashar is now known as hasharDinner | 16:55 | |
| openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: WIP - Pagure driver https://review.openstack.org/604404 | 16:55 |
| clarkb | https://review.openstack.org/#/c/604248/2 is a change that would be useful for the openstack team to support a cloud that changed some networking related stuff (and we need to have greater control over behavior via config passed to nodes from nodepool) | 16:56 |
| clarkb | if anyone has time to review that it would be much appreciated | 16:56 |
| Shrews | clarkb: i' | 16:58 |
| Shrews | i'll take a look | 16:58 |
| clarkb | thank you!@ | 16:58 |
| clarkb | I think others have asked for this feature in the past too so gnerally useful | 16:58 |
| clarkb | was that spamaps or tobiash ? | 16:58 |
| tobiash | clarkb: that probably was SpamapS | 16:58 |
| tobiash | looking too btw | 16:59 |
| *** dkehn has joined #zuul | 16:59 | |
| Shrews | clarkb: lgtm. could we add a release note in a follow up? | 17:09 |
| clarkb | Shrews: ++ | 17:09 |
| *** sshnaidm has joined #zuul | 17:11 | |
| *** annabelleB has quit IRC | 17:12 | |
| *** annabelleB has joined #zuul | 17:13 | |
| *** sshnaidm is now known as sshnaidm|pto | 17:13 | |
| *** sshnaidm|pto has quit IRC | 17:20 | |
| *** jpena is now known as jpena|off | 17:21 | |
| openstackgerrit | Merged openstack-infra/nodepool master: Add instance boot properties https://review.openstack.org/604248 | 17:23 |
| *** annabelleB has quit IRC | 17:32 | |
| *** sshnaidm|pto has joined #zuul | 17:33 | |
| *** annabelleB has joined #zuul | 17:40 | |
| tobiash | Shrews, corvus: tested znode caching in prod: https://paste.pics/fbe409084b1e084bc725820d43aa2c50 | 17:46 |
| tobiash | both peaks did the same requests, the first is without znode caching, the second with znode caching | 17:47 |
| tobiash | this graphs the open node requests reported by zuul | 17:48 |
| tobiash | and single launcher with all requests served by a single provider | 17:50 |
| openstackgerrit | Monty Taylor proposed openstack-infra/zuul-jobs master: Block twine 1.12.0 when we install it https://review.openstack.org/604862 | 17:57 |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool master: Add release note for instance-properties config https://review.openstack.org/604863 | 18:10 |
| clarkb | Shrews: ^ that is the release note followup | 18:10 |
| corvus | tobiash: i'm excited about the words "znode" and "caching". it's definitely on my radar once i get caught up. :) | 18:15 |
| tobiash | corvus: that was my yesterday's evening project with some finetuning today :) | 18:16 |
| *** samccann_ has joined #zuul | 18:36 | |
| *** sshnaidm|pto has quit IRC | 18:36 | |
| *** samccann has quit IRC | 18:36 | |
| *** dkehn has quit IRC | 18:39 | |
| *** dkehn has joined #zuul | 18:47 | |
| *** ianychoi_ is now known as ianychoi | 18:54 | |
| *** panda has quit IRC | 18:56 | |
| *** samccann_ has quit IRC | 19:08 | |
| *** pcaruana has quit IRC | 19:17 | |
| *** annabelleB has quit IRC | 19:31 | |
| *** dkehn has quit IRC | 19:35 | |
| *** annabelleB has joined #zuul | 19:37 | |
| *** panda has joined #zuul | 19:37 | |
| *** dkehn has joined #zuul | 19:57 | |
| *** jimi|ansible has joined #zuul | 20:19 | |
| *** sshnaidm|pto has joined #zuul | 20:34 | |
| *** samccann has joined #zuul | 20:40 | |
| *** samccann has quit IRC | 20:53 | |
| *** annabelleB has quit IRC | 21:01 | |
| *** annabelleB has joined #zuul | 21:03 | |
| *** sshnaidm|pto has quit IRC | 21:10 | |
| openstackgerrit | Merged openstack-infra/nodepool master: Add release note for instance-properties config https://review.openstack.org/604863 | 21:23 |
| *** annabelleB has quit IRC | 21:34 | |
| *** sshnaidm|pto has joined #zuul | 21:40 | |
| ianw | hey, could i ask for a couple of eyes on moving nodepool config documenation to zuul-sphinx (https://review.openstack.org/604274) and the associated zuul-sphinx change (https://review.openstack.org/604267) | 21:45 |
| ianw | it's one i'd prefer to not keep rebasing if we're generally happy with it | 21:45 |
| *** AJaeger_ has joined #zuul | 22:10 | |
| *** AJaeger has quit IRC | 22:11 | |
| corvus | ianw: cool! i left a comment on a small but important detail on the sphinx change | 22:11 |
| ianw | corvus: ok, i did think it looked ok in italics, but not fussed. did you write all zuul-sphinx? | 22:15 |
| corvus | ianw: we did a big push to standardize things and wrote a style guide which touches on it: https://zuul-ci.org/docs/zuul/developer/docs.html#literal-values | 22:16 |
| openstackgerrit | Ian Wienand proposed openstack-infra/zuul-sphinx master: Add example and type options to attributes https://review.openstack.org/604267 | 22:17 |
| corvus | i think an example value would qualify as us "instruct[ing] a user to type a specific string into a configuration file" so that probably applies | 22:17 |
| ianw | yep, cool | 22:18 |
| ianw | i spent a bit of time trying to get zuul-sphinx to create an "contents" style overview of the options | 22:18 |
| corvus | oh that sounds useful (especially if you could ask for a subgroup of options) | 22:19 |
| ianw | yeah i started hacking around the "doctree-resolved" event and then traversing the desc type nodes, but it felt like square peg in round hole | 22:22 |
| openstackgerrit | Ian Wienand proposed openstack-infra/zuul-sphinx master: Add example and type options to attributes https://review.openstack.org/604267 | 22:26 |
| corvus | ianw: there's a data structure with all the objects that's used by the resolve_xref method; not sure if that would be helpful | 22:29 |
| *** panda is now known as panda|off | 22:38 | |
| *** mmedvede_ has joined #zuul | 23:00 | |
| *** jimi|ansible has quit IRC | 23:00 | |
| *** _ari_ has quit IRC | 23:00 | |
| *** Diabelko has quit IRC | 23:00 | |
| *** jlvillal has quit IRC | 23:00 | |
| *** fbouliane has quit IRC | 23:00 | |
| *** mmedvede has quit IRC | 23:00 | |
| *** mmedvede_ is now known as mmedvede | 23:00 | |
| *** sshnaidm|pto has quit IRC | 23:04 | |
| *** hasharDinner has quit IRC | 23:05 | |
| *** Diabelko has joined #zuul | 23:08 | |
| openstackgerrit | Clark Boylan proposed openstack-infra/nodepool master: Do Not Merge Testing glean + nodepool integration https://review.openstack.org/604826 | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!