Friday, 2018-12-07

*** rlandy has quit IRC00:11
tristanCmordred: thanks, note that i'm still learning how redux-thunk work...00:53
tristanCi mean, the code is very expressive at the moment, i'm not entirely sure how the duplicated logic can be factored00:53
tristanCit's also that the api are not very consistent, e.g. the /info endpoint returns an {info: object}, and the /status endpoint returns an object directly00:55
*** dkehn has quit IRC01:51
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation  https://review.openstack.org/53554102:49
*** bhavikdbavishi has joined #zuul03:02
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation  https://review.openstack.org/53554103:20
*** neilsun has joined #zuul04:14
*** bjackman has joined #zuul04:19
*** bhavikdbavishi has quit IRC06:18
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation  https://review.openstack.org/53554106:52
openstackgerritQuique Llorente proposed openstack-infra/zuul master: Add default value for relative_priority  https://review.openstack.org/62217507:01
openstackgerritMerged openstack-infra/zuul master: web: refactor status page to use a reducer  https://review.openstack.org/62139507:04
openstackgerritMerged openstack-infra/zuul master: web: refactor jobs page to use a reducer  https://review.openstack.org/62139607:06
tobiashcorvus, clarkb: I think 622175 is needed to not break zuul without using relative prio07:36
*** gtema has joined #zuul08:00
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Use combined status for Github status checks  https://review.openstack.org/62341708:22
tobiashcorvus, clarkb, SpamapS: fix for github status checks handling in the gate ^08:23
*** jpena|off is now known as jpena08:43
*** electrofelix has joined #zuul10:02
*** bhavikdbavishi has joined #zuul10:27
*** sshnaidm|afk is now known as sshnaidm|off11:33
*** gtema has quit IRC11:57
*** goern has quit IRC12:22
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Add timer for starting_builds  https://review.openstack.org/62346812:24
*** gtema has joined #zuul12:36
*** tobiash has quit IRC12:38
pandawhat's the use case for zuul container image built with pbrx ?12:40
*** jpena is now known as jpena|lunch12:40
*** bhavikdbavishi has quit IRC12:41
*** bjackman has quit IRC12:44
*** njohnston has quit IRC12:49
*** tobiash has joined #zuul12:50
*** bjackman has joined #zuul12:52
*** tobiash_ has joined #zuul12:52
*** bjackman has quit IRC12:58
*** tobiash has quit IRC13:02
*** tobiash has joined #zuul13:02
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Add timer for starting_builds  https://review.openstack.org/62346813:03
*** chandan_kumar is now known as chkumar|off13:12
pabelangerpanda: today they are used by zuul quickstart example13:18
*** EmilienM is now known as EvilienM13:22
*** neilsun has quit IRC13:36
*** jpena|lunch is now known as jpena13:37
*** sshnaidm|off has quit IRC13:37
*** rlandy has joined #zuul13:44
*** tobiash has left #zuul13:44
*** tobiash_ is now known as tobiash13:45
openstackgerritPaul Belanger proposed openstack-infra/zuul master: Add nodepool.host_id variable to inventory file  https://review.openstack.org/62349614:07
pabelangerfungi: clarkb: corvus: tobiash: ^ is zuul change to add host_id into inventory files14:08
tobiashpabelanger: cool, will look at it later today14:10
openstackgerritMerged openstack-infra/nodepool master: Include host_id for openstack provider  https://review.openstack.org/62310714:10
mordredpanda: yeah - but in the future we're looking at using to run openstack's zuul - so we expect them to be good candidates for that14:23
*** pwhalen has joined #zuul14:23
mordredtristanC: zomg. I love your openapi patch14:27
mordredtristanC: it doesn;t' seem to work on the multi-tenant job for me ... is that just an issue with the job? (like, I think maybe we need to add a symlink or something)14:27
*** pwhalen has quit IRC14:30
*** pwhalen has joined #zuul14:33
mordredtristanC: oh - or hrm. I have no idea why it wouldn't work14:35
*** sshnaidm has joined #zuul14:52
*** sshnaidm has quit IRC15:03
*** sshnaidm has joined #zuul15:29
*** sshnaidm is now known as sshnaidm|off15:42
tristanCmordred: indeed, the route is special because it's for both white-label and multi-tenant, but without tenant prefix... next ps should fix that15:46
mordredcool15:46
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation  https://review.openstack.org/53554115:46
tristanCmordred: glad you like the idea. Now the important missing piece is a functional test of the swagger file, would be cool to generate a client in tox test and validate it works as excepted15:48
tristanCuntil then, it's still a convenient documentations of the rest api :)15:48
clarkbtobiash: ok, pulling up those changes for top of my review list16:12
rlandyhello ... it is possible to commit WIP patches to upstream gerrit and override the .zuul.d/zuul.yaml definitions as not to trigger the tests in upstream zuul?16:17
clarkbrlandy: yes, as long as the tests are in untrusted config this will work16:19
rlandyclarkb: ok - how I go about doing this? short of manually editing the .zuul.d files?16:20
clarkbthat is how you do it16:20
rlandyclarkb: hmmm ... I was looking for a more general solution - because the manual edit approach would require each developer to know where exactly the test list was defined to edit the correct zuul.d file16:22
rlandywe are trying to get developers out of the practice of using upstream zuul as their local test env16:23
clarkbah I see, so this is more of general workflow and not a one off?16:23
rlandywe are testing providing a local zuul/gerrit16:23
rlandygetting devs to work there until the patch is ready16:23
rlandyso that we clear up the upstream queues16:24
clarkbin that case you could tweak the pipeline definitions such that they would only trigger say after the first reviewer gives a positive review16:24
clarkbin general though zuul wants to run the tests16:24
rlandyclarkb: as an alternative - I thought about editing the [remote "gerrit"] definitions of cloned upstream repos to point to the local gerrit16:24
openstackgerritMerged openstack-infra/zuul master: Add default value for relative_priority  https://review.openstack.org/62217516:25
rlandycommit there while under dev and change back to the upstream gerrit when ready16:25
rlandythat would require my adding the usptream repo to the local gerrit which may be a crazy idea16:25
pandarlandy: I don't think it's to much to ask a dev that if he wonts to tests things locally he should push to a different repo16:28
pandarlandy: the local git copy may have both gerrit and gerrit local16:29
rlandyclarkb: lastly, wrt yesterday's discussion re: the static driver and private_ipv4, this review worked for me https://review.openstack.org/#/c/623294/16:29
pandayou do your iteration in gerrit-local, then when you're ready to test in openstack-infra, git review to the upstream gerrit16:30
clarkbin general my preference would be for devs to spend some cycles fixing the issues with their testing upstream16:30
clarkbrather than doing their best to avoid the testing16:30
rlandypanda: adding the upstream repo to local gerrit is not the problem ... we need to think how this repo will interact with the upstream repo in testing16:30
clarkbthe root of the problem there is that zuul is being asked to do the impossible, gate a bunch of code for broken software16:31
clarkbthe solution to that is s/broken/working/ then it lands in the realm of possibility16:31
openstackgerritMerged openstack-infra/zuul master: web: refactor job page to use a reducer  https://review.openstack.org/62315616:32
rlandycorrect ... we only want working code (or close to working) reviews to land in upstream zuul16:33
clarkbrlandy: but then upstream zuul loses all of the review data for how the software evolved16:33
clarkbI don't think that is what we actually want. The problem from where I'm sitting is the tests don't work reliably and I'm the only person digging in and actually debugging why16:33
clarkb(I know thats not true, but it feels that way because the tests nodes are crashing and actualyl rebooting and I'm the only one that notices?)16:34
rlandyhmmm ... well that's another problem I wasn't really considering at this decision - that the test are unreliable16:35
openstackgerritMerged openstack-infra/zuul master: web: refactor tenants page to use a reducer  https://review.openstack.org/62315716:35
* rlandy rethinks this a bit ...416:35
clarkbassuming this is openstack being the upstream (the test node crashes were a centos + nested virt issue that tripleo was hitting)16:38
clarkbin general though there is a bunch of test instablity in openstacks upstream testing. Some of that is the hosting for sure (which we continue to work with the cloud provider to address). But some of it is the software and its tests not working16:39
*** bhavikdbavishi has joined #zuul16:39
clarkband I think any optomization that doesn't start with fix the software and tests is misplaced16:39
clarkbbecause we can't accurately measure anything until that is done16:39
clarkbcorvus: mordred: it seems that while zuul is back to swapping near where it was yesterday it took much longer to get to that point17:02
clarkbimplying that the json fix was an improvement?17:02
mordredclarkb: perhaps so? it should reduce the time when different ansibles are high-memory simultaneously17:04
clarkbya17:04
mordredalthough it obviously doesn't avoid the whole log getting read in to memory17:04
clarkbrlandy: left a comment on https://review.openstack.org/#/c/623294/4 my ansible isn't strong enough to know if one is preferred over the other.17:16
rlandythanks - will checck it out17:18
*** rlandy is now known as rlandy|brb17:23
*** rlandy|brb is now known as rlandy17:41
*** bhavikdbavishi has quit IRC17:48
*** jpena is now known as jpena|off17:50
openstackgerritMerged openstack-infra/zuul master: Add nodepool.host_id variable to inventory file  https://review.openstack.org/62349618:21
*** gtema has quit IRC18:49
*** sean-k-mooney has joined #zuul19:00
sean-k-mooneyo/ quick question is there any docs on how to use zuul v3 to set up a third party ci.19:08
sean-k-mooneyi deployed it about 8 months ago but got stuck on configuing the base jobs to uploads logs after the run but im going to try and set it up again this weekend19:09
*** electrofelix has quit IRC19:11
tobiashsean-k-mooney: there is now a docker based quick start tutorial you want to try out: https://zuul-ci.org/docs/zuul/admin/quick-start.html19:31
tobiashsean-k-mooney: but I'm not familiar with third party ci for openstack19:32
sean-k-mooneyya i saw. the node i was going to install zull on has k8s running so not sure how well that will work out19:32
tobiashcorvus: responded on 62346819:33
tobiashsean-k-mooney: note that the zuul-executor needs to run privileged if you run on k8s19:33
sean-k-mooneyya that is fine. this is just for a personal ci so not an issue19:34
sean-k-mooneyhttps://zuul-ci.org/docs/zuul/admin/quick-start.html#configure-a-base-job19:34
sean-k-mooneywas not written last time i tried so hopefully that ill have everythign i was missing19:34
sean-k-mooneywhen i tried a few months ago i got zuul/nodepool working and runnign the tox jobs as a smoke test bug never figured out how to upload the logs out of the vms19:35
tobiashcorvus: if you have doubts about the usefulness of this metric I can also prototype this just in my deployment to verify if it's useful or not. Waiting is probably easier than adding and removing again if it turns out that this is not useful at all.19:37
corvustobiash: removing isn't that hard :)19:38
tobiashok :)19:38
*** sean-k-mooney has quit IRC20:20
*** sean-k-mooney has joined #zuul20:28
*** rlandy has quit IRC21:08
SpamapSso... if I was to submit a slack notify role21:34
SpamapSand set up a slack just for testing it21:35
SpamapSand submit a working test with an encrypted token for testing it..21:35
SpamapSwould that be a good thing?21:35
SpamapSand if so.. do we need to like, make sure others have admin rights to said slack?21:35
SpamapSHm.. seems zuul-jobs has no project section. I assume that will need to be set up in project-config ?21:55
SpamapStobiash: does the executor still have to run privileged if you run under a modern kernel on k8s?22:12
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/zuul-jobs master: Add a slack-notify role  https://review.openstack.org/62359422:13
SpamapSWell there it is22:13
* SpamapS has done his good zuul deed for the day22:13
*** dmellado has quit IRC22:22
*** gouthamr has quit IRC22:23
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Consider shared changes queues for relative_priority  https://review.openstack.org/62359522:28
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Consider shared changes queues for relative_priority  https://review.openstack.org/62359522:30
*** gouthamr has joined #zuul23:06
*** dmellado has joined #zuul23:11
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Consider shared changes queues for relative_priority  https://review.openstack.org/62359523:15
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Cap mypy  https://review.openstack.org/62359823:15

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!