*** rlandy has quit IRC | 00:11 | |
tristanC | mordred: thanks, note that i'm still learning how redux-thunk work... | 00:53 |
---|---|---|
tristanC | i mean, the code is very expressive at the moment, i'm not entirely sure how the duplicated logic can be factored | 00:53 |
tristanC | it's also that the api are not very consistent, e.g. the /info endpoint returns an {info: object}, and the /status endpoint returns an object directly | 00:55 |
*** dkehn has quit IRC | 01:51 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation https://review.openstack.org/535541 | 02:49 |
*** bhavikdbavishi has joined #zuul | 03:02 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation https://review.openstack.org/535541 | 03:20 |
*** neilsun has joined #zuul | 04:14 | |
*** bjackman has joined #zuul | 04:19 | |
*** bhavikdbavishi has quit IRC | 06:18 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation https://review.openstack.org/535541 | 06:52 |
openstackgerrit | Quique Llorente proposed openstack-infra/zuul master: Add default value for relative_priority https://review.openstack.org/622175 | 07:01 |
openstackgerrit | Merged openstack-infra/zuul master: web: refactor status page to use a reducer https://review.openstack.org/621395 | 07:04 |
openstackgerrit | Merged openstack-infra/zuul master: web: refactor jobs page to use a reducer https://review.openstack.org/621396 | 07:06 |
tobiash | corvus, clarkb: I think 622175 is needed to not break zuul without using relative prio | 07:36 |
*** gtema has joined #zuul | 08:00 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Use combined status for Github status checks https://review.openstack.org/623417 | 08:22 |
tobiash | corvus, clarkb, SpamapS: fix for github status checks handling in the gate ^ | 08:23 |
*** jpena|off is now known as jpena | 08:43 | |
*** electrofelix has joined #zuul | 10:02 | |
*** bhavikdbavishi has joined #zuul | 10:27 | |
*** sshnaidm|afk is now known as sshnaidm|off | 11:33 | |
*** gtema has quit IRC | 11:57 | |
*** goern has quit IRC | 12:22 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Add timer for starting_builds https://review.openstack.org/623468 | 12:24 |
*** gtema has joined #zuul | 12:36 | |
*** tobiash has quit IRC | 12:38 | |
panda | what's the use case for zuul container image built with pbrx ? | 12:40 |
*** jpena is now known as jpena|lunch | 12:40 | |
*** bhavikdbavishi has quit IRC | 12:41 | |
*** bjackman has quit IRC | 12:44 | |
*** njohnston has quit IRC | 12:49 | |
*** tobiash has joined #zuul | 12:50 | |
*** bjackman has joined #zuul | 12:52 | |
*** tobiash_ has joined #zuul | 12:52 | |
*** bjackman has quit IRC | 12:58 | |
*** tobiash has quit IRC | 13:02 | |
*** tobiash has joined #zuul | 13:02 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Add timer for starting_builds https://review.openstack.org/623468 | 13:03 |
*** chandan_kumar is now known as chkumar|off | 13:12 | |
pabelanger | panda: today they are used by zuul quickstart example | 13:18 |
*** EmilienM is now known as EvilienM | 13:22 | |
*** neilsun has quit IRC | 13:36 | |
*** jpena|lunch is now known as jpena | 13:37 | |
*** sshnaidm|off has quit IRC | 13:37 | |
*** rlandy has joined #zuul | 13:44 | |
*** tobiash has left #zuul | 13:44 | |
*** tobiash_ is now known as tobiash | 13:45 | |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Add nodepool.host_id variable to inventory file https://review.openstack.org/623496 | 14:07 |
pabelanger | fungi: clarkb: corvus: tobiash: ^ is zuul change to add host_id into inventory files | 14:08 |
tobiash | pabelanger: cool, will look at it later today | 14:10 |
openstackgerrit | Merged openstack-infra/nodepool master: Include host_id for openstack provider https://review.openstack.org/623107 | 14:10 |
mordred | panda: yeah - but in the future we're looking at using to run openstack's zuul - so we expect them to be good candidates for that | 14:23 |
*** pwhalen has joined #zuul | 14:23 | |
mordred | tristanC: zomg. I love your openapi patch | 14:27 |
mordred | tristanC: it doesn;t' seem to work on the multi-tenant job for me ... is that just an issue with the job? (like, I think maybe we need to add a symlink or something) | 14:27 |
*** pwhalen has quit IRC | 14:30 | |
*** pwhalen has joined #zuul | 14:33 | |
mordred | tristanC: oh - or hrm. I have no idea why it wouldn't work | 14:35 |
*** sshnaidm has joined #zuul | 14:52 | |
*** sshnaidm has quit IRC | 15:03 | |
*** sshnaidm has joined #zuul | 15:29 | |
*** sshnaidm is now known as sshnaidm|off | 15:42 | |
tristanC | mordred: indeed, the route is special because it's for both white-label and multi-tenant, but without tenant prefix... next ps should fix that | 15:46 |
mordred | cool | 15:46 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add OpenAPI documentation https://review.openstack.org/535541 | 15:46 |
tristanC | mordred: glad you like the idea. Now the important missing piece is a functional test of the swagger file, would be cool to generate a client in tox test and validate it works as excepted | 15:48 |
tristanC | until then, it's still a convenient documentations of the rest api :) | 15:48 |
clarkb | tobiash: ok, pulling up those changes for top of my review list | 16:12 |
rlandy | hello ... it is possible to commit WIP patches to upstream gerrit and override the .zuul.d/zuul.yaml definitions as not to trigger the tests in upstream zuul? | 16:17 |
clarkb | rlandy: yes, as long as the tests are in untrusted config this will work | 16:19 |
rlandy | clarkb: ok - how I go about doing this? short of manually editing the .zuul.d files? | 16:20 |
clarkb | that is how you do it | 16:20 |
rlandy | clarkb: hmmm ... I was looking for a more general solution - because the manual edit approach would require each developer to know where exactly the test list was defined to edit the correct zuul.d file | 16:22 |
rlandy | we are trying to get developers out of the practice of using upstream zuul as their local test env | 16:23 |
clarkb | ah I see, so this is more of general workflow and not a one off? | 16:23 |
rlandy | we are testing providing a local zuul/gerrit | 16:23 |
rlandy | getting devs to work there until the patch is ready | 16:23 |
rlandy | so that we clear up the upstream queues | 16:24 |
clarkb | in that case you could tweak the pipeline definitions such that they would only trigger say after the first reviewer gives a positive review | 16:24 |
clarkb | in general though zuul wants to run the tests | 16:24 |
rlandy | clarkb: as an alternative - I thought about editing the [remote "gerrit"] definitions of cloned upstream repos to point to the local gerrit | 16:24 |
openstackgerrit | Merged openstack-infra/zuul master: Add default value for relative_priority https://review.openstack.org/622175 | 16:25 |
rlandy | commit there while under dev and change back to the upstream gerrit when ready | 16:25 |
rlandy | that would require my adding the usptream repo to the local gerrit which may be a crazy idea | 16:25 |
panda | rlandy: I don't think it's to much to ask a dev that if he wonts to tests things locally he should push to a different repo | 16:28 |
panda | rlandy: the local git copy may have both gerrit and gerrit local | 16:29 |
rlandy | clarkb: lastly, wrt yesterday's discussion re: the static driver and private_ipv4, this review worked for me https://review.openstack.org/#/c/623294/ | 16:29 |
panda | you do your iteration in gerrit-local, then when you're ready to test in openstack-infra, git review to the upstream gerrit | 16:30 |
clarkb | in general my preference would be for devs to spend some cycles fixing the issues with their testing upstream | 16:30 |
clarkb | rather than doing their best to avoid the testing | 16:30 |
rlandy | panda: adding the upstream repo to local gerrit is not the problem ... we need to think how this repo will interact with the upstream repo in testing | 16:30 |
clarkb | the root of the problem there is that zuul is being asked to do the impossible, gate a bunch of code for broken software | 16:31 |
clarkb | the solution to that is s/broken/working/ then it lands in the realm of possibility | 16:31 |
openstackgerrit | Merged openstack-infra/zuul master: web: refactor job page to use a reducer https://review.openstack.org/623156 | 16:32 |
rlandy | correct ... we only want working code (or close to working) reviews to land in upstream zuul | 16:33 |
clarkb | rlandy: but then upstream zuul loses all of the review data for how the software evolved | 16:33 |
clarkb | I don't think that is what we actually want. The problem from where I'm sitting is the tests don't work reliably and I'm the only person digging in and actually debugging why | 16:33 |
clarkb | (I know thats not true, but it feels that way because the tests nodes are crashing and actualyl rebooting and I'm the only one that notices?) | 16:34 |
rlandy | hmmm ... well that's another problem I wasn't really considering at this decision - that the test are unreliable | 16:35 |
openstackgerrit | Merged openstack-infra/zuul master: web: refactor tenants page to use a reducer https://review.openstack.org/623157 | 16:35 |
* rlandy rethinks this a bit ...4 | 16:35 | |
clarkb | assuming this is openstack being the upstream (the test node crashes were a centos + nested virt issue that tripleo was hitting) | 16:38 |
clarkb | in general though there is a bunch of test instablity in openstacks upstream testing. Some of that is the hosting for sure (which we continue to work with the cloud provider to address). But some of it is the software and its tests not working | 16:39 |
*** bhavikdbavishi has joined #zuul | 16:39 | |
clarkb | and I think any optomization that doesn't start with fix the software and tests is misplaced | 16:39 |
clarkb | because we can't accurately measure anything until that is done | 16:39 |
clarkb | corvus: mordred: it seems that while zuul is back to swapping near where it was yesterday it took much longer to get to that point | 17:02 |
clarkb | implying that the json fix was an improvement? | 17:02 |
mordred | clarkb: perhaps so? it should reduce the time when different ansibles are high-memory simultaneously | 17:04 |
clarkb | ya | 17:04 |
mordred | although it obviously doesn't avoid the whole log getting read in to memory | 17:04 |
clarkb | rlandy: left a comment on https://review.openstack.org/#/c/623294/4 my ansible isn't strong enough to know if one is preferred over the other. | 17:16 |
rlandy | thanks - will checck it out | 17:18 |
*** rlandy is now known as rlandy|brb | 17:23 | |
*** rlandy|brb is now known as rlandy | 17:41 | |
*** bhavikdbavishi has quit IRC | 17:48 | |
*** jpena is now known as jpena|off | 17:50 | |
openstackgerrit | Merged openstack-infra/zuul master: Add nodepool.host_id variable to inventory file https://review.openstack.org/623496 | 18:21 |
*** gtema has quit IRC | 18:49 | |
*** sean-k-mooney has joined #zuul | 19:00 | |
sean-k-mooney | o/ quick question is there any docs on how to use zuul v3 to set up a third party ci. | 19:08 |
sean-k-mooney | i deployed it about 8 months ago but got stuck on configuing the base jobs to uploads logs after the run but im going to try and set it up again this weekend | 19:09 |
*** electrofelix has quit IRC | 19:11 | |
tobiash | sean-k-mooney: there is now a docker based quick start tutorial you want to try out: https://zuul-ci.org/docs/zuul/admin/quick-start.html | 19:31 |
tobiash | sean-k-mooney: but I'm not familiar with third party ci for openstack | 19:32 |
sean-k-mooney | ya i saw. the node i was going to install zull on has k8s running so not sure how well that will work out | 19:32 |
tobiash | corvus: responded on 623468 | 19:33 |
tobiash | sean-k-mooney: note that the zuul-executor needs to run privileged if you run on k8s | 19:33 |
sean-k-mooney | ya that is fine. this is just for a personal ci so not an issue | 19:34 |
sean-k-mooney | https://zuul-ci.org/docs/zuul/admin/quick-start.html#configure-a-base-job | 19:34 |
sean-k-mooney | was not written last time i tried so hopefully that ill have everythign i was missing | 19:34 |
sean-k-mooney | when i tried a few months ago i got zuul/nodepool working and runnign the tox jobs as a smoke test bug never figured out how to upload the logs out of the vms | 19:35 |
tobiash | corvus: if you have doubts about the usefulness of this metric I can also prototype this just in my deployment to verify if it's useful or not. Waiting is probably easier than adding and removing again if it turns out that this is not useful at all. | 19:37 |
corvus | tobiash: removing isn't that hard :) | 19:38 |
tobiash | ok :) | 19:38 |
*** sean-k-mooney has quit IRC | 20:20 | |
*** sean-k-mooney has joined #zuul | 20:28 | |
*** rlandy has quit IRC | 21:08 | |
SpamapS | so... if I was to submit a slack notify role | 21:34 |
SpamapS | and set up a slack just for testing it | 21:35 |
SpamapS | and submit a working test with an encrypted token for testing it.. | 21:35 |
SpamapS | would that be a good thing? | 21:35 |
SpamapS | and if so.. do we need to like, make sure others have admin rights to said slack? | 21:35 |
SpamapS | Hm.. seems zuul-jobs has no project section. I assume that will need to be set up in project-config ? | 21:55 |
SpamapS | tobiash: does the executor still have to run privileged if you run under a modern kernel on k8s? | 22:12 |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/zuul-jobs master: Add a slack-notify role https://review.openstack.org/623594 | 22:13 |
SpamapS | Well there it is | 22:13 |
* SpamapS has done his good zuul deed for the day | 22:13 | |
*** dmellado has quit IRC | 22:22 | |
*** gouthamr has quit IRC | 22:23 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Consider shared changes queues for relative_priority https://review.openstack.org/623595 | 22:28 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Consider shared changes queues for relative_priority https://review.openstack.org/623595 | 22:30 |
*** gouthamr has joined #zuul | 23:06 | |
*** dmellado has joined #zuul | 23:11 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Consider shared changes queues for relative_priority https://review.openstack.org/623595 | 23:15 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Cap mypy https://review.openstack.org/623598 | 23:15 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!