| *** rlandy|rover is now known as rlandy|rover|bbl | 00:23 | |
| clarkb | and now I've got through the ansible version spec | 00:24 |
|---|---|---|
| *** bhavikdbavishi has joined #zuul | 02:06 | |
| *** bhavikdbavishi has quit IRC | 02:09 | |
| *** bhavikdbavishi has joined #zuul | 02:20 | |
| *** rlandy|rover|bbl is now known as rlandy|rover | 02:33 | |
| dmsimard | the new stuff in the ui is genius | 02:50 |
| dmsimard | tristanC: when browsing jobs (ex: http://zuul.openstack.org/job/zuul-quick-start ).. would the next logical step be to list (recent) builds for that job or something like that ? | 02:53 |
| dmsimard | because that'd be pretty cool. | 02:53 |
| dmsimard | I know you can go the other way and filter builds by job | 02:53 |
| tristanC | dmsimard: yes sure, we could add a reducer to update the page with recents build | 02:56 |
| tristanC | dmsimard: i'd like to recursively fetch parent job to display breadcrumbs at the top too | 02:58 |
| dmsimard | the job graph doesn't provide it already ? | 02:58 |
| tristanC | dmsimard: yes, but corvus -2 the implementation... and this would be complementary, as a graph for a single job page | 02:59 |
| *** spsurya has joined #zuul | 04:22 | |
| *** bhavikdbavishi has quit IRC | 04:25 | |
| *** rfolco has quit IRC | 04:34 | |
| *** rfolco has joined #zuul | 04:34 | |
| *** rf0lc0 has joined #zuul | 04:37 | |
| *** rfolco has quit IRC | 04:39 | |
| *** rf0lc0 has quit IRC | 04:40 | |
| *** rfolco has joined #zuul | 04:41 | |
| *** bhavikdbavishi has joined #zuul | 04:44 | |
| *** spsurya has quit IRC | 05:10 | |
| *** spsurya has joined #zuul | 05:13 | |
| *** sshnaidm has quit IRC | 06:52 | |
| *** quiquell|off is now known as quiquell | 07:09 | |
| *** pcaruana has joined #zuul | 07:42 | |
| *** quiquell is now known as quiquell|brb | 07:44 | |
| openstackgerrit | Matthieu Huin proposed openstack-infra/zuul-jobs master: upload-pypi: add option to register packages https://review.openstack.org/629018 | 07:49 |
| *** dkehn has quit IRC | 07:58 | |
| *** quiquell|brb is now known as quiquell | 08:11 | |
| *** ssbarnea has joined #zuul | 08:14 | |
| *** ssbarnea|bkp2 has quit IRC | 08:16 | |
| *** themroc has joined #zuul | 08:26 | |
| *** sshnaidm has joined #zuul | 08:31 | |
| *** sshnaidm has quit IRC | 08:47 | |
| *** evrardjp_ has joined #zuul | 08:48 | |
| *** evrardjp__ has joined #zuul | 08:49 | |
| *** jpena|off is now known as jpena | 08:50 | |
| *** evrardjp has quit IRC | 08:51 | |
| *** evrardjp_ has quit IRC | 08:52 | |
| *** evrardjp__ has quit IRC | 08:53 | |
| *** evrardjp has joined #zuul | 09:03 | |
| *** hashar has joined #zuul | 09:04 | |
| *** gtema has joined #zuul | 09:05 | |
| *** sshnaidm has joined #zuul | 09:55 | |
| *** bhavikdbavishi has quit IRC | 10:25 | |
| *** dkehn has joined #zuul | 11:52 | |
| *** bhavikdbavishi has joined #zuul | 11:55 | |
| *** jpena is now known as jpena|lunch | 12:37 | |
| *** bhavikdbavishi has quit IRC | 13:00 | |
| *** bhavikdbavishi has joined #zuul | 13:01 | |
| *** zigo has joined #zuul | 13:28 | |
| *** bhavikdbavishi has quit IRC | 13:32 | |
| *** jpena|lunch is now known as jpena | 13:34 | |
| *** jhesketh has quit IRC | 13:45 | |
| *** jhesketh has joined #zuul | 13:47 | |
| *** AlbinVass has joined #zuul | 14:25 | |
| AlbinVass | Anyone here that has experience setting up nodepool with winrm? | 14:26 |
| Shrews | AlbinVass: maybe ask tobiash (i think he added that feature) | 14:26 |
| AlbinVass | Because I think I've found a bug in executor/server.py. It seems like it wants to add an ssh key to known hosts even though it doens't use ssh | 14:27 |
| AlbinVass | Any way to get in contact with him? | 14:27 |
| tobiash | AlbinVass: did you set the connection-type property in nodepool? | 14:28 |
| AlbinVass | yep, to winrm | 14:28 |
| AlbinVass | it's on row 1262 if that's any help | 14:29 |
| tobiash | AlbinVass: zuul adds all host keys that it got from nodepool | 14:31 |
| tobiash | however this list should be empty if you set the connection type to winrm in nodepool | 14:31 |
| AlbinVass | getting 'NoneType' is not iterable | 14:31 |
| tobiash | as nodepool skips getting the keys from the node in this case | 14:31 |
| tobiash | do you have a log? | 14:31 |
| AlbinVass | yeah | 14:31 |
| Shrews | version mismatch between zuul and nodepool maybe? | 14:33 |
| tobiash | possibly | 14:33 |
| tobiash | I don't see that exception in my deployment | 14:33 |
| AlbinVass | it could be an old docker image | 14:37 |
| Shrews | AlbinVass: i'm guessing you have a more recent version of nodepool than zuul. when the winrm feature was added to nodepool, there are zuul changes that were added that you need to actually use that feature. | 14:39 |
| AlbinVass | alright | 14:40 |
| AlbinVass | that could be it actually since I had to set the port to 5986 manually otherwise it was still checking default ssh port | 14:42 |
| tobiash | the port needs to be set manually because it's not yet derived from the connection type | 14:43 |
| AlbinVass | Documentation says it's 5986 if connection-type is set to winrm | 14:44 |
| tobiash | oh, maybe I forgot about that | 14:45 |
| tobiash | AlbinVass: you're right, https://git.zuul-ci.org/cgit/nodepool/tree/nodepool/driver/openstack/config.py#n219 | 14:48 |
| tobiash | AlbinVass: are you on recent versions of zuul and nodepool? | 14:48 |
| AlbinVass | yeah | 14:49 |
| openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Default ssh keys to empty list https://review.openstack.org/629201 | 14:59 |
| tobiash | AlbinVass: this should resolve your exception, but I think there might be more wrong in your setup ^ | 15:00 |
| tobiash | AlbinVass: so it would be useful to see what versions you use and having a log | 15:01 |
| AlbinVass | yeah probably, still trying to set it up to ping a server to start with | 15:05 |
| *** bhavikdbavishi has joined #zuul | 15:13 | |
| dmsimard | I could probably hack something together but is there a way to tell wha tthe log URL will be during job runtime ? | 15:24 |
| pabelanger | dmsimard: yup, emit-job-header will do it. See: http://git.openstack.org/cgit/openstack-infra/project-config/tree/playbooks/base/pre.yaml#n1 | 15:27 |
| AlbinVass | Doesn't like like updating the docker containers fixes it so it's probably something else | 15:27 |
| dmsimard | pabelanger: ah, thanks, I felt like it had been done before but forgot where. Thanks. | 15:28 |
| AlbinVass | tobiash: any chance I get can in touch with you tomorrow? | 15:28 |
| tobiash | just ping me here, I'll respond as soon as I'm available then | 15:31 |
| AlbinVass | Sure, thanks | 15:32 |
| openstackgerrit | Merged openstack-infra/zuul master: Default ssh keys to empty list https://review.openstack.org/629201 | 15:53 |
| *** pcaruana has quit IRC | 16:20 | |
| *** AlbinVass has quit IRC | 16:20 | |
| *** themroc has quit IRC | 16:37 | |
| *** hashar has quit IRC | 17:07 | |
| *** quiquell is now known as quiquell|off | 17:19 | |
| *** gtema has quit IRC | 17:50 | |
| *** rf0lc0 has joined #zuul | 18:14 | |
| *** rfolco has quit IRC | 18:15 | |
| *** rf0lc0 is now known as rfolco | 18:16 | |
| *** panda is now known as panda|off | 18:17 | |
| *** jpena is now known as jpena|off | 18:30 | |
| fungi | the kata containers community is abandoning pullapprove for their github workflow, and looking for alternatives. for completeness i suggested that zuul covers a similar featureset or at least is extensible enough through simple jobs to do most of it. unfortunately i'm not very familiar with github-oriented workflows so not sure how other zuul+gh users here do it. they're asking about "keyword matching for merge | 18:46 |
| fungi | blocking" and "gathering ack's before merge" http://lists.katacontainers.io/pipermail/kata-dev/2019-January/000644.html | 18:46 |
| clarkb | pabelanger SpamapS and tobiash ^ are likely best positioned to talk about their approaches | 18:48 |
| *** bhavikdbavishi has quit IRC | 18:52 | |
| mordred | fungi: the awx project is using zuul for gating | 18:53 |
| mordred | on github | 18:53 |
| mordred | fungi: https://github.com/ansible/awx | 18:53 |
| tobiash | we use githubs branch protection with required status for check, gate and in combination with codeowners review | 18:54 |
| tobiash | our gate is label triggered | 18:54 |
| pabelanger | we even have a job for dco-license: https://github.com/ansible-network/zuul-config/blob/master/zuul.d/jobs.yaml#L70 based on some logic that bonnyci was doing. Been meaning on pushing it up into zuul-jobs | 18:55 |
| tobiash | also note that zuul respects other required status checks too (we use e.g the wip bot which also reports as a status check) | 18:55 |
| tobiash | so this could be combined with anything further that sets status | 18:55 |
| pabelanger | yes, out gate and awx is also label triggered | 18:55 |
| pabelanger | our* (ansible-network) | 18:56 |
| fungi | okay, so basically there is something in github called a "label" which you can set acls around who's allowed to add/remove them, and that's how you "vote" to approve and/or block pull requests? | 18:58 |
| tobiash | labels unfortunately don't have acls | 18:59 |
| tobiash | so we really use it just as a trigger | 18:59 |
| fungi | well, what they seem to be describing is leaving formatted strings in pr comments, which i don't suppose have acls either | 18:59 |
| pabelanger | fungi: yes, correct. but what tobiash, no ACL anybody with commit access can apply a label | 18:59 |
| pabelanger | in our case, we call it gate :) | 18:59 |
| pabelanger | for example: https://github.com/ansible-network/vyos/pull/51 | 18:59 |
| fungi | "with commit access" sounds like an acl | 19:00 |
| tobiash | ok, not a really fine grained acl ;) | 19:00 |
| tobiash | if you want something more sophisticated you can leverage e.g. codeowners with required reviews | 19:01 |
| pabelanger | Yah, they are tied, so if you want to label, they also need commit. which means they can force push tags, I've learned | 19:01 |
| pabelanger | seems branch protections don't help for that | 19:01 |
| tobiash | or write/use some external 'approve-bot' that sets a successful status once all needed approvals are there | 19:01 |
| tobiash | but I suppose using review requirements with codeowners | 19:04 |
| tobiash | would be what I'd recommend | 19:04 |
| tobiash | combined with setting a label to trigger the gate | 19:04 |
| tobiash | but I'm always open for better suggestions | 19:05 |
| pabelanger | I haven't looked at codeowners yet myself, on the list to try | 19:05 |
| tobiash | it's really simple, just enable code review requirements and add a CODEOWNERS file that just lists some group for * in the most simple case | 19:06 |
| tobiash | but with that self-review won't be possible | 19:06 |
| *** hashar has joined #zuul | 20:08 | |
| *** spsurya has quit IRC | 20:41 | |
| *** jesusaur has quit IRC | 23:02 | |
| *** hashar has quit IRC | 23:09 | |
| *** rlandy|rover is now known as rlandy|rover|bbl | 23:16 | |
| corvus | tristanC: do you have a change to make the build url the result url for a build? are there any pre-requisites for that? | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!