Thursday, 2019-01-10

openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: config: add playbooks to job.toDict()  https://review.openstack.org/62134300:19
mordredmrhillsman: I just pushed up patches to gophercloud and cloud-provider-openstack and as a result got test results from your zuul - thanks!00:19
mordredmrhillsman: fwiw, it was MUCH easier to figure out what was wrong with my gophercloud patch from openlab than it was from travis00:20
mrhillsman;)00:22
mrhillsmanwe hope to get that latest zuul up and running to make it even easier00:23
mrhillsmani really like the extra tabs00:23
mrhillsmanhopefully our xcommunity work will yield some more zuul patches00:24
mrhillsmana k8s community member messaged me on how to get involved and i pointed them here00:25
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: config: add playbooks to job.toDict()  https://review.openstack.org/62134301:03
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: config: add tenant.toDict() method and REST endpoint  https://review.openstack.org/62134401:03
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: config: add tenant.toDict() method and REST endpoint  https://review.openstack.org/62134402:35
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement a Runc driver  https://review.openstack.org/53555602:54
*** bhavikdbavishi has joined #zuul03:07
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth  https://review.openstack.org/61915503:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: print-zk: convert zookeeper_servers to a list  https://review.openstack.org/62975403:37
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Implement zookeeper-auth  https://review.openstack.org/61915603:39
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement zookeeper-auth  https://review.openstack.org/61915504:50
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: Implement zookeeper-auth  https://review.openstack.org/61915604:50
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: config: add tenant.toDict() method and REST endpoint  https://review.openstack.org/62134404:53
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift resource provider  https://review.openstack.org/57066705:05
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift Pod provider  https://review.openstack.org/59033505:47
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add jobs graph rendering  https://review.openstack.org/53786906:25
*** quiquell|off is now known as quiquell07:19
*** bhavikdbavishi has quit IRC07:35
*** hashar has joined #zuul07:44
*** pcaruana has joined #zuul07:51
*** avass has joined #zuul07:52
*** bhavikdbavishi has joined #zuul07:57
*** hashar has quit IRC08:06
*** jpena|off is now known as jpena08:08
*** gtema has joined #zuul08:38
avasstobiash: Is pywinrm supposed to be pre-installed on the executor docker image? because I'm getting an error from ansible that there's no winrm module08:54
tobiashno, you need to install it separately afaik08:55
*** logan- has quit IRC09:21
*** logan- has joined #zuul09:28
*** logan- has quit IRC09:28
*** themroc has joined #zuul10:06
*** hashar has joined #zuul10:09
jktpabelanger: ah, I haven't realized that you're from RH, I didn't mean my question about timeline like that :)10:24
*** sshnaidm|afk is now known as sshnaidm10:31
*** openstackgerrit has quit IRC11:05
*** electrofelix has joined #zuul11:28
*** dkehn has quit IRC11:35
*** hashar has quit IRC11:38
*** bhavikdbavishi has quit IRC12:00
*** hashar has joined #zuul12:41
*** jpena is now known as jpena|lunch12:43
*** bhavikdbavishi has joined #zuul13:04
*** rcarrillocruz has joined #zuul13:24
*** bhavikdbavishi has quit IRC13:31
ssbarnea|roveris there are way to avoid this http://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/ansible/callback/zuul_stream.py#n304 -- is really annoying to see ERROR: All items complete -- on logs as this is highligted as an error my my regex-es.13:41
ssbarnea|rovernot sure why "all items complete" counts as an error.13:41
*** rlandy has joined #zuul13:42
*** jpena|lunch is now known as jpena13:45
*** dkehn has joined #zuul13:52
*** dkehn has quit IRC14:13
*** electrofelix has quit IRC14:31
Shrewscorvus: tobiash: care to put another set of eyes on the openshift driver changes? https://review.openstack.org/57066714:46
tobiashShrews: I commented already today with some nits and a missing field in the docs14:47
tobiashI wasn't sure if that's -1 worthy14:47
tobiashI'd say yes with option to fix this in a followup14:47
*** dkehn has joined #zuul14:48
Shrewstobiash: ah, missed that. thx14:51
*** _ari_ has joined #zuul14:59
*** openstackgerrit has joined #zuul15:00
openstackgerritMerged openstack-infra/nodepool master: print-zk: convert zookeeper_servers to a list  https://review.openstack.org/62975415:00
*** rcarrillocruz has quit IRC15:25
avasstobiash: is it possible to make a job only run if a job it depends on is not skipped?15:27
corvusShrews, tobiash, tristanC: looks great.  let's make sure there's at least a patch for the missing image-pull doc before we approve so we don't forget about that.15:37
corvusShrews, tobiash: the depend-on could user another +215:37
corvusavass: if a job depends on a job that is skipped, i don't think it should run; do you see that it does?15:38
avassyeah it still does, the documentation is a bit ambiguous but it seems like it runs as long as it does not fail15:38
avassunless i missed something15:39
corvusavass: just to make sure i'm clear: C depends on B which depends on A;  A fails, b is skipped, c runs (but should be skipped).  right?15:42
avassA is dependent on file changes B should not run if A is skipped15:43
corvusavass: A has a "file:" attribute in the job definition?15:44
avassyeah15:44
corvusavass: so in the report, A doesn't run at all, right?  it doesn't show up as "SKIPPED" it just isn't there?15:44
avassexactly15:45
corvusavass: one more question -- you're not using zuul_return.child_jobs are you?  (where, in job A, you return a 'child_jobs' attribute to zuul to tell it not to run B)15:45
avassnope15:46
corvusavass: what version are you running?15:53
avasswe pulled today15:53
*** quiquell is now known as quiquell|off15:54
corvusavass: i just wrote a unit test for this, and i see that zuul should report back this error: Unable to freeze job graph: Job child-job depends on parent-job which was not run.15:54
corvus(i'm not sure that error is what we want either, since it's not running *any* jobs, but it makes me think i haven't quite reproduced your situation)15:55
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP: Test a child job depending on a parent that did not run  https://review.openstack.org/62988515:56
avassB is not inherited from A, only set as dependent. if that help15:57
corvusavass: ^ does the 'job-dependency.yaml' file in that change look like the right configuration?15:57
corvus(yeah, my use of parent/child here is confusing, sorry.  i did not use inheritance)15:57
avassyes, only that dependecies is set in the child job definition15:58
openstackgerritJames E. Blair proposed openstack-infra/zuul master: WIP: Test a child job depending on a parent that did not run  https://review.openstack.org/62988515:59
corvusavass: like that?15:59
avassyes16:00
corvusthe child-job did run this time, so i think we've got a reproducer16:00
openstackgerritMerged openstack-infra/zuul-jobs master: Add install and deploy openshift roles.  https://review.openstack.org/60861016:00
corvusavass: so i think we have one bug where we are ignoring the dependencies attribute when it's set there, and if we fix that, we'd probably end up with the error message from earlier.  i'm assuming it would be preferable to simply not run the child job in that case, so we'll have to change that too.16:02
avassMaybe it could be configurable later. But it is nice if it behaves the same way at least.16:04
*** sshnaidm has quit IRC16:10
*** sshnaidm has joined #zuul16:11
sshnaidmdo you have any example how to configure user data for nodepool? https://zuul-ci.org/docs/nodepool/configuration.html#attr-providers.[openstack].pools.labels.instance-properties16:26
clarkbsshnaidm: the openstack nodepool config does it to set a flag for ovh instances and glean. Let me get a link16:28
clarkbsshnaidm: https://git.openstack.org/cgit/openstack-infra/project-config/tree/nodepool/nl04.openstack.org.yaml#n6716:28
sshnaidmclarkb, but it's not user-data, right?16:31
clarkbuser-data is just a type of instance property I thought. But maybe it is distinct in nova?16:32
clarkbhrm with osc it is its own flag so maybe it is distinct16:32
clarkbya confirmed with nova api docs. metadata and user_data are separate fields16:34
sshnaidmclarkb, so for passing some cloud config, what should be done? I tried like: instance-properties:16:35
sshnaidm              user-data: userdata.txt16:35
clarkbI don't think that will work. That is what I assumed will work but rereading api docs I'm pretty sure it won't16:36
clarkbnodepool likely needs explicit support for this which I dn't think it has currently16:36
sshnaidmclarkb, oh, I see..16:36
sshnaidmclarkb, maybe you know - if I have 2 users in image, how can I assign public keys to both of them with keypair?16:37
sshnaidmbecause currently it's assigned to first user only16:37
clarkbsshnaidm: that would be a cloud init configuration item aiui16:37
clarkbubuntu sets it for the ubuntu and root users so should be possible16:38
clarkbif you are using glean, glean only supports root user16:38
sshnaidmclarkb, yeah, it's what I tried - to inject cloud init config using instance-properties in nodepool.. :)16:38
sshnaidmI need the nodepool to assign pub keys to all users..16:39
clarkbnodepool doesn't assign any keys to anything. That is up to the image (and nova to pass the data)16:40
sshnaidmclarkb, yeah, I mean when it spawns a vm on openstack with key_name: ...16:41
clarkbyes that is up to your cloud init config which you can set in the image16:42
clarkbnova's api doesn't distinguish keys per user in metadata. But you can instruct your init tooling to apply the key to multiple users16:42
sshnaidmclarkb, but how do I set it on the image?16:43
clarkbsshnaidm: write the config file as part of the nodepool image builds with dib would be one way16:43
sshnaidmclarkb, and then I need to build it.. and if I have already built image?16:44
*** avass has quit IRC16:45
clarkbif you have an already built image that you cannot modify it will depend on however it is already configured.16:46
*** themroc has quit IRC16:48
*** gtema has quit IRC16:54
*** hashar has quit IRC17:13
*** avass has joined #zuul17:21
avassthanks for the help earlier17:21
clarkbsshnaidm: reading further on cloud-init docs it appears that if you want to side load user configs then you need to set user-data. SO probably the thing to do is add support for user data to nodepool and in the meantime modify the image?17:26
*** jpena is now known as jpena|off17:32
*** panda is now known as panda|off17:53
*** electrofelix has joined #zuul18:15
*** electrofelix has quit IRC18:20
*** nhicher has joined #zuul18:27
*** rcarrillocruz has joined #zuul18:27
corvusavass: thanks for the report -- i'll try to work on fixing those issues18:43
*** electrofelix has joined #zuul19:02
*** electrofelix has quit IRC19:04
*** rcarrillocruz has quit IRC19:15
*** rcarrillocruz has joined #zuul19:19
*** rcarrillocruz has quit IRC19:39
openstackgerritDavid Shrewsbury proposed openstack-infra/nodepool master: Add a timeout for the image build  https://review.openstack.org/62992319:47
Shrewsclarkb: i *think* that will prevent the situation you noticed yesterday ^^^.  It changes build log buffer writing a bit to not flush per-line but rather by chunk, but I think that's ok?19:49
Shrewsreadline() blocking seems to be a common thing folks have issues with. it was easier to remove it entirely19:51
clarkbShrews: thanks.19:52
*** openstackgerrit has quit IRC20:50
*** openstackgerrit has joined #zuul20:52
openstackgerritMerged openstack-infra/zuul-base-jobs master: Add ensure-output-dirs to base jobs  https://review.openstack.org/62867420:52
openstackgerritMerged openstack-infra/zuul-base-jobs master: Add fetch-output to base jobs  https://review.openstack.org/62897520:52
openstackgerritMerged openstack-infra/zuul-base-jobs master: Ignore errors on ssh key removal  https://review.openstack.org/62897620:52
*** rlandy is now known as rlandy|biab21:25
*** pcaruana has quit IRC21:46
*** avass has quit IRC22:07
*** rlandy|biab is now known as rlandy22:36
openstackgerritMonty Taylor proposed openstack-infra/zuul-jobs master: Add role to move docs and artifacts to log root  https://review.openstack.org/62957122:48
*** etp has quit IRC22:57
*** etp has joined #zuul22:59
*** etp has quit IRC23:14
*** etp has joined #zuul23:16

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!