Wednesday, 2019-02-20

openstackgerritJames E. Blair proposed openstack-infra/zuul master: Return artifact metadata in API endpoint  https://review.openstack.org/63805200:12
*** rlandy has quit IRC00:16
*** jamesmcarthur has quit IRC00:22
*** jamesmcarthur has joined #zuul00:23
*** jamesmcarthur has quit IRC00:27
*** sdake has joined #zuul00:59
openstackgerritJames E. Blair proposed openstack-infra/zuul master: Don't set child jobs to skipped on post failure  https://review.openstack.org/63805401:35
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: push-to-registry: handle undefined docker_images  https://review.openstack.org/63805701:49
*** cognifloyd has joined #zuul02:07
mrhillsmananyone running or tried running zuul on all arm?02:23
clarkbI'm not aware of anyone doing that but I cant think of any proble  areas for doing that02:30
*** sdake has quit IRC02:36
*** jamesmcarthur has joined #zuul02:37
fungiyeah, in theory should work fine02:40
*** bhavikdbavishi has joined #zuul03:10
dmsimardLooking at this line: https://github.com/openstack-infra/zuul/blob/5271b592afe708d33fc4b3d08d9a2cc97ae0ddfc/.zuul.yaml#L51 where does "zuul.project.src_dir" come from ?03:16
dmsimardI mean, if that is rendered at runtime, could it be different depending on which project triggered the job ?03:17
*** jamesmcarthur has quit IRC03:21
*** jamesmcarthur has joined #zuul03:22
*** jamesmcarthur has quit IRC03:27
*** jamesmcarthur has joined #zuul03:44
clarkbyes its the source dir of the triggering project03:52
clarkb03:53
*** jamesmcarthur has quit IRC03:59
*** jamesmcarthur has joined #zuul04:00
*** jamesmcarthur has quit IRC04:05
*** jamesmcarthur has joined #zuul04:09
*** jamesmcarthur has quit IRC04:22
*** jamesmcarthur has joined #zuul04:25
*** jamesmcarthur has quit IRC04:30
*** jamesmcarthur has joined #zuul04:53
*** cognifloyd has left #zuul04:59
*** jamesmcarthur has quit IRC04:59
*** kratec has joined #zuul05:31
jheskethtobiash: (sorry for the slow reply), regarding 636146 I'm fine with merging it, but initially wanted to leave it up longer because my review was shortly after it was published and wanted to give others a chance to weigh in etc05:36
tobiashjhesketh: thanks05:38
*** k4ch0 has joined #zuul06:00
*** badboy has joined #zuul06:04
badboy#gentoo-pl06:04
*** k4ch0 has quit IRC06:22
*** sdake has joined #zuul06:25
*** sdake has quit IRC06:27
*** saneax has joined #zuul06:31
openstackgerritMerged openstack-infra/zuul master: Don't exclude config if excluded in earlier tenant  https://review.openstack.org/63614606:41
*** quiquell|off is now known as quiquell|rover06:49
*** hasharAway has quit IRC07:09
*** jamesmcarthur has joined #zuul07:18
*** jamesmcarthur has quit IRC07:22
*** quiquell|rover is now known as quique|rover|brb07:36
*** chandankumar is now known as chkumar|ruck07:59
*** pcaruana has joined #zuul07:59
*** quique|rover|brb is now known as quiquell|rover08:04
*** avass has joined #zuul08:12
*** ruffian_sheep has joined #zuul08:14
*** hashar has joined #zuul08:28
openstackgerritJan Kundrát proposed openstack-infra/nodepool master: Implement a Runc driver  https://review.openstack.org/53555608:29
*** gtema has joined #zuul08:41
*** electrofelix has joined #zuul08:45
*** jpena|off is now known as jpena09:00
*** saneax has quit IRC09:04
*** saneax has joined #zuul09:05
*** nilashishc has joined #zuul09:30
*** themroc has joined #zuul09:38
*** nilashishc has quit IRC09:43
*** panda|off is now known as panda09:46
quiquell|rovertobiash: ping, do you have a minute ?10:26
*** bhavikdbavishi has quit IRC10:31
tobiashquiquell|rover: sorry, full day workshop today10:35
quiquell|rovertobiash: ack np10:37
*** ianychoi has quit IRC10:59
*** ruffian_sheep has quit IRC11:48
*** hashar has quit IRC11:56
*** avass has quit IRC11:59
*** jpena is now known as jpena|lunch12:12
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: CLI: fail if trying to enqueue/dequeue a change for the wrong project  https://review.openstack.org/63666212:31
*** hashar has joined #zuul12:31
*** rlandy has joined #zuul13:00
*** saneax has quit IRC13:10
*** saneax has joined #zuul13:11
*** jamesmcarthur has joined #zuul13:18
*** quiquell|rover is now known as quique|rover|mtg13:20
*** jamesmcarthur has quit IRC13:22
*** jamesmcarthur has joined #zuul13:22
*** ianychoi has joined #zuul13:22
*** electrofelix has quit IRC13:31
*** jamesmcarthur has quit IRC13:33
*** jpena|lunch is now known as jpena13:34
*** spsurya has joined #zuul13:44
*** jamesmcarthur has joined #zuul13:51
*** jamesmcarthur has quit IRC13:51
*** jamesmcarthur has joined #zuul13:52
*** sdake has joined #zuul14:10
*** sdake has quit IRC14:18
iurygregoryMorning everyone o/, does anyone has idea how to set a configuration file to be used by tox when running zuulv3? We have functional tests in python-ironicclient https://github.com/openstack/python-ironicclient/blob/master/tools/run_functional.sh but i didnt figure out how could i made it run using zuulv3, any tips? My zuulv3 patch is https://review.openstack.org/#/c/633010/14:28
*** sdake has joined #zuul14:34
*** chkumar|ruck is now known as kmrchdn14:35
dmsimardiurygregory: https://zuul-ci.org/docs/zuul-jobs/jobs.html#job-tox maybe tox_environment or tox_extra_args ?14:39
*** electrofelix has joined #zuul14:40
iurygregorydmsimard, tks man! going to give a try =)14:40
*** gtema has quit IRC14:52
*** jamesmcarthur has quit IRC14:53
*** sdake has quit IRC14:58
*** quique|rover|mtg is now known as quiquell15:06
*** saneax has quit IRC15:33
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: use-buildset-registry: support running before docker installed  https://review.openstack.org/63818015:36
*** gtema has joined #zuul15:43
*** kmrchdn is now known as chandankumar15:48
*** nilashishc has joined #zuul15:54
*** quiquell is now known as quiquell|off15:56
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Split docker mirror config into its own role  https://review.openstack.org/63819516:13
jktwhat is the usual Zuul idiom for running pieces of a job as root on target nodes? My nodes are containers maanged by nodepool's runc (not-yet-merged) if that matters16:17
jktdo I use become: true, sudo, etc?16:17
*** nilashishc has quit IRC16:20
pabelangerjkt: become: true in your ansible playbooks should be enough16:21
jktpabelanger: and that is subject to whatever ansible rules, defaulting probably to sudo, right, thanks16:22
pabelangerjkt: yup, you have the ability to control it via a playbook using become_method16:23
fungialso in openstack we've found it's helpful to revoke sudo privileges from the zuul user at some point in a lot of jobs to prevent accidental use of sudo from creeping into the code being exercised by our jobs16:23
jktfungi: I'll look into this, thanks!16:26
fungijkt: we use the revoke-sudo role from the zuul-jobs standard library for that purpose: https://zuul-ci.org/docs/zuul-jobs/roles.html#role-revoke-sudo16:34
*** nilashishc has joined #zuul16:42
*** themroc has quit IRC16:45
*** nilashishc has quit IRC16:57
jkt...so the fact that runc containers have r/o rootfs is something as a blocker for this :)17:02
*** nilashishc has joined #zuul17:06
mordredjkt: is that a fundamental feature of runc containers? or just how the nodepool driver is doing them? (I haven't dug in to the runc driver yet)17:11
*** pcaruana has quit IRC17:13
*** nilashishc has quit IRC17:17
*** nilashishc has joined #zuul17:18
*** chandankumar is now known as kmrchdn17:19
*** nilashishc has quit IRC17:23
*** nilashishc has joined #zuul17:23
*** nilashishc has quit IRC17:28
*** nilashishc has joined #zuul17:35
*** nilashishc has quit IRC17:49
*** panda is now known as panda|off17:59
*** sdake has joined #zuul18:03
*** hashar has quit IRC18:03
*** gtema has quit IRC18:04
openstackgerritMerged openstack-infra/zuul-jobs master: push-to-registry: handle undefined docker_images  https://review.openstack.org/63805718:06
*** jpena is now known as jpena|off18:11
*** themroc has joined #zuul18:25
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: use-buildset-registry: support running before docker installed  https://review.openstack.org/63818018:35
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Split docker mirror config into its own role  https://review.openstack.org/63819518:35
corvuspabelanger: can you please review https://review.openstack.org/638054 and parent?18:38
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: use-buildset-registry: support running before docker installed  https://review.openstack.org/63818018:48
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Split docker mirror config into its own role  https://review.openstack.org/63819518:48
*** sdake has quit IRC18:58
pabelanger+219:00
*** sdake has joined #zuul19:14
*** saneax has joined #zuul19:28
*** rfolco has quit IRC19:32
*** electrofelix has quit IRC19:38
*** hashar has joined #zuul19:38
*** rfolco has joined #zuul19:39
*** sdake has quit IRC19:50
*** saneax has quit IRC19:53
openstackgerritMerged openstack-infra/zuul master: Support boolean values in get_default  https://review.openstack.org/63715819:56
daniel2So looking at the image.log file from the image builder, it is super hard to find what is causing a failed build.  Any ideas on how to find that faster?19:58
daniel2I literally have to go through thousands of lines of logs to find the one line that shows it failed.19:58
tobiashdaniel2: just look at the last hundred ;)19:59
daniel2Well it doesn't help that it restarts the build after it fails19:59
daniel2is there a way to make it stop after fail?19:59
tobiashit does, it just does some extensive cleanup that also spits out logs19:59
daniel2Well, no, I mean, once it fails it restarts the build which floods the image.log file.20:00
tobiashdaniel2: you can configure nodepool to create one log file per image build20:00
daniel2ah yes that makes sense20:01
*** jamesmcarthur has joined #zuul20:02
tobiashdaniel2: this is the relevant part of a logging config that does that: http://paste.openstack.org/show/745513/20:03
tobiashcorvus: do you have any objection about making it possible to disable the disk accountant in the executor?20:04
corvustobiash: what's the problem?20:04
tobiashI have a hunch that it is very expensive when running large jobs and having many large repos in the cache20:05
daniel2tobiash: Thats actually what its set to, but its just reusing /var/log/nodepool/image/image.log20:05
openstackgerritMerged openstack-infra/zuul master: Return artifact metadata in API endpoint  https://review.openstack.org/63805220:05
openstackgerritMerged openstack-infra/zuul master: Don't set child jobs to skipped on post failure  https://review.openstack.org/63805420:05
tobiashand we're very short on io performance on the executors20:05
tobiashbut have large disks20:05
tobiashso I think in our setup it might harm more than it provides us safety20:06
tobiashdaniel2: hrm, let me recheck our logging config, as our builder has one log file per build20:08
corvustobiash: i think it would be okay (probably just reuse the max size setting for that).  we could also try renicing the thread *, or increasing the loop delay.  (* apparently individual threads can have their own niceness in linux)20:08
daniel2So I noticed that there are two log configs in /etc/nodepool, one is logging.conf and the other is builder-logging.conf20:08
daniel2So I'm unsure if its even picking up the builder-logging.conf file20:09
daniel2I'm working with old stuff created by my colleague 3 years ago.  They were on nodepool 0.3.0, I updated it to 0.5.0 for now.20:09
tobiashcorvus: k, I'll try it via the max size setting, also renicing won't make much difference in our setup because of shared ceph cluster where I'm currently trying to avoid any unneccessary io20:10
tobiashdaniel2: scratch that, my logging config looks outdated in this regard20:12
daniel2It looks like it just rotates after a certain time, not after a build.20:12
tobiashdaniel2: current nodepool versions just do this by default20:13
tobiashbut that probably won't help you as you're probably still on zuulv2?20:14
daniel2yeah..20:16
daniel2I tried to push on just upgrading but got shot down, so I do what I can.20:17
daniel2I'm low on the totem pole.20:18
daniel2Why did nodepool/zuul drop jenkins anyways?20:18
daniel2Jenkins is a pretty solid tool.20:18
mordreddaniel2: many reasons, but importantly it's not solid at scale20:19
daniel2ah I guess that's a good point20:19
daniel2I just started this job a month and a half ago.  I've gotten a pretty good crash course into nodepool.  I might take some spare time to at least make a POC in order to push updating.20:20
mordreddaniel2: nothing like on-the-job learning! :)20:20
daniel2I haven't worked with openstack since grizzly when I was a NOC Engineer for HP Public Cloud.20:21
daniel2Actually, I think I worked with Havana a little bit at Mirantis, and that's where I learned how to work with Gerrit.20:21
mordreddaniel2: oh - we've worked together before then. I was also at HP Public Cloud.20:22
daniel2mordred: Did you work there in 2014?  I was there Feb 2014 to Feb 2015.20:23
mordreddaniel2: yup. Nov2011 to Aug2015. although by Feb 2014 I wasn't as directly involved with the public cloud20:24
daniel2mordred: Well most of the service teams hated us in the NOC :)20:25
mordred:)20:25
daniel2I wrote a portal for the NOC using the openstack bindings and Django.  It was one of my biggest accomplishments.  It was meant just for the NOC but eventually started to spread around the company.  It was capable of tracking down anything to anywhere, instances to routers to networks to customers, etc.20:26
tobiashcorvus, jkt: regarding the update thread and checkout parallelization (635496, 637996). It seems like we have somewhat conflicting conditions. So a one thread count to rule them all may not be possible. What do you think about defaulting to the cpu count (which should be a reasonable default for most installations) and still make that overidable?20:31
*** spsurya has quit IRC20:42
jkttobiash: I'm fine with that, but just note that e.g. 3.7+'s implementation actually uses 5*CPUs in their thread-backed pool implementation, https://docs.python.org/dev/library/concurrent.futures.html#concurrent.futures.ThreadPoolExecutor20:49
jkttheir reasoning is IMHO relevant, they are also talking about overlapping IO20:49
*** themroc has quit IRC20:50
corvustobiash: what's the conflict?  ie, why not go with 5x or 8x?20:51
tobiashjkt: I think that might be ok for us as long we have that threadpool per executor and not per job20:53
tobiashSo go with 5x or 8x and have a common threadpool for updates and clones sounds like a good compromise20:55
corvustobiash: the existing change has a common thread pool, right?20:56
corvusthe only issue under discussion is what the level of parallelization should be?20:57
tobiashcorvus: for updates yes, jkt's followup currently has one per job if I read that correct20:57
corvusoh, i haven't looked at that20:57
tobiashI think that was the modt important part I stumbled accross20:57
tobiashI think it makes sense to combine those threadpools an have 8x cpu maybe with a limit at 64 threads or so21:00
corvustobiash: then, yes, i think i agree with you.  python can't handle more than 1000 threads (even 1000 is probably too much).  so we need to plan for having about 100 job threads and certainly no more than 100 (64 sounds better) io threads.21:01
openstackgerritIan Wienand proposed openstack-infra/nodepool master: Use a pipeline for dib stats  https://review.openstack.org/63826521:01
corvus(with 1k threads, the overhead for dealing with the gil, etc, is too much, cpu-bound threads get starved even when there's available cpu)21:02
tobiashYes, I've saw this in nodepool (v2) a few times21:03
*** jamesmcarthur has quit IRC21:05
*** sdake has joined #zuul21:12
*** jamesmcarthur has joined #zuul21:17
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: use-buildset-registry: support running before docker installed  https://review.openstack.org/63818021:28
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Split docker mirror config into its own role  https://review.openstack.org/63819521:29
*** takamatsu_ has joined #zuul21:31
*** takamatsu has quit IRC21:31
*** sdake has quit IRC21:38
*** sdake has joined #zuul21:39
*** takamatsu_ has quit IRC21:45
*** takamatsu has joined #zuul21:46
*** sdake has quit IRC21:48
*** sdake has joined #zuul21:49
jkttobiash: sure, that makes sense, I should have probably marked these patches as RFC or something21:53
jkttobiash: I'll see if I can make these thread pools global, not per-job21:53
*** jamesmcarthur has quit IRC21:55
*** jamesmcarthur has joined #zuul21:59
*** sdake has quit IRC21:59
*** sdake has joined #zuul22:01
*** hashar has quit IRC22:09
*** hashar has joined #zuul22:10
*** hashar has quit IRC22:10
*** hashar has joined #zuul22:11
corvusi wonder if we should increase the priority of node requests for childred of paused jobs22:36
corvusotherwise, we may leave a paused job idling for a while, which is inefficient overall22:36
*** hashar has quit IRC22:37
mordredcorvus: yeah. seems like an unterrible idea22:47
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: use-buildset-registry: support running before docker installed  https://review.openstack.org/63818022:48
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Split docker mirror config into its own role  https://review.openstack.org/63819522:48
*** rlandy is now known as rlandy|bbl23:14
*** jamesmcarthur has quit IRC23:55
*** jamesmcarthur has joined #zuul23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!