Monday, 2019-03-11

*** jamesmcarthur has joined #zuul01:41
*** jamesmcarthur has quit IRC01:48
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift Pod provider  https://review.openstack.org/59033501:52
*** ruffian_sheep has joined #zuul02:08
ruffian_sheepI meet some problem,I'm try to build a third party CI.Maybe someone had seen me many times lolool.I set the zuul like the layout.yaml. And the result changed after my serval times retry.I dont know what'is the problem.02:17
ruffian_sheephttp://paste.openstack.org/show/747521/02:17
ruffian_sheepIt's right at first and it turned to merge,then failed.02:18
openstackgerritTristan Cacqueray proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.openstack.org/57690702:32
tristanCruffian_sheep: is this zuul v2 ?02:45
ruffian_sheepyes02:46
ruffian_sheeptristanC:Is it have been abandoned?02:46
tristanCcorvus: about the requires artifacts, how are we supposed to cope with a 404 URL, for example when logs are expired after purge?02:47
tristanCruffian_sheep: it's no longer developped, there is no stable/v2 branch for example... Why not using the new v3 version?02:48
ruffian_sheeptristanC:Sad...The zuul v3 is more difficult for me ...I find two document to build the Third party ci.One used the zuul v2,link:https://docs.openstack.org/infra/openstackci/third_party_ci.html02:55
ruffian_sheeptristanC:The others is that :https://zuul-ci.org/docs/zuul/admin/zuul-from-scratch.html02:57
ruffian_sheeptristanC:The second uses the zuul v3,but it also had some problem I can solve....02:58
ruffian_sheeptristanC:The problem is that when i used the zuul v3.:http://paste.openstack.org/show/745241/03:01
ruffian_sheeptristanC:I can do the cmd by myself,but it cannot be used by the service.03:01
*** bjackman has quit IRC03:30
*** bjackman has joined #zuul03:34
*** jamesmcarthur has joined #zuul03:39
tristanCruffian_sheep: can you do ssh -i ~zuul/.ssh/id_rsa hjy@review.openstack.org -p 29418 ?03:49
ruffian_sheeptristanC:Yes,I can03:51
tristanCruffian_sheep: you may want to participate in this spec: https://specs.openstack.org/openstack-infra/infra-specs/specs/zuulv3-3rd-party-ci.html03:51
tristanCruffian_sheep: is the zuul user able to create directory in /var/lib/zuul/executor-git/review.openstack.org/openstack-dev/sandbox ?03:52
tristanCe.g., perhaps one of the directory is owned by root instead of zuul03:53
ruffian_sheeptristanC:0.0 But I can do the cmd to clone the repo03:54
ruffian_sheeptristanC:I have read the document you sent,Zuul-from-scratch.This is the link i just sent to you.03:55
ruffian_sheeptristanC:What is the meaning of able to create directory in /var/lib/zuul/executor-git/review.openstack.org/openstack-dev/sandbox ?03:56
tristanCruffian_sheep: the paste you linked show a "Cmd('git') failed due to: exit code(-13)" which i think highlight a permission issue04:01
tristanCruffian_sheep: make sure zuul can write in that directory, e.g. run "chown -R zuul:zuul ~zuul/executor-git"04:02
*** jamesmcarthur has quit IRC04:32
ruffian_sheeptristanC:Thx dude,I will check it05:45
openstackgerritIan Wienand proposed openstack-infra/zuul-sphinx master: Add type to role variables  https://review.openstack.org/64116805:53
*** ianychoi has quit IRC06:32
*** ianychoi has joined #zuul06:32
*** ianychoi has quit IRC06:35
*** ianychoi has joined #zuul06:36
*** saneax has joined #zuul06:45
*** pcaruana has joined #zuul07:00
*** themroc has joined #zuul07:17
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Add python-path option to node  https://review.openstack.org/63733807:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement an OpenShift Pod provider  https://review.openstack.org/59033507:37
openstackgerritTristan Cacqueray proposed openstack-infra/nodepool master: Implement a Runc driver  https://review.openstack.org/53555607:41
*** badboy has joined #zuul07:43
*** fbo__ has joined #zuul08:10
*** fbo__ is now known as fbo08:11
*** gouthamr has quit IRC08:18
badboyhi guyes08:19
badboys/es/s/08:19
badboyis possible to define a job in zuul-config repo for a given project?08:19
badboymy goal is *not* to have any zuul related files in the repo08:20
tobiashbadboy: yes, absolutely08:20
*** dmellado has quit IRC08:20
badboytobiash: could you share an example?08:21
tobiashjust name the project in the project pipeline: https://zuul-ci.org/docs/zuul/user/config.html#attr-project.name08:21
tobiashor look into openstack-infra/project-config08:21
badboytobiash: run: playbooks/puppet-tarball/run.yaml in this case the playbooks dir is located in the repo?08:25
tobiashbadboy: the playbook must be in the repo where the job is defined08:25
badboytobiash: that's exactly what I am trying to avoid08:25
tobiashbadboy: so you also can have a shared untrusted repo with zuul jobs08:26
tobiashand attach those jobs to another project in a config repo08:26
badboytobiash: I have three repos: repo1, repo2, zuul-config (trusted)08:26
*** gtema has joined #zuul08:26
badboyI would like to have all the the playbooks and configs in the zuul-config repo08:27
tobiashbadboy: that's unfortunate because then all jobs will be non-speculative08:27
badboytobiash: could you elaborate on that?08:27
tobiashbadboy: I might want to think about adding another zuul-untrusted-config repo and define the jobs there08:27
tobiashjobs defined in trusted repos are not self-testing but are changed only on merge08:28
badboyself-testing?08:29
tobiashso maybe you want to have repo1, repo2, zuul-untrusted-config (define jobs here), zuul-config (trusted, define projects here)08:29
tobiashbadboy: jobs in untrusted repos are executed with the predicted future state of the change08:29
tobiashjobs in trusted repos are always executed with the current upstream state of the target branch08:30
badboyso basically, having job in the trusted repo is no good ;)08:31
tobiashbadboy: correct, you should put as few jobs as possible into rtusted repos08:32
badboyfor now I just want to have one job per repo08:33
badboytobiash: one more thing regarding jobs, I have a few scripts that are invoked in the playbooks08:34
badboytobiash: can I store them in zuul-untrusted-config repo as well?08:34
tobiashprobably yes08:36
SpamapSit's a pretty common set up to have a zuul-config repo with your config and a few trusted base jobs to inherit from, and a local-zuul-jobs repo full of untrusted jobs.08:37
SpamapSThat is how both of my significant zuulv3's have worked.08:38
*** saneax has quit IRC08:38
tobiash++08:39
badboySpamapS: so how do I define a job playbook in the project-config?08:40
badboydamn, lack o caffeine08:40
badboynevermind that ;)08:41
badboyI have to grab a coffee08:41
SpamapSbadboy: no worries, basically what you want is job content in untrusted, but project config that ties job content to project and pipeline, in trusted.08:43
badboySpamapS: what about scripts? can I keep them in the untrusted repo?08:47
*** mhu has joined #zuul08:48
tobiashbadboy: you probably want to have the scripts in the same repo as the playbooks08:50
*** zbr has joined #zuul08:53
*** hashar has joined #zuul08:54
*** jpena|off is now known as jpena08:56
*** saneax has joined #zuul08:57
*** needssleep has quit IRC09:01
[GNU]if `encrypt_secret.py` can gets an 404... there is something wrong, right?09:49
*** panda is now known as panda|rover09:50
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.openstack.org/57690710:26
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Allow operator to generate auth tokens through the CLI  https://review.openstack.org/63619710:26
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Zuul CLI: allow access via REST  https://review.openstack.org/63631510:26
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Add Authorization Rules configuration  https://review.openstack.org/63985510:26
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Web: plug the authorization engine  https://review.openstack.org/64088410:26
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/actions endpoint  https://review.openstack.org/64109910:27
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry  https://review.openstack.org/64240810:27
*** electrofelix has joined #zuul10:40
*** saneax has quit IRC10:59
*** gouthamr has joined #zuul10:59
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions  https://review.openstack.org/57690711:03
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Allow operator to generate auth tokens through the CLI  https://review.openstack.org/63619711:03
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Zuul CLI: allow access via REST  https://review.openstack.org/63631511:04
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Add Authorization Rules configuration  https://review.openstack.org/63985511:04
*** dmellado_ has joined #zuul11:04
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: [WIP] Web: plug the authorization engine  https://review.openstack.org/64088411:04
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/actions endpoint  https://review.openstack.org/64109911:04
*** dmellado_ is now known as dmellado11:05
*** markwork has joined #zuul11:08
markworkHey, I can't seem to find the source for the zuul/zuul container on DockerHub, where can I find the Dockerfile?11:09
*** gtema has quit IRC11:26
openstackgerritJakub Bielecki proposed openstack-infra/zuul-preview master: add basic description into README.rst  https://review.openstack.org/64242811:41
openstackgerritMatthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry  https://review.openstack.org/64240811:43
*** ruffian_sheep has quit IRC11:46
*** saneax has joined #zuul11:46
*** edmondsw has joined #zuul11:47
bjackmanI'm confused about the project.merge-mode option. It has "merge", "merge-resolve" and "cherry-pick"11:48
bjackmanBut cherry-pick vs merge is orthoganal to the merge strategy11:49
bjackmanShould there also be a "cherry-pick-resolve"?11:49
*** gtema has joined #zuul11:55
*** rlandy has joined #zuul11:57
*** panda|rover is now known as panda|rover|lunc12:21
*** bjackman has quit IRC12:22
*** bjackman has joined #zuul12:32
*** hashar has quit IRC12:43
*** hashar has joined #zuul12:43
*** jamesmcarthur has joined #zuul12:48
*** jpena is now known as jpena|lunch12:57
*** bjackman has quit IRC12:59
*** bjackman has joined #zuul13:14
*** panda|rover|lunc is now known as panda|rover13:23
*** ianychoi has quit IRC13:28
*** ianychoi has joined #zuul13:29
*** jamesmcarthur has quit IRC13:30
*** jamesmcarthur has joined #zuul13:31
*** jamesmcarthur has quit IRC13:36
*** jamesmcarthur has joined #zuul13:45
*** jamesmcarthur_ has joined #zuul13:49
pabelangermarkwork: it should be in the root folder of https://git.zuul-ci.org/cgit/zuul/13:51
*** jamesmcarthur has quit IRC13:53
*** jpena|lunch is now known as jpena13:59
mordredmarkwork: unfortunately there doens't seem to be any API for seting metadata on dockerhub - metadata about things only gets filled in if you use dockerhub to build images from a github repo14:00
*** gtema has quit IRC14:39
*** hashar has quit IRC14:53
mhuhello, can anybody tell me where the dockerfiles for opendevorg/python-base and opendevorg/python-builder are? I'd like to see what's on them14:54
*** hashar has joined #zuul14:54
pabelangermhu: http://git.openstack.org/cgit/openstack-infra/system-config/tree/docker for the moment14:54
mhuthanks pabelanger!14:55
*** hashar has quit IRC14:55
*** octainne has joined #zuul15:11
pabelangerI've noticed zuul web doesn't seem to work well, if the log that is stream is really long15:16
pabelangerI am unsure if chrome issue or something else15:16
pabelangerhttps://ansible-network.softwarefactory-project.io/zuul/stream/9f0ee3101f5846c6bbdc31be8bfbfe5a?logfile=console.log15:17
pabelangerfor example15:17
pabelangerokay, firefox does seem a little faster15:18
mordredmhu: also, see my comment to markwork about dockerhub not having an API we can use to set metadata about where things like dockerfiles live15:18
pabelangerchrome will just die out15:18
pabelangerbut it could also be poor network15:19
mordredmhu: which is my way of saying "sorry there aren't good links, there isn't really a way for us to set them"15:21
mhumordred, it's okay, I was trying to understand what was done to set the images15:23
mhuI'd like to set up a compose file with my current JWT-related changes + keycloak for debug/Demo purposes15:23
mordredmhu: cool!15:24
mhuyeah, if I ever manage to do it!15:25
*** hashar has joined #zuul15:30
*** hashar has quit IRC15:33
*** hashar has joined #zuul15:33
*** hashar has quit IRC15:37
*** hashar has joined #zuul15:37
*** jamesmcarthur_ has quit IRC15:38
*** jamesmcarthur has joined #zuul15:38
*** jamesmcarthur has quit IRC15:57
*** jamesmcarthur has joined #zuul15:57
*** hashar has quit IRC15:59
*** hashar has joined #zuul15:59
*** jamesmcarthur has quit IRC16:00
*** jamesmcarthur has joined #zuul16:01
*** themroc has quit IRC16:05
SpamapSbjackman: It would actually make some sense to also have a cherry-pick-resolve, yes, but maybe it's just that nobody has asked for that?16:14
pabelangerha, we've been running with out setting a post-timeout for more then 6 months, only today did we notice it.16:18
pabelanger(had a stuck job trying upload logs)16:18
*** pcaruana has quit IRC16:23
*** pcaruana has joined #zuul16:23
*** octainne has quit IRC16:34
*** daniel3 is now known as daniel216:39
openstackgerritTobias Henkel proposed openstack-infra/zuul master: Prevent local code execution via the raw module  https://review.openstack.org/64251816:49
tobiashcorvus, mordred: ^16:50
*** electrofelix has quit IRC16:52
pabelangertobiash: nice find17:03
*** gtema has joined #zuul17:04
tobiashpabelanger: yeah, found this accidentally during the multi-ansible work ;)17:06
SpamapSclarkb: I think I just hit the kubernetes bug you were talking about. 401 after the first operation. WHat were you saying was the remedy?17:13
clarkbSpamapS: install the python kubernetes lib at the 9.0 beta version17:13
clarkbSpamapS: be careful in that openshiftclient pins to version 8 so if you reinstall further up the dep chain you will revert back to broken17:13
*** kklimonda_ has quit IRC17:14
*** rfolco has joined #zuul17:14
SpamapSah so just list it after openshift in the requirements?17:14
*** kklimonda has joined #zuul17:14
*** bjackman has quit IRC17:15
*** rfolco|ruck has quit IRC17:16
clarkbmaybe? we did an out of band install17:17
clarkbI can never keep up with pips changes to how it resolves those conflicts17:17
clarkbbut ya17:17
openstackgerritClint 'SpamapS' Byrum proposed openstack-infra/nodepool master: DNM: Pin to Kubernetes 9 beta until it releases  https://review.openstack.org/64252417:18
SpamapSI use gerrit refs for patches whenever possible. :)17:18
SpamapSclarkb: for requirements.txt, it's not a dep solver. It literally just installs each one in series.17:20
clarkbSpamapS: yes but when it runs into conflicts it does things17:21
SpamapSnah, it just complains17:21
clarkbya I think it may fail17:21
SpamapS"Hey you asked for this, but other packages will be broken."17:21
SpamapSI wonder if there's any way to solve it not with beta kubernetes driver.17:22
clarkbthis behavior has changed many times in the last few yaers though17:22
clarkb(fwiw I filed the original pip bug "needs dep resolver". I kept up to date on this until I realized it would never be fixed and stopped paying attention)17:22
clarkbSpamapS: the issue is the previous kubernetes lib holds threads open17:22
SpamapSpipenv is the closest pip has come to having a depsolver17:22
clarkbSpamapS: so the wait for threads to close code never finishes and you end up waiting on timeouts iirc17:23
SpamapSand it does that by having an explicit lock file.17:23
clarkbit is also all generated code17:23
SpamapSclarkb: hm, the thing I see.. nodepool is able to make namespaces and pods when it first starts, but then not after a while.17:23
SpamapSsounds like it might be the same.17:23
SpamapSor not17:23
clarkbbeing generated code I doubt they'd take a fix to 8.0 that was hand rolled. And 9.0 beta is up just need them to release it and we can unpin openshiftclient17:24
*** jamesmcarthur has quit IRC17:40
*** jamesmcarthur has joined #zuul17:41
openstackgerritMerged openstack-infra/zuul master: Prevent local code execution via the raw module  https://review.openstack.org/64251817:45
*** jamesmcarthur has quit IRC17:45
fungicorvus: mordred: okay to switch the story visibility for that ^ now?17:47
fungitobiash: ^17:47
tobiashfungi: fine for me, the fix is merged :)17:48
tobiashcorvus: or do you like to wait until it's in a release?17:48
fungipeople reading random stories on storyboard are probably roughly as common as people reading commit messages in git (perhaps even less so)17:49
clarkbnot getting email about those is the known issue with private stories right?17:51
fungiyep17:51
daniel2So every time an image to built it redownloads all the openstack repos which takes a long time.  Is there a way to have it just reuse the same repos and not update them if no update is needed or something?17:57
clarkbdaniel2: are you using openstacks elements for that? if so it should already cache them in the dib cache dir17:58
daniel2clarkb: using openstack-repos element for that, its downloading them to dib_cache but its still redownloading them every time an image is built.17:59
*** gtema has quit IRC17:59
clarkbit shouldnt do a full download it should just update them18:00
daniel2maybe thats what I'm seeing then18:01
fungiit's supposed to just check whether there are any new commits at the origin and fetch those to the local clone18:02
daniel2you're right, it just says "updating cache"18:10
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Begin refactoring code for unit testing  https://review.openstack.org/64224518:13
*** jpena is now known as jpena|off18:13
daniel2It still takes like 10-15 minutes to do just that18:14
*** markwork has quit IRC18:17
openstackgerritDavid Shrewsbury proposed openstack-infra/zuul-preview master: WIP: Begin refactoring code for unit testing  https://review.openstack.org/64224518:18
Shrewsfyi, ^^ is mostly just me experimenting/learning. not sure how much effort i'm going to continue to put into that for the time being18:20
*** jamesmcarthur has joined #zuul18:20
daniel2Testing is overrated, it's always best to test your code in production :)18:20
*** panda|rover is now known as panda|rover|off18:20
Shrewsdaniel2: you subscribe to mordred's newsletter, i see  :)18:21
daniel2Shrews: I just spent 5 years in the Software QA field, so my ideas of testing are morbid.18:22
*** jamesmcarthur has quit IRC18:26
openstackgerritJeremy Stanley proposed openstack-infra/zuul-jobs master: [DNM] exercise base-test as parent in unittests  https://review.openstack.org/64253618:27
fungidaniel2: yeah, even just checking the remote state for over a thousand git repos will take a while. for your own deployment you might be able to get away with stripping it down to just the repositories used by the jobs you expect to run18:28
* fungi isn't sure what your goal is though18:29
daniel2fungi: Apparently we used to host a local copy with Gitlab, but I feel that would take forever to do.  The main goal is because nodestack-base requires openstack-repos.  Although I've started modifying the elements as needed.  We are still on 0.5.0 and can't upgrade right now.18:30
daniel2It's been 3 weeks so far I've been working on this.  It would had probably been faster if I upgraded, but I keep having to track down old files, old documentation, etc etc.18:30
openstackgerritJeremy Stanley proposed openstack-infra/zuul-jobs master: [DNM] exercise base-test as parent in unittests  https://review.openstack.org/64253618:36
openstackgerritJeremy Stanley proposed openstack-infra/zuul-jobs master: [DNM] exercise base-test as parent in unittests  https://review.openstack.org/64253618:39
*** jamesmcarthur has joined #zuul18:47
mnaseri remember this being brought up in context of zuul dev where running gpg commands would autostart the gnupg agent19:14
mordredyup19:15
mnaserhow did you workaround that?19:15
* mnaser is trying to get a container of something and needs to import gpg keys for apt repo and getting weird warnings around process going up19:15
mordredmnaser: one sec - lemme get the cantrip for you19:16
mordredmnaser: ok - so weirdly, if you run "gpg-agent --daemon your command here" - it will run gpg without spawning a long-lived daemon process19:17
* mnaser blinks19:18
mordredyeah19:18
mordreddon't thnik about it too much19:18
mnasero-ok19:18
mnaserworks for me.19:18
mordredalso don't ask too many questions about why it's so impossible to avoid spawning a daemon19:18
*** saneax has quit IRC19:23
pabelangerapparently you can use mask to stop the gpg-agant daemon from even starting, but need to mask like 4 services: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850982#4519:48
openstackDebian bug 850982 in gnupg-agent "Add instructions to disable gpg-agent user service in README.Debian" [Normal,Fixed]19:48
corvusi'll tag 5ae25f004a32ea76558564612903cef917c3e5b9 as 3.6.1  sound good?19:50
corvustobiash, mordred: ^19:50
tobiashcorvus: ++19:51
*** dkehn has joined #zuul19:51
corvustobiash: do you want to write an announcement?19:51
tobiashyes I can, just a minute19:52
mordredcorvus: ++19:59
tobiashcorvus, mordred, fungi: how does that look like? https://etherpad.openstack.org/p/X3NlVoP2ZL20:01
mordredlgtm20:01
tobiashmordred: I shamelessly copied parts of your last security mail ;)20:01
corvustobiash: ++20:02
mordredtobiash: that's the way I like to write emails :)20:02
tobiashme too :)20:02
fungiwe should definitely switch the story to public before we send out an announcement referring to it20:05
fungianyone mind if i go ahead and do that now?20:06
corvusfungi: ++20:06
tobiashoh I thought you did this already ;)20:06
fungiokay, story 2005037 is public now20:06
tobiash3.6.1 is on pypi now20:07
pabelangerupgrading now!20:08
fungitobiash: your announcement looks great, thanks!20:08
fungiin the future we can take advantage of the its-storyboard plugin for gerrit by switching the story to public right before pushing the fix to gerrit, and including a corresponding task footer in the commit message20:11
fungiideally the story itself doesn't disclose any more information than can be obtained by looking at the patch anyway20:11
corvusShrews: what's the status of authenticated zookeeper connections?20:16
corvuslooks like https://review.openstack.org/619155 is the answer to that20:19
Shrewscorvus: not really familiar with zk auth myself but i can begin looking at that review for us and start digging into it20:22
corvusShrews: cool -- i think we're going to need it for the "use zk instead of gearman" part of zuul v4 for sure ... and maybe sooner based on this email i'm writing right now :)20:23
tobiashmordred: re openstacksdk image download memory issue: neither jemalloc nor response.raw.read fixed the issue so we'll have to dig deeper20:24
clarkbcorvus: Shrews you can use basicauth or kerberos iirc20:29
clarkbwe probably only need basicauth as we don't need to partition readers and writers aggressively20:29
mordredtobiash: BOOO20:32
pabelangerZuul version: 3.6.1 \o/20:34
tobiashmordred: maybe I find time to dig into that tomorrow20:40
*** hashar has quit IRC20:42
*** hashar has joined #zuul20:45
*** jamesmcarthur has quit IRC20:56
SpamapSclarkb: unfortunately, kubernetes client 9.x.x beta doesn't work for namespaces in nodepool21:13
SpamapShttp://paste.openstack.org/show/747576/21:14
clarkbSpamapS: bah21:16
clarkbyou'd think it would be eaiser to maintain compat with generated code21:16
clarkbjust generate all the versions21:16
openstackgerritJames E. Blair proposed openstack-infra/zuul-jobs master: Add no_log entries to skopeo copy commands  https://review.openstack.org/64257421:29
corvusmordred, clarkb, fungi: ^ final cleanup for the buildset registry stuff21:29
*** pcaruana has quit IRC21:45
dmsimardcorvus: re - Ansible modules in Zuul: does upstream have an opinion on how we should be managing this at all ? I know that there is a notion of authorized modules in AWX but I'm not familiar with how it works under the hood.21:51
corvusdmsimard: plugins, not modules, are the main issue here21:52
corvus(though some of the work is custom plugins which then restrict what upstream modules are run)21:52
corvusdmsimard: but i'm not familiar with awx authorized modules, do you have a reference?21:53
corvusdmsimard: i think the tricky thing is that in many cases, our plugins allow use of certain modules but only if they have certain arguments21:55
dmsimardcorvus: best reference I can find right now is https://docs.ansible.com/ansible-tower/latest/html/userguide/security.html#playbook-access-and-information-sharing (see the screenshot with a list of enabled modules)21:57
dmsimardcorvus: I may be conflating definitions of modules and plugins -- action plugins are indeed not modules22:00
corvusdmsimard: though, at the end of the day, the thing we wanted to do was "don't allow certain tasks to run".  "don't run these modules" is pretty close to that -- enough to make it worth looking into.  :)22:02
fungias i understand, even the licensing requirements for action modules and plugins differ22:02
corvusfungi: yes, though that isn't a concern in this case22:02
corvus(we're happy to carry gpl code)22:02
fungisure, just noting they're quite distinct conceptually22:02
dmsimardin any case, I agree that it's not sustainable to "fork" every upstream plugin and I would look at how we might implement a single place where modules (or plugins) are either authorized to run or not based on configuration22:04
dmsimardThey already have something somewhat similar with callback plugin whitelisting22:04
corvusdmsimard: that sounds reasonable -- but does that get us anything?  we have no "policy" reasons not to run modules, only security reasons22:05
corvusand the security reasons suggest that we either need to filter based on argument, or blacklist almost everything22:05
*** rfolco is now known as rfolco|ruck|off22:06
dmsimardyeah, filtering based on arguments makes it a bit more challenging. I'll do some research :)22:08
*** josefwells has quit IRC22:18
SpamapSclarkb: I've never seen generated code work out. The shortcut always leads to a lack of engagement in the target language (see: mordred's libgearman driver ;)22:27
openstackgerritMerged openstack-infra/zuul master: Increase timeout of test_plugins  https://review.openstack.org/64180322:30
openstackgerritMerged openstack-infra/zuul master: Fix test race in test_container_jobs  https://review.openstack.org/64179122:30
*** hashar has quit IRC22:38
corvustobiash: i've reviewed the multi-ansible stack22:42
mordredSpamapS: I agree - I used to be a fan of the generated bindings approach and have since come to hold the opinion that it's a bad idea22:48
*** threestrands has joined #zuul22:50
clarkbSpamapS: sure I didn't write the kubernetes module. I'm assuming someone from google runs the swagger generator on it22:55
mrhillsmanbefore i go digging, is there a way to use [WIP] or [DNM] in the title to disable CI for a PR23:04
mrhillsmani mean is it possible out the box23:04
corvusmrhillsman: not out of the box.  i expect that the gerrit or github triggers could be extended to support matching on commit messages.23:08
corvusmrhillsman: but i'm confused by that request.  WIP and DNM changes are the ones i'm most interested in seeing CI results on.23:08
mrhillsmanlike a person knows it is not ready for testing cause they are still building it23:09
mrhillsmanthe job(s)23:10
mrhillsmansomeone is asking but i also could use it for that exact use case23:10
corvusmrhillsman: even when i know something is going to fail, i still don't always know all the ways it's going to fail.  i get tons of useful information that way :)23:10
mrhillsmanagreed23:10
mrhillsmanbut rather than holding up a resource for a failure i know will happen i would want to hold off23:11
mrhillsmancause i am still adding in stuff to the job definition23:11
mrhillsmanadditional tasks, roles, etc23:12
SpamapSsimplicity buys a lot of resources.23:12
mrhillsmancause it is completely nothing right now23:12
corvusmrhillsman: sometimes when i'm building a new job, i'll comment out all the others from the in-tree .zuul.yaml23:12
corvusthat's a special case where we can do something like that.23:12
mrhillsmanso for a case where i or someone knows it does not make sense to trigger the ci would be good to add that23:13
mrhillsmani am sure other use cases could be thought up just wanted to check though23:14
mrhillsmanappreciate it23:14
*** threestrands has quit IRC23:45
openstackgerritMerged openstack-infra/zuul-jobs master: Add no_log entries to skopeo copy commands  https://review.openstack.org/64257423:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!