*** ianychoi has quit IRC | 00:17 | |
*** ianychoi has joined #zuul | 00:18 | |
*** jamesmcarthur has joined #zuul | 00:18 | |
*** mhu has quit IRC | 00:19 | |
*** mhu has joined #zuul | 00:19 | |
*** yolanda has quit IRC | 01:07 | |
*** yolanda has joined #zuul | 01:15 | |
*** jamesmcarthur has quit IRC | 01:51 | |
*** jamesmcarthur has joined #zuul | 01:51 | |
*** rlandy has quit IRC | 01:55 | |
*** jamesmcarthur has quit IRC | 01:56 | |
*** jamesmcarthur has joined #zuul | 02:02 | |
*** jamesmcarthur has quit IRC | 02:06 | |
*** bhavikdbavishi has joined #zuul | 02:18 | |
*** jamesmcarthur has joined #zuul | 02:22 | |
*** bhavikdbavishi has quit IRC | 02:45 | |
*** jamesmcarthur has quit IRC | 02:54 | |
*** jamesmcarthur has joined #zuul | 03:02 | |
*** jamesmcarthur has quit IRC | 03:18 | |
*** jamesmcarthur has joined #zuul | 03:19 | |
*** jamesmcarthur has quit IRC | 03:21 | |
*** pabelanger has quit IRC | 03:24 | |
*** bhavikdbavishi has joined #zuul | 03:30 | |
jhesketh | tristanC: so, I think part of the confusion around the object roles in the zuul-runner refactor is the way the runner and executor are consuming AnsibleJob differently. I think rather than extending AnsibleJob, the executor should consume it and handle the gearman stuff around it | 03:48 |
---|---|---|
jhesketh | tristanC: I've done a crude refactor that pulls it out, and it also help uncover some inter-dependencies between the parent and child that shouldn't have been there, and it seems to work | 03:49 |
jhesketh | so I'll keep tidying that up and rebase everything and see where that lands us | 03:49 |
*** raukadah is now known as chandankumar | 03:53 | |
tristanC | jhesketh: that sounds better indeed, thanks! | 04:04 |
*** jamesmcarthur has joined #zuul | 05:23 | |
*** jamesmcarthur has quit IRC | 05:27 | |
*** gtema has joined #zuul | 05:47 | |
*** gtema has quit IRC | 05:53 | |
*** swest has joined #zuul | 06:13 | |
*** quiquell|off is now known as quiquell | 06:37 | |
badboy | hi all | 07:13 |
badboy | what are the possible triggers in a pipeline? so far I've found patchset-created and comment-added | 07:14 |
badboy | is it possible to make a trigger on a label i.e. code-review, verified etc.? | 07:14 |
*** gtema has joined #zuul | 07:23 | |
*** quiquell is now known as quiquell|brb | 07:25 | |
mordred | badboy: yes - those come in via the comment-added trigger- for instance: https://opendev.org/zuul/project-config/src/branch/master/zuul.d/pipelines.yaml#L46-L48 | 07:26 |
mordred | badboy: https://zuul-ci.org/docs/zuul/admin/drivers/gerrit.html#attr-pipeline.trigger.%3Cgerrit%20source%3E.approval talks about it | 07:27 |
badboy | mordred: can a custom label be used? | 07:27 |
badboy | mordred: i.e. i have a 'fancy-label', can I used it as a trigger? | 07:28 |
badboy | s/used/use/ | 07:28 |
*** quiquell|brb is now known as quiquell | 08:06 | |
mordred | badboy: yup. our "workflow" label is a custom label - the label names are passthrough - zuul doesn't know anything about them | 08:16 |
badboy | mordred: thx :) | 08:25 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Get executor job params https://review.openstack.org/607078 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Separate out executor server from runner https://review.openstack.org/607079 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: implement prep-workspace https://review.openstack.org/607082 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: add configuration schema https://review.openstack.org/640672 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: add execute sub-command https://review.openstack.org/630944 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add command line interface https://review.openstack.org/644770 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: add job parameters listing https://review.openstack.org/644795 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Add depends-on support to frozen jobs API https://review.openstack.org/639022 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add support for depends-on https://review.openstack.org/632064 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Move repository preparation into common class https://review.openstack.org/648642 | 08:35 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Separate out executor concerns from AnsibleJob https://review.openstack.org/648643 | 08:35 |
jhesketh | tristanC: ^ okay, some refactoring of the stack and how we consume AnsibleJob. Should make the boundaries clearer, and have also added some comments on the classes. I still want to add some user facing docs next. | 08:36 |
jhesketh | After that we can review if it needs a retro-spec. | 08:36 |
*** jpena|off is now known as jpena | 08:40 | |
tristanC | jhesketh: that looks great, thanks a lot. | 08:48 |
jhesketh | :-) | 08:49 |
jhesketh | I also reordered some commits FYI | 08:49 |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Add a role to mirror a git repository to a remote git server https://review.openstack.org/643394 | 08:51 |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Add a job that runs the upload-git-mirror role https://review.openstack.org/648230 | 08:51 |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Fix typo in upload-git-mirror README https://review.openstack.org/648423 | 08:51 |
*** bhavikdbavishi has quit IRC | 08:53 | |
*** pcaruana has joined #zuul | 09:15 | |
*** electrofelix has joined #zuul | 09:37 | |
*** hashar has joined #zuul | 09:41 | |
odyssey4me | jhesketh tristanC great to see movement on zuul runner, and on being able to set the version of ansible used to run | 09:42 |
badboy | mordred: can you please look at this and tell me if PIPELINE_2 or PIPELINE_3 is valid? currently I have PIPELINE_1 set to be triggered on Code-Review change | 10:09 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Separate out executor concerns from AnsibleJob https://review.openstack.org/648643 | 10:11 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: implement prep-workspace https://review.openstack.org/607082 | 10:11 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: add configuration schema https://review.openstack.org/640672 | 10:11 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: add execute sub-command https://review.openstack.org/630944 | 10:11 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add command line interface https://review.openstack.org/644770 | 10:11 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: runner: add job parameters listing https://review.openstack.org/644795 | 10:11 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: Add depends-on support to frozen jobs API https://review.openstack.org/639022 | 10:12 |
openstackgerrit | Joshua Hesketh proposed openstack-infra/zuul master: zuul-runner: add support for depends-on https://review.openstack.org/632064 | 10:12 |
openstackgerrit | Luigi Toscano proposed openstack-infra/zuul-jobs master: stage-output: fix dotfiles handling https://review.openstack.org/648658 | 10:34 |
*** hashar has quit IRC | 11:01 | |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: trigger: add job filter event https://review.openstack.org/639905 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: webtrigger: add initial driver and event https://review.openstack.org/555153 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: webtrigger: add web route and rpclistener https://review.openstack.org/554839 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add build button to trigger job https://review.openstack.org/635716 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: webtrigger: add support for parameterized trigger https://review.openstack.org/644484 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add build modal with a parameter form https://review.openstack.org/644485 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add support for checkbox and list parameters https://review.openstack.org/648661 | 11:07 |
openstackgerrit | Tristan Cacqueray proposed openstack-infra/zuul master: web: add triggers information to pipeline list https://review.openstack.org/637670 | 11:08 |
*** gtema has quit IRC | 11:35 | |
*** bhavikdbavishi has joined #zuul | 11:45 | |
*** jamesmcarthur has joined #zuul | 12:18 | |
*** EmilienM is now known as EvilienM | 12:21 | |
*** jpena is now known as jpena|lunch | 12:32 | |
*** jamesmcarthur has quit IRC | 12:33 | |
*** hashar has joined #zuul | 12:49 | |
*** pabelanger has joined #zuul | 12:49 | |
*** jamesmcarthur has joined #zuul | 12:50 | |
*** quiquell is now known as quiquell|lunch | 12:56 | |
*** gtema has joined #zuul | 12:59 | |
*** rlandy has joined #zuul | 13:26 | |
openstackgerrit | Markus Hosch proposed openstack-infra/zuul master: Evaluate CODEOWNERS settings during canMerge check https://review.openstack.org/644557 | 13:26 |
pabelanger | tobiash: I think I might have hit a bug with multi-ansible support (using ansible_root): http://paste.openstack.org/show/748582/ | 13:29 |
pabelanger | Ansible output: b'bwrap: execvp /opt/venv/zuul-ansible/2.7/bin/ansible-playbook: No such file or directory' | 13:29 |
pabelanger | tobiash: I haven't yet looked into code path, but suspect ansible isn't setup properly inside bwrap | 13:29 |
tobiash | pabelanger: oh, maybe the ansible_root is missing as ro path in the bwrap | 13:34 |
pabelanger | yah | 13:34 |
pabelanger | I think that is it | 13:34 |
pabelanger | trying to find code, but also should be able to manually set in zuul.conf | 13:35 |
*** jpena|lunch is now known as jpena | 13:35 | |
tobiash | pabelanger: https://opendev.org/openstack-infra/zuul/src/branch/master/zuul/executor/server.py#L1872 | 13:37 |
tobiash | the executor takes it from the ansible-manager, so that should work | 13:37 |
tobiash | so the bug must be then in the ansible manager somehow | 13:37 |
pabelanger | oh | 13:37 |
pabelanger | --ro-bind /opt/venv/zuul-3.7.1 /opt/venv/zuul-3.7.1 | 13:38 |
pabelanger | I think this is a symlnk issue | 13:38 |
pabelanger | Hmm | 13:38 |
pabelanger | maybe not | 13:38 |
tobiash | you symlinked it? | 13:38 |
pabelanger | yah, so I can have dot release virtualenvs | 13:39 |
pabelanger | --ro-bind /opt/venv/zuul-ansible/2.7 /opt/venv/zuul-ansible/2.7 | 13:39 |
pabelanger | that is right, but guessing bwrap fails because that symlinks outside | 13:39 |
tobiash | if that symlinks outside then yes | 13:40 |
pabelanger | let me add -ro-bind of /opt/venv/zuul-ansible, toplevel | 13:40 |
tobiash | *phew*, so a deployment issue not a zuul bug | 13:40 |
pabelanger | :) | 13:40 |
pabelanger | tobiash: okay, untrusted_ro_paths looks to be my fix here! Sorry for noise | 13:52 |
tobiash | :) | 13:53 |
badboy | hey guys, can you please look at this and tell me if PIPELINE_2 or PIPELINE_3 is valid? | 13:54 |
badboy | currently I have PIPELINE_1 set to be triggered on Code-Review change | 13:54 |
badboy | http://paste.openstack.org/show/748574/ | 13:54 |
openstackgerrit | Luigi Toscano proposed openstack-infra/zuul-jobs master: stage-output: fix dotfiles handling https://review.openstack.org/648658 | 13:56 |
tobiash | badboy: valid in what regard? | 13:57 |
tobiash | badboy: your gerrit review requirements look a bit odd, check out this as a examples of real world in use pipelines: https://opendev.org/openstack-infra/project-config/src/branch/master/zuul.d/pipelines.yaml | 13:59 |
badboy | tobiash: I would like a trigger on all Code-Reviews values | 13:59 |
badboy | tobiash: don't mind the yaml syntax on paste | 14:01 |
*** quiquell|lunch is now known as quiquell | 14:02 | |
badboy | tobiash: https://opendev.org/openstack-infra/project-config/src/branch/master/zuul.d/pipelines.yaml#L26-L27 | 14:02 |
badboy | tobiash: what's the difference between require-approval and approval? | 14:03 |
tobiash | badboy: https://zuul-ci.org/docs/zuul/admin/drivers/gerrit.html#attr-pipeline.trigger.%3Cgerrit%20source%3E.approval | 14:10 |
tobiash | and https://zuul-ci.org/docs/zuul/admin/drivers/gerrit.html#attr-pipeline.trigger.%3Cgerrit%20source%3E.require-approval | 14:10 |
tobiash | that describes both | 14:11 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions https://review.openstack.org/576907 | 14:39 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Allow operator to generate auth tokens through the CLI https://review.openstack.org/636197 | 14:39 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Zuul CLI: allow access via REST https://review.openstack.org/636315 | 14:39 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Add Authorization Rules configuration https://review.openstack.org/639855 | 14:39 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Web: plug the authorization engine https://review.openstack.org/640884 | 14:40 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/actions endpoint https://review.openstack.org/641099 | 14:40 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 14:40 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] admin REST API: docker-compose PoC, frontend https://review.openstack.org/643536 | 14:40 |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool master: WIP: Add test demonstrating image build leak https://review.openstack.org/648706 | 14:47 |
Shrews | corvus: gotta make some minor improvements, but looks like your idea will work ^^ | 14:50 |
*** jamesmcarthur has quit IRC | 14:54 | |
*** jamesmcarthur has joined #zuul | 15:08 | |
*** jamesmcarthur has quit IRC | 15:13 | |
*** jamesmcarthur has joined #zuul | 15:18 | |
*** gouthamr has quit IRC | 15:24 | |
*** dmellado has quit IRC | 15:24 | |
*** dmellado has joined #zuul | 15:26 | |
pabelanger | tobiash: okay, up and running now, after a reorg of directories | 15:27 |
tobiash | :) | 15:27 |
pabelanger | now to enable swift logs | 15:27 |
*** gouthamr has joined #zuul | 15:27 | |
*** chandankumar is now known as raukadah | 15:30 | |
tobiash | ++swift, after switching to it I never had to do anything with it again :) | 15:32 |
tobiash | it's like fire and forget | 15:32 |
pabelanger | yah | 15:32 |
pabelanger | I think the next step is get a swift proxy up to make URLs nicer | 15:33 |
corvus | tobiash, pabelanger: can you look at https://review.openstack.org/648550 ? | 15:33 |
corvus | and maybe add that repo to your list of repos to watch? :) | 15:33 |
tobiash | yes | 15:33 |
corvus | pabelanger: i have a better next step than that | 15:33 |
pabelanger | corvus: oh, cool | 15:33 |
corvus | pabelanger: http://lists.zuul-ci.org/pipermail/zuul-discuss/2018-July/000501.html | 15:34 |
corvus | pabelanger: that's the direction we should be heading on logging. no proxy required, but it will address your concerns with nice urls | 15:34 |
*** sshnaidm|off has quit IRC | 15:34 | |
corvus | i'll pull that in as a spec | 15:34 |
pabelanger | nice! will re-read today | 15:34 |
tobiash | corvus: I've added that project to my default filter | 15:39 |
openstackgerrit | Merged zuul/project-config master: Add branch docs jobs https://review.openstack.org/648550 | 15:45 |
*** sshnaidm|off has joined #zuul | 15:48 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Add logs spec https://review.openstack.org/648714 | 15:52 |
corvus | pabelanger, tristanC, jhesketh: ^ i pulled in that mailing list message as a spec and updated it slightly. we've already done 2 of the larger work items described there. :) | 15:53 |
*** quiquell is now known as quiquell|off | 15:59 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul-sphinx master: Update to new docs jobs https://review.openstack.org/648718 | 15:59 |
openstackgerrit | Merged openstack-infra/zuul-sphinx master: Update to new docs jobs https://review.openstack.org/648718 | 16:24 |
corvus | w00t! got it in one! https://zuul-ci.org/docs/zuul-sphinx/.root-marker :) | 16:27 |
*** rlandy is now known as rlandy|brb | 16:30 | |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: WIP - Pagure driver https://review.openstack.org/604404 | 16:39 |
corvus | mhu: i'm reviewing the jwt spec, and i noticed that the authz section has gotten complicated again | 16:47 |
corvus | mhu: originally, it was complicated, then we had a discussion about making it simpler (just restricting admin actions to admin users), and the last time i reviewed it, it reflected that | 16:47 |
corvus | mhu: but now it's complicated again, with a whole language for describing authz rules | 16:47 |
corvus | mhu: why did that happen? | 16:48 |
*** rlandy|brb is now known as rlandy | 16:49 | |
*** bhavikdbavishi has quit IRC | 16:51 | |
*** bhavikdbavishi has joined #zuul | 16:54 | |
*** gtema has quit IRC | 16:56 | |
*** [GNU] has quit IRC | 16:57 | |
*** gtema has joined #zuul | 16:57 | |
*** gtema has quit IRC | 16:57 | |
*** jpena is now known as jpena|off | 17:37 | |
*** yolanda has quit IRC | 17:53 | |
*** hashar has quit IRC | 17:56 | |
*** jamesmcarthur has quit IRC | 18:01 | |
openstackgerrit | David Shrewsbury proposed openstack-infra/nodepool master: WIP: Fix for image build leaks https://review.openstack.org/647599 | 18:02 |
*** jamesmcarthur has joined #zuul | 18:03 | |
*** sshnaidm|off has quit IRC | 18:08 | |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Match tag items against containing branches https://review.openstack.org/578557 | 18:10 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Use implied branch matcher for implied branches https://review.openstack.org/640272 | 18:10 |
*** jamesmcarthur_ has joined #zuul | 18:12 | |
*** jamesmcarthur has quit IRC | 18:14 | |
corvus | clarkb: can you weigh in on the elasticsearch field index questions in https://review.openstack.org/644927 when you have a spare moment? (see my comment on the latest PS, but possibly also on an earlier one) | 18:15 |
*** jamesmcarthur_ has quit IRC | 18:20 | |
*** jamesmcarthur has joined #zuul | 18:21 | |
*** sshnaidm|off has joined #zuul | 18:21 | |
clarkb | corvus looking | 18:21 |
clarkb | corvus: ya elasticsearch can work schemaless so you should be able to inject any arbitrary json datastructure | 18:22 |
clarkb | corvus: so some jobs can have { zuul.vars.foo: bah, zuul_return: {foo: baz} } and others can omit the zuul_return entirely | 18:23 |
clarkb | it should handle that just fine | 18:23 |
corvus | clarkb: and we can search on that? so we can search for "zuul_job:tox-py35 zuul_return.foo:baz" ? | 18:24 |
clarkb | yup should be able to. The one thing where that gets a little weird is you have to tell elasticsearch explicitly about fields that should be glob able | 18:25 |
clarkb | so zuul_return.foo:baz works but zuul_return.foo:baz* won't by default | 18:25 |
clarkb | but in general you want to avoid globs in ES anyway so I don't think that is a major issue | 18:25 |
*** jamesmcarthur has quit IRC | 18:26 | |
corvus | clarkb: cool... that sounds like it's probably the way to go; can you write a quick reply on the change and we'll see what fbo thinks? | 18:26 |
clarkb | yup | 18:26 |
*** electrofelix has quit IRC | 18:29 | |
clarkb | done | 18:31 |
corvus | thanks! | 18:32 |
clarkb | corvus: can you check the most recent comment from zuul on https://review.openstack.org/#/c/634626/14 is that an expected behavior or a bug? | 18:37 |
*** pcaruana has quit IRC | 18:38 | |
*** kmalloc is now known as needscoffee | 18:41 | |
*** raukadah has quit IRC | 18:45 | |
corvus | clarkb: i believe that's expected -- if a nodeset is defined on multiple branches, it must have the same definition on all of them. the solution is to remove the nodeset defn from older branches. | 19:05 |
corvus | clarkb: (there's no branch matching for nodesets, they're just globally defined objects. so the idea that multiple definitions must match is basically to allow users to branch repos without immediately creating config errors by having duplicate definitions. that gives time to remove the definition from the stable branch before modifying it on the master branch) | 19:07 |
corvus | probably a repo like devstack should adopt a policy of removing all nodeset (and secret, if any) definitions immediately after branching | 19:08 |
pabelanger | so, fun fact, prepare-workspace will not delete stale files on remote (static) node. Need to push up a patch that will enable delete args for the synchronize task | 19:37 |
tobiash | pabelanger: you may want to use prepare-workspace-git instead | 19:40 |
pabelanger | yah, should look again to see what the new hotness is | 19:40 |
tobiash | pabelanger: that's using git push and can use cached repos if existing (it handles both existing and not existing cached repos) | 19:41 |
pabelanger | tobiash: sweet! No git cache yet on images, but totally should do it | 19:42 |
*** bhavikdbavishi has quit IRC | 19:42 | |
tobiash | You save roughly half of transfer data even without caching | 19:43 |
tobiash | Because it doesn't transfer the working copy | 19:43 |
pabelanger | nice, that might be my next thing to try, after I can confirm upload-logs-swift is properly working. | 19:45 |
pabelanger | tobiash: have you done much work to setup regional mirrors for OS packages, pip, npm, etc? | 19:49 |
tobiash | We don't have multi region yet, that's something we're working on atm | 19:50 |
pabelanger | Yay, log publishing now working: https://dashboard.zuul.ansible.com/t/ansible/builds | 19:50 |
tobiash | pabelanger: but we're using artifactory and think about a regional dns to inject the right artifactory into the builds | 19:52 |
pabelanger | tobiash: Oh, you can run that locally? | 19:53 |
tobiash | Artifactory? Yes, you can run that locally | 19:53 |
tobiash | And we'll manage our own dns zone that will dispatch the clients to the correct artifactory | 19:54 |
pabelanger | cool | 19:55 |
clarkb | pabelanger: "pulp" is the redhat artifactory alike thing iirc | 19:55 |
tobiash | That way we don't have to handle that for each tool in each build in each tenant | 19:55 |
pabelanger | clarkb: yah, I've used that begore | 19:55 |
pabelanger | before* | 19:55 |
pabelanger | Hmm, ara-report doesn't see happy: https://object-storage-ca-ymq-1.vexxhost.net/v1/a0b4156a37f9453eb4ec7db5422272df/logs/3/3/1fd00dd02d737aa28d73172aa9daba287dd371fa/check/tox-linters/558a7eb/job-output.html#l334 | 19:56 |
pabelanger | can't find ara | 19:56 |
pabelanger | it should be in ansible venv, I am guessing maybe a path issue | 19:56 |
*** yolanda has joined #zuul | 19:58 | |
pabelanger | /usr/local/bin/ara | 20:17 |
pabelanger | that is from an openstack zuul job | 20:17 |
pabelanger | I think that is because ara is pip installed into zuul virtualenv | 20:18 |
pabelanger | trying to confirm | 20:18 |
pabelanger | sorry, not virtualenv | 20:18 |
clarkb | pabelanger: openstack installs ara globally on the executors | 20:18 |
clarkb | then we bind mount that into the bwrap container | 20:19 |
clarkb | (via the mount of /usr) | 20:19 |
pabelanger | yah | 20:19 |
pabelanger | https://opendev.org/openstack-infra/puppet-zuul/src/branch/master/manifests/executor.pp#L53 | 20:19 |
pabelanger | so, I only have ara inside zuul-ansible virtualenvs | 20:19 |
pabelanger | so, think report-ara role needs to be updated to include path to ara | 20:19 |
clarkb | fwiw I think it is reasonable for roles to expect commands be in their path then let operators figure out how they want to get it into the path | 20:20 |
clarkb | (this is the exact problem that PATH is supposed to solve for us) | 20:21 |
pabelanger | yah, this is the same issue we have with tox jobs too, it only looks to default OS path, and if you pip install tox --user, type tox doesn't find it | 20:22 |
clarkb | yes I'm saying that isn't really a bug, instead you should update PATH or put things in PATH as appropriate | 20:22 |
pabelanger | I think with bindep role, we allow for job to allow for path to binary, then role will also use it | 20:22 |
SpamapS | seeing these in my nodepool logs.. not sure how long it's been happening | 20:24 |
SpamapS | /usr/local/lib/python3.7/site-packages/paramiko/kex_ecdh_nist.py:96: CryptographyDeprecationWarning: Support for unsafe construction of public numbers from encoded data will be removed in a future version. Please use EllipticCurvePublicKey.from_encoded_point | 20:24 |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul-jobs master: Allow user to set ara_report_executable https://review.openstack.org/648773 | 20:32 |
*** mrhillsman is now known as mrhillsman_away4 | 20:40 | |
*** mrhillsman_away4 is now known as mrhillsman_wkend | 20:41 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Handle no metadata in zuul artifact items https://review.openstack.org/644428 | 20:43 |
openstackgerrit | James E. Blair proposed zuul/project-config master: Add zuul-publish-tox-docs job https://review.openstack.org/648777 | 20:45 |
*** jamesmcarthur has joined #zuul | 20:45 | |
corvus | SpamapS: i think that's recent, i also just noticed it and haven't looked into it yet. | 20:46 |
corvus | it also appears in zuul unit test logs | 20:46 |
corvus | clarkb: do we pass PATH through from the invocation of the executor? | 20:48 |
pabelanger | yah, I'm struggling a little right now trying to figure out where the virtualenv lives inside brwap for ansible. I don't see any information in the inventory file about it | 20:49 |
corvus | pabelanger: wait, i'm confused -- ara should be inside the ansible venv, and that should be in your path | 20:51 |
pabelanger | corvus: ara is inside my ansible env, but is not in path right now, for some reason | 20:52 |
pabelanger | type ara is failing, in log above | 20:52 |
pabelanger | I think this is because the shell / command task doesn't have the ansible venv path for some reason | 20:52 |
corvus | pabelanger: ok, let's explory why that is -- because i'm 100% certain the solution to this is not for you to encode ara_path=/var/lib/zuul/ansible/venv/2.7/bin/ara into your jobs. | 20:54 |
pabelanger | +1, that would be nice not to do | 20:54 |
pabelanger | I have to prepare food right now, but so far that was the only issue I seen switching to multi-ansible spec | 20:55 |
pabelanger | so, yay | 20:55 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul-sphinx master: Publish docs on release https://review.openstack.org/648779 | 20:57 |
corvus | if folks could review https://review.openstack.org/648775 and https://review.openstack.org/648779 i can enqueue some tags manually to test it out. | 20:58 |
clarkb | corvus: iirc ansible/zuul loads the system path settings | 21:01 |
clarkb | so we could bind mount that in | 21:01 |
corvus | ok, so a) anything outside the venv can be added to PATH by the admin and should be available. b) anything inside the venv should already be there. | 21:01 |
corvus | pabelanger should be in case (b) but it seems there may be a bug there. | 21:02 |
pabelanger | yah, openstacksdk is inside my venv, for upload-logs-switch, and that works as expected. | 21:03 |
pabelanger | so, need to look why shell doesn't see it | 21:03 |
dmsimard | should secrets be included in the job display ? e.g, http://zuul.openstack.org/job/zuul-upload-image has no "docker_credentials" variable or mention of a secret | 21:29 |
*** jamesmcarthur has quit IRC | 21:31 | |
*** jamesmcarthur has joined #zuul | 21:32 | |
*** jamesmcarthur has quit IRC | 21:43 | |
*** jamesmcarthur has joined #zuul | 21:43 | |
*** jamesmcarthur has quit IRC | 21:49 | |
*** jamesmcarthur has joined #zuul | 21:50 | |
*** rlandy has quit IRC | 22:02 | |
*** jamesmcarthur has quit IRC | 22:19 | |
*** needscoffee is now known as kmalloc | 23:53 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!