*** timburke has joined #zuul | 00:00 | |
*** jamesmcarthur has joined #zuul | 00:01 | |
*** mgoddard has quit IRC | 00:06 | |
*** mgoddard has joined #zuul | 00:22 | |
*** rlandy has quit IRC | 00:25 | |
*** jamesmcarthur has quit IRC | 00:31 | |
*** jamesmcarthur has joined #zuul | 00:54 | |
*** jamesmcarthur has quit IRC | 00:58 | |
*** jamesmcarthur has joined #zuul | 01:27 | |
*** jamesmcarthur has quit IRC | 01:34 | |
*** mrhillsman_afk is now known as mrhillsman | 02:10 | |
*** bhavikdbavishi has joined #zuul | 02:33 | |
*** jamesmcarthur has joined #zuul | 02:44 | |
*** jamesmcarthur has quit IRC | 03:04 | |
*** spsurya has joined #zuul | 03:31 | |
*** openstackgerrit has joined #zuul | 03:33 | |
openstackgerrit | Ian Wienand proposed openstack-infra/nodepool master: Add Debian Buster boot tests https://review.openstack.org/649214 | 03:33 |
---|---|---|
*** bjackman has joined #zuul | 03:37 | |
*** jamesmcarthur has joined #zuul | 03:56 | |
*** jamesmcarthur has quit IRC | 03:59 | |
*** jamesmcarthur has joined #zuul | 04:01 | |
*** jamesmcarthur has quit IRC | 04:05 | |
*** jamesmcarthur has joined #zuul | 04:08 | |
*** jamesmcarthur has joined #zuul | 04:08 | |
*** jamesmcarthur has quit IRC | 04:17 | |
*** jamesmcarthur has joined #zuul | 04:18 | |
*** jamesmcarthur has quit IRC | 04:25 | |
*** jamesmcarthur_ has joined #zuul | 04:26 | |
*** jamesmcarthur_ has quit IRC | 04:39 | |
*** jamesmcarthur has joined #zuul | 04:40 | |
*** jamesmcarthur has quit IRC | 04:46 | |
*** pcaruana has joined #zuul | 05:35 | |
*** jamesmcarthur has joined #zuul | 05:41 | |
*** jamesmcarthur has quit IRC | 05:46 | |
*** quiquell|off is now known as quiquell | 05:49 | |
*** jamesmcarthur has joined #zuul | 05:57 | |
*** jamesmcarthur has quit IRC | 06:01 | |
*** openstackgerrit has quit IRC | 06:09 | |
*** jamesmcarthur has joined #zuul | 06:28 | |
*** gtema has joined #zuul | 07:11 | |
*** themroc has joined #zuul | 07:44 | |
*** jpena|off is now known as jpena | 07:58 | |
*** zbr|pto is now known as zbr | 08:23 | |
*** openstackgerrit has joined #zuul | 08:47 | |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Add Authorization Rules configuration https://review.openstack.org/639855 | 08:48 |
*** hashar has joined #zuul | 08:48 | |
*** manjeets has quit IRC | 08:56 | |
*** manjeets has joined #zuul | 08:57 | |
*** manjeets has quit IRC | 09:05 | |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Add Authorization Rules configuration https://review.openstack.org/639855 | 09:28 |
openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Remove TaskManager and just use keystoneauth https://review.openstack.org/640643 | 09:30 |
mordred | tobiash: heads up - we released a new openstacksdk that has the taskmanager removed. if you encounter any issues you may want to pin openstacksdk to <= 0.26.0 | 09:32 |
tobiash | mordred: thanks for the hint, I'll try it in a test environment first :) | 09:32 |
mordred | actually - you know - why don't I push up a <= 0.26.0 patch to nodepool in front of the patch to actually remove taskmanager from nodepool | 09:33 |
*** electrofelix has joined #zuul | 09:34 | |
openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Remove TaskManager and just use keystoneauth https://review.openstack.org/640643 | 09:36 |
openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Pin openstacsksdk to <0.27.0 https://review.openstack.org/649254 | 09:36 |
mordred | tobiash: ^^ maybe that's a safer way to step this one forward | 09:36 |
tobiash | mordred: so 640643 is needed to work with the new openstacksdk? | 09:37 |
mordred | tobiash: I think it SHOULD work fine with new openstacksdk and the stuff in 640643 is mostly just cleanup | 09:38 |
mordred | although the statsd reporting keys will change | 09:38 |
tobiash | ah, ok | 09:38 |
*** manjeets has joined #zuul | 09:38 | |
mordred | as documented in the https://review.openstack.org/#/c/640643/6/releasenotes/notes/task-manager-replaced-12e4b3a0108f9358.yaml | 09:38 |
tobiash | ah ok, I don't care about the reporting keys :) | 09:39 |
mordred | \o/ | 09:40 |
openstackgerrit | Tobias Henkel proposed openstack-infra/nodepool master: WIP: Test Single provider reload https://review.openstack.org/649259 | 09:41 |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: WIP - Pagure driver https://review.openstack.org/604404 | 09:52 |
mordred | fbo: oh cool - all the needed changes have been landed in pagure? | 10:02 |
mordred | fbo: ah - reading the outstanding issues list in https://review.openstack.org/#/c/604404/19/zuul/driver/pagure/pagureconnection.py | 10:05 |
mordred | fbo: I agree, the current blocking issue is an issue for sure | 10:06 |
tristanC | mordred: here is a PoC for the operator we talked about: https://github.com/TristanCacqueray/zuul-operator | 10:08 |
tristanC | mordred: not sure how far you are from the spec, thus i went ahead to start a prototype | 10:09 |
mordred | tristanC: cool! working on the spec is actually my next todo list item - as soon as I stop being sick | 10:11 |
mordred | tristanC: incidentally: https://github.com/operator-framework/operator-lifecycle-manager/blob/master/Documentation/design/building-your-csv.md#required-crds is the relevant docs to read about declaring inter-operator crd dependencies | 10:14 |
mordred | tristanC: so I believe we should be able to use that to pull in the zookeeper crd | 10:15 |
tristanC | oh yes, that's an early poc to test an ansible based reconcile loop | 10:25 |
tristanC | also, adding crd is pretty neat, they are available from the cli and you can do: "oc get zuul" :-) | 10:26 |
*** bhavikdbavishi has quit IRC | 10:30 | |
mordred | tristanC: neat! | 10:35 |
*** yolanda has quit IRC | 10:39 | |
*** gtema has quit IRC | 10:41 | |
bjackman | With my version of Gerrit I am getting some unexpected pipeline triggers. I have "Workflow: 1" in my pipeline.trigger.gerrit.event.approval for a "comment-added" event. But rather than only triggering on comments that _add_ the approval, it seems to trigger for any comment on a change that already has the approval | 10:47 |
bjackman | Could it be that the Gerrit event stream format has changed? | 10:48 |
bjackman | The data received by the driver looks like this: https://paste.gnome.org/pl7l9udi2 | 10:48 |
bjackman | The "approvals" field in the object contains "{'description': 'Workflow', 'type': 'Workflow', 'value': '1'}" even though the comment did not add the Workflow +1 - it was already there | 10:49 |
bjackman | Interestingly it includes the "Code-Review +2" and "Workflow +1" that I added, but does not include the "Verified -2" added by Zuul | 10:50 |
bjackman | Ah yes, looking at the Gerrit docs it seems like Zuul should be checking the "oldValue" field in the approvals to see if the approval was newly created by the comment: https://gerrit-review.googlesource.com/Documentation/json.html#approval | 10:55 |
mordred | bjackman: I'm not an expert in the gerrit event stream - but I know on older gerrit zuul does the right thing for the sequence of events I beleive you are describing | 10:59 |
mordred | tobiash: ^^ does this sound like a gerrit behavior change to you? | 10:59 |
mordred | bjackman: I asumme you're running latest gerrit? | 11:00 |
tobiash | mordred: unfortunately I'm not very familiar with the gerrit event stream anymore as I don't run a recent gerrit myself since quite some time now | 11:01 |
mordred | darn. none of us are running recent gerrit then I guess | 11:02 |
mordred | tobiash: in other news - yay, the "remove taskmanager" patch https://review.openstack.org/#/c/640643/ is green | 11:03 |
tobiash | mordred: cool :) | 11:03 |
*** bjackman has quit IRC | 11:06 | |
sshnaidm|rover | how can I define zuul reconnection retries and timeout? | 11:17 |
*** gtema has joined #zuul | 11:23 | |
*** yolanda has joined #zuul | 11:26 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Add trailing slash for log url https://review.openstack.org/648837 | 11:27 |
*** jpena is now known as jpena|lunch | 11:29 | |
*** bhavikdbavishi has joined #zuul | 11:32 | |
mordred | Shrews: whence you make the awakening, https://review.openstack.org/#/q/topic:task-manager+status:open are just for you! | 12:04 |
*** bhavikdbavishi has quit IRC | 12:09 | |
openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Remove unused use_taskmanager flag https://review.openstack.org/649293 | 12:13 |
openstackgerrit | Monty Taylor proposed openstack-infra/nodepool master: Remove reference to TaskManagerStopped exception https://review.openstack.org/649294 | 12:13 |
*** manjeets has quit IRC | 12:16 | |
*** jamesmcarthur has quit IRC | 12:23 | |
*** jamesmcarthur has joined #zuul | 12:23 | |
*** jpena|lunch is now known as jpena | 12:27 | |
*** jamesmcarthur has quit IRC | 12:33 | |
*** jamesmcarthur has joined #zuul | 12:35 | |
*** rlandy has joined #zuul | 12:39 | |
*** jamesmcarthur has quit IRC | 12:40 | |
*** jamesmcarthur has joined #zuul | 12:44 | |
*** hashar has quit IRC | 12:54 | |
*** quiquell is now known as quiquell|lunch | 13:00 | |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine https://review.openstack.org/640884 | 13:03 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/actions endpoint https://review.openstack.org/641099 | 13:04 |
*** quiquell|lunch is now known as quiquell | 13:24 | |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 13:41 |
*** quiquell is now known as quiquell|off | 14:11 | |
Shrews | mordred: fyi, those changes totally undo ianw's change from https://review.openstack.org/605898 That may or may not be a bad thing???? | 14:14 |
*** smcginnis_pto is now known as smcginnis | 14:16 | |
Shrews | fluctuating back and forth on the stats api is probably not going to be well received | 14:18 |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: WIP - Pagure driver - https://pagure.io/pagure/ https://review.openstack.org/604404 | 14:19 |
corvus | yay! https://zuul-ci.org/docs/zuul-sphinx/0.4.0/ exists | 14:41 |
corvus | i approved a change which will re-exercise the promote job too | 14:43 |
*** hashar has joined #zuul | 14:46 | |
*** gtema has quit IRC | 14:49 | |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: WIP - Pagure driver - https://pagure.io/pagure/ https://review.openstack.org/604404 | 14:50 |
openstackgerrit | Merged openstack-infra/zuul-sphinx master: Raise an error if a file in zuul.d is empty https://review.openstack.org/606062 | 14:50 |
*** yolanda has quit IRC | 14:55 | |
openstackgerrit | James E. Blair proposed zuul/project-config master: Fix docs promote job https://review.openstack.org/649355 | 14:55 |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Add a slide presentation for Zuul Graduation https://review.openstack.org/649356 | 14:55 |
corvus | mordred: ^ quick fix if you have a sec | 14:55 |
mordred | corvus: ^ first draft of graduation slides | 14:55 |
mordred | there are bits I'm sure that are wrong, missing, terrible, etc | 14:55 |
corvus | mordred: \o/ | 14:55 |
corvus | that's gonna be way easier to review when the docs jobs come back :) | 14:56 |
openstackgerrit | Merged zuul/project-config master: Fix docs promote job https://review.openstack.org/649355 | 15:05 |
*** yolanda has joined #zuul | 15:13 | |
mordred | corvus: nah - it doesn't need them: http://logs.openstack.org/56/649356/1/check/zuul-website-build/6d486de/html/graduation/#(1) | 15:15 |
corvus | mordred: sorry, that's what i meant -- when the job reports | 15:17 |
mordred | corvus: ah :) | 15:18 |
clarkb | mordred: quickly skimming through and on the architecture diagram is it accurate that the finger service talks to gearman? I thought it talked directly to the executors over the finger protocol (on a higher port) | 15:20 |
mordred | clarkb: I agree - fwiw, that architecture diagram is actually a direct link to the one from the docs | 15:21 |
clarkb | ++ to using that one and if it needs fixing, fixing it in the docs is a good place :) | 15:22 |
corvus | it talks to gearman to find out which executor to talk to | 15:24 |
clarkb | on the engagement side of things not sure if we want to mention zuul's work with ansible and openlab but those were other examples that came to mind | 15:24 |
clarkb | corvus: ah | 15:24 |
mordred | corvus: oh right. good point | 15:24 |
corvus | clarkb: ++ | 15:24 |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Add web / fingergw connections for components graph https://review.openstack.org/645852 | 15:24 |
*** jamesmcarthur has quit IRC | 15:24 | |
mordred | clarkb: ++ | 15:24 |
*** jamesmcarthur has joined #zuul | 15:25 | |
*** themroc has quit IRC | 15:26 | |
clarkb | one last thought before I find tea: Under the use cases heading would it be useful to call out that zuul is used in a variety of target applications (that is not the right phrase, but basically we use it for open source project development with gerrit, ansible uses github, bmw does it for their internal development and none of this assumes a specific programming language or target deployment platform [openstack | 15:29 |
clarkb | k8s baremetal etc]) | 15:29 |
clarkb | probably something along the lines of "zuul is flexible and tries to avoid assumptions about software being tested and target platforms" | 15:30 |
clarkb | this sets it apart from current trends in the space too imo. As there is a big rush towards all in on containers as an example | 15:30 |
clarkb | which neglects a set of users | 15:31 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine https://review.openstack.org/640884 | 15:32 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 15:33 |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Add database info for components graph https://review.openstack.org/649371 | 15:34 |
pabelanger | ^should give deployers a good map of the required connections needed between zuul services. Was helpful when setting up firewall permissions | 15:35 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 15:37 |
*** jamesmcarthur has quit IRC | 15:44 | |
*** yolanda has quit IRC | 15:46 | |
*** yolanda has joined #zuul | 15:47 | |
*** bhavikdbavishi has joined #zuul | 15:47 | |
mordred | clarkb: ++ | 16:00 |
*** jamesmcarthur has joined #zuul | 16:04 | |
openstackgerrit | Merged openstack-infra/zuul master: Use xterm.js for live log streaming https://review.openstack.org/648838 | 16:04 |
*** hashar has quit IRC | 16:07 | |
pabelanger | tobiash: PgUp / PgDn don't seem to work on ^ now. At one point shift+PgUp / shift+PgDn did. Any idea why? | 16:08 |
pabelanger | I find it helpful to use them to move up and down, without using mouse | 16:08 |
tobiash | pabelanger: is that already live? | 16:09 |
clarkb | the web updates go live after a puppet pulse iirc | 16:09 |
tobiash | pabelanger: I guess it needs the focus | 16:10 |
clarkb | which has not yet happened | 16:10 |
pabelanger | tobiash: I was using zuul-build-dashboard job to validate | 16:10 |
mordred | clarkb: ok. I took a stab at that. | 16:11 |
pabelanger | for example: http://logs.openstack.org/65/648865/3/check/zuul-build-dashboard/4864887/npm/html/stream/15b3cf82b54f46db8bcb4c45b2456c19?logfile=console.log | 16:11 |
pabelanger | oh, guess can link that | 16:11 |
pabelanger | can't* | 16:13 |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Add a slide presentation for Zuul Graduation https://review.openstack.org/649356 | 16:16 |
mordred | clarkb: ^^ included your suggestions and rearranged the use-cases slide a smidge | 16:17 |
clarkb | cool taking a look | 16:17 |
mordred | clarkb: (written in python3 isn't really a use case) | 16:17 |
clarkb | ooh I like the comment about network switches because thats a thing :) | 16:17 |
mordred | clarkb: yah - I just rewrote that line - tell me if you like this better: | 16:19 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Increase timeout of zuul-quick-start https://review.openstack.org/649384 | 16:19 |
*** yolanda has quit IRC | 16:19 | |
mordred | clarkb: http://paste.openstack.org/show/748733/ | 16:19 |
*** jamesmcarthur has quit IRC | 16:21 | |
clarkb | I would list k8s and openshift as different things as they use different drivers. But the rewrite in the paste flows a little better I think | 16:21 |
clarkb | s|/|and| type replacement | 16:21 |
SpamapS | openshift is a superset of k8s, IIRC | 16:25 |
SpamapS | like, they do actually use many of the same underlying API's and python modules | 16:25 |
openstackgerrit | James E. Blair proposed zuul/project-config master: Set a default for docs path templates https://review.openstack.org/649389 | 16:26 |
corvus | clarkb, mordred: ^ is what i'm gathering from this error: http://logs.openstack.org/62/606062/2/promote/zuul-promote-docs/83e4331/ara-report/result/f10d43cd-8cc6-4136-b71a-de035981d39e/ | 16:26 |
*** jamesmcarthur has joined #zuul | 16:27 | |
mordred | SpamapS: it's a superset - but also a stricter execution context - so you really can't assume something that works on k8s will work on openshift | 16:27 |
corvus | (^ *optionally) | 16:27 |
mordred | SpamapS: but also - I believe we use the openshift client library to talk to vanialla k8s because it's better at being a client library | 16:27 |
clarkb | mordred: the kubernetes python lib is gerneated code and openshift lib is built on top of that making it more humanly consumable | 16:28 |
SpamapS | mordred: indeed | 16:28 |
* corvus reviews http://logs.openstack.org/56/649356/2/check/zuul-website-build/37f4b4d/html/graduation | 16:28 | |
SpamapS | I've been kind of stuck with the kubernetes driver... but I'm hoping to poke at it more this week. | 16:29 |
mordred | actually - how about I remove OpenShift from the line - that's an impl detail - I think kuberenetes is sufficient to explain COE without having to explain what a COE is to board members | 16:29 |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Add a slide presentation for Zuul Graduation https://review.openstack.org/649356 | 16:30 |
corvus | mordred: on slide 5 you mention cloud provider drivers for openstack and aws; should k8s be there? | 16:31 |
Shrews | and static nodes? | 16:31 |
corvus | ++ | 16:32 |
mordred | ++ | 16:32 |
openstackgerrit | Monty Taylor proposed openstack-infra/zuul-website master: Add a slide presentation for Zuul Graduation https://review.openstack.org/649356 | 16:33 |
pabelanger | I have a few patches out for components diagram update, so far: http://logs.openstack.org/71/649371/1/check/tox-docs/5aec25a/html/admin/components.html is the latest version. If we wanted more moving bits for that slide. | 16:33 |
corvus | mordred: looks good! i'd vote for us. :) | 16:34 |
mordred | corvus: yay! | 16:35 |
mordred | pabelanger: I like the updated diagram | 16:35 |
mordred | pabelanger: although nodepool also talks to statsd | 16:35 |
pabelanger | mordred: yah, I didn't include nodepool bits, as we likely want to split into nodepool-launcher / nodepool-builder | 16:36 |
pabelanger | but if we want that, we can totally do | 16:36 |
mordred | good point. as it's in a single bubble, yeah - leaving it like that makes maybe more sense | 16:36 |
mordred | I wish there was a graphviz shape that could be used to indicate "this is a scale-out component so there are potentially many of this type" | 16:39 |
pabelanger | YES! | 16:39 |
pabelanger | that would be awesome | 16:39 |
mordred | but none of the existing ones listed on https://www.graphviz.org/doc/info/shapes.html would do that without some sort of explanation | 16:39 |
corvus | we could switch to blockdiag: http://blockdiag.com/en/blockdiag/examples.html#shape-of-nodes | 16:40 |
corvus | it has 'stacked' which i think would work | 16:40 |
corvus | http://blockdiag.com/en/blockdiag/examples.html#using-stacked-attribute | 16:40 |
corvus | we use blockdiag elsewhere in the manual; i think that diagram is the only place we use graphviz | 16:40 |
mordred | yeah- stacked is the thing my brain wants | 16:41 |
mordred | we could also just make an eps file with a stacked box in it | 16:41 |
corvus | is that easier than switching to blockdiag? | 16:41 |
mordred | if we didn't want to switch that diagram from graphviz to blockdiag | 16:41 |
mordred | I don't know - you're the main person I know who can write eps by hand | 16:41 |
corvus | oh, it also has dots: http://blockdiag.com/en/blockdiag/examples.html#using-dots-shape | 16:41 |
mordred | corvus: switching to blockdiag doesn't look like it would be super harder | 16:42 |
pabelanger | +1 I can push up a patch if we want to see what it looks like | 16:44 |
corvus | 0 0 10 10 rectstroke 2 2 10 10 rectstroke 1 setgray 4 4 10 10 rectfill 0 setgray 4 4 10 10 rectfill | 16:44 |
corvus | or something like that :) | 16:45 |
clarkb | mordred: seems like the presentation lacks an ending | 16:50 |
clarkb | maybe future goals | 16:51 |
mordred | clarkb: do we have any other than "take over the world"? | 16:51 |
corvus | hrm, is future goals what the board is looking for? i thought this was more retrospective | 16:51 |
clarkb | corvus: I think it is mostly retrospective. Just trying to come up with some way to send it off | 16:52 |
clarkb | https://wiki.openstack.org/w/index.php?title=Governance/Foundation/OSFProjectConfirmationGuidelines are the guidelines which I am not rereading | 16:52 |
clarkb | future goals might be best captured under strategic focus under those guidelines | 16:53 |
*** jamesmcarthur_ has joined #zuul | 16:53 | |
corvus | could send it off with links to website, etc | 16:54 |
clarkb | *now rereading | 16:54 |
corvus | or find something to summarize | 16:55 |
corvus | clarkb, mordred: also remember this exists: https://zuul-ci.org/media/zuul_solution_brief.pdf | 16:56 |
*** jamesmcarthur has quit IRC | 16:57 | |
corvus | mordred: you should set the <title> | 16:57 |
mordred | corvus: I should set the title | 16:59 |
clarkb | corvus: ya a "find us at $locations" bookend slide might work best given the guidelines | 17:00 |
clarkb | we should stay focused on the areas they are interested in | 17:00 |
clarkb | or a "questions" bookend | 17:00 |
clarkb | though given historical board meetings I expect they will just interrupt and ask quetsions as we go | 17:01 |
openstackgerrit | Merged zuul/project-config master: Set a default for docs path templates https://review.openstack.org/649389 | 17:02 |
fungi | speaking of zuul's impending oip confirmation (i left a couple comments on the current deck patchset btw), here is the raw feedback from the openstack community the tc will be working into a foundation ml post to fulfil its obligation to the board with providing input on oip confirmation applications: https://etherpad.openstack.org/p/openstack-tc-zuul-confirmation-feedback | 17:11 |
fungi | in summary, it's overwhelmingly positive | 17:12 |
fungi | (we requested input from the whole openstack community, but in the end it was mostly just tc members providing feedback on the zuul confirmation, we had a few more non-tc folks weigh in on the kata confirmation feedback etherpad) | 17:14 |
openstackgerrit | Merged openstack-infra/zuul master: Add search function to web streaming https://review.openstack.org/648862 | 17:18 |
*** jamesmcarthur_ has quit IRC | 17:28 | |
*** jpena is now known as jpena|off | 17:28 | |
corvus | yay! https://zuul-ci.org/docs/zuul-sphinx/.root-marker is correct | 17:34 |
pabelanger | corvus: clarkb: so, I was able to reproduce ara issue running ansible-playbook from ./venv/bin/ansible-playbook locally, PATH did not include venv/bin. | 17:37 |
pabelanger | I don't see any logic to add that in zuul-executor | 17:37 |
corvus | tobiash: ^ do you have thoughts on this? istr that we're including ara in the virtualenvs, but it looks like the virtualenv doesn't end up in the path | 17:38 |
mordred | corvus, clarkb, fungi: I'm done hacking for the day - so if anyone wants to make updates to the slides directly, please feel free to push up new changes - my feelings will certainly not be hurt | 17:46 |
mordred | oh - we should also add jimmy as a co-authored-by - he did all of the css and the first pass at those which I then imported and edited - would be remiss to not credit him | 17:46 |
fungi | thanks mordred! and i wish you a swift recovery from your travel plague | 17:46 |
mordred | fungi: my travel plague shakes its fists at you - but I thank you | 17:46 |
clarkb | I guess the gear install works via python path not path path? | 17:58 |
*** bhavikdbavishi has quit IRC | 17:58 | |
*** gtema has joined #zuul | 17:59 | |
corvus | clarkb: yeah, i don't think we run any gear binaries | 17:59 |
SpamapS | heh.. so.. I just noticed.. I think for the second time but I forgot last time.. the aws driver completely ignores max-servers | 18:01 |
tobiash | corvus: the virtualenv normally is in the path, but it might be because of the localhost connection of ansible | 18:06 |
tobiash | corvus: we don't set ansible_python_interpreter for localhost do we? | 18:08 |
tobiash | corvus: I can reproduce that locally by creating a virtualenv with ansible and ara and running './ansible/bin/ansible localhost -m shell -a ara' | 18:10 |
tobiash | corvus: looks like the path is only set if the virtualenv is getting activated | 18:12 |
pabelanger | mordred: Shrews: happen to notice this traceback from nodepool today: http://paste.openstack.org/show/748735/ any thoughts? | 18:12 |
tobiash | corvus: so one easy fix could be to just add the dir containing the ansible executable to the path of the ansible process | 18:12 |
tobiash | that's exactly what happens when the virtualenv gets activated | 18:13 |
corvus | tobiash: that sounds reasonable | 18:14 |
pabelanger | +1 | 18:14 |
tobiash | virtualenv prepends the path, I'll prepare a change that does the same | 18:15 |
tobiash | confirmed that this works: PATH=`pwd`/ansible/bin:$PATH ./ansible/bin/ansible localhost -m shell -a ara | 18:16 |
tobiash | so that will work | 18:16 |
Shrews | pabelanger: uh, hrm. that's odd | 18:17 |
pabelanger | tobiash: yah, that was my workaround locally too | 18:18 |
*** electrofelix has quit IRC | 18:18 | |
*** rlandy is now known as rlandy|brb | 18:19 | |
openstackgerrit | Paul Belanger proposed openstack-infra/zuul master: Add database info for components graph https://review.openstack.org/649371 | 18:20 |
Shrews | pabelanger: unfortunately, nothing springs to mind as to what could be happening there | 18:22 |
pabelanger | Shrews: k, will keep an eye out for it. I've deleted instances manually to silence the exception for now | 18:23 |
SpamapS | oh fun, and I also think the aws driver doesn't actually respect the region passed in via the provider config | 18:30 |
SpamapS | seems it uses the .aws/config file only | 18:30 |
*** spsurya has quit IRC | 18:32 | |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Fix AWS provider ignoring region in providers https://review.openstack.org/649423 | 18:36 |
*** rlandy|brb is now known as rlandy | 18:36 | |
*** gtema has quit IRC | 18:40 | |
Shrews | SpamapS: maybe a new test for that ^^? you can use pool.getProviderManager() to get at that object | 18:44 |
SpamapS | Doesn't fix the problem anyway. :( | 18:45 |
fungi | in light of mordred's earlier comments in here, any objection to me pushing an update to the zuul confirmation slide deck change addressing my comments and adding jimmy as a co-author? | 18:46 |
SpamapS | another weird thing is that the driver is choosing an explicit availability zone, even though it never actually mentions availability zones. Makes me think this may be a boto3 bug | 18:47 |
openstackgerrit | Nicolas Hicher proposed openstack-infra/zuul-jobs master: Propose submit-logstash role to export logs https://review.openstack.org/649426 | 18:48 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Prepend path with bin dir of ansible virtualenv https://review.openstack.org/649427 | 18:48 |
tobiash | corvus, pabelanger: ^ | 18:48 |
corvus | fungi: sounds good | 18:50 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: Cleanup executor specific requirements https://review.openstack.org/649428 | 18:50 |
pabelanger | tobiash: that should mean openstack-infra, which installs ara globally on executor, now pick it up from virtualenv. | 18:52 |
pabelanger | clarkb: ^ | 18:52 |
tobiash | pabelanger: yes, I'd expect that to happen | 18:52 |
clarkb | I think we've carefully controlled the ara version but I'm not sure that matters? Then we could clean up our puppet for that | 18:53 |
tobiash | clarkb: did you carefully control it in puppet or as a zuul requirement in the past? | 18:53 |
clarkb | tobiash: its in puppet let me dig it up | 18:54 |
clarkb | I don't think it is necessary though | 18:54 |
clarkb | https://git.openstack.org/cgit/openstack-infra/puppet-zuul/tree/manifests/executor.pp#n53 its that nasty exec. And actually we install latest ara just not latest everything else | 18:54 |
clarkb | so ya this chagne should be totally fine | 18:54 |
tobiash | corvus: responded on 649384 | 19:01 |
corvus | tobiash: ++ | 19:02 |
tobiash | corvus: we throw the builder image away right? So we could copy in the correct proxy config without having to worry about contaminating the final image? | 19:05 |
pabelanger | could I get a review on https://review.openstack.org/648815/ to update prepare-workspace for static nodes? I've included log file to downstream testing | 19:07 |
corvus | tobiash: yes, though we do install packages in the final image too (bubblewrap) | 19:07 |
tobiash | hrm, ok, so we don't have to worry about that in the builder step and need to find a proper solution in the final step | 19:08 |
pabelanger | tobiash: SpamapS: how have you setup your database for zuul? Are you doing any sort of HA with it today, if so, what components are you using? Currently, I just have a single db server running and trying to see steps to maybe to HA without tomuch down the rabbit hole | 19:13 |
pabelanger | my current cloud doesn't offer dbaas | 19:13 |
tobiash | pabelanger: I offloaded that to the database department so I don't have to worry about that | 19:13 |
tobiash | because yes, HA database is hard and you need to know what you're doing | 19:14 |
tobiash | and I don't | 19:14 |
pabelanger | ++ | 19:14 |
tobiash | (at least for databases ;) ) | 19:14 |
pabelanger | yah, so far zookeeper hasn't been terrible. It just works. | 19:15 |
pabelanger | (HA) | 19:15 |
tobiash | yeah, because it has HA builtin | 19:15 |
tobiash | that's not the case for traditional sql databases where you need to deal with replication, failover, recovery... | 19:16 |
tobiash | pabelanger: maybe you want to try this one: https://www.cockroachlabs.com/ | 19:16 |
tobiash | cloud native ha containerized sql database | 19:16 |
tobiash | and supports the postgres wire format | 19:16 |
pabelanger | tobiash: thanks, will find some time to test it out | 19:18 |
tobiash | that could be the 'just works' solution if it works good | 19:18 |
pabelanger | yah | 19:18 |
clarkb | does zuul gracefully degrade if the db is down? | 19:19 |
pabelanger | good question | 19:20 |
*** gtema has joined #zuul | 19:23 | |
SpamapS | pabelanger: I'm using AWS RDS, with no HA. We just back it up and if it goes down we'll restore from snap and move on. | 19:24 |
SpamapS | clarkb: I don't think it does. | 19:24 |
SpamapS | I think scheduler keeps working, and running jobs tho | 19:25 |
SpamapS | just throws exceptions | 19:25 |
SpamapS | so .. maybe sort of gracefully | 19:25 |
tobiash | corvus: is debian mirrored completely in your infrastructure? looking at http://mirror.sjc1.vexxhost.openstack.org/debian/dists/stretch/ this is missing the signature of the Release file compared to http://ftp.debian.org/debian/dists/stretch/ | 19:26 |
pabelanger | tobiash: it isn't a 100% mirror, we dont' sign artifacts because we keep some packages a few hours longer before removing. The window is about 4 hours behind upstream, in an effort to not break runnings jobs. | 19:27 |
tobiash | pabelanger: apt-get complains about the missing signature: W: The repository 'http://mirror.sjc1.vexxhost.openstack.org/debian stretch Release' is not signed. | 19:28 |
pabelanger | tobiash: yah, we need to disable signed packages | 19:29 |
pabelanger | where do you see that? | 19:29 |
tobiash | trying locally to add the mirrors to the docker image build | 19:29 |
clarkb | correct we use reprepro to build a new repository instead of mirroring directly. The reason for this is deb mirrors are updated in a manner that breaks clients often | 19:29 |
clarkb | so instead we build a working repo then publish it via afs only when it is viable | 19:29 |
*** gtema has quit IRC | 19:29 | |
pabelanger | tobiash: http://git.zuul-ci.org/cgit/zuul-jobs/tree/roles/configure-mirrors/templates/etc/apt/apt.conf.d/99unauthenticated.j2 | 19:30 |
pabelanger | that is what we set on all nodes | 19:30 |
pabelanger | you'll have to do the same | 19:30 |
pabelanger | (all test nodes) | 19:30 |
pabelanger | clarkb: what was the tool your bother created again, in an attempt to fix this issue? | 19:31 |
clarkb | https://github.com/squidboylan/apt-package-mirror | 19:32 |
*** ianychoi has quit IRC | 19:32 | |
pabelanger | thanks | 19:32 |
*** ianychoi has joined #zuul | 19:33 | |
SpamapS | BTW... | 19:34 |
SpamapS | apt has been fixed | 19:34 |
tobiash | pabelanger: thanks, that seems to do the trick | 19:34 |
SpamapS | newer versions do not have the cache expiration bug that old versions had | 19:34 |
clarkb | SpamapS: ya you need bionic though iirc | 19:35 |
clarkb | xenial isn't new enough. So soon we may have a better story there (openstack still using a lot of xenial) | 19:35 |
tobiash | pabelanger, clarkb: how do other openstack projects publish docker images? I don't feel very comfortable installing unsigned packages into official images. | 19:35 |
clarkb | tobiash: many of them don't use our mirrors to build the images | 19:36 |
SpamapS | probably in a year or so | 19:36 |
SpamapS | right? :) | 19:36 |
tobiash | ok, so we might want two variants, one that uses the mirror which is used for zuul-quick-start and one that doesn't use the mirrors in the gate (zuul-build-images)? | 19:37 |
SpamapS | Ok I was wrong, boto wasn't choosing an AZ for me. I forgot I had an explicit VPC/subnet and the subnet was AZ specific. | 19:37 |
pabelanger | tobiash: yah, I wouldn't want to use our mirrors for production builds | 19:44 |
pabelanger | SpamapS: is that fix in bionic? | 19:44 |
pabelanger | wowo | 19:46 |
pabelanger | woah* | 19:46 |
pabelanger | new xterm.js is live on zuul.o.o | 19:46 |
mhu | what does it do? | 19:47 |
pabelanger | mhu: faster loading of logs | 19:47 |
mhu | sweet! | 19:47 |
mhu | I'll put it to the test right now! | 19:48 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine https://review.openstack.org/640884 | 19:48 |
*** hashar has joined #zuul | 19:49 | |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 19:50 |
daniel2 | When you specify multiple targets in nodepool, such as 2 jenkins servers, how do you specify where to launch the nodes? | 19:50 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 19:52 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 19:53 |
pabelanger | daniel2: usually you kept all your jenkins in sync, so jobs could run on any of them, using something like JJB. | 19:56 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 19:56 |
daniel2 | pabelanger: the nodes should show up as available on both jenkins then I am assuming? | 19:57 |
pabelanger | daniel2: nodepool would dynamically attach a node to any one of the jenkins master you had configured. No 2 masters would have the same single node. | 19:59 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions https://review.openstack.org/576907 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Allow operator to generate auth tokens through the CLI https://review.openstack.org/636197 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Zuul CLI: allow access via REST https://review.openstack.org/636315 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Add Authorization Rules configuration https://review.openstack.org/639855 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] Web: plug the authorization engine https://review.openstack.org/640884 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/actions endpoint https://review.openstack.org/641099 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 20:01 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] admin REST API: docker-compose PoC, frontend https://review.openstack.org/643536 | 20:01 |
mhu | woops | 20:01 |
mhu | what's the easiest way to return to a previous patchset? | 20:02 |
daniel2 | pabelanger: can we specify availability per target? | 20:03 |
pabelanger | daniel2: IIRC, no. | 20:03 |
pabelanger | daniel2: http://git.zuul-ci.org/cgit/nodepool/tree/doc/source/configuration.rst?h=0.5.0#n563 | 20:04 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: web: add tenant and project scoped, JWT-protected actions https://review.openstack.org/576907 | 20:05 |
daniel2 | okay thanks | 20:05 |
clarkb | mhu: Gerrit enforces that the most recent patchset be the one that can merge. So you have to checkout and repush older patchsets if you want them | 20:06 |
mhu | clarkb, that's what I was afraid of, thanks | 20:06 |
pabelanger | daniel2: with zuul 3.0, we do support executor zones: https://zuul-ci.org/docs/zuul/admin/components.html#attr-executor.zone | 20:08 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Allow operator to generate auth tokens through the CLI https://review.openstack.org/636197 | 20:08 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul CLI: allow access via REST https://review.openstack.org/636315 | 20:10 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Add Authorization Rules configuration https://review.openstack.org/639855 | 20:11 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Web: plug the authorization engine https://review.openstack.org/640884 | 20:12 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: Zuul Web: add /api/user/authorizations endpoint https://review.openstack.org/641099 | 20:12 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: authentication config: add optional token_expiry https://review.openstack.org/642408 | 20:13 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] admin REST API: docker-compose PoC, frontend https://review.openstack.org/643536 | 20:14 |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: A reporter for Elasticsearch with the capability to index build and buildset results in an index. https://review.openstack.org/644927 | 20:16 |
openstackgerrit | Merged openstack-infra/zuul master: Document how to run eslint locally https://review.openstack.org/648855 | 20:16 |
openstackgerrit | Fabien Boucher proposed openstack-infra/zuul master: A reporter for Elasticsearch with the capability to index build and buildset results in an index. https://review.openstack.org/644927 | 20:17 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: WIP: Use mirror infrastructure during zuul-quick-start https://review.openstack.org/649448 | 20:18 |
openstackgerrit | Tobias Henkel proposed openstack-infra/zuul master: WIP: Use mirror infrastructure during zuul-quick-start https://review.openstack.org/649448 | 20:21 |
openstackgerrit | Jeremy Stanley proposed openstack-infra/zuul-website master: Add a slide presentation for Zuul Graduation https://review.openstack.org/649356 | 20:22 |
openstackgerrit | Jeremy Stanley proposed openstack-infra/zuul-website master: Slide presentation for Zuul's OIP Confirmation https://review.openstack.org/649356 | 20:26 |
*** pcaruana has quit IRC | 20:30 | |
*** jamesmcarthur has joined #zuul | 20:47 | |
*** jamesmcarthur has joined #zuul | 20:47 | |
*** adam_g has quit IRC | 20:53 | |
corvus | tobiash, mordred, tristanC: oops: https://review.openstack.org/609366 | 21:02 |
tobiash | oops, sorry tristanC | 21:04 |
*** jamesmcarthur has quit IRC | 21:19 | |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Add parameter to upload-git-mirror to specify ssh host key https://review.openstack.org/649033 | 21:22 |
openstackgerrit | Nicolas Hicher proposed openstack-infra/zuul-jobs master: Propose submit-logstash role to export logs https://review.openstack.org/649426 | 21:24 |
corvus | fungi: thanks for sprinkling those periods on the confirmation presentation; i was about to do that myself :) | 21:27 |
fungi | heh, i held back on some of my more nit-picky tendencies | 21:29 |
fungi | but figured at least consistent punctuation was worth having | 21:30 |
openstackgerrit | Tim Burke proposed openstack-infra/zuul-jobs master: Exclude linux_x86_64 wheels from upload to PyPI https://review.openstack.org/649455 | 21:32 |
fungi | that's ^ a problem we spotted in #openstack-release a couple hours ago | 21:34 |
fungi | (or rather a possible fix to a problem we spotted) | 21:34 |
openstackgerrit | Matthieu Huin proposed openstack-infra/zuul master: [WIP] admin REST API: docker-compose PoC, frontend https://review.openstack.org/643536 | 21:38 |
*** jamesmcarthur has joined #zuul | 21:45 | |
*** hashar has quit IRC | 21:46 | |
*** jamesmcarthur has quit IRC | 21:50 | |
openstackgerrit | James E. Blair proposed openstack-infra/zuul-sphinx master: Run opendev-release-python on release https://review.openstack.org/649456 | 21:54 |
corvus | mhu: that change reminds me that we need to upgrade zuul's docker jobs to the new system which respects depends-on | 21:55 |
corvus | mhu: i'll do that real quick, then your stack should be fully self-testing without needing to modify build contexts | 21:56 |
corvus | mhu: oh, er, actually i'm a little confused -- the quick-start job always builds all the images from scratch... so why are you setting the build attribute in docker-compose? | 22:02 |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Exclude linux_x86_64 wheels from upload to PyPI https://review.openstack.org/649455 | 22:19 |
*** jamesmcarthur has joined #zuul | 22:25 | |
openstackgerrit | James E. Blair proposed openstack-infra/nodepool master: Use opendev docker jobs https://review.openstack.org/649465 | 22:28 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Use opendev docker jobs https://review.openstack.org/649466 | 22:28 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Use the buildset registry in zuul-quick-start https://review.openstack.org/649467 | 22:28 |
openstackgerrit | James E. Blair proposed openstack-infra/nodepool master: Use the buildset registry in zuul-quick-start https://review.openstack.org/649468 | 22:30 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul master: Use the buildset registry in zuul-quick-start https://review.openstack.org/649467 | 22:31 |
*** rlandy has quit IRC | 22:49 | |
*** jamesmcarthur has quit IRC | 22:50 | |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Implement max-servers for AWS driver https://review.openstack.org/649474 | 23:02 |
SpamapS | FYI ^^ I had a *really* hard time getting any tests to work | 23:02 |
SpamapS | I don't really understand the way zk works with unit tests | 23:02 |
SpamapS | Shrews: ^ maybe you can explain to me how we could test that the quota bits work there? | 23:03 |
corvus | SpamapS: i think you have to have a zk running (could be in a docker image) | 23:05 |
corvus | i think stephenfin has started some tox-docker changes to make that easier | 23:05 |
corvus | https://review.openstack.org/649041 not ready for prime time | 23:06 |
SpamapS | I have zk running | 23:12 |
SpamapS | what happens is, if I add a second request, nothing ever handles it. It remains in 'pending' state forever. | 23:13 |
SpamapS | And I don't know if that's just normal.. or there's something I have to kick to make the provider handle it.. or what | 23:13 |
SpamapS | I was thinking I'd like to test adding a node that would push things over quota and making sure it got rejected by the provider. | 23:14 |
*** jamesmcarthur has joined #zuul | 23:14 | |
SpamapS | TO do that I need one active request with a node, so the second one would see 1 running, with a max-servers of 1, and in theory.. the provider would reject it. But instead it just stays pending forever. | 23:15 |
corvus | SpamapS: oh sorry, i misunderstood | 23:17 |
SpamapS | oh wait.. hm | 23:18 |
corvus | SpamapS: i would expect a test like you describe to work | 23:18 |
SpamapS | reading the actual code | 23:18 |
SpamapS | We dont' reject when hasRemainingQuota returns false | 23:18 |
SpamapS | we "pause" | 23:18 |
SpamapS | and that seems to be an internal only state, so the test will have to peek inside NodeRequestHandler to verify that | 23:20 |
SpamapS | corvus: I think you were just my rubber ducky | 23:20 |
openstackgerrit | James E. Blair proposed openstack-infra/zuul-jobs master: Fix error in pull-from-intermediate-registry https://review.openstack.org/649475 | 23:22 |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack-infra/nodepool master: Implement max-servers for AWS driver https://review.openstack.org/649474 | 23:38 |
SpamapS | corvus: indeed, quack has been the knack.. ^^ now with test coverage! | 23:38 |
openstackgerrit | Merged openstack-infra/zuul-jobs master: Fix error in pull-from-intermediate-registry https://review.openstack.org/649475 | 23:39 |
corvus | SpamapS: quack i could quack! | 23:41 |
*** jamesmcarthur has quit IRC | 23:43 | |
*** jamesmcarthur has joined #zuul | 23:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!