| *** mattw4 has quit IRC | 00:23 | |
| *** saneax has joined #zuul | 00:23 | |
| *** michael-beaver has quit IRC | 00:40 | |
| *** saneax has quit IRC | 01:03 | |
| *** rfolco has quit IRC | 01:41 | |
| *** jamesmcarthur has joined #zuul | 01:48 | |
| *** spsurya has joined #zuul | 02:18 | |
| *** jamesmcarthur has quit IRC | 02:30 | |
| *** rlandy|bbl has quit IRC | 03:12 | |
| *** saneax has joined #zuul | 03:28 | |
| *** igordc has quit IRC | 03:31 | |
| *** saneax has quit IRC | 03:33 | |
| *** bolg has joined #zuul | 03:55 | |
| *** snapiri has joined #zuul | 04:19 | |
| *** igordc has joined #zuul | 04:44 | |
| openstackgerrit | Merged zuul/zuul master: Web: rely on new attributes when determining task failure https://review.opendev.org/680498 | 05:28 |
|---|---|---|
| *** bjackman has joined #zuul | 05:31 | |
| *** raukadah is now known as chandankumar | 05:34 | |
| *** pots has quit IRC | 05:42 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: [wip] Test and expand documentation for executor-only jobs https://review.opendev.org/679184 | 06:00 |
| *** saneax has joined #zuul | 06:02 | |
| *** bolg has quit IRC | 06:43 | |
| *** bogdando has joined #zuul | 06:52 | |
| *** igordc has quit IRC | 07:00 | |
| *** themroc has joined #zuul | 07:01 | |
| *** threestrands has quit IRC | 07:20 | |
| *** bolg has joined #zuul | 07:24 | |
| *** jpena|off is now known as jpena | 07:33 | |
| bogdando | Shrews: hi, the issue I was mentioning y-day is the same that rlandy reported in http://eavesdrop.openstack.org/irclogs/%23zuul/%23zuul.2018-12-06.log.html | 07:49 |
| bogdando | at 15:28 | 07:50 |
| *** hashar has joined #zuul | 07:50 | |
| bogdando | bringing up the 2nd interface on subnode and make it running with IPv4 didn't help as well, clarkb ^^ | 07:50 |
| bogdando | so I'm not sure where to do that set_fact on hostvars[groups['switch'][0]]['nodepool']['private_ipv4'] | 07:51 |
| *** bolg has quit IRC | 07:51 | |
| bogdando | mordred: hi, around? | 07:57 |
| bogdando | https://opendev.org/zuul/zuul-jobs/commit/9853d3608f89cec205dd46ec0197fbad09c18ae8 seems changed nothing as I'm observing the same private_ipv4: null issue | 07:58 |
| *** jangutter has joined #zuul | 07:58 | |
| bogdando | the logs snippet from executor http://paste.openstack.org/show/oA9T77WOHF4ZqVJ8obvh/ | 08:00 |
| *** bolg has joined #zuul | 08:07 | |
| bogdando | tristanC: hi, around? | 08:08 |
| *** AJaeger has quit IRC | 08:17 | |
| *** panda|rover has quit IRC | 08:23 | |
| *** panda has joined #zuul | 08:24 | |
| *** sshnaidm|afk is now known as sshnaidm|ruck | 08:37 | |
| *** mhu has joined #zuul | 08:43 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix delegating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 08:49 |
| bogdando | if I add a depends on https://review.opendev.org/#/c/681182 for my patch under local testing, would it work?.. | 08:51 |
| bogdando | or shall I reinstall zuul with it somehow? | 08:51 |
| *** rfolco has joined #zuul | 09:14 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix delegating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 09:50 |
| *** avass has joined #zuul | 09:52 | |
| *** bolg has quit IRC | 09:53 | |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure - handle Pull Request tags (labels) metadata https://review.opendev.org/681050 | 09:59 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure - handle initial comment change event https://review.opendev.org/680310 | 10:06 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure - handle Pull Request tags (labels) metadata https://review.opendev.org/681050 | 10:12 |
| *** bolg has joined #zuul | 10:13 | |
| *** hashar has quit IRC | 10:25 | |
| *** AJaeger has joined #zuul | 10:43 | |
| *** jpena is now known as jpena|lunch | 10:59 | |
| *** hashar has joined #zuul | 11:40 | |
| tristanC | bogdando: hello | 11:45 |
| *** jamesmcarthur has joined #zuul | 11:54 | |
| *** jamesmcarthur has quit IRC | 12:08 | |
| *** jpena|lunch is now known as jpena | 12:10 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 12:10 |
| bogdando | tristanC: hi | 12:12 |
| bogdando | tristanC: I think I have found the root cause for the empty private_ipv4 couldn't fallback to the public IP | 12:13 |
| bogdando | testing https://review.opendev.org/681182 | 12:13 |
| *** jamesmcarthur has joined #zuul | 12:13 | |
| bogdando | please don't ask me how come it gets '\n'. historically?.. see comments for https://review.opendev.org/#/q/I32fb17bae98f13f735da4d5b9a6a01e948f21678 | 12:14 |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 12:19 |
| *** rlandy has joined #zuul | 12:23 | |
| *** jamesmcarthur has quit IRC | 12:24 | |
| *** jamesmcarthur has joined #zuul | 12:26 | |
| openstackgerrit | Andy Ladjadj proposed zuul/zuul master: Fix: prevent usage of hashi_vault https://review.opendev.org/681041 | 12:28 |
| *** jamesmcarthur has quit IRC | 12:29 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 12:48 |
| Shrews | bogdando: is using that role even necessary? can't you just use the proper networking type between your vms to allow them to talk to each other? | 12:51 |
| bogdando | Shrews: great question | 12:52 |
| bogdando | I have no idea as only learning all those things | 12:52 |
| bogdando | my current goal is to have an upstream job reproduced locally | 12:54 |
| bogdando | with a fancy reproduce script tripleo devops crafted | 12:54 |
| openstackgerrit | Andy Ladjadj proposed zuul/zuul master: Fix: prevent usage of hashi_vault https://review.opendev.org/681041 | 12:54 |
| bogdando | that happend I have to debug zuul et all a little bit for that | 12:55 |
| *** AJaeger has quit IRC | 12:55 | |
| *** bolg has quit IRC | 13:07 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 13:16 |
| pabelanger | bogdando: that to me feels like a issue with nodepool^. Why are we passing \n into the inventory? | 13:21 |
| bogdando | pabelanger: yes, that looks hairy | 13:22 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure - reference pipelines add open: True requirement https://review.opendev.org/681252 | 13:22 |
| bogdando | the original change although mentions that is was the current behavior as of that time | 13:22 |
| bogdando | meaning https://review.opendev.org/#/c/623294/ | 13:23 |
| pabelanger | bogdando: you could also strip values at https://opendev.org/zuul/zuul/src/branch/master/zuul/executor/server.py#L1360 but nodepool update is likely better | 13:24 |
| bogdando | pabelanger: thanks for the pointer! | 13:24 |
| bogdando | I love the way I can add the dependency changes live and see how infrastructure tests itself | 13:25 |
| *** AJaeger has joined #zuul | 13:46 | |
| *** roman_g has joined #zuul | 14:15 | |
| *** avass has quit IRC | 14:19 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul master: Normalize/alias nodepool inventory IPs in executor https://review.opendev.org/681273 | 14:28 |
| clarkb | bogdando: on the role side you might want to use the ipv4 filter and set it to public v4 if private v4 fails the ipv4 filyer test | 14:30 |
| *** ianychoi_ is now known as ianychoi | 14:37 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul master: Normalize/alias nodepool inventory IPs in executor https://review.opendev.org/681273 | 14:37 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: spec: add a zuul-runner cli https://review.opendev.org/681277 | 14:40 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add support for the Gerrit checks plugin https://review.opendev.org/680778 | 14:42 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add no-jobs reporter action https://review.opendev.org/681278 | 14:42 |
| clarkb | pabelanger: bogdando see my comments on https://review.opendev.org/#/c/681182/6 I don't think that change should be abandoned | 14:44 |
| bogdando | clarkb: thanks | 14:44 |
| clarkb | pabelanger: bogdando I think we fix nodepool, but because we can't control what version of nodepool people use with that role we should have belts and suspenders in the role too | 14:44 |
| *** jamesmcarthur has joined #zuul | 14:47 | |
| pabelanger | sure, maybe we need a better filter, checking for \n and \\n felt ugly | 14:48 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure - handles pull-request.closed event https://review.opendev.org/681279 | 14:49 |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 14:50 |
| *** themroc has quit IRC | 14:58 | |
| *** spsurya has quit IRC | 15:05 | |
| openstackgerrit | Merged zuul/zuul master: Overriding max. starting builds. https://review.opendev.org/670461 | 15:05 |
| *** saneax has quit IRC | 15:14 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 15:16 |
| openstackgerrit | Merged zuul/zuul master: Update heuristing of parallel starting builds. https://review.opendev.org/671702 | 15:23 |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 15:38 |
| bogdando | pabelanger: clarkb: I think this ^^ is done now | 15:39 |
| bogdando | thanks for hints and helping | 15:39 |
| clarkb | bogdando: that looks correct to me +2 and testing should confirm | 15:42 |
| *** hashar has quit IRC | 15:43 | |
| *** mattw4 has joined #zuul | 15:48 | |
| openstackgerrit | Bogdan Dobrelya (bogdando) proposed zuul/zuul-jobs master: Fix evaluating nodepool_ip and switch_ip facts https://review.opendev.org/681182 | 15:54 |
| *** gtema_ has joined #zuul | 15:56 | |
| *** hashar has joined #zuul | 16:01 | |
| *** noorul has joined #zuul | 16:08 | |
| *** mattw4 has quit IRC | 16:14 | |
| *** mattw4 has joined #zuul | 16:25 | |
| *** mattw4 has quit IRC | 16:33 | |
| AJaeger | zuul-jobs maintainers, do you want to merge this change to update fetch-subunit-output? https://review.opendev.org/674334 | 16:36 |
| *** igordc has joined #zuul | 16:39 | |
| *** jpena is now known as jpena|off | 16:39 | |
| *** igordc has quit IRC | 16:44 | |
| *** noorul has quit IRC | 16:50 | |
| clarkb | corvus: the proper name for the gerrit api you are adding support for is the gerrit checks api? | 17:01 |
| paladox | rest api :) | 17:01 |
| clarkb | paladox: gerrit checks rest api? | 17:01 |
| paladox | yeh. | 17:02 |
| clarkb | thanks! | 17:02 |
| paladox | https://gerrit.googlesource.com/plugins/checks/+/refs/heads/master/resources/Documentation/rest-api-checkers.md | 17:02 |
| * clarkb is helping to update aansiblefest slides and ifugred that would be a good thing to call out | 17:02 | |
| *** hashar has quit IRC | 17:10 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add support for the Gerrit checks plugin https://review.opendev.org/680778 | 17:14 |
| corvus | paladox, clarkb: i think i've got the full lifecycle in that patchset ^. if i run that with this pipeline config: http://paste.openstack.org/show/774849/ i get https://imgur.com/a/ZTssZIT | 17:15 |
| paladox | \o/ | 17:15 |
| clarkb | exciting | 17:16 |
| corvus | now that that's working with a real gerrit, i can go update the test fixtures to match, then write some tests | 17:17 |
| paladox | :) | 17:17 |
| *** jamesmcarthur has quit IRC | 17:18 | |
| corvus | tobiash, SpamapS, pabelanger: i'm also laying some groundwork for enhancing the status url reporting that we should be able to incorporate into the github driver as a followup | 17:25 |
| pabelanger | great | 17:28 |
| *** igordc has joined #zuul | 17:44 | |
| *** Jordan_Kramer has joined #zuul | 17:46 | |
| *** igordc has quit IRC | 17:50 | |
| *** Jordan_Kramer has quit IRC | 17:54 | |
| *** igordc has joined #zuul | 17:57 | |
| *** gtema_ has quit IRC | 17:58 | |
| *** igordc has quit IRC | 18:06 | |
| *** igordc has joined #zuul | 18:06 | |
| *** Jordan_Kramer has joined #zuul | 18:07 | |
| *** Jordan_Kramer has quit IRC | 18:09 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add support for the Gerrit checks plugin https://review.opendev.org/680778 | 18:12 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add report time to item model https://review.opendev.org/681323 | 18:12 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add Item.formatStatusUrl https://review.opendev.org/681324 | 18:12 |
| *** igordc has quit IRC | 18:15 | |
| *** kramerj has joined #zuul | 18:16 | |
| *** jamesmcarthur has joined #zuul | 18:18 | |
| *** kramerj has quit IRC | 18:20 | |
| *** saneax has joined #zuul | 18:35 | |
| *** panda is now known as panda|rover|off | 18:54 | |
| *** jamesmcarthur has quit IRC | 18:57 | |
| Shrews | AJaeger: i looked at https://review.opendev.org/674334 and not knowing the history behind the failure that is mentioned in the commit message, it would seem we could/should have a test for that role. I would think something similar to the fetch-output role test would be feasible. Or am I way off in thinking that would be easy enough to test? | 18:59 |
| Shrews | maybe someone more familiar with subunit might have some input on that? ^^ | 19:02 |
| *** saneax has quit IRC | 19:08 | |
| clarkb | Shrews: I think you should be able to do something similar. You will need valid subunit to do the appending with but you can just grab that from any other job and add it as a test fixture | 19:08 |
| SpamapS | corvus: yay.. the status url could use some enhancement in github. :) | 19:13 |
| *** pcaruana has quit IRC | 19:20 | |
| *** mattw4 has joined #zuul | 19:29 | |
| *** mattw4 has quit IRC | 19:33 | |
| *** panda|rover|off has quit IRC | 19:37 | |
| *** panda has joined #zuul | 19:38 | |
| fungi | there is an osf board of directors remote meeting underway now, if anyone wants to listen in: https://wiki.openstack.org/wiki/Governance/Foundation/10September2019BoardMeeting | 20:08 |
| pabelanger | fungi: thanks! | 20:18 |
| openstackgerrit | Merged zuul/zuul master: Record handler tasks in json job output https://review.opendev.org/680726 | 20:38 |
| corvus | paladox: fyi https://bugs.chromium.org/p/gerrit/issues/detail?id=11474 | 21:19 |
| paladox | oh | 21:19 |
| paladox | corvus is that from /admin/repos? | 21:19 |
| corvus | paladox: what's admin/repos? | 21:20 |
| paladox | replaces /admin/projects :) | 21:20 |
| paladox | it's what lists repository's | 21:20 |
| paladox | Ah, i see | 21:21 |
| paladox | ignore me :) | 21:21 |
| corvus | oh gotcha. i'm actually just focused on the rest api and notedb storage -- i think the existing 'create new checker' web ui wouldn't need to be changed | 21:22 |
| corvus | (it is, weirdly, available on the change screen, but it still has a repository field, so could apply to any repo) | 21:22 |
| paladox | Ah | 21:24 |
| paladox | corvus i take it this https://gerrit.googlesource.com/plugins/checks/+/refs/heads/master/gr-checks/gr-create-checkers-dialog.html#59 is the bit. | 21:30 |
| corvus | yep | 21:30 |
| paladox | it seems to be using the same rest api as gr-repo-list. | 21:31 |
| paladox | oh! | 21:31 |
| paladox | it calls https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js#L1373 | 21:32 |
| *** sshnaidm|ruck is now known as sshnaidm|afk | 21:33 | |
| paladox | i guess that needs fixing to support ?r= (regex). | 21:34 |
| paladox | corvus https://gerrit-review.googlesource.com/Documentation/user-search-projects.html#_search_operators | 21:34 |
| paladox | you could try state. | 21:34 |
| *** jamesmcarthur has joined #zuul | 21:35 | |
| corvus | paladox: on the web ui side i think we wouldn't want any kind of autocomplete there; i think it would need to detect someone entering a regex and just pass the value through unchanged. after all, the value i want to supply is ".*" :) | 21:38 |
| paladox | i think that is a regresion | 21:38 |
| paladox | *regression | 21:38 |
| paladox | it used to be supported in polygerrit by the looks of https://github.com/GerritCodeReview/gerrit/commit/1510bcfde2c002c14727b43e8df266010038b96a | 21:38 |
| corvus | paladox: how can there be a regression in the checks plugin? | 21:39 |
| paladox | it's not the checks plugin, the rest api its using :) | 21:39 |
| paladox | it's calling "getRepos" from gerrit's core | 21:39 |
| paladox | it's calling https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js#L1373 | 21:39 |
| corvus | paladox: if i type "state:active" in the repository field of the 'new checker' dialog, i get a popup selection of all the projects, so i think that still works | 21:41 |
| paladox | yup | 21:41 |
| corvus | paladox: i still have to select exactly one of them though, which is the thing i want to change | 21:41 |
| paladox | ok | 21:41 |
| paladox | i wonder if r= would work with query= | 21:41 |
| paladox | corvus https://gerrit-review.googlesource.com/c/gerrit/+/236473/ | 22:03 |
| paladox | would that work for you? | 22:03 |
| corvus | paladox: i'm not sure that's what's needed here -- specifically, i need to be able to put "^.*" in the repository field of the 'new checker' dialog, and on opendev, that's going to return 2100 entries. I don't want to see those in the ui. the only ui change needed for this would be to ignore a regex in that field and pass the contents through unchanged to the checks plugin rest endpoint. | 22:11 |
| corvus | paladox: but honestly, before we even get to the ui part, the backend rest api and data storage needs to support it, and that's where i was starting with that issue | 22:11 |
| paladox | ah ok | 22:11 |
| *** jamesmcarthur has quit IRC | 22:14 | |
| *** jamesmcarthur has joined #zuul | 22:15 | |
| *** jamesmcarthur has quit IRC | 22:17 | |
| clarkb | corvus: if you have a moment https://review.opendev.org/#/c/671704/3 would be helpful for some of the recent debugging we've had to do around why nodepool launches are failing. It should expose the nova fault message | 22:17 |
| *** jamesmcarthur has joined #zuul | 22:18 | |
| *** jamesmcarthur has quit IRC | 22:21 | |
| *** jamesmcarthur has joined #zuul | 22:24 | |
| *** panda has quit IRC | 22:26 | |
| *** panda has joined #zuul | 22:28 | |
| tristanC | I got some zuul jobs using synchronize to run on openshift using https://github.com/ansible/ansible/pull/62107 | 22:34 |
| corvus | clarkb: +3 | 22:36 |
| clarkb | corvus: thanks! | 22:36 |
| *** jamesmcarthur has quit IRC | 22:37 | |
| corvus | tristanC: that's really cool, that'll improve the ux a lot i think | 22:37 |
| tristanC | corvus: yeah, otherwise we'd have to adapt each role using synchronize... though I don't think this PR is going to be accepted easily since it only supports the src and dest argument | 22:39 |
| tristanC | because the oc rsync implementation can't support rsync options as it fallback to tar if rsync isn't installed in the pod | 22:40 |
| *** jamesmcarthur has joined #zuul | 22:44 | |
| *** mattw4 has joined #zuul | 22:55 | |
| *** jamesmcarthur has quit IRC | 22:57 | |
| *** mattw4 has quit IRC | 23:00 | |
| *** shachar has joined #zuul | 23:01 | |
| *** snapiri has quit IRC | 23:03 | |
| *** jamesmcarthur has joined #zuul | 23:18 | |
| *** jamesmcarthur has quit IRC | 23:21 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Add support for the Gerrit checks plugin https://review.opendev.org/680778 | 23:22 |
| *** jamesmcarthur has joined #zuul | 23:23 | |
| *** jamesmcarthur has quit IRC | 23:26 | |
| openstackgerrit | Merged zuul/nodepool master: Fix node failures when at volume quota https://review.opendev.org/671704 | 23:29 |
| *** jamesmcarthur has joined #zuul | 23:31 | |
| *** jamesmcarthur has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!