Tuesday, 2019-10-22

*** jamesmcarthur has quit IRC00:14
*** jamesmcarthur has joined #zuul00:15
*** jamesmcarthur has quit IRC00:16
*** jamesmcarthur has joined #zuul00:16
*** jamesmcarthur has quit IRC00:17
*** jamesmcarthur has joined #zuul00:19
fungiokay, gave it an hour just to be on the safe side. seeing no additional feedback or suggested edits, i'm sending now. thanks!00:31
*** jamesmcarthur has joined #zuul00:35
*** jamesmcarthur has quit IRC00:52
*** ianychoi has quit IRC01:16
*** ianychoi has joined #zuul01:16
*** jamesmcarthur has joined #zuul01:32
*** saneax has joined #zuul01:37
*** jamesmcarthur has quit IRC01:55
*** bhavikdbavishi has joined #zuul02:06
*** bhavikdbavishi1 has joined #zuul02:09
*** bhavikdbavishi has quit IRC02:11
*** bhavikdbavishi1 is now known as bhavikdbavishi02:11
*** bhavikdbavishi has quit IRC02:13
*** bhavikdbavishi has joined #zuul02:25
*** bhavikdbavishi1 has joined #zuul02:30
*** jamesmcarthur has joined #zuul02:31
*** ianychoi has quit IRC02:31
*** bhavikdbavishi has quit IRC02:32
*** bhavikdbavishi1 is now known as bhavikdbavishi02:32
*** ianychoi has joined #zuul02:33
*** jamesmcarthur has quit IRC02:38
*** spsurya has joined #zuul02:50
*** ianychoi has quit IRC02:51
*** ianychoi has joined #zuul02:52
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Stub out dry run in the uploader  https://review.opendev.org/59292902:58
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Create a download script  https://review.opendev.org/59234102:58
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Add a unicode file  https://review.opendev.org/59285302:58
*** rfolco has quit IRC03:15
*** saneax has quit IRC03:30
*** bolg has joined #zuul05:11
*** ianychoi has quit IRC05:13
*** ianychoi has joined #zuul05:14
*** ianychoi has quit IRC05:26
*** ianychoi has joined #zuul05:28
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Create a download script  https://review.opendev.org/59234105:32
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Add a unicode file  https://review.opendev.org/59285305:32
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: testing autogenerated download script  https://review.opendev.org/68993005:32
*** bolg has quit IRC06:06
*** themroc has joined #zuul06:08
*** sshnaidm_ has joined #zuul06:15
*** sshnaidm|pto has quit IRC06:15
*** igordc has joined #zuul06:34
*** pcaruana has joined #zuul06:47
*** igordc has quit IRC06:48
*** saneax has joined #zuul07:04
*** bolg has joined #zuul07:11
*** tosky has joined #zuul07:12
*** sshnaidm_ has quit IRC07:14
*** hashar has joined #zuul07:18
*** sshnaidm has joined #zuul07:27
*** jangutter has joined #zuul07:52
openstackgerritMatthieu Huin proposed zuul/zuul master: Zuul Web: add /api/user/authorizations endpoint  https://review.opendev.org/64109908:10
openstackgerritFabien Boucher proposed zuul/zuul master: gerrit: add support for report only connection  https://review.opendev.org/56821608:32
fbotristanC: corvus do you think this patch ^ could be replaced by the new" stream_events connection setting ?08:34
openstackgerritFabien Boucher proposed zuul/zuul master: gerrit: add support for report only connection  https://review.opendev.org/56821608:36
openstackgerritFabien Boucher proposed zuul/zuul master: trigger: add job filter event  https://review.opendev.org/63990509:30
openstackgerritFabien Boucher proposed zuul/zuul master: webtrigger: add initial driver and event  https://review.opendev.org/55515309:33
openstackgerritFabien Boucher proposed zuul/zuul master: webtrigger: add web route and rpclistener  https://review.opendev.org/55483909:35
openstackgerritFabien Boucher proposed zuul/zuul master: web: add build button to trigger job  https://review.opendev.org/63571609:36
*** mauved has quit IRC09:49
*** mauved has joined #zuul09:50
*** phildawson has quit IRC10:05
*** pcaruana has quit IRC10:16
*** pcaruana has joined #zuul10:21
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Create a download script  https://review.opendev.org/59234110:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: test bulk download script change  https://review.opendev.org/68993010:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Add a unicode file  https://review.opendev.org/59285310:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: test bulk download script change  https://review.opendev.org/68993010:43
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Create a download script  https://review.opendev.org/59234110:43
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Add a unicode file  https://review.opendev.org/59285310:43
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Add a unicode file  https://review.opendev.org/59285311:26
*** ianychoi has quit IRC11:37
*** ianychoi has joined #zuul11:40
*** ianychoi has quit IRC12:00
*** yolanda has quit IRC12:01
*** ianychoi has joined #zuul12:03
openstackgerritSorin Sbarnea proposed zuul/zuul-jobs master: WIP: Allow ensure-tox to upgrade tox version  https://review.opendev.org/67646412:05
openstackgerritSorin Sbarnea proposed zuul/zuul-jobs master: tox: change default calling as a module  https://review.opendev.org/69005712:12
*** yolanda has joined #zuul12:13
*** jamesmcarthur has joined #zuul12:18
*** jamesmcarthur has quit IRC12:30
*** ianychoi has quit IRC12:39
*** ianychoi has joined #zuul12:41
*** ianychoi has quit IRC12:54
*** rfolco has joined #zuul12:55
*** ianychoi has joined #zuul12:57
jangutterThis is an odd question, but does anyone use zuul and git submodules together (I know it's a bad idea, but legacy, y'know). It would improve our workflow immensely if we can get the merger to clone with git --recursive as an option.13:34
jangutterI just want to check if someone's hit a similar problem before I start hacking on it.13:35
openstackgerritSorin Sbarnea proposed zuul/zuul-jobs master: tox: change default calling as a module  https://review.opendev.org/69005713:38
openstackgerritDavid Shrewsbury proposed zuul/nodepool master: Take advantage of fetch-output  https://review.opendev.org/68947313:39
corvusjangutter: http://eavesdrop.openstack.org/irclogs/%23zuul/%23zuul.2019-10-16.log.html#t2019-10-16T22:34:5513:47
jangutterDo you guys have some sort of non-causal way of discussing my questions the week before?13:48
corvusjangutter: mailing list, and if it's a more complex subject we need to get agreement on, a spec13:49
corvusjangutter: do you think mordred's suggestion would cover your use-case?13:50
janguttercorvus: I'm checking - we're specifically _not_ considering the CI aspect (can of worms), but it would be nice if the submodules could be checked out by zuul before the roles start.13:52
corvusfbo: yes, i think you can use the stream events setting instead13:56
*** ianychoi has quit IRC13:58
*** ianychoi has joined #zuul14:00
janguttercorvus: modred's suggestion would be pretty much next-level supercool. Gleaning dep info from submodules is not even something I had considered. CI-ing submodules that have not merged I kind-of considered as impossible.14:02
fungii wonder if i'm the only one who got jangutter's temporal paradox joke14:03
*** rfolco is now known as rfolco|rover14:03
jangutterfungi: would be more impressive if you caught it 20 minutes ago, but I'm not complaining.14:03
fungibwahahah14:04
jangutterOK, just to double-check my understanding:14:11
jangutter1) open up a review on the master repo that depends-on a review of the submodule.14:11
jangutter2) Zuul scans the master repo and figures out that the submodule repo needs to have an checkout override to the submodule dir.14:11
jangutter3) Zuul creates a merge commit on the master repo, as if the submodule review has merged.14:11
jangutter(I didn't consider the CI implications, I was thinking of adding a flag that clones the work repos with --recursive when you opt-in)14:12
jangutterStep 3 is the domain of dragons.14:13
corvus1 and 2 are correct -- i'm not certain that mordred was thinking of implementing 3 in exactly that way, but rather achieving the same effect by zuul having prepared the submodule repo in the normal way of a required-project and then performing the equivalent of a git init.  (having said that, i think item 3 may be an equally valid and achievable way to implement that)14:20
corvus(er, 'git submodule init')14:20
*** igordc has joined #zuul14:23
corvusclarkb, fungi, mordred: https://github.com/kislyuk/rehash/issues/4  is an interesting read14:24
fungihah14:25
fungi"i can work on fixing this once our ci system has python 3.8 support"14:25
jangutterSee, the acausal logic is spreading.14:26
fungiwe could be facing a total causality collapse, yes14:26
fungilots of me-too comments on https://github.com/actions/setup-python/issues/3014:27
fungialan clark just complimented zuul and opendev for being able to keep up with the volume and complexity of testing required to support the openstack train release14:28
fungi(on the osf board of directors call)14:28
corvusaww thanks!14:29
clarkbif only there was some way to collaboratively build a CI system that met the needs of its users :)14:29
clarkbthat said I thought github actions ran with user specified containers? you can probably supply a python-slim container and get 3.8 that way?14:29
corvushere's the file: https://github.com/kislyuk/rehash/blob/master/.github/workflows/pythonpackage.yml14:29
*** michael-beaver has joined #zuul14:30
corvusso maybe it could use something like "runs-on: python:3.8-slim" and drop the actions/setup-python step?14:30
corvus(i have no idea, i'm just making that up)14:31
corvusclarkb: apparently they are virtual machines: https://help.github.com/en/github/automating-your-workflow-with-github-actions/virtual-environments-for-github-actions14:33
clarkbTIL14:34
corvusapparently "use vms for all your ci tests" is not as passe as some people have suggested.14:34
jangutterdecided lack of CentOS :-/14:37
*** ianychoi has quit IRC14:38
corvusit looks like they have special "actions" for docker containers, so there still may be a not-too-complex way to use python:slim14:39
*** ianychoi has joined #zuul14:40
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Test buildset registry with k8s and docker  https://review.opendev.org/68928014:42
corvusclarkb, fungi: want to push https://review.opendev.org/689880 through?14:42
clarkbdone14:44
openstackgerritMerged zuul/project-config master: Add gerrit image build job to gerrit checks plugin  https://review.opendev.org/68988014:44
fungiheh, that updated to merged just as i pulled it up14:45
fungithe noop is *fast* ;)14:45
mnaserdoing nothing is fast D:14:48
jangutteryou _quite_ sure the noop didn't complete before the +W?14:50
*** jamesmcarthur has joined #zuul14:53
*** pcaruana has quit IRC14:58
ShrewsFYI, probably afk for the rest of the day. Having car issues while running an errand this morning.15:07
corvusShrews: good luck!15:09
corvusclarkb, fungi: i don't understand this: https://zuul.opendev.org/t/zuul/build/2b5c1df748f74d4db75f5ddde433495515:14
corvusthat's for a recheck of a zuul-jobs change which has otherwise run many times15:14
clarkbcorvus: is it possible pip/setuptools updated and started making that an error?15:15
corvusthat tried to install 3.10.2; the last time that job ran, it apparently installed 3.2.0 https://zuul.opendev.org/t/zuul/build/c30cb8d6c05b4abf93bf103702897ae0/log/tox/py27-1.log15:15
fungilooking15:16
clarkbhttps://opendev.org/zuul/zuul-jobs/src/branch/master/test-requirements.txt#L6 is the dependency15:16
corvusmaybe?  or maybe something happened with mirroring, and 3.2.0 didn't have that restriction?15:16
fungiyeah, looks like python 2.7 pip tried to install zuul15:17
fungiand so is complaining that zuul says it only works with python 3.5 and later15:17
corvusbut apparently that usually works?15:17
fungior something changed15:17
clarkbpossible that different pip version would find the newest zuul that works with python2 and install that and that has changed?15:18
corvusthe same job ran 3 minutes later and passed15:18
fungihuh, have a link so we can compare the logs?15:18
fungii can't imagine the py27 job would have been successfully installing zuul v315:19
corvuspass: https://zuul.opendev.org/t/zuul/build/0b37898faa8445b19293da4a9122e3ae fail: https://zuul.opendev.org/t/zuul/build/2b5c1df748f74d4db75f5ddde433495515:19
fungithanks15:19
corvusdifferent changes, but they're in the same series (the one i'm rechecking over and over); none touch anything related to unit tests15:19
*** saneax has quit IRC15:20
clarkbthe same version of pip is used in both cases15:20
*** yolanda__ has joined #zuul15:21
clarkbI think pypi will provide valid versions for the requesting python version15:21
fungihttps://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_0b3/689280/10/check/tox-py27/0b37898/tox/py27-1.log15:21
fungiyou can see there the py27 tox log shows it installing http://mirror.ord.rax.opendev.org/pypifiles/packages/39/54/09c7e809b5b216c99c165f8390837c5d0814350026beaaac126eb73d81d5/zuul-3.2.0.tar.gz15:21
fungiSuccessfully installed [...] zuul-3.2.015:22
clarkbya and 3.2.0 is the newest version that doesn't specify requires >= 3.5 on pypi15:22
fungibizarre15:22
clarkbI think it is possible that this is due to pypi15:23
clarkbpip is relying on it to give it the valid version list?15:23
fungiyeah, and the failing job tries to install http://mirror.sjc1.vexxhost.openstack.org/pypifiles/packages/e7/48/a083a6639aed280151d3c43e690d5a7dd445f729278f5ba08f87f5a65300/zuul-3.10.2.tar.gz15:23
clarkbwhich is not the latest version either15:23
corvusi wonder if the cdn cached the wrong results15:24
*** yolanda has quit IRC15:24
*** mattw4 has joined #zuul15:26
corvuswe going with "<shrug> pypi.  see if it happens again?"15:27
clarkbya I think so as I'm 95% sure that it is pypi that filters the python versions for pip15:28
corvusk.  i'll keep an eye15:28
*** sgw has quit IRC15:29
webknjaznope15:29
webknjazit's Pip that does version filtering15:29
webknjazif it's new enough15:29
fungiwebknjaz: but the filtering is going to be based on the response it gets from pypi15:30
webknjazPyPI just show whatever the maintainer uploaded in dist meta15:30
clarkbah ok15:30
clarkbwebknjaz: the metadata shows 3.10.2 requires python >= 3.5 any idea why pip might try to install that anyway on python3?15:30
clarkber on python215:30
webknjaz@fungi: Pip looks up the page with a simple indes, like https://pypi.org/simple/ansible/15:31
clarkbthe version of pip used was the same as a job that properly filtered it out15:31
webknjazThen, it look at the names of dists listed there15:31
fungiwebknjaz: we've seen truncated responses from the pypi fastly cdn endpoints in the past15:31
fungiso can't rule out incomplete responses15:31
webknjazbased on the name pattern, Pip can filter out things15:31
webknjazbut yes, it probably looks up some metadata from the API (so that it won't have to download dists first to figure it out)15:32
webknjaz> any idea why pip might try to install that anyway on python315:32
webknjazyes, it's because of the outdated Pip version15:32
webknjazIt should be v8+ or v10+, don't remember exactly15:33
clarkbwait so it does get that info from pypi?15:33
clarkbalso the version of pip was 19.2.315:34
webknjazI think so15:34
clarkbcould still be pypi then15:34
webknjazAlso, you can do `-vvv` to make Pip more verbose, maybe it'll reveal the reason why it chose that dist15:34
clarkbI think we go with that original "see if it happens again"15:34
webknjazhttps://www.irccloud.com/pastebin/bgrmon54/15:36
webknjaz> zuul-3.10.2.tar.gz15:36
webknjazwhy does it hit sdist?15:36
clarkbbecause there is no wheel for that version15:36
clarkb*for that python + zuul version15:36
webknjazI'm not sure sdist can ship this meta15:36
clarkbright which is why I was fairly certain it comes from pypi15:37
clarkbbecause without first downloading all of the sdists and unpacking them the info wouldn't be availalb15:37
webknjazOTOH I downloaded that sdist and it has python-requires15:39
webknjaz➜ grep \\-Python zuul-3.10.2/zuul.egg-info/PKG-INFO15:39
webknjazRequires-Python: >=3.515:39
corvusview-source:http://mirror.ord.rax.opendev.org/pypi/simple/zuul/15:40
corvusthat does have the python version req in it15:40
clarkbaha15:40
openstackgerritSorin Sbarnea proposed zuul/zuul-jobs master: tox: change default calling as a module  https://review.opendev.org/69005715:40
clarkbit does come from pypi15:40
webknjazwait, where?15:41
corvusview-source:http://mirror.sjc1.vexxhost.openstack.org/pypi/simple/zuul/15:41
webknjazstop15:41
webknjazI was wrong15:41
corvusthat does not15:41
webknjazno, it doesn't have version info there15:41
webknjazthat's a simple-index page, with links15:41
webknjazPip downloads it over HTTP and finds all matching filenames15:41
corvusdata-requires-python="&gt;=3.5"15:42
clarkbwebknjaz: check the html source15:42
clarkbcorvus: in that case I think that would be a cdn issue? we are proxying caching in each of those mirror nodes so are dependent on the data provided by pypi's cdn15:42
webknjazI'm not sure that Pip uses that attr15:42
webknjazand the filename doesn't have Python branch specifier in it15:42
corvusthey're even sorted differently15:43
webknjazwhat's sorted differently?15:44
corvusthe two simple index pages from the different mirror locations15:45
corvus(vexxhost-sjc1 vs rax-ord)15:45
webknjazlooks like his page has invalid relative URLs: http://mirror.ord.rax.opendev.org/pypi/simple/15:48
webknjaz`/simple/PKG_NAME` instead of `/pypi/simple/PKG_NAME`15:49
corvuslast time i looked, pip ignored that and only used the package names from the index page15:50
*** bhavikdbavishi has quit IRC15:50
*** bhavikdbavishi has joined #zuul15:51
*** ianychoi has quit IRC15:52
webknjazWell, Pip should open the package page to see the list of dists for that package15:52
webknjazhttps://www.irccloud.com/pastebin/BCcnSjmr/15:52
webknjazIt goes to the usual PyPI CDN on my laptop15:53
*** ianychoi has joined #zuul15:54
webknjazhttps://www.irccloud.com/pastebin/WluCSLWM/15:54
webknjazAnd if I disable the default index, it just doesn't find anything ^15:54
webknjazif you add `-vvv` it'll explain what it skips pages of every dist listed there15:58
webknjazhttps://www.irccloud.com/pastebin/akPRViDW/15:59
webknjazIf you check any link like `Skipping link http://mirror.ord.rax.opendev.org/simple/mast/ (from http://mirror.ord.rax.opendev.org/pypi/simple/); not a file`, it returns 40415:59
clarkbthat is orthogonal to the issue at hand though right? I mena it is something we may want to address in the proxy cache system but unrelated to the switch since we've got the difference of behavior through this proxy setup16:00
webknjazwhat's different?16:00
clarkbcorvus pointed out the difference is order of entries and the lack of the data-requires-python tags16:01
webknjazI don't think it matters much16:01
clarkbI mean it is clearly downloading the packages from from that mirror successfully16:01
clarkbit is also deciding that it cannot install what it has downloaded16:02
clarkb(which implies to me the problem you point out isorthogonal to the problem corvus has run into)16:02
webknjazwhat do you mean by deciding it cannot install?16:02
clarkbwebknjaz: https://zuul.opendev.org/t/zuul/build/2b5c1df748f74d4db75f5ddde4334955 ERROR: Package 'zuul' requires a different Python: 2.7.15 not in '>=3.5'16:03
corvusyes, in our usage of pip, the index page is hardly used (it's really only used to correct the case of package names)16:03
*** themroc has quit IRC16:03
clarkband apparently the metadata tags for that info are present in one of our pypi caches and not another16:04
clarkbimplying to me that there is a difference in cdn setup?16:04
*** bolg has quit IRC16:04
clarkbthe one that fails is the one without the data-requires-python16:05
clarkbthe one that works has that information16:05
webknjazokay, it seems like Pip looks at that since v916:06
webknjazhttps://github.com/pypa/pip/blob/937315905670d25dc7354a832d81ea3e4afacef1/NEWS.rst#L87416:06
webknjazhttps://github.com/pypa/pip/blob/0f095af4ba7ac1af2c27024fa539af4c3a45d002/src/pip/_internal/index/collector.py#L23216:07
openstackgerritSorin Sbarnea proposed zuul/zuul-jobs master: WIP: Allow ensure-tox to upgrade tox version  https://review.opendev.org/67646416:07
openstackgerritJames E. Blair proposed zuul/project-config master: Use gerrit master job with no files matcher  https://review.opendev.org/69012116:08
clarkbcorvus: I believe the ttl on those files is short ~10 minutes16:08
clarkbcorvus: if it persists we should confirm that then escalate to pypi16:08
corvusclarkb: ack16:08
corvusjackpot!  got a v6 registry node: https://zuul.opendev.org/t/zuul/build/f0587812badc40aea9a807bf126e0ef716:10
*** igordc has quit IRC16:20
*** yolanda__ has quit IRC16:38
*** pcaruana has joined #zuul16:41
*** pcaruana has quit IRC16:52
*** bhavikdbavishi has quit IRC17:15
*** hashar has quit IRC17:15
openstackgerritMerged zuul/project-config master: Use gerrit master job with no files matcher  https://review.opendev.org/69012117:22
*** ianychoi has quit IRC17:39
*** ianychoi has joined #zuul17:42
*** ianychoi has quit IRC17:55
*** ianychoi has joined #zuul17:58
mnaserhey -- just need a second pair of eyes to double check18:00
mnaserhttps://zuul-ci.org/docs/zuul/admin/tenants.html seems to mention that tenant.config-projects and tenant.untrusted-projects are a thing, but the layout is tenant.source.<connection>.{config,untrusted}-projects18:00
mnaserthat seems like a documentation bug (i can fix, but just wanted a second pair of eyes)18:01
*** jamesmcarthur has quit IRC18:01
corvusmnaser: yeah, i think the text in https://zuul-ci.org/docs/zuul/admin/tenants.html#attr-tenant.source explains, but it's not obvious, and that all probably predates our use of metasyntactic variables, so i think an update to do that would be more clear18:03
mnaserok ill push up a small patch now18:03
clarkbindenting another level might help too to show that is an attribute of the source? though that might make things hard to read if it gets too squished18:04
openstackgerritJames E. Blair proposed zuul/project-config master: Run opendev-buildset-registry when building gerrit  https://review.opendev.org/69014618:07
corvusfungi, clarkb: ^ quick +3 on that?18:07
mnaserclarkb: yeah that was what i was thinknig but i was worried it would start to get a lil more confusing18:07
mnaserbtw, there seems to be a little disagreement in teh docs too18:08
mnaserhttps://zuul-ci.org/docs/zuul/user/config.html  "Pipeline configuration items may only appear in config-projects."18:08
mnaseryet.. https://zuul-ci.org/docs/zuul/admin/tenants.html#attr-tenant.untrusted-projects.%3Cproject%3E.include18:08
mnaserseems to imply that you can include/exclude pipelines there?18:08
corvusheh.  it's "technically" correct.  you can put the word "pipeline" in the include list there, and it will not be a syntax error, however it will be ignored.18:09
corvusmaybe the easiest fix for that is a "note: pipelines are ignored in untrusted projects"18:10
corvusor some such18:10
openstackgerritMerged zuul/project-config master: Run opendev-buildset-registry when building gerrit  https://review.opendev.org/69014618:10
clarkbor have docs for include in config-projects and specify different lists?18:10
clarkbI think the issue there is it is documenting all valid include options for config-projects and untrusted-projects18:11
corvusi think it's legitimate to note that it's not a syntax error (it's important when you start to talk about default values, etc)18:11
corvuslike, you can make a single list of stuff that includes pipelines, and throw config and unstrusted projects in that list, and that is valid syntax but pipelines will still be ignored in unstrusted projects.18:11
corvuswhy do i keep saying unstrusted?  that's weird.18:12
corvusuntrusted.  untrusted.  untrusted.18:12
*** ianychoi has quit IRC18:12
*** sgw has joined #zuul18:13
*** igordc has joined #zuul18:14
corvuswe've scheduled jobs on https://gerrit-review.googlesource.com/c/plugins/checks/+/241293 at https://zuul.opendev.org/t/zuul/status18:14
*** ianychoi has joined #zuul18:16
Shrewswell that was certainly an expensive errand18:16
corvusShrews: how's your new car?18:16
Shrewspfft, new? i wish18:16
Shrewsparts of it are new now18:17
*** ianychoi has quit IRC18:26
*** ianychoi has joined #zuul18:30
*** spsurya has quit IRC18:30
*** ianychoi has quit IRC18:38
*** ianychoi has joined #zuul18:42
mnaserhttp://zuul.opendev.org/api/tenant/opendev/build/108c06c64b5745b581ad999156df78a318:43
mnaseris there a reasoning behind why node_name is empty?18:43
*** hwangbo has joined #zuul18:45
hwangboHello, can I define different projects and queues for different branches in the same untrusted gerrit repo?18:46
mnaserhwangbo: you could technically have a .zuul.yaml file inside every branch containing the config for that branch itself -- i think that would get you what you want?18:46
*** hashar has joined #zuul18:47
*** jamesmcarthur has joined #zuul18:47
*** igordc has quit IRC18:47
hwangboWe have a zuul.yaml file in each branch, but they still ended up in the same dependent pipeline queue, even though different ones were specified18:47
hwangboSo I was wondering if that ability was something supported, to have different dependent queues for different branches on the same repo18:49
*** jamesmcarthur_ has joined #zuul18:50
*** michael-beaver has quit IRC18:50
clarkbhwangbo: no, and that is somewhat intentional to enable upgrade testing18:51
hwangboall right, thank you for confirming!18:53
*** jamesmcarthur has quit IRC18:54
fungihwangbo: specifically, it's intended to make sure that if a job involves more than one branch of your repo, changes to one branch are tested with any changes queued for other branches18:55
*** igordc has joined #zuul18:56
hwangboclarkb fungi: so if I have different queues defined for different branches, is it basically first branch/change in the pipeline determines what queue it belongs in?18:57
fungihwangbo: all configuration from all branches is read by zuul and combined18:57
fungibut yes, i think in that case one of them would override the queue value set in the others18:58
fungio18:58
fungii'm not sure which branch would take precedence in that case18:58
corvusthe first one zuul encounters: https://zuul-ci.org/docs/zuul/user/config.html#attr-project.%3Cpipeline%3E.queue18:58
clarkbhwangbo: what is the goal with splitting the queues?18:59
clarkb(it might help to understand the use case to know if there is some other approach that could be taken)18:59
corvusso put it in a config-project, or in the master branch of the project itself.18:59
fungibut the idea with not separating branches into different queues is so that if you have a 1.x branch and a 2.x branch and a job that tests upgrading from 1.x to 2.x, then it makes sure that changes for 1.x and 2.x which are queued at the same time get tested together so you don't merge a change for one of them which doesn't work with the changes for the other in the job18:59
hwangboclarkb: teams working on different branches didn't want the dependent queue length/size to affect each other18:59
hwangboso if there are 20 changes in queue for branch A, they didn't want a change for branch B to have to wait for all 20 to finish19:01
corvuswell, they don't.  zuul runs those in parallel.19:01
corvusthat's kind of it's main thing.19:01
fungiwell, they do have to wait for all 20 ahead to finish before they can merge the change, but they don't have to wait for all 20 to merge before jobs for the change can start being tested19:02
openstackgerritJames E. Blair proposed zuul/project-config master: Remove gerrit checks plugin third-party-check pipeline  https://review.opendev.org/69030719:02
hwangboAlso, if our pipeline window is small (for whatever reason, flaky testing, bad test nodes), it's also affected in those scenarios19:03
corvusi'm going to self-approve that ^19:03
*** pcaruana has joined #zuul19:04
*** ianychoi has quit IRC19:04
corvusthat's certainly true :/19:04
clarkbthough you can increase the window size or disable it entirely iirc19:04
clarkb(typically the best solution there is to stop attempting to merge changes that can't possibly merge, but I understand it is often difficult to know that ahead of time when approving things)19:05
*** jamesmcarthur has joined #zuul19:05
corvusin openstack we've generally accepted that being able to test upgrades is worth the cost.  i suppose if you had a piece of software with no upgrade testing, then branch/queue separation might make sense.19:06
*** jamesmca_ has joined #zuul19:06
openstackgerritMerged zuul/project-config master: Remove gerrit checks plugin third-party-check pipeline  https://review.opendev.org/69030719:07
fungibut yeah, at least at the moment, zuul assumes there could be some interaction or dependency relationships between all branches of a project and errs on the side of correctness19:07
hwangboThat's definitely fair, thanks for the clarification19:07
*** ianychoi has joined #zuul19:08
fungiright now you can use depends-on freely between changes for different branches of the same project and get the expected behavior. if branches could be configured to not share the same queue as other branches for the same project, you'd need additional configuration constructs to be able to identify when there are branch relationships to make things like depends-on work correctly19:08
*** jamesmcarthur_ has quit IRC19:08
*** jamesmcarthur has quit IRC19:09
*** jamesmcarthur has joined #zuul19:10
*** hwangbo has quit IRC19:12
*** jamesmcarthur has quit IRC19:12
*** jamesmca_ has quit IRC19:13
*** hwangbo has joined #zuul19:13
*** jamesmcarthur has joined #zuul19:15
*** ianychoi has quit IRC19:15
hwangboanother question then, since I have all these different zuul.yaml files across different branches, is there a way to specify, maybe on a repo level, "use the zuul.yaml from this specified branch and ignore the others"?19:15
hwangboone that hopefully doesn't require me to open a gerrit review for each branch :)19:15
fungiif it's a config-project then only the master branch is considered19:19
fungihowever you also don't get speculative execution of proposed configuration changes in those19:19
corvushwangbo: not at the moment, though we have discussed that.  but there may be other options for specific issues... what sort of thing are you thinking you might need to change on all the branches?19:19
*** pcaruana has quit IRC19:19
hwangbojust remove the different queues, so they don't interfere with each other. I'm worried that if it's first-come defines the queue, shared queue items in different projects will not be processed correctly19:20
*** ianychoi has joined #zuul19:24
clarkbhwangbo: one way to address that is the define the queues in a config project without branches19:25
clarkbthat will be loaded before the in repo configs of untrusted projects19:25
*** jamesmcarthur has quit IRC19:27
hwangboclarkb: that might work, I'll look into it. thanks!19:27
corvushwangbo: yeah, clarkb's suggestion is the best -- but also, it is determistic.  ie, it's based on the order zuul loads configs, so if it's defined in the project itself, it is always certain that zuul will use the value in the master branch, because it always starts there.19:30
corvus(so you can be sure that values in other branches will be ignored -- it's safe to leave them there)19:31
*** jamesmcarthur has joined #zuul19:32
*** ianychoi has quit IRC19:39
*** hwangbo has quit IRC19:43
*** jamesmcarthur has quit IRC19:46
openstackgerritJames E. Blair proposed zuul/project-config master: Make third-party-check quieter  https://review.opendev.org/69040520:24
corvusclarkb, fungi, mordred: ^ that should take care of the chatty messages and fix the urls that we send20:24
openstackgerritJames E. Blair proposed zuul/project-config master: Revert "Remove gerrit checks plugin third-party-check pipeline"  https://review.opendev.org/69040720:28
*** hwangbo has joined #zuul20:51
openstackgerritMerged zuul/project-config master: Make third-party-check quieter  https://review.opendev.org/69040521:01
corvusclarkb: something isn't adding up for me with this registry ipv6 thing.  the issue is when we're in limestone (all ipv6).  the job makes a complete replica of the environment (fake executor, intermediate registry, and builder+buildset registry).  we set up a socat process on the executor so that we can skopeo copy to the buildset registry (via the socat port on localhost).  that isn't actually able to21:25
corvuscontact the buildset registry in the test job.  i don't actually see how this is any different than production, and am wondering if copying to a production buildset registry is actually working.  but i'm sure we thought we fixed this (we put a lot of effort into the socat stuff).  am i missing something?21:25
corvus(i suspect the immediate problem is actually that docker isn't setting up the necessary iptables rules for v6; but i'm hesitant to just dive into that without knowing whether or why this works in prod)21:27
corvusoh wait i found it!21:30
corvuswe open ports 5000:5001 in ip6tables in the opendev buildset-registry job pre-playbook21:31
corvusso we need to do the same thing in the test job21:31
*** armstrongs has joined #zuul21:40
*** mattw4 has quit IRC21:40
clarkbcorvus: catching up after lunch and a bike ride and ya the ipv6 ports was a problem in production for a while too21:40
clarkbthat was the lsat piece of that puzzle, once we put that into prod it worked reliably21:40
*** mattw4 has joined #zuul21:41
corvuscool, i guess we just lucked out with this role's testing so far21:41
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Use zuul-registry as buildset registry  https://review.opendev.org/68923821:42
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Make the buildset registry port configurable  https://review.opendev.org/68924021:42
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Test buildset registry with k8s and docker  https://review.opendev.org/68928021:42
openstackgerritJames E. Blair proposed zuul/zuul-jobs master: Open iptables ports in registry test job  https://review.opendev.org/69042521:42
corvusclarkb, mordred: i think we're ready for https://review.opendev.org/690407 unless anyone thinks of something else to check before trying again21:43
mordredcorvus: it took me several reads of the above to grok it - the testing of testing things can be mindbending21:44
mordredcorvus: I also think we're ready for it21:44
openstackgerritMerged zuul/project-config master: Revert "Remove gerrit checks plugin third-party-check pipeline"  https://review.opendev.org/69040721:44
corvusmordred: yeah -- though being abel to say "this should be just like production" really helps21:45
corvusthat's what reminded me to go look to see if the base job did anything else21:45
mordredcorvus: SPEAKING OF ...,21:45
mordredactually, let me move this to -infra21:45
*** armstrongs has quit IRC21:46
corvusmordred: round 2 of gerrit testing is happening in https://zuul.opendev.org/t/zuul/status now21:49
*** hashar has quit IRC21:51
mordredcorvus: sweet!22:04
mordredcorvus: btw - at some point it might be nice to tenant-scope the cookie we use for project filters22:04
corvus++22:05
mordred(I was just confused that I didn't see anything, but it was because I had system-config still in the list from openstack tenant)22:05
mordredhttps://gerrit-review.googlesource.com/c/plugins/checks/+/241293/ <--22:06
mordredyou can see the check is in the running state22:06
mordredclarkb: ^^22:06
clarkblooks like it failed and the view log buildset link worked22:07
clarkbOne thing I like about our existing js hacks is that you see the table by default22:07
corvushrm, still left a message though :/22:07
clarkbmaybe we can suggest the checks api render by default per a user set option or something22:07
mordredclarkb: there is a thing coming called "subchecks"22:09
corvusyeah, i'm not sure why you would only want to see either files or checks.22:09
mordredoh - nevermind - I misunderstood22:09
mordredand yeah - the checks are pretty hidden for now22:09
corvusbut if you click on the "1 of 1 checks failed" it does open the table for you22:09
mordredcorvus: what is the "re-run" link supposed to accomplish?22:10
corvusmordred: it removes the check result, causing the next poll to indicate that it should run a check22:11
mordredah - neat22:11
corvusmordred: it should not work for your regular account22:11
mordredshould I try?22:11
corvusmordred: go for it :)22:11
mordredit didn't work - and also didn't give me an error :)22:12
corvussounds about right :)22:12
corvusi'm assuming that's a TODO22:12
corvusit does work under the opendev-zuul account, so i'm logged in with that so i can click it to trigger this stuff22:12
corvus(though i could also "zuul enqueue")22:12
corvusi think we may need further code changes to zuul to suppress the job reporting in comments22:14
mordredcorvus: I noticed OpenDev Zuul responded to David22:14
corvusyeah, i got the wrong tab :(22:14
mordredcorvus: :)22:14
mordredcorvus: I was thinking zuul had achieved sentience22:15
openstackgerritJames E. Blair proposed zuul/project-config master: Revert "Revert "Remove gerrit checks plugin third-party-check pipeline""  https://review.opendev.org/69043022:16
corvusself-approving ^22:16
clarkb"I am corvus"22:16
clarkbmordred: ^22:16
openstackgerritMerged zuul/project-config master: Revert "Revert "Remove gerrit checks plugin third-party-check pipeline""  https://review.opendev.org/69043022:16
mnaserhttps://review.opendev.org/#/c/688446/22:16
mordredclarkb: if zuul told me it was corvus, how would I know?22:16
mnaserdoes anyone mind kicking +W-ing this?22:16
mnaserwow words are hard22:17
corvusdone22:17
mnaserthanks!22:18
mnaserhttps://zuul.opendev.org/t/opendev/build/360d08f189824abdae6ae324cc75b10922:34
mnaserhmm, it blew up22:34
*** saneax has joined #zuul22:49
*** tosky has quit IRC22:56
openstackgerritIan Wienand proposed zuul/zuul-jobs master: upload-logs-swift: Add a unicode file  https://review.opendev.org/59285323:01
*** tjgresha_ has joined #zuul23:46
*** tjgresha_ has quit IRC23:51
*** tjgresha has joined #zuul23:52
*** tjgresha has quit IRC23:53
*** igordc has quit IRC23:55
*** mattw4 has quit IRC23:57

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!