corvus | announcement emails sent | 00:00 |
---|---|---|
corvus | i'll work on the ansible email tomorrow... | 00:02 |
*** jamesmcarthur has joined #zuul | 00:28 | |
*** Goneri has joined #zuul | 00:29 | |
openstackgerrit | Ian Wienand proposed zuul/nodepool master: Also build sibling container images https://review.opendev.org/697393 | 00:30 |
openstackgerrit | Ian Wienand proposed zuul/nodepool master: [wip] move openstack testing to use containerised daemon https://review.opendev.org/693464 | 00:30 |
*** sshnaidm is now known as sshnaidm|afk | 00:35 | |
*** rf0lc0 has joined #zuul | 00:51 | |
*** rfolco has quit IRC | 00:51 | |
SpamapS | can somebody point me at an example of a jobs on a single project having a parent/child relationship (as in, 1 job runs, and then if it passes, the second one does)? | 00:52 |
SpamapS | Docs don't seem to spell this out, only thing I can find is provides/requires... but I feel like there's a more natural way to do it. | 00:52 |
* SpamapS already forgetting how to configure zuul :-/ | 00:53 | |
corvus | SpamapS: you want this one: https://zuul-ci.org/docs/zuul/user/config.html#attr-job.dependencies | 00:54 |
*** Goneri has quit IRC | 00:55 | |
SpamapS | the elusive obvious | 01:00 |
SpamapS | corvus:thanks, I am sure I skimmed past it 4 times | 01:00 |
corvus | yeah, i think we need to add that to to the faq | 01:01 |
corvus | something like that should be more findable, and ideally be part of some narrative docs too | 01:01 |
jamesmcarthur | Yo Zuul! I'd like to tweet about the new Zuul release - congrats all btw!! | 01:03 |
jamesmcarthur | Any chance I can get a rough quote on what it means in plain-speak and perhaps what's coming down the pike next? | 01:04 |
*** jamesmcarthur has quit IRC | 01:07 | |
corvus | jamesmcarthur: actually, this relase was mostly to flush out the queue so that we can make 2 more releases over the next couple of days adding and removing support for ansible versions... i think if you hold off for another day or 2, you can talk about adding support for ansible 2.9. that's more interesting, and that way it doesn't get buried in 2 other releases. | 01:08 |
*** mhu has quit IRC | 01:15 | |
*** jamesmcarthur has joined #zuul | 01:24 | |
*** jamesmcarthur has joined #zuul | 01:24 | |
jamesmcarthur | Apologies. I inadvertently disconnected, but clarkb gave me the scoop | 01:25 |
jamesmcarthur | corvus: let me know a bit ahead of time when the next release will be and we can tee up some tweets and make sure we're all in agreement | 01:25 |
*** jamesmcarthur has quit IRC | 01:32 | |
*** igordc has quit IRC | 02:24 | |
*** dmellado has quit IRC | 02:45 | |
*** dmellado has joined #zuul | 02:48 | |
*** bhavikdbavishi has joined #zuul | 02:54 | |
*** bhavikdbavishi1 has joined #zuul | 02:57 | |
*** bhavikdbavishi has quit IRC | 02:58 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 02:58 | |
*** jamesmcarthur has joined #zuul | 03:40 | |
ianw | mnaser: https://zuul.opendev.org/t/zuul/build/7cf1dc94536f4c9c9bd59154782eba00/log/docker/nodepool_nodepool-builder_1.txt | 03:43 |
ianw | so that's a nodepool-builder container building an image | 03:43 |
ianw | doesn't work with the full functional test yet, but it's a start :) | 03:44 |
mnaser | ianw: yay. I’m clearing out some stuff on my hand to be able to help out a bit more | 03:44 |
mnaser | I’ve had a few interesting projects take up my time | 03:44 |
ianw | :) may you live in interesting times | 03:45 |
*** jamesmcarthur has quit IRC | 04:32 | |
*** raukadah is now known as chkumar|ruck | 05:23 | |
*** saneax has joined #zuul | 06:00 | |
*** jamesmcarthur has joined #zuul | 06:01 | |
*** jamesmcarthur has quit IRC | 06:06 | |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: enqueue: make trigger deprecated https://review.opendev.org/695446 | 06:34 |
*** sanjayu_ has joined #zuul | 06:37 | |
*** saneax has quit IRC | 06:40 | |
*** sanjayu__ has joined #zuul | 06:53 | |
*** sanjayu_ has quit IRC | 06:55 | |
*** themroc has joined #zuul | 07:26 | |
*** pcaruana has joined #zuul | 07:39 | |
openstackgerrit | Merged zuul/nodepool master: Dockerfile: add user to shadow file too https://review.opendev.org/693647 | 07:46 |
*** tosky has joined #zuul | 08:11 | |
*** sanjayu__ has quit IRC | 08:19 | |
*** sanjayu__ has joined #zuul | 08:19 | |
*** jcapitao has joined #zuul | 08:21 | |
*** hashar has joined #zuul | 08:43 | |
*** jpena|off is now known as jpena | 08:53 | |
*** sshnaidm|afk is now known as sshnaidm | 08:58 | |
*** mhu has joined #zuul | 09:21 | |
sshnaidm | hi, how can I define job so that I can use it in different projects? | 09:24 |
*** spsurya has joined #zuul | 09:25 | |
*** avass has joined #zuul | 09:32 | |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure: remove connectors burden and simplify code https://review.opendev.org/696134 | 09:59 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: authentication config: add optional max_token_age, skew https://review.opendev.org/642408 | 10:04 |
*** bhavikdbavishi has quit IRC | 10:12 | |
openstackgerrit | Merged zuul/zuul master: enqueue: make trigger deprecated https://review.opendev.org/695446 | 10:30 |
openstackgerrit | Fabien Boucher proposed zuul/zuul master: Pagure - Refresh token and recheck sign when token regenerated https://review.opendev.org/698208 | 10:33 |
*** hashar has quit IRC | 10:48 | |
*** jcapitao is now known as jcapitao|afk | 11:07 | |
*** rf0lc0 has quit IRC | 11:40 | |
*** bhavikdbavishi has joined #zuul | 12:17 | |
*** bhavikdbavishi1 has joined #zuul | 12:20 | |
*** bhavikdbavishi has quit IRC | 12:22 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 12:22 | |
*** jpena is now known as jpena|lunch | 12:34 | |
openstackgerrit | Albin Vass proposed zuul/nodepool master: Keys must be defined for host-key-checking: false https://review.opendev.org/698029 | 12:34 |
*** spsurya has quit IRC | 12:35 | |
avass | ^ that should fail since it only has the test without the fix | 12:35 |
avass | Don't really like having to add host_key_checking as an argument to the test since it already has that information in the config file but couldn't figure out a nice way to access it. | 12:37 |
openstackgerrit | Albin Vass proposed zuul/nodepool master: Keys must be defined for host-key-checking: false https://review.opendev.org/698029 | 12:48 |
*** jcapitao|afk is now known as jcapitao | 12:59 | |
*** sanjayu__ has quit IRC | 13:01 | |
*** rlandy has joined #zuul | 13:01 | |
*** hashar has joined #zuul | 13:06 | |
*** mhu has quit IRC | 13:07 | |
*** jamesmcarthur has joined #zuul | 13:15 | |
*** jamesmcarthur has quit IRC | 13:28 | |
*** jamesmcarthur has joined #zuul | 13:30 | |
fungi | sshnaidm: zuul provides ansible variables so you can identify what project triggered a build, and also provides correct source code state for the triggering repository, the repositories containing the job playbooks, and any repositories listed as required-projects, so making use of the context and source code zuul provides is most of what you need to think about in your cross-repository/shared job design | 13:31 |
fungi | also where that job is defined (trusted config repo vs normal untrusted repo) and what it contains (secrets in particular) can influence whether that job is able to be shared and whether it can be run in specific sorts of pipelines or whether it can speculatively test changes to the job components | 13:33 |
*** jamesmcarthur has quit IRC | 13:34 | |
fungi | anyway, depending on what you want to do it can be trivial or quite complicated | 13:34 |
*** jpena|lunch is now known as jpena | 13:37 | |
*** Goneri has joined #zuul | 13:43 | |
*** jamesmcarthur has joined #zuul | 13:46 | |
avass | uuh, I have a strange problem. A project that just got added isn't showing up in zuul after a full-reconfig and it's not reporting any errors. An ideas? | 13:51 |
avass | It shouldn't be a gerrit access problem since it uses the same rights as two other projects that are working | 13:52 |
fungi | avass: can you elaborate on what you mean when you say "reporting errors" (bell icon on the web dashboard? scheduler daemon log?) and "showing up" (projects tab in the web dashboard? something else?) | 14:00 |
*** chkumar|ruck is now known as raukadah | 14:26 | |
Petar_T | Hi all. | 14:34 |
Petar_T | I've a question on project dependencies and speculative merging. | 14:34 |
*** pcaruana has quit IRC | 14:36 | |
*** hashar has quit IRC | 14:38 | |
Petar_T | If you have projects Foo and Bar, and the former depends on the latter and they share a queue, if Bar currently has a running pipeline for a commit (let's call it A') and the pipeline for Foo is enqueued too, assuming that the dependency is only expressed via a required-projects entry, which commit of Bar will Zuul check out for Foo? HEAD on | 14:38 |
Petar_T | master, or A'? | 14:38 |
*** themroc has quit IRC | 14:55 | |
openstackgerrit | Merged zuul/nodepool master: Aws cloud-image is referred to from pool labels section https://review.opendev.org/697998 | 14:58 |
*** igordc has joined #zuul | 14:58 | |
*** pcaruana has joined #zuul | 15:01 | |
*** jamesmcarthur has quit IRC | 15:03 | |
tristanC | Petar_T: iiuc it depends of the pipeline or Foo commit message | 15:03 |
tristanC | Petar_T: if it's a dependent pipeline, e.g. gate, and if foo and bar share a queue and job have required-project, then when foo enter the gate, it will have A' in it's workspace | 15:04 |
tristanC | Petar_T: if it's an indepdendent pipeline, e.g. check, then foo can have A' in its workspace if foo commit message mensions a 'Depends-On: https://location-of/A'' | 15:05 |
fungi | projects don't really depend on other projects in zuul, jobs can depend on projects (meaning zuul should prepare and provide copies of them in the workspace), and changes can depend on other changes (either explicitly via depends-on commit message footers or implicitly based on the order in which they're enqueued into a dependent pipeline) | 15:05 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: authentication config: add optional token_expiry https://review.opendev.org/642408 | 15:09 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM][WIP] admin REST API: zuul-web integration https://review.opendev.org/643536 | 15:09 |
*** jamesmcarthur has joined #zuul | 15:15 | |
*** jamesmcarthur has quit IRC | 15:15 | |
*** jamesmcarthur_ has joined #zuul | 15:15 | |
Petar_T | tristanC: Thanks. That makes sense. | 15:16 |
Petar_T | fungi: Roger that. I'm still getting my terms straight. | 15:19 |
fungi | cool, mostly making sure you've got a grasp of the overall data model | 15:20 |
*** Petar_T has quit IRC | 15:24 | |
pabelanger | Is there an easy way to query zuul to check if a specific label is used by a job? | 15:33 |
avass | fungi: no errors in the dashboard or when running zuul tenant-conf-check | 15:33 |
pabelanger | Wanting to remove one in nodepool, and try to ensure now jobs are using it | 15:33 |
avass | fungi: it got fixed by restarting zuul completely | 15:33 |
fungi | avass: did you look in the scheduler daemon log? could have been reporting a reconfiguration failure there | 15:38 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: authentication config: add optional max_validity_time, skew https://review.opendev.org/642408 | 15:41 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM][WIP] admin REST API: zuul-web integration https://review.opendev.org/643536 | 15:42 |
clarkb | pabelanger: if you push removal of nodesets zuul will sanity check that. For labels its tricker because they arent verified config between zuul and nodepool. | 15:44 |
clarkb | pabelanger: you can prpbably ask zuul for a list of all nodesets then scan that for your label? | 15:44 |
corvus | i don't think we have a nodesets endpoint yet :( | 15:45 |
corvus | pabelanger: but you can use a script like tobiash or tristanC were discussing yesterday to crawl the jobs+project pipelines to check for labels | 15:45 |
corvus | i think they posted links if you check eavesdrop | 15:46 |
avass | fungi: I did, but couldn't find anything | 15:46 |
corvus | clarkb, pabelanger, fungi: how does this message look? https://etherpad.openstack.org/p/fyn4FVFo6v | 15:49 |
*** sugaar has quit IRC | 15:51 | |
clarkb | corvus: lgtm | 15:53 |
corvus | i'll send that to -announce | 15:53 |
fungi | slight vagueness in the first sentence | 15:54 |
fungi | might help to say that ansible 2.5 has been unsupported by its authors or community or something for quite some time | 15:54 |
fungi | since i first started reading it as indicating ansible 2.5 has been unsupported in zuul for quite some time, which then conflicted with the second part of the sentence | 15:55 |
fungi | the rest lgtm | 15:56 |
*** Petar_T has joined #zuul | 15:58 | |
Shrews | folks might want a pointer to how to set the ansible version | 15:58 |
mordred | corvus: the words you say about adding 2.9 before removing 2.5 giving the widest range of possibilities makes me think that we should be sure to incorporate that pattern when we make our policy | 15:59 |
corvus | Shrews, fungi: updated, thanks; mordred ++ | 16:00 |
fungi | lgtm! | 16:00 |
Shrews | ditto | 16:01 |
*** jcapitao is now known as jcapitao|afk | 16:02 | |
corvus | sent | 16:04 |
pabelanger | +1 to announce | 16:08 |
Shrews | corvus: should we send a notice to our zuul users as well informing them of the default version update? we should probably point to the 2.8 porting guide so they can see if they need to update their job playbooks (https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.8.html) | 16:09 |
Shrews | i'm not sure if there are any changes in that guide that might affect them. scanning now... | 16:09 |
*** igordc has quit IRC | 16:11 | |
Shrews | some of those changes seem noteworthy | 16:12 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Switch ansible_default to 2.8 https://review.opendev.org/676695 | 16:12 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Support Ansible 2.9 https://review.opendev.org/674854 | 16:12 |
pabelanger | k, that should rebase away 2.5 version drop | 16:13 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Remove support for ansible 2.5 https://review.opendev.org/650431 | 16:16 |
pabelanger | zuul-maint: order of ansible 2.9 patchset updated^ Should match the email corvus just sent | 16:17 |
mordred | pabelanger: ++ | 16:19 |
mordred | pabelanger: there's an issue on the drop-2.5 patch - otherwise stack looks good | 16:23 |
*** jcapitao|afk is now known as jcapitao | 16:24 | |
Shrews | pabelanger: mordred: none of those update the docs for https://zuul-ci.org/docs/zuul/user/config.html#attr-job.ansible-version that i can see | 16:24 |
pabelanger | Shrews: that should be generated dynamically, via ansible-manage | 16:26 |
pabelanger | mordred: looking | 16:26 |
Shrews | pabelanger: oh, neat! i didn't realize that | 16:27 |
openstackgerrit | Monty Taylor proposed zuul/zuul master: Extract an abstract base Parser class https://review.opendev.org/545610 | 16:28 |
mordred | Shrews: ^^ I fixed your review comments | 16:28 |
* Shrews does not remember what that was | 16:28 | |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Switch ansible_default to 2.8 https://review.opendev.org/676695 | 16:29 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Support Ansible 2.9 https://review.opendev.org/674854 | 16:29 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Remove support for ansible 2.5 https://review.opendev.org/650431 | 16:29 |
Shrews | mordred: oh, that one. i was stupid on my comments | 16:29 |
Shrews | mordred: i had left a +2 | 16:29 |
pabelanger | unrelated, is there open review to update install-docker role to support centos-8? | 16:30 |
corvus | jamesmcarthur_: see http://lists.zuul-ci.org/pipermail/zuul-announce/2019-December/000060.html 3.13.0 is coming up next, that's the one that adds ansible 2.9 support | 16:30 |
*** mhu has joined #zuul | 16:30 | |
corvus | mordred: lgtm, but holding +W until 3.14 | 16:32 |
jamesmcarthur_ | corvus: thanks! | 16:33 |
mordred | Shrews: well, your headline comment was bogus - but the inlines seemed still accurate? | 16:33 |
corvus | mordred: 676695 could use another +3 | 16:33 |
mordred | done! | 16:34 |
*** sugaar has joined #zuul | 16:36 | |
*** sgw has joined #zuul | 16:39 | |
*** jpena is now known as jpena|brb | 16:45 | |
*** sanjayu__ has joined #zuul | 16:47 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM][WIP] admin REST API: zuul-web integration https://review.opendev.org/643536 | 17:08 |
*** sanjayu__ has quit IRC | 17:18 | |
*** jpena|brb is now known as jpena | 17:24 | |
openstackgerrit | Merged zuul/zuul master: Switch ansible_default to 2.8 https://review.opendev.org/676695 | 17:24 |
*** tosky has quit IRC | 17:27 | |
*** rlandy is now known as rlandy|brb | 17:36 | |
openstackgerrit | Merged zuul/zuul master: Support Ansible 2.9 https://review.opendev.org/674854 | 17:40 |
corvus | do we want to do an opendev restart sanity check before releasing that, or just go ahead and tag it? | 17:41 |
clarkb | I'm happy to help with another restart, but will defer to others on their comfort level for deciding if that is necessary | 17:44 |
corvus | pabelanger: ^ do you have thoughts about the risk level there? | 17:45 |
*** rlandy|brb is now known as rlandy | 17:45 | |
pabelanger | I'd be okay with a restart first, and smoke test of 2.9 job | 17:48 |
corvus | cool, i'll get that started over in -infra | 17:48 |
pabelanger | If we can confirm say tox jobs works, we can then propose fixes to zuul-job as needed | 17:48 |
pabelanger | ++ | 17:48 |
*** sshnaidm is now known as sshnaidm|afk | 17:50 | |
*** jcapitao has quit IRC | 17:55 | |
*** rf0lc0 has joined #zuul | 18:22 | |
*** jamesmcarthur_ has quit IRC | 18:26 | |
*** jamesmcarthur has joined #zuul | 18:26 | |
*** jamesmcarthur has quit IRC | 18:36 | |
*** jpena is now known as jpena|off | 18:42 | |
*** bhavikdbavishi has quit IRC | 19:25 | |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Update tox-docs to ansible 2.9 job https://review.opendev.org/698316 | 19:30 |
fungi | so i guess per the discussion in #openstack-infra we need something like a .encode() on these two: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/library/tox_install_sibling_packages.py#L130-L131 | 19:35 |
*** igordc has joined #zuul | 19:39 | |
fungi | or maybe a default encoding a ways up on line 124 would solve it | 19:40 |
*** gmann is now known as gmann_afk | 19:40 | |
pabelanger | corvus: wonder if we should add an upgrade note about default switch to auto for 2.8 jobs | 19:50 |
corvus | pabelanger: not a bad idea | 19:50 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Add upgrade note about ansible_python_interpreter https://review.opendev.org/698318 | 20:07 |
*** hashar has joined #zuul | 20:07 | |
pabelanger | corvus: fungi: clarkb: how is ^ for info to user | 20:07 |
pabelanger | also | 20:09 |
pabelanger | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_047/698316/1/check/tox-pep8/0476433/ looks to have worked properly under ansible 2.9 | 20:09 |
pabelanger | 2019-12-10 19:57:05.784214 | Ansible Version: 2.9.2 | 20:09 |
pabelanger | \o/ | 20:09 |
*** pcaruana has quit IRC | 20:16 | |
clarkb | fungi: pabelanger I think the answer to that comment is yes | 20:20 |
corvus | pabelanger: are you planning on looking into the tox-siblings issue? | 20:24 |
corvus | fungi: or you? | 20:24 |
pabelanger | corvus: I can, but will need a little time, maybe tomorrow | 20:24 |
fungi | corvus: i can. just not sure the best way to test it. set an ansible version override on a change which runs a job we saw failing in opendev? | 20:24 |
pabelanger | fungi: yah, you can set ansible-version: 2.8 | 20:25 |
fungi | i have a feeling that role itself needs some tests added to the zuul-jobs repo | 20:25 |
clarkb | zuul tenant is still 2.8 default right? | 20:25 |
clarkb | so should just be tested that way on push? | 20:25 |
pabelanger | yes, 2.8 | 20:25 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Add upgrade note about ansible_python_interpreter https://review.opendev.org/698318 | 20:34 |
fungi | more generally though, should we have something at https://opendev.org/zuul/zuul-jobs/src/branch/master/zuul-tests.d/python-jobs.yaml which exercises the tox-siblings role? | 20:35 |
*** Goneri has quit IRC | 20:38 | |
corvus | yeah, i think that would be nice. maybe just a job with zuul and nodepool as siblings? | 20:42 |
corvus | could just inherit from tox-docs, then add both of those as required projects\ | 20:45 |
corvus | that might be all that's necessary | 20:45 |
openstackgerrit | Paul Belanger proposed zuul/zuul master: Add additional info for executor.merge_jobs release note https://review.opendev.org/698324 | 20:59 |
pabelanger | tristanC: ^ update to your reno note about executor.merge_jobs. Had to dig into git logs to understand more | 21:01 |
*** hashar has quit IRC | 21:59 | |
clarkb | fungi: for fixing tox siblings I think we should change the mode of the file open instaed of doing explicit encodes | 22:01 |
clarkb | fungi: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/library/tox_install_sibling_packages.py#L124 becomes (mode='w', delete=False) | 22:01 |
clarkb | the default mode is w+b | 22:01 |
clarkb | I think that reduces the python2 vs python3 checking we would have to do? | 22:02 |
corvus | i'm starting on a gce nodepool driver with the hope that we'll be able to use it for the gerrit project | 22:14 |
pabelanger | how does the governance of gerrit project work? I'm assuming that is still mostly out of google? | 22:18 |
corvus | pabelanger: there's a committee with google holding one vote more than 50% | 22:19 |
pabelanger | neat! I never really look into stateholders of the project, aside from google being involved | 22:20 |
corvus | google is about half of the contributions at this point | 22:20 |
pabelanger | thanks for info! | 22:21 |
openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Fix python3 compat in tox siblings handling https://review.opendev.org/698335 | 22:44 |
clarkb | fungi: pabelanger corvus ^ something like that maybe? The unittest confirms this is a fix for that particular function. Not sure if I got the job stuff correct though | 22:45 |
corvus | clarkb: that looks like it should do it | 22:47 |
*** mhu has quit IRC | 22:49 | |
*** gmann_afk is now known as gmann | 23:06 | |
openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Fix python3 compat in tox siblings handling https://review.opendev.org/698335 | 23:07 |
clarkb | I think ^ should work now | 23:07 |
clarkb | I used the wrong tox role var | 23:07 |
*** rlandy is now known as rlandy|bbl | 23:13 | |
clarkb | ok now it fails due to lack of bindeping | 23:20 |
fungi | yeah, needs libre2-dev i think | 23:25 |
openstackgerrit | Clark Boylan proposed zuul/zuul-jobs master: Fix python3 compat in tox siblings handling https://review.opendev.org/698335 | 23:27 |
clarkb | fungi: yup | 23:27 |
fungi | oh, indeed, we just weren't doing the thing with the stuff | 23:30 |
clarkb | it passes now | 23:33 |
clarkb | which implies it works for python3 in the whole role too | 23:33 |
clarkb | and the unittest covers that specific subset of functioanlity | 23:33 |
*** avass has quit IRC | 23:33 | |
*** Goneri has joined #zuul | 23:35 | |
fungi | tests.unit.test_v3.TestDiskAccounting.test_disk_accountant_kills_job under py37 and tests.unit.test_v3.TestPrePlaybooks.test_pre_playbook_fail under py35 both timed out "waiting for Zuul to settle" on 698318 | 23:36 |
fungi | and that was merely a release notes addition, so i don't think the change is to blame | 23:39 |
*** Goneri has quit IRC | 23:40 | |
*** sgw has quit IRC | 23:40 | |
*** rf0lc0 has quit IRC | 23:47 | |
openstackgerrit | James E. Blair proposed zuul/nodepool master: WIP: Add Google Cloud provider https://review.opendev.org/698342 | 23:47 |
corvus | that's super-wip -- there are a few methods to implement still. but it does implement the basic lifecycle -- create/delete | 23:48 |
*** rf0lc0 has joined #zuul | 23:49 | |
clarkb | corvus: https://review.opendev.org/#/c/698335/ should be ready now | 23:49 |
corvus | clarkb: +3 thanks! | 23:51 |
corvus | maybe tomorrow we'll remove the pin and see how things look, then make a release? | 23:51 |
corvus | after getting those relnotes changes merged | 23:51 |
clarkb | ++ | 23:51 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!