| openstackgerrit | Merged zuul/zuul master: zuul-manage-ansible: add validate option https://review.opendev.org/704701 | 00:05 |
|---|---|---|
| *** igordc has quit IRC | 00:06 | |
| *** Defolos has quit IRC | 00:16 | |
| openstackgerrit | Merged zuul/zuul master: executor: avoid duplicate debug logs https://review.opendev.org/705010 | 01:10 |
| *** jamesmcarthur has joined #zuul | 01:17 | |
| openstackgerrit | Merged zuul/zuul master: Add build history link to summary https://review.opendev.org/705049 | 01:19 |
| *** jamesmcarthur has quit IRC | 01:39 | |
| openstackgerrit | Merged zuul/zuul master: Offload repo reset to processes https://review.opendev.org/707095 | 01:48 |
| *** jamesmcarthur has joined #zuul | 01:51 | |
| *** jamesmcarthur has quit IRC | 02:01 | |
| openstackgerrit | Merged zuul/zuul master: Speed up test_inventory https://review.opendev.org/704570 | 02:06 |
| openstackgerrit | Merged zuul/zuul master: web: humanize time durations https://review.opendev.org/705120 | 02:29 |
| *** jamesmcarthur has joined #zuul | 02:48 | |
| openstackgerrit | Merged zuul/zuul master: Clarify RequirementError message https://review.opendev.org/707620 | 02:50 |
| *** sgw has quit IRC | 03:08 | |
| *** bhavikdbavishi has joined #zuul | 03:19 | |
| openstackgerrit | Merged zuul/zuul master: Gitlab - bootstrap the driver structure + Webhook support https://review.opendev.org/685682 | 03:24 |
| *** jamesmcarthur has quit IRC | 03:26 | |
| *** sgw has joined #zuul | 03:33 | |
| openstackgerrit | Merged zuul/zuul master: Gerrit checks: trigger new patchset behavior https://review.opendev.org/707729 | 03:43 |
| *** jamesmcarthur has joined #zuul | 03:48 | |
| *** NBorg has quit IRC | 03:51 | |
| *** bhavikdbavishi1 has joined #zuul | 04:28 | |
| *** bhavikdbavishi has quit IRC | 04:29 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 04:29 | |
| *** saneax has joined #zuul | 04:31 | |
| *** saneax has quit IRC | 04:35 | |
| *** saneax has joined #zuul | 04:38 | |
| *** jamesmcarthur has quit IRC | 04:58 | |
| *** jamesmcarthur has joined #zuul | 04:59 | |
| *** jamesmcarthur has quit IRC | 05:07 | |
| *** bolg has joined #zuul | 05:08 | |
| *** jamesmcarthur has joined #zuul | 05:10 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Set misfire grace time of apscheduler job https://review.opendev.org/707842 | 05:16 |
| *** jamesmcarthur has quit IRC | 05:22 | |
| *** jamesmcarthur has joined #zuul | 05:28 | |
| *** jamesmcarthur has quit IRC | 05:32 | |
| *** evrardjp has quit IRC | 05:34 | |
| *** evrardjp has joined #zuul | 05:34 | |
| openstackgerrit | Merged zuul/zuul master: Fix evaluation of range file_comments https://review.opendev.org/708076 | 06:05 |
| openstackgerrit | Merged zuul/zuul master: Gitlab - Basic handling of merge_requests event https://review.opendev.org/685990 | 06:07 |
| *** jamesmcarthur has joined #zuul | 06:08 | |
| *** jamesmcarthur has quit IRC | 06:14 | |
| *** felixedel has joined #zuul | 06:20 | |
| *** jamesmcarthur has joined #zuul | 06:30 | |
| *** jamesmcarthur has quit IRC | 06:35 | |
| openstackgerrit | Merged zuul/zuul master: Gitlab - Add zuul_event_id and set use get_annotated_logger https://review.opendev.org/692799 | 06:37 |
| *** felixedel has quit IRC | 06:44 | |
| *** raukadah is now known as chandankumar | 06:44 | |
| *** saneax has quit IRC | 06:49 | |
| *** saneax has joined #zuul | 06:49 | |
| *** felixedel has joined #zuul | 06:50 | |
| *** openstack has joined #zuul | 07:21 | |
| *** ChanServ sets mode: +o openstack | 07:21 | |
| *** openstack has joined #zuul | 07:45 | |
| *** ChanServ sets mode: +o openstack | 07:45 | |
| *** dpawlik has joined #zuul | 07:58 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: web: link to index.html if index_links is set https://review.opendev.org/705585 | 08:01 |
| *** bhavikdbavishi has quit IRC | 08:03 | |
| *** bhavikdbavishi has joined #zuul | 08:14 | |
| dSrinivas | Hi All, We have 2 Workers with one executor each and 2 Jobs. Each Job as to run on specific worker node label. Whenever the Zuul has the queued patches. It is not running on 2 workers parallel.How can I configure to run jobs parallel in Jenkins | 08:20 |
| *** armstrongs has joined #zuul | 08:25 | |
| *** jamesmcarthur has joined #zuul | 08:31 | |
| *** armstrongs has quit IRC | 08:34 | |
| *** jtanner has quit IRC | 08:34 | |
| *** jbryce has quit IRC | 08:35 | |
| *** Shrews has quit IRC | 08:35 | |
| *** jbryce has joined #zuul | 08:36 | |
| *** ChrisShort has quit IRC | 08:36 | |
| *** jamesmcarthur has quit IRC | 08:36 | |
| *** tosky has joined #zuul | 08:37 | |
| *** jtanner has joined #zuul | 08:37 | |
| *** ChrisShort has joined #zuul | 08:38 | |
| *** Shrews has joined #zuul | 08:38 | |
| *** tosky has quit IRC | 08:51 | |
| *** tosky has joined #zuul | 08:51 | |
| *** jpena|off is now known as jpena | 08:52 | |
| *** carli has joined #zuul | 08:54 | |
| *** felixedel has quit IRC | 09:17 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Uncap GitPython https://review.opendev.org/708593 | 09:25 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: A Zuul reporter for Elasticsearch https://review.opendev.org/644927 | 09:27 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: URLTrigger driver time based https://review.opendev.org/635567 | 09:32 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Uncap GitPython https://review.opendev.org/708593 | 09:33 |
| *** bhavikdbavishi has quit IRC | 09:34 | |
| *** bhavikdbavishi has joined #zuul | 09:36 | |
| *** bhavikdbavishi has quit IRC | 09:41 | |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: URLTrigger driver time based https://review.opendev.org/635567 | 09:42 |
| openstackgerrit | Merged zuul/zuul master: web: link to index.html if index_links is set https://review.opendev.org/705585 | 09:54 |
| *** felixedel has joined #zuul | 10:06 | |
| *** jcapitao has joined #zuul | 10:22 | |
| *** bhavikdbavishi has joined #zuul | 10:33 | |
| *** felixedel has quit IRC | 10:35 | |
| *** felixedel has joined #zuul | 10:38 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Implement basic github checks API workflow https://review.opendev.org/705168 | 10:41 |
| *** bhavikdbavishi1 has joined #zuul | 10:42 | |
| *** bhavikdbavishi has quit IRC | 10:43 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 10:43 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Authorization rules: add templating https://review.opendev.org/705193 | 10:47 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Support file comments via Github checks API https://review.opendev.org/708611 | 10:57 |
| *** sgw has quit IRC | 11:12 | |
| *** felixedel has quit IRC | 11:16 | |
| *** sgw has joined #zuul | 11:29 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Extracting scheduler in test base https://review.opendev.org/708621 | 11:35 |
| *** felixedel has joined #zuul | 11:39 | |
| felixedel | corvus: I've added the missing release notes to the Github checks API patch https://review.opendev.org/#/c/705168/ . I already prepared them yesterday but apparently forgot to update the change. | 11:42 |
| tobiash | corvus, clarkb: remote: https://review.opendev.org/708622 Add gear to zuul tenant | 11:42 |
| *** sshnaidm is now known as sshnaidm|afk | 11:47 | |
| swest | zuul-maint: we had some people complain about the verbosity of defining multiple jobs that only differ slightly. E.g. tox jobs for multiple Python versions and different platforms. I came up with a proof of concept to express this in the job config: https://review.opendev.org/#/c/708406/ Basically it's only syntactic sugar and the 'matrix job' will be expanded when the config is loaded. | 11:55 |
| *** carli has quit IRC | 12:10 | |
| *** mgoddard has quit IRC | 12:16 | |
| *** rfolco has joined #zuul | 12:18 | |
| *** mgoddard has joined #zuul | 12:21 | |
| *** jpena is now known as jpena|lunch | 12:34 | |
| *** jcapitao is now known as jcapitao_lunch | 12:35 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Implement basic github checks API workflow https://review.opendev.org/705168 | 12:38 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Support file comments via Github checks API https://review.opendev.org/708611 | 12:38 |
| *** rlandy has joined #zuul | 12:50 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 12:54 |
| *** Goneri has joined #zuul | 12:54 | |
| *** felixedel has quit IRC | 12:57 | |
| *** felixedel has joined #zuul | 13:00 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Support file comments via Github checks API https://review.opendev.org/708611 | 13:03 |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 13:04 |
| *** jamesmcarthur has joined #zuul | 13:17 | |
| *** felixedel has quit IRC | 13:24 | |
| *** felixedel has joined #zuul | 13:31 | |
| *** bhavikdbavishi1 has joined #zuul | 13:32 | |
| *** bhavikdbavishi has quit IRC | 13:32 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 13:32 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: WIP: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 13:34 |
| *** jamesmcarthur has quit IRC | 13:36 | |
| *** jpena|lunch is now known as jpena | 13:36 | |
| *** jcapitao_lunch is now known as jcapitao | 13:44 | |
| *** Goneri has quit IRC | 13:47 | |
| *** jamesmcarthur has joined #zuul | 13:48 | |
| *** swest has quit IRC | 13:54 | |
| *** jamesmcarthur has quit IRC | 14:14 | |
| *** felixedel has quit IRC | 14:25 | |
| *** Goneri has joined #zuul | 14:25 | |
| *** dSrinivas has quit IRC | 14:26 | |
| *** jamesmcarthur has joined #zuul | 14:32 | |
| *** jamesmcarthur_ has joined #zuul | 14:33 | |
| *** jamesmcarthur has quit IRC | 14:36 | |
| *** swest has joined #zuul | 14:45 | |
| *** sshnaidm|afk is now known as sshnaidm | 14:52 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Extracting scheduler in test base https://review.opendev.org/708621 | 14:52 |
| bolg | tristanC: Thanks for review, I renamed the wrapper class after discussion with tobias: ^^^ | 14:54 |
| tristanC | bolg: i meant to suggest another name for wrapper, but couldn't find one. App sounds good too :) | 14:55 |
| *** irclogbot_1 has quit IRC | 14:56 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 14:57 |
| bolg | tristanC: it actually act a bit like a zuul app now, see self.sched.setZuulApp(self) | 14:57 |
| tristanC | bolg: perhaps Fixture could works too? I don't mind either way. Thank you for splitting the branch cache changes, it's easier to review smaller diff | 14:58 |
| *** irclogbot_3 has joined #zuul | 15:03 | |
| *** bhavikdbavishi has quit IRC | 15:17 | |
| *** johanssone has quit IRC | 15:24 | |
| *** plaurin has joined #zuul | 15:26 | |
| plaurin | Hello IRC people :) | 15:26 |
| plaurin | Good <insert time of the day> | 15:26 |
| *** johanssone has joined #zuul | 15:27 | |
| tobiash | what's up? | 15:28 |
| plaurin | Happily using the kubernetes (openshift) zuul/nodepool implementation. Seems to work really well | 15:29 |
| tobiash | :) | 15:29 |
| plaurin | However I do get angry stares at me because of the missing stdout streaming with the kubectl plugin :( Any update on this upcoming feature? :) | 15:29 |
| tobiash | there was discussion about how to implement it, but I don't know if anyone is actively working on that | 15:31 |
| clarkb | tobiash: the idea was to have the pod process act as log streamer daemon? | 15:32 |
| clarkb | (to refresh my memory on where that ended up) | 15:32 |
| tobiash | clarkb: the idea was to normally run the zuul_stream module in the pod and refactor the log streaming in the console callback | 15:33 |
| tobiash | (so it can open a kubectl port-forward before streaming) | 15:33 |
| tristanC | i thought ansible log streaming was a common request, shouldn't this be worked on with upstream ansible directly instead of within zuul? | 15:33 |
| tobiash | I don't think it'll be super complicated, just some work | 15:33 |
| tobiash | tristanC: that would be ideal. I think mordred was working at some point in time towards that goal, but I guess got stuck somewhere in the discussion | 15:34 |
| tristanC | tobiash: what about making the console-stream prints the task results as a regular ansible-playbook -v output for kubectl connection? | 15:36 |
| tobiash | tristanC: that should already be the case, what's not working is live streaming for longer running tasks (same is the case for windows btw) | 15:37 |
| tristanC | tobiash: i meant, the stdout is not part of the stream or console-output.txt | 15:38 |
| tristanC | it's not exactly helping for long running task, but that would be better than nothing | 15:38 |
| tobiash | tristanC: is it really like this? When not streaming the callback should already do this | 15:39 |
| plaurin | yeah basically it's the stdout of the shell we don't see, but we see the tasks running and it's result. just missing the output of the shell itself | 15:39 |
| tobiash | then that's also a bug in the callback | 15:39 |
| plaurin | I can show you some examples between a static node and a kubectl node | 15:40 |
| corvus | tristanC: log streaming in ansible requires major refactoring by the ansible core team which they plan to do; it's not something we're likely to be able to help with at this point | 15:40 |
| tristanC | tobiash: yes, tasks just prints `TASK [tox : Run tox]` then `fedora-30 | ok: Runtime: 0:00:04.199655` | 15:41 |
| tobiash | check out https://opendev.org/zuul/zuul/src/branch/master/zuul/ansible/base/callback/zuul_stream.py#L489 | 15:42 |
| tobiash | maybe there is some flaw in there for tasks with k8s connection | 15:43 |
| tristanC | tobiash: perhaps because of https://opendev.org/zuul/zuul/src/branch/master/zuul/ansible/base/callback/zuul_stream.py#L269 ? | 15:43 |
| corvus | tristanC, tristanC, plaurin: regarding log streaming, i think this idea from tobiash was the best we came up with: http://eavesdrop.openstack.org/irclogs/%23zuul/%23zuul.2020-02-03.log.html#t2020-02-03T19:30:52 | 15:44 |
| tobiash | tristanC: I think this needs to be changed to also process kubectl connection in addition to local tasks: https://opendev.org/zuul/zuul/src/branch/master/zuul/ansible/base/callback/zuul_stream.py#L298 | 15:45 |
| tobiash | or streaming | 15:45 |
| tobiash | (which should solve that issue as well) | 15:45 |
| corvus | tobiash: yeah, i think maybe fixing 298 is easier? so maybe do that first to fix the "bug", then add streaming to add the new "feature" | 15:46 |
| corvus | (unless you think it's easier to jump straight to streaming?) | 15:46 |
| tristanC | corvus++ | 15:46 |
| plaurin | here's a pastebin of the diff between a regular static node vs kubernetes node streaming | 15:47 |
| plaurin | https://pastebin.com/qbEfjzdj | 15:47 |
| tobiash | corvus: correct, I think that order makes sense :) | 15:47 |
| tristanC | for runc i tried to make the zuul_console and zuul_stream behave differently based on the connection type, and iirc that requires quite a few changes | 15:47 |
| tristanC | though, iiuc the port-forward proposal, then we don't have to change the zuul_console daemon right? | 15:48 |
| tobiash | tristanC: zuul_console daemon can be unchanged when we implement the streaming refactor in the callback | 15:49 |
| *** jcapitao is now known as jcapitao_afk | 15:54 | |
| *** bolg has quit IRC | 15:55 | |
| openstackgerrit | Merged zuul/zuul master: Implement basic github checks API workflow https://review.opendev.org/705168 | 15:57 |
| *** rishabhhpe has joined #zuul | 15:57 | |
| rishabhhpe | Hell All , i had setup and third party ci using zuul v3 and nodepool .. my zuul scheduler ,executor and nodepool builder ,launcher both are working fine but still it is not triggering a build also i am not seeing any errors in logs . can u please let me know how i can start troubleshooting of this | 15:58 |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 16:09 |
| *** jcapitao_afk is now known as jcapitao | 16:10 | |
| openstackgerrit | Merged zuul/zuul master: gear: remove support for custom MASS_DO packet https://review.opendev.org/704742 | 16:12 |
| tristanC | rishabhhpe: perhaps could you paste the zuul tenant config, and the pipeline configuration from your config project? | 16:14 |
| rishabhhpe | ok | 16:14 |
| rishabhhpe | Please find it here -: http://paste.openstack.org/show/789758/ | 16:17 |
| rishabhhpe | also when i am triggering the job manually with zuul enqueue command job status is going to unknown and no error is publishing in logs | 16:18 |
| tristanC | rishabhhpe: and is there a pipeline config for openstack/cinder ? | 16:19 |
| rishabhhpe | tristanC: i did not get what u are reffering here ? i had only this file which i shared with you apart from that there is config files and playbooks for job | 16:20 |
| tristanC | rishabhhpe: do you have such object in your config project: '{ project: { name: openstack/cinder, check: {jobs: [...]} } }' ? e.g. to associate check job for cinder | 16:23 |
| rishabhhpe | yes i have that wait let me share it with you | 16:24 |
| rishabhhpe | tristanC: please find it here -: http://paste.openstack.org/show/789759/ | 16:26 |
| tristanC | rishabhhpe: alright, that seems good. then the scheduler.log would probably help figure out the issue | 16:27 |
| rishabhhpe | in scheduler i am not seeing any error | 16:27 |
| tristanC | on restart, you should check no config errors happen, (e.g. missing base job, gerrit connection failure, ...), and on event there should be message about job graph being created | 16:29 |
| tristanC | and in the executor.log, you should see the job context being prepared, perhaps there is a missing role or a failure to connect to the nodepool node | 16:30 |
| Shrews | i don't understand the use of the cinder "exclude" options there in the first paste. looks like all config items are being ignored? | 16:31 |
| tristanC | Shrews: for third-party-ci, you don't want to load objects from the upstream .zuul.yaml configuration. it usualy fails because of missing nodeset or job | 16:31 |
| Shrews | tristanC: oh, ok, yeah. makes sense for 3rd party | 16:32 |
| tristanC | iirc that could be simplified with `include: []` | 16:32 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: docs: move components to reference https://review.opendev.org/708686 | 16:34 |
| tristanC | Shrews: i had trouble finding the zuul.conf documentation, any reason why components are not in the reference section? (as proposed in ^) | 16:35 |
| Shrews | i also assume there is a valid "connection gerrit" entry in zuul.yaml. I suppose there'd be a config error if that was missing | 16:35 |
| tristanC | Shrews: i guess you meant `zuul.conf` ^ | 16:35 |
| Shrews | tristanC: iirc, they were moved again to user/admin ref sections | 16:35 |
| Shrews | tristanC: oops, yes | 16:35 |
| *** Defolos has quit IRC | 16:36 | |
| Shrews | tristanC: oh, misunderstood your doc question. yeah, i dunno why it's not in ref | 16:38 |
| Shrews | maybe because it fits both categories (discussion/reference) | 16:38 |
| tristanC | Shrews: yeah, some content looks like discussion about the distributed nature of the components, but most of the file does look like a configuration reference | 16:39 |
| Shrews | might be worth splitting up | 16:39 |
| tristanC | Shrews: which i started to do, but that's a lot more work than moving it all to ref :) | 16:40 |
| *** mattw4 has joined #zuul | 16:54 | |
| *** igordc has joined #zuul | 16:59 | |
| *** plaurin has quit IRC | 17:06 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 17:11 |
| *** rishabhhpe has quit IRC | 17:15 | |
| *** tosky has quit IRC | 17:16 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 17:16 |
| openstackgerrit | Matthew Thode proposed zuul/zuul-jobs master: DNM: test longer timeout for gentoo-multinode https://review.opendev.org/708702 | 17:20 |
| *** jcapitao is now known as jcapitao_away | 17:24 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests bindep role on all-platforms https://review.opendev.org/708704 | 17:26 |
| *** evrardjp has quit IRC | 17:34 | |
| *** evrardjp has joined #zuul | 17:34 | |
| *** rishabhhpe has joined #zuul | 17:43 | |
| *** igordc has quit IRC | 17:46 | |
| *** Defolos has joined #zuul | 17:49 | |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: Tests ensure-tox on all-platforms https://review.opendev.org/708642 | 17:51 |
| *** jpena is now known as jpena|off | 18:00 | |
| openstackgerrit | Merged zuul/zuul-operator master: Setup Prelude and Kubernetes binding https://review.opendev.org/702104 | 18:00 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: DNM: Test zuul with gear with darwin support https://review.opendev.org/708714 | 18:05 |
| Shrews | since when does the opendev zuul leave a +2 instead of a +1? | 18:10 |
| mordred | Shrews: since forever | 18:10 |
| Shrews | really? why have i not noticed this then... | 18:10 |
| mordred | Shrews: it leaves +2 in the gate, +! in check | 18:10 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: DNM: Test zuul with gear with broken darwin support https://review.opendev.org/708720 | 18:10 |
| mordred | +1 | 18:10 |
| Shrews | mordred: oh, it confused me b/c it is not merged | 18:11 |
| Shrews | ah, the workflow was removed | 18:12 |
| Shrews | ok, sanity restored | 18:12 |
| mordred | Shrews: \o/ | 18:12 |
| mordred | Shrews: wait - there was sanity? | 18:12 |
| Shrews | it doesn't imply full sanity, just a partial restoration :) | 18:13 |
| fungi | asymptotically approaching sanity | 18:14 |
| Shrews | yeah, what he said | 18:15 |
| *** reiterative has quit IRC | 18:16 | |
| *** reiterative has joined #zuul | 18:18 | |
| *** reiterative has quit IRC | 18:19 | |
| *** igordc has joined #zuul | 18:22 | |
| mnaser | can a zuul secret contain both secrets *and* normal plain text values? | 18:25 |
| corvus | mnaser: yes and we frequently do that in opendev and zuul projects | 18:25 |
| fungi | mnaser: yep | 18:25 |
| mnaser | hmm, ok, so i'll have to go back to the drawing board as to why my post job isn't working then | 18:25 |
| fungi | and yeah, look in the openstack/project-config repo for numerous examples | 18:25 |
| mnaser | https://www.irccloud.com/pastebin/S0DtQK0n/ | 18:26 |
| corvus | zuul-maint: i think this spec for allowing circular dependencies is ready to merge: https://review.opendev.org/643309 last call for reviews. let me know if you need more time to review, otherwise i'll approve it tomorrow | 18:26 |
| mnaser | and inside my secret, i have both values in there, but my job seems to be failing due to the fact that it gets an empty string | 18:26 |
| tobiash | :) | 18:27 |
| corvus | mnaser: what's going wrong? error, or does it not appear to be used? | 18:27 |
| openstackgerrit | Merged zuul/zuul-operator master: Replace existing operator tasks with the new dhall function https://review.opendev.org/702106 | 18:27 |
| mnaser | i have a task that waits for the environment varaible NETBOX_URL to 'show up' | 18:27 |
| mnaser | and it works with my normal check/gate, but fails in post with: FAILED - RETRYING: Wait for Netbox API to be available (1 retries left). fatal: [localhost]: FAILED! => {"attempts": 300, "changed": false, "msg": "unknown url type: ''", "status": -1, "url": ""} | 18:28 |
| mnaser | which seems to sound like the thing that specific the url (environment variable) is coming up as empty | 18:28 |
| mnaser | https://www.irccloud.com/pastebin/rvTS7Gwc/ | 18:29 |
| mnaser | to me that should use tox_environment from the secret in the post job (-apply) | 18:29 |
| mnaser | and my check/gate job works just fine so the logic works | 18:30 |
| mnaser | i'm not seeing zuul showing any "decryption failed" errors either | 18:30 |
| mordred | mnaser: so - I believe that's expected | 18:30 |
| mnaser | oh, well that's good | 18:31 |
| mordred | mnaser: because the tox job is a parent job, so the secret is not available to the tox roles from that layer of the onion | 18:31 |
| mnaser | ahhhh yes | 18:31 |
| mordred | we added a thing to help with that though ... | 18:31 |
| mordred | corvus: pass-to-parent or something right? | 18:32 |
| mnaser | yes i remember seeing that | 18:32 |
| corvus | yep, pass-to-parent: true | 18:32 |
| *** rishabhhpe has quit IRC | 18:32 | |
| corvus | https://zuul-ci.org/docs/zuul/reference/job_def.html#attr-job.secrets.pass-to-parent | 18:32 |
| mordred | yeah | 18:32 |
| mordred | woot. I even remembered the name | 18:32 |
| mnaser | from a zuul pov, i wonder if we should give some sort of warning.. | 18:32 |
| mnaser | like a logged "zuul secret <foo> not passed to playbooks/tox/run.yaml due to .." | 18:33 |
| corvus | mnaser: the main thing to know is that makes the secret available to all the playbooks in all the parent jobs. so you have to trust not only netbox-apply, but also netbox, tox, and base. that seems reasonable to me in this circumstance. | 18:33 |
| corvus | mnaser: i agree, some way of visualizing what secrets are available to what playbooks would be good, but maybe not logging that case, since that's the usual case | 18:34 |
| corvus | maybe we could have the json job log include what secrets are available? | 18:34 |
| mnaser | yes perhaps like 'secrets passed' or something along those lines so the user has an idea of what is being shared | 18:34 |
| fungi | for that matter, the job browser could expose that somehow | 18:34 |
| corvus | so when you're looking at the list of playbooks in the "console" log tab, right now where it says trusted, it could also list what secrets are there? | 18:34 |
| mordred | also - there is a specific case here which is that the job attaching the secret does not define any playbooks itself - all it's doing is adding a secret | 18:35 |
| corvus | fungi: well, it sort of does, but i don't think that would help in this case because of things like that ^ | 18:35 |
| mordred | so maybe it's possible to emit a warning in the specific case of a job that adds a secrets but has no associated playbooks? | 18:35 |
| fungi | ahh, yeah, okay | 18:35 |
| corvus | mordred: oh, yeah, that would be an okay instance to warn as mnaser suggests | 18:36 |
| corvus | since that is not typical | 18:36 |
| mordred | yeah - and almost always a case when the person wants pass-to-parent | 18:36 |
| mordred | zuul-upload-image meets that model too | 18:36 |
| corvus | fungi: a frozen job browser that showed that would be helpful (since it would know all the playbooks to be run in a job) | 18:37 |
| fungi | yep | 18:37 |
| mnaser | so pretty much a job with no playbooks defined, secret(s) and a parent job defined should essentially result in a warning because it will inherently be broken? | 18:38 |
| *** jamesmcarthur has joined #zuul | 18:39 | |
| mnaser | because that secret will never be in use | 18:39 |
| mordred | yeah - either the person forgot pass-to-parent - or forgot to git add a playbook | 18:39 |
| mnaser | wonder if we should block merging that sort of config | 18:40 |
| openstackgerrit | Merged zuul/zuul-operator master: Generate TLS certificats for the gearman service https://review.opendev.org/702716 | 18:41 |
| *** jamesmcarthur_ has quit IRC | 18:41 | |
| corvus | i think could see that being an error instead of a warning. at least, i can't think of a reason not to. | 18:41 |
| mordred | mmm. certifi cats | 18:41 |
| mnaser | :p | 18:41 |
| mordred | corvus: yah. I'm really trying to come up with a counter example where it's a valid life decision | 18:42 |
| mnaser | and you can't create a child job from a job that has a secret i assume | 18:42 |
| mordred | you can - but it's also not going to get the secret | 18:42 |
| mordred | so your job with only secret is still bong | 18:43 |
| fungi | potentially useful if you want to inherit from it for a check job that supplies its own substitute not-secret test vectors i guess | 18:43 |
| mnaser | but then you can just inherit the parent of that one directly | 18:43 |
| fungi | but yeah, in that specific case you could just inherit from the parent, no point in inheriting from the secret-only child | 18:44 |
| corvus | mordred: i tried a google search for a "certifi cats" meme and found nothing! this could be your breakout moment! | 18:44 |
| mordred | corvus: you're going to make me buy another useless domain aren't you? | 18:44 |
| corvus | mordred: remember us little people when you're a meme star | 18:44 |
| mordred | I have a friend from CalArts who recently blew up on TikTok | 18:45 |
| corvus | that sounds... messy | 18:45 |
| mordred | it was apparently a very surreal experience | 18:45 |
| * fungi has to look up what a tiktok is now... presumably nothing like a tic-tac | 18:45 | |
| corvus | every story i've heard that involved calarts could be described as surreal, usually intentionally so i think | 18:46 |
| * mnaser watches post console logs | 18:46 | |
| mordred | corvus: https://www.patreon.com/posts/33233625 | 18:46 |
| fungi | "video-sharing social networking service" thanks wikipedia! | 18:46 |
| mordred | "What It Feels Like To Have A Song Go Viral On TikTok" | 18:47 |
| Shrews | fungi: wait... i just migrated to myspace | 18:47 |
| Shrews | that's not the latest thing? | 18:47 |
| mordred | fungi: actually, jonathan's article might be a good read - he didn't realy know what it was either | 18:47 |
| fungi | heh, will check it out then | 18:47 |
| openstackgerrit | Merged zuul/zuul-operator master: Add zuul-operator-promote-image job https://review.opendev.org/704187 | 18:47 |
| mordred | also - the song in question was the "Baby Yoda" song :) | 18:48 |
| clarkb | I've never heard this song | 18:49 |
| Shrews | mordred: well now i have to hear it | 18:49 |
| clarkb | shows how connected to sicial media I am | 18:49 |
| mordred | clarkb: you're probably not 11 years old | 18:50 |
| mnaser | im just gonna hide | 18:51 |
| mordred | Shrews: I hadn't actually listened to it until now - but now I have | 18:53 |
| openstackgerrit | Matthew Thode proposed zuul/zuul-jobs master: set jobs for installing openvswitch https://review.opendev.org/708727 | 18:57 |
| *** sugaar has quit IRC | 19:00 | |
| mnaser | wewt, pass-to-parent did it | 19:01 |
| mnaser | now i have some other ssl related failure ill have to figure out | 19:01 |
| mnaser | but that's another thing | 19:01 |
| mnaser | `Status code was -1 and not [200]: Request failed: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1056)>` -- probably missing local certs.. or something | 19:01 |
| openstackgerrit | Merged zuul/zuul-operator master: Handle service restart when connections are changed https://review.opendev.org/703624 | 19:01 |
| mnaser | is my internet here questionable | 19:08 |
| mnaser | or am i unable to run git review | 19:08 |
| mnaser | seems to be stuck at 'git remote update gerrit' | 19:08 |
| mnaser | i can ssh mnaser@review.opendev.org -p29418 .. | 19:09 |
| fungi | load average on gerrit seems high-ish (~4), but i'm not in a good position to dig into it | 19:10 |
| openstackgerrit | Mohammed Naser proposed zuul/zuul master: configloader: validate playbook-less + secret jobs https://review.opendev.org/708731 | 19:10 |
| mnaser | came through but either my internet here is bad (which it has been..) or something is up there | 19:10 |
| mnaser | corvus, mordred, fungi: ^ i think i'm in the right place, but i am not sure where to add unit tests because tests/unit/configparser.py didnt have any job tests so i'm unsure... | 19:10 |
| fungi | looking through history in cacti, this is typical system load on the server, so that's probably not it | 19:12 |
| fungi | memory pressure looks okay too | 19:13 |
| *** armstrongs has joined #zuul | 19:22 | |
| *** armstrongs has quit IRC | 19:23 | |
| corvus | mnaser: iirc on the executor we do usually map in to bwrap the normal directory for ssl certs, but if you have some installed in a different location, you may need to add another directory (or maybe they just aren't installed on your executor) | 19:24 |
| mnaser | corvus: after doing some research that was because i didnt include the letsencrypt fullchain cert in nginx so my browser (firefox) worked fine but python wasnt happy | 19:24 |
| corvus | aha | 19:25 |
| corvus | mnaser: i'll get you an answer on tests in a sec | 19:25 |
| openstackgerrit | Matthew Thode proposed zuul/zuul-jobs master: set jobs for installing openvswitch https://review.opendev.org/708727 | 19:33 |
| corvus | mnaser: you could add it to test_v3.TestSecretPassToParent -- i think you can add a test that does an in-repo config update of .zuul.yaml and then looks for the error. the (unrelated test) test_protected_inherit_not_ok is like that. | 19:36 |
| corvus | pabelanger: some github checks api stuff landed -- do you want to try using that in z.a.c? | 19:39 |
| *** michael-beaver has joined #zuul | 19:53 | |
| *** sshnaidm is now known as sshnaidm|afk | 19:54 | |
| *** reiterative has joined #zuul | 19:56 | |
| *** jamesmcarthur has quit IRC | 20:06 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: store secret names in console json https://review.opendev.org/708736 | 20:07 |
| corvus | mnaser, mordred, fungi: ^ that's a start on the "expose secrets on the playbook ui" idea. i think i'm in favor of the change i describe in the last pgraph of the commit message, but wanted to check in with other folks before i go further (because we currently lose that data when we ship it from the scheduler to the executor, so it's a slightly bigger change) | 20:08 |
| mordred | corvus: reading | 20:46 |
| mordred | corvus: yeah - I also think I'm in favor of the change you describe | 20:47 |
| *** jamesmcarthur has joined #zuul | 21:07 | |
| *** jamesmcarthur has quit IRC | 21:07 | |
| *** jamesmcarthur has joined #zuul | 21:07 | |
| *** jamesmcarthur has quit IRC | 21:19 | |
| *** jamesmcarthur has joined #zuul | 21:21 | |
| corvus | mordred: i think https://review.opendev.org/621479 is safe for you to re-add your +2 without re-review | 21:25 |
| *** jamesmcarthur has quit IRC | 21:26 | |
| corvus | SpamapS, Shrews, tristanC, clarkb: the scale-out scheduler spec is probably ready for a final re-review from you if/when you have time: https://review.opendev.org/621479 | 21:28 |
| *** yolanda has quit IRC | 21:38 | |
| *** yolanda has joined #zuul | 21:52 | |
| *** jamesmcarthur has joined #zuul | 21:56 | |
| *** jamesmcarthur has quit IRC | 21:58 | |
| *** jamesmcarthur has joined #zuul | 21:58 | |
| *** tosky has joined #zuul | 22:00 | |
| *** yolanda has quit IRC | 22:06 | |
| *** jamesmcarthur_ has joined #zuul | 22:09 | |
| *** michael-beaver has quit IRC | 22:13 | |
| *** jamesmcarthur has quit IRC | 22:13 | |
| *** saneax has quit IRC | 22:16 | |
| *** dpawlik has quit IRC | 22:21 | |
| openstackgerrit | Merged zuul/zuul master: Extracting scheduler in test base https://review.opendev.org/708621 | 22:26 |
| *** rlandy is now known as rlandy|bbl | 23:28 | |
| *** jamesmcarthur_ has quit IRC | 23:32 | |
| *** jamesmcarthur has joined #zuul | 23:33 | |
| *** tosky has quit IRC | 23:34 | |
| *** jamesmcarthur has quit IRC | 23:39 | |
| SpamapS | corvus: neeeeatttoooo | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!