Thursday, 2020-04-16

*** cdearborn has quit IRC00:01
*** jamesmcarthur has joined #zuul00:27
*** jamesmcarthur has quit IRC00:36
*** jamesmcarthur has joined #zuul00:58
*** swest has quit IRC01:16
*** jamesmcarthur has quit IRC01:26
*** jamesmcarthur has joined #zuul01:26
*** swest has joined #zuul01:32
*** jamesmcarthur has quit IRC01:32
*** jamesmcarthur has joined #zuul02:04
*** jamesmcarthur_ has joined #zuul02:07
*** jamesmcarthur has quit IRC02:11
*** jamesmcarthur_ has quit IRC02:13
*** jamesmcarthur has joined #zuul02:41
*** jamesmcarthur has quit IRC02:43
*** jamesmcarthur has joined #zuul02:44
*** jamesmcarthur_ has joined #zuul03:02
*** jamesmcarthur has quit IRC03:05
openstackgerritMerged zuul/nodepool master: config_validator: refactor the schema to a static method  https://review.opendev.org/71858203:15
*** threestrands has joined #zuul03:29
*** zxiiro has joined #zuul03:56
*** jamesmcarthur has joined #zuul04:06
*** jamesmcarthur_ has quit IRC04:09
*** bhavikdbavishi has joined #zuul04:21
*** jamesmcarthur has quit IRC04:22
*** jamesmcarthur has joined #zuul04:23
*** bhavikdbavishi1 has joined #zuul04:26
*** bhavikdbavishi has quit IRC04:26
*** bhavikdbavishi1 is now known as bhavikdbavishi04:26
*** jamesmcarthur has quit IRC04:28
*** jamesmcarthur has joined #zuul04:30
*** jamesmcarthur has quit IRC04:30
*** jamesmcarthur has joined #zuul04:36
*** evrardjp has quit IRC04:37
*** evrardjp has joined #zuul04:37
*** jamesmcarthur has quit IRC04:38
*** jamesmcarthur has joined #zuul04:39
*** jamesmcarthur has quit IRC04:47
*** jamesmcarthur has joined #zuul05:14
*** sgw has quit IRC05:34
*** ysandeep is now known as ysandeep|brb05:38
*** bhavikdbavishi has quit IRC05:38
*** reiterative has quit IRC05:43
*** reiterative has joined #zuul05:43
*** bhavikdbavishi has joined #zuul05:49
*** saneax has joined #zuul06:01
*** jamesmcarthur_ has joined #zuul06:16
*** jamesmcarthur has quit IRC06:20
*** jamesmcarthur_ has quit IRC06:21
*** ysandeep|brb is now known as ysandeep06:34
*** gtema has joined #zuul06:45
*** dpawlik has joined #zuul06:49
*** jamesmcarthur has joined #zuul06:54
*** yolanda has quit IRC07:08
*** yolanda has joined #zuul07:09
*** jcapitao has joined #zuul07:14
*** bhavikdbavishi has quit IRC07:14
*** tflink has quit IRC07:29
*** tflink_ has joined #zuul07:29
*** rpittau|afk is now known as rpittau07:34
*** tosky has joined #zuul07:38
*** jpena|off is now known as jpena07:53
*** zxiiro has quit IRC07:55
*** bhavikdbavishi has joined #zuul08:08
*** bhavikdbavishi has quit IRC08:18
*** bhavikdbavishi has joined #zuul08:23
*** threestrands has quit IRC08:45
*** harrymichal has joined #zuul08:49
*** ysandeep is now known as ysandeep|lunch08:53
*** jamesmcarthur has quit IRC08:55
*** newbie999 has joined #zuul09:11
newbie999Hi guys!09:11
newbie999Does the Zuul timer driver use UTC time?09:12
newbie999https://zuul-ci.org/docs/zuul/reference/drivers/timer.html09:12
*** gtema has left #zuul09:12
newbie999does not say, but it seems it uses whatever local time has been configured on the scheduler/executor09:12
tobiashnewbie999: zuul uses apscheduler in its default settings: https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/timer/__init__.py#L3509:34
tobiashwhich probably defaults to the timezone defined by the locale09:34
newbie999thanks! That is a good starting point to investigate it09:36
newbie999https://apscheduler.readthedocs.io/en/stable/userguide.html09:37
newbie999it seems you could tell apscheduler to use UTC, but that is not the default09:37
*** bhavikdbavishi has quit IRC09:39
openstackgerritJan Kubovy proposed zuul/zuul master: Separate connection registries in tests  https://review.opendev.org/71295810:03
*** bhavikdbavishi has joined #zuul10:09
*** harrymichal has quit IRC10:19
*** harrymichal has joined #zuul10:19
*** rpittau is now known as rpittau|bbl10:19
*** ysandeep|lunch is now known as ysandeep10:22
*** harrymichal has quit IRC10:24
*** harrymichal has joined #zuul10:24
*** yolanda has quit IRC10:26
msuszkoHi! I'm looking for a clue: I'd like to prepare check and gate project jobs do an app in docker. Dockerfile has build, and release stages. Release stage would be uploaded published - obviously, but i'd like to run tests in build stage. Maybe add test stage with extra tools and run tests there.10:34
msuszkoShould I use buildset registry for this?10:35
*** yolanda has joined #zuul10:38
msuszkoI just got it working, but run-buildset-registry and use-buildset-registry alone take over 4 minutes with tiny image.10:38
*** rfolco has joined #zuul10:50
*** jamesmcarthur has joined #zuul10:53
*** jcapitao is now known as jcapitao_lunch10:53
*** newbie999 has quit IRC10:56
*** avass has quit IRC11:06
*** ysandeep is now known as ysandeep|afk11:15
*** jpena is now known as jpena|lunch11:30
*** cdearborn has joined #zuul11:37
*** ysandeep|afk is now known as ysandeep11:47
*** dpawlik has quit IRC11:50
*** dpawlik has joined #zuul11:50
*** Goneri has joined #zuul11:59
*** bhavikdbavishi has quit IRC12:04
*** jcapitao_lunch is now known as jcapitao12:07
*** rpittau|bbl is now known as rpittau12:07
*** harrymichal has quit IRC12:07
*** hashar has joined #zuul12:09
*** dpawlik has quit IRC12:09
*** dpawlik has joined #zuul12:10
*** harrymichal has joined #zuul12:17
zbrcorvus: clarkb: are you pleased with new <pre> output on https://review.opendev.org/#/c/681532/ ?12:19
zbri was finally able to get it to wrap correctly12:20
*** bhavikdbavishi has joined #zuul12:24
*** zxiiro has joined #zuul12:27
*** jpena|lunch is now known as jpena12:31
openstackgerritJan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler  https://review.opendev.org/71726912:36
*** harrymichal has quit IRC12:39
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: dhall-diff: add new job  https://review.opendev.org/71869412:44
openstackgerritTobias Henkel proposed zuul/zuul master: Detach head before reset  https://review.opendev.org/72045812:51
*** yolanda has quit IRC12:55
*** yolanda has joined #zuul12:55
openstackgerritTobias Henkel proposed zuul/zuul master: Detach head before reset  https://review.opendev.org/72045812:56
*** ysandeep is now known as ysandeep|mtg13:14
*** gtema has joined #zuul13:21
*** gtema_ has joined #zuul13:31
*** gtema has quit IRC13:34
*** sgw has joined #zuul13:40
*** bhavikdbavishi has quit IRC13:48
mordredcorvus: idea - add a config setting to zuul to communicate what the log retention period is - so that on old builds in the dashboard instead of throwing a "can't load file, maybe you have an ad blocker" error, we can throw a "can't load logs, the log data is beyond the retention period"14:23
mordredcorvus: since the build record has a date associated with it - so we should be able to know "yup, this build is too old to have logs"14:24
corvusmordred: yeah, that's something we could return via zuul_return and stick in mysql14:25
mordredcorvus: oh, that's even better than a config setting :)14:25
corvus(we could actually cheat, and do that as metadata on the manifest today with no schema change, but this seems like something to make a bit more fundamental)14:25
mordredyeah - it seems like a piece of data an admin would want to communicate14:27
mordredmsuszko: you don't need the buildset registry for a self-contained docker build like that. where it's more useful is if you have subsequent jobs in the buildset that want to use the image you built14:29
mordredmsuszko: with the buildset registry instead of making a test stage in the dockerfile you could instead make a second test job that runs the release image and verifies that it's working like it would in production - but it's possible that's overkill for your use case14:30
*** harrymichal has joined #zuul14:49
*** panda is now known as panda|ruck14:49
*** harrymichal has quit IRC14:57
*** ysandeep|mtg is now known as ysandeep14:59
msuszkomordred: It seems I have two cases: 1) one job with playbook running roles build-docker-image and test-in-docker, 2) build-docker-image + run-buildset-registry and other jobs test-in-docker + use-buildset-registry with dependencies set to first job14:59
msuszkothe latter one is required to run tests in parallel15:00
openstackgerritMonty Taylor proposed zuul/nodepool master: Add yappi and objgraph to an extra  https://review.opendev.org/72049915:02
msuszkoBTW: is anyone using S3 for log storage?15:02
AJaegercorvus: want to review https://review.opendev.org/#/c/717663/ (the pip ensure zuul-jobs changes) again, please? With clarkb's change the 3rd party CI is passing now.15:02
*** gtema_ has left #zuul15:02
corvusmsuszko: i think some folks are; there's a wip change in zuul-jobs to support it, though i think it could use an update to be more like the gcp log storage role15:08
*** ysandeep is now known as ysandeep|away15:11
*** bhavikdbavishi has joined #zuul15:25
*** dpawlik has quit IRC15:26
*** dpawlik has joined #zuul15:26
msuszkoupload-logs-gcs is a copy of older upload-logs-swift with few changes15:34
fungiand upload-logs-swift is the one which gets the most testing and is most widely-deployed, so i expect consistency with it is preferable15:35
*** ttx has quit IRC15:38
*** ttx has joined #zuul15:38
zbrfungi: can you do a quick look at https://review.opendev.org/#/c/681532/ ? (ignore WIP prefix, is ready for review afaik). -- the <pre> change.15:46
zbrhttps://sbarnea.com/ss/Screen-Shot-2020-04-16-16-46-33.42.png15:46
zbrno more vertical scrolling15:46
fungii assume you mean no more horizontal scrolling, but looks good! https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_633/681532/10/check/zuul-build-dashboard-multi-tenant/63376a0/npm/html/t/local/build/ad1ef4edadca43d38b90cd784f121c1d16:01
fungizbr: are you interested in similar work on the console view, or is that less of a concern?16:02
fungihttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_633/681532/10/check/zuul-build-dashboard-multi-tenant/63376a0/npm/html/t/local/build/ad1ef4edadca43d38b90cd784f121c1d/console16:02
zbrfungi: yes, I am (fyi, these links are not shareable).16:03
zbri happen to care a lot about UX of the console output, so I will be glad to make changes to improve it.16:04
zbrmy plan is to also enable ANSI support, but i need to wait for the react app version upgrade to happen, apparently there is something wrong with it.16:07
fungizbr: d'oh, yep i didn't notice those links don't work unless you browse to them starting from https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_633/681532/10/check/zuul-build-dashboard-multi-tenant/63376a0/npm/html/16:07
corvuswe could probably use zuul-preview to make those work16:07
openstackgerritSorin Sbarnea proposed zuul/zuul master: Improve display of stdout/stderr task errors  https://review.opendev.org/68153216:09
*** jcapitao has quit IRC16:10
*** sshnaidm has joined #zuul16:17
*** rpittau is now known as rpittau|afk16:18
*** evrardjp has quit IRC16:37
*** evrardjp has joined #zuul16:37
corvusi plan to focus on upgrading the opendev installation and using the new TLS feature there for the next few days16:42
corvusi'd like to make sure that gets some real-world usage before we release it16:43
corvusi apologize if that delays reviews for a bit16:43
tobiashk, sounds good17:18
*** jpena is now known as jpena|off17:18
*** sshnaidm has quit IRC17:37
*** avass has joined #zuul17:57
*** hashar is now known as hasharAway18:03
mordredcorvus: https://review.opendev.org/#/c/720499 if you get a sec18:07
mordredcorvus: we should land that before the nodepol launcher change in opendev18:07
*** yolanda has quit IRC18:14
corvusdone18:15
*** yolanda has joined #zuul18:28
*** bhavikdbavishi has quit IRC18:33
*** jamesmcarthur has quit IRC18:44
*** jamesmcarthur has joined #zuul18:44
*** tflink_ is now known as tflink18:54
openstackgerritMerged zuul/nodepool master: Add yappi and objgraph to an extra  https://review.opendev.org/72049918:54
*** rfolco is now known as rfolco|bbl19:01
*** harrymichal has joined #zuul19:04
*** hasharAway is now known as hashar19:05
*** saneax has quit IRC19:05
*** jamesmcarthur has quit IRC19:29
*** jamesmcarthur has joined #zuul19:33
*** jamesmcarthur has quit IRC19:37
*** jamesmcarthur has joined #zuul19:38
*** harrymichal has quit IRC19:45
*** rfolco|bbl is now known as rfolco19:46
*** jamesmcarthur has quit IRC20:14
*** jamesmcarthur has joined #zuul20:20
*** jamesmcarthur has quit IRC20:20
*** rfolco has quit IRC20:36
*** saneax has joined #zuul20:42
*** sassyn has quit IRC20:57
*** rfolco has joined #zuul21:10
*** hashar has quit IRC21:17
jktI switched my Zuul 3.18.0 to use HTTP reporting (I wanted to get access to file comments), but now I'm getting AttributeError: 'GerritChange' object has no attribute 'commit' in gerritconnection.py", line 1108, in review_http21:48
jktGerrit 3.1.421:49
jktI see that this is probably introduced in 947b7b1dcb6699ac3e5cfe2c046d18599d0ba8fe with introduction of GerritChangeData, because before that the change.commit was taken from ps['revision']21:50
clarkbjkt: I think its still doing ps['revision'] in gerritmodel.py21:57
clarkbjkt: https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/gerrit/gerritmodel.py#L114 there21:59
clarkbjkt: looking at that code, is it possible ti was trying to comment on an old patchset?21:59
clarkbwe seem to not set the commit revision if the patchset isn't current there21:59
openstackgerritMerged zuul/zuul master: Filter secret ZUUL_ env variables from ansible env  https://review.opendev.org/72023822:03
jktclarkb: digging into this (with printfs as usual), but now I'm getting a rejectionf when I try to re-run via zuul enqueue, and that exception eating code in rpclistener.py is less than helpful22:09
jktclarkb: ah!, so that error was caused by enqueueuing a wrong version (there was no PS2, just PS1, and I manually injected PS2)22:27
jktclarkb: looks like something which should not be allowed, though22:27
fungisounds like it wasn't allowed, it raised an exception?22:30
fungior are you suggesting the rpc interface should do some sort of lookahead to find out if stuff is in gerrit?22:31
fungiand bubble that back up to the rpc request interface?22:31
jktfungi: the problem is that I can enqueue a non-existing PS, and when this non-existing PS gets "reported" to gerrit, it results in an exception22:33
fungigot it22:33
jktfungi: as I was debugging this, I added extra print()s into the code and that resulted in the RPC layer showing me something which confused me22:33
fungidid it report an exception into gerrit though?22:33
fungior just short-circuit to the reporter since there was no valid item to enqueue?22:34
jktnope, it resulted in a build and everything, but nothing hit Gerrit22:34
jktit started (and finished) building stuff22:34
fungineat, i wonder what it built22:34
fungi(what ref, i mean)22:34
jkthttps://gerrit.cesnet.cz/c/CzechLight/netconf-cli/+/2452 is that change, and https://zuul.gerrit.cesnet.cz/t/public/buildset/0f162a8a7cac427b860dd5e17f32d2d0 is one of these build sets22:34
jktlet me dig through the logs22:35
jktfungi: my build log says it built PS1 of that change22:35
jktI wonder what would have happened if someone uploaded PS2 while this PS1 treated as-if-it-was-PS2 was getting built, prior to Zuul reporting result of actual PS122:36
fungian interesting race condition to test, i suppose22:37
jktzuul.GerritConnection: Updating <Change 0x7feafc466748 CzechLight/netconf-cli 2452,2>: Getting git-dependent change 2451,222:39
jktzuul.GerritConnection: Updating <Change 0x7feafc466748 CzechLight/netconf-cli 2452,2>: Getting git-needed change 2452,122:39
jktzuul.GerritConnection: Updating <Change 0x7feafc466748 CzechLight/netconf-cli 2452,2>: Running query message:{I9c1f039e7e054f84559a3d57812d0254db183a99} to find changes needed-by22:39
jkthere's how it ended up there I think22:40
*** jamesmcarthur has joined #zuul22:48
openstackgerritMerged zuul/zuul-jobs master: ensure-pip: export ensure_pip_virtualenv_command  https://review.opendev.org/71822423:01
*** tosky has quit IRC23:09
*** threestrands has joined #zuul23:14
*** threestrands has quit IRC23:15
*** threestrands has joined #zuul23:15
*** jamesmcarthur has quit IRC23:19
*** rfolco has quit IRC23:21
openstackgerritMerged zuul/zuul-jobs master: fetch-zuul-cloner: use ensure-pip  https://review.opendev.org/71788223:25
*** armstrongs has joined #zuul23:32
*** armstrongs has quit IRC23:41

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!