| *** jamesmcarthur has joined #zuul | 00:00 | |
| *** jamesmcarthur has quit IRC | 00:05 | |
| *** avass has quit IRC | 00:12 | |
| *** jamesmcarthur has joined #zuul | 00:21 | |
| *** threestrands has joined #zuul | 00:43 | |
| *** sgw has joined #zuul | 01:17 | |
| *** jamesmcarthur has quit IRC | 01:26 | |
| *** jamesmcarthur has joined #zuul | 01:26 | |
| *** jamesmcarthur has quit IRC | 01:34 | |
| *** jamesmcarthur has joined #zuul | 01:37 | |
| *** swest has quit IRC | 01:40 | |
| *** swest has joined #zuul | 01:54 | |
| *** jamesmcarthur has quit IRC | 02:18 | |
| *** jamesmcarthur has joined #zuul | 02:18 | |
| *** jamesmcarthur has quit IRC | 02:22 | |
| *** jamesmcarthur_ has joined #zuul | 02:22 | |
| *** EmilienM is now known as EmilienM|off | 03:16 | |
| *** bhavikdbavishi has joined #zuul | 03:35 | |
| *** bhavikdbavishi has quit IRC | 04:32 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** bhavikdbavishi has joined #zuul | 04:46 | |
| mnaser | ouch | 05:28 |
|---|---|---|
| mnaser | it seems like we don't shard periodic pipelines by default for uploading to swift | 05:29 |
| mnaser | and it hurts | 05:29 |
| *** bhavikdbavishi1 has joined #zuul | 05:53 | |
| *** dpawlik has joined #zuul | 05:53 | |
| *** bhavikdbavishi has quit IRC | 05:54 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 05:54 | |
| *** dpawlik has quit IRC | 05:57 | |
| *** dpawlik has joined #zuul | 06:13 | |
| *** jamesmcarthur_ has quit IRC | 06:22 | |
| *** jamesmcarthur has joined #zuul | 06:22 | |
| *** jamesmcarthur has quit IRC | 06:27 | |
| AJaeger | mnaser: you mean all reports from today go to Vexxhost? Or from every day? | 06:27 |
| mnaser | AJaeger: another zuul user which uses our cloud, the 'sharding' works for check/gate, but for periodic pipeline, it just creates an ansible_periodic | 06:28 |
| AJaeger | you mean in the pathname - ah | 06:28 |
| mnaser | right, so it ends up uplaoding everything into a single bucket :\ | 06:29 |
| AJaeger | mnaser: is that user not setting zuul_log_path_shard_build? | 06:30 |
| AJaeger | mnaser: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/set-zuul-log-path-fact/tasks/main.yaml#L35 that should work fine, doesn't it? | 06:31 |
| mnaser | they have `zuul_log_partition` = `true` | 06:31 |
| mnaser | but i guess maybe they're not running that role | 06:31 |
| mnaser | yeah i guess they explicitly need to set zuul_log_path_shard_build too? | 06:32 |
| mnaser | so the user needs to set both `zuul_log_path_shard_build` and `zuul_log_partition` ? | 06:33 |
| AJaeger | mnaser: I don't remember those details, sorry | 06:33 |
| mnaser | its a little late for me to dig into the details of this right now for me too. | 06:34 |
| AJaeger | tobiash: could you review later https://review.opendev.org/725030 , please? | 06:35 |
| AJaeger | mnaser: it might be an either or - but that needs some further investigation. | 06:35 |
| mnaser | AJaeger: yeah i'm not groking that codebase clearly right now, but def need to look into it | 06:36 |
| tobiash | AJaeger: yes | 06:49 |
| *** avass has joined #zuul | 06:49 | |
| *** hashar has joined #zuul | 06:50 | |
| avass | tristanC: yes, but the zuul-runner requires an operational zuul+nodepool right? I wanted to see if I could make a test runner that runs everything locally :) | 06:51 |
| *** jamesmcarthur has joined #zuul | 06:59 | |
| *** bhavikdbavishi has quit IRC | 07:01 | |
| *** yolanda has joined #zuul | 07:07 | |
| avass | tristanC: Oh, I guess that got updated since I last saw it since it now requires the user to specify the inventoy themselves | 07:08 |
| avass | tristanC: well, no worries, I just did it for fun anyway :) | 07:09 |
| *** jcapitao has joined #zuul | 07:09 | |
| avass | tristanC: I wonder if we could integrate my idea of matching dockerfiles against labels that gets launched locally as an alternative to supplying an inventory file | 07:11 |
| *** jamesmcarthur has quit IRC | 07:12 | |
| openstackgerrit | Merged zuul/zuul-jobs master: tox: update lint regex to not require column https://review.opendev.org/725030 | 07:12 |
| *** iurygregory has joined #zuul | 07:17 | |
| *** tosky has joined #zuul | 07:22 | |
| *** evrardjp has quit IRC | 07:28 | |
| *** rpittau|afk is now known as rpittau | 07:29 | |
| *** evrardjp has joined #zuul | 07:30 | |
| *** asaleh_ has joined #zuul | 07:39 | |
| *** fbo|off is now known as fbo|afk | 07:45 | |
| *** jpena|off is now known as jpena | 07:56 | |
| *** phildawson has joined #zuul | 07:58 | |
| openstackgerrit | Antoine Musso proposed zuul/zuul master: tests: throttle after all builds have reported https://review.opendev.org/704381 | 08:10 |
| *** nils has joined #zuul | 08:10 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Cache config schema in configloader and drivers https://review.opendev.org/728774 | 08:10 |
| *** threestrands has quit IRC | 08:13 | |
| *** sshnaidm|off has joined #zuul | 08:47 | |
| *** sshnaidm|off is now known as sshnaidm | 08:47 | |
| *** bhavikdbavishi has joined #zuul | 08:52 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Drop support for ansible 2.7 https://review.opendev.org/727373 | 08:53 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 08:54 |
| *** ysandeep is now known as ysandeep|lunch | 08:56 | |
| *** bhavikdbavishi has quit IRC | 09:09 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 09:17 |
| avass | So putting a "when" on a block is the same as setting it on each of the tasks in the block it seems | 09:18 |
| *** klindgren_ has quit IRC | 09:21 | |
| *** bhavikdbavishi has joined #zuul | 09:21 | |
| *** klindgren has joined #zuul | 09:21 | |
| *** tumble has joined #zuul | 09:23 | |
| *** ysandeep|lunch is now known as ysandeep | 09:51 | |
| *** guillaumec has joined #zuul | 09:53 | |
| *** hashar is now known as hasharAway | 09:54 | |
| *** rpittau is now known as rpittau|bbl | 10:06 | |
| masterpe | can https://review.opendev.org/#/c/726288/ have merged? | 10:25 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Support per branch change queues https://review.opendev.org/718531 | 10:43 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: WIP: Move queue from pipeline to project https://review.opendev.org/720182 | 10:43 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Add optional support for circular dependencies https://review.opendev.org/685354 | 10:43 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: WIP: Move queue from pipeline to project https://review.opendev.org/720182 | 10:52 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Move queue from pipeline to project https://review.opendev.org/720182 | 10:52 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Add optional support for circular dependencies https://review.opendev.org/685354 | 10:53 |
| *** jcapitao is now known as jcapitao_lunch | 11:00 | |
| *** phildawson has quit IRC | 11:07 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 11:09 |
| *** jamesmcarthur has joined #zuul | 11:09 | |
| *** jamesmcarthur has quit IRC | 11:14 | |
| *** fbo|afk is now known as fbo | 11:15 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 11:23 |
| *** jpena is now known as jpena|lunch | 11:31 | |
| Pilou | tristanC: i have updated https://review.opendev.org/#/c/726171/, could you please have a look | 11:33 |
| tristanC | Pilou: thanks! | 11:36 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 11:36 |
| avass | I noticed that we were missing python3-devel in bindep when working on that testrunner: https://review.opendev.org/#/c/728708/ | 11:41 |
| avass | If we want to merge that | 11:41 |
| *** rfolco has joined #zuul | 11:49 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Cache config schema in configloader and drivers https://review.opendev.org/728774 | 11:50 |
| *** ysandeep is now known as ysandeep|afk | 11:53 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Cache config schema in configloader and drivers https://review.opendev.org/728774 | 12:00 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 12:00 |
| *** saneax has quit IRC | 12:00 | |
| *** rfolco is now known as rfolco|rover | 12:02 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: REST API: add tenant scoped, unscoped endpoints https://review.opendev.org/728118 | 12:04 |
| *** rlandy has joined #zuul | 12:10 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Move queue from pipeline to project https://review.opendev.org/720182 | 12:11 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Add optional support for circular dependencies https://review.opendev.org/685354 | 12:11 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 12:11 |
| *** rpittau|bbl is now known as rpittau | 12:12 | |
| openstackgerrit | Merged zuul/nodepool master: openshiftpods: define ca_crt parameter if available https://review.opendev.org/726171 | 12:14 |
| *** bhavikdbavishi has quit IRC | 12:17 | |
| *** hasharAway is now known as hashar | 12:17 | |
| AJaeger | avass, tobiash: https://review.opendev.org/710208 just gave a lot of new linting warnings that look new "py38: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()" - is that a fallout from https://review.opendev.org/725030 ? | 12:18 |
| *** jcapitao_lunch is now known as jcapitao | 12:19 | |
| tobiash | AJaeger: I think so as this removed the warning_output test case that makes sure that this doesn't happen | 12:19 |
| tobiash | AJaeger: revert? | 12:19 |
| AJaeger | tobiash: if nobody has a better idea... | 12:21 |
| *** bhavikdbavishi has joined #zuul | 12:21 | |
| tobiash | we could do a re-revert afterwards without disabling that test case | 12:21 |
| AJaeger | ;) | 12:21 |
| AJaeger | avass: could you add some better commit message to 728708? Then I'm happy to +2. | 12:22 |
| AJaeger | tobiash, avass , let me propose the revert for now | 12:22 |
| tobiash | ++ | 12:22 |
| openstackgerrit | Andreas Jaeger proposed zuul/zuul-jobs master: Revert "tox: update lint regex to not require column" https://review.opendev.org/728822 | 12:23 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: How-to: using the REST API with cURL https://review.opendev.org/727785 | 12:25 |
| *** evrardjp has quit IRC | 12:36 | |
| *** ysandeep|afk is now known as ysandeep | 12:36 | |
| avass | AJaeger, tobiash: well it is supposed to match that, wouldn't it be better to stop outputting warnings if they're not wanted? | 12:36 |
| AJaeger | avass: that warning comes at runtime, e.g. from lower-constraints job or py37 job. So, it's not from the linter jobs. | 12:39 |
| AJaeger | I'm not aware of stopping those. | 12:39 |
| AJaeger | I'm not aware of a way to silence these run-time warnings. | 12:40 |
| AJaeger | (ignore the first line above) | 12:40 |
| avass | AJaeger: python -W ignore::DeprecationWarning it seems: https://stackoverflow.com/questions/879173/how-to-ignore-deprecation-warnings-in-python | 12:41 |
| *** jpena|lunch is now known as jpena | 12:42 | |
| avass | AJaeger: https://review.opendev.org/#/c/726829/ is green .. finally, that was a lot of small errors I stumbled into | 12:42 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: How-to: using the REST API with cURL https://review.opendev.org/727785 | 12:43 |
| AJaeger | avass: wow, congratulations! | 12:43 |
| AJaeger | Ah -W - but that would be needed to pass to python via tox | 12:43 |
| AJaeger | avass: sorry, no time right now to dig into that further, hope others have ideas | 12:43 |
| avass | and I'll update 728708, I found that it was needed when messing around with: https://review.opendev.org/#/c/728684/ | 12:44 |
| asaleh_ | fbo, question ... can I have 2 vcpu's in a zuul vm? :) | 12:45 |
| *** evrardjp has joined #zuul | 12:49 | |
| fbo | asaleh_: hi, yes which node label are you using atm ? | 12:52 |
| openstackgerrit | Merged zuul/zuul-jobs master: Revert "tox: update lint regex to not require column" https://review.opendev.org/728822 | 12:52 |
| *** saneax has joined #zuul | 12:52 | |
| asaleh_ | fbo, fedora-30-vm and running into minikube needing at least 2cpu and 2G ram | 12:53 |
| avass | AJaeger: So we either need to a) keep trying to avoid warnings, b) disable warning output for tests in CI somehow or c) disable output matching for tests | 12:59 |
| fbo | avass: here are the label we have https://fedora.softwarefactory-project.io/zuul/labels | 12:59 |
| fbo | asaleh_: ^ sorry avass :p | 12:59 |
| fbo | asaleh_: cloud-fedora-32-medium is I think at least 2 vcpus | 13:00 |
| fbo | asaleh_: let's talk on #softwarefactory instead | 13:02 |
| *** reiterative has quit IRC | 13:05 | |
| *** reiterative has joined #zuul | 13:06 | |
| tobiash | AJaeger: do you know how long py27 will be supported by diskimage-builder? | 13:10 |
| *** jamesmcarthur has joined #zuul | 13:11 | |
| *** jhesketh has quit IRC | 13:15 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: CLI: add autohold-info, autohold-delete via REST https://review.opendev.org/728410 | 13:15 |
| *** jamesmcarthur has quit IRC | 13:15 | |
| mordred | tobiash: that's an interesting question - do you mean for installing dib in python2.7 - or for the elements that do things inside of in-progress chroots that are python2.7? | 13:18 |
| mordred | I'd think the second would need a very long support period, since it's dib's job to be able to build images of things and some of those base OS's may need py2.7 | 13:18 |
| tobiash | mordred: running dib with py27 (swest had a change that appearently failed third party ci by using pathlib) | 13:18 |
| mordred | nod. for that - I actually don't know why it still supports py27 | 13:19 |
| mordred | tobiash: zuul and openstack are both python3 only now, so I think we could probably make the case that it's time for dib to drop python2.7 support too | 13:21 |
| *** jhesketh has joined #zuul | 13:22 | |
| tobiash | makes sense to me since py27 is end of life now | 13:22 |
| *** hashar is now known as hasharAway | 13:24 | |
| mordred | tobiash: remote: https://review.opendev.org/728889 Drop support for python2 | 13:27 |
| mordred | tobiash: let's see what people think | 13:27 |
| tobiash | :) | 13:29 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Increase wait time in remote tests https://review.opendev.org/728892 | 13:30 |
| tobiash | zuul-maint: I've seen increasing rates of timeouts in the remote tests, I hope that this makes them more stable ^ | 13:30 |
| mordred | tobiash: I sent an email to openstack-discuss@ and zuul-discuss@ | 13:31 |
| *** jhesketh has quit IRC | 13:41 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: REST API: add tenant scoped, unscoped endpoints https://review.opendev.org/728118 | 13:41 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: CLI: add autohold-info, autohold-delete via REST https://review.opendev.org/728410 | 13:41 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Update node to v14 and update to new jobs https://review.opendev.org/726553 | 13:45 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Use node image to build javascript https://review.opendev.org/728690 | 13:45 |
| mordred | corvus: https://review.opendev.org/#/c/717371/ is green | 13:46 |
| mordred | corvus: oh - althoughwe should update its doc artifact to use zuul-preview | 13:47 |
| avass | AJaeger: or, I could finish the negative matchers and that could be used to avoid the warnings :) | 13:47 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: REST API: add promote endpoint https://review.opendev.org/728489 | 13:47 |
| AJaeger | avass: that's an option - mordred, advise on 728822? | 13:47 |
| corvus | mordred: yeah, it's a bit hard to evaluate the change without it :/ | 13:48 |
| avass | tristanC: do you think I should abandon the zuul-jobs test runner idea and wait for zuul-runner, or should I continue on that so we have a way to test most of the jobs locally in containers? | 13:49 |
| corvus | avass: the zuul-runner spec is still in review; i can't say for certain that we're going to merge zuul-runner (but i hope that we can resolve the issues and do so) | 13:51 |
| mordred | corvus: in the netlify-sandbox repo, you used success-url: "http://site.{build.uuid}.{tenant.name}.zuul-preview.opendev.org/" - is that still the right thing to do? | 13:51 |
| avass | AJaeger, mordred: although, if it's so simple that they don't want comments in gerrit for those jobs they can just turn it off with tox_inline_comments already | 13:51 |
| corvus | avass: so i'd hesitate to recommend anyone wait on it. | 13:51 |
| corvus | mordred: yes | 13:51 |
| *** bhavikdbavishi has quit IRC | 13:52 | |
| avass | corvus: ok, since I don't think they overlap entirely anyway | 13:52 |
| corvus | AJaeger, avass: aw, i wish you had asked for my review on https://review.opendev.org/725030 | 13:52 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-website master: Switch website to Gatsby https://review.opendev.org/717371 | 13:53 |
| avass | corvus: sorry, what's your take on it? :) | 13:53 |
| corvus | AJaeger, avass: that was not a faulty test case, that was a very carefully constructed test case with real data, that we made after hitting exactly the situation that prompted you to revert | 13:53 |
| AJaeger | corvus: I pointed you to it last week... | 13:54 |
| *** hasharAway is now known as hashar | 13:54 | |
| avass | corvus, AJaeger: it feels to me like that should be configured downstream since it would be very hard to keep avoiding that and adding more matchers | 13:55 |
| avass | sicne they're all really the same format of <file>:<line>:<column>:<message> | 13:56 |
| corvus | AJaeger, avass: i think any time we write something like "remove a faulty test case" it's worth really understanding what the test case was there for. if you git blame it, you'll find this is the change that added it: https://review.opendev.org/718554 | 13:56 |
| avass | corvus: I did | 13:56 |
| AJaeger | corvus: yes, sorry | 13:56 |
| corvus | what's faulty about it? | 13:56 |
| corvus | (it kept out python warnings; we removed it, and python warnings showed up) | 13:57 |
| avass | corvus: the test case isn't faulty, the assumption that if there's no column specified it's a warning and shouldn't be returned | 13:57 |
| avass | and that no one wants warnings | 13:58 |
| corvus | avass: that is the assumption that's built into the role, that's why it has a PEP8_RE and a SPHINX_RE but not a PYTHON_WARNINGS_RE | 13:58 |
| avass | corvus: yes and that takes us back to the case where it's going to be very hard to know what to return, so it's probably better to return everything that specified a line in a file with a message. Also why I started on: https://review.opendev.org/#/c/725100/ | 13:59 |
| corvus | avass: is someone asking for warnings? | 14:00 |
| corvus | because so far, everytime we've returned warnings, it's been terrible | 14:00 |
| corvus | avass: or do you just want ansible-lint to show up? | 14:01 |
| avass | I wanted ansible-lint to show up and that's why I looked into why it didn't | 14:02 |
| corvus | avass: i don't suppose it's possible to make it match flake8 output? | 14:03 |
| corvus | avass: or, is there a more specific regex we could use for ansible-lint that doesn't also match warnings? | 14:04 |
| avass | corvus: not that I'm aware of, except that we could match on it having the ": [<rule_id>] <mesage>" format | 14:04 |
| zbr | ansible-lint already has pep8 compatible output, enable it with "-p" | 14:04 |
| corvus | avass: that sounds like the best approach to me -- then we still have our list of specific regexes for each type of return data | 14:05 |
| zbr | i was considering proposing to change default to be pep8 format | 14:05 |
| corvus | or that ^ | 14:05 |
| avass | we already do that with parseable: true in .asnible-lint | 14:05 |
| corvus | avass: if the specific regex doesn't work, then i think maybe either add an option to include warnings (off by default), or your suggestion for included regexes are the way to go | 14:05 |
| avass | corvus: I'll wait for a review from you the next time I change something like that then | 14:07 |
| corvus | avass: i think that the last time this came up, we found that in many cases, there are many python warnings that can't or shouldn't be fixed for various reasons. iow, they're not as easy to fix as linting errors, and even linting errors can be annotated with "noqa" whereas the same is not true for python warnings | 14:07 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-website master: Add blog to website https://review.opendev.org/724648 | 14:08 |
| corvus | avass: so i think at the very least, that means we probably don't want warnings included by default | 14:08 |
| avass | sure | 14:13 |
| avass | corvus: I'll see if I can work around that instead then | 14:14 |
| corvus | avass: i also made an alternate suggestion about how to exclude warnings in in my commit message; that may be useful | 14:15 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add flag for disabling log streaming on a host https://review.opendev.org/721953 | 14:16 |
| mordred | corvus: ^^ I agree with tobiash on that - I'm not sure how to do a tox-remote test for it - any suggestions? | 14:18 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: CLI: support promote via the REST API https://review.opendev.org/728907 | 14:19 |
| corvus | mordred: if there is no log streaming, and the task is a shell or command, then will there be output from that task in job-output.txt? | 14:23 |
| avass | corvus: yep | 14:23 |
| tobiash | corvus: the output will be there in both cases | 14:23 |
| tobiash | just in one case live in the other case after the task finished | 14:23 |
| corvus | hrm, i guess all of our tasks where we are seeing this have no output :/ | 14:26 |
| avass | corvus: filtering on Warning sounds like a good idea | 14:27 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Log missing required status checks https://review.opendev.org/718114 | 14:28 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Revert "Revert "tox: update lint regex to not require column"" https://review.opendev.org/728912 | 14:28 |
| corvus | mordred, tobiash, avass: i'm not so sure -- it looks like the only way we get non-streaming output lines is if we're localhost, or win_command or win_shell: https://opendev.org/zuul/zuul/src/branch/master/zuul/ansible/base/callback/zuul_stream.py#L340-L341 | 14:37 |
| corvus | mordred, tobiash, avass: so a test in tox-remote should be straightforward (if you set the new variable, there will be no output) | 14:38 |
| mordred | corvus: kk. I'll try that real quick | 14:38 |
| corvus | mordred, tobiash, avass: now, arguably that may not be the behavior we desire; so maybe we want to consider changing it to what you thought it was, which would be more difficult to test :) | 14:38 |
| corvus | mordred, tobiash, avass: (ie, perhaps that check should be "if i did not start a streamer, dump output lines") | 14:39 |
| tobiash | corvus: I guess we should fix that then | 14:39 |
| tobiash | ++ | 14:39 |
| corvus | yeah, i think what has happened is we have two places where we decide if there's log streaming, and we haven't kept the two in sync | 14:40 |
| tobiash | yeah looks like | 14:40 |
| avass | ah that could be it | 14:41 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: REST API: add tenant scoped, unscoped endpoints https://review.opendev.org/728118 | 14:42 |
| tobiash | when we fixed this I think I know how we could test this. Just run a playbook without starting zuul_console and validate that the job output doesn't contain the streamer warnings | 14:42 |
| tobiash | (and the desired output) | 14:43 |
| corvus | tobiash: ++ | 14:43 |
| tobiash | however that could be difficult with parallel runs | 14:43 |
| corvus | oh because they use the same node | 14:44 |
| tobiash | or do we run multiple zuul_console on different ports during the tests? | 14:44 |
| corvus | tobiash: apparently each test class gets its own port... | 14:45 |
| avass | AJaeger: openstacksdk is trying to build netifaces and that requires python3-devel, I'll update the commit message :) | 14:45 |
| *** cdearborn has joined #zuul | 14:45 | |
| corvus | tobiash: so i think we could make a new class just for this and reserve its own (unused) port number | 14:45 |
| tobiash | corvus: yes, we already thought about that :) https://opendev.org/zuul/zuul/src/branch/master/tests/fixtures/config/remote-zuul-stream/git/org_project/playbooks/command.yaml#L21 | 14:46 |
| corvus | mordred: ^ you caught up on this? | 14:46 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add python3-devel to bindep https://review.opendev.org/728708 | 14:49 |
| avass | caught that ^ with the test runner by the way :) | 14:49 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add flag for disabling log streaming on a host https://review.opendev.org/721953 | 14:51 |
| mordred | corvus, tobiash: reading | 14:52 |
| mordred | hrm. ok. I think I need another coffee | 14:54 |
| corvus | mordred: short version: we should fix the callback plugin so the stdout-line-dump conditions match the start-streaming conditions which will make it behave the way you thought it did. then add a test by creating a new test class with a dedicated streaming port (which won't be used) and playbook which does not start zuul-stream but does set your variable. check for no streamer warnings in the output. | 14:57 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add flag for disabling log streaming on a host https://review.opendev.org/721953 | 15:03 |
| mordred | corvus: oh wait - I'm missing the first part of that | 15:03 |
| mordred | ah! nod | 15:04 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-coverage-output: do not synchronize owner https://review.opendev.org/727717 | 15:05 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-javascript-content-tarball: do not synchronize owner https://review.opendev.org/727718 | 15:05 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-javascript-output: do not synchronize owner https://review.opendev.org/727719 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-javascript-tarball: do not synchronize owner https://review.opendev.org/727720 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-markdownlint: do not synchronize owner https://review.opendev.org/727721 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-phoronix-results: do not synchronize owner https://review.opendev.org/727722 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-puppet-module-output: do not synchronize owner https://review.opendev.org/727723 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-python-sdist-output: do not synchronize owner https://review.opendev.org/727724 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-sphinx-output: do not synchronize owner https://review.opendev.org/727725 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-sphinx-tarball: do not synchronize owner https://review.opendev.org/727726 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: do not synchronize owner https://review.opendev.org/727727 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-translation-output: do not synchronize owner https://review.opendev.org/727728 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-subunit-output: do not synchronize owner https://review.opendev.org/727729 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: prepare-workspace: do not synchronize owner https://review.opendev.org/727730 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: publish-artifacts-to-fileserver: do not synchronize owner https://review.opendev.org/727731 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: upload-logs: do not synchronize owner https://review.opendev.org/727732 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tarball-post.yaml: do not synchronize owner https://review.opendev.org/727735 | 15:06 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy https://review.opendev.org/727642 | 15:06 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: CLI: add autohold-info, autohold-delete via REST https://review.opendev.org/728410 | 15:06 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: REST API: add promote endpoint https://review.opendev.org/728489 | 15:06 |
| avass | corvus: we should be ready to slowly merge that stack right? | 15:07 |
| corvus | avass: yep, i think we're all clear | 15:07 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: CLI: support promote via the REST API https://review.opendev.org/728907 | 15:07 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add flag for disabling log streaming on a host https://review.opendev.org/721953 | 15:08 |
| *** guillaumec has quit IRC | 15:08 | |
| mordred | corvus, tobiash: ok - that might do all of the things | 15:08 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add flag for disabling log streaming on a host https://review.opendev.org/721953 | 15:09 |
| tobiash | mordred: this conflicts with the ansible 2.6 removal, which way do we want? | 15:11 |
| mordred | tobiash: I can rebase it on 2.6 | 15:11 |
| tobiash | cool, thx | 15:11 |
| *** jamesmcarthur has joined #zuul | 15:11 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 15:12 |
| tobiash | mordred: I think there is also a good comment on the docs part | 15:14 |
| openstackgerrit | Monty Taylor proposed zuul/zuul master: Add flag for disabling log streaming on a host https://review.opendev.org/721953 | 15:17 |
| mordred | tobiash: agree. | 15:17 |
| corvus | i +3d the 2.6 removal patch (that was already +3d last week) | 15:20 |
| *** asaleh_ has quit IRC | 15:21 | |
| mordred | corvus: cool - the default-to-2.9 patch could also use a +3 | 15:23 |
| *** jamesmcarthur has quit IRC | 15:23 | |
| *** jamesmcarthur has joined #zuul | 15:24 | |
| *** ysandeep is now known as ysandeep|afk | 15:26 | |
| openstackgerrit | Merged zuul/zuul master: add installation manual for Ubuntu https://review.opendev.org/726288 | 15:26 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 15:27 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 15:27 |
| *** dpawlik has quit IRC | 15:31 | |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-coverage-output: do not synchronize owner https://review.opendev.org/727717 | 15:32 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-javascript-content-tarball: do not synchronize owner https://review.opendev.org/727718 | 15:47 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Remove --verbose from js_build_command https://review.opendev.org/728930 | 16:01 |
| *** bhavikdbavishi has joined #zuul | 16:05 | |
| *** rpittau is now known as rpittau|afk | 16:06 | |
| mordred | corvus: adding success-url to the website patch did not have any impact | 16:09 |
| mordred | corvus: I should probably do that as an artifact link in zuul_return instead yeah? | 16:09 |
| corvus | mordred: yes, success-url is effectively deprecated by the report build page setting | 16:11 |
| corvus | mordred: just leave the 'site' artifact link alone, since that's going to be used by the preview link | 16:12 |
| mordred | corvus: nod. just add a preview link | 16:12 |
| corvus | mordred: yep. maybe rename the existing one | 16:13 |
| corvus | since it's currently "site preview" | 16:13 |
| corvus | maybe call it 'site build' or something | 16:13 |
| openstackgerrit | Merged zuul/zuul-jobs master: Ensure output dirs are empty https://review.opendev.org/727135 | 16:13 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-javascript-output: do not synchronize owner https://review.opendev.org/727719 | 16:13 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-javascript-tarball: do not synchronize owner https://review.opendev.org/727720 | 16:13 |
| *** bhavikdbavishi1 has joined #zuul | 16:15 | |
| openstackgerrit | Merged zuul/zuul master: Default to Ansible 2.9 https://review.opendev.org/727345 | 16:15 |
| *** bhavikdbavishi has quit IRC | 16:16 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 16:16 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul-website master: Switch website to Gatsby https://review.opendev.org/717371 | 16:17 |
| openstackgerrit | Merged zuul/zuul master: Drop support for ansible 2.6 https://review.opendev.org/727157 | 16:18 |
| openstackgerrit | Merged zuul/zuul-jobs master: Remove --verbose from js_build_command https://review.opendev.org/728930 | 16:21 |
| *** jcapitao has quit IRC | 16:21 | |
| *** ysandeep|afk is now known as ysandeep | 16:33 | |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-markdownlint: do not synchronize owner https://review.opendev.org/727721 | 16:34 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-phoronix-results: do not synchronize owner https://review.opendev.org/727722 | 16:34 |
| *** nils has quit IRC | 16:48 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul-website master: Switch website to Gatsby https://review.opendev.org/717371 | 16:52 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Remove ununecessary shebangs https://review.opendev.org/728951 | 16:52 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Remove ununecessary shebangs https://review.opendev.org/728951 | 16:58 |
| *** ysandeep is now known as ysandeep|away | 17:02 | |
| openstackgerrit | James E. Blair proposed zuul/zuul-jobs master: Allow mapping additional hostvars in write-inventory https://review.opendev.org/728952 | 17:03 |
| fbo | corvus: monty I've added ansible/base/actiongeneral/zuul_return.py in the PS2 | 17:04 |
| corvus | mordred: ^ | 17:05 |
| fbo | what about web/__init__.py should it keep the shebang and the exec bit ? | 17:06 |
| corvus | fbo: i don't think so, i think it's launched the same way (zuul-web entrypoint) | 17:07 |
| fbo | corvus: yes I'll include it in the patch then. What about ansible/base/library/command.py and ansible/base/library/zuul_console.py is the shebang useful there ? | 17:09 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Remove ununecessary shebangs https://review.opendev.org/728951 | 17:10 |
| corvus | fbo: unsure -- the only reason i can think to keep it is in case ansible requires it, but i don't know if it does | 17:10 |
| corvus | mordred: ^? | 17:11 |
| mordred | also unsure | 17:11 |
| mordred | I don't think it does though | 17:11 |
| corvus | yeah, i would also guess no | 17:11 |
| fbo | is it supposed to be catched by the CI ? if we remove them ? | 17:11 |
| corvus | fbo: maybe handle those in a followup change? yes, it should be tested | 17:11 |
| fbo | ok | 17:12 |
| *** sgw has quit IRC | 17:16 | |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: Remove shebang for base/library/command.py|zuul_console.py https://review.opendev.org/728955 | 17:16 |
| *** fbo is now known as fbo|off | 17:18 | |
| *** jpena is now known as jpena|off | 17:18 | |
| corvus | mordred: is https://review.opendev.org/726372 still the state of the art? | 17:26 |
| corvus | mordred: (do we still want that?) | 17:26 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-puppet-module-output: do not synchronize owner https://review.opendev.org/727723 | 17:28 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-python-sdist-output: do not synchronize owner https://review.opendev.org/727724 | 17:29 |
| *** armstrongs has joined #zuul | 17:31 | |
| mordred | corvus: yes - I thnik we do want that - however, orthogonally, I'm not 100% sure our multi-arch builds are doing the right thing | 17:32 |
| mordred | (well, not _quite_ orthogonal. whether we want that is not related to the multi-arch builds doing the right thing or not, although obviously them not doing the right thing could have deleterious impact on how well that would work) | 17:33 |
| *** hashar has quit IRC | 17:44 | |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-sphinx-output: do not synchronize owner https://review.opendev.org/727725 | 17:46 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-sphinx-tarball: do not synchronize owner https://review.opendev.org/727726 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-tox-output: do not synchronize owner https://review.opendev.org/727727 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-translation-output: do not synchronize owner https://review.opendev.org/727728 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: fetch-subunit-output: do not synchronize owner https://review.opendev.org/727729 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: prepare-workspace: do not synchronize owner https://review.opendev.org/727730 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: publish-artifacts-to-fileserver: do not synchronize owner https://review.opendev.org/727731 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: upload-logs: do not synchronize owner https://review.opendev.org/727732 | 18:00 |
| openstackgerrit | Merged zuul/zuul-jobs master: tarball-post.yaml: do not synchronize owner https://review.opendev.org/727735 | 18:00 |
| avass | Looks like all the unarchive/synchronize changes are merged now and everything looks good | 18:04 |
| *** hashar has joined #zuul | 18:04 | |
| avass | There could still be some stray tasks that hasn't been caught yet since the linter rule isn't 100% yet but I'll update it during the week | 18:05 |
| *** jamesmcarthur has quit IRC | 18:05 | |
| *** hashar is now known as hasharAway | 18:09 | |
| *** sgw has joined #zuul | 18:14 | |
| openstackgerrit | Merged zuul/zuul master: Remove ununecessary shebangs https://review.opendev.org/728951 | 18:33 |
| *** jamesmcarthur has joined #zuul | 18:35 | |
| *** jamesmcarthur has quit IRC | 18:35 | |
| *** jamesmcarthur has joined #zuul | 18:35 | |
| mordred | corvus: woot. https://review.opendev.org/#/c/717371/ is all the way green and the zuul-preview deploy works great | 18:39 |
| *** panda is now known as panda|off | 18:40 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [WIP] Builds: add "held" attribute https://review.opendev.org/728994 | 18:51 |
| *** rlandy_ has joined #zuul | 19:18 | |
| *** rlandy has quit IRC | 19:20 | |
| *** rlandy_ is now known as rlandy | 19:21 | |
| corvus | avass: thanks! | 19:23 |
| corvus | mordred: lgtm! :) | 19:26 |
| openstackgerrit | James E. Blair proposed zuul/zuul-jobs master: Allow mapping additional hostvars in write-inventory https://review.opendev.org/728952 | 19:34 |
| openstackgerrit | James E. Blair proposed zuul/zuul-jobs master: Update flake8 ignore rules to match Zuul https://review.opendev.org/729010 | 19:34 |
| *** hasharAway is now known as hashar | 19:39 | |
| avass | so removing tox_envlist: venv is working now, but softwarefactory doesn't seem to like it: https://review.opendev.org/#/c/726830/6 | 20:01 |
| avass | I guess that 'fake-tox' doesn't have a default configured envlist | 20:02 |
| AJaeger | avass: are there repos that depend on tox_envlist = venv? Are those fixed? | 20:04 |
| AJaeger | corvus: do you want to review the tox_envlist change https://review.opendev.org/726829 ? | 20:05 |
| corvus | AJaeger: hrm, i don't see a response to my question on that | 20:06 |
| corvus | oh sorry, wrong patch | 20:06 |
| corvus | i don't see a response to my question on https://review.opendev.org/726830 | 20:06 |
| avass | AJaeger: haven't taken a look yet | 20:06 |
| AJaeger | corvus: yeah, waiting for that one as well | 20:07 |
| corvus | yes, i'll look at 829 | 20:07 |
| avass | 829, grew a bit :) | 20:07 |
| AJaeger | thanks, corvus. I tested an earlier version with openstackdocstheme and a cross-nova job - finally working thanks to the parsing of envdir | 20:07 |
| corvus | avass, AJaeger: generally looks good, but i think we can simplify it a bit; comment inline | 20:15 |
| avass | corvus: oh, yeah we could probably do that | 20:16 |
| avass | corvus: oh I forgot to update the docs :) | 20:17 |
| corvus | avass: i think you'll need the 'readfp' method on configparser to use with stringio; that's deprecated in 3.x (but still present); replaced with read_file -- might be good to do a version switch | 20:18 |
| corvus | avass: i like the docs and think you should leave them and update the code to match :) | 20:18 |
| avass | corvus: hmm but I wonder if we really want to pass a string since that produces a lot of ugly output in zuul | 20:18 |
| corvus | how does it produce ugly output? | 20:18 |
| corvus | oh, because it's going to stdout? | 20:19 |
| avass | corvus: yeah | 20:19 |
| avass | and you can't no_log with register | 20:19 |
| avass | at least it didn't work when I tried | 20:20 |
| corvus | avass: bummer; if you want to update the docs to match the implementation, i'm okay with that. | 20:22 |
| avass | corvus: I need to do one quick update anyway since I noticed that I forgot to remove some things :) | 20:22 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 20:25 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Don't require tox_envlist https://review.opendev.org/726829 | 20:26 |
| avass | I think I've been working a bit too much with containers lately ;) | 20:26 |
| avass | I'm calling it for tonight, if there's anything else you want to nit on feel free to update it | 20:28 |
| corvus | avass: heh :) lgtm, thanks | 20:32 |
| AJaeger | zuul-jobs maintainers, https://review.opendev.org/726829 is a larger rewrite of tox handling, additional reviews welcome! | 20:40 |
| corvus | clarkb, fungi, mnaser, mordred: ^ | 20:43 |
| *** bhavikdbavishi has quit IRC | 20:46 | |
| *** bhavikdbavishi has joined #zuul | 20:46 | |
| *** bhavikdbavishi has quit IRC | 20:51 | |
| mordred | avass: wow. you went all the way down the rabbit hole on that one :) | 20:56 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-website master: Add blog to website https://review.opendev.org/724648 | 20:56 |
| mordred | clarkb: wanna re-review https://review.opendev.org/#/c/717371/26 ? | 20:57 |
| mordred | clarkb: since last you looked, I split the blog stuff into its own patch (so it should be clearer what's going on there) and I think I addressed your earlier review comments | 20:58 |
| mordred | clarkb: oh - not the hover navbar - that'll still want to be a followup I think | 20:59 |
| mordred | mnaser: ^^ btw - that's all the way working now, along with a zuul-preview site | 21:00 |
| clarkb | mordred: fwiw I think we may just need to edit the dimensions of that box to match the dimensions of the normal navbar | 21:03 |
| clarkb | mordred: of course I've forgotten when the other dimensions are and am trying to find them now | 21:03 |
| clarkb | the problem is the dimensions change and so you get that super annoying behavior on scroll | 21:03 |
| corvus | oh shoot | 21:04 |
| corvus | mordred: i thought you'd fixed those :( | 21:04 |
| clarkb | mordred: https://review.opendev.org/#/c/717371/26/src/components/Layout/Navbar/Navbar.styled.js line 5 vs https://review.opendev.org/#/c/717371/26/src/components/Layout/Header/Header.styled.js line 12 | 21:05 |
| clarkb | but I'm totally not a css person | 21:05 |
| corvus | mordred: i'd really love to keep the documentation dropdown; i'm kinda curious why the top has to change at all? | 21:05 |
| clarkb | I don't have suggestions for the docs dropdown shortcut | 21:09 |
| corvus | oh, i also just noticed that the graphics are larger, so we're scaling up raster images which looks not great | 21:10 |
| *** tumble has quit IRC | 21:11 | |
| *** rfolco|rover is now known as rfolco|rover|off | 21:12 | |
| corvus | clarkb, mordred: i left a longer review comment | 21:16 |
| clarkb | AJaeger: I left a question on https://review.opendev.org/#/c/726829/57 | 21:19 |
| clarkb | corvus: agreed that its the minimal twitch the navbar does that makes the size transition weird. If we made it a bigger jump it would probably be fine | 21:20 |
| *** hashar has quit IRC | 21:30 | |
| openstackgerrit | Monty Taylor proposed zuul/zuul-preview master: Remove autoconf https://review.opendev.org/729066 | 21:45 |
| mordred | corvus: thanks - will read. | 21:46 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-preview master: Remove autoconf https://review.opendev.org/729066 | 21:50 |
| *** sshnaidm is now known as sshnaidm|afk | 22:00 | |
| *** threestrands has joined #zuul | 22:06 | |
| *** rlandy has quit IRC | 22:55 | |
| *** rfolco|rover|off has quit IRC | 23:22 | |
| *** yolanda has quit IRC | 23:36 | |
| *** tosky has quit IRC | 23:39 | |
| *** jamesmcarthur has quit IRC | 23:42 | |
| *** jamesmcarthur has joined #zuul | 23:43 | |
| *** jamesmcarthur has quit IRC | 23:47 | |
| *** amotoki has quit IRC | 23:53 | |
| *** amotoki has joined #zuul | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!