*** tosky has quit IRC | 00:01 | |
*** rlandy has quit IRC | 00:06 | |
*** jamesmcarthur has joined #zuul | 00:06 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 00:15 |
---|---|---|
*** jamesmcarthur has quit IRC | 00:33 | |
*** jamesmcarthur has joined #zuul | 00:33 | |
*** jamesmcarthur has quit IRC | 00:37 | |
*** Goneri has quit IRC | 00:42 | |
*** ysandeep|away is now known as ysandeep | 01:02 | |
*** jamesmcarthur has joined #zuul | 01:14 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Add tutorial tests https://review.opendev.org/728194 | 01:26 |
*** jamesmcarthur has quit IRC | 01:27 | |
*** guillaumec has quit IRC | 01:30 | |
*** swest has quit IRC | 01:36 | |
*** swest has joined #zuul | 01:51 | |
*** jamesmcarthur has joined #zuul | 02:59 | |
*** jamesmcarthur has quit IRC | 03:15 | |
*** jamesmcarthur has joined #zuul | 03:15 | |
*** bhavikdbavishi has joined #zuul | 03:16 | |
*** jamesmcarthur has quit IRC | 03:20 | |
*** tobberydberg has quit IRC | 03:25 | |
*** bhavikdbavishi1 has joined #zuul | 03:27 | |
*** bhavikdbavishi has quit IRC | 03:29 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:29 | |
*** tobberydberg has joined #zuul | 03:35 | |
*** jamesmcarthur has joined #zuul | 03:54 | |
*** jamesmcarthur has quit IRC | 04:01 | |
*** jamesmcarthur has joined #zuul | 04:01 | |
*** saneax has joined #zuul | 04:31 | |
*** evrardjp has quit IRC | 04:33 | |
*** sshnaidm is now known as sshnaidm|off | 04:33 | |
*** evrardjp has joined #zuul | 04:33 | |
*** bhavikdbavishi has quit IRC | 04:45 | |
*** jamesmcarthur_ has joined #zuul | 05:01 | |
*** jamesmcarthur has quit IRC | 05:05 | |
*** bhavikdbavishi has joined #zuul | 05:14 | |
*** bhavikdbavishi has quit IRC | 05:16 | |
*** bhavikdbavishi has joined #zuul | 05:17 | |
*** bhavikdbavishi1 has joined #zuul | 05:26 | |
*** bhavikdbavishi has quit IRC | 05:28 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 05:28 | |
*** sgw has quit IRC | 06:01 | |
*** bhavikdbavishi has quit IRC | 06:42 | |
*** jamesmcarthur_ has quit IRC | 06:44 | |
*** jamesmcarthur has joined #zuul | 06:44 | |
*** jamesmcarthur_ has joined #zuul | 06:45 | |
*** jamesmcarthur has quit IRC | 06:49 | |
*** jamesmcarthur_ has quit IRC | 06:50 | |
*** guillaumec has joined #zuul | 06:55 | |
*** ysandeep is now known as ysandeep|afk | 07:12 | |
*** jamesmcarthur has joined #zuul | 07:20 | |
*** ysandeep|afk is now known as ysandeep | 07:34 | |
*** tosky has joined #zuul | 07:34 | |
*** jamesmcarthur has quit IRC | 07:35 | |
*** asaleh_ has joined #zuul | 07:35 | |
*** jpena|off is now known as jpena | 07:38 | |
*** bhavikdbavishi has joined #zuul | 07:41 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: WIP: Enable ANSI rendering on stdout/stderr https://review.opendev.org/716251 | 07:44 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Enable ANSI rendering on stdout/stderr https://review.opendev.org/716251 | 07:54 |
*** nils has joined #zuul | 08:04 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Bump ansible-lint to 4.3.0 https://review.opendev.org/702679 | 08:04 |
*** tumble has joined #zuul | 08:12 | |
*** hashar has joined #zuul | 08:32 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: revoke-sudo: improve sudo removal https://review.opendev.org/703065 | 08:44 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: WIP: Import user tutorials from Software Factory project blog https://review.opendev.org/728193 | 09:05 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Add tutorial tests https://review.opendev.org/728194 | 09:05 |
*** ysandeep is now known as ysandeep|lunch | 09:09 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: Add missing virtualenv and fixed repo install https://review.opendev.org/693637 | 09:10 |
zbr | do we have a chaperone for gentoo jobs? | 09:13 |
zbr | i would really want to avoid having to look into anything broken suse or gentoo jobs, dpkg and rpm distros take enough time to tame any way :D | 09:14 |
openstackgerrit | Guillaume Chauvel proposed zuul/nodepool master: Initial change to rename zuul-quick-start to zuul-tutorial-quick-start https://review.opendev.org/728262 | 09:20 |
*** jamesmcarthur has joined #zuul | 09:37 | |
*** bhavikdbavishi has quit IRC | 09:45 | |
*** jamesmcarthur has quit IRC | 09:46 | |
*** ysandeep|lunch is now known as ysandeep | 10:01 | |
*** bhavikdbavishi has joined #zuul | 10:03 | |
*** hashar has quit IRC | 10:31 | |
*** zenkuro has joined #zuul | 10:37 | |
zenkuro | hi if I want to add another place to put on logos I have add secret encrypted with specific project name, but what If I want to add another base job. What project should I spacify within tool/encrypt_secret.py? | 10:40 |
*** zenkuro has quit IRC | 10:45 | |
*** bhavikdbavishi has quit IRC | 10:50 | |
*** guillaumec has quit IRC | 11:00 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 11:26 |
*** jpena is now known as jpena|lunch | 11:30 | |
AJaeger | avass: what do you think of https://review.opendev.org/730306 ? | 11:43 |
avass | AJaeger: I'm confused to why we need to specify venv? is that wanted there? | 12:00 |
avass | AJaeger: what does tox -e venv do? run the default tox envlist in a venv instead of virtualenv? | 12:01 |
AJaeger | avass: I was helping you with https://review.opendev.org/#/c/726830 - but the horizon change is not needed | 12:02 |
avass | AJaeger: yeah, but I don't think I understand why -e venv is needed in the first place :) | 12:03 |
AJaeger | avass: it's not needed in that change. In the past we build docs this way "tox -e venv -- python setup.py build_sphinx" | 12:04 |
avass | AJaeger: ah so it's just a way to run a python script in a venv | 12:06 |
AJaeger | avass: that's what we did in the past - but all of that was Jenkins time, so should be gone. I think we can move forward with 726830 | 12:07 |
avass | AJaeger: nice! thanks :) | 12:08 |
fungi | and it wasn't any sort of built-in tox magic, we literally defined a [testenv:venv] in every project which just did command={posargs} | 12:09 |
fungi | so no different from any other tox testenv really, there was nothing particularly special about it | 12:09 |
avass | got it, that's what confused me | 12:11 |
avass | AJaeger: so all we need to do for 726830 is to get software factory working | 12:13 |
AJaeger | avass: yep, just rechecked | 12:14 |
AJaeger | avass: and decide whether we need an announcement email. corvus, do we need one? | 12:14 |
avass | AJaeger: I think the problem is that they don't set a default envlist in their tox.ini | 12:14 |
AJaeger | avass: let's ask tristanC ^^ | 12:16 |
*** rlandy has joined #zuul | 12:17 | |
tristanC | AJaeger: avass: what is the issue? | 12:21 |
AJaeger | tristanC: check 726830 - why is Software Factory CI failing with that change? avass had one suggestion... | 12:22 |
tristanC | it fails because `tox: error: argument -e: expected one argument` : https://softwarefactory-project.io/logs/30/726830/8/third-party-check/test-job-tox-el7/26f7267/ara-report/ | 12:23 |
avass | tristanC: yeah, since we no longer default to tox_envlist: venv | 12:23 |
avass | (with that change) | 12:23 |
tristanC | and i guess that is failing because we use the `tox` job, not one of the `tox-*` | 12:24 |
avass | yeah, adding envlist = venv in tox.ini should produce the same behaviour | 12:26 |
avass | tristanC: so adding a couple of line to this: https://softwarefactory-project.io/logs/30/726830/8/third-party-check/test-job-tox-el7/26f7267/ara-report/ :) | 12:27 |
tristanC | avass: we can do that, but what about projects which do not have that setting in their tox.ini, is this a new requirement? | 12:27 |
avass | tristanC: yes, I believe AJaeger could't find any projects that uses venv in opendev at least, but we might want to do an announcement for the change | 12:29 |
avass | just to be sure | 12:29 |
avass | tristanC: the idea is that the tox role should work the same as running 'tox' on the commandline | 12:30 |
tristanC | avass: then why not removing the `-e` argument? | 12:31 |
*** jpena|lunch is now known as jpena | 12:32 | |
avass | tristanC: hmm, I guess we could do that but we need to expand the envlist for tox_siblings | 12:34 |
avass | tristanC: but that sets a different internal variable so we could handle that | 12:34 |
*** hashar has joined #zuul | 12:36 | |
tristanC | avass: as you prefer, i'd be happy to add the new tox.ini option, `Software Factory CI` ci job config is: https://softwarefactory-project.io/cgit/third-party-ci-jobs/tree/playbooks/fake-tox.yaml#n9 | 12:37 |
avass | tristanC: just noticed that's a case I missed, if envlist isn't set it has the same behaviour as ALL | 12:39 |
avass | tristanC: so let's not change software factory ci, I'll fix that instead | 12:39 |
tristanC | avass: nice, thank you! | 12:40 |
*** rlandy is now known as rlandy|mtg | 12:50 | |
*** bhavikdbavishi has joined #zuul | 12:50 | |
*** rfolco|rover is now known as rfolco|rover|bbl | 12:52 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Minor documentation rephrase https://review.opendev.org/728640 | 12:52 |
*** guillaumec has joined #zuul | 12:53 | |
*** bhavikdbavishi1 has joined #zuul | 12:58 | |
*** bhavikdbavishi has quit IRC | 13:00 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 13:00 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL https://review.opendev.org/730322 | 13:12 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL https://review.opendev.org/730322 | 13:17 |
avass | AJaeger, tristanC: that's ^ probably what I've should have done from the beginning | 13:17 |
*** rlandy|mtg is now known as rlandy | 13:19 | |
*** guillaumec has quit IRC | 13:20 | |
*** cdearborn has joined #zuul | 13:24 | |
*** cdearborn has left #zuul | 13:26 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL https://review.opendev.org/730322 | 13:27 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 13:28 |
avass | tristanC: that should give us the behaviour we want | 13:28 |
*** bhavikdbavishi has quit IRC | 13:34 | |
*** bhavikdbavishi has joined #zuul | 13:34 | |
mordred | avass: nice | 13:35 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL https://review.opendev.org/730322 | 13:36 |
openstackgerrit | Monty Taylor proposed zuul/zuul master: Update create-react-scripts to 3.4.2 https://review.opendev.org/729954 | 13:36 |
*** Goneri has joined #zuul | 13:39 | |
*** bhavikdbavishi has quit IRC | 13:39 | |
*** guillaumec has joined #zuul | 13:39 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Undefined envlist should behave like tox -e ALL https://review.opendev.org/730322 | 13:43 |
*** jamesmcarthur has joined #zuul | 13:43 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 13:44 |
avass | AJaeger: oh, fetch-tox-output is probably broken if envdir is set to something else then | 13:45 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Revert "Add Gentoo integration tests" https://review.opendev.org/730329 | 13:47 |
*** jamesmcarthur has quit IRC | 13:49 | |
*** rlandy is now known as rlandy|mtg | 13:55 | |
*** zenkuro has joined #zuul | 13:57 | |
zenkuro | hi if I want to add another place to put on logos I have add secret encrypted with specific project name, but what If I want to add another base job. What project should I spacify within tool/encrypt_secret.py? | 13:57 |
mordred | zenkuro: you always want to use encrypt_secret for the project where the secret is going | 13:59 |
mordred | zenkuro: secrets are only accessible by playbooks in the project where they are defined - so if you put a secret in a base job (encrypted to the project where the base job is) - then only the base job will have access to those secrets. (the base job can use them to do things so that child jobs can have the benefit of the secret having been used without the child job needing to acess the secret) | 14:00 |
*** nhicher has quit IRC | 14:03 | |
zenkuro | mordred: yes. regsrdless your last statment. what pub key should I use for making universal base job? | 14:05 |
zenkuro | or Im missing something | 14:05 |
mordred | zenkuro: you should use the key of the project the base job is defined in | 14:06 |
mordred | or - wait - let me ask a question to make sure I understand | 14:06 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: empty envlist should behave like tox -e ALL https://review.opendev.org/730322 | 14:06 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 14:06 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL https://review.opendev.org/730334 | 14:06 |
mordred | zenkuro: you want to make a base job that uses a secret to define something? or you want to make a base job that does something but you expect it to need a secret that would be different per-project using it? | 14:07 |
zenkuro | mordred: I want base job to push logs on different ftp server for every its child job | 14:09 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable https://review.opendev.org/723534 | 14:10 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable https://review.opendev.org/723534 | 14:10 |
avass | zenkuro: is the child job in an untrusted project? | 14:12 |
mordred | zenkuro: ok. so this is possible, but I think it might get slightly annoying for you | 14:12 |
avass | zenkuro: or in a different project | 14:12 |
zenkuro | it is untrusted priject | 14:13 |
zenkuro | and I do not want to add anothere key for every new project | 14:13 |
mordred | zenkuro: what you want is the base job with the ftp publishing roles but without a secret. then, in each project you will want a child job of that base job that defines a secret with the ftp credentials, with the secret encrypted for that project, and the job sets pass-to-parent on the ftp credentials secret: https://zuul-ci.org/docs/zuul/reference/config.html#attr-job.secrets.pass-to-parent | 14:13 |
avass | mordred, zenkuro: it wouldn't be possible to upload logs in a pre-review pipeline that way | 14:14 |
mordred | avass: yeah | 14:14 |
avass | zenkuro: if it's okay for the different projects to have access to eachothers logservers you could define a dictionary of credentials in the base job and let the child job choose which one to upload to by setting a variable | 14:16 |
mordred | OH | 14:16 |
mordred | wait | 14:16 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable https://review.opendev.org/723534 | 14:16 |
mordred | I think I might understand the issue | 14:16 |
*** nhicher has joined #zuul | 14:16 | |
mordred | zenkuro: is the problem that you want different log locations per-project - but the add-fileserver role is designed to put the base path into the secret? | 14:17 |
mordred | (I'm certain there is a solution to do what you want to do - but we might just need to learn a little more about the details of what you need here) | 14:18 |
zenkuro | nope, in general I have main zuul server with logs and Im bulding ci for openstack and I need to share some of the logs to public server | 14:21 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: empty envlist should behave like tox -e ALL https://review.opendev.org/730322 | 14:24 |
*** y2kenny has joined #zuul | 14:27 | |
y2kenny | Is there a way to configure a playbook such that the executor will ignore host key checking when connecting to the nodes? | 14:28 |
corvus | y2kenny: i don't think so; instead we try to get the host keys correctly supplied to the executor from nodepool | 14:29 |
y2kenny | corvus: this is the case where the job pre-step is doing majority of the node preparation. | 14:30 |
y2kenny | it's actually not the baremetal use case yet but I will probably run into the same problem when I get to that one. | 14:31 |
y2kenny | for now, I am actually launching VMs on kubernetes using kubevirt | 14:31 |
corvus | y2kenny: with nodepool's static driver, you can specify the host keys for the bare metal nodes | 14:31 |
corvus | y2kenny: so you're getting a k8s namespace from nodepool, and creating vms in that? | 14:32 |
y2kenny | yes | 14:32 |
corvus | y2kenny: i have 2 thoughts: 1) maybe we should look into a new nodepool driver for that use case :) | 14:32 |
y2kenny | sigh... | 14:32 |
*** nhicher has quit IRC | 14:32 | |
y2kenny | I guess I have two nodepool driver to write... | 14:32 |
*** rlandy|mtg is now known as rlandy | 14:32 | |
corvus | y2kenny: well, i was just thinking it might be useful for other folks, it sounds neat | 14:33 |
corvus | y2kenny: but wait i have more | 14:33 |
corvus | y2kenny: 2) the known_hosts file is writeable in the work dir, so if you can get the host keys in your prep step, you can write them to .ssh/known_hosts in the zuul work dir | 14:33 |
y2kenny | corvus: I want to write them... it's the corporate open source policy/paper work that cause me headache. | 14:34 |
avass | corvus, y2kenny: can't you modify the inventory at runtime? if so you could add a ansible_extra_ssh_args: -o StrictHostKeyChecking=no as a temporary solution | 14:34 |
y2kenny | corvus: Oh... like a direct file write? I haven't tried that one. I tried using the known_host ansible module but it failed on something. | 14:35 |
avass | but I like corvus solution more :) | 14:35 |
y2kenny | avass, corvus: ansible_extra_ssh_args is prohibited for Zuul's add_host (that solution I tried) | 14:35 |
corvus | it's worth at least trying to keep host validation working :) | 14:35 |
y2kenny | I also tried setting a var for the play (ansible_host_key_check=false) that one seems to be a long standing ansible bug that hasn't been fixed | 14:36 |
corvus | avass's solution may work if you can do that in a trusted execution context (ie, config-project playbook). | 14:36 |
corvus | but yeah, the known_hosts file is intended to be writeable, so that seems the most straightforward way | 14:37 |
openstackgerrit | Merged zuul/zuul master: Update to create-react-app 3.4.1 https://review.opendev.org/716305 | 14:37 |
y2kenny | corvus: Oh... I forgot about that. Yes, eventually the role/job will be in a trusted context. I was just doing things in untrusted environment right now to leverge the pre-submit test/iteration. | 14:38 |
corvus | y2kenny: cool. i suggest trying the known_hosts thing first -- it's less dodgy. and if it doesn't work or you need the other thing somehow, that should be possible. | 14:38 |
y2kenny | corvus: and fwiw, I was going to start writing nodepool driver after this task. | 14:38 |
*** sgw has joined #zuul | 14:39 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL https://review.opendev.org/730334 | 14:40 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 14:40 |
y2kenny | corvus: totally unrelated question. Do you guys have any plans create an entity to do commercial support (or if there's one already that I am not aware of)? Kind of like how Cloudbee is to Jenkins? | 14:40 |
y2kenny | corvus: (this is not related to the nodepool drivers thing... I will try to write those. it's more about pitching and recommending zuul in other contexts.) | 14:42 |
*** jamesmcarthur has joined #zuul | 14:45 | |
*** zenkuro has quit IRC | 14:46 | |
corvus | y2kenny: that's a great question; vexxhost does provide a commercial saas offering, and i'd love there to be more in that space | 14:47 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL https://review.opendev.org/730334 | 14:53 |
*** jamesmcarthur has quit IRC | 15:03 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 15:04 |
*** nhicher has joined #zuul | 15:05 | |
*** jamesmcarthur has joined #zuul | 15:07 | |
openstackgerrit | Sagi Shnaidman proposed zuul/zuul-jobs master: WIP Add ansible collection roles https://review.opendev.org/730360 | 15:14 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 15:19 |
*** nhicher has quit IRC | 15:23 | |
avass | tristanC: I think https://review.opendev.org/#/c/726830/ is breaking because a bug in tox now | 15:25 |
avass | I mean, it's failing because it looks like tox itself is broken | 15:26 |
*** nhicher has joined #zuul | 15:28 | |
avass | tristanC: I'm able to reproduce that with tox==3.13.2 if envlist isn't set. Anything above that works | 15:30 |
tristanC | avass: 3.13.2 is the version shipped in fedora31 | 15:31 |
*** rfolco|rover|bbl is now known as rfolco|rover | 15:31 | |
avass | tristanC: oh :( | 15:32 |
avass | tristanC: maybe just adding a failed_when: false there is enough? | 15:32 |
tristanC | avass: i don't think zuul-jobs should silence all failure just because there is a bug in the tox version shipped by fedora31 | 15:35 |
tristanC | avass: in f32 it is tox-3.14.6 , let me see if can add ci for that version instead | 15:36 |
tristanC | avass: ideally we would 'failed_when: distro != f31' until the bug is fixed | 15:36 |
avass | oh fedora32 is out, I should probably upgrade :) | 15:37 |
*** y2kenny has quit IRC | 15:38 | |
*** hashar has quit IRC | 15:40 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 15:40 |
tristanC | https://softwarefactory-project.io/r/#/q/topic:f32-tp-ci should adds new -f32 jobs | 15:42 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Disable broken gentoo job nv https://review.opendev.org/728640 | 15:43 |
avass | tristanC: nice | 15:44 |
*** nhicher has quit IRC | 15:46 | |
*** jamesmcarthur has quit IRC | 15:49 | |
avass | tristanC: actually, adding a check for tox version is probably better. I'll see if I can do that | 15:50 |
*** nils has quit IRC | 15:51 | |
*** nhicher has joined #zuul | 15:54 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable https://review.opendev.org/723534 | 15:59 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 15:59 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 16:03 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Make gentoo jobs nv https://review.opendev.org/728640 | 16:03 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 16:14 |
*** nhicher has quit IRC | 16:15 | |
*** jamesmcarthur has joined #zuul | 16:17 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 16:18 |
*** nhicher has joined #zuul | 16:19 | |
*** jamesmcarthur has quit IRC | 16:21 | |
*** bhavikdbavishi has joined #zuul | 16:21 | |
*** jamesmcarthur has joined #zuul | 16:21 | |
*** jamesmcarthur has quit IRC | 16:21 | |
*** jamesmcarthur has joined #zuul | 16:21 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 16:31 |
*** jamesmcarthur has quit IRC | 16:34 | |
*** jamesmcarthur has joined #zuul | 16:35 | |
*** jamesmcarthur has quit IRC | 16:39 | |
*** jamesmcarthur has joined #zuul | 16:39 | |
zbr | tristanC: avass: maybe is time to allow tox to be upgraded via https://review.opendev.org/#/c/690057/ | 16:43 |
*** jpena is now known as jpena|off | 16:43 | |
tristanC | zbr: this is not related, unless we make the upgrade a default, our use-case doesn't involve upgrading tox | 16:48 |
zbr | it would allow us to do whatever we want, upgrading or not. | 16:48 |
zbr | sooner or later we would have users requiring a specific tox version | 16:49 |
zbr | its ability to bootstrap itself is cool, but it would still not be enough if the pre-installed version is buggy | 16:50 |
tristanC | zbr: i agree this is good to have, but what we are testing here is that you a python project can be tested by the tox provided by the distro, thus we explicitely do not want to upgrade tox using pip | 16:51 |
zbr | tristanC: good luck with that, centos-8 does not have any tox and the one from centos-7 is unusable-old. | 16:51 |
tristanC | zbr: we are already using the fedora and centos tox package successfully | 16:53 |
avass | tristanC: that ^ works and I just added a comment to explain why we set the failed_when the way we do | 16:53 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 16:53 |
avass | oh, that ^ :) | 16:53 |
*** ysandeep is now known as ysandeep|away | 16:54 | |
tristanC | zbr: and if zuul-jobs can't support fedora or centos pacakge, then that's ok and we will remove the third party ci | 16:54 |
zbr | i do no see reasons why it would not be able to, it should definitely support them | 16:55 |
avass | actually, let me break that into it's own change since that should be separate from deprecating tox_envlist: venv | 16:56 |
tristanC | zbr: well if the old version prevent using more recent feature, then i think that's fair to stop supporting them from zuul-jobs | 16:56 |
zbr | tbh, i am glad to see venv default being removed, the default should be empty, and should just run "tox". | 16:57 |
tristanC | but thanks to avass work so far, it seems like it is possible to keep the support | 16:57 |
zbr | i wonder when -l was added and if it did change over time. | 16:58 |
tristanC | avass: btw, f32 variant are now in place | 16:58 |
avass | tristanC: nice! | 16:59 |
*** bhavikdbavishi has quit IRC | 17:18 | |
*** bhavikdbavishi has joined #zuul | 17:33 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 17:33 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: envlist bugfixes https://review.opendev.org/730381 | 17:33 |
avass | zbr: why does 690057 loop over the tox_requirements? | 17:45 |
avass | zbr: oh, it has to be a list and can't be packages separated by a space? | 17:46 |
zbr | avass: yep | 17:47 |
zbr | mainly to allow installing tox plugins | 17:47 |
avass | zbr: but shouldn't .split() be enough to produce a list then? | 17:47 |
zbr | similar to "pip install tox tox-pyenv>12" | 17:48 |
zbr | no, not enough | 17:48 |
zbr | we need to remove the quotes, in case user added them when doing a copy/paste from bash | 17:48 |
zbr | pip module does not expects or allow quotes, but allows conditions. | 17:49 |
*** nhicher has quit IRC | 17:49 | |
*** tosky has quit IRC | 17:50 | |
*** tosky has joined #zuul | 17:51 | |
avass | zbr: left a comment, I think the rest of the change looks good otherwise | 17:54 |
openstackgerrit | Lida Liu proposed zuul/zuul master: WIP: Add commit id to Change for mqtt reporter https://review.opendev.org/722478 | 18:03 |
*** nhicher has joined #zuul | 18:16 | |
mnaser | zuul-maint: ensure-kubernetes is still broken and https://review.opendev.org/#/c/727868/9 is the fix. minikube ack'd it's broken but needs someone to do the fix -- we'll try to drive that but at least for the meantime... https://github.com/kubernetes/minikube/issues/8130 | 18:20 |
mnaser | (and it means any service discovery with coredns is broken) | 18:21 |
*** nhicher has quit IRC | 18:24 | |
*** nhicher has joined #zuul | 18:36 | |
AJaeger | avass: is the teox stack ready for review now? | 18:37 |
avass | AJaeger: I see a minor change, but you can start nitting ;) | 18:39 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 18:39 |
AJaeger | avass: sorry, didn't find nits ;) | 18:40 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: empty envlist should behave like tox -e ALL https://review.opendev.org/730322 | 18:41 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: fetch-tox-output: empty envlist should behave like tox -e ALL https://review.opendev.org/730334 | 18:41 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: tox: envlist bugfixes https://review.opendev.org/730381 | 18:41 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv https://review.opendev.org/726830 | 18:41 |
avass | AJaeger: too bad that changes the entire stack, but I don't need to add default(omit) to change it to default("default") later on | 18:41 |
AJaeger | corvus, mordred , if you have time, could you give avass' tox stack some review love, please? https://review.opendev.org/#/c/730322 the stack looks good to me but this is all tricky so want you to review as well. Do we need to announce the venv change and wait with merging? I have not found any users that we would break, we seem to set venv everywhere (still, the search was tricky, so I might have | 18:43 |
AJaeger | missed something). | 18:44 |
*** bhavikdbavishi has quit IRC | 18:47 | |
*** jamesmcarthur has quit IRC | 18:54 | |
*** nhicher has quit IRC | 18:54 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul-operator master: Add zuul-operator-upload-image job https://review.opendev.org/708860 | 18:58 |
*** jamesmcarthur has joined #zuul | 18:59 | |
*** nhicher has joined #zuul | 19:24 | |
*** nhicher has quit IRC | 19:28 | |
*** jamesmcarthur has quit IRC | 19:35 | |
*** jamesmcarthur has joined #zuul | 19:48 | |
*** jamesmcarthur has quit IRC | 20:12 | |
*** jamesmcarthur has joined #zuul | 20:12 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul-operator master: Add zuul-operator-upload-image job https://review.opendev.org/708860 | 20:45 |
*** jamesmcarthur has quit IRC | 20:50 | |
*** jamesmcarthur has joined #zuul | 20:51 | |
*** jamesmcarthur has quit IRC | 20:56 | |
*** jamesmcarthur has joined #zuul | 20:56 | |
*** jamesmcarthur has quit IRC | 21:11 | |
*** jamesmcarthur has joined #zuul | 21:11 | |
*** tumble has quit IRC | 21:11 | |
*** jamesmcarthur has quit IRC | 21:17 | |
*** jamesmcarthur has joined #zuul | 21:18 | |
*** rfolco|rover has quit IRC | 21:22 | |
*** rlandy has quit IRC | 21:42 | |
Open10K8S | Hi team | 21:44 |
Open10K8S | Could you merge this PS https://review.opendev.org/#/c/727868/? | 21:44 |
Open10K8S | related to the zuul job for ensure-kubernetes | 21:44 |
Open10K8S | Maybe you can remeber about this, started when the minikube 1.10.x released | 21:44 |
Open10K8S | clarkb: we discussed about this before :) | 21:44 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 21:45 |
*** nhicher has joined #zuul | 22:10 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: add simple test runner https://review.opendev.org/728684 | 22:21 |
*** jamesmcarthur has quit IRC | 22:50 | |
*** jamesmcarthur has joined #zuul | 22:51 | |
*** jamesmcarthur has quit IRC | 22:53 | |
*** jamesmcarthur_ has joined #zuul | 22:53 | |
*** tosky has quit IRC | 22:59 | |
tristanC | Open10K8S: mnaser: not sure if you had a reproducer and a depends-on to show that the fix is correct, thus i'm waiting for ci result with https://review.opendev.org/708860 | 23:08 |
Open10K8S | I did this patchset https://review.opendev.org/#/c/729430/ depends on 728684 | 23:10 |
Open10K8S | tristanC: I did this patchset https://review.opendev.org/#/c/729430/ depends on 728684 | 23:11 |
tristanC | alright, then i approved the zuul-jobs change | 23:12 |
*** nhicher has quit IRC | 23:12 | |
openstackgerrit | Merged zuul/zuul-jobs master: Patch CoreDNS corefile https://review.opendev.org/727868 | 23:24 |
*** nhicher has joined #zuul | 23:26 | |
logan- | i'm trying to register and pass some variables from a pre-run playbook to a run playbook. is that something I should use zuul_return for? | 23:43 |
logan- | I found https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/build-container-image/tasks/main.yaml#L1-L15, it looks like that should do it, but I didn't see any documentation about results.json in the zuul_return docs. | 23:44 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!