Monday, 2020-07-27

openstackgerritAndrii Ostapenko proposed zuul/zuul-jobs master: Add ability to use (upload|promote)-docker-image roles in periodic jobs  https://review.opendev.org/74056000:13
openstackgerritAndrii Ostapenko proposed zuul/zuul-jobs master: Add ability to use (upload|promote)-docker-image roles in periodic jobs  https://review.opendev.org/74056000:14
*** rfolco has quit IRC00:32
*** jamesmcarthur has joined #zuul00:50
*** Goneri has quit IRC01:49
*** Goneri has joined #zuul01:50
*** Goneri has quit IRC01:50
*** jamesmcarthur has quit IRC01:51
*** jamesmcarthur has joined #zuul01:55
*** Goneri has joined #zuul01:59
*** Goneri has quit IRC01:59
*** Goneri has joined #zuul02:02
*** Goneri has joined #zuul02:04
*** jamesmcarthur has quit IRC02:15
*** Goneri has quit IRC02:20
*** Goneri has joined #zuul02:23
*** jamesmcarthur has joined #zuul02:27
*** saneax has joined #zuul02:27
*** Goneri has quit IRC02:31
*** jamesmcarthur has quit IRC02:33
*** saneax has quit IRC02:33
*** jamesmcarthur has joined #zuul02:36
*** jamesmcarthur has quit IRC02:37
*** saneax has joined #zuul02:38
*** jamesmcarthur has joined #zuul02:39
*** sgw1 has quit IRC02:40
*** jamesmcarthur has quit IRC02:53
*** sgw1 has joined #zuul02:53
*** sgw1 has quit IRC02:55
*** saneax has quit IRC02:57
*** saneax has joined #zuul03:10
*** sgw1 has joined #zuul03:11
*** jamesmcarthur has joined #zuul03:35
*** bhavikdbavishi has joined #zuul03:39
*** chandankumar has joined #zuul03:44
*** jamesmcarthur has quit IRC03:45
*** jamesmcarthur has joined #zuul03:45
*** fdegir2 has joined #zuul03:49
*** fdegir has quit IRC03:49
*** jamesmcarthur has quit IRC03:52
*** sgw1 has quit IRC04:24
*** Goneri has joined #zuul04:52
*** Goneri has quit IRC05:03
*** Goneri has joined #zuul05:16
*** Goneri has quit IRC05:22
*** Goneri has joined #zuul05:23
*** Goneri has quit IRC05:30
*** Goneri has joined #zuul05:32
*** Goneri has quit IRC05:34
*** Goneri has joined #zuul05:37
*** Goneri has quit IRC05:43
*** Goneri has joined #zuul05:46
*** bhavikdbavishi has quit IRC06:01
*** bhavikdbavishi has joined #zuul06:01
*** marios has joined #zuul06:03
*** bhavikdbavishi1 has joined #zuul06:17
*** bhavikdbavishi has quit IRC06:18
*** bhavikdbavishi1 is now known as bhavikdbavishi06:18
*** bhavikdbavishi has quit IRC06:24
*** Goneri has quit IRC06:26
*** tosky has joined #zuul06:42
*** Goneri has joined #zuul06:59
*** jcapitao has joined #zuul07:10
*** bhavikdbavishi has joined #zuul07:10
*** jpena|off is now known as jpena07:21
*** dpawlik2 has joined #zuul07:23
*** holser has joined #zuul07:23
*** hashar has joined #zuul07:24
openstackgerritFelix Edel proposed zuul/zuul master: PF4: Update to newest patternfly 4 release (2020.09)  https://review.opendev.org/74315707:33
*** Goneri has quit IRC07:35
*** holser_ has joined #zuul07:39
*** holser__ has joined #zuul07:40
*** holser has quit IRC07:41
*** holser has joined #zuul07:44
*** holser_ has quit IRC07:44
*** holser__ has quit IRC07:45
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Add tests  https://review.opendev.org/74274707:47
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Reorg scheduler event process loop  https://review.opendev.org/74274807:47
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Scheduler ref-updated create/delete  https://review.opendev.org/73919807:47
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Allow ref-updated newrev+oldrev reconfiguration  https://review.opendev.org/74274907:47
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Get ref-updated modified files  https://review.opendev.org/73907807:47
*** harrymichal has joined #zuul07:59
*** tosky has quit IRC08:03
*** hrw has joined #zuul08:16
hrwmorning08:17
*** bhavikdbavishi has quit IRC08:19
*** nils has joined #zuul08:23
*** harrymichal has quit IRC08:28
*** bhavikdbavishi has joined #zuul08:28
*** vishalmanchanda has joined #zuul08:29
*** holser_ has joined #zuul08:39
*** rpittau has joined #zuul08:39
*** holser has quit IRC08:40
*** holser_ has quit IRC08:40
*** fdegir2 is now known as fdegir08:40
*** holser has joined #zuul08:42
*** holser_ has joined #zuul08:48
*** holser has quit IRC08:50
*** holser_ has quit IRC08:52
*** holser has joined #zuul08:57
*** holser has quit IRC09:01
*** holser has joined #zuul09:02
*** holser has quit IRC09:09
*** holser has joined #zuul09:09
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Add tests  https://review.opendev.org/74274709:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Reorg scheduler event process loop  https://review.opendev.org/74274809:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Scheduler ref-updated create/delete  https://review.opendev.org/73919809:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Allow ref-updated newrev+oldrev reconfiguration  https://review.opendev.org/74274909:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Get ref-updated modified files  https://review.opendev.org/73907809:23
*** hrw has left #zuul09:27
*** tosky has joined #zuul09:33
openstackgerritBenjamin Schanzel proposed zuul/zuul master: Disable Log Streaming from k8s Pod Nodes  https://review.opendev.org/74318209:53
*** bhavikdbavishi has quit IRC10:03
*** bhavikdbavishi has joined #zuul10:03
*** harrymichal has joined #zuul10:48
*** bhavikdbavishi has quit IRC10:53
tobiashzuul-maint: fyi, we discovered that kubectl port-forward doesn't work reliably for log streaming ^10:55
*** avass has joined #zuul10:58
*** harrymichal has quit IRC10:59
*** harrymichal has joined #zuul10:59
*** iurygregory has quit IRC10:59
*** bhavikdbavishi has joined #zuul11:00
*** iurygregory has joined #zuul11:01
*** jcapitao is now known as jcapitao_lunch11:02
openstackgerritTobias Henkel proposed zuul/zuul master: Evaluate CODEOWNERS settings during canMerge check  https://review.opendev.org/64455711:15
openstackgerritTobias Henkel proposed zuul/zuul master: GitHub Reporter: Fix User Email in Merge Commit Message  https://review.opendev.org/74115711:25
*** jpena is now known as jpena|lunch11:38
*** sanjayu_ has joined #zuul11:53
*** saneax has quit IRC11:56
*** rfolco has joined #zuul12:00
*** bhavikdbavishi has quit IRC12:04
*** rlandy has joined #zuul12:04
openstackgerritBenjamin Schanzel proposed zuul/zuul master: GitHub Reporter: Fix User Email in Merge Commit Message  https://review.opendev.org/74115712:07
*** bhavikdbavishi has joined #zuul12:17
*** mordred has joined #zuul12:20
openstackgerritMerged zuul/zuul master: Revert "Revert "Tune automatic garbage collection of git repos""  https://review.opendev.org/72380012:28
openstackgerritMerged zuul/zuul master: Ensure refs for recent branches are not GCed  https://review.opendev.org/73845412:30
*** evrardjp has quit IRC12:32
*** evrardjp has joined #zuul12:32
*** evrardjp has quit IRC12:32
*** evrardjp has joined #zuul12:33
*** jcapitao_lunch is now known as jcapitao12:33
*** jpena|lunch is now known as jpena12:34
openstackgerritTobias Henkel proposed zuul/zuul master: GitHub Reporter: Fix User Email in Merge Commit Message  https://review.opendev.org/74115712:57
openstackgerritTobias Henkel proposed zuul/zuul master: Evaluate CODEOWNERS settings during canMerge check  https://review.opendev.org/64455713:25
*** bhavikdbavishi has quit IRC13:47
*** sgw1 has joined #zuul13:50
openstackgerritFelix Edel proposed zuul/zuul master: PF4: Fix scrolling behaviour when using keyboard  https://review.opendev.org/74323914:11
felixedelzuul-maint: This https://review.opendev.org/#/c/743239/ should fix the scrolling behaviour when using space, pageup/down and so on. I'm still not entirely sure what's exactly the root cause for this, but this seems to do the trick. Took me quite some time :D14:13
*** harrymichal has quit IRC14:16
*** harrymichal has joined #zuul14:16
*** hashar has quit IRC14:16
*** harrymichal has quit IRC14:22
openstackgerritBenjamin Schanzel proposed zuul/zuul master: GitHub Reporter: Fix User Email in Merge Commit Message  https://review.opendev.org/74115714:23
*** bhagyashris is now known as bhagyashris|away14:24
*** harrymichal has joined #zuul14:41
*** harrymichal has quit IRC14:59
*** harrymichal has joined #zuul15:02
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: WIP: Generalize localStorage state persistency  https://review.opendev.org/74325215:08
zbrfelixedel: how does your change relate to https://review.opendev.org/#/c/742759/15:13
zbrapparently very different approach to address same issue15:13
zbronly thing in common is that nobody knows the root cause15:13
*** bhavikdbavishi has joined #zuul15:15
*** jamesmcarthur has joined #zuul15:42
tobiashzbr: at least what I noticed is that 742759 changes the page to scroll completely compared to the current implementation that doesn't scroll the header15:45
zbrnot scrolling the header is a big improvement IMHO, ideally change number and title should also be part of the header.15:48
zbrso you do not loose context15:48
zbrwhen i seen the css change, i was almost sure something was fishy about it15:49
*** sanjayu__ has joined #zuul15:49
*** sanjayu_ has quit IRC15:52
openstackgerritGhanshyam Mann proposed zuul/zuul master: Add ubuntu-focal for python3.7 platforms  https://review.opendev.org/74326715:53
openstackgerritTobias Henkel proposed zuul/zuul master: Evaluate CODEOWNERS settings during canMerge check  https://review.opendev.org/64455715:54
*** marios has quit IRC16:02
*** jcapitao has quit IRC16:15
*** hashar has joined #zuul16:29
*** Goneri has joined #zuul16:38
*** jpena is now known as jpena|off16:41
*** nils has quit IRC16:43
*** sanjayu__ has quit IRC16:48
*** hamalq has joined #zuul16:55
*** nils has joined #zuul17:04
*** bhavikdbavishi has quit IRC17:21
*** bhavikdbavishi has joined #zuul17:24
*** jamesmcarthur has quit IRC17:26
*** jamesmcarthur has joined #zuul17:27
*** vishalmanchanda has quit IRC18:18
*** evrardjp has quit IRC18:21
*** bhavikdbavishi has quit IRC18:23
*** evrardjp has joined #zuul18:24
gmannclarkb: fungi corvus can you please check this - https://review.opendev.org/#/c/743267/118:30
clarkbgmann: why is openstack installing zuul?18:31
clarkbgmann: also https://packages.ubuntu.com/search?suite=focal&arch=any&searchon=names&keywords=python3.7 that package doesn't exist on focal18:32
*** tosky has quit IRC18:33
fungiyeah, focal has 3.8, you need bionic for older pythons18:35
fungior you need to custom hack in your own python builds18:35
gmannclarkb:  humm, i think I saw it from here with python3.7-dev - https://launchpad.net/ubuntu/focal/+source/python3.718:36
gmannyeah, i think running 3.7 on bionic node. i  initially thought focal has.18:36
clarkbgmann: but also its not clear to me why zuul's bindep file matters, that is for zuul th service and has nothing to do with zuul jobs18:36
gmannthat's mistake. i thought i did in zuul jobs. sorry for that.18:37
clarkbmordred: btw https://review.opendev.org/#/c/741973/ is where we ended up with making nodepool arm64 builds work19:09
clarkbmordred: that got it working but it still takes close to the hour timeout and requires us to work in lockstep with openstack. Another idea thrown out there was to create an intermediate layer for nodepool that has its deps in it, then we can build that periodically and the on demand builds for nodepool changes happen much more quickly (in theory)19:09
clarkbdoing that what we don't know is how long it will take to build wheels for cryptography and bcrypt and pynacl on that intermediate layer19:10
*** jamesmcarthur has quit IRC19:43
*** SpamapS has quit IRC19:46
*** SpamapS has joined #zuul19:50
*** jamesmcarthur has joined #zuul19:51
*** jamesmcarthur has quit IRC19:55
*** jamesmcarthur has joined #zuul19:56
*** hashar has quit IRC20:02
*** jamesmcarthur has quit IRC20:14
*** jamesmcarthur has joined #zuul20:17
*** y2kenny has joined #zuul20:26
y2kennyis max-servers driver specific/openstack only?20:27
clarkby2kenny: it looks like aws and azure support it too?20:28
clarkbits possible that the k8s driver doesn't though20:28
y2kennyok... thanks for confirming...(I just found out... :))20:29
y2kennyprobably launched 100 jobs together on 10 machines...20:29
y2kennyclarkb: are there other ways to limit launches?  I looked at label but looks like it only has min20:31
clarkby2kenny: the only other thing I know about is the quota based management which I think only openstack has added. Its probably not too difficult to add max-servers support to k8s if that is whta you need20:32
clarkby2kenny: the config loading in the base class for drivers laready handles that aspect of it, it should just be a matter of pausing and waiting for resources to be freed before continuning within the k8s driver20:33
clarkbtristanC: ^ do you know why this wasn't added initially?20:33
tristanCclarkb: i don't remember, oODpenshift does have a `max-projects` quota system20:59
clarkbwell we don't need to rely on the remote to tell us, we can track it locally20:59
clarkbwe deal with openstack quotas because they may not be aligned with the nodepool set limits and we want to avoid errors by respecting them, but that is another level of limit handling21:00
tristanCi'm not sure if and how vanilla kubernetes handle quota, but for openshit the handler code check for `quota exceeded` exception message and raise a QuotaException, which should delay and auto retry creation attempt21:04
*** jamesmcarthur has quit IRC21:07
*** jamesmcarthur has joined #zuul21:08
clarkbLooking at the k8s driver we listNodes() and provide the total number of namespaces21:09
clarkbI think where this gets weird is that a namespace does't have a set size21:10
clarkbwhat we could do fairly easily is map max-servers to a max number of namespaces21:10
y2kennyI don't think k8s namespace is some kind of countable resource.  But with the way nodepool uses it's kind of an implied resource.21:11
clarkby2kenny: correct21:11
y2kennyI think max-servers mapping to max number of nameapces is a good limit21:11
y2kennyat least there's a limit :)21:11
clarkbwe could have createNamespace block if it is already at the limit and wait for namespace count to drop21:12
clarkbwhich is basically what the openstack driver does (and I assume gce, aws, etc)21:12
y2kennythat make sense21:12
*** jamesmcarthur has quit IRC21:22
*** tosky has joined #zuul21:25
*** jamesmcarthur has joined #zuul21:27
*** jamesmcarthur has quit IRC21:32
*** jamesmcarthur has joined #zuul21:34
openstackgerritClark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver  https://review.opendev.org/74342421:43
clarkby2kenny: tristanC ^ I don't have a quick and easy way to test that locally but I believe that the k8s jobs that will run for the chagne should give us enough of a "does this regress" check21:44
clarkbif that doesn't completely explode we can try and set max-servers in those jobs and actually exercise the limit maybe21:45
*** SpamapS has quit IRC21:52
corvusclarkb: the last time i needed to locally test a nodepool/zuul/k8s change, i used KIND and it worked well21:55
*** SpamapS has joined #zuul21:57
avassyeah KIND has been great so far22:00
fungithat's hard to perform a web search for... https://kind.sigs.k8s.io/ i guess?22:01
fungiooh, i should have said "kind of hard to..."22:02
y2kennyIt should stand for Kubernetes in Docker22:02
y2kennyclarkb: do you want me to try a local nodepool build and deploy it and see how that goes?  Or do you mean there will be a nodepool build from opendev that I can try?22:02
y2kennyor "Kubernetes IN Docker"22:03
avassfungi: yeah22:03
fungicool, thanks22:03
clarkby2kenny: ya Zuul's CI system (opendev) should do some checks for us. If you're able to test that without impacting your production use then I'd say go for it22:04
avassalso: https://review.opendev.org/#/c/740935/ :)22:04
clarkby2kenny: also feel free to push updates if you find problems22:04
clarkbbasically what the change does is assumes an infinite k8s quota and a 1 instance == 1 namespace usage rate. Then applies some existing lib code to those assumptions which should get us working max-servers22:05
clarkbits also stubbed out so that we could more accurately check things if we want but that would be good for followons I think22:05
y2kennyclarkb: ok, I will see what I can do this week.  I should be able to run multiple nodepool instances.  One more experimental nodepool shouldn't hurt.22:06
clarkby2kenny: fwiw if the testing shows it doens't work I'll do my best to fix it from that too. And maybe tomorrow I'll get a KIND running22:07
openstackgerritClark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver  https://review.opendev.org/74342422:14
*** jamesmcarthur has quit IRC22:31
*** jamesmcarthur has joined #zuul22:31
*** nils has quit IRC22:32
webknjazPSA: Cheroot v8.1.0 refactoring introduced a performance drop. Upgrade to v8.4.2 for the hotfix!22:53
*** harrymichal has quit IRC22:59
*** rlandy is now known as rlandy|bbl23:03
*** sanjayu__ has joined #zuul23:10
*** sanjayu__ has quit IRC23:10
openstackgerritJames E. Blair proposed zuul/zuul master: Add user preferences dialog  https://review.opendev.org/73948223:11
openstackgerritJames E. Blair proposed zuul/zuul master: Use redux for handling autoReload preference  https://review.opendev.org/74343423:11
clarkbrunning nodepool unittests locally haslocked up my laptop23:13
openstackgerritClark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver  https://review.opendev.org/74342423:17
clarkbapologies for the spam but I've tried to run it locally and my laptop was not having it23:19
clarkbI should probably look at some newer hardware23:19
*** tosky has quit IRC23:25
*** jamesmcarthur has quit IRC23:28
*** jamesmcarthur has joined #zuul23:29
corvuszbr: take a look at https://review.opendev.org/743434  i left a lot of comments about redux there.  let me know if you have questions.23:29
corvusfelixedel, tristanC, avass: ^ fyi you may be interested23:29
*** holser has quit IRC23:30
*** jamesmcarthur has quit IRC23:33
*** holser has joined #zuul23:34
openstackgerritClark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver  https://review.opendev.org/74342423:34
openstackgerritClark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver  https://review.opendev.org/74342423:47

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!