| *** rlandy|biab is now known as rlandy | 00:26 | |
| *** rfolco has quit IRC | 00:29 | |
| *** wuchunyang has joined #zuul | 00:32 | |
| *** wuchunyang has quit IRC | 00:36 | |
| *** rlandy has quit IRC | 00:56 | |
| *** wuchunyang has joined #zuul | 01:23 | |
| *** hamalq has quit IRC | 01:26 | |
| *** wuchunyang has quit IRC | 02:03 | |
| *** Goneri has quit IRC | 03:10 | |
| *** hamalq has joined #zuul | 03:12 | |
| *** hamalq_ has joined #zuul | 03:13 | |
| *** hamalq has quit IRC | 03:17 | |
| *** hamalq_ has quit IRC | 03:37 | |
| *** bhavikdbavishi has joined #zuul | 03:40 | |
| *** bhavikdbavishi1 has joined #zuul | 03:44 | |
| *** bhavikdbavishi has quit IRC | 03:45 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:45 | |
| *** bhagyashris|away is now known as bhagyashris | 03:52 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** vishalmanchanda has joined #zuul | 04:41 | |
| *** y2kenny has quit IRC | 04:44 | |
| *** wuchunyang has joined #zuul | 04:45 | |
| *** wuchunyang has quit IRC | 04:55 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: Move mark comparision into ZuulMark object https://review.opendev.org/744088 | 05:04 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed zuul/zuul master: ParsedConfig.extend : raise TypeError https://review.opendev.org/744089 | 05:04 |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: ConfigItem*Exception : add failure context https://review.opendev.org/744090 | 05:04 |
| *** sanjayu__ has joined #zuul | 05:55 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: web: Fix error drawer contents https://review.opendev.org/744095 | 06:13 |
| *** wuchunyang has joined #zuul | 06:36 | |
| openstackgerrit | Simon Westphahl proposed zuul/nodepool master: Ignore unparsable/empty image upload ZNode data https://review.opendev.org/738013 | 06:39 |
| swest | clarkb: thanks! I also found another case that needed a check of the return value: https://review.opendev.org/#/c/738013/ | 06:45 |
| *** wuchunyang has quit IRC | 06:45 | |
| *** bhavikdbavishi has quit IRC | 06:52 | |
| *** avass has quit IRC | 06:56 | |
| *** wxy has joined #zuul | 07:03 | |
| *** jcapitao has joined #zuul | 07:11 | |
| *** tosky has joined #zuul | 07:19 | |
| *** sgw1 has quit IRC | 07:24 | |
| *** bhavikdbavishi has joined #zuul | 07:47 | |
| *** jpena|off is now known as jpena | 07:56 | |
| openstackgerrit | Merged zuul/nodepool master: Add basic max-servers handling to the k8s driver https://review.opendev.org/743424 | 07:57 |
| *** ianw has quit IRC | 08:01 | |
| *** ianw has joined #zuul | 08:02 | |
| *** nils has joined #zuul | 08:05 | |
| *** wuchunyang has joined #zuul | 08:12 | |
| zbr | ianw: clarkb corvus: can you please give the green to https://review.opendev.org/#/c/739482/ ? | 08:34 |
| *** wuchunyang has quit IRC | 08:54 | |
| *** harrymichal has joined #zuul | 09:01 | |
| openstackgerrit | Tobias Henkel proposed zuul/nodepool master: Delete init nodes when resetting lost requests https://review.opendev.org/744107 | 09:06 |
| *** yolanda has quit IRC | 09:06 | |
| *** yolanda has joined #zuul | 09:16 | |
| *** bhavikdbavishi has quit IRC | 09:34 | |
| *** bhavikdbavishi has joined #zuul | 09:40 | |
| mhu | just letting you know that I'm hating every second of rebasing my UI patches on the big PF4 overhaul :p | 09:51 |
| tobiash | mhu: I'm sorry, but I'm sure it's worth it ;) | 09:54 |
| mhu | tobiash, no worries, it was expected anyway | 09:54 |
| mhu | and it's for the greater good! | 09:56 |
| *** wuchunyang has joined #zuul | 10:03 | |
| zbr | mhu: you are not alone experiencing that rebasefobia.... | 10:08 |
| mhu | what are <> and </> for ? is it now possible to have components as attributes for components? | 10:16 |
| felixedel | mhu: <> is a shorthand for <React.Fragment> | 10:17 |
| felixedel | That's a node that won't be reflected in the DOM. Sometimes it's necessary to wrap an DOM snippet in those as e.g. the return value of render() only allows a single node to be returned | 10:18 |
| felixedel | One could also use a <div> instead, but this will then be put into the resulting DOM | 10:18 |
| mhu | gotcha | 10:19 |
| mhu | I'm asking about that because the localization lib has two functions, the one you use depends whether the translatable string is used as text between anchors or as a component attribute | 10:20 |
| felixedel | Sorry that you have to go through all the rebasing. To be honest I wasn't aware that there are so many UI changes ongoing | 10:20 |
| mhu | I predict it'll be confusing | 10:20 |
| *** harrymichal has quit IRC | 10:20 | |
| mhu | felixedel, no worries, it happens! | 10:21 |
| mhu | if the i18n change had passed you'd be the one lamenting right now, so ... :) | 10:21 |
| felixedel | Right :D | 10:21 |
| mhu | and again, it's for the greater good - PF3 is hardly documented anymore, it was head-scratching to get into it | 10:22 |
| *** wuchunyang has quit IRC | 10:36 | |
| *** bhavikdbavishi has quit IRC | 10:44 | |
| *** jpena is now known as jpena|afk | 10:56 | |
| *** zbr is now known as zbr|pto | 10:56 | |
| *** bhavikdbavishi has joined #zuul | 11:10 | |
| *** jcapitao is now known as jcapitao_lunch | 11:16 | |
| *** wuchunyang has joined #zuul | 11:20 | |
| *** jpena|afk is now known as jpena | 11:20 | |
| *** bhavikdbavishi1 has joined #zuul | 11:35 | |
| *** bhavikdbavishi has quit IRC | 11:35 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 11:35 | |
| *** jpena is now known as jpena|lunch | 11:48 | |
| *** wuchunyang has quit IRC | 11:55 | |
| *** rlandy has joined #zuul | 11:58 | |
| *** avass has joined #zuul | 11:59 | |
| *** jcapitao_lunch is now known as jcapitao | 12:05 | |
| *** bhavikdbavishi has quit IRC | 12:19 | |
| *** rfolco has joined #zuul | 12:24 | |
| *** benoit_lbc has joined #zuul | 12:26 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: Move mark comparision into ZuulMark object https://review.opendev.org/744088 | 12:43 |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: ParsedConfig.extend : raise TypeError https://review.opendev.org/744089 | 12:43 |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: ConfigItem*Exception : add failure context https://review.opendev.org/744090 | 12:43 |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: web: Fix error drawer contents https://review.opendev.org/744095 | 12:43 |
| benoit_lbc | Hello, I'm working at Leboncoin in France and we switched to AWS recently and using the Nodepool AWS driver. We met some limitation due to a high rate of AWS EC2 API querying. We made some modifications to the provider but we cannot pass the tests. It looks lite moto is not changing instances status https://review.opendev.org/#/c/740328 | 12:48 |
| benoit_lbc | Has anyone already worked on this provider ? | 12:48 |
| tobiash | I've hit moto limitations in the past as well (network related) | 12:50 |
| tobiash | is it really the instance status or is multi-describe not working in moto? | 12:51 |
| tobiash | if it's a limitation in moto you might be able to intercept multi-describe and mock it using a series of describesin the test framework | 12:52 |
| tobiash | however that comes with the price of less test coverage and demands at least manual testing that the mock behaves the same as aws does | 12:53 |
| benoit_lbc | I have a thread aggregating instances statutes then querying all at once. During the tests, the statutes never change to "running" | 12:54 |
| benoit_lbc | manual testing is successful :) | 12:56 |
| benoit_lbc | I'll check if the multi describe is supported or not | 12:56 |
| benoit_lbc | ok you're right, it was as simple as that, the 'describe_instances' method is not implemented yet... | 12:58 |
| benoit_lbc | https://github.com/spulec/moto/blob/master/IMPLEMENTATION_COVERAGE.md | 12:59 |
| *** jpena|lunch is now known as jpena | 12:59 | |
| benoit_lbc | thanks for your help | 12:59 |
| *** wuchunyang has joined #zuul | 13:11 | |
| tobiash | :) | 13:21 |
| tobiash | ok, so you need to intercept and emulate this in the test framework | 13:22 |
| benoit_lbc | you mean something like this ? https://review.opendev.org/#/c/632715/5/nodepool/tests/unit/test_driver_aws.py | 13:30 |
| *** sanjayu__ has quit IRC | 13:36 | |
| *** wuchunyang has quit IRC | 14:09 | |
| *** Goneri has joined #zuul | 14:11 | |
| tobiash | yes, now I remember I did this already in the past :) | 14:12 |
| tobiash | but you'll need to do this on a more central place probably | 14:13 |
| benoit_lbc | thx :) | 14:22 |
| *** rlandy is now known as rlandy|brb | 15:00 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove unneeded api requests when commenting in github https://review.opendev.org/744194 | 15:05 |
| tobiash | I think we need to do another round of github api call optimizations. I randomly picked one event and it issued 12 calls where 5 of them look unnecessary | 15:07 |
| *** chkumar|rover is now known as raukadah | 15:12 | |
| *** jcapitao has quit IRC | 15:27 | |
| *** rlandy|brb is now known as rlandy | 15:30 | |
| *** hamalq has joined #zuul | 15:56 | |
| *** irclogbot_3 has quit IRC | 15:56 | |
| *** hamalq_ has joined #zuul | 15:57 | |
| *** irclogbot_0 has joined #zuul | 15:58 | |
| *** hamalq has quit IRC | 16:01 | |
| *** sgw1 has joined #zuul | 16:11 | |
| *** irclogbot_0 has quit IRC | 16:15 | |
| *** irclogbot_1 has joined #zuul | 16:17 | |
| *** bhavikdbavishi has joined #zuul | 16:19 | |
| *** bhavikdbavishi has quit IRC | 16:21 | |
| *** bhavikdbavishi has joined #zuul | 16:21 | |
| *** nils has quit IRC | 16:55 | |
| *** jpena is now known as jpena|off | 17:01 | |
| *** benoit_lbc has quit IRC | 17:53 | |
| *** bhavikdbavishi has quit IRC | 18:04 | |
| *** vishalmanchanda has quit IRC | 18:50 | |
| *** EmilienM is now known as EmilienM|PTO | 20:07 | |
| *** nhicher has quit IRC | 20:11 | |
| *** smcginnis has quit IRC | 20:12 | |
| *** smcginnis has joined #zuul | 20:13 | |
| corvus | tobiash: left comments on https://review.opendev.org/691253 | 20:30 |
| corvus | clarkb, mordred: is this the state of the art for npm mirrors? https://review.opendev.org/743623 | 20:31 |
| mordred | corvus: I *think* so? | 20:32 |
| clarkb | corvus: the url is correct (its a caching proxy). I'm not sure if there is a better way to consume it in .zuul.yaml | 20:32 |
| corvus | mostly i was wondering if there's anything better than sed in pip.sh | 20:32 |
| mordred | yeah - I'm pretty sure the consume side is correct- although it might not be a terrible set of functionality to add to the javascript jobs | 20:32 |
| corvus | (in .zuul.yaml, we may want to think about setting those as project vars) | 20:32 |
| mordred | but then I think we didn't do that because we wanted to do it with the new and improved mirroring vars | 20:33 |
| corvus | oh yeah, those :/ | 20:33 |
| mordred | because "replace urls in yarn.lock" is a thing that should be reasonable to do | 20:33 |
| mordred | but ... rabbit h9ole | 20:33 |
| corvus | so maybe we land this and update to the other thing when someone gets around to implementing it | 20:33 |
| tobiash | corvus: awesome, thanks! I'll finish this next week then :) | 20:34 |
| mordred | corvus: ++ | 20:35 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 20:37 |
| corvus | tobiash: i'm seeing a bunch of review comments about not using mutable defaults; our previous discussions on the topic have resulted in the following understanding: | 20:53 |
| corvus | 1) yes, they can be traps and should generally be avoided | 20:53 |
| corvus | 2) there are places where they are used in zuul with complete understanding of their lifecycle and they don't need to be changed | 20:53 |
| corvus | unfortunately, indescriminate application of the "rule" not to use them is resulting in some pretty verbose boilerplate code | 20:55 |
| corvus | we use them more often in test code than production code, and honestly, it seems quite safe there and much less likely to be a trap. | 20:55 |
| fungi | they can save a lot of complexity, when applied correctly (and carefully) | 20:56 |
| clarkb | test cases also tend to not be reentrant | 20:56 |
| clarkb | which is where you end up with problems | 20:56 |
| tobiash | oh, I forgot about 2) | 20:57 |
| clarkb | call a function once and its fine | 20:57 |
| corvus | also, at the very least, if we're going to ask someone to avoid a mutable default, we sholud at least settle on a recommendation to avoid verbosity; i like "foo == foo or []" | 20:58 |
| corvus | (the two recent examples i've seed ended up with the 2 line "if foo is None:\n foo = []" or the wall of text version: "foo = foo if foo is None else []" or something like that; i can't exactly remember | 20:59 |
| * mordred likes foo = foo or [] | 21:00 | |
| mordred | for the times when that pattern is appropriate | 21:00 |
| tobiash | \me likes foo = foo or [] as well | 21:01 |
| *** rfolco has quit IRC | 21:01 | |
| corvus | yeah. and just to be clear, i'm basically never going to say "please use a mutable default in the main code base". after today, i probably won't even object to folks wanting to avoid them in the test cases. but asking new contributors to rework their patches to also remove mutable defaults from previously written test cases when i would happily +2 a change that added a mutable default to the same test | 21:02 |
| corvus | case seems like something to avoid. :) | 21:02 |
| mordred | corvus: woot! I have tested the netlify code and it is now good | 21:08 |
| mordred | corvus: I copied the role and job description directly in to the inaugust repo and is correctly did its job | 21:09 |
| corvus | swest: see comments on https://review.opendev.org/739042 | 21:11 |
| mordred | corvus: https://review.opendev.org/#/c/739047/ - you can see the job output of its successful run here: https://zuul.opendev.org/t/opendev/build/c7fe4e0221ac454db142f929a9edb4a6 | 21:13 |
| corvus | mordred: do you need zuul-preview for it to work right? (styling seems off) | 21:14 |
| mordred | and I copied the role from the zuul-jobs change in to inaugust for that here: https://review.opendev.org/#/c/740591/ | 21:14 |
| mordred | corvus: for the site-preview? yeah - I should really have the site preview use zuul-preview for that | 21:15 |
| mordred | but that's not really a netlify thing - that's more the inaugust content requires being rooted | 21:16 |
| corvus | mordred: may want to look into passing a "zuul_preview_url" or something into the netlify role, so you can use it in inaugust without having to make an opendev job | 21:16 |
| corvus | mordred: (iow, have netlify role have the option of returning a zuul-preview artifact based on that variable) | 21:16 |
| mordred | yeah | 21:16 |
| mordred | or - honestly we should have the netlify role parse the netlify-cli output and return the netlify url as the site-preview url | 21:17 |
| mordred | corvus: https://zuul.opendev.org/t/opendev/build/c7fe4e0221ac454db142f929a9edb4a6/log/job-output.txt#549 | 21:17 |
| corvus | mordred: oh, this is for publishing... i think maybe none of what i said matters? | 21:18 |
| corvus | mordred: because when this role is done, the site is live in prod, right? | 21:18 |
| mordred | yeah, that's right | 21:18 |
| corvus | okay, strike everything i said after 21:14 :) | 21:19 |
| mordred | :) | 21:19 |
| corvus | mordred: i left a couple of +0 comments | 21:21 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 21:26 |
| mordred | corvus: responded and addressed | 21:26 |
| corvus | mordred: +2 | 21:27 |
| mordred | \o/ | 21:27 |
| mordred | tobiash, avass: if either of you get bored, that's ready ^^ ;) | 21:27 |
| tobiash | mordred: it's late, but two nits and a question | 21:35 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 21:37 |
| mordred | tobiash: thanks! fixed the nits and responded | 21:37 |
| mordred | corvus: ^^ mind re-+2ing? | 21:37 |
| mordred | tobiash: I'd totally put a comment in the file explaining - but json and comments == sad | 21:37 |
| mordred | woot! | 21:38 |
| openstackgerrit | Merged zuul/zuul master: Move mark comparision into ZuulMark object https://review.opendev.org/744088 | 21:39 |
| openstackgerrit | Merged zuul/zuul master: ParsedConfig.extend : raise TypeError https://review.opendev.org/744089 | 21:39 |
| openstackgerrit | Merged zuul/zuul master: Use npm mirrors in tox jobs https://review.opendev.org/743623 | 21:46 |
| openstackgerrit | Guillaume Chauvel proposed zuul/nodepool master: Initial change to rename zuul-quick-start to zuul-tutorial-quick-start https://review.opendev.org/728262 | 21:53 |
| *** hamalq_ has quit IRC | 22:01 | |
| *** tosky has quit IRC | 22:10 | |
| openstackgerrit | Merged zuul/zuul master: scheduler: Fix event process abide hasUnparsedBranchCache argument https://review.opendev.org/739042 | 22:15 |
| openstackgerrit | Merged zuul/zuul master: Fix github branch protection while already unprotected https://review.opendev.org/740340 | 22:17 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 22:44 |
| openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Pass node_version through to included roles https://review.opendev.org/744266 | 22:44 |
| mordred | corvus: sigh. I think 744266 is the right thing to do | 22:45 |
| *** _erlon_ has quit IRC | 22:49 | |
| *** rlandy has quit IRC | 23:02 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!