*** tosky has quit IRC | 00:00 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: model.py : remove self.attributes.inheritable_attributes https://review.opendev.org/747600 | 01:38 |
---|---|---|
openstackgerrit | Ian Wienand proposed zuul/zuul master: model.py : remove unused inheritable_attributes dictionary https://review.opendev.org/747600 | 01:40 |
*** bhavikdbavishi has joined #zuul | 03:45 | |
*** bhavikdbavishi1 has joined #zuul | 03:50 | |
*** bhavikdbavishi has quit IRC | 03:51 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:51 | |
*** bhavikdbavishi has quit IRC | 04:00 | |
*** bhavikdbavishi has joined #zuul | 04:12 | |
*** vishalmanchanda has joined #zuul | 04:33 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: [wip] always file matcher https://review.opendev.org/747614 | 04:40 |
*** evrardjp has quit IRC | 04:46 | |
*** evrardjp has joined #zuul | 04:48 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: [wip] always file matcher https://review.opendev.org/747614 | 05:08 |
*** mach1na has joined #zuul | 05:18 | |
*** mach1na has quit IRC | 05:28 | |
*** raukadah is now known as chandankumar | 05:45 | |
*** mach1na has joined #zuul | 06:05 | |
*** yoctozepto has quit IRC | 06:10 | |
*** yoctozepto has joined #zuul | 06:13 | |
*** mach1na has quit IRC | 06:13 | |
*** mach1na has joined #zuul | 06:14 | |
*** mnasiadka has quit IRC | 06:16 | |
*** mnasiadka has joined #zuul | 06:19 | |
*** bhavikdbavishi has quit IRC | 06:28 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: [wip] always file matcher https://review.opendev.org/747614 | 06:32 |
*** AJaeger has quit IRC | 06:36 | |
*** jhesketh_ has quit IRC | 06:39 | |
*** jhesketh has joined #zuul | 06:41 | |
*** AJaeger has joined #zuul | 06:45 | |
zbr | felixedel: explained on https://review.opendev.org/#/c/747377/2 | 06:55 |
*** bhavikdbavishi has joined #zuul | 06:58 | |
felixedel | zbr: Ok, to me that documentation didn't make it very clear if they mean enforce the indentation (true/false) or if they mean enforce the indentation level (1, 2, 3). | 07:01 |
*** sshnaidm|afk is now known as sshnaidm | 07:03 | |
*** AJaeger has quit IRC | 07:17 | |
*** hashar has joined #zuul | 07:20 | |
*** tosky has joined #zuul | 07:20 | |
zbr | felixedel: true, but testing and seeing what others are using proved that 1 is what we needed. | 07:31 |
zbr | ianw: maybe you can help us close ^ | 07:34 |
felixedel | zbr: Maybe add a short comment to clarify what the switchCase 1 means? Just noted that - following the documentation - it's also not a bool value, but a factor (1 means 1x2=2 spaces indentation). 2 would mean 2x2=4 spaces indentation. | 07:39 |
zbr | i do not think is needed, if anyone would try to touch the value, they will see the results. still, if this is preventing this change from merging I will add it. | 07:41 |
zbr | that almost reminds me that at some point someone asked me to document how yaml anchors were working | 07:41 |
*** bolg has joined #zuul | 07:44 | |
felixedel | I just tink as it wasn't clear to me and also your answer wasn't the correct one, we should write it down as somebody else might have the same problem. | 08:02 |
felixedel | Also a comment shouldn't harm here ;-) | 08:03 |
*** yolanda has quit IRC | 08:03 | |
*** avass has joined #zuul | 08:09 | |
*** bhavikdbavishi has quit IRC | 08:14 | |
*** bhavikdbavishi has joined #zuul | 08:15 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: DNM: Add unified synchronize-repos role that works with linux and windows https://review.opendev.org/740005 | 08:25 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Update synchronize-repos https://review.opendev.org/740110 | 08:25 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: synchronize-repos: Remove unecessary git path modifications https://review.opendev.org/747640 | 08:25 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Consolidate js/jsx indentation https://review.opendev.org/747377 | 08:31 |
*** nils has joined #zuul | 08:35 | |
*** bhavikdbavishi has quit IRC | 08:53 | |
*** bhavikdbavishi has joined #zuul | 08:53 | |
openstackgerrit | Felix Edel proposed zuul/zuul master: Merge file comments from multiple tasks https://review.opendev.org/747661 | 09:12 |
*** hashar has quit IRC | 09:12 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Enable linting of test-playbooks https://review.opendev.org/731471 | 09:25 |
*** AJaeger has joined #zuul | 09:32 | |
felixedel | zuul-maint: I have a bunch of small UI changes waiting for review https://review.opendev.org/#/c/747363/ , https://review.opendev.org/#/c/747152/ and https://review.opendev.org/#/c/739973/. Additionally the changes for the new filtertoolbar https://review.opendev.org/#/c/741385/ and the new layout for the builds/ and buildsets/ pages https://review.opendev.org/#/c/746112/5 are also ready for review | 09:35 |
*** bhavikdbavishi has quit IRC | 10:31 | |
*** shanemcd has quit IRC | 10:52 | |
*** shanemcd has joined #zuul | 10:53 | |
*** bhavikdbavishi has joined #zuul | 11:03 | |
zbr | felixedel: done. | 11:07 |
zbr | most ok, only issue with extra icons on columns | 11:07 |
*** mach1na has quit IRC | 11:24 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Add releasenote about PF4 migration https://review.opendev.org/745085 | 11:25 |
swest | zuul-maint: would be nice to get +w on https://review.opendev.org/#/c/747160/ | 11:26 |
*** mach1na has joined #zuul | 11:55 | |
*** rlandy has joined #zuul | 12:00 | |
*** mach1na has quit IRC | 12:07 | |
*** mach1na has joined #zuul | 12:08 | |
*** mach1na has quit IRC | 12:18 | |
*** mach1na has joined #zuul | 12:20 | |
felixedel | ianw: Regarding https://review.opendev.org/#/c/741385/. What exactly "takes quites a while to load"? In case you mean the table when the filters are changed, this change doesn't touch the table, so the behaviour is the same like before. But I've addressed that in the follow-up change https://review.opendev.org/#/c/746112/5 which also shows a spinner while the data is (re)loading | 12:25 |
*** rfolco has joined #zuul | 12:31 | |
openstackgerrit | Felix Edel proposed zuul/zuul master: Merge file comments from multiple tasks https://review.opendev.org/747661 | 12:33 |
*** bhavikdbavishi has quit IRC | 12:44 | |
*** hashar has joined #zuul | 12:49 | |
*** nhicher has joined #zuul | 12:52 | |
openstackgerrit | Felix Edel proposed zuul/zuul master: PF4: Update builds and buildsets tables + use newest patternfly release https://review.opendev.org/746112 | 13:06 |
openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Highlight pipeline names on status page https://review.opendev.org/747152 | 13:09 |
*** Goneri has joined #zuul | 13:25 | |
zbr | tobiash: mordred tristanC: https://review.opendev.org/#/c/747377/ please (formatting) | 13:32 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Consolidate js/jsx indentation https://review.opendev.org/747377 | 14:18 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 14:19 |
*** chandankumar is now known as raukadah | 14:52 | |
*** cloudnull7 has joined #zuul | 15:02 | |
*** tdasilva has quit IRC | 15:03 | |
*** evgenyl has quit IRC | 15:03 | |
*** cloudnull has quit IRC | 15:03 | |
*** cloudnull7 is now known as cloudnull | 15:03 | |
*** tdasilva has joined #zuul | 15:03 | |
*** webknjaz has quit IRC | 15:03 | |
*** evgenyl has joined #zuul | 15:04 | |
*** zbr has quit IRC | 15:04 | |
*** zbr has joined #zuul | 15:05 | |
*** webknjaz has joined #zuul | 15:06 | |
*** nils has quit IRC | 15:07 | |
*** nils has joined #zuul | 15:18 | |
*** vishalmanchanda has quit IRC | 15:22 | |
*** masterpe has quit IRC | 15:22 | |
*** donnyd has quit IRC | 15:22 | |
*** gundalow has quit IRC | 15:22 | |
*** kklimonda has quit IRC | 15:22 | |
*** mwhahaha has quit IRC | 15:22 | |
*** mnaser has quit IRC | 15:22 | |
*** guilhermesp has quit IRC | 15:22 | |
*** iamweswilson has quit IRC | 15:26 | |
*** iamweswilson has joined #zuul | 15:26 | |
*** masterpe has joined #zuul | 15:30 | |
*** mwhahaha has joined #zuul | 15:31 | |
*** weshay|ruck has quit IRC | 15:31 | |
*** weshay has joined #zuul | 15:32 | |
*** vishalmanchanda has joined #zuul | 15:33 | |
*** donnyd has joined #zuul | 15:33 | |
*** gundalow has joined #zuul | 15:33 | |
*** kklimonda has joined #zuul | 15:34 | |
*** mnaser has joined #zuul | 15:34 | |
*** guilhermesp has joined #zuul | 15:34 | |
*** mach1na has quit IRC | 15:37 | |
*** bhavikdbavishi has joined #zuul | 15:47 | |
*** weshay has quit IRC | 16:05 | |
*** weshay has joined #zuul | 16:05 | |
*** iurygregory has quit IRC | 16:18 | |
*** iurygregory has joined #zuul | 16:27 | |
*** hashar has quit IRC | 16:48 | |
*** tosky has quit IRC | 16:49 | |
*** nils has quit IRC | 16:56 | |
*** Pilou has quit IRC | 17:28 | |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: Add missing virtualenv and fixed repo install https://review.opendev.org/693637 | 17:29 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: Fixed runtime warnings https://review.opendev.org/747781 | 17:33 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: install packages one by one https://review.opendev.org/693637 | 17:37 |
clarkb | zbr: any idea how much slower ^ is? | 17:38 |
clarkb | I wonder if we can make that a role parameter (then set it as a project level var) | 17:38 |
zbr | clarkb: i did not make any tests but I doubt is a real issue. i don't really enjoy making it an opt-in as bindep user may have zero zuul knowledge. | 17:39 |
zbr | i am more inclined to do another approach: try all at once and fallback to serial if failing. | 17:40 |
zbr | it would make it slower only in case of failure | 17:40 |
zbr | any other ideas? | 17:41 |
clarkb | could possibly have bindep output if serial is necessary | 17:42 |
zbr | what i really love about bindep.txt is its simplicity, I seen it used (updated) by people which never used bindep tool. | 17:42 |
zbr | i think bindep itself has no clue if something may need serial or not, nor it has any ways to add generic config items. | 17:43 |
zbr | it is very simplistic: list of package names with filters after | 17:43 |
clarkb | you could specify it in the config potentially | 17:44 |
clarkb | [this is a repo package] type thing | 17:44 |
clarkb | I'm mostly just brain storming not sureit us a good idea | 17:44 |
clarkb | but I expect serial installs to significantly slow down bindep | 17:45 |
clarkb | (it is a long issue with puppet working aroound a yum behavior and makes it slow) | 17:45 |
zbr | as I said, alternative is to try current task (all), check result and try serial after instead of failing right away. | 17:46 |
zbr | more like using serial only as a fallback for bulk install failure | 17:46 |
clarkb | ya that would also likely work | 17:52 |
zbr | clarkb: sure I will update it to do that. | 17:57 |
zbr | corvus: did we wait enough with https://review.opendev.org/#/c/739482/ ? | 17:58 |
*** Pilou has joined #zuul | 18:01 | |
corvus | zbr: yeah, looks like good consensus on that +3 | 18:02 |
* zbr pinching myself to check if I a dreaming or not | 18:03 | |
zbr | do we happen to have (or plan) a test zuul instance that always runs master? as in real CD | 18:05 |
zbr | it could prove very useful for testing unreleased version, especially around UI changes | 18:06 |
zbr | there another UI change I want to make to shorten durations and remove secons and write them compressed: "16 mins 47 secs" -> "17m" | 18:09 |
zbr | there is not much value in measuring seconds for duration | 18:10 |
zbr | we could display full value as tooltip... | 18:10 |
clarkb | ui changes are built then can be run against both opendev and software factory's zuul | 18:10 |
clarkb | thats all done by the jobs for you | 18:10 |
clarkb | abd for a master deployment the quickstart is good for that | 18:10 |
corvus | zbr: before you write that, go look at the review history for the change that last modified the time fields | 18:11 |
corvus | i don't want to have to go through that conversation again from scratch | 18:11 |
zbr | i found some reviews around that but not about listing in builds/buildsets page | 18:17 |
zbr | https://sbarnea.com/ss/Screen-Shot-2020-08-24-19-19-33.13.png | 18:19 |
zbr | as seen the duration and start time are always wrapped. likely compressing duration alone is enough to make most rows not wrap. | 18:20 |
openstackgerrit | Merged zuul/zuul master: Prevent Git GC issue between merger and executor https://review.opendev.org/747160 | 18:21 |
zbr | one dowside of the new ui is that I lock the ability to select text inside the rows | 18:22 |
openstackgerrit | Merged zuul/zuul master: UI: Show Ref on build(set) result page if no branch is set https://review.opendev.org/747363 | 18:30 |
openstackgerrit | Merged zuul/zuul-jobs master: ara-report: add option for artifact prefix https://review.opendev.org/747100 | 19:05 |
openstackgerrit | Merged zuul/zuul-jobs master: tox: include command output in log/error https://review.opendev.org/747325 | 19:05 |
openstackgerrit | Merged zuul/zuul master: Add user preferences dialog https://review.opendev.org/739482 | 19:07 |
*** bhavikdbavishi has quit IRC | 19:23 | |
fungi | i'm on vacation and totally not here, but whether packages need to be installed serially is an instruction to whatever's running the package manager. bindep doesn't install things, so whether or not installation should be serialized is not information it would ever act on, and so i question whether it would make sense in the file used to instruct bindep | 19:30 |
fungi | bindep really does one (and only one) thing, that's tell you whether the packages you have installed match the list it was given (and then all the fanciness is in how it filters that list based on your platform and any command parameters) | 19:31 |
clarkb | thats a fair point | 19:31 |
fungi | i wasn't following closely, but i guess this is related to multi-stage installation? | 19:32 |
clarkb | fungi: ya so that you can install a package that enables a repo then install packages from that repo | 19:34 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Enable optional pre-wrapping on console and output https://review.opendev.org/723603 | 19:34 |
clarkb | corvus: tobiash (is jan on irc too?) is there a good place to help dig into the zk work in zuul? | 19:34 |
clarkb | I'm looking at hte change list and there are a number of them I'm not quite sure yet where would be the best plcae to help | 19:35 |
fungi | maybe the role could just retry several times? | 19:35 |
fungi | that would get you up to three stages | 19:35 |
fungi | assuming the package manager doesn't just refuse to install anything if you include an unrecognized package name | 19:36 |
corvus | clarkb: bolg is jan | 19:36 |
fungi | also this would be an rpmism, debian derivatives would need an apt update in between installing a package which added a new package repository and then installing packages from that new repository | 19:37 |
fungi | so even serializing wouldn't help you there | 19:37 |
tobiash | clarkb, corvus: fyi, I'm out of office this week | 19:37 |
fungi | unless you updated indices after each package installed | 19:37 |
fungi | tobiash: hah, me too | 19:38 |
fungi | neither of us is doing a very good job at that, apparently | 19:38 |
clarkb | tobiash: no worries, enjoy your time off | 19:39 |
tobiash | thanks | 19:39 |
clarkb | fungi: ya you should go back to drinking rum on the deck or whatever it is you are doing:) | 19:39 |
fungi | i was painting, doing some radio repair, mowing the lawn and making releases of some personal software projects | 19:40 |
fungi | unfortunately not all at the same moment though, that would have been impressibe | 19:40 |
fungi | impressive | 19:40 |
clarkb | bolg: hey, if you're still around I'd be happy to help with some reivews on the zk work in zuul. Just point me at where I can be most useful | 19:40 |
clarkb | https://review.opendev.org/#/c/709735/27 seems to be the bottom of a related stack so I'll start there for now | 19:41 |
tobiash | clarkb: yes, that makes sense. Those changes at the bottom mostly prepare some stuff to aid further implementation | 19:44 |
corvus | might also be worth seeking out the required db changes | 19:44 |
openstackgerrit | Merged zuul/zuul master: UI: Highlight pipeline names on status page https://review.opendev.org/747152 | 20:20 |
ianw | felixedel: thanks, yeah the filter taking a while to load isn't new. a spinner will be welcome and i'll take a look | 22:31 |
erbarr | hello, any zuul install experts that can help me? | 22:34 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Add ensure-rust role https://review.opendev.org/746423 | 23:05 |
clarkb | erbarr: I'm mostly around and happy to help if I can | 23:06 |
ianw | erbarr: best to just ask ... you are in the right place though :) | 23:07 |
erbarr | clarkb, thanks man, I've followed the zuul from scratch and I'm getting to a point where I have nodepool configured to use dib, it creates and uploads a ubuntu bionic image to my devstack cloud successfully, i can then go and use that image to launch instances, but then nodepool launcher is pretty much instantly deleting the instance it makes and then says that is ready | 23:08 |
clarkb | erbarr: it thinks the node is ready even though it has deleted it? | 23:09 |
clarkb | generally with node deletions after boot the problem is with ssh | 23:09 |
clarkb | I would double check that firwalls and security groups allow ssh in, and that cloud-init/glean/something is configuring networking on the host as well as ssh keys (if you don't bake them into the image) | 23:10 |
erbarr | ahh, that sounds familiar, i did the no host checking option since i was getting unable to connect to port 22 thing | 23:10 |
clarkb | manually booting the image is usually the easiest way to check that | 23:10 |
erbarr | and after that it still deletes but says is ready | 23:10 |
erbarr | but that seemed to fail very quickly though, like the instance was barely starting to boot and it would delete it | 23:12 |
clarkb | nodepool should log when it is deleting the instance too iirc | 23:13 |
clarkb | I'm looking to see how that is logged now | 23:13 |
erbarr | i'm not seeing that in /var/log/nodepool/nodepool.log, "node is ready" is the last entry i see there | 23:14 |
clarkb | self.log.info("Deleting %s instance %s from %s", node.state, node.external_id, node.provider) | 23:16 |
clarkb | you should see log lines like that if nodepool is deleting the instance | 23:16 |
clarkb | you are saying the nodepool state is ready though? But it is deleted from the cloud? | 23:16 |
clarkb | Iwonder if it is a cloud side issue we don't account for | 23:16 |
erbarr | yea, and it seems the launcher is deleting it right in the middle of booting before I guess even the ssh server has initialized | 23:17 |
clarkb | are there any exceptions? | 23:17 |
clarkb | oh wait when you say it is ready is that from nodepool list or from openstack listings? | 23:17 |
erbarr | nodepool list | 23:17 |
erbarr | openstack doesn't show, on cli or horizon | 23:18 |
erbarr | i see it pop up briefly then get deleted | 23:18 |
clarkb | got it | 23:18 |
clarkb | can you grep a node id from nodepool.log which should give the full cycle of that node according to nodepool | 23:18 |
clarkb | then share that ( just double check there isn't anything sensitive first like maybe IP addrs) | 23:19 |
clarkb | but the other thing I would try is manually booting and see what happens | 23:19 |
erbarr | ok, let me get that | 23:19 |
*** iurygregory has quit IRC | 23:21 | |
erbarr | https://www.irccloud.com/pastebin/IO6TgYNN/ | 23:22 |
erbarr | that's the last one, not much message, let me remove the no host checking option to get the port 22 errors | 23:23 |
clarkb | I'm trying to think of other ways that servers can be deleted | 23:23 |
clarkb | if the connection to zookeeper is lost then they maybe depending on when the connection is lost | 23:23 |
clarkb | double check that the nodepool and zuul processes and zookeeper processes aren't restarting? | 23:24 |
erbarr | okay, let me see | 23:25 |
erbarr | they seem to not be restarting | 23:30 |
clarkb | and are there any other nodepool processes running that may be conflicting with a different config? | 23:30 |
clarkb | for nodepool launchers you want a single one running per provider | 23:30 |
erbarr | i only have one launcher and one builder running | 23:31 |
clarkb | ya not coming up with any other ideas right now. I would try a manual boot and see if you can replicate as that may help narrow down the problem | 23:32 |
*** vishalmanchanda has quit IRC | 23:32 | |
erbarr | okay, so for manual boot, i have tried to use the image uploaded by the builder manually, i can create an instance with the 3 interfaces, wait for it to boot, ping each one of them and then try to ssh but fail to do so, started with the (publickey) error but then I got it to "connection closed by remote host" | 23:34 |
openstackgerrit | Merged zuul/zuul-jobs master: Add ensure-rust role https://review.opendev.org/746423 | 23:34 |
clarkb | ok I would get ssh working completely as that could be related to the cleanups (if zuul/nodepool think the server isn't accessible they will get cleaned up) | 23:35 |
erbarr | okay, let me try to get that fully working, so, in the zuul from scratch tutorial the private key gets moved to the zuul user .ssh folder, does the nodepool user need a copy of tha key as well? | 23:38 |
clarkb | I think it is just zuul that does sshing in now | 23:42 |
clarkb | nodepool will do a host key scan | 23:42 |
clarkb | but not actually ssh in | 23:42 |
erbarr | okay, that makes sense, so maybe i need to fix my dib elements | 23:43 |
erbarr | i got nothing custom element wise, everything coming from the dib install, on diskimages i have elements in this order, ubuntu, vm, simple-init, openssh-server, growroot | 23:47 |
erbarr | does that seem okay? | 23:47 |
clarkb | erbarr: mostly. What that will do is give you a glean configured server on boot. Glean will configure the root user with any ssh keys set by nodepool | 23:48 |
clarkb | erbarr: zuul will expect to ssh as the zuul user by default | 23:48 |
clarkb | so that may be the mismatch | 23:49 |
clarkb | erbarr: https://opendev.org/openstack/project-config/src/branch/master/nodepool/nl01.openstack.org.yaml#L82 is how you set a key on instances in nodepool. Note that that key must be created in nova independently by something | 23:49 |
clarkb | that would then allow ssh to root not zuul. I think you can change the zuul user elsewhere. However, it would probably be better to configure a zuul user instead using an element like https://opendev.org/openstack/project-config/src/branch/master/nodepool/elements/zuul-worker | 23:50 |
*** rlandy has quit IRC | 23:51 | |
* clarkb thinks out loud here: should we maybe put that lement in the nodepool repo? | 23:53 | |
erbarr | ahh, that's neat, so I guess i can just get a local copy of that zuul-worker element and drop it in my local elements folder that i configured in nodepool.yaml | 23:53 |
erbarr | does order matter? | 23:53 |
clarkb | ya that should work | 23:53 |
clarkb | no order doesn't matter in the elements list | 23:53 |
clarkb | the elements are internally ordered | 23:53 |
erbarr | nice! alright, let me give this a shot, i'll probably bother you again tomorrow lol, i need to update Dell Ironic CI to zuul v3 so I'm kind of just starting from scratch | 23:55 |
erbarr | thanks for the help, i really appreciate it | 23:55 |
clarkb | you're welcome | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!