Thursday, 2020-09-10

ianwcorvus / felixedel : AIUI the plan is to stack a fix for the log scroll on top, and then we're happy enough to move forward?  and think about the other horizontal scroll issues as a short-term todo00:14
*** armstrongs has joined #zuul00:20
*** rlandy has quit IRC00:21
*** armstrongs has quit IRC00:26
openstackgerritMerged zuul/nodepool master: Dockerfile: add xz-utils  https://review.opendev.org/75083900:43
*** zenkuro has quit IRC00:57
*** vishalmanchanda has joined #zuul01:59
*** bhavikdbavishi has joined #zuul02:54
*** bhavikdbavishi1 has joined #zuul03:01
*** bhavikdbavishi has quit IRC03:03
*** bhavikdbavishi1 is now known as bhavikdbavishi03:03
*** bhavikdbavishi has quit IRC03:19
*** bhavikdbavishi has joined #zuul03:38
*** bhavikdbavishi1 has joined #zuul03:45
*** bhavikdbavishi has quit IRC03:46
*** bhavikdbavishi1 is now known as bhavikdbavishi03:46
*** bhavikdbavishi has quit IRC04:18
*** bhavikdbavishi has joined #zuul04:19
*** bhavikdbavishi has quit IRC04:23
*** bhavikdbavishi has joined #zuul04:23
*** bhagyashris|rove is now known as bhagyashri|rover04:32
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** cloudnull has quit IRC05:08
*** reiterative has quit IRC05:40
*** reiterative has joined #zuul05:41
felixedelianw, corvus: Yes, that was my understanding05:53
*** bhavikdbavishi1 has joined #zuul06:01
*** bhavikdbavishi has quit IRC06:03
*** bhavikdbavishi1 is now known as bhavikdbavishi06:03
*** cloudnull has joined #zuul06:05
openstackgerritJan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality  https://review.opendev.org/70973506:14
openstackgerritJan Kubovy proposed zuul/zuul master: Separate connection registries in tests  https://review.opendev.org/71295806:14
openstackgerritJan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler  https://review.opendev.org/71726906:14
openstackgerritJan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests  https://review.opendev.org/72125406:14
openstackgerritJan Kubovy proposed zuul/zuul master: Driver event ingestion  https://review.opendev.org/71729906:14
openstackgerritJan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper  https://review.opendev.org/71622106:14
openstackgerritJan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper  https://review.opendev.org/71687506:14
openstackgerritJan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper  https://review.opendev.org/71626206:14
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441606:14
*** mach1na has joined #zuul06:14
openstackgerritFelix Edel proposed zuul/zuul master: UI: Wrap lines on Logfile page  https://review.opendev.org/75087506:17
felixedelianw, corvus: I've put the fix for the Logfile page on top of the stack https://review.opendev.org/#/c/750875/06:17
*** mach1na has quit IRC06:23
*** mach1na has joined #zuul06:23
*** bhavikdbavishi has quit IRC06:32
*** hashar has joined #zuul06:50
openstackgerritJan Kubovy proposed zuul/zuul-jobs master: WIP: Temporary disable sudo revocation  https://review.opendev.org/75088106:53
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441606:55
*** bhavikdbavishi has joined #zuul07:10
ianwfelixedel: nice, i'll probably have to check it out tomorrow but sounds good!07:11
openstackgerritJan Kubovy proposed zuul/zuul-jobs master: WIP: Temporary disable sudo revocation for tox  https://review.opendev.org/75088107:12
*** mach1na has quit IRC07:15
*** bhavikdbavishi1 has joined #zuul07:22
*** bhavikdbavishi has quit IRC07:23
*** bhavikdbavishi1 is now known as bhavikdbavishi07:23
*** tosky has joined #zuul07:32
*** avass has joined #zuul07:34
*** mach1na has joined #zuul07:35
*** mach1na has quit IRC07:36
*** mach1na has joined #zuul07:36
*** jpena|off is now known as jpena07:40
*** jcapitao has joined #zuul07:42
*** saneax has joined #zuul07:53
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441608:00
bolg_tristanC: Regarding https://review.opendev.org/c/717269 I am open to suggestion how to break up the ZooKeeper class. With the current approach its too verbose, with functions we will the ZK object will not see tose functions as methods, without both there will be little IDE support. What do you think?08:22
openstackgerritMatthieu Huin proposed zuul/zuul-client master: Add promote, release jobs  https://review.opendev.org/75019308:22
mhuhello zuul maintainers, I think the initialization of zuul-client is ready; could you have a look at the changes: https://review.opendev.org/#/c/749775/ and https://review.opendev.org/#/c/750193/08:23
mhuAlso once these are merged could we tag an initial release so that the project is hosted on PyPI? This will allow zuul-client to be used as a requirement in zuul (and avoid some code repetition)08:25
*** jcapitao has quit IRC08:27
*** jcapitao has joined #zuul08:36
*** jcapitao has quit IRC08:41
*** jcapitao has joined #zuul08:42
*** jfoufas1 has joined #zuul08:47
*** bhavikdbavishi has quit IRC08:49
*** bhavikdbavishi has joined #zuul09:01
*** bhavikdbavishi has quit IRC09:03
*** harrymichal has joined #zuul09:18
*** bhavikdbavishi has joined #zuul09:32
*** nils has joined #zuul09:34
*** AshBullock has joined #zuul09:37
AshBullockHey, I'm in the process of adding TLS to zookeeper, I'm trying to get nodepool to connect but getting connection refused, In the folder I ran the zk-ca.sh I see certs labelled by IP: "10.X.X.X.pem" and also "client.pem", which files should I be referencing in the nodepool.yaml?09:44
*** bhavikdbavishi has quit IRC09:49
*** hashar has quit IRC09:58
*** hashar has joined #zuul09:58
openstackgerritJan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler  https://review.opendev.org/71726910:02
bolg_tristanC: another approach without the overhead: https://review.opendev.org/#/c/71726910:04
*** zenkuro has joined #zuul10:10
*** harrymichal has quit IRC10:18
*** harrymichal has joined #zuul10:18
*** bhavikdbavishi has joined #zuul10:25
fricklerdid anyone else notice an issue with the console stream window output for running tasks? there's no scroll bar for the text window, the scroll bar that I have moves the whole window, not the console content. I can scroll with the wheel inside the console window, but I'd like to be able to move to start/end fast10:36
*** CraigR has joined #zuul10:46
*** mach1na has quit IRC10:50
*** bhavikdbavishi has quit IRC10:55
*** bhavikdbavishi has joined #zuul10:56
openstackgerritJan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests  https://review.opendev.org/72125411:01
openstackgerritJan Kubovy proposed zuul/zuul master: Driver event ingestion  https://review.opendev.org/71729911:01
openstackgerritJan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper  https://review.opendev.org/71622111:01
openstackgerritJan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper  https://review.opendev.org/71687511:01
openstackgerritJan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper  https://review.opendev.org/71626211:01
*** sanjayu_ has joined #zuul11:01
*** saneax has quit IRC11:02
*** sanjayu__ has joined #zuul11:04
*** sanjayu_ has quit IRC11:07
*** bhavikdbavishi has quit IRC11:09
*** CraigR has quit IRC11:10
*** AshBullock has quit IRC11:12
*** AshBullock has joined #zuul11:17
*** jcapitao is now known as jcapitao_lunch11:21
*** jpena is now known as jpena|lunch11:31
*** mach1na has joined #zuul11:44
*** AshBullock has quit IRC11:48
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441611:53
*** mach1na has quit IRC11:57
*** mach1na has joined #zuul11:57
*** arxcruz|ruck is now known as arxcruz|pto12:05
*** rlandy has joined #zuul12:06
*** rfolco has joined #zuul12:11
*** jcapitao_lunch is now known as jcapitao12:16
*** rfolco is now known as rfolco|ruck12:18
*** mach1na has quit IRC12:23
*** mach1na has joined #zuul12:26
*** hashar has quit IRC12:31
tristanCbolg_: what is the benefit to mix both nodepool and zuul function inside a single object? Is it just for caller to use zk.getHoldRequest? I find composition easier to read, e.g.: zk.nodepool.getHoldRequest12:33
*** hashar has joined #zuul12:37
*** AshBullock has joined #zuul12:37
*** jpena|lunch is now known as jpena12:39
*** hashar has quit IRC12:40
*** bhavikdbavishi has joined #zuul12:43
*** AshBullock has quit IRC12:53
*** AshBullock has joined #zuul12:54
*** bhavikdbavishi has quit IRC12:56
*** bhavikdbavishi has joined #zuul13:02
bolg_tristanC: I was also thinking about doing it this way, would make even more sence. Currently I just split the one ZooKeeper class into multiple mixins13:14
bolg_The change did not require changes outside the zuul.zk, with the composition also calls needs to be changed then13:15
tristanCbolg_: i developped that idea in a comment on the review, but i am not sure to understand all the implication13:15
*** sanjayu__ has quit IRC13:16
tristanCbolg_: but it seems like a good idea that the client specifics state such as connection event listener should not be shared with the zkzuul or zknodepool class13:17
*** zenkuro has quit IRC13:18
*** bhavikdbavishi has quit IRC13:19
bolg_tristanC: It cleaner what you suggest there. But I am not sure how all the changed calls will be welcomed13:19
fungiAshBullock: here's how we set ours in opendev's nodepool servers: https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/nodepool-base/tasks/main.yaml#L74-L7713:20
tristanCbolg_: in that situation, the main zk class could provide backward compatible passthrough function13:20
AshBullockfungi thanks, actually just figured it out, had the wrong nodepool version13:21
bolg_tristanC: I think this may be confusing for someone who wants to use the API, no? We would comment the passthrough functions as deprecated?13:22
*** Goneri has joined #zuul13:26
bolg_tristanC: Also when I thought about such implementation I was thinking to split not only zuul and nodepool but also, executors, builds, etc. See https://review.opendev.org/c/744416/28/zuul/zk/__init__.py. Imagine properties instead of each mixin there13:26
*** piotrowskim has joined #zuul13:28
tristanCbolg_: passthrough should be temporary, just for the initial review, and it could be removed in a follow while fixing the callsite13:30
tristanCbolg_: it seems like using mixin doesn't actually break-up the "god-like" zookeeper class, it's only splitting it in different file13:33
bolg_tristanC: yes from runtime point of view it has the same result. Its just a logical split13:35
tristanCbolg_: executors and builds could also be composed using regular objects that takes the client as a constructor13:35
*** hashar has joined #zuul13:48
openstackgerritMatthieu Huin proposed zuul/zuul-client master: Add builds subcommand  https://review.opendev.org/75099914:06
felixedelfrickler: The problem you are describing sounds related to the scrolling issues we discussed the last days. It should be fixed by https://review.opendev.org/#/c/750361/2 and the related changes. A temporary solution would be to remove the "overflow-x: visible; overflow-y: visible;" attributes from the "pf-c-page__main" CSS selector directly in the browser for this page.14:16
*** jfoufas1 has quit IRC14:26
fricklerfelixedel: ah, thx for the pointer, I didn't follow scrollback. but now I indeed found the horizontal scrollbar and can uncover the vertical one with it.14:35
*** zenkuro has joined #zuul14:46
openstackgerritJan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler  https://review.opendev.org/71726914:47
*** hashar has quit IRC15:17
*** mach1na has quit IRC15:30
*** AshBullock has quit IRC15:58
*** jcapitao has quit IRC16:16
*** bhavikdbavishi has joined #zuul16:21
*** zenkuro has quit IRC16:31
*** hamalq has joined #zuul16:32
*** bhavikdbavishi1 has joined #zuul16:49
*** jpena is now known as jpena|off16:49
*** bhavikdbavishi has quit IRC16:51
*** bhavikdbavishi1 is now known as bhavikdbavishi16:51
*** bhavikdbavishi has quit IRC16:53
*** bhavikdbavishi1 has joined #zuul16:53
*** bhavikdbavishi1 is now known as bhavikdbavishi16:55
*** bhavikdbavishi has quit IRC17:00
*** mach1na has joined #zuul17:32
*** mach1na has quit IRC17:36
mhuhello zuul maintainers, I think the initialization of zuul-client is ready; could you have a look at the changes: https://review.opendev.org/#/c/749775/ and https://review.opendev.org/#/c/750193/17:58
mhuAlso once these are merged could we tag an initial release so that the project is hosted on PyPI? This will allow zuul-client to be used as a requirement in zuul (and avoid some code repetition)17:58
openstackgerritMatthieu Huin proposed zuul/zuul-client master: Add build-info subcommand  https://review.opendev.org/75107017:59
openstackgerritMatthieu Huin proposed zuul/zuul-client master: Add builds subcommand  https://review.opendev.org/75099918:04
*** gmann is now known as gmann_afk18:11
*** nils has quit IRC18:21
*** wxy has quit IRC18:51
*** zenkuro has joined #zuul18:53
*** rfolco has joined #zuul18:54
*** piotrowskim has quit IRC18:54
*** rfolco|ruck has quit IRC18:56
*** hashar has joined #zuul19:01
*** rfolco is now known as rfolco|ruck19:12
*** hamalq_ has joined #zuul19:23
*** hamalq has quit IRC19:24
*** hashar has quit IRC20:33
*** openstackgerrit has quit IRC20:36
*** rfolco|ruck has quit IRC21:00
*** harrymichal has quit IRC21:37
*** Goneri has quit IRC21:49
*** rlandy has quit IRC22:04
*** vishalmanchanda has quit IRC22:21
*** tosky has quit IRC22:42
*** gmann_afk is now known as gmann22:49
*** sanjayu__ has joined #zuul23:05

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!