ianw | corvus / felixedel : AIUI the plan is to stack a fix for the log scroll on top, and then we're happy enough to move forward? and think about the other horizontal scroll issues as a short-term todo | 00:14 |
---|---|---|
*** armstrongs has joined #zuul | 00:20 | |
*** rlandy has quit IRC | 00:21 | |
*** armstrongs has quit IRC | 00:26 | |
openstackgerrit | Merged zuul/nodepool master: Dockerfile: add xz-utils https://review.opendev.org/750839 | 00:43 |
*** zenkuro has quit IRC | 00:57 | |
*** vishalmanchanda has joined #zuul | 01:59 | |
*** bhavikdbavishi has joined #zuul | 02:54 | |
*** bhavikdbavishi1 has joined #zuul | 03:01 | |
*** bhavikdbavishi has quit IRC | 03:03 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:03 | |
*** bhavikdbavishi has quit IRC | 03:19 | |
*** bhavikdbavishi has joined #zuul | 03:38 | |
*** bhavikdbavishi1 has joined #zuul | 03:45 | |
*** bhavikdbavishi has quit IRC | 03:46 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:46 | |
*** bhavikdbavishi has quit IRC | 04:18 | |
*** bhavikdbavishi has joined #zuul | 04:19 | |
*** bhavikdbavishi has quit IRC | 04:23 | |
*** bhavikdbavishi has joined #zuul | 04:23 | |
*** bhagyashris|rove is now known as bhagyashri|rover | 04:32 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #zuul | 04:33 | |
*** cloudnull has quit IRC | 05:08 | |
*** reiterative has quit IRC | 05:40 | |
*** reiterative has joined #zuul | 05:41 | |
felixedel | ianw, corvus: Yes, that was my understanding | 05:53 |
*** bhavikdbavishi1 has joined #zuul | 06:01 | |
*** bhavikdbavishi has quit IRC | 06:03 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 06:03 | |
*** cloudnull has joined #zuul | 06:05 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 06:14 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 06:14 |
*** mach1na has joined #zuul | 06:14 | |
openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Wrap lines on Logfile page https://review.opendev.org/750875 | 06:17 |
felixedel | ianw, corvus: I've put the fix for the Logfile page on top of the stack https://review.opendev.org/#/c/750875/ | 06:17 |
*** mach1na has quit IRC | 06:23 | |
*** mach1na has joined #zuul | 06:23 | |
*** bhavikdbavishi has quit IRC | 06:32 | |
*** hashar has joined #zuul | 06:50 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul-jobs master: WIP: Temporary disable sudo revocation https://review.opendev.org/750881 | 06:53 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 06:55 |
*** bhavikdbavishi has joined #zuul | 07:10 | |
ianw | felixedel: nice, i'll probably have to check it out tomorrow but sounds good! | 07:11 |
openstackgerrit | Jan Kubovy proposed zuul/zuul-jobs master: WIP: Temporary disable sudo revocation for tox https://review.opendev.org/750881 | 07:12 |
*** mach1na has quit IRC | 07:15 | |
*** bhavikdbavishi1 has joined #zuul | 07:22 | |
*** bhavikdbavishi has quit IRC | 07:23 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 07:23 | |
*** tosky has joined #zuul | 07:32 | |
*** avass has joined #zuul | 07:34 | |
*** mach1na has joined #zuul | 07:35 | |
*** mach1na has quit IRC | 07:36 | |
*** mach1na has joined #zuul | 07:36 | |
*** jpena|off is now known as jpena | 07:40 | |
*** jcapitao has joined #zuul | 07:42 | |
*** saneax has joined #zuul | 07:53 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 08:00 |
bolg_ | tristanC: Regarding https://review.opendev.org/c/717269 I am open to suggestion how to break up the ZooKeeper class. With the current approach its too verbose, with functions we will the ZK object will not see tose functions as methods, without both there will be little IDE support. What do you think? | 08:22 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add promote, release jobs https://review.opendev.org/750193 | 08:22 |
mhu | hello zuul maintainers, I think the initialization of zuul-client is ready; could you have a look at the changes: https://review.opendev.org/#/c/749775/ and https://review.opendev.org/#/c/750193/ | 08:23 |
mhu | Also once these are merged could we tag an initial release so that the project is hosted on PyPI? This will allow zuul-client to be used as a requirement in zuul (and avoid some code repetition) | 08:25 |
*** jcapitao has quit IRC | 08:27 | |
*** jcapitao has joined #zuul | 08:36 | |
*** jcapitao has quit IRC | 08:41 | |
*** jcapitao has joined #zuul | 08:42 | |
*** jfoufas1 has joined #zuul | 08:47 | |
*** bhavikdbavishi has quit IRC | 08:49 | |
*** bhavikdbavishi has joined #zuul | 09:01 | |
*** bhavikdbavishi has quit IRC | 09:03 | |
*** harrymichal has joined #zuul | 09:18 | |
*** bhavikdbavishi has joined #zuul | 09:32 | |
*** nils has joined #zuul | 09:34 | |
*** AshBullock has joined #zuul | 09:37 | |
AshBullock | Hey, I'm in the process of adding TLS to zookeeper, I'm trying to get nodepool to connect but getting connection refused, In the folder I ran the zk-ca.sh I see certs labelled by IP: "10.X.X.X.pem" and also "client.pem", which files should I be referencing in the nodepool.yaml? | 09:44 |
*** bhavikdbavishi has quit IRC | 09:49 | |
*** hashar has quit IRC | 09:58 | |
*** hashar has joined #zuul | 09:58 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 10:02 |
bolg_ | tristanC: another approach without the overhead: https://review.opendev.org/#/c/717269 | 10:04 |
*** zenkuro has joined #zuul | 10:10 | |
*** harrymichal has quit IRC | 10:18 | |
*** harrymichal has joined #zuul | 10:18 | |
*** bhavikdbavishi has joined #zuul | 10:25 | |
frickler | did anyone else notice an issue with the console stream window output for running tasks? there's no scroll bar for the text window, the scroll bar that I have moves the whole window, not the console content. I can scroll with the wheel inside the console window, but I'd like to be able to move to start/end fast | 10:36 |
*** CraigR has joined #zuul | 10:46 | |
*** mach1na has quit IRC | 10:50 | |
*** bhavikdbavishi has quit IRC | 10:55 | |
*** bhavikdbavishi has joined #zuul | 10:56 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 11:01 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 11:01 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 11:01 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 11:01 |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 11:01 |
*** sanjayu_ has joined #zuul | 11:01 | |
*** saneax has quit IRC | 11:02 | |
*** sanjayu__ has joined #zuul | 11:04 | |
*** sanjayu_ has quit IRC | 11:07 | |
*** bhavikdbavishi has quit IRC | 11:09 | |
*** CraigR has quit IRC | 11:10 | |
*** AshBullock has quit IRC | 11:12 | |
*** AshBullock has joined #zuul | 11:17 | |
*** jcapitao is now known as jcapitao_lunch | 11:21 | |
*** jpena is now known as jpena|lunch | 11:31 | |
*** mach1na has joined #zuul | 11:44 | |
*** AshBullock has quit IRC | 11:48 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 11:53 |
*** mach1na has quit IRC | 11:57 | |
*** mach1na has joined #zuul | 11:57 | |
*** arxcruz|ruck is now known as arxcruz|pto | 12:05 | |
*** rlandy has joined #zuul | 12:06 | |
*** rfolco has joined #zuul | 12:11 | |
*** jcapitao_lunch is now known as jcapitao | 12:16 | |
*** rfolco is now known as rfolco|ruck | 12:18 | |
*** mach1na has quit IRC | 12:23 | |
*** mach1na has joined #zuul | 12:26 | |
*** hashar has quit IRC | 12:31 | |
tristanC | bolg_: what is the benefit to mix both nodepool and zuul function inside a single object? Is it just for caller to use zk.getHoldRequest? I find composition easier to read, e.g.: zk.nodepool.getHoldRequest | 12:33 |
*** hashar has joined #zuul | 12:37 | |
*** AshBullock has joined #zuul | 12:37 | |
*** jpena|lunch is now known as jpena | 12:39 | |
*** hashar has quit IRC | 12:40 | |
*** bhavikdbavishi has joined #zuul | 12:43 | |
*** AshBullock has quit IRC | 12:53 | |
*** AshBullock has joined #zuul | 12:54 | |
*** bhavikdbavishi has quit IRC | 12:56 | |
*** bhavikdbavishi has joined #zuul | 13:02 | |
bolg_ | tristanC: I was also thinking about doing it this way, would make even more sence. Currently I just split the one ZooKeeper class into multiple mixins | 13:14 |
bolg_ | The change did not require changes outside the zuul.zk, with the composition also calls needs to be changed then | 13:15 |
tristanC | bolg_: i developped that idea in a comment on the review, but i am not sure to understand all the implication | 13:15 |
*** sanjayu__ has quit IRC | 13:16 | |
tristanC | bolg_: but it seems like a good idea that the client specifics state such as connection event listener should not be shared with the zkzuul or zknodepool class | 13:17 |
*** zenkuro has quit IRC | 13:18 | |
*** bhavikdbavishi has quit IRC | 13:19 | |
bolg_ | tristanC: It cleaner what you suggest there. But I am not sure how all the changed calls will be welcomed | 13:19 |
fungi | AshBullock: here's how we set ours in opendev's nodepool servers: https://opendev.org/opendev/system-config/src/branch/master/playbooks/roles/nodepool-base/tasks/main.yaml#L74-L77 | 13:20 |
tristanC | bolg_: in that situation, the main zk class could provide backward compatible passthrough function | 13:20 |
AshBullock | fungi thanks, actually just figured it out, had the wrong nodepool version | 13:21 |
bolg_ | tristanC: I think this may be confusing for someone who wants to use the API, no? We would comment the passthrough functions as deprecated? | 13:22 |
*** Goneri has joined #zuul | 13:26 | |
bolg_ | tristanC: Also when I thought about such implementation I was thinking to split not only zuul and nodepool but also, executors, builds, etc. See https://review.opendev.org/c/744416/28/zuul/zk/__init__.py. Imagine properties instead of each mixin there | 13:26 |
*** piotrowskim has joined #zuul | 13:28 | |
tristanC | bolg_: passthrough should be temporary, just for the initial review, and it could be removed in a follow while fixing the callsite | 13:30 |
tristanC | bolg_: it seems like using mixin doesn't actually break-up the "god-like" zookeeper class, it's only splitting it in different file | 13:33 |
bolg_ | tristanC: yes from runtime point of view it has the same result. Its just a logical split | 13:35 |
tristanC | bolg_: executors and builds could also be composed using regular objects that takes the client as a constructor | 13:35 |
*** hashar has joined #zuul | 13:48 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add builds subcommand https://review.opendev.org/750999 | 14:06 |
felixedel | frickler: The problem you are describing sounds related to the scrolling issues we discussed the last days. It should be fixed by https://review.opendev.org/#/c/750361/2 and the related changes. A temporary solution would be to remove the "overflow-x: visible; overflow-y: visible;" attributes from the "pf-c-page__main" CSS selector directly in the browser for this page. | 14:16 |
*** jfoufas1 has quit IRC | 14:26 | |
frickler | felixedel: ah, thx for the pointer, I didn't follow scrollback. but now I indeed found the horizontal scrollbar and can uncover the vertical one with it. | 14:35 |
*** zenkuro has joined #zuul | 14:46 | |
openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 14:47 |
*** hashar has quit IRC | 15:17 | |
*** mach1na has quit IRC | 15:30 | |
*** AshBullock has quit IRC | 15:58 | |
*** jcapitao has quit IRC | 16:16 | |
*** bhavikdbavishi has joined #zuul | 16:21 | |
*** zenkuro has quit IRC | 16:31 | |
*** hamalq has joined #zuul | 16:32 | |
*** bhavikdbavishi1 has joined #zuul | 16:49 | |
*** jpena is now known as jpena|off | 16:49 | |
*** bhavikdbavishi has quit IRC | 16:51 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 16:51 | |
*** bhavikdbavishi has quit IRC | 16:53 | |
*** bhavikdbavishi1 has joined #zuul | 16:53 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 16:55 | |
*** bhavikdbavishi has quit IRC | 17:00 | |
*** mach1na has joined #zuul | 17:32 | |
*** mach1na has quit IRC | 17:36 | |
mhu | hello zuul maintainers, I think the initialization of zuul-client is ready; could you have a look at the changes: https://review.opendev.org/#/c/749775/ and https://review.opendev.org/#/c/750193/ | 17:58 |
mhu | Also once these are merged could we tag an initial release so that the project is hosted on PyPI? This will allow zuul-client to be used as a requirement in zuul (and avoid some code repetition) | 17:58 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add build-info subcommand https://review.opendev.org/751070 | 17:59 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add builds subcommand https://review.opendev.org/750999 | 18:04 |
*** gmann is now known as gmann_afk | 18:11 | |
*** nils has quit IRC | 18:21 | |
*** wxy has quit IRC | 18:51 | |
*** zenkuro has joined #zuul | 18:53 | |
*** rfolco has joined #zuul | 18:54 | |
*** piotrowskim has quit IRC | 18:54 | |
*** rfolco|ruck has quit IRC | 18:56 | |
*** hashar has joined #zuul | 19:01 | |
*** rfolco is now known as rfolco|ruck | 19:12 | |
*** hamalq_ has joined #zuul | 19:23 | |
*** hamalq has quit IRC | 19:24 | |
*** hashar has quit IRC | 20:33 | |
*** openstackgerrit has quit IRC | 20:36 | |
*** rfolco|ruck has quit IRC | 21:00 | |
*** harrymichal has quit IRC | 21:37 | |
*** Goneri has quit IRC | 21:49 | |
*** rlandy has quit IRC | 22:04 | |
*** vishalmanchanda has quit IRC | 22:21 | |
*** tosky has quit IRC | 22:42 | |
*** gmann_afk is now known as gmann | 22:49 | |
*** sanjayu__ has joined #zuul | 23:05 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!