| *** armstrongs has quit IRC | 00:04 | |
| *** hamalq has quit IRC | 00:45 | |
| *** zenkuro has quit IRC | 01:24 | |
| *** ianychoi_ has joined #zuul | 01:46 | |
| *** ianychoi has quit IRC | 01:48 | |
| *** iurygregory has quit IRC | 02:08 | |
| *** rlandy has quit IRC | 02:22 | |
| *** hashar has joined #zuul | 02:48 | |
| *** sanjayu_ has joined #zuul | 04:01 | |
| *** saneax has quit IRC | 04:02 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** vishalmanchanda has joined #zuul | 04:34 | |
| *** sassyn has quit IRC | 04:40 | |
| *** hashar has quit IRC | 05:13 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 05:48 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 05:48 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 05:48 |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: web: PF4 minor rework of log viewer page https://review.opendev.org/751140 | 05:49 |
| *** mach1na has joined #zuul | 05:51 | |
| *** sanjayu_ has quit IRC | 06:10 | |
| openstackgerrit | Rico Lin proposed zuul/zuul-jobs master: Allow skip files when download logs https://review.opendev.org/751973 | 06:11 |
| *** saneax has joined #zuul | 06:24 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 06:27 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 06:27 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 06:27 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Retire Fedora 31 for 32 https://review.opendev.org/751975 | 06:27 |
| openstackgerrit | Merged zuul/zuul master: Handle review requirements in canMerge https://review.opendev.org/749040 | 06:35 |
| *** mach1na has quit IRC | 06:35 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 06:42 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 06:50 |
| *** mach1na has joined #zuul | 06:55 | |
| *** iurygregory has joined #zuul | 06:58 | |
| *** jcapitao has joined #zuul | 07:13 | |
| openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed zuul/zuul-jobs master: Add support to use stow for ensure-python https://review.opendev.org/751611 | 07:15 |
| *** hashar has joined #zuul | 07:24 | |
| *** tosky has joined #zuul | 07:34 | |
| *** saneax has quit IRC | 07:36 | |
| openstackgerrit | Merged zuul/zuul master: Don't match branch protection rule patterns locally https://review.opendev.org/751686 | 07:38 |
| *** jpena|off is now known as jpena | 07:49 | |
| *** saneax has joined #zuul | 07:52 | |
| *** sshnaidm|afk is now known as sshnaidm | 08:04 | |
| *** harrymichal has joined #zuul | 08:20 | |
| openstackgerrit | Rico Lin proposed zuul/zuul-jobs master: Allow skip files when download logs https://review.opendev.org/751973 | 08:21 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/750196 | 08:24 |
| *** holser has joined #zuul | 08:30 | |
| *** nils has joined #zuul | 08:30 | |
| *** harrymichal has quit IRC | 08:43 | |
| *** harrymichal has joined #zuul | 08:44 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Make default config files location a class attribute https://review.opendev.org/751291 | 08:58 |
| *** zenkuro has joined #zuul | 09:08 | |
| openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed zuul/zuul-jobs master: Add support to use stow for ensure-python https://review.opendev.org/751611 | 09:09 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/750196 | 09:16 |
| *** harrymichal has quit IRC | 09:34 | |
| *** yolanda has joined #zuul | 09:37 | |
| noonedeadpunk | folks, is fedora 31 supposed to fail on zuul/zuul-jobs ? | 09:46 |
| noonedeadpunk | https://zuul.opendev.org/t/zuul/build/14944c447b694db682d2f102b76c26c8 | 09:46 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add cross testing with Zuul https://review.opendev.org/751264 | 09:51 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Make default config files location a class attribute https://review.opendev.org/751291 | 09:51 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/750196 | 09:57 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Evaluate CODEOWNERS settings during canMerge check https://review.opendev.org/644557 | 10:04 |
| *** jcapitao is now known as jcapitao_lunch | 10:24 | |
| *** sanjayu_ has joined #zuul | 10:30 | |
| *** saneax has quit IRC | 10:30 | |
| *** sanjayu__ has joined #zuul | 11:03 | |
| *** sanjayu_ has quit IRC | 11:03 | |
| *** mach1na has quit IRC | 11:10 | |
| *** mach1na has joined #zuul | 11:11 | |
| *** mach1na has quit IRC | 11:15 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/750196 | 11:25 |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Reduce column size for time values https://review.opendev.org/752018 | 11:31 |
| *** jpena is now known as jpena|lunch | 11:35 | |
| *** Goneri has joined #zuul | 11:44 | |
| openstackgerrit | Tobias Henkel proposed zuul/nodepool master: Add zookeeper-timeout connection config https://review.opendev.org/752022 | 11:48 |
| *** mach1na has joined #zuul | 11:50 | |
| *** brendangalloway has joined #zuul | 11:56 | |
| fungi | noonedeadpunk: we suspect it's related to https://bugzilla.redhat.com/show_bug.cgi?id=1853736 which only got fixed in f32 and later | 11:58 |
| openstack | bugzilla.redhat.com bug 1853736 in systemd "systemctl show service fails with "Failed to parse bus message: Invalid argument"" [Unspecified,Closed: errata] - Assigned to systemd-maint | 11:58 |
| fungi | clarkb is trying to work around it with https://review.opendev.org/751872 | 11:58 |
| fungi | but ianw has also pushed https://review.opendev.org/751975 to just switch to f32 | 11:59 |
| noonedeadpunk | tbh I'd rather just used f32 if possible... | 11:59 |
| noonedeadpunk | but yeah, I see | 11:59 |
| noonedeadpunk | thanks for heads up:) | 12:00 |
| *** rfolco|ruck has joined #zuul | 12:03 | |
| *** jcapitao_lunch is now known as jcapitao | 12:05 | |
| *** rlandy has joined #zuul | 12:07 | |
| *** brendangalloway has quit IRC | 12:18 | |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: gitlab: merge request approval: specify the commit https://review.opendev.org/752031 | 12:20 |
| *** Goneri has quit IRC | 12:23 | |
| mhu | hello fungi, re: your suggestion to test adding zuul-client as a zuul requirement: I'm trying to pre-install zuul-client in the tox venv in a pre playbook, before the tox job is run | 12:23 |
| mhu | this is in https://review.opendev.org/#/c/750196/ | 12:24 |
| mhu | but it looks like tox doesn't seem to see the "manually" installed version of zuul-client and still fetches the lib from pypi | 12:24 |
| mhu | which breaks the test since the package is incorrect | 12:25 |
| *** sshnaidm has quit IRC | 12:25 | |
| fungi | mhu: i think our tox role does the right thing via its "tox-siblings" detection, where if you have a requirement which is listed as a required-projects entry for the job then it gets automatically preinstalled into the venv | 12:26 |
| tristanC | fungi: iirc the tox role install the siblings after an initial installation from pypi | 12:29 |
| fungi | ahh, yeah, though it should currently be installable, it's just not importable | 12:33 |
| mhu | fungi, tristanC yeah that's exactly the problem, the build fails when attempting to initialize the zuul entry points - since the tox siblings scripts occur after the tox run without testing, it's too late | 12:35 |
| *** jpena|lunch is now known as jpena | 12:36 | |
| mhu | that's why I'm trying to install the fixed lib from a local build before this, but it looks like tox cleans the venv first | 12:36 |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: FakeGitlabAPIClient: use subject instead of title https://review.opendev.org/752035 | 12:38 |
| mhu | the test confirms at least that the wheel builds correctly and can be installed: https://zuul.opendev.org/t/zuul/build/bcfbe4b98f6442f09862bcae236420cc/log/job-output.txt#740 | 12:39 |
| mhu | as of https://review.opendev.org/#/c/751291/ | 12:40 |
| *** piotrowskim has joined #zuul | 12:45 | |
| *** Goneri has joined #zuul | 12:49 | |
| *** sshnaidm has joined #zuul | 12:50 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 12:55 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 12:56 |
| *** hashar has quit IRC | 13:16 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client to requirements https://review.opendev.org/752043 | 13:21 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client to requirements https://review.opendev.org/752043 | 13:22 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 13:52 |
| *** yolanda has quit IRC | 13:53 | |
| *** yolanda has joined #zuul | 13:54 | |
| *** AshBullock has joined #zuul | 13:55 | |
| *** jfoufas1 has joined #zuul | 13:56 | |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: gitlab: merge request approval: specify the commit https://review.opendev.org/752031 | 13:57 |
| *** stevthedev_ has joined #zuul | 13:57 | |
| *** gouthamr__ has joined #zuul | 13:57 | |
| *** guilhermesp_ has joined #zuul | 13:57 | |
| *** gmann_ has joined #zuul | 13:57 | |
| *** smyers_ has joined #zuul | 13:57 | |
| *** jbryce_ has joined #zuul | 13:58 | |
| *** gouthamr has quit IRC | 14:00 | |
| *** jbryce has quit IRC | 14:00 | |
| *** guilhermesp has quit IRC | 14:00 | |
| *** stevthedev has quit IRC | 14:00 | |
| *** fungi has quit IRC | 14:00 | |
| *** Eighth_Doctor has quit IRC | 14:00 | |
| *** smyers has quit IRC | 14:00 | |
| *** logan- has quit IRC | 14:00 | |
| *** smyers_ is now known as smyers | 14:00 | |
| *** gmann has quit IRC | 14:00 | |
| *** ironfoot has quit IRC | 14:00 | |
| *** jbryce_ is now known as jbryce | 14:00 | |
| *** stevthedev_ is now known as stevthedev | 14:00 | |
| *** gouthamr__ is now known as gouthamr | 14:00 | |
| *** guilhermesp_ is now known as guilhermesp | 14:00 | |
| *** ironfoot has joined #zuul | 14:00 | |
| *** gmann_ is now known as gmann | 14:00 | |
| *** logan- has joined #zuul | 14:01 | |
| *** Eighth_Doctor has joined #zuul | 14:07 | |
| *** fungi has joined #zuul | 14:09 | |
| AshBullock | Hey, is anyone with better knowledge of the code base able to point me in the right direction of what is responsible for setting the "self.updated" var of the class "MergeCompletedEvent", I'm working on a driver for bitbucketcloud and have some webhooks firing events, but they are all being set as updated: False by the merger, I can't figure out | 14:19 |
| AshBullock | where this is calculated | 14:19 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove an unneeded api call when creating check_runs https://review.opendev.org/752056 | 14:20 |
| *** jfoufas1 has quit IRC | 14:23 | |
| *** AshBullock has quit IRC | 14:27 | |
| felixedel | AshBullock: Not sure if that helps, but I just did a search in the code for that field: It looks like the "updated" field is directly set on the MergeCompletedEvent() when it is initialized in scheduler.onMergeCompleted() https://opendev.org/zuul/zuul/src/branch/master/zuul/scheduler.py#L555 This method is called by the MergeClient https://opendev.org/zuul/zuul/src/branch/master/zuul/merger/client.py#L199 whereby the | 14:27 |
| felixedel | updated field of the job is used | 14:27 |
| *** AshBullock has joined #zuul | 14:28 | |
| AshBullock | Hey, is anyone with better knowledge of the codebase able to point me in the right direction of how the "self.updated" variable of the class "MergeCompletedEvent" gets set? I've got a bitbucketcloud driver set up firing some webhook events, but they are all set as "updated: False" by the merge client and I can't seem to find how that's evaluated | 14:34 |
| AshBullock | felixedel thanks! yeah I was looking there, but can't see how the job gets that value set either | 14:35 |
| felixedel | AshBullock: Hmm, not sure. That might come from gearman directly. At least it seems to be set on the job result. The getJobData() method just extracts the "data" attribute that is set on the job. | 14:42 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove an unneeded api call when creating check_runs https://review.opendev.org/752056 | 14:43 |
| clarkb | AshBullock: felixedel https://opendev.org/zuul/zuul/src/branch/master/zuul/merger/server.py#L141 https://opendev.org/zuul/zuul/src/branch/master/zuul/merger/server.py#L175 https://opendev.org/zuul/zuul/src/branch/master/zuul/merger/server.py#L203 | 14:45 |
| clarkb | then in merger/client.py the gearman merge client reads that value and applies it to the merge event in the scheduler | 14:46 |
| AshBullock | clarkb Thanks, that's what I'm looking for | 14:49 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 14:57 |
| *** ianychoi__ has joined #zuul | 15:41 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 15:44 |
| *** mach1na has quit IRC | 15:45 | |
| *** ianychoi_ has quit IRC | 15:45 | |
| *** mach1na has joined #zuul | 15:45 | |
| *** mach1na has quit IRC | 15:50 | |
| *** mach1na has joined #zuul | 16:02 | |
| *** mach1na has quit IRC | 16:06 | |
| -openstackstatus- NOTICE: Our PyPI caching proxies are serving stale package indexes for some packages. We think because PyPI's CDN is serving stale package indexes. We are sorting out how we can either fix or workaround that. In the meantime updating requirements is likely the wrong option. | 16:12 | |
| *** jcapitao has quit IRC | 16:12 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 16:13 |
| *** nils has quit IRC | 16:22 | |
| mhu | fungi: I've split the zuul-client > zuul integration over two changes: the first, https://review.opendev.org/#/c/752039/ is only for unit testing that the zuul-client module gets installed | 16:30 |
| mhu | but from the tox logs it doesn't seem like the depends-on version of zuul-client is installed by the tox siblings script | 16:31 |
| fungi | mhu: sorry, i'm being pulled in half a dozen directions today, can you link to the build result where you expected it to get installed from source and it wasn't? | 16:35 |
| mhu | fungi, no worries, I'm about to call it a day anyway. There's a build in progress right now | 16:35 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove an unneeded api call when creating check_runs https://review.opendev.org/752056 | 16:38 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Save superfluous api requests in check run reporting https://review.opendev.org/752079 | 16:38 |
| *** sanjayu__ has quit IRC | 16:39 | |
| *** saneax has joined #zuul | 16:41 | |
| *** saneax has quit IRC | 16:46 | |
| *** piotrowskim has quit IRC | 16:51 | |
| *** jpena is now known as jpena|off | 16:56 | |
| *** paladox has quit IRC | 17:37 | |
| *** paladox has joined #zuul | 17:38 | |
| *** tosky has quit IRC | 17:40 | |
| *** vishalmanchanda has quit IRC | 18:13 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove an unneeded api call when creating check_runs https://review.opendev.org/752056 | 18:31 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Save superfluous api requests in check run reporting https://review.opendev.org/752079 | 18:31 |
| *** AshBullock has quit IRC | 18:31 | |
| *** ashbullock has joined #zuul | 18:32 | |
| ashbullock | thanks for your pointers earlier, I now have jobs triggering for bitbucketcloud on commits to branchs, prs, and pr branches :D I'm in the process of cleaning up the code for reviewal now | 18:33 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Use bionic images for zuul-stream-functional tests https://review.opendev.org/749967 | 18:36 |
| ashbullock | pr comments* I've encountered a few things to consider along the way, the bitbucketcloud webhook integrations don't pass an authentication token like github/lab do, and their docs just advise to lock down to bitbucket cloud IP's, https://support.atlassian.com/bitbucket-cloud/docs/manage-webhooks/ | 18:39 |
| ashbullock | I'm thinking in this case the best I can do is document that and ensure required headers are in place on the requests, and lock down to https, does anyone have any thoughts on that? | 18:41 |
| corvus | wow, you'd need a dedicated zuul-web worker just for bitbucket in order to firewall by ip :( | 18:42 |
| fungi | ashbullock: maybe the connection driver should also include a configuration option to allow you to specify allowed ip addresses for the bb webhooks? | 18:43 |
| fungi | ugly, but might make it possible to not need to use network firewalls to restrict source addresses for those specific paths | 18:43 |
| corvus | fungi: that would also prevent using load balancers, proxies, ssl terminators... | 18:44 |
| corvus | i think it would be better to do that outside of zuul-web | 18:44 |
| fungi | yeah, fair, if you put zuul-web behind a non-transparent load balancer you'd need to do the layer 7 filtering on the lb layer | 18:44 |
| corvus | ashbullock: when you say 'required headers' what do you mean? is there a header that can be used to authenticate that the webhook event is from bbc? | 18:45 |
| ashbullock | fungi yeah thats exactly what i've got set up on my test, zuul exposed on a public lb with rules | 18:46 |
| ashbullock | it is rather annoying, it seems like a core requirement | 18:47 |
| ashbullock | corvus i just mean the standard webhook headers bitbucketcloud adds (X-Event-Key, X-Hook-UUID, X-Request-UUID) https://support.atlassian.com/bitbucket-cloud/docs/event-payloads/ | 18:51 |
| ashbullock | they also have User-Agent: Bitbucket-Webhooks/2.0, but that's about it | 18:51 |
| fungi | so easily spoofed by anyone | 18:52 |
| ashbullock | unfortunately, yeah | 18:54 |
| ashbullock | and on another point, it doesn't have a concept of pull request refs like github/lab does, so at the moment I've been taking refs/heads/<branch>, not sure if that would encounter problems | 18:58 |
| *** mattd01 has joined #zuul | 18:58 | |
| clarkb | ashbullock: the proposed content should be fetchable in some way? | 18:58 |
| clarkb | if you pull refs/heads/branch that is just the existing code on the branch isn't it? | 18:59 |
| ashbullock | i'd assumed it would be at the latest of the branch which would have the changes | 19:00 |
| ashbullock | but I've seen a few ways the pull request head can be calculated which I want to try out tomorrow | 19:01 |
| *** armstrongs has joined #zuul | 19:05 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Retire Fedora 31 for 32 https://review.opendev.org/751975 | 19:15 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 19:15 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 19:15 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 19:15 |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: web: PF4 minor rework of log viewer page https://review.opendev.org/751140 | 19:27 |
| *** ashbullock has quit IRC | 19:33 | |
| openstackgerrit | Merged zuul/zuul master: Drop support for python 3.5 https://review.opendev.org/749947 | 19:49 |
| ianw | corvus: do you think we're gtg with the pf4 stack from https://review.opendev.org/#/c/750875 down? | 19:57 |
| corvus | ianw: i'll take a look, thx for the reminder | 19:59 |
| Pilou | With zuul.opendev.org, is there a way to get logs of failed builds (for example: https://zuul.opendev.org/t/zuul/build/8d2e556e988045b196c612a60c8e6f7c) ? | 20:00 |
| fungi | Pilou: that's why it ended in a post_failure result. zuul was unable to upload the logs for that build | 20:01 |
| fungi | so hard to serve logs for a build which failed trying to record its logs, unfortunately | 20:01 |
| fungi | Pilou: though the timing on that looks coincident with when opendev's zuul was unable to upload logs to one of its configured swift regions where a quota was reached, since corrected | 20:02 |
| fungi | i expect that's the reason for the failure | 20:02 |
| Pilou | ok, thanks for the explanation! | 20:03 |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: gitlab: merge request approval: specify the commit https://review.opendev.org/752031 | 20:13 |
| *** AshBullock has joined #zuul | 20:23 | |
| *** mattd01 has left #zuul | 20:38 | |
| *** AshBullock has quit IRC | 21:03 | |
| *** armstrongs33 has joined #zuul | 21:26 | |
| corvus | ianw: i'm confused by 750875 | 21:33 |
| corvus | ianw: that eliminates horizontal scrolling on the logs page, and asserts that "we don't like horizontal scrolling" | 21:33 |
| corvus | ianw: i like it very much, and indeed we asked zbr to do quite a bit of work to ensure that we don't lose it | 21:34 |
| corvus | so it seems really weird that we would suddenly decide that when felixedel proposes we get rid of it that we forget that | 21:34 |
| *** armstrongs33 has quit IRC | 21:35 | |
| corvus | i even left a review comment on 750322 that we needed to maintain the horizontal scrolling on the logs tab | 21:35 |
| corvus | tristanC: ^ fyi | 21:36 |
| corvus | tobiash: ^ also | 21:39 |
| ianw | corvus: I don't think i ever -1'd a wrap change, although i probably didn't vote for it. i'm taking in the context of having looked at contemporary examples, from github and gitlab, which i linked in a few places | 21:41 |
| corvus | ianw: i don't understand | 21:41 |
| ianw | in prior discussion, i saw opinions, but never "github does like this, here's the link", "gitlab does like this, here's the link", "jenkins does like this" here's the link | 21:41 |
| corvus | ianw: my point is that 750875 contradicts what i said earlier in 750322 and should not be approved. | 21:42 |
| corvus | there definitely is no consensus that "we don't like horizontal scrolling". i *love* horizontal scrolling. | 21:42 |
| corvus | at best, we are divided, which is why we're adding a user-pref toggle. | 21:43 |
| ianw | i would agree that's a strong thing to write in that commit message | 21:43 |
| corvus | so i think we should maintain the status quo, then add the new functionality in the toggle | 21:43 |
| tristanC | corvus: i understood the issue is that without 750875, the whole ui, including the navbar doesn't horiwontal scroll properly | 21:45 |
| corvus | tristanC: it looks like without 750875, we get viewport horizontal scrolling (and a really wide navbar) | 21:47 |
| tristanC | corvus: for example, with the current webui, i can't see the top right part of this page: https://zuul.opendev.org/t/zuul/build/f3aeaa6a6d76482b8173e606db0e71c7/log/job-output.txt | 21:47 |
| corvus | tristanC: yep | 21:48 |
| corvus | that's also not desirable | 21:48 |
| tristanC | corvus: while with the site-preview of 750875, then at least the navbar is rendered correctly. but I agree we also want horizontal scroll for logfile content | 21:49 |
| corvus | yeah, i'm thinking we can live with the stretched navbar until this is fixed | 21:49 |
| corvus | i'd like to wait until the whole stack is ready before we merge anything though | 21:50 |
| *** rfolco|ruck has quit IRC | 22:51 | |
| *** Goneri has quit IRC | 23:03 | |
| *** armstrongs70 has joined #zuul | 23:09 | |
| *** armstrongs70 has quit IRC | 23:19 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!