| tristanC | ianw: maybe we could rename it latest_tested_version, and perhaps a bot could propose update when upstream release a new version? | 00:07 |
|---|---|---|
| *** freenzyfriday has joined #zuul | 00:07 | |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-zookeeper: add role to setup zookeeper https://review.opendev.org/752757 | 00:08 |
| ianw | the proposal bot could i guess keep an eye on it ... | 00:08 |
| *** freenzyfriday has quit IRC | 00:16 | |
| *** Goneri has quit IRC | 00:41 | |
| *** freenzyfriday has joined #zuul | 01:02 | |
| *** freenzyfriday has quit IRC | 01:11 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: javascript: publish artifact tarball https://review.opendev.org/754245 | 01:17 |
| *** hamalq has quit IRC | 01:21 | |
| openstackgerrit | Merged zuul/nodepool master: Stop using fedora-30 https://review.opendev.org/752743 | 01:47 |
| *** jamesmcarthur has joined #zuul | 01:49 | |
| *** jamesmcarthur has quit IRC | 01:59 | |
| *** freenzyfriday has joined #zuul | 02:01 | |
| *** jamesmcarthur has joined #zuul | 02:03 | |
| *** freenzyfriday has quit IRC | 02:06 | |
| *** jamesmcarthur has quit IRC | 02:10 | |
| *** dmsimard has quit IRC | 02:16 | |
| *** dmsimard7 has joined #zuul | 02:16 | |
| *** freenzyfriday has joined #zuul | 02:51 | |
| *** freenzyfriday has quit IRC | 03:01 | |
| *** shanemcd has quit IRC | 03:28 | |
| *** shanemcd has joined #zuul | 03:28 | |
| *** jamesmcarthur has joined #zuul | 03:38 | |
| *** dmsimard7 is now known as dmsimard | 03:41 | |
| *** freenzyfriday has joined #zuul | 03:46 | |
| *** freenzyfriday has quit IRC | 03:55 | |
| *** bhavikdbavishi has joined #zuul | 04:22 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 04:28 |
| *** evrardjp has quit IRC | 04:33 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul master: web: consistent font sizes on console page and PF4 for task summary https://review.opendev.org/752383 | 04:33 |
| *** evrardjp has joined #zuul | 04:33 | |
| *** freenzyfriday has joined #zuul | 04:40 | |
| *** freenzyfriday has quit IRC | 04:45 | |
| *** bhavikdbavishi has quit IRC | 05:01 | |
| *** zbr|pto has quit IRC | 05:07 | |
| *** bhavikdbavishi has joined #zuul | 05:11 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 05:24 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 05:24 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 05:24 |
| *** jamesmcarthur has quit IRC | 05:28 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 05:33 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 05:33 |
| *** freenzyfriday has joined #zuul | 05:35 | |
| swest | ianw: thanks for your reviews! replied to your question in https://review.opendev.org/#/c/753548/2 | 05:38 |
| *** bhavikdbavishi has quit IRC | 05:38 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 05:38 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 05:38 |
| *** freenzyfriday has quit IRC | 05:44 | |
| ianw | swest: ahh, so the problem is the parent class explicitly sets it to None, whereas drivers should be able to implement it as property if they want? | 05:45 |
| *** bhavikdbavishi has joined #zuul | 05:47 | |
| swest | ianw: exactly. and since the content is driver specific anyways and it's only used in the drivers internally there is no need to have it as part of the public interface of the Change | 05:48 |
| *** jfoufas1 has joined #zuul | 06:01 | |
| *** bhavikdbavishi has quit IRC | 06:06 | |
| *** freenzyfriday has joined #zuul | 06:29 | |
| *** bhavikdbavishi has joined #zuul | 06:31 | |
| *** freenzyfriday has quit IRC | 06:34 | |
| *** freenzyfriday has joined #zuul | 06:45 | |
| *** zbr has joined #zuul | 06:49 | |
| *** hashar has joined #zuul | 06:51 | |
| *** jcapitao has joined #zuul | 06:54 | |
| *** bhavikdbavishi has quit IRC | 07:11 | |
| *** avass has joined #zuul | 07:11 | |
| *** jpena|off is now known as jpena | 07:22 | |
| *** iurygregory has quit IRC | 07:40 | |
| *** tosky has joined #zuul | 07:43 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/691253 | 08:23 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Update images to use python 3.8 https://review.opendev.org/727374 | 09:19 |
| *** piotrowskim has joined #zuul | 09:36 | |
| *** saneax has joined #zuul | 10:09 | |
| openstackgerrit | Merged zuul/zuul master: Fetch can-merge info when updating a pull-request https://review.opendev.org/753243 | 10:20 |
| openstackgerrit | Merged zuul/zuul master: Move driver specific change status field to driver https://review.opendev.org/753548 | 10:20 |
| danpawlik | Hi, can someone take a look on https://review.opendev.org/#/c/644927/ please? | 10:23 |
| *** noonedeadpunk has quit IRC | 10:33 | |
| *** noonedeadpunk has joined #zuul | 10:35 | |
| *** hashar is now known as hasharAway | 10:42 | |
| *** jcapitao is now known as jcapitao_lunch | 11:04 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Merge upload logs modules into common role https://review.opendev.org/742732 | 11:21 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Consolidate common log upload code into module_utils https://review.opendev.org/742736 | 11:21 |
| *** jpena is now known as jpena|lunch | 11:27 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Enforce max-job-timeout for jobs without configured timeout https://review.opendev.org/629552 | 11:28 |
| *** hasharAway is now known as hashar | 11:31 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Enforce max-job-timeout for jobs without configured timeout https://review.opendev.org/629552 | 11:36 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix bindep.txt: clean remaining python3.7 https://review.opendev.org/754359 | 11:59 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Improve typings in context of 744416 https://review.opendev.org/753578 | 12:00 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Merge Zookeeper connection methods https://review.opendev.org/754360 | 12:00 |
| *** rlandy has joined #zuul | 12:04 | |
| *** rfolco|ruck has joined #zuul | 12:05 | |
| *** jcapitao_lunch is now known as jcapitao | 12:18 | |
| *** jpena|lunch is now known as jpena | 12:31 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Merge Zookeeper connection methods and specialize exceptions https://review.opendev.org/754360 | 12:35 |
| *** gmann is now known as gmann_pto | 12:41 | |
| *** saneax has quit IRC | 12:42 | |
| *** jfoufas1 has quit IRC | 13:01 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/744416 | 13:03 |
| *** AJaeger has quit IRC | 13:10 | |
| *** AJaeger has joined #zuul | 13:23 | |
| *** hashar has quit IRC | 13:24 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] test zuul-client encrypt subcommand https://review.opendev.org/754103 | 13:26 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add cross testing with Zuul https://review.opendev.org/751264 | 13:29 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 13:29 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] test zuul-client encrypt subcommand https://review.opendev.org/754103 | 13:29 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add encrypt subcommand https://review.opendev.org/750709 | 13:30 |
| *** Goneri has joined #zuul | 13:41 | |
| *** hashar has joined #zuul | 13:48 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] test zuul-client encrypt subcommand https://review.opendev.org/754103 | 13:51 |
| tristanC | flaper87: corvus: the elasticsearch reporter seems to be working as expected, would you like to +3? | 14:10 |
| corvus | tristanC: will do, thx | 14:22 |
| corvus | mhu: does this tag for zuul-client look right? commit e9b427e8de649def179334fa3f99ea9beec0c64b (HEAD -> master, tag: 0.0.2, origin/master, origin/HEAD, refs/changes/93/753093/4) | 14:24 |
| mhu | corvus, LGTM | 14:25 |
| corvus | mhu: pushed | 14:25 |
| mhu | thanks! | 14:26 |
| corvus | np, sorry for delay | 14:26 |
| mhu | no worries, steady wins the race | 14:26 |
| mhu | if you have a few minutes to spare, I'd like some advice on a test that is puzzling me - I'm trying to test the encrypt subcommand in https://review.opendev.org/#/c/754103/8/tests/zuul_client/test_zuulclient.py | 14:27 |
| mhu | I'm looking at what is done in the class TestSecrets in test_v3.py | 14:27 |
| mhu | I get an error when trying to find the job history for project-secret2 on patch B, but looking at the debug logs it seems to terminate with success: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_7d1/754103/8/check/zuul-client-zuul-functional/7d12d64/testr_results.html | 14:28 |
| mhu | (I've had a pretty rocky night, so it's very well possible I'm missing something obvious) | 14:29 |
| corvus | mhu: i'll take a look; won't be right now though | 14:30 |
| mhu | Alright, I can work on something else in the meantime | 14:30 |
| *** jamesmcarthur has joined #zuul | 14:32 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add builds subcommand https://review.opendev.org/750999 | 14:40 |
| *** freenzyfriday has quit IRC | 14:45 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add build-info subcommand https://review.opendev.org/751070 | 14:47 |
| tristanC | mhu: looking at those zuul-client changes, wouldn't it be better to decouple json parsing from terminal printing? | 14:54 |
| mhu | tristanC, I intended to do that in followups | 14:55 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add build-info subcommand https://review.opendev.org/751070 | 15:10 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add buildsets, buildset-info to subcommands https://review.opendev.org/752909 | 15:13 |
| *** brendangalloway has joined #zuul | 15:21 | |
| brendangalloway | We've been seeing a lot of restarts trying to run jobs on our CI - the error seems to be due to ansible timeout being exceeded when trying to start the job (the live console fails before PRE) | 15:22 |
| clarkb | mhu: that is a weird test failure. At first I thought maybe your test class wasn't using the recording executor server but it looks like it does? | 15:23 |
| brendangalloway | We set the executor logging to debug and the output indicates an issue with the ara python module | 15:23 |
| mhu | clarkb, so I am not crazy, right? :) | 15:23 |
| clarkb | brendangalloway: its possible that is a regression that has snuck through beacuse installations like opendev's aren't using the ara integration anymore | 15:24 |
| clarkb | brendangalloway: we're relying on zuul's built in console rendering now | 15:24 |
| brendangalloway | I can supply the stack trace if that will be useful? | 15:24 |
| tristanC | brendangalloway: yes please | 15:24 |
| clarkb | mhu: not crazy :) | 15:25 |
| brendangalloway | Ansible command: ANSIBLE_CONFIG=/var/lib/zuul/builds/eadc5543a1ea4504a9cb085898ae044e/ansible/setup_playbook/ansible.cfg ZUUL_JOBDIR=/var/lib/zuul/builds/eadc5543a1ea4504a9cb085898ae044e ZUUL_JOB_LOG_CONFIG=/var/lib/zuul/builds/eadc5543a1ea4504a9cb085898ae044e/ansible/logging.json PYTHONPATH=/var/lib/zuul/ansible/2.8 TMP=/var/lib/zuul/builds/eadc5543a1ea4504a9cb085898ae044e/work/tmp /usr/lib/zuul/ansible/2.8/bin/ansible '*' -v | 15:25 |
| brendangalloway | -m setup -i /var/lib/zuul/builds/eadc5543a1ea4504a9cb085898ae044e/ansible/setup-inventory.yaml -a 'gather_subset=!all' | 15:25 |
| brendangalloway | Ansible output: b'Using /var/lib/zuul/builds/eadc5543a1ea4504a9cb085898ae044e/ansible/setup_playbook/ansible.cfg as config file' | 15:25 |
| brendangalloway | Ansible output: b'[WARNING]: Skipping plugin (/usr/lib/python3.6/site-' | 15:25 |
| brendangalloway | Ansible output: b'packages/ara/plugins/actions/ara_read.py) as it seems to be invalid: module' | 15:25 |
| brendangalloway | Ansible output: b"'ansible.plugins.callback./usr/lib/python3.6/site-" | 15:25 |
| brendangalloway | Ansible output: b"packages/ara/plugins/actions/ara_read' has no attribute 'CallbackModule'" | 15:25 |
| brendangalloway | Ansible output: b'[WARNING]: Skipping plugin (/usr/lib/python3.6/site-' | 15:25 |
| brendangalloway | Ansible output: b'packages/ara/plugins/actions/ara_record.py) as it seems to be invalid: module' | 15:25 |
| brendangalloway | Ansible output: b"'ansible.plugins.callback./usr/lib/python3.6/site-" | 15:25 |
| brendangalloway | Ansible output: b"packages/ara/plugins/actions/ara_record' has no attribute 'CallbackModule'" | 15:25 |
| brendangalloway | scrubbed a lot of leading characters for readability | 15:25 |
| brendangalloway | next output is timeout exceeded | 15:26 |
| tristanC | brendangalloway: please use a pasting service like http://paste.openstack.org/ to share log file | 15:26 |
| tristanC | brendangalloway: i think those errors are expected, it just indicates the ara built-in module are not available, so unless you are using ara_read or ara_record in your playbook, you should be fine | 15:27 |
| fungi | brendangalloway: what is the delay in the log between the ara-related messages and the timeout exceeded? | 15:28 |
| brendangalloway | tristanC: Thanks, I will do so next time | 15:28 |
| brendangalloway | fungi: about one second | 15:29 |
| brendangalloway | fungi: http://paste.openstack.org/show/798404/ | 15:29 |
| tristanC | brendangalloway: could it be a network issue between your executor and the nodepool nodes? | 15:30 |
| *** zettabyte has joined #zuul | 15:31 | |
| clarkb | mhu: this log line uses self.history too: 2020-09-25 14:18:16,498 zuul.test INFO Completed build: <Completed build, result: SUCCESS name: project2-secret uuid: 538cdd20b9494d598eac4a24c32227a4 changes: 2,1 ref: refs/changes/1/2/1> which tells us that something got recordred | 15:32 |
| brendangalloway | tristanC: That's not impossible, but I'm not sure what would have causing it. They both live in the same openstack cluster and no config has changed recently | 15:32 |
| corvus | mhu: BaseTestWeb sets executor_server.hold_jobs_in_build to True, but test_encrypt doesn't release any builds. | 15:32 |
| corvus | mhu: so you'll need to unset that or release as appropriate. that's why the history is empty. | 15:33 |
| mhu | !!! | 15:33 |
| openstack | mhu: Error: "!!" is not a valid command. | 15:33 |
| brendangalloway | tristanC: Do you have any advice on testing whether that is the case? | 15:33 |
| clarkb | corvus: mhu ah yup there is another Begin state dump earlier whichi s for your first wait for settled | 15:33 |
| corvus | clarkb: that build is recorded after the release which happens as part of the error-state shutdown | 15:33 |
| corvus | clarkb: exactly | 15:33 |
| clarkb | then the assert fails and things all get released | 15:33 |
| mhu | corvus: oooh!! | 15:33 |
| tristanC | brendangalloway: you could set a min-ready in nodepool configuration, and from the executor try: "sudo -u zuul ssh zuul@node-ip" | 15:34 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] test zuul-client encrypt subcommand https://review.opendev.org/754103 | 15:38 |
| brendangalloway | tristanC: It looks like you are correct - I can access some of the standby VMs, but not others. Will have to investigate further what might be wrong | 15:44 |
| *** jcapitao has quit IRC | 15:58 | |
| *** armstrongs has joined #zuul | 16:07 | |
| armstrongs | hey guys i noticed on the latest version of zuul on master on the builds page it no longer shows the ref id under the change column for master branch builds So you cant see what changed anymore if a commit is done on master. Just wanted to point it out. The patternfly 4 stuff looks awesome. :) | 16:12 |
| clarkb | armstrongs: the sha1 of the commit you mean? | 16:14 |
| clarkb | it should link directly to the change | 16:14 |
| armstrongs | yeah its fine for PR's not showing for master | 16:14 |
| clarkb | oh I see, builds that aren't change related | 16:14 |
| armstrongs | yeah has a blank sha1 on new patternfly page where old one had it | 16:15 |
| clarkb | I'm not even seeing a blank sha1 ? https://zuul.opendev.org/t/openstack/build/c5eae83c8efe481bbca0ce64f110f069 | 16:16 |
| fungi | likely we need to use the same ref mapping we use to display in the status view | 16:16 |
| armstrongs | https://zuul.opendev.org/t/openstack/builds?job_name=publish-stx-releasenotes+ i mostly use it on this page. It also shows a blank ref on the buildset https://zuul.opendev.org/t/openstack/build/c5eae83c8efe481bbca0ce64f110f069 | 16:18 |
| clarkb | there is a TODO in the code to fix it :) | 16:20 |
| armstrongs | ah cool sorry was just making sure. I have jumped the gun :) | 16:21 |
| clarkb | https://opendev.org/zuul/zuul/src/branch/master/web/src/containers/build/Build.jsx#L75-L89 | 16:21 |
| armstrongs | yeah periodic never showed anything but commits on master used to show sha1 diffs on what changed | 16:22 |
| clarkb | ya I think they both use the .ref attribute though | 16:24 |
| clarkb | so its the same underlying issue? | 16:24 |
| clarkb | oh no thats the refs/heads/master value | 16:24 |
| clarkb | its newrev that I think matters for this | 16:24 |
| armstrongs | yeah | 16:25 |
| clarkb | felixedel: ^ I think maybe we can render the url using newrev as the text rather than change,patchset and set the url to ref_url ? | 16:26 |
| clarkb | felixedel: the problem being that change,patchset doesn't make sense in thsi context but newrev does? | 16:26 |
| * clarkb makes a feeble attempt at a change | 16:29 | |
| *** jpena is now known as jpena|off | 16:30 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Render links for ref_url if build.change isnt' set https://review.opendev.org/754453 | 16:51 |
| clarkb | armstrongs: ^ That may fix it? | 16:51 |
| armstrongs | thats awesome thanks | 16:55 |
| clarkb | armstrongs: js(x) is definitely not my strong suit but I think that actually has a chance. It will publish a testing dashboard we can check with too | 16:55 |
| clarkb | one thing we may want to do is trim the newrev down to 7 chars but I wanted to see this work at all first | 16:56 |
| armstrongs | sounds good | 16:56 |
| armstrongs | it was 4 characters before on the old page | 16:56 |
| armstrongs | i just noticed it when we were looking at the new bitbucketcloud driver my colleague ashley is working on and thought i should say. | 16:57 |
| clarkb | heh already seeing bugs in it /me makes it better | 17:00 |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Render links for ref_url if build.change isnt' set https://review.opendev.org/754453 | 17:05 |
| *** hamalq has joined #zuul | 17:07 | |
| *** hamalq has quit IRC | 17:21 | |
| *** hamalq has joined #zuul | 17:21 | |
| *** hashar has quit IRC | 17:33 | |
| *** jamesmcarthur has quit IRC | 18:02 | |
| *** jamesmcarthur has joined #zuul | 18:12 | |
| *** freenzyfriday has joined #zuul | 18:14 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Render links for ref_url if build.change isnt' set https://review.opendev.org/754453 | 18:16 |
| clarkb | very quickly getting lost here. felixedel ^ maybe you can take a look at that and point me in the right direction if it continues to break | 18:16 |
| *** freenzyfriday has quit IRC | 18:22 | |
| *** freenzyfriday has joined #zuul | 18:47 | |
| *** jamesmcarthur has quit IRC | 18:55 | |
| *** jamesmcarthur has joined #zuul | 18:56 | |
| *** jamesmcarthur has quit IRC | 18:59 | |
| *** jamesmcarthur has joined #zuul | 18:59 | |
| *** armstrongs has quit IRC | 19:22 | |
| openstackgerrit | Andrii Ostapenko proposed zuul/zuul-jobs master: Add ability to use *-docker-image roles in periodic jobs https://review.opendev.org/740560 | 19:23 |
| *** mattd01 has joined #zuul | 19:33 | |
| *** piotrowskim has quit IRC | 19:43 | |
| *** zettabyte has quit IRC | 19:56 | |
| *** jamesmcarthur has quit IRC | 19:59 | |
| *** jamesmcarthur has joined #zuul | 20:02 | |
| *** jamesmcarthur has quit IRC | 20:04 | |
| *** jamesmcarthur has joined #zuul | 20:05 | |
| AJaeger | clarkb, corvus, tristanC, fungi, here's a change to consolidate our log roles, could you review, please? https://review.opendev.org/#/c/742732/ | 20:08 |
| tristanC | AJaeger: lgtm, but i'd rather not +3 such change on a friday :-) | 20:12 |
| *** jamesmcarthur has quit IRC | 20:16 | |
| clarkb | tristanC: AJaeger ya that sounds reasonable especially since the impact for that could be far and wide (if it were just opendev I'd say I'm around and we can go for it) | 20:25 |
| *** mattd01 has left #zuul | 20:35 | |
| *** jamesmcarthur has joined #zuul | 20:52 | |
| *** armstrongs has joined #zuul | 20:57 | |
| *** rfolco|ruck has quit IRC | 20:58 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Render links for ref_url if build.change isnt' set https://review.opendev.org/754453 | 21:00 |
| clarkb | I feel like the I have no idea what I'm doing dog | 21:00 |
| *** freenzyfriday has quit IRC | 21:02 | |
| fungi | living the meme | 21:09 |
| *** armstrongs has quit IRC | 21:11 | |
| *** jamesmcarthur has quit IRC | 21:15 | |
| *** jamesmcarthur has joined #zuul | 21:47 | |
| *** rlandy has quit IRC | 21:58 | |
| clarkb | zuul disliked that one | 22:27 |
| clarkb | my ability to debug is waning. tristanC if you haven't started a weekend yet any chance you can look at https://review.opendev.org/754453 and see if it is an obvious error? | 22:27 |
| tristanC | clarkb: perhaps you need `<>` wrapper to use the dot syntax inside jsx ternary branch, e.g. https://review.opendev.org/#/c/754453/4/web/src/containers/build/BuildsetTable.jsx@107 | 22:34 |
| tristanC | clarkb: it might be easier to read if the link value was constructed before the jsx block | 22:35 |
| clarkb | tristanC: something like external_link = {ternary stuff} then later {external_link} ? | 22:37 |
| clarkb | the previous patchset compiled but then it always complained about build.newrev being null | 22:40 |
| clarkb | even though it is the condition of the ternary condition (so something is going on there too that I don't understand) | 22:40 |
| tristanC | clarkb: i find it better like that, inlining javascript in jsx can be confusing, and the syntax error are less useful | 22:40 |
| clarkb | I think my problem is I don't quite grok the delineation here | 22:40 |
| *** freenzyfriday has joined #zuul | 22:40 | |
| clarkb | but I can give it a try | 22:40 |
| clarkb | this whole function is basically just jsx if I read it correctly | 22:42 |
| tristanC | clarkb: i would guess that in `{test ? exprA : exprB}`, test is JS, and exprA and exprB are JSX. | 22:43 |
| tristanC | clarkb: and `{buildset.change},{buildset.patchset}` may not be valid JSX, adding `<>` and `</>` around it may force it to be a valid string value | 22:44 |
| *** freenzyfriday has quit IRC | 22:45 | |
| clarkb | I see | 22:45 |
| *** tosky has quit IRC | 22:58 | |
| *** rfolco|ruck has joined #zuul | 23:02 | |
| *** jamesmcarthur has quit IRC | 23:03 | |
| *** jamesmcarthur has joined #zuul | 23:03 | |
| openstackgerrit | Clark Boylan proposed zuul/zuul master: Render links for ref_url if build.change isnt' set https://review.opendev.org/754453 | 23:13 |
| clarkb | tristanC: ^ like that maybe (its super verbose right now but I just want something that has a chance of working) | 23:13 |
| *** jamesmcarthur has quit IRC | 23:21 | |
| *** jamesmcarthur has joined #zuul | 23:22 | |
| *** rfolco|ruck has quit IRC | 23:29 | |
| *** freenzyfriday has joined #zuul | 23:30 | |
| *** freenzyfriday has quit IRC | 23:35 | |
| *** hamalq has quit IRC | 23:39 | |
| *** armstrongs has joined #zuul | 23:40 | |
| *** jamesmcarthur has quit IRC | 23:44 | |
| clarkb | tristanC: that latest patchset seems to work. Thanks for the hint | 23:46 |
| *** jamesmcarthur has joined #zuul | 23:47 | |
| *** armstrongs has quit IRC | 23:50 | |
| *** jamesmcarthur has quit IRC | 23:51 | |
| *** jamesmcarthur has joined #zuul | 23:53 | |
| *** jamesmcarthur has quit IRC | 23:54 | |
| *** jamesmcarthur has joined #zuul | 23:56 | |
| *** jamesmcarthur has quit IRC | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!