Thursday, 2020-11-05

*** armstrongs has quit IRC00:01
*** holser has quit IRC00:10
*** tosky has quit IRC00:14
*** holser has joined #zuul01:08
*** holser has quit IRC01:31
*** rlandy|bbl is now known as rlandy01:53
*** wuchunyang has joined #zuul01:57
*** smyers has quit IRC01:59
*** smyers has joined #zuul02:17
*** bhavikdbavishi has joined #zuul03:17
*** hamalq has quit IRC03:21
*** wuchunyang has quit IRC04:01
*** vishalmanchanda has joined #zuul04:31
*** saneax has joined #zuul05:03
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
*** reiterative has joined #zuul05:42
*** mach1na has joined #zuul06:59
*** mach1na has quit IRC07:03
*** mach1na has joined #zuul07:05
*** bhavikdbavishi has quit IRC07:05
*** mach1na has quit IRC07:09
openstackgerritDaniel Pawlik proposed zuul/zuul master: Improve Elasticsearch reporter doc and driver, changed index name  https://review.opendev.org/76144107:15
*** zenkuro has quit IRC07:27
*** mach1na has joined #zuul07:29
*** jpena|off is now known as jpena07:35
*** mach1na has quit IRC07:58
tobiashcorvus: do you want more reviews on 728118 (rest api tenant scoping)?07:58
*** jcapitao has joined #zuul07:59
*** saneax has quit IRC08:09
*** bhavikdbavishi has joined #zuul08:10
*** tosky has joined #zuul08:13
*** bhavikdbavishi1 has joined #zuul08:21
*** bhavikdbavishi has quit IRC08:22
*** bhavikdbavishi1 is now known as bhavikdbavishi08:22
openstackgerritzbr proposed zuul/zuul-jobs master: More E208  https://review.opendev.org/76129308:33
*** mach1na has joined #zuul08:36
*** sshnaidm|rover has quit IRC08:36
*** sshnaidm|rover has joined #zuul08:38
*** rpittau|afk is now known as rpittau08:39
*** sshnaidm|rover has quit IRC08:43
*** saneax has joined #zuul09:04
openstackgerritTobias Henkel proposed zuul/zuul master: Only report dequeue if we have reported start  https://review.opendev.org/76152009:11
*** nils has joined #zuul09:19
*** sugaar has joined #zuul09:47
*** sshnaidm has joined #zuul09:49
*** mach1na has quit IRC09:52
*** mach1na has joined #zuul09:55
*** bhavikdbavishi has quit IRC09:55
*** arxcruz has quit IRC10:04
*** holser has joined #zuul10:07
*** arxcruz has joined #zuul10:09
bschanzeltristanC: as we discussed some days ago, I've prepared a change for the k8s/OKD provider to remove the default workingDir from their pod specs. Could you take a look at https://review.opendev.org/#/c/758965/ ?10:13
*** hashar has joined #zuul10:15
*** noonedeadpunk has quit IRC10:32
*** noonedeadpunk has joined #zuul10:32
*** mach1na has quit IRC10:45
*** jfoufas1 has joined #zuul11:21
*** noonedeadpunk has quit IRC11:21
*** mach1na has joined #zuul11:24
*** noonedeadpunk has joined #zuul11:26
*** mach1na has quit IRC11:28
*** bhavikdbavishi has joined #zuul11:35
*** bhavikdbavishi1 has joined #zuul11:38
*** bhavikdbavishi has quit IRC11:40
*** bhavikdbavishi1 is now known as bhavikdbavishi11:40
*** jcapitao is now known as jcapitao_lunch11:52
*** mach1na has joined #zuul11:54
*** rfolco has joined #zuul12:02
*** wuchunyang has joined #zuul12:09
*** mach1na has quit IRC12:10
*** wuchunyang has quit IRC12:14
*** armstrongs has joined #zuul12:28
*** jpena is now known as jpena|lunch12:32
*** mach1na has joined #zuul12:57
*** rfolco has quit IRC13:01
*** jcapitao_lunch is now known as jcapitao13:01
*** rfolco has joined #zuul13:01
*** Goneri has joined #zuul13:11
*** jpena|lunch is now known as jpena13:31
*** saneax has quit IRC13:37
openstackgerritSimon Westphahl proposed zuul/zuul master: Component Registry in ZooKeeper  https://review.opendev.org/75918713:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Move management and result events to model  https://review.opendev.org/76116313:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of management events  https://review.opendev.org/76116413:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of result events  https://review.opendev.org/76116513:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Add and fix fields in driver trigger event models  https://review.opendev.org/76116613:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events  https://review.opendev.org/76116713:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Interface to get a driver's trigger event class  https://review.opendev.org/76116813:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Clear list of Zookeeper connections after tests  https://review.opendev.org/76116913:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues  https://review.opendev.org/76117013:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher  https://review.opendev.org/76117113:43
openstackgerritSimon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues  https://review.opendev.org/76117213:43
*** bhavikdbavishi has quit IRC13:52
*** armstrongs has quit IRC14:09
*** Goneri has quit IRC14:22
*** vishalmanchanda has quit IRC14:30
*** Goneri has joined #zuul14:38
*** zenkuro has joined #zuul14:38
tristanCbschanzel: thanks!14:44
openstackgerritFelix Edel proposed zuul/zuul master: Configure json-server as mock API for development  https://review.opendev.org/76093314:54
openstackgerritFelix Edel proposed zuul/zuul master: WIP UI: Remove stretchable link from builds and buildset table  https://review.opendev.org/76162114:54
tobiashzuul-maint: what do you think about making this a regex? https://zuul-ci.org/docs/nodepool/configuration.html#attr-providers.[openstack].cloud-images.image-name14:59
tobiashthis would make it possible/easier to have a snapshot based image update approach that is driven by zuul14:59
tobiashwe'd like to have something like that for the really large images where image building and uploading to glance is not feasable anymore15:00
tristanCtobiash: sounds good to me, should we keep on using re2 or stdlib would be enough?15:02
tobiashsince that's nodepool without user config stdlib for that would be enough (nodepool has no re2 anyway)15:03
tobiashthe idea would be that nodepool takes the last match of the alphabetically sorted list15:04
avasstobiash: I believe that's how the image filter works for ec2 as well15:04
tobiashoh that one: https://zuul-ci.org/docs/nodepool/configuration.html#attr-providers.[aws].cloud-images.image-filters15:05
tobiashyeah so that would be feature wise then on par with that15:05
tristanCtobiash: i'm confused with re2 usage, shouldn't all new regexp attribute use re2 to be future proof?15:05
avassbut except that it's some sort of globbing and not a regex15:06
tobiashjepp15:06
corvustobiash: ++ i'm interested in 2 ideas: 1) replacing nodepool-builder with some zuul jobs; 2) creating a second nodepool-builder that's snapshot based [that was in the original spec]15:08
corvustobiash: i think both are viable solutions and worth exploring.  #1 gets a lot more visibility to the whole system.15:09
tobiashcorvus: we have a running version of a zuul driven image build that uploads to s3 combined with a fake diskimage build that downloads it in the nodepool builder15:09
avasswe're doing #1 but using packer. and I think the CI jobs are not completely finished15:09
tobiashcorvus: for the really large images we need to get rid of the upload/download and directly use snapshots instead15:10
corvustobiash: separately -- i'm curious about why uploading to glance isn't feasible.  what's the bottleneck?  is there some way to improve that?15:10
tobiashcorvus: the images are ~700gb which takes >24h to upload via glance15:11
corvustobiash: but uploading via s3 is shorter?15:11
tobiashwell, we upload it to s3 which is shorter, download it to the builders, then upload it to multiple regions via glance15:11
tobiashand we have multiple of those images and glance is not really able to handle this amount of data15:12
corvusright, from a first principles perspective it sounds like there ought to be room for improvement in glance.  i wonder if it's worth talking with the glance authors about it, or do you think that even if glance worked as well as its peers (s3, etc) you would still want to avoid it?15:13
tobiashwe still want to avoid it, best case would be to get glance upload down to maybe ~6h which would still make overall round trip time of like 18h due to s3 upload, then download, then glance upload15:15
tobiashso even if glance can be tuned (that would need a non-python fast direct stream to ceph probably) we have still a huge penalty for copying data around15:16
corvustobiash: but if glance were faster, you could use the builder as designed and not copy to s3?15:17
corvusor maybe i don't know why you're copyng to s3 in the first place instead of using dib15:18
tobiashcorvus: we don't use the builder there because we need a ci job producing the cache data in this image which can only be done within zuul (and as a side effect makes it debuggable by the project)15:19
corvustobiash: ok.  could you push the data from the job to the builder directly instead of using s3?  (or even run the job on the builder as a static node?)15:19
*** hashar is now known as hasharKids15:20
tobiashthat's not really possible since we have 12 builders, all running in openshift15:20
*** bhavikdbavishi has joined #zuul15:33
*** jfoufas1 has quit IRC15:37
*** flaper87 has quit IRC15:42
*** bhavikdbavishi1 has joined #zuul15:56
*** bhavikdbavishi has quit IRC15:59
*** bhavikdbavishi1 is now known as bhavikdbavishi15:59
openstackgerritMerged zuul/nodepool master: k8s/OpenShift Provider: Remove workingDir Attribute  https://review.opendev.org/75896515:59
*** zenkuro has quit IRC16:03
*** zenkuro has joined #zuul16:04
*** bhavikdbavishi has quit IRC16:06
*** bhavikdbavishi has joined #zuul16:06
*** wuchunyang has joined #zuul16:11
*** bhavikdbavishi1 has joined #zuul16:13
*** bhavikdbavishi has quit IRC16:15
*** bhavikdbavishi1 is now known as bhavikdbavishi16:15
*** wuchunyang has quit IRC16:16
*** mach1na has quit IRC16:25
clarkbtristanC: re2 use isn't about future proofing but about performance and avoiding the possibility of slow regex processing in places where regexes are user supplied16:32
clarkbtristanC: in the case of admin supplied configs like for nodepool I think normal regexes are probably fine. It is more ofa concern when they are coming in unvetted zuul configs16:32
tristanCclarkb: what about having this config user supplied in the future?16:38
clarkbthen re2 may make sense at that point. The reason for not defaulting to re2 unless it is user facing is you lose a lot of features like negative lookaheads16:40
fungiand also it's yet another non-stdlib dependency16:43
*** jpena is now known as jpena|off16:43
fungi(and which relies on compiled c extensions)16:44
tristanCfungi: we already depending on it for zuul16:44
fungiahh16:45
tristanCclarkb: it's also for consistency, isn't it odd that some zuul configuration regex support negative lookaheads while some other don't16:45
fungiwas trying to install it locally but currently i seem to not be able to build its extensions16:46
tristanCclarkb: iiuc, we didn't fully switch to re2 to avoid a breaking existing regexp16:46
fungisrc/re2.cpp:14805:13: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘exc_value’; did you mean ‘curexc_value’?16:46
fungithat's fun16:46
clarkbtristanC: I don't find that odd because negative lookaheads are a very valuable feature in many cases16:46
clarkbits not ideal, but functionality like that is often very useful16:46
clarkbthe building problem I often run into is they don't release new versions of re2 often so I'll end up with a cached wheel for an old python that breaks16:47
clarkbthen I have to find that in my wheel cache and delete it to force a rebuild. Not really re2's fault but that hits me every 6 months or so16:47
fungiaha, it ships cython-generated files which need to be regenerated with newer cython for use with newer python16:48
fungiand `pip install re2` on its own won't take care of that16:48
corvuswe haven't switched to re2 everywhere because in some places negative lookaheads are very important, so we need new features to accomodate that16:49
tristanCcorvus: oh, then why are we using re2?16:50
corvusbecause work was started on that16:50
corvustristanC: https://review.opendev.org/552809 is the continuation16:51
corvusif someone wants to continue working on that, i think we can eventually switch everything to re216:52
*** jcapitao is now known as jcapitao_afk17:19
*** rpittau is now known as rpittau|afk17:21
tristanCalright, then if we don't need negative lookaheads for nodepool image-name, i think it would be better to use re2 there as well17:22
*** bhavikdbavishi has quit IRC17:25
corvustristanC: let's make sure to change it for the existing (aws?) drivers as well so it's consistent17:25
*** bhavikdbavishi has joined #zuul17:25
*** hasharKids is now known as hashar17:30
avasscorvus: aws doesn't use regex afaik17:30
avassunless it does in nodepool somewhere17:30
corvusavass: oh i misunderstood your earlier comment.  i see now you indicated it uses a glob.17:32
avassif you're thinking of the image filter i mentioned that's the aws api allowing you to glob and not boto17:32
corvusperhaps we should glob everywhere17:32
avassi guess globbing wouldn't have any perfomance issues17:37
*** hamalq has joined #zuul17:38
corvusi'm just brainstorming.  globbing might be easy/simple/consistent with aws driver.  but re2 would be more consistent with rest of zuul.  i don't have a strong preference.17:41
*** bhavikdbavishi has quit IRC17:49
*** jcapitao_afk has quit IRC18:11
*** jcapitao has joined #zuul18:18
*** hashar is now known as hashardinner18:39
*** jcapitao has quit IRC18:41
*** sshnaidm is now known as sshnaidm|afk18:44
*** wuchunyang has joined #zuul20:13
*** wuchunyang has quit IRC20:17
*** hashardinner is now known as hashar20:38
*** nils has quit IRC21:21
*** hashar has quit IRC21:27
*** hamalq has quit IRC22:11
*** rlandy has quit IRC22:25
*** tosky has quit IRC23:55
*** rfolco has quit IRC23:55

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!